@multiplatform.one/backoffice 7.86.0 → 7.87.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/cjs/form/FormConnections.cjs +4 -14
- package/dist/cjs/form/FormConnections.native.js +4 -14
- package/dist/cjs/form/FormConnections.native.js.map +1 -1
- package/dist/esm/form/FormConnections.mjs +6 -16
- package/dist/esm/form/FormConnections.mjs.map +1 -1
- package/dist/esm/form/FormConnections.native.js +6 -16
- package/dist/esm/form/FormConnections.native.js.map +1 -1
- package/dist/jsx/form/FormConnections.mjs +6 -16
- package/dist/jsx/form/FormConnections.mjs.map +1 -1
- package/dist/jsx/form/FormConnections.native.js +4 -14
- package/dist/jsx/form/FormConnections.native.js.map +1 -1
- package/package.json +12 -12
- package/src/form/FormConnections.screen.spec.tsx +11 -0
- package/src/form/FormConnections.tsx +8 -9
- package/src/formBuilder/FieldPropertiesPanel.spec.tsx +216 -0
- package/src/formBuilder/FormBuilderCanvas.spec.tsx +217 -0
- package/src/formBuilder/FormBuilderScreen.screen.spec.tsx +55 -0
- package/src/formBuilder/useFormBuilderDrag.spec.tsx +183 -0
- package/types/form/FormConnections.d.ts.map +1 -1
|
@@ -108,6 +108,17 @@ describe("FormConnections", () => {
|
|
|
108
108
|
expect(row("Blogger").textContent).toBe("Blogger");
|
|
109
109
|
});
|
|
110
110
|
|
|
111
|
+
it("lays one group card per MPO card-grid cell (LC-179)", async () => {
|
|
112
|
+
renderConnections();
|
|
113
|
+
await waitFor(() => expect(within(row("Contact")).getByText("3")).toBeTruthy());
|
|
114
|
+
const grid = screen.getByText("Profile").closest("[data-card-grid]");
|
|
115
|
+
expect(grid).toBeTruthy();
|
|
116
|
+
expect(grid?.querySelectorAll("[data-card-grid-cell]").length).toBe(4);
|
|
117
|
+
for (const heading of ["Profile", "Logs", "Reference", "Billing"]) {
|
|
118
|
+
expect(screen.getByText(heading).closest("[data-card-grid-cell]")).toBeTruthy();
|
|
119
|
+
}
|
|
120
|
+
});
|
|
121
|
+
|
|
111
122
|
it("opens the target list filtered to this document", async () => {
|
|
112
123
|
const navigation = renderConnections();
|
|
113
124
|
await waitFor(() => expect(within(row("Contact")).getByText("3")).toBeTruthy());
|
|
@@ -4,15 +4,15 @@
|
|
|
4
4
|
import {
|
|
5
5
|
Button,
|
|
6
6
|
Card,
|
|
7
|
+
CardGrid,
|
|
7
8
|
Chip,
|
|
8
9
|
EmptyState,
|
|
9
10
|
ListGroup,
|
|
10
11
|
ListGroupItem,
|
|
11
12
|
ListRow,
|
|
12
13
|
Skeleton,
|
|
13
|
-
XStack,
|
|
14
14
|
} from "@multiplatform.one/components";
|
|
15
|
-
import { sizeRecipeEscape
|
|
15
|
+
import { sizeRecipeEscape } from "@multiplatform.one/theme";
|
|
16
16
|
import { PlusIcon } from "@phosphor-icons/react";
|
|
17
17
|
import { useMemo } from "react";
|
|
18
18
|
import { useTranslation } from "react-i18next";
|
|
@@ -128,7 +128,7 @@ interface ConnectionGroupCardProps {
|
|
|
128
128
|
function ConnectionGroupCard({ group, docname, counts, countsLoading }: ConnectionGroupCardProps) {
|
|
129
129
|
const { t } = useTranslation(BACKOFFICE_I18N_NAMESPACE);
|
|
130
130
|
return (
|
|
131
|
-
<Card
|
|
131
|
+
<Card flexGrow={1}>
|
|
132
132
|
<Card.Header>{group.label || t("connections.referenceGroup", "Reference")}</Card.Header>
|
|
133
133
|
<ListGroup variant="plain">
|
|
134
134
|
{group.links.map((link) => (
|
|
@@ -156,7 +156,7 @@ function ConnectionsSkeleton() {
|
|
|
156
156
|
/>
|
|
157
157
|
);
|
|
158
158
|
return (
|
|
159
|
-
<Card
|
|
159
|
+
<Card flexGrow={1}>
|
|
160
160
|
{bone(
|
|
161
161
|
sizeRecipeEscape(120, "loading bones sized to the connection card rows they stand in for"),
|
|
162
162
|
18,
|
|
@@ -170,7 +170,6 @@ function ConnectionsSkeleton() {
|
|
|
170
170
|
|
|
171
171
|
export function FormConnections({ doctype, name, meta: metaProp }: FormConnectionsProps) {
|
|
172
172
|
const { t } = useTranslation(BACKOFFICE_I18N_NAMESPACE);
|
|
173
|
-
const { knobProps } = useResolvedKnobs();
|
|
174
173
|
// form-core usually passes meta; fetch it only when it didn't.
|
|
175
174
|
const {
|
|
176
175
|
meta: loadedMeta,
|
|
@@ -185,10 +184,10 @@ export function FormConnections({ doctype, name, meta: metaProp }: FormConnectio
|
|
|
185
184
|
if (!meta) {
|
|
186
185
|
if (metaLoading) {
|
|
187
186
|
return (
|
|
188
|
-
<
|
|
187
|
+
<CardGrid minCardWidth="sm">
|
|
189
188
|
<ConnectionsSkeleton />
|
|
190
189
|
<ConnectionsSkeleton />
|
|
191
|
-
</
|
|
190
|
+
</CardGrid>
|
|
192
191
|
);
|
|
193
192
|
}
|
|
194
193
|
return (
|
|
@@ -215,7 +214,7 @@ export function FormConnections({ doctype, name, meta: metaProp }: FormConnectio
|
|
|
215
214
|
}
|
|
216
215
|
|
|
217
216
|
return (
|
|
218
|
-
<
|
|
217
|
+
<CardGrid minCardWidth="sm">
|
|
219
218
|
{groups.map((group) => (
|
|
220
219
|
<ConnectionGroupCard
|
|
221
220
|
key={group.label ?? ""}
|
|
@@ -225,6 +224,6 @@ export function FormConnections({ doctype, name, meta: metaProp }: FormConnectio
|
|
|
225
224
|
countsLoading={countsLoading}
|
|
226
225
|
/>
|
|
227
226
|
))}
|
|
228
|
-
</
|
|
227
|
+
</CardGrid>
|
|
229
228
|
);
|
|
230
229
|
}
|
|
@@ -0,0 +1,216 @@
|
|
|
1
|
+
import { renderWithProviders } from "@multiplatform.one/test-utils";
|
|
2
|
+
import { cleanup, fireEvent, screen, within } from "@testing-library/react";
|
|
3
|
+
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
4
|
+
import { FieldPropertiesPanel, type BuilderErrors } from "./FieldPropertiesPanel";
|
|
5
|
+
import {
|
|
6
|
+
fieldsFromLayout,
|
|
7
|
+
findField,
|
|
8
|
+
layoutFromFields,
|
|
9
|
+
type BuilderDocField,
|
|
10
|
+
type BuilderLayout,
|
|
11
|
+
type FormBuilderMode,
|
|
12
|
+
} from "./model";
|
|
13
|
+
|
|
14
|
+
afterEach(cleanup);
|
|
15
|
+
|
|
16
|
+
const fields: BuilderDocField[] = [
|
|
17
|
+
{ fieldname: "main_tab", fieldtype: "Tab Break", label: "Main" },
|
|
18
|
+
{ fieldname: "title", fieldtype: "Data", label: "Title" },
|
|
19
|
+
{ fieldname: "kind", fieldtype: "Select", label: "Kind", options: "a\nb" },
|
|
20
|
+
{ fieldname: "details_section", fieldtype: "Section Break", label: "Details" },
|
|
21
|
+
{ fieldname: "notes", fieldtype: "Data", label: "Notes" },
|
|
22
|
+
{ fieldname: "notes_break", fieldtype: "Column Break" },
|
|
23
|
+
{ fieldname: "more", fieldtype: "Data", label: "More" },
|
|
24
|
+
{ fieldname: "extra_tab", fieldtype: "Tab Break", label: "Extra" },
|
|
25
|
+
{ fieldname: "extra", fieldtype: "Data", label: "" },
|
|
26
|
+
] as BuilderDocField[];
|
|
27
|
+
|
|
28
|
+
const seed = () => layoutFromFields(fields);
|
|
29
|
+
const fieldKey = (layout: BuilderLayout, name: string) =>
|
|
30
|
+
layout.tabs
|
|
31
|
+
.flatMap((t) => t.sections.flatMap((s) => s.columns.flatMap((c) => c.fields)))
|
|
32
|
+
.find((f) => f.df.fieldname === name)!.key;
|
|
33
|
+
|
|
34
|
+
function renderPanel({
|
|
35
|
+
layout = seed(),
|
|
36
|
+
selection,
|
|
37
|
+
mode = "doctype" as FormBuilderMode,
|
|
38
|
+
errors = {} as BuilderErrors,
|
|
39
|
+
}: {
|
|
40
|
+
layout?: BuilderLayout;
|
|
41
|
+
selection?: string;
|
|
42
|
+
mode?: FormBuilderMode;
|
|
43
|
+
errors?: BuilderErrors;
|
|
44
|
+
} = {}) {
|
|
45
|
+
const onChange = vi.fn<(next: BuilderLayout) => void>();
|
|
46
|
+
renderWithProviders(
|
|
47
|
+
<FieldPropertiesPanel
|
|
48
|
+
layout={layout}
|
|
49
|
+
selection={selection}
|
|
50
|
+
mode={mode}
|
|
51
|
+
errors={errors}
|
|
52
|
+
onChange={onChange}
|
|
53
|
+
/>,
|
|
54
|
+
);
|
|
55
|
+
const next = () => onChange.mock.lastCall![0];
|
|
56
|
+
return { layout, onChange, next };
|
|
57
|
+
}
|
|
58
|
+
|
|
59
|
+
const deleteThroughDialog = async () => {
|
|
60
|
+
fireEvent.click(screen.getByRole("button", { name: "Delete" }));
|
|
61
|
+
const dialog = await screen.findByRole("alertdialog");
|
|
62
|
+
fireEvent.click(within(dialog).getByRole("button", { name: "Delete" }));
|
|
63
|
+
};
|
|
64
|
+
|
|
65
|
+
describe("FieldPropertiesPanel", () => {
|
|
66
|
+
it("asks for a selection when nothing is selected", () => {
|
|
67
|
+
renderPanel();
|
|
68
|
+
expect(screen.getByText("Select a field to edit its properties")).toBeTruthy();
|
|
69
|
+
expect(screen.queryByTestId("form-builder-properties")).toBeNull();
|
|
70
|
+
});
|
|
71
|
+
|
|
72
|
+
it("asks for a selection when the selected key is gone", () => {
|
|
73
|
+
renderPanel({ selection: "builder_999" });
|
|
74
|
+
expect(screen.getByText("Select a field to edit its properties")).toBeTruthy();
|
|
75
|
+
});
|
|
76
|
+
|
|
77
|
+
it("titles a field by its label and fieldname and edits its label", () => {
|
|
78
|
+
const layout = seed();
|
|
79
|
+
const key = fieldKey(layout, "title");
|
|
80
|
+
const { next } = renderPanel({ layout, selection: key });
|
|
81
|
+
const panel = screen.getByTestId("form-builder-properties");
|
|
82
|
+
expect(within(panel).getByText("Field properties")).toBeTruthy();
|
|
83
|
+
expect(within(panel).getAllByText("title").length).toBeGreaterThan(0);
|
|
84
|
+
fireEvent.change(screen.getByLabelText("Label"), { target: { value: "Name" } });
|
|
85
|
+
expect(findField(next(), key)!.df.label).toBe("Name");
|
|
86
|
+
});
|
|
87
|
+
|
|
88
|
+
it("titles an unlabelled field by its fieldname", () => {
|
|
89
|
+
const layout = seed();
|
|
90
|
+
renderPanel({ layout, selection: fieldKey(layout, "extra") });
|
|
91
|
+
expect(screen.getAllByText("extra").length).toBeGreaterThanOrEqual(2);
|
|
92
|
+
});
|
|
93
|
+
|
|
94
|
+
it("locks the fieldname of a saved field and frees it on a new one", () => {
|
|
95
|
+
const layout = seed();
|
|
96
|
+
const key = fieldKey(layout, "title");
|
|
97
|
+
renderPanel({ layout, selection: key });
|
|
98
|
+
expect((screen.getByLabelText("Fieldname") as HTMLInputElement).readOnly).toBe(true);
|
|
99
|
+
cleanup();
|
|
100
|
+
findField(layout, key)!.isNew = true;
|
|
101
|
+
const { next } = renderPanel({ layout, selection: key });
|
|
102
|
+
const fieldname = screen.getByLabelText("Fieldname") as HTMLInputElement;
|
|
103
|
+
expect(fieldname.readOnly).toBe(false);
|
|
104
|
+
fireEvent.change(fieldname, { target: { value: "headline" } });
|
|
105
|
+
expect(findField(next(), key)!.df.fieldname).toBe("headline");
|
|
106
|
+
});
|
|
107
|
+
|
|
108
|
+
it("offers Options with a hint on a Select and edits them", () => {
|
|
109
|
+
const layout = seed();
|
|
110
|
+
const key = fieldKey(layout, "kind");
|
|
111
|
+
const { next } = renderPanel({ layout, selection: key });
|
|
112
|
+
const options = screen.getByLabelText("Options") as HTMLTextAreaElement;
|
|
113
|
+
expect(options.value).toBe("a\nb");
|
|
114
|
+
fireEvent.change(options, { target: { value: "a\nb\nc" } });
|
|
115
|
+
expect(findField(next(), key)!.df.options).toBe("a\nb\nc");
|
|
116
|
+
});
|
|
117
|
+
|
|
118
|
+
it("edits a value field's Default and Description", () => {
|
|
119
|
+
const layout = seed();
|
|
120
|
+
const key = fieldKey(layout, "title");
|
|
121
|
+
const { next } = renderPanel({ layout, selection: key });
|
|
122
|
+
fireEvent.change(screen.getByLabelText("Default"), { target: { value: "Untitled" } });
|
|
123
|
+
expect(findField(next(), key)!.df.default).toBe("Untitled");
|
|
124
|
+
fireEvent.change(screen.getByLabelText("Description"), { target: { value: "Shown" } });
|
|
125
|
+
expect(findField(next(), key)!.df.description).toBe("Shown");
|
|
126
|
+
});
|
|
127
|
+
|
|
128
|
+
it.each([
|
|
129
|
+
["Mandatory", "reqd"],
|
|
130
|
+
["Read Only", "read_only"],
|
|
131
|
+
["In List View", "in_list_view"],
|
|
132
|
+
["Hidden", "hidden"],
|
|
133
|
+
] as const)("%s sets %s to 1", (label, prop) => {
|
|
134
|
+
const layout = seed();
|
|
135
|
+
const key = fieldKey(layout, "title");
|
|
136
|
+
const { next } = renderPanel({ layout, selection: key });
|
|
137
|
+
fireEvent.click(screen.getByRole("checkbox", { name: label }));
|
|
138
|
+
expect(findField(next(), key)!.df[prop]).toBe(1);
|
|
139
|
+
});
|
|
140
|
+
|
|
141
|
+
it("shows a field's errors under its inputs", () => {
|
|
142
|
+
const layout = seed();
|
|
143
|
+
const key = fieldKey(layout, "title");
|
|
144
|
+
renderPanel({
|
|
145
|
+
layout,
|
|
146
|
+
selection: key,
|
|
147
|
+
errors: { [key]: { label: "Label is required", fieldname: "Fieldname is taken" } },
|
|
148
|
+
});
|
|
149
|
+
expect(screen.getByText("Label is required")).toBeTruthy();
|
|
150
|
+
expect(screen.getByText("Fieldname is taken")).toBeTruthy();
|
|
151
|
+
});
|
|
152
|
+
|
|
153
|
+
it("deletes a field in doctype mode after the confirm", async () => {
|
|
154
|
+
const layout = seed();
|
|
155
|
+
const { next } = renderPanel({ layout, selection: fieldKey(layout, "title") });
|
|
156
|
+
await deleteThroughDialog();
|
|
157
|
+
expect(fieldsFromLayout(next()).map((df) => df.fieldname)).not.toContain("title");
|
|
158
|
+
});
|
|
159
|
+
|
|
160
|
+
it("hides a standard field in customize mode instead of deleting it", () => {
|
|
161
|
+
const layout = seed();
|
|
162
|
+
const key = fieldKey(layout, "title");
|
|
163
|
+
const { next } = renderPanel({ layout, selection: key, mode: "customize" });
|
|
164
|
+
expect(screen.queryByRole("button", { name: "Delete" })).toBeNull();
|
|
165
|
+
fireEvent.click(screen.getByRole("button", { name: "Hide" }));
|
|
166
|
+
expect(findField(next(), key)!.df.hidden).toBe(1);
|
|
167
|
+
});
|
|
168
|
+
|
|
169
|
+
it("edits a tab's label and removes the tab when there is another", async () => {
|
|
170
|
+
const layout = seed();
|
|
171
|
+
const tab = layout.tabs[1];
|
|
172
|
+
const { next } = renderPanel({ layout, selection: tab.key });
|
|
173
|
+
expect(screen.getByText("Tab properties")).toBeTruthy();
|
|
174
|
+
expect(screen.queryByLabelText("Fieldname")).toBeNull();
|
|
175
|
+
fireEvent.change(screen.getByLabelText("Label"), { target: { value: "Bonus" } });
|
|
176
|
+
expect(next().tabs[1].df!.label).toBe("Bonus");
|
|
177
|
+
await deleteThroughDialog();
|
|
178
|
+
expect(next().tabs).toHaveLength(1);
|
|
179
|
+
});
|
|
180
|
+
|
|
181
|
+
it("keeps the only tab", () => {
|
|
182
|
+
const layout = layoutFromFields(fields.slice(0, 3));
|
|
183
|
+
renderPanel({ layout, selection: layout.tabs[0].key });
|
|
184
|
+
expect(screen.getByText("Tab properties")).toBeTruthy();
|
|
185
|
+
expect(screen.queryByRole("button", { name: "Delete" })).toBeNull();
|
|
186
|
+
});
|
|
187
|
+
|
|
188
|
+
it("edits a section and removes it into its neighbour", async () => {
|
|
189
|
+
const layout = seed();
|
|
190
|
+
const section = layout.tabs[0].sections[1];
|
|
191
|
+
const { next } = renderPanel({
|
|
192
|
+
layout,
|
|
193
|
+
selection: section.key,
|
|
194
|
+
errors: { [section.key]: { fieldname: "Duplicate break" } },
|
|
195
|
+
});
|
|
196
|
+
expect(screen.getByText("Section properties")).toBeTruthy();
|
|
197
|
+
expect(screen.getByText("Duplicate break")).toBeTruthy();
|
|
198
|
+
await deleteThroughDialog();
|
|
199
|
+
expect(next().tabs[0].sections).toHaveLength(1);
|
|
200
|
+
expect(fieldsFromLayout(next()).map((df) => df.fieldname)).toContain("notes");
|
|
201
|
+
});
|
|
202
|
+
|
|
203
|
+
it("removes a column only when its section has another", async () => {
|
|
204
|
+
const layout = seed();
|
|
205
|
+
const [first, second] = layout.tabs[0].sections[1].columns;
|
|
206
|
+
const { next } = renderPanel({ layout, selection: second.key });
|
|
207
|
+
expect(screen.getByText("Column properties")).toBeTruthy();
|
|
208
|
+
await deleteThroughDialog();
|
|
209
|
+
expect(next().tabs[0].sections[1].columns.map((c) => c.key)).toEqual([first.key]);
|
|
210
|
+
cleanup();
|
|
211
|
+
const lone = layout.tabs[0].sections[0].columns[0];
|
|
212
|
+
renderPanel({ layout, selection: lone.key });
|
|
213
|
+
expect(screen.getByText("Column properties")).toBeTruthy();
|
|
214
|
+
expect(screen.queryByRole("button", { name: "Delete" })).toBeNull();
|
|
215
|
+
});
|
|
216
|
+
});
|
|
@@ -0,0 +1,217 @@
|
|
|
1
|
+
import { renderWithProviders } from "@multiplatform.one/test-utils";
|
|
2
|
+
import { cleanup, fireEvent, screen, waitFor, within } from "@testing-library/react";
|
|
3
|
+
import { useState } from "react";
|
|
4
|
+
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
5
|
+
import { FormBuilderCanvas } from "./FormBuilderCanvas";
|
|
6
|
+
import {
|
|
7
|
+
fieldsFromLayout,
|
|
8
|
+
findField,
|
|
9
|
+
layoutFromFields,
|
|
10
|
+
type BuilderDocField,
|
|
11
|
+
type BuilderLayout,
|
|
12
|
+
type FormBuilderMode,
|
|
13
|
+
} from "./model";
|
|
14
|
+
import { useFormBuilderDrag } from "./useFormBuilderDrag";
|
|
15
|
+
|
|
16
|
+
afterEach(cleanup);
|
|
17
|
+
|
|
18
|
+
const fields = [
|
|
19
|
+
{ fieldname: "title", fieldtype: "Data", label: "Title" },
|
|
20
|
+
{ fieldname: "kind", fieldtype: "Data", label: "Kind" },
|
|
21
|
+
{ fieldname: "stats_section", fieldtype: "Section Break", label: "Stats" },
|
|
22
|
+
{ fieldname: "hp", fieldtype: "Int", label: "HP" },
|
|
23
|
+
{ fieldname: "stats_column", fieldtype: "Column Break" },
|
|
24
|
+
{ fieldname: "speed", fieldtype: "Int", label: "Speed" },
|
|
25
|
+
] as BuilderDocField[];
|
|
26
|
+
|
|
27
|
+
function renderCanvas({
|
|
28
|
+
mode = "doctype" as FormBuilderMode,
|
|
29
|
+
initial = layoutFromFields(fields),
|
|
30
|
+
selection,
|
|
31
|
+
}: { mode?: FormBuilderMode; initial?: BuilderLayout; selection?: string } = {}) {
|
|
32
|
+
const onTab = vi.fn();
|
|
33
|
+
const onSelect = vi.fn();
|
|
34
|
+
const onAdd = vi.fn();
|
|
35
|
+
const seen: { layout: BuilderLayout } = { layout: initial };
|
|
36
|
+
function Host() {
|
|
37
|
+
const [layout, setLayout] = useState(initial);
|
|
38
|
+
const [tab, setTab] = useState(initial.tabs[0].key);
|
|
39
|
+
seen.layout = layout;
|
|
40
|
+
const onChange = (next: BuilderLayout) => setLayout(next);
|
|
41
|
+
const drag = useFormBuilderDrag({ layout, tabKey: tab, onChange, onSelect });
|
|
42
|
+
return (
|
|
43
|
+
<FormBuilderCanvas
|
|
44
|
+
layout={layout}
|
|
45
|
+
activeTab={tab}
|
|
46
|
+
selection={selection}
|
|
47
|
+
stacked={false}
|
|
48
|
+
mode={mode}
|
|
49
|
+
errors={{}}
|
|
50
|
+
drag={drag}
|
|
51
|
+
onChange={onChange}
|
|
52
|
+
onTab={(key) => {
|
|
53
|
+
onTab(key);
|
|
54
|
+
setTab(key);
|
|
55
|
+
}}
|
|
56
|
+
onSelect={onSelect}
|
|
57
|
+
onAdd={onAdd}
|
|
58
|
+
/>
|
|
59
|
+
);
|
|
60
|
+
}
|
|
61
|
+
renderWithProviders(<Host />);
|
|
62
|
+
const names = () =>
|
|
63
|
+
fieldsFromLayout(seen.layout)
|
|
64
|
+
.filter((df) => !df.fieldtype.endsWith("Break"))
|
|
65
|
+
.map((df) => df.fieldname);
|
|
66
|
+
return { seen, names, onTab, onSelect, onAdd };
|
|
67
|
+
}
|
|
68
|
+
|
|
69
|
+
const sectionMenu = { Untitled: 0, Stats: 1 } as const;
|
|
70
|
+
|
|
71
|
+
function menuButton(menu: string) {
|
|
72
|
+
const [kind, name] = menu.startsWith("Menu for section ")
|
|
73
|
+
? ([
|
|
74
|
+
"Menu for section {{section}}",
|
|
75
|
+
sectionMenu[menu.slice(17).split(" ")[0] as "Stats"],
|
|
76
|
+
] as const)
|
|
77
|
+
: (["Menu for {{field}}", menu.slice(9).toLowerCase()] as const);
|
|
78
|
+
if (typeof name === "string") {
|
|
79
|
+
const card = document.querySelector<HTMLElement>(`[data-fb-fieldname="${name}"]`)!;
|
|
80
|
+
return within(card).getByRole("button", { name: kind });
|
|
81
|
+
}
|
|
82
|
+
return screen.getAllByRole("button", { name: kind })[name];
|
|
83
|
+
}
|
|
84
|
+
|
|
85
|
+
async function pick(menu: string, item: string) {
|
|
86
|
+
fireEvent.click(menuButton(menu));
|
|
87
|
+
fireEvent.click(await screen.findByRole("menuitem", { name: item }));
|
|
88
|
+
}
|
|
89
|
+
|
|
90
|
+
const fieldKey = (layout: BuilderLayout, name: string) =>
|
|
91
|
+
layout.tabs
|
|
92
|
+
.flatMap((t) => t.sections.flatMap((s) => s.columns.flatMap((c) => c.fields)))
|
|
93
|
+
.find((f) => f.df.fieldname === name)!.key;
|
|
94
|
+
|
|
95
|
+
describe("FormBuilderCanvas toolbar", () => {
|
|
96
|
+
it("adds a tab, opens it and selects it", () => {
|
|
97
|
+
const { seen, onTab, onSelect } = renderCanvas();
|
|
98
|
+
fireEvent.click(screen.getByRole("button", { name: "Add tab" }));
|
|
99
|
+
expect(seen.layout.tabs).toHaveLength(2);
|
|
100
|
+
const added = seen.layout.tabs[1].key;
|
|
101
|
+
expect(onTab).toHaveBeenLastCalledWith(added);
|
|
102
|
+
expect(onSelect).toHaveBeenLastCalledWith(added);
|
|
103
|
+
});
|
|
104
|
+
|
|
105
|
+
it("opens the tab's properties", () => {
|
|
106
|
+
const { seen, onSelect } = renderCanvas();
|
|
107
|
+
fireEvent.click(screen.getByRole("button", { name: "Tab properties" }));
|
|
108
|
+
expect(onSelect).toHaveBeenLastCalledWith(seen.layout.tabs[0].key);
|
|
109
|
+
});
|
|
110
|
+
|
|
111
|
+
it("adds a section at the end of the tab and selects it", () => {
|
|
112
|
+
const { seen, onSelect } = renderCanvas();
|
|
113
|
+
fireEvent.click(screen.getByRole("button", { name: "Add section" }));
|
|
114
|
+
const sections = seen.layout.tabs[0].sections;
|
|
115
|
+
expect(sections).toHaveLength(3);
|
|
116
|
+
expect(onSelect).toHaveBeenLastCalledWith(sections[2].key);
|
|
117
|
+
});
|
|
118
|
+
|
|
119
|
+
it("offers Add field on an empty form", () => {
|
|
120
|
+
const { onAdd } = renderCanvas({ initial: layoutFromFields([]) });
|
|
121
|
+
expect(screen.getByText("This form has no fields")).toBeTruthy();
|
|
122
|
+
fireEvent.click(screen.getByRole("button", { name: "Add field" }));
|
|
123
|
+
expect(onAdd).toHaveBeenCalled();
|
|
124
|
+
});
|
|
125
|
+
});
|
|
126
|
+
|
|
127
|
+
describe("FormBuilderCanvas section menu", () => {
|
|
128
|
+
it("adds a column to the section", async () => {
|
|
129
|
+
const { seen } = renderCanvas();
|
|
130
|
+
await pick("Menu for section Stats", "Add column");
|
|
131
|
+
expect(seen.layout.tabs[0].sections[1].columns).toHaveLength(3);
|
|
132
|
+
});
|
|
133
|
+
|
|
134
|
+
it("removes the last column, keeping its fields in the section", async () => {
|
|
135
|
+
const { seen, names } = renderCanvas();
|
|
136
|
+
await pick("Menu for section Stats", "Remove column");
|
|
137
|
+
expect(seen.layout.tabs[0].sections[1].columns).toHaveLength(1);
|
|
138
|
+
expect(names()).toEqual(["title", "kind", "hp", "speed"]);
|
|
139
|
+
});
|
|
140
|
+
|
|
141
|
+
it("removes the selected column rather than the last", async () => {
|
|
142
|
+
const initial = layoutFromFields(fields);
|
|
143
|
+
const [first, second] = initial.tabs[0].sections[1].columns;
|
|
144
|
+
const { seen } = renderCanvas({ initial, selection: first.key });
|
|
145
|
+
await pick("Menu for section Stats", "Remove column");
|
|
146
|
+
expect(seen.layout.tabs[0].sections[1].columns.map((c) => c.key)).toEqual([second.key]);
|
|
147
|
+
});
|
|
148
|
+
|
|
149
|
+
it("offers no Remove column on a one-column section", async () => {
|
|
150
|
+
renderCanvas();
|
|
151
|
+
fireEvent.click(menuButton("Menu for section Untitled section"));
|
|
152
|
+
await screen.findByRole("menuitem", { name: "Add column" });
|
|
153
|
+
expect(screen.queryByRole("menuitem", { name: "Remove column" })).toBeNull();
|
|
154
|
+
});
|
|
155
|
+
|
|
156
|
+
it("adds a section below and removes a section into its neighbour", async () => {
|
|
157
|
+
const { seen, names } = renderCanvas();
|
|
158
|
+
await pick("Menu for section Untitled section", "Add section below");
|
|
159
|
+
expect(seen.layout.tabs[0].sections).toHaveLength(3);
|
|
160
|
+
expect(seen.layout.tabs[0].sections[2].df?.label).toBe("Stats");
|
|
161
|
+
await pick("Menu for section Stats", "Remove section");
|
|
162
|
+
expect(seen.layout.tabs[0].sections).toHaveLength(2);
|
|
163
|
+
expect(names()).toEqual(["title", "kind", "hp", "speed"]);
|
|
164
|
+
});
|
|
165
|
+
|
|
166
|
+
it("keeps the only section of the only tab", async () => {
|
|
167
|
+
renderCanvas({ initial: layoutFromFields(fields.slice(0, 2)) });
|
|
168
|
+
fireEvent.click(menuButton("Menu for section Untitled section"));
|
|
169
|
+
await screen.findByRole("menuitem", { name: "Add section below" });
|
|
170
|
+
expect(screen.queryByRole("menuitem", { name: "Remove section" })).toBeNull();
|
|
171
|
+
});
|
|
172
|
+
});
|
|
173
|
+
|
|
174
|
+
describe("FormBuilderCanvas field cards", () => {
|
|
175
|
+
it("selects a field from its card and from Edit properties", async () => {
|
|
176
|
+
const { seen, onSelect } = renderCanvas();
|
|
177
|
+
const key = fieldKey(seen.layout, "kind");
|
|
178
|
+
fireEvent.click(screen.getByText("Kind"));
|
|
179
|
+
expect(onSelect).toHaveBeenLastCalledWith(key);
|
|
180
|
+
onSelect.mockClear();
|
|
181
|
+
await pick("Menu for Title", "Edit properties");
|
|
182
|
+
expect(onSelect).toHaveBeenLastCalledWith(fieldKey(seen.layout, "title"));
|
|
183
|
+
});
|
|
184
|
+
|
|
185
|
+
it("moves a field down and back up", async () => {
|
|
186
|
+
const { names } = renderCanvas();
|
|
187
|
+
await pick("Menu for Title", "Move down");
|
|
188
|
+
expect(names().slice(0, 2)).toEqual(["kind", "title"]);
|
|
189
|
+
await pick("Menu for Title", "Move up");
|
|
190
|
+
expect(names().slice(0, 2)).toEqual(["title", "kind"]);
|
|
191
|
+
});
|
|
192
|
+
|
|
193
|
+
it("deletes a field in doctype mode only after the confirm", async () => {
|
|
194
|
+
const { names } = renderCanvas();
|
|
195
|
+
await pick("Menu for Kind", "Delete");
|
|
196
|
+
const dialog = await screen.findByRole("alertdialog");
|
|
197
|
+
expect(names()).toContain("kind");
|
|
198
|
+
fireEvent.click(within(dialog).getByRole("button", { name: "Delete" }));
|
|
199
|
+
await waitFor(() => expect(names()).not.toContain("kind"));
|
|
200
|
+
});
|
|
201
|
+
|
|
202
|
+
it("keeps the field when the delete is cancelled", async () => {
|
|
203
|
+
const { names } = renderCanvas();
|
|
204
|
+
await pick("Menu for Kind", "Delete");
|
|
205
|
+
const dialog = await screen.findByRole("alertdialog");
|
|
206
|
+
fireEvent.click(within(dialog).getByRole("button", { name: "Cancel" }));
|
|
207
|
+
await waitFor(() => expect(screen.queryByRole("alertdialog")).toBeNull());
|
|
208
|
+
expect(names()).toContain("kind");
|
|
209
|
+
});
|
|
210
|
+
|
|
211
|
+
it("hides a standard field in customize mode and marks its card", async () => {
|
|
212
|
+
const { seen } = renderCanvas({ mode: "customize" });
|
|
213
|
+
await pick("Menu for Kind", "Hide");
|
|
214
|
+
expect(findField(seen.layout, fieldKey(seen.layout, "kind"))!.df.hidden).toBe(1);
|
|
215
|
+
expect(screen.getByText("Hidden")).toBeTruthy();
|
|
216
|
+
});
|
|
217
|
+
});
|
|
@@ -391,4 +391,59 @@ describe("FormBuilderScreen", { timeout: 90_000 }, () => {
|
|
|
391
391
|
"false",
|
|
392
392
|
);
|
|
393
393
|
});
|
|
394
|
+
|
|
395
|
+
it("asks before leaving with unsaved edits: Cancel keeps them, Discard follows the link", async () => {
|
|
396
|
+
const { navigator } = renderBuilder();
|
|
397
|
+
await addNickname();
|
|
398
|
+
const goToList = async () => {
|
|
399
|
+
fireEvent.click(screen.getByTestId("form-toolbar-menu"));
|
|
400
|
+
fireEvent.click(await screen.findByRole("menuitem", { name: /Go to Pokemon list/ }));
|
|
401
|
+
return screen.findByRole("alertdialog");
|
|
402
|
+
};
|
|
403
|
+
let dialog = await goToList();
|
|
404
|
+
expect(within(dialog).getByText("Discard unsaved changes?")).toBeTruthy();
|
|
405
|
+
fireEvent.click(within(dialog).getByRole("button", { name: "Cancel" }));
|
|
406
|
+
await waitFor(() => expect(screen.queryByRole("alertdialog")).toBeNull());
|
|
407
|
+
expect(input("Label")).toHaveValue("Nickname");
|
|
408
|
+
expect(navigator.getLocation().path).toBe("/backoffice/customize-form");
|
|
409
|
+
dialog = await goToList();
|
|
410
|
+
fireEvent.click(within(dialog).getByRole("button", { name: "Discard" }));
|
|
411
|
+
await waitFor(() => expect(navigator.getLocation().path).toBe("/backoffice/pokemon"));
|
|
412
|
+
});
|
|
413
|
+
|
|
414
|
+
it("goes straight to the list when nothing changed", async () => {
|
|
415
|
+
const { navigator } = renderBuilder();
|
|
416
|
+
await screen.findByRole("button", { name: "Menu for Sprite (Back)" });
|
|
417
|
+
fireEvent.click(screen.getByTestId("form-toolbar-menu"));
|
|
418
|
+
fireEvent.click(await screen.findByRole("menuitem", { name: /Go to Pokemon list/ }));
|
|
419
|
+
expect(screen.queryByRole("alertdialog")).toBeNull();
|
|
420
|
+
await waitFor(() => expect(navigator.getLocation().path).toBe("/backoffice/pokemon"));
|
|
421
|
+
});
|
|
422
|
+
|
|
423
|
+
it("reverts unsaved edits to the saved layout after the confirm", async () => {
|
|
424
|
+
const { reads } = renderBuilder();
|
|
425
|
+
await addNickname();
|
|
426
|
+
const before = reads.length;
|
|
427
|
+
fireEvent.click(screen.getByTestId("form-toolbar-menu"));
|
|
428
|
+
fireEvent.click(await screen.findByRole("menuitem", { name: /Revert to Saved/ }));
|
|
429
|
+
const dialog = await screen.findByRole("alertdialog");
|
|
430
|
+
fireEvent.click(within(dialog).getByRole("button", { name: "Discard" }));
|
|
431
|
+
await waitFor(() => expect(reads.length).toBeGreaterThan(before));
|
|
432
|
+
await waitFor(() =>
|
|
433
|
+
expect(document.querySelector('[data-fb-fieldname="nickname"]')).toBeNull(),
|
|
434
|
+
);
|
|
435
|
+
});
|
|
436
|
+
|
|
437
|
+
it("switches the phone sheet between properties and field types, and Escape clears it", async () => {
|
|
438
|
+
viewport.size = "compact";
|
|
439
|
+
renderBuilder();
|
|
440
|
+
fireEvent.click(await screen.findByRole("button", { name: "Field properties" }));
|
|
441
|
+
expect(await screen.findByText("Select a field to edit its properties")).toBeTruthy();
|
|
442
|
+
fireEvent.click(screen.getByRole("button", { name: "Field types" }));
|
|
443
|
+
expect(await screen.findByRole("button", { name: "Add Data field" })).toBeTruthy();
|
|
444
|
+
fireEvent.keyDown(document, { key: "Escape" });
|
|
445
|
+
await waitFor(() =>
|
|
446
|
+
expect(screen.queryByRole("button", { name: "Add Data field" })).toBeNull(),
|
|
447
|
+
);
|
|
448
|
+
});
|
|
394
449
|
});
|