@multiplatform.one/backoffice 7.83.1 → 7.84.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (173) hide show
  1. package/dist/cjs/chrome/HelpMenu.cjs +11 -0
  2. package/dist/cjs/chrome/HelpMenu.native.js +11 -0
  3. package/dist/cjs/chrome/HelpMenu.native.js.map +1 -1
  4. package/dist/cjs/chrome/UserMenu.cjs +1 -1
  5. package/dist/cjs/chrome/UserMenu.native.js +1 -1
  6. package/dist/cjs/chrome/UserMenu.native.js.map +1 -1
  7. package/dist/cjs/chrome/user-session.cjs +9 -0
  8. package/dist/cjs/chrome/user-session.native.js +9 -0
  9. package/dist/cjs/chrome/user-session.native.js.map +1 -1
  10. package/dist/cjs/form/FormToolbar.cjs +28 -24
  11. package/dist/cjs/form/FormToolbar.native.js +32 -28
  12. package/dist/cjs/form/FormToolbar.native.js.map +1 -1
  13. package/dist/cjs/index.cjs +1 -0
  14. package/dist/cjs/index.native.js +1 -0
  15. package/dist/cjs/index.native.js.map +1 -1
  16. package/dist/cjs/list/ListSidebar.cjs +2 -0
  17. package/dist/cjs/list/ListSidebar.native.js +4 -0
  18. package/dist/cjs/list/ListSidebar.native.js.map +1 -1
  19. package/dist/cjs/shared/sessionUser.cjs +11 -50
  20. package/dist/cjs/shared/sessionUser.native.js +11 -77
  21. package/dist/cjs/shared/sessionUser.native.js.map +1 -1
  22. package/dist/cjs/shared/useSlugTarget.cjs +8 -4
  23. package/dist/cjs/shared/useSlugTarget.native.js +8 -4
  24. package/dist/cjs/shared/useSlugTarget.native.js.map +1 -1
  25. package/dist/cjs/shell/BackofficeShell.cjs +2 -1
  26. package/dist/cjs/shell/BackofficeShell.native.js +2 -1
  27. package/dist/cjs/shell/BackofficeShell.native.js.map +1 -1
  28. package/dist/cjs/shell/WorkspaceSidebar.cjs +36 -2
  29. package/dist/cjs/shell/WorkspaceSidebar.native.js +40 -2
  30. package/dist/cjs/shell/WorkspaceSidebar.native.js.map +1 -1
  31. package/dist/cjs/views/ViewHeader.cjs +41 -12
  32. package/dist/cjs/views/ViewHeader.native.js +47 -16
  33. package/dist/cjs/views/ViewHeader.native.js.map +1 -1
  34. package/dist/cjs/views/viewMeta.cjs +4 -0
  35. package/dist/cjs/views/viewMeta.native.js +7 -0
  36. package/dist/cjs/views/viewMeta.native.js.map +1 -1
  37. package/dist/esm/chrome/HelpMenu.mjs +11 -1
  38. package/dist/esm/chrome/HelpMenu.mjs.map +1 -1
  39. package/dist/esm/chrome/HelpMenu.native.js +11 -1
  40. package/dist/esm/chrome/HelpMenu.native.js.map +1 -1
  41. package/dist/esm/chrome/UserMenu.mjs +1 -1
  42. package/dist/esm/chrome/UserMenu.mjs.map +1 -1
  43. package/dist/esm/chrome/UserMenu.native.js +1 -1
  44. package/dist/esm/chrome/UserMenu.native.js.map +1 -1
  45. package/dist/esm/chrome/user-session.mjs +9 -1
  46. package/dist/esm/chrome/user-session.mjs.map +1 -1
  47. package/dist/esm/chrome/user-session.native.js +9 -1
  48. package/dist/esm/chrome/user-session.native.js.map +1 -1
  49. package/dist/esm/form/FormToolbar.mjs +29 -25
  50. package/dist/esm/form/FormToolbar.mjs.map +1 -1
  51. package/dist/esm/form/FormToolbar.native.js +33 -29
  52. package/dist/esm/form/FormToolbar.native.js.map +1 -1
  53. package/dist/esm/index.mjs +2 -2
  54. package/dist/esm/index.mjs.map +1 -1
  55. package/dist/esm/index.native.js +2 -2
  56. package/dist/esm/index.native.js.map +1 -1
  57. package/dist/esm/list/ListSidebar.mjs +2 -0
  58. package/dist/esm/list/ListSidebar.mjs.map +1 -1
  59. package/dist/esm/list/ListSidebar.native.js +4 -0
  60. package/dist/esm/list/ListSidebar.native.js.map +1 -1
  61. package/dist/esm/shared/sessionUser.mjs +7 -46
  62. package/dist/esm/shared/sessionUser.mjs.map +1 -1
  63. package/dist/esm/shared/sessionUser.native.js +7 -73
  64. package/dist/esm/shared/sessionUser.native.js.map +1 -1
  65. package/dist/esm/shared/useSlugTarget.mjs +9 -5
  66. package/dist/esm/shared/useSlugTarget.mjs.map +1 -1
  67. package/dist/esm/shared/useSlugTarget.native.js +9 -5
  68. package/dist/esm/shared/useSlugTarget.native.js.map +1 -1
  69. package/dist/esm/shell/BackofficeShell.mjs +2 -1
  70. package/dist/esm/shell/BackofficeShell.mjs.map +1 -1
  71. package/dist/esm/shell/BackofficeShell.native.js +2 -1
  72. package/dist/esm/shell/BackofficeShell.native.js.map +1 -1
  73. package/dist/esm/shell/WorkspaceSidebar.mjs +37 -3
  74. package/dist/esm/shell/WorkspaceSidebar.mjs.map +1 -1
  75. package/dist/esm/shell/WorkspaceSidebar.native.js +41 -3
  76. package/dist/esm/shell/WorkspaceSidebar.native.js.map +1 -1
  77. package/dist/esm/views/ViewHeader.mjs +45 -16
  78. package/dist/esm/views/ViewHeader.mjs.map +1 -1
  79. package/dist/esm/views/ViewHeader.native.js +51 -20
  80. package/dist/esm/views/ViewHeader.native.js.map +1 -1
  81. package/dist/esm/views/viewMeta.mjs +4 -0
  82. package/dist/esm/views/viewMeta.mjs.map +1 -1
  83. package/dist/esm/views/viewMeta.native.js +7 -0
  84. package/dist/esm/views/viewMeta.native.js.map +1 -1
  85. package/dist/jsx/chrome/HelpMenu.mjs +11 -1
  86. package/dist/jsx/chrome/HelpMenu.mjs.map +1 -1
  87. package/dist/jsx/chrome/HelpMenu.native.js +11 -0
  88. package/dist/jsx/chrome/HelpMenu.native.js.map +1 -1
  89. package/dist/jsx/chrome/UserMenu.mjs +1 -1
  90. package/dist/jsx/chrome/UserMenu.mjs.map +1 -1
  91. package/dist/jsx/chrome/UserMenu.native.js +1 -1
  92. package/dist/jsx/chrome/UserMenu.native.js.map +1 -1
  93. package/dist/jsx/chrome/user-session.mjs +9 -1
  94. package/dist/jsx/chrome/user-session.mjs.map +1 -1
  95. package/dist/jsx/chrome/user-session.native.js +9 -0
  96. package/dist/jsx/chrome/user-session.native.js.map +1 -1
  97. package/dist/jsx/form/FormToolbar.mjs +29 -25
  98. package/dist/jsx/form/FormToolbar.mjs.map +1 -1
  99. package/dist/jsx/form/FormToolbar.native.js +32 -28
  100. package/dist/jsx/form/FormToolbar.native.js.map +1 -1
  101. package/dist/jsx/index.js +2 -2
  102. package/dist/jsx/index.js.map +1 -1
  103. package/dist/jsx/index.mjs +2 -2
  104. package/dist/jsx/index.mjs.map +1 -1
  105. package/dist/jsx/index.native.js +1 -0
  106. package/dist/jsx/index.native.js.map +1 -1
  107. package/dist/jsx/list/ListSidebar.mjs +2 -0
  108. package/dist/jsx/list/ListSidebar.mjs.map +1 -1
  109. package/dist/jsx/list/ListSidebar.native.js +4 -0
  110. package/dist/jsx/list/ListSidebar.native.js.map +1 -1
  111. package/dist/jsx/shared/sessionUser.mjs +7 -46
  112. package/dist/jsx/shared/sessionUser.mjs.map +1 -1
  113. package/dist/jsx/shared/sessionUser.native.js +11 -77
  114. package/dist/jsx/shared/sessionUser.native.js.map +1 -1
  115. package/dist/jsx/shared/useSlugTarget.mjs +9 -5
  116. package/dist/jsx/shared/useSlugTarget.mjs.map +1 -1
  117. package/dist/jsx/shared/useSlugTarget.native.js +8 -4
  118. package/dist/jsx/shared/useSlugTarget.native.js.map +1 -1
  119. package/dist/jsx/shell/BackofficeShell.mjs +2 -1
  120. package/dist/jsx/shell/BackofficeShell.mjs.map +1 -1
  121. package/dist/jsx/shell/BackofficeShell.native.js +2 -1
  122. package/dist/jsx/shell/BackofficeShell.native.js.map +1 -1
  123. package/dist/jsx/shell/WorkspaceSidebar.mjs +37 -3
  124. package/dist/jsx/shell/WorkspaceSidebar.mjs.map +1 -1
  125. package/dist/jsx/shell/WorkspaceSidebar.native.js +40 -2
  126. package/dist/jsx/shell/WorkspaceSidebar.native.js.map +1 -1
  127. package/dist/jsx/views/ViewHeader.mjs +45 -16
  128. package/dist/jsx/views/ViewHeader.mjs.map +1 -1
  129. package/dist/jsx/views/ViewHeader.native.js +47 -16
  130. package/dist/jsx/views/ViewHeader.native.js.map +1 -1
  131. package/dist/jsx/views/viewMeta.mjs +4 -0
  132. package/dist/jsx/views/viewMeta.mjs.map +1 -1
  133. package/dist/jsx/views/viewMeta.native.js +7 -0
  134. package/dist/jsx/views/viewMeta.native.js.map +1 -1
  135. package/package.json +12 -12
  136. package/src/chrome/HelpMenu.tsx +6 -0
  137. package/src/chrome/UserMenu.screen.spec.tsx +17 -0
  138. package/src/chrome/UserMenu.tsx +1 -1
  139. package/src/chrome/command-palette-model.spec.tsx +6 -1
  140. package/src/chrome/user-session.tsx +15 -0
  141. package/src/design/DeskPhoneBoard.stories.tsx +64 -114
  142. package/src/form/FormToolbar.screen.spec.tsx +34 -3
  143. package/src/form/FormToolbar.tsx +38 -27
  144. package/src/index.ts +1 -0
  145. package/src/list/DoctypeListScreen.guest.screen.spec.tsx +10 -0
  146. package/src/list/ListSidebar.screen.spec.tsx +28 -0
  147. package/src/list/ListSidebar.tsx +9 -0
  148. package/src/shared/sessionReset.spec.tsx +81 -0
  149. package/src/shared/sessionUser.ts +9 -48
  150. package/src/shared/useSlugTarget.ts +16 -6
  151. package/src/shell/BackofficeShell.sheet.spec.tsx +20 -0
  152. package/src/shell/BackofficeShell.spec.tsx +2 -2
  153. package/src/shell/BackofficeShell.tsx +1 -0
  154. package/src/shell/WorkspaceSidebar.tsx +35 -2
  155. package/src/views/ViewHeader.screen.spec.tsx +22 -1
  156. package/src/views/ViewHeader.tsx +67 -29
  157. package/src/views/viewMeta.ts +5 -0
  158. package/types/chrome/HelpMenu.d.ts +10 -0
  159. package/types/chrome/HelpMenu.d.ts.map +1 -1
  160. package/types/chrome/user-session.d.ts +1 -0
  161. package/types/chrome/user-session.d.ts.map +1 -1
  162. package/types/form/FormToolbar.d.ts.map +1 -1
  163. package/types/index.d.ts +1 -1
  164. package/types/index.d.ts.map +1 -1
  165. package/types/list/ListSidebar.d.ts.map +1 -1
  166. package/types/shared/sessionUser.d.ts +2 -5
  167. package/types/shared/sessionUser.d.ts.map +1 -1
  168. package/types/shared/useSlugTarget.d.ts.map +1 -1
  169. package/types/shell/BackofficeShell.d.ts.map +1 -1
  170. package/types/shell/WorkspaceSidebar.d.ts +3 -1
  171. package/types/shell/WorkspaceSidebar.d.ts.map +1 -1
  172. package/types/views/ViewHeader.d.ts.map +1 -1
  173. package/types/views/viewMeta.d.ts.map +1 -1
@@ -152,6 +152,23 @@ describe("UserMenu", () => {
152
152
  expect(screen.queryByText("Jane Cooper")).toBeNull();
153
153
  });
154
154
 
155
+ it("drops the signed-in menu when the host logout fails after the bench logout", async () => {
156
+ const logout = vi.fn(async () => {
157
+ throw new Error("offline");
158
+ });
159
+ renderMenu({ auth: { login: vi.fn(), logout } });
160
+ await screen.findByText("Jane Cooper");
161
+ fireEvent.click(item("Log Out"));
162
+ await waitFor(() => expect(logout).toHaveBeenCalledTimes(1));
163
+ expect(calls).toContain("/api/method/logout");
164
+ expect(
165
+ await screen.findByText("Unable to complete sign-in or sign-out. Try again."),
166
+ ).toBeTruthy();
167
+ fireEvent.click(screen.getByRole("button", { name: "Close" }));
168
+ expect(await screen.findByRole("button", { name: "Log in" })).toBeTruthy();
169
+ expect(screen.queryByRole("button", { name: "User menu" })).toBeNull();
170
+ });
171
+
155
172
  // frappe's client.get_value checks doctype-level read, which User grants to
156
173
  // System Manager only: a Keycloak-provisioned Website User (FZ-7755) or a
157
174
  // desk user without that role is refused their own User record.
@@ -65,11 +65,11 @@ export function UserMenu({ defaultOpen }: UserMenuProps = {}) {
65
65
  setActionError(false);
66
66
  try {
67
67
  await action();
68
- clearSessionUserCache();
69
68
  } catch (error) {
70
69
  setActionError(true);
71
70
  emitEvent({ type: "error", error, context: "user-menu-auth" });
72
71
  } finally {
72
+ clearSessionUserCache();
73
73
  acting.current = false;
74
74
  setBusy(false);
75
75
  }
@@ -3,7 +3,12 @@ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
3
3
  import { useCommandPaletteModel } from "./command-palette-model";
4
4
 
5
5
  const provider = vi.hoisted(() => ({ baseURL: "" }));
6
- vi.mock("@multiplatform.one/frappe-ui", () => ({ useFrappeConfig: () => provider }));
6
+ vi.mock("@multiplatform.one/frappe-ui", () => ({
7
+ getSessionRevision: () => 0,
8
+ useFrappeConfig: () => provider,
9
+ sessionUserKey: ({ baseURL }: { baseURL?: string }) => baseURL ?? "",
10
+ useSessionRevision: () => 0,
11
+ }));
7
12
  vi.mock("../config/BackofficeProvider", () => ({
8
13
  useBackofficePaths: () => ({
9
14
  workspace: (name: string) => `/workspace/${name}`,
@@ -40,6 +40,21 @@ export function clearSessionUserCache(): void {
40
40
  clearSessionIdentityCache();
41
41
  }
42
42
 
43
+ /**
44
+ * Drops the session caches when the signed-in identity settles on a new
45
+ * value. `identity` is undefined while the host's session is still loading;
46
+ * a guest starts settled, so loading/guest flips cost no refetch.
47
+ */
48
+ let settledIdentity = "guest";
49
+
50
+ export function useSessionIdentityReset(identity: string | undefined): void {
51
+ useEffect(() => {
52
+ if (identity === undefined || identity === settledIdentity) return;
53
+ settledIdentity = identity;
54
+ clearSessionUserCache();
55
+ }, [identity]);
56
+ }
57
+
43
58
  /** Resolve a User.user_image value (usually "/files/…") to an absolute URL. */
44
59
  export function resolveUserImageUrl(
45
60
  userImage: string | null | undefined,
@@ -4,19 +4,18 @@
4
4
  import {
5
5
  Chip,
6
6
  DetailPageLayout,
7
- H2,
8
7
  Image,
9
8
  List,
10
9
  ListPageLayout,
10
+ DropdownMenu,
11
11
  ListRow,
12
- ListRowMeta,
13
12
  PageHeader,
13
+ PageMenuButton,
14
14
  PageSection,
15
- Text,
16
- ViewSwitcher,
17
15
  XStack,
18
16
  YStack,
19
17
  ActionButton,
18
+ type DropdownMenuEntry,
20
19
  } from "@multiplatform.one/components";
21
20
  import {
22
21
  Button,
@@ -25,7 +24,6 @@ import {
25
24
  ImageField,
26
25
  Input,
27
26
  SearchInput,
28
- ToggleGroup,
29
27
  } from "@multiplatform.one/forms";
30
28
  import { DataTable, type DataTableColumn } from "@multiplatform.one/table";
31
29
  import {
@@ -34,9 +32,9 @@ import {
34
32
  ChartBarIcon,
35
33
  FunnelIcon,
36
34
  ListBulletsIcon,
37
- PlusIcon,
38
35
  } from "@phosphor-icons/react";
39
36
  import { useState } from "react";
37
+ import { LIST_PAGE_SIZE, ListPaging } from "../list/list-paging";
40
38
 
41
39
  const meta = {
42
40
  title: "Boards/Freeform/Backoffice",
@@ -94,14 +92,20 @@ const views = [
94
92
 
95
93
  function HeaderActions({ view }: { view: string }) {
96
94
  const [current, setCurrent] = useState(view);
95
+ const entries: DropdownMenuEntry[] = views.map(({ type, label, icon: Icon }) => ({
96
+ key: type,
97
+ label,
98
+ icon: <Icon />,
99
+ checked: type === current,
100
+ onSelect: () => setCurrent(type),
101
+ }));
97
102
  return (
98
- <XStack flex={1} gap="$2" alignItems="center" justifyContent="space-between">
99
- <ViewSwitcher views={views} currentView={current} onViewChange={setCurrent} />
100
- <XStack gap="$2" alignItems="center">
101
- <ActionButton kind="more" label="More actions" />
102
- <ActionButton kind="add" />
103
- </XStack>
104
- </XStack>
103
+ <>
104
+ <DropdownMenu items={entries} closeOnSelect placement="bottom-end">
105
+ <PageMenuButton />
106
+ </DropdownMenu>
107
+ <ActionButton kind="add" />
108
+ </>
105
109
  );
106
110
  }
107
111
 
@@ -110,34 +114,21 @@ function FilterBar({ filters }: { filters?: number }) {
110
114
  return (
111
115
  <XStack gap="$2" alignItems="center" justifyContent="space-between">
112
116
  <IconButton icon={FunnelIcon} aria-label={filters ? `Filter (${filters})` : "Filter"} />
113
- <Button iconAfter={ArrowDownIcon}>Last Updated On</Button>
117
+ <Button iconAfter={ArrowDownIcon}>Last updated on</Button>
114
118
  </XStack>
115
119
  );
116
120
  }
117
121
 
118
- /** Desk's list foot: page size and Load More. */
122
+ /** The list's paging, as the desk list screen draws it. */
119
123
  function PageFoot({ shown, total }: { shown: number; total: number }) {
120
- const [size, setSize] = useState("20");
124
+ const [pageIndex, setPageIndex] = useState(0);
121
125
  return (
122
- <YStack gap="$3">
123
- <Text color="$color11">
124
- {shown} of {total}
125
- </Text>
126
- <XStack gap="$3" alignItems="center" justifyContent="space-between">
127
- <ToggleGroup
128
- aria-label="Page size"
129
- type="single"
130
- value={size}
131
- onChange={(value) => setSize(Array.isArray(value) ? (value[0] ?? "20") : value)}
132
- options={[
133
- { label: "20", value: "20" },
134
- { label: "100", value: "100" },
135
- { label: "500", value: "500" },
136
- ]}
137
- />
138
- <Button>Load More</Button>
139
- </XStack>
140
- </YStack>
126
+ <ListPaging
127
+ pagination={{ pageIndex, pageSize: LIST_PAGE_SIZE, totalCount: total }}
128
+ onPaginationChange={(next) => setPageIndex(next.pageIndex)}
129
+ shown={shown}
130
+ total={total}
131
+ />
141
132
  );
142
133
  }
143
134
 
@@ -145,10 +136,10 @@ export const ListView = {
145
136
  name: "List",
146
137
  render: () => (
147
138
  <ListPageLayout
148
- header={<PageHeader heading={<H2>Pokemon</H2>} actions={<HeaderActions view="list" />} />}
139
+ header={<PageHeader title="Pokemon" actions={<HeaderActions view="list" />} />}
149
140
  toolbar={
150
141
  <YStack gap="$3">
151
- <SearchInput placeholder="Pokemon Name" aria-label="Pokemon Name" defaultValue="" />
142
+ <SearchInput placeholder="Pokemon name" aria-label="Pokemon name" defaultValue="" />
152
143
  <FilterBar />
153
144
  </YStack>
154
145
  }
@@ -159,14 +150,10 @@ export const ListView = {
159
150
  aria-label="Pokemon"
160
151
  renderItem={(doc) => (
161
152
  <ListRow
162
- icon={<Image src={sprite(doc.poke_id)} alt="" size="extraSmall" />}
153
+ media={<Image src={sprite(doc.poke_id)} alt="" size="extraSmall" />}
163
154
  title={doc.pokemon_name}
164
- subtitle={
165
- <Text color="$color10" fontSize="$3" numberOfLines={1}>
166
- {doc.species} · Poke ID {doc.poke_id}
167
- </Text>
168
- }
169
- meta={<ListRowMeta color="$color10">{doc.modified}</ListRowMeta>}
155
+ subtitle={doc.species}
156
+ meta={doc.modified}
170
157
  />
171
158
  )}
172
159
  />
@@ -176,40 +163,30 @@ export const ListView = {
176
163
  ),
177
164
  };
178
165
 
179
- const numberHeader = (label: string) => () => (
180
- <Text flex={1} textAlign="right" numberOfLines={1}>
181
- {label}
182
- </Text>
183
- );
184
-
185
166
  const reportColumns = [
186
167
  {
187
168
  accessorKey: "pokemon_name",
188
- header: "Pokemon Name",
169
+ header: "Pokemon name",
189
170
  width: 164,
190
171
  cell: ({ row }) => (
191
- <XStack flex={1} minWidth="$0" gap="$3" alignItems="center">
192
- <Image src={sprite(row.original.poke_id)} alt="" size="extraSmall" />
193
- <YStack flex={1} minWidth="$0">
194
- <Text numberOfLines={1}>{row.original.pokemon_name}</Text>
195
- <Text color="$color10" fontSize="$3" numberOfLines={1}>
196
- {row.original.species}
197
- </Text>
198
- </YStack>
199
- </XStack>
172
+ <ListRow
173
+ media={<Image src={sprite(row.original.poke_id)} alt="" size="extraSmall" />}
174
+ title={row.original.pokemon_name}
175
+ subtitle={row.original.species}
176
+ />
200
177
  ),
201
178
  },
202
179
  {
203
180
  accessorKey: "poke_id",
204
181
  width: 90,
205
- header: numberHeader("Poke ID"),
182
+ header: "Poke ID",
206
183
  align: "right",
207
184
  meta: { label: "Poke ID", align: "right" },
208
185
  },
209
186
  {
210
187
  accessorKey: "weight",
211
188
  width: 96,
212
- header: numberHeader("Weight"),
189
+ header: "Weight",
213
190
  align: "right",
214
191
  meta: { label: "Weight (hg)", align: "right" },
215
192
  },
@@ -219,7 +196,7 @@ export const ReportView = {
219
196
  name: "Report",
220
197
  render: () => (
221
198
  <ListPageLayout
222
- header={<PageHeader heading={<H2>Pokemon</H2>} actions={<HeaderActions view="report" />} />}
199
+ header={<PageHeader title="Pokemon" actions={<HeaderActions view="report" />} />}
223
200
  toolbar={
224
201
  <YStack gap="$3">
225
202
  <FilterBar filters={1} />
@@ -244,8 +221,8 @@ export const ReportView = {
244
221
  enableSorting={false}
245
222
  />
246
223
  <XStack gap="$2" flexWrap="wrap">
247
- <Button>Pick Columns</Button>
248
- <Button>Group By</Button>
224
+ <Button>Pick columns</Button>
225
+ <Button>Group by</Button>
249
226
  </XStack>
250
227
  <PageFoot shown={pokemon.length} total={151} />
251
228
  </YStack>
@@ -264,64 +241,37 @@ export const FormView = {
264
241
  name: "Form",
265
242
  render: () => (
266
243
  <DetailPageLayout
267
- header={
268
- <PageHeader
269
- heading={
270
- <YStack gap="$1">
271
- <H2>Caterpie</H2>
272
- <Text color="$color11">Not Saved</Text>
273
- </YStack>
274
- }
275
- />
276
- }
244
+ header={<PageHeader title="Caterpie" subtitle="Not saved" />}
277
245
  toolbarLeading={
278
- <YStack>
279
- <Button chromeless icon={CaretLeftIcon}>
280
- Pokemon
281
- </Button>
282
- </YStack>
246
+ <Button chromeless edge="start" icon={CaretLeftIcon}>
247
+ Pokemon
248
+ </Button>
283
249
  }
284
250
  toolbarTrailing={
285
- <XStack gap="$2" alignItems="center">
251
+ <>
286
252
  <ActionButton kind="more" label="More actions" />
287
253
  <ActionButton kind="save" />
288
- </XStack>
254
+ </>
289
255
  }
290
256
  >
291
257
  <PageSection>
292
- <FormGrid>
293
- <Input label="Pokemon Name" defaultValue="Caterpie" />
258
+ <FormGrid columns={2}>
259
+ <Input label="Pokemon name" defaultValue="Caterpie" />
294
260
  <Input label="Species" defaultValue="Worm Pokémon" />
261
+ <Input label="Poke ID" defaultValue="10" keyboardType="numeric" />
262
+ <Input label="Base experience" defaultValue="39" keyboardType="numeric" />
263
+ <Input label="Height (dm)" defaultValue="3" keyboardType="numeric" />
264
+ <Input label="Weight (hg)" defaultValue="29" keyboardType="numeric" />
295
265
  </FormGrid>
296
- <XStack gap="$4">
297
- <YStack flex={1}>
298
- <Input label="Poke ID" defaultValue="10" keyboardType="numeric" />
299
- </YStack>
300
- <YStack flex={1}>
301
- <Input label="Base Experience" defaultValue="39" keyboardType="numeric" />
302
- </YStack>
303
- </XStack>
304
- <XStack gap="$4">
305
- <YStack flex={1}>
306
- <Input label="Height (dm)" defaultValue="3" keyboardType="numeric" />
307
- </YStack>
308
- <YStack flex={1}>
309
- <Input label="Weight (hg)" defaultValue="29" keyboardType="numeric" />
310
- </YStack>
311
- </XStack>
312
266
  </PageSection>
313
267
  <PageSection title="Sprites">
314
- <XStack gap="$4">
315
- <YStack flex={1}>
316
- <ImageField label="Sprite (Front)" defaultValue={sprite(10)} />
317
- </YStack>
318
- <YStack flex={1}>
319
- <ImageField
320
- label="Sprite (Back)"
321
- defaultValue="https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/back/10.png"
322
- />
323
- </YStack>
324
- </XStack>
268
+ <FormGrid columns={2}>
269
+ <ImageField label="Sprite (front)" defaultValue={sprite(10)} />
270
+ <ImageField
271
+ label="Sprite (back)"
272
+ defaultValue="https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/back/10.png"
273
+ />
274
+ </FormGrid>
325
275
  </PageSection>
326
276
  <PageSection title="Stats">
327
277
  <DataTable
@@ -329,8 +279,8 @@ export const FormView = {
329
279
  columns={
330
280
  [
331
281
  { accessorKey: "stat", header: "Stat" },
332
- { accessorKey: "base_stat", header: numberHeader("Base Stat"), align: "right" },
333
- { accessorKey: "effort", header: numberHeader("Effort"), align: "right" },
282
+ { accessorKey: "base_stat", header: "Base stat", align: "right" },
283
+ { accessorKey: "effort", header: "Effort", align: "right" },
334
284
  ] as DataTableColumn<(typeof stats)[number]>[]
335
285
  }
336
286
  layout="table"
@@ -341,7 +291,7 @@ export const FormView = {
341
291
  enableColumnVisibility={false}
342
292
  />
343
293
  <XStack>
344
- <Button icon={PlusIcon}>Add Row</Button>
294
+ <ActionButton kind="add" label="Add row" />
345
295
  </XStack>
346
296
  </PageSection>
347
297
  </DetailPageLayout>
@@ -197,7 +197,7 @@ describe("FormToolbar", () => {
197
197
  expect(onNextDoc).toHaveBeenCalledTimes(1);
198
198
  });
199
199
 
200
- it("puts back in the phone top bar with Save and the chromeless menu, the title under it (LC-145)", () => {
200
+ it("puts back, Save and the chromeless menu in the phone top bar, the title centred in it (LC-145, LC-270)", () => {
201
201
  layout.size = "compact";
202
202
  const onNavigate = vi.fn();
203
203
  renderWithProviders(
@@ -216,8 +216,9 @@ describe("FormToolbar", () => {
216
216
  expect(bar.contains(screen.getByTestId("form-toolbar-save"))).toBe(true);
217
217
  expect(bar.contains(screen.getByTestId("form-toolbar-menu"))).toBe(true);
218
218
  const title = screen.getByRole("heading", { name: "SO-0001" });
219
- expect(bar.contains(title)).toBe(false);
220
- expect(bar.compareDocumentPosition(title) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
219
+ expect(bar.contains(title)).toBe(true);
220
+ expect(title.getAttribute("aria-level")).toBe("1");
221
+ expect(document.querySelector("h1")).toBeNull();
221
222
  expect(screen.getByTestId("form-toolbar-menu").getAttribute("data-top-bar-control")).toBe(
222
223
  "menu",
223
224
  );
@@ -226,6 +227,36 @@ describe("FormToolbar", () => {
226
227
  expect(onNavigate).toHaveBeenCalledWith("/backoffice/sales-order");
227
228
  });
228
229
 
230
+ it("keeps the large title under the breadcrumbs on a wide screen (LC-270 is phone only)", () => {
231
+ renderWithProviders(<FormToolbar {...props()} />);
232
+ const title = screen.getByRole("heading", { name: "SO-0001" });
233
+ expect(title.tagName).toBe("H1");
234
+ expect(document.querySelector("[data-bar-title]")).toBeNull();
235
+ });
236
+
237
+ it("opens the record's … over its button with no X, rows from the top, Escape closes (LC-112)", async () => {
238
+ layout.size = "compact";
239
+ renderWithProviders(
240
+ <FormToolbar
241
+ {...props({
242
+ indicator: "saved",
243
+ canSubmit: false,
244
+ onPrevDoc: vi.fn(),
245
+ onNextDoc: vi.fn(),
246
+ menuItems: [{ key: "reload", label: "Reload", onSelect: vi.fn() }],
247
+ })}
248
+ />,
249
+ );
250
+ fireEvent.click(screen.getByTestId("form-toolbar-menu"));
251
+ const menu = await screen.findByRole("menu");
252
+ expect(menu.querySelector('[aria-label="Close"]')).toBeNull();
253
+ expect(screen.queryByRole("button", { name: "Close" })).toBeNull();
254
+ const rows = screen.getAllByRole("menuitem");
255
+ expect(rows[0].textContent).toContain("Previous document");
256
+ fireEvent.keyDown(menu, { key: "Escape" });
257
+ await waitFor(() => expect(screen.queryByRole("menu")).toBeNull());
258
+ });
259
+
229
260
  it("pages prev/next and disables the boundary arrow instead of hiding it", () => {
230
261
  const onPrevDoc = vi.fn();
231
262
  const onNextDoc = vi.fn();
@@ -7,6 +7,7 @@ import {
7
7
  PageBackButton,
8
8
  PageHeader,
9
9
  PageMenuButton,
10
+ PushedPage,
10
11
  ScreenToolbar,
11
12
  StatusDot,
12
13
  XStack,
@@ -439,35 +440,45 @@ export function FormToolbar({
439
440
  ) : undefined;
440
441
 
441
442
  if (isNarrow) {
442
- // LC-145: back leads the top bar on the row Save and "…" trail, and the
443
- // title starts directly under it. Back goes to the list crumb.
443
+ // LC-145: back leads the top bar on the row Save and "…" trail. LC-270:
444
+ // the record is a pushed page, so its title sits centred in that bar.
445
+ // Back goes to the list crumb.
444
446
  const back = [...breadcrumbs].reverse().find((crumb) => crumb.href);
445
447
  return (
446
- <YStack {...knobProps.panelPadding} gap="$2" flexShrink={0} testID="form-toolbar">
447
- <ScreenToolbar
448
- leading={
449
- back?.href ? (
450
- <PageBackButton
451
- label={back.label}
452
- onPress={() => onNavigate(back.href as string)}
453
- aria-label={t("backToList", "Back to {{doctype}} list", { doctype: back.label })}
454
- testID="form-toolbar-back"
455
- />
456
- ) : null
457
- }
458
- trailing={
459
- <>
460
- {saveButton}
461
- {menuButton}
462
- </>
463
- }
464
- // The block pads the bar and the title alike, so the bar takes no
465
- // inset or bleed of its own and back stays on the title's line.
466
- padding={0}
467
- marginHorizontal={0}
468
- />
469
- <PageHeader title={title} heading={heading} status={status} divider={false} />
470
- </YStack>
448
+ <PushedPage>
449
+ <YStack
450
+ {...knobProps.panelPadding}
451
+ paddingBottom={0}
452
+ gap="$2"
453
+ flexShrink={0}
454
+ testID="form-toolbar"
455
+ >
456
+ <ScreenToolbar
457
+ title={title}
458
+ leading={
459
+ back?.href ? (
460
+ <PageBackButton
461
+ label={back.label}
462
+ onPress={() => onNavigate(back.href as string)}
463
+ aria-label={t("backToList", "Back to {{doctype}} list", { doctype: back.label })}
464
+ testID="form-toolbar-back"
465
+ />
466
+ ) : null
467
+ }
468
+ trailing={
469
+ <>
470
+ {saveButton}
471
+ {menuButton}
472
+ </>
473
+ }
474
+ // The block pads the bar and the title alike, so the bar takes no
475
+ // inset or bleed of its own and back stays on the title's line.
476
+ padding={0}
477
+ marginHorizontal={0}
478
+ />
479
+ <PageHeader title={title} heading={heading} status={status} divider={false} />
480
+ </YStack>
481
+ </PushedPage>
471
482
  );
472
483
  }
473
484
 
package/src/index.ts CHANGED
@@ -172,6 +172,7 @@ export type { UserMenuProps } from "./chrome/UserMenu";
172
172
  export {
173
173
  clearSessionUserCache,
174
174
  resolveUserImageUrl,
175
+ useSessionIdentityReset,
175
176
  useSessionUserInfo,
176
177
  } from "./chrome/user-session";
177
178
  export type { SessionUserInfo } from "./chrome/user-session";
@@ -186,6 +186,16 @@ describe("DoctypeListScreen with DocType meta refused (LC-96)", () => {
186
186
  expect(screen.getByText("Seed monster")).toBeTruthy();
187
187
  });
188
188
 
189
+ it("leads a guest's phone rows with the record's image (FZ-7684)", async () => {
190
+ layout.size = "compact";
191
+ renderList();
192
+ await waitFor(() => expect(screen.getByText("bulbasaur")).toBeTruthy(), settle);
193
+ await waitFor(
194
+ () => expect(document.querySelector('img[src$="/files/bulbasaur.png"]')).toBeTruthy(),
195
+ settle,
196
+ );
197
+ });
198
+
189
199
  it("keeps compact rows in a bounded document list", async () => {
190
200
  layout.size = "compact";
191
201
  renderList();
@@ -27,6 +27,7 @@ interface FacetCall {
27
27
  let run = 0;
28
28
  let calls: FacetCall[] = [];
29
29
  let failFacets = false;
30
+ let emptyFacets = false;
30
31
 
31
32
  function json(body: unknown, status = 200) {
32
33
  return new Response(JSON.stringify(body), {
@@ -64,6 +65,7 @@ beforeEach(() => {
64
65
  run += 1;
65
66
  calls = [];
66
67
  failFacets = false;
68
+ emptyFacets = false;
67
69
  vi.stubGlobal("fetch", async (input: string | URL | Request, init?: RequestInit) => {
68
70
  const url = new URL(String(input instanceof Request ? input.url : input));
69
71
  const method = url.pathname.replace(/^\/api\/method\//, "");
@@ -73,6 +75,11 @@ beforeEach(() => {
73
75
  if (method.startsWith("frappe.desk.")) {
74
76
  calls.push({ method, body });
75
77
  if (failFacets) return json({ exc_type: "PermissionError" }, 403);
78
+ if (emptyFacets) {
79
+ return method === "frappe.desk.reportview.get_sidebar_stats"
80
+ ? json({ message: { stats: {} } })
81
+ : json({ message: [] });
82
+ }
76
83
  }
77
84
  if (method === "frappe.desk.listview.get_group_by_count") {
78
85
  return json({ message: groupBy[body.field] ?? [] });
@@ -95,6 +102,7 @@ interface SidebarOptions {
95
102
  filters?: FrappeFilters;
96
103
  hiddenSections?: ListSidebarSection[];
97
104
  capabilities?: BackofficeCapabilities;
105
+ fill?: boolean;
98
106
  }
99
107
 
100
108
  function renderSidebar({
@@ -102,6 +110,7 @@ function renderSidebar({
102
110
  filters = [],
103
111
  hiddenSections,
104
112
  capabilities,
113
+ fill,
105
114
  }: SidebarOptions = {}) {
106
115
  const onFiltersChange = vi.fn();
107
116
  renderWithProviders(
@@ -116,6 +125,7 @@ function renderSidebar({
116
125
  filters={filters}
117
126
  onFiltersChange={onFiltersChange}
118
127
  hiddenSections={hiddenSections}
128
+ fill={fill}
119
129
  />
120
130
  </BackofficeProvider>,
121
131
  );
@@ -199,4 +209,22 @@ describe("ListSidebar", () => {
199
209
  renderSidebar();
200
210
  expect(await screen.findByText("Filters sidebar unavailable")).toBeTruthy();
201
211
  });
212
+
213
+ // FZ-8939 (LC-39): the desk Pokemon list has no assignments, owners, tags or
214
+ // status to count. Its sidebar drew a 200pt column of nothing and pushed the
215
+ // table off the page's leading edge.
216
+ it("draws no column once every facet resolves empty", async () => {
217
+ emptyFacets = true;
218
+ renderSidebar();
219
+ await waitFor(() => expect(calls).toHaveLength(4));
220
+ await waitFor(() => expect(screen.queryByLabelText("List filters sidebar")).toBeNull());
221
+ });
222
+
223
+ it("keeps its group in the shell rail when every facet resolves empty (LC-101)", async () => {
224
+ emptyFacets = true;
225
+ renderSidebar({ fill: true });
226
+ await waitFor(() => expect(calls).toHaveLength(4));
227
+ await new Promise((resolve) => setTimeout(resolve, 100));
228
+ expect(screen.getByLabelText("List filters sidebar")).toBeTruthy();
229
+ });
202
230
  });
@@ -162,6 +162,15 @@ export function ListSidebar({
162
162
  // Whole surface unavailable — every facet errored (e.g. no read perm).
163
163
  const unavailable = sections.every((section) => !section.state.loading && section.state.error);
164
164
 
165
+ // LC-39 (FZ-8939): standing as the page's own column, a sidebar whose facets
166
+ // all resolved empty is a fixed column of nothing that pushed the list off
167
+ // the page's leading edge (Tier 2 `screens-backoffice-desk-pokemon--list`).
168
+ // In the shell rail (`fill`) it is a group under the nav and costs no column.
169
+ const resolvedEmpty = sections.every(
170
+ (section) => !section.state.loading && !section.state.error && section.rows.length === 0,
171
+ );
172
+ if (resolvedEmpty && !fill) return null;
173
+
165
174
  return (
166
175
  <YStack
167
176
  width={