@multiplatform.one/backoffice 7.22.0 → 7.23.1

package/src/list/filter-fields.spec.ts

@@ -1,29 +0,0 @@
-import { describe, expect, it } from "vitest";
-import type { DoctypeMeta } from "../shared/useDoctypeMeta";
-import { standardFiltersFromMeta } from "./filter-fields";
-
-const todoMeta: DoctypeMeta = {
-  name: "ToDo",
-  title_field: "description",
-  fields: [
-    {
-      fieldname: "status",
-      fieldtype: "Select",
-      label: "Status",
-      options: "Open\nClosed",
-      in_standard_filter: 1,
-    },
-    { fieldname: "description", fieldtype: "Small Text", label: "Description" },
-    { fieldname: "priority", fieldtype: "Select", label: "Priority", in_list_view: 1 },
-  ],
-};
-
-describe("standardFiltersFromMeta", () => {
-  it("prepends ID and the title field when they are not already standard filters", () => {
-    const names = standardFiltersFromMeta(todoMeta).map((field) => field.fieldname);
-    expect(names[0]).toBe("name");
-    expect(names).toContain("description");
-    expect(names).toContain("status");
-    expect(names).not.toContain("priority");
-  });
-});

package/src/list/listFields.spec.ts

@@ -1,148 +0,0 @@
-/**
- * listFields — permlevel column pruning (desk parity with base_list.js
- * `get_fields_in_list_view`: in_list_view fields above the session roles'
- * READ permlevel never render as columns). The matrix itself is the form
- * workstream's fieldPermissions module (perm.js parity) — reused, not forked.
- * buildListColumns maps listViewFields 1:1 into column defs, so pruning is
- * asserted here on the pure module (the features vitest node environment
- * cannot import the JSX/components barrel — see vitest.config.mjs).
- */
-import { describe, expect, it } from "vitest";
-import { buildPermLevelMatrix, type PermLevelMatrix } from "../form/fieldPermissions";
-import type { DoctypeMeta } from "../shared/useDoctypeMeta";
-import { listDocumentColumnIds, listFieldsToFetch, listViewFields } from "./listFields";
-
-const meta: DoctypeMeta = {
-  name: "User",
-  title_field: "full_name",
-  fields: [
-    { fieldname: "full_name", fieldtype: "Data", label: "Full Name", in_list_view: 1 },
-    { fieldname: "enabled", fieldtype: "Check", label: "Enabled", in_list_view: 1 },
-    {
-      fieldname: "role_profile_name",
-      fieldtype: "Link",
-      label: "Role Profile",
-      in_list_view: 1,
-      permlevel: 1,
-    },
-    {
-      fieldname: "api_secret_hint",
-      fieldtype: "Data",
-      label: "API Secret Hint",
-      in_list_view: 1,
-      permlevel: 2,
-    },
-    { fieldname: "bio", fieldtype: "Small Text", label: "Bio" },
-  ],
-  permissions: [
-    { role: "System Manager", permlevel: 0, read: 1, write: 1 },
-    { role: "System Manager", permlevel: 1, read: 1, write: 1 },
-    // No rows at permlevel 2 — desk gap-fills {} and hides those fields.
-  ],
-};
-
-function viewFieldnames(matrix?: PermLevelMatrix): string[] {
-  return listViewFields(meta, meta.title_field ?? "name", matrix).map((field) => field.fieldname);
-}
-
-describe("listViewFields permlevel pruning", () => {
-  it("without a matrix (fixtures / roles unavailable) prunes nothing", () => {
-    const names = viewFieldnames(undefined);
-    expect(names).toContain("enabled");
-    expect(names).toContain("role_profile_name");
-    expect(names).toContain("api_secret_hint");
-  });
-
-  it("keeps fields whose permlevel the roles can read, prunes the rest", () => {
-    const matrix = buildPermLevelMatrix(meta.permissions, ["System Manager"]);
-    const names = viewFieldnames(matrix);
-    expect(names).toContain("enabled"); // level 0
-    expect(names).toContain("role_profile_name"); // level 1 granted
-    // Level 2 has no granting rows at all → hidden (desk gap-fill).
-    expect(names).not.toContain("api_secret_hint");
-  });
-
-  it("prunes every above-zero level for roles with no granting rows", () => {
-    const matrix = buildPermLevelMatrix(meta.permissions, ["Desk User"]);
-    const names = viewFieldnames(matrix);
-    expect(names).toContain("enabled");
-    expect(names).not.toContain("role_profile_name");
-    expect(names).not.toContain("api_secret_hint");
-  });
-
-  it("excludes the title field regardless of the matrix (title column owns it)", () => {
-    expect(viewFieldnames(undefined)).not.toContain("full_name");
-    const matrix = buildPermLevelMatrix(meta.permissions, ["Desk User"]);
-    expect(viewFieldnames(matrix)).not.toContain("full_name");
-  });
-
-  it("never includes fields that are not in_list_view", () => {
-    expect(viewFieldnames(undefined)).not.toContain("bio");
-  });
-});
-
-describe("listFieldsToFetch permlevel pruning", () => {
-  it("skips unreadable in_list_view fields but keeps bookkeeping fields", () => {
-    const matrix = buildPermLevelMatrix(meta.permissions, ["Desk User"]);
-    const fields = listFieldsToFetch(meta, matrix);
-    expect(fields).toEqual(
-      expect.arrayContaining(["name", "modified", "full_name", "enabled", "_comments"]),
-    );
-    expect(fields).not.toContain("role_profile_name");
-    expect(fields).not.toContain("api_secret_hint");
-  });
-
-  it("fetches everything in_list_view when no matrix is available", () => {
-    const fields = listFieldsToFetch(meta, undefined);
-    expect(fields).toContain("role_profile_name");
-    expect(fields).toContain("api_secret_hint");
-  });
-});
-
-// frappe/model/__init__.py default_fields and optional_fields: the only names
-// frappe.desk.reportview.validate_fields lets through without a DocField.
-// Anything else that isn't a field of the doctype answers 417 "Field not
-// permitted in query" for every user without the query bypass (MPO-389).
-const frappeStandardFields = new Set([
-  "doctype",
-  "name",
-  "owner",
-  "creation",
-  "modified",
-  "modified_by",
-  "docstatus",
-  "idx",
-  "_user_tags",
-  "_comments",
-  "_assign",
-  "_liked_by",
-  "_seen",
-]);
-
-describe("listFieldsToFetch asks only for columns Frappe will select", () => {
-  it("names nothing but the doctype's fields and Frappe's standard columns", () => {
-    const fieldnames = new Set(meta.fields.map((field) => field.fieldname));
-    const rejected = listFieldsToFetch(meta, undefined).filter(
-      (name) => !fieldnames.has(name) && !frappeStandardFields.has(name),
-    );
-    expect(rejected).toEqual([]);
-  });
-
-  it("reads the comment count from _comments instead of the computed _comment_count", () => {
-    const fields = listFieldsToFetch(meta, undefined);
-    expect(fields).toContain("_comments");
-    expect(fields).not.toContain("_comment_count");
-  });
-});
-
-describe("listDocumentColumnIds desk list anatomy", () => {
-  it("is title, in_list_view values, then the activity cluster — no extra ID/modified", () => {
-    expect(listDocumentColumnIds(meta)).toEqual([
-      "full_name",
-      "enabled",
-      "role_profile_name",
-      "api_secret_hint",
-      "_activity",
-    ]);
-  });
-});

package/src/list/listFormat.spec.ts

@@ -1,151 +0,0 @@
-/**
- * listFormat — frappe datetime parsing and desk-style list-cell display
- * helpers. Time-ago fixtures anchor `now` to the parsed date itself so the
- * assertions are timezone-independent.
- */
-import { describe, expect, it } from "vitest";
-import {
-  formatDateCell,
-  formatTimeAgo,
-  parseFrappeDate,
-  parseTagsField,
-  parseUserListField,
-  stripHtmlPreview,
-} from "./listFormat";
-
-describe("parseFrappeDate", () => {
-  it("parses frappe datetime strings (space-separated, microseconds)", () => {
-    const date = parseFrappeDate("2026-08-12 08:50:24.691936");
-    expect(date).toBeInstanceOf(Date);
-    expect(date?.getFullYear()).toBe(2026);
-    expect(date?.getMonth()).toBe(7); // August
-    expect(date?.getDate()).toBe(12);
-    expect(date?.getHours()).toBe(8);
-    expect(date?.getMinutes()).toBe(50);
-    expect(date?.getSeconds()).toBe(24);
-  });
-
-  it("parses plain dates", () => {
-    const date = parseFrappeDate("2026-08-12");
-    expect(date).toBeInstanceOf(Date);
-    expect(Number.isNaN(date?.getTime())).toBe(false);
-  });
-
-  it("returns undefined for invalid input", () => {
-    expect(parseFrappeDate("not a date")).toBeUndefined();
-    expect(parseFrappeDate("")).toBeUndefined();
-  });
-});
-
-describe("formatDateCell (LC-12 compact-absolute display register)", () => {
-  // Anchor `now` inside the stamp's year so current-year elision is stable.
-  const now = parseFrappeDate("2026-01-01 00:00:00") as Date;
-
-  it("renders the house compact-absolute register, never raw ISO", () => {
-    expect(formatDateCell("2026-08-12 08:50:24", now)).toBe("Aug 12");
-    expect(formatDateCell("2026-08-12 08:50:24.691936", now)).toBe("Aug 12");
-    expect(formatDateCell("2026-08-12", now)).toBe("Aug 12");
-  });
-
-  it("keeps the year when not current (display register year:auto)", () => {
-    expect(formatDateCell("2025-07-01", now)).toBe("Jul 1, 2025");
-  });
-
-  it("passes unparseable input through unchanged (honest passthrough)", () => {
-    expect(formatDateCell("garbage", now)).toBe("garbage");
-  });
-});
-
-describe("formatTimeAgo (LC-12 relative register)", () => {
-  const stamp = "2026-08-12 08:00:00";
-  const base = parseFrappeDate(stamp) as Date;
-  const after = (ms: number) => new Date(base.getTime() + ms);
-  const MINUTE = 60_000;
-  const HOUR = 60 * MINUTE;
-  const DAY = 24 * HOUR;
-
-  it("speaks the house relative register — one voice, unambiguous units", () => {
-    expect(formatTimeAgo(stamp, after(0))).toBe("just now");
-    expect(formatTimeAgo(stamp, after(59_000))).toBe("just now");
-    expect(formatTimeAgo(stamp, after(MINUTE))).toBe("1m ago");
-    expect(formatTimeAgo(stamp, after(59 * MINUTE))).toBe("59m ago");
-    expect(formatTimeAgo(stamp, after(HOUR))).toBe("1h ago");
-    expect(formatTimeAgo(stamp, after(23 * HOUR + 59 * MINUTE))).toBe("23h ago");
-    expect(formatTimeAgo(stamp, after(DAY))).toBe("1 day ago");
-    expect(formatTimeAgo(stamp, after(29 * DAY))).toBe("29 days ago");
-  });
-
-  it("months use 'mo', never an ambiguous capital M", () => {
-    expect(formatTimeAgo(stamp, after(31 * DAY))).toBe("1mo ago");
-    expect(formatTimeAgo(stamp, after(330 * DAY))).toBe("11mo ago");
-  });
-
-  it("shows years beyond ~12 months", () => {
-    expect(formatTimeAgo(stamp, after(366 * DAY))).toBe("1y ago");
-    expect(formatTimeAgo(stamp, after(2 * 366 * DAY))).toBe("2y ago");
-  });
-
-  it("returns the raw value when unparseable", () => {
-    expect(formatTimeAgo("garbage", new Date())).toBe("garbage");
-  });
-
-  it("treats future timestamps as just now (clamped, never negative)", () => {
-    expect(formatTimeAgo(stamp, after(-5 * HOUR))).toBe("just now");
-  });
-});
-
-describe("parseUserListField (_assign / _liked_by JSON-array-string columns)", () => {
-  it("parses the bench shape: a JSON array string", () => {
-    expect(parseUserListField('["admin@example.com", "test@example.com"]')).toEqual([
-      "admin@example.com",
-      "test@example.com",
-    ]);
-  });
-
-  it("passes real arrays through, stringifying members", () => {
-    expect(parseUserListField(["a@b.c", 42])).toEqual(["a@b.c", "42"]);
-  });
-
-  it("returns [] for empty, malformed, or non-array JSON", () => {
-    expect(parseUserListField("")).toEqual([]);
-    expect(parseUserListField(null)).toEqual([]);
-    expect(parseUserListField(undefined)).toEqual([]);
-    expect(parseUserListField("not json")).toEqual([]);
-    expect(parseUserListField('{"a":1}')).toEqual([]);
-    expect(parseUserListField(42)).toEqual([]);
-  });
-});
-
-describe("stripHtmlPreview (rich-text cell previews, desk strip_html parity)", () => {
-  it("strips Text Editor markup down to its text", () => {
-    expect(stripHtmlPreview('<div class="ql-editor read-mode"><p>Call the vendor</p></div>')).toBe(
-      "Call the vendor",
-    );
-  });
-
-  it("collapses tags and entities into single spaces", () => {
-    expect(stripHtmlPreview("<p>a</p><p>b&nbsp;c</p>")).toBe("a b c");
-    expect(stripHtmlPreview("x &amp; y &lt;z&gt;")).toBe("x & y <z>");
-  });
-
-  it("passes plain text through untouched (fast path)", () => {
-    expect(stripHtmlPreview("plain description")).toBe("plain description");
-  });
-});
-
-describe("parseTagsField (_user_tags comma-joined column)", () => {
-  it("parses the bench shape: leading-comma joined tags", () => {
-    expect(parseTagsField(",Urgent,Follow Up")).toEqual(["Urgent", "Follow Up"]);
-  });
-
-  it("trims whitespace and drops empty segments", () => {
-    expect(parseTagsField(" ,  a , ,b, ")).toEqual(["a", "b"]);
-  });
-
-  it("returns [] for empty or non-string values", () => {
-    expect(parseTagsField("")).toEqual([]);
-    expect(parseTagsField(null)).toEqual([]);
-    expect(parseTagsField(undefined)).toEqual([]);
-    expect(parseTagsField(["a"])).toEqual([]);
-  });
-});

package/src/list/statusColors.spec.ts

@@ -1,100 +0,0 @@
-/**
- * statusColors — desk indicator-color parity for the list status pill.
- * Workflow `states` from the doctype meta must win over the heuristic
- * word map; everything unknown lands on gray.
- */
-import { describe, expect, it } from "vitest";
-import type { DoctypeMeta } from "../shared/useDoctypeMeta";
-import { statusPillColors } from "./statusColors";
-
-function makeMeta(states: Array<{ title?: string; color?: string }>): DoctypeMeta {
-  return { name: "ToDo", fields: [], states } as DoctypeMeta;
-}
-
-describe("statusPillColors heuristics (no meta)", () => {
-  it("maps done/healthy words to green", () => {
-    for (const status of ["Closed", "Completed", "Approved", "Paid", "Active", "Delivered"]) {
-      expect(statusPillColors(status)).toEqual({ background: "$green3", text: "$green11" });
-    }
-  });
-
-  it("maps in-flight words to orange", () => {
-    for (const status of ["Open", "Pending", "In Progress", "Overdue", "Medium"]) {
-      expect(statusPillColors(status)).toEqual({ background: "$orange3", text: "$orange11" });
-    }
-  });
-
-  it("maps informational words to blue", () => {
-    for (const status of ["Submitted", "Running", "New", "In Review", "Low"]) {
-      expect(statusPillColors(status)).toEqual({ background: "$blue3", text: "$blue11" });
-    }
-  });
-
-  it("maps failed/stopped words to red", () => {
-    for (const status of ["Cancelled", "Canceled", "Failed", "Rejected", "Urgent", "High"]) {
-      expect(statusPillColors(status)).toEqual({ background: "$red3", text: "$red11" });
-    }
-  });
-
-  it("maps draft and unknown values to gray", () => {
-    expect(statusPillColors("Draft")).toEqual({ background: "$gray3", text: "$gray11" });
-    expect(statusPillColors("Something Custom")).toEqual({
-      background: "$gray3",
-      text: "$gray11",
-    });
-    expect(statusPillColors("")).toEqual({ background: "$gray3", text: "$gray11" });
-  });
-
-  it("normalizes case and whitespace", () => {
-    expect(statusPillColors(" OPEN ")).toEqual({ background: "$orange3", text: "$orange11" });
-    expect(statusPillColors("paid")).toEqual({ background: "$green3", text: "$green11" });
-  });
-});
-
-describe("statusPillColors with workflow states", () => {
-  it("prefers the workflow state color over the word heuristic", () => {
-    // Heuristic would say orange for "Open"; the workflow says Red.
-    const meta = makeMeta([{ title: "Open", color: "Red" }]);
-    expect(statusPillColors("Open", meta)).toEqual({ background: "$red3", text: "$red11" });
-  });
-
-  it("matches state titles case-insensitively and trims", () => {
-    const meta = makeMeta([{ title: "  open ", color: "Green" }]);
-    expect(statusPillColors("Open", meta)).toEqual({ background: "$green3", text: "$green11" });
-  });
-
-  it("maps desk color aliases onto ramp families", () => {
-    const cases: Array<[string, string]> = [
-      ["Light-Blue", "blue"],
-      ["cyan", "blue"],
-      ["Amber", "yellow"],
-      ["Grey", "gray"],
-      ["darkgrey", "gray"],
-      ["Purple", "purple"],
-      ["Pink", "pink"],
-    ];
-    for (const [deskColor, ramp] of cases) {
-      const meta = makeMeta([{ title: "Custom", color: deskColor }]);
-      expect(statusPillColors("Custom", meta)).toEqual({
-        background: `$${ramp}3`,
-        text: `$${ramp}11`,
-      });
-    }
-  });
-
-  it("falls back to the heuristic for unknown desk colors", () => {
-    const meta = makeMeta([{ title: "Open", color: "Teal" }]);
-    expect(statusPillColors("Open", meta)).toEqual({ background: "$orange3", text: "$orange11" });
-  });
-
-  it("falls back to the heuristic when the state has no color or no match", () => {
-    expect(statusPillColors("Open", makeMeta([{ title: "Open" }]))).toEqual({
-      background: "$orange3",
-      text: "$orange11",
-    });
-    expect(statusPillColors("Closed", makeMeta([{ title: "Open", color: "Red" }]))).toEqual({
-      background: "$green3",
-      text: "$green11",
-    });
-  });
-});