@muloka/figma-console-mcp 0.4.0 → 0.5.1

package/figma-desktop-bridge/code.js

@@ -719,40 +719,47 @@ figma.ui.onmessage = async (msg) => {
   // CREATE_VARIABLE_COLLECTION - Create a new variable collection
   // ============================================================================
   else if (msg.type === 'CREATE_VARIABLE_COLLECTION') {
+    var newCollection = null;
     try {
       console.log('🌉 [Desktop Bridge] Creating collection:', msg.name);
 
-      // Create the collection
-      var collection = figma.variables.createVariableCollection(msg.name);
+      newCollection = figma.variables.createVariableCollection(msg.name);
 
       // Rename the default mode if a name is provided
-      if (msg.initialModeName && collection.modes.length > 0) {
-        collection.renameMode(collection.modes[0].modeId, msg.initialModeName);
+      if (msg.initialModeName && newCollection.modes.length > 0) {
+        newCollection.renameMode(newCollection.modes[0].modeId, msg.initialModeName);
       }
 
       // Add additional modes if provided
       if (msg.additionalModes && msg.additionalModes.length > 0) {
         for (var i = 0; i < msg.additionalModes.length; i++) {
-          collection.addMode(msg.additionalModes[i]);
+          newCollection.addMode(msg.additionalModes[i]);
         }
       }
 
-      console.log('🌉 [Desktop Bridge] Collection created:', collection.id);
+      console.log('🌉 [Desktop Bridge] Collection created:', newCollection.id);
 
       figma.ui.postMessage({
         type: 'CREATE_VARIABLE_COLLECTION_RESULT',
         requestId: msg.requestId,
         success: true,
-        collection: serializeCollection(collection)
+        collection: serializeCollection(newCollection)
       });
 
     } catch (error) {
+      // Mode setup failed after the collection was created — remove the
+      // orphan so a retry cannot create twins (mirrors the rollback in the
+      // tokens-tools create phase).
+      var ccRolledBack = false;
+      if (newCollection) {
+        try { newCollection.remove(); ccRolledBack = true; } catch (removeErr) {}
+      }
       console.error('🌉 [Desktop Bridge] Create collection error:', error);
       figma.ui.postMessage({
         type: 'CREATE_VARIABLE_COLLECTION_RESULT',
         requestId: msg.requestId,
         success: false,
-        error: error.message || String(error)
+        error: (error.message || String(error)) + (ccRolledBack ? ' (partially-created collection rolled back)' : '')
       });
     }
   }
@@ -3751,12 +3758,18 @@ figma.ui.onmessage = async (msg) => {
 
     } catch (error) {
       var errorMsg = error && error.message ? error.message : String(error);
+      // figma.createX() lands the node on the page immediately; a throw from
+      // font load / resize / fills / appendChild would otherwise strand it.
+      var childRemoved = false;
+      if (typeof newNode !== 'undefined' && newNode) {
+        try { newNode.remove(); childRemoved = true; } catch (removeErr) {}
+      }
       console.error('🌉 [Desktop Bridge] Create child node error:', errorMsg);
       figma.ui.postMessage({
         type: 'CREATE_CHILD_NODE_RESULT',
         requestId: msg.requestId,
         success: false,
-        error: errorMsg
+        error: errorMsg + (childRemoved ? ' (partially-created node was removed)' : '')
       });
     }
   }
@@ -6022,28 +6035,31 @@ figma.ui.onmessage = async (msg) => {
       var stickyFontLoaded = false;
 
       for (var si = 0; si < msg.stickies.length; si++) {
+        var batchSticky = null;
         try {
           var spec = msg.stickies[si];
-          var sticky = figma.createSticky();
+          batchSticky = figma.createSticky();
           if (!stickyFontLoaded) {
-            await figma.loadFontAsync(sticky.text.fontName);
+            await figma.loadFontAsync(batchSticky.text.fontName);
             stickyFontLoaded = true;
           }
-          sticky.text.characters = spec.text || '';
+          batchSticky.text.characters = spec.text || '';
 
-          if (typeof spec.x === 'number') sticky.x = spec.x;
-          if (typeof spec.y === 'number') sticky.y = spec.y;
+          if (typeof spec.x === 'number') batchSticky.x = spec.x;
+          if (typeof spec.y === 'number') batchSticky.y = spec.y;
 
           if (spec.color) {
             var sc = __stickyColors[spec.color.toUpperCase()];
             if (sc) {
-              sticky.fills = [{ type: 'SOLID', color: sc }];
+              batchSticky.fills = [{ type: 'SOLID', color: sc }];
             }
           }
 
-          created.push({ id: sticky.id, type: sticky.type, name: sticky.name, x: sticky.x, y: sticky.y });
+          created.push({ id: batchSticky.id, type: batchSticky.type, name: batchSticky.name, x: batchSticky.x, y: batchSticky.y });
         } catch (e) {
-          failed.push({ index: si, error: e.message || String(e) });
+          // A sticky created before the throw EXISTS on the board but is in
+          // neither list — report its id so the caller can find or remove it.
+          failed.push({ index: si, id: batchSticky ? batchSticky.id : undefined, error: e.message || String(e) });
         }
       }
 
@@ -6073,15 +6089,17 @@ figma.ui.onmessage = async (msg) => {
       }
       console.log('🌉 [Desktop Bridge] Creating connector');
 
-      var connector = figma.createConnector();
-
-      // Set start and end endpoints
+      // Validate endpoints FIRST — a stale nodeId is the most common caller
+      // error, and creating the connector before checking guaranteed an
+      // endpoint-less orphan on every such call.
       var startNode = await figma.getNodeByIdAsync(msg.startNodeId);
       var endNode = await figma.getNodeByIdAsync(msg.endNodeId);
 
       if (!startNode) throw new Error('Start node not found: ' + msg.startNodeId);
       if (!endNode) throw new Error('End node not found: ' + msg.endNodeId);
 
+      var connector = figma.createConnector();
+
       connector.connectorStart = {
         endpointNodeId: msg.startNodeId,
         magnet: msg.startMagnet || 'AUTO'
@@ -6263,16 +6281,16 @@ figma.ui.onmessage = async (msg) => {
       }
       console.log('🌉 [Desktop Bridge] Creating table:', msg.rows, 'x', msg.columns);
 
-      var table = figma.createTable(msg.rows, msg.columns);
+      var ctTable = figma.createTable(msg.rows, msg.columns);
 
-      if (typeof msg.x === 'number') table.x = msg.x;
-      if (typeof msg.y === 'number') table.y = msg.y;
+      if (typeof msg.x === 'number') ctTable.x = msg.x;
+      if (typeof msg.y === 'number') ctTable.y = msg.y;
 
       // Populate cells if data provided
       if (msg.data && Array.isArray(msg.data)) {
         for (var row = 0; row < msg.data.length && row < msg.rows; row++) {
           for (var col = 0; col < msg.data[row].length && col < msg.columns; col++) {
-            var cell = table.cellAt(row, col);
+            var cell = ctTable.cellAt(row, col);
             if (cell && msg.data[row][col] != null) {
               await figma.loadFontAsync(cell.text.fontName);
               cell.text.characters = String(msg.data[row][col]);
@@ -6285,16 +6303,21 @@ figma.ui.onmessage = async (msg) => {
         type: 'CREATE_TABLE_RESULT',
         requestId: msg.requestId,
         success: true,
-        data: { id: table.id, type: table.type, name: table.name, rows: msg.rows, columns: msg.columns }
+        data: { id: ctTable.id, type: ctTable.type, name: ctTable.name, rows: msg.rows, columns: msg.columns }
       });
 
     } catch (error) {
+      // A font-load failure mid cell-loop leaves a half-populated table.
+      var ctTableRemoved = false;
+      if (typeof ctTable !== 'undefined' && ctTable) {
+        try { ctTable.remove(); ctTableRemoved = true; } catch (removeErr) {}
+      }
       console.error('🌉 [Desktop Bridge] Create table error:', error);
       figma.ui.postMessage({
         type: 'CREATE_TABLE_RESULT',
         requestId: msg.requestId,
         success: false,
-        error: error.message || String(error)
+        error: (error.message || String(error)) + (ctTableRemoved ? ' (partially-created node was removed)' : '')
       });
     }
   }
@@ -7154,12 +7177,19 @@ figma.ui.onmessage = async (msg) => {
       });
 
     } catch (error) {
+      // createText() lands on the page; ~7 fallible setters (font load,
+      // textAlign/textCase enums, resize) run before appendChild moves it to
+      // the slide — remove the stranded node on any of their throws.
+      var slideTextRemoved = false;
+      if (typeof textNode !== 'undefined' && textNode) {
+        try { textNode.remove(); slideTextRemoved = true; } catch (removeErr) {}
+      }
       console.error('🌉 [Desktop Bridge] Add text to slide error:', error);
       figma.ui.postMessage({
         type: 'ADD_TEXT_TO_SLIDE_RESULT',
         requestId: msg.requestId,
         success: false,
-        error: error.message || String(error)
+        error: (error.message || String(error)) + (slideTextRemoved ? ' (partially-created node was removed)' : '')
       });
     }
   }

package/figma-desktop-bridge/ui.html

@@ -1524,8 +1524,16 @@
               return;
             }
 
-            // Call the handler with a safety timeout, then send back the result
-            var HANDLER_TIMEOUT_MS = 30000;
+            // Call the handler with a safety timeout, then send back the result.
+            // The server includes each command's real budget as timeoutMs
+            // (see websocket-server.ts sendCommand); race against that plus a
+            // 5s margin so the command's own wrapper timeout — which produces
+            // the method-specific error — always fires first. No field (older
+            // server) or an invalid value falls back to the old 30s default.
+            var requestedBudget = (typeof message.timeoutMs === 'number' && isFinite(message.timeoutMs) && message.timeoutMs > 0)
+              ? message.timeoutMs
+              : null;
+            var HANDLER_TIMEOUT_MS = requestedBudget ? Math.min(requestedBudget + 5000, 310000) : 30000;
             var handlerSettled = false;
             var handlerTimeoutId = null;
             var handlerPromise = Promise.resolve(handler(message.params || {}));

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@muloka/figma-console-mcp",
-	"version": "0.4.0",
+	"version": "0.5.1",
 	"forkedFrom": {
 		"name": "figma-console-mcp",
 		"version": "1.36.0",