@mulmoclaude/accounting-plugin 0.2.0 → 0.3.1

package/dist/server.js

@@ -1,4 +1,4 @@
-import { ACCOUNTING_ACTIONS, ACCOUNTING_API, ACCOUNTING_BOOKS_CHANNEL, ACCOUNTING_DIRS, BOOK_EVENT_KINDS, FISCAL_YEAR_ENDS, SUPPORTED_COUNTRY_CODES, TIME_SERIES_GRANULARITIES, TIME_SERIES_METRICS, bookChannel, errorMessage, fiscalYearEndMonth, isFiscalYearEnd, isSupportedCountryCode } from "./shared.js";
+import { ACCOUNTING_ACTIONS, ACCOUNTING_API, ACCOUNTING_BOOKS_CHANNEL, ACCOUNTING_DIRS, BOOK_EVENT_KINDS, FISCAL_YEAR_END_MONTHS, SUPPORTED_COUNTRY_CODES, TIME_SERIES_GRANULARITIES, TIME_SERIES_METRICS, bookChannel, errorMessage, fiscalYearEndMonth, isFiscalYearEnd, isSupportedCountryCode, resolveFiscalYearEnd } from "./shared.js";
 import { Router } from "express";
 import { randomUUID } from "node:crypto";
 import { promises } from "node:fs";
@@ -142,8 +142,27 @@ async function readJsonStrict(filePath) {
 		throw err;
 	}
 }
+/** Migrate a legacy calendar-quarter `fiscalYearEnd` token ("Q1".."Q4")
+*  to its closing-month number in memory so every downstream consumer
+*  (reports, time-series, the UI selects) sees one shape. Absent stays
+*  absent — the field is optional and resolves to the default on read;
+*  we don't stamp an explicit December onto a book that never chose one.
+*  Nothing is written back here (no auto-migrate on disk). */
+function normalizeBookFiscalYearEnd(book) {
+	if (book.fiscalYearEnd === void 0) return book;
+	const resolved = resolveFiscalYearEnd(book.fiscalYearEnd);
+	return book.fiscalYearEnd === resolved ? book : {
+		...book,
+		fiscalYearEnd: resolved
+	};
+}
 async function readConfig(workspaceRoot) {
-	return readJsonStrict(configPath(workspaceRoot));
+	const config = await readJsonStrict(configPath(workspaceRoot));
+	if (!config) return null;
+	return {
+		...config,
+		books: config.books.map(normalizeBookFiscalYearEnd)
+	};
 }
 async function writeConfig(config, workspaceRoot) {
 	await writeJsonAtomic(configPath(workspaceRoot), config);
@@ -1464,29 +1483,47 @@ function unsupportedCountryError(received) {
 	return new AccountingError(400, `unsupported country code ${JSON.stringify(received)} — must be one of: ${SUPPORTED_COUNTRY_CODES.join(", ")}`);
 }
 function unsupportedFiscalYearEndError(received) {
-	return new AccountingError(400, `unsupported fiscalYearEnd ${JSON.stringify(received)} — must be one of: ${FISCAL_YEAR_ENDS.join(", ")}`);
-}
-/** Narrow a free-form `fiscalYearEnd` input. Empty / absent → default
-*  (back-compat with old callers and pre-field on-disk books); any
-*  other value must match the enum or 400. */
-function narrowFiscalYearEnd(raw) {
-	if (raw === void 0 || raw === "") return "Q4";
-	if (!isFiscalYearEnd(raw)) throw unsupportedFiscalYearEndError(raw);
-	return raw;
-}
-/** Boundary checks shared by updateBook. Throws on the first failure
-*  so the surrounding function stays under the cognitive-complexity
-*  threshold; each rule is also unit-testable independently via the
-*  service entry point. */
+	return new AccountingError(400, `unsupported fiscalYearEnd ${JSON.stringify(received)} — must be a closing-month number ${FISCAL_YEAR_END_MONTHS.join(", ")} (1 = January … 12 = December)`);
+}
+/** Coerce + validate a free-form `fiscalYearEnd` from any ingress path
+*  (REST body, MCP tool args, direct callers). The service is the
+*  validation boundary, so this is deliberately tolerant of input SHAPE
+*  but strict about the resulting value:
+*    - absent / null / empty string → `undefined` (field omitted; the
+*      caller decides default-vs-no-op);
+*    - a number, or a numeric string ("8") from a hand-rolled client →
+*      that month;
+*    - a legacy calendar-quarter token ("Q1".."Q4") from a stale client
+*      → its closing month (same Q1→3 mapping the read side applies);
+*    - anything else non-empty (a typo, garbage, an out-of-range or
+*      non-integer number) → 400, echoing the ORIGINAL value so the
+*      bad payload can't be silently mistaken for the default. */
+function coerceFiscalYearEndInput(raw) {
+	if (raw === void 0 || raw === null || raw === "") return void 0;
+	let month = raw;
+	if (typeof raw === "string") {
+		const trimmed = raw.trim();
+		if (trimmed === "") return void 0;
+		if (/^Q[1-4]$/.test(trimmed)) return resolveFiscalYearEnd(trimmed);
+		month = /^-?\d+$/.test(trimmed) ? Number(trimmed) : NaN;
+	}
+	if (!isFiscalYearEnd(month)) throw unsupportedFiscalYearEndError(raw);
+	return month;
+}
+/** Boundary checks shared by updateBook (name / country only —
+*  fiscalYearEnd is coerced + validated separately via
+*  `coerceFiscalYearEndInput`). Throws on the first failure so the
+*  surrounding function stays under the cognitive-complexity threshold;
+*  each rule is also unit-testable independently via the service entry
+*  point. */
 function validateUpdateBookInput(input) {
 	if (input.name !== void 0 && (typeof input.name !== "string" || input.name.trim() === "")) throw new AccountingError(400, "name must be a non-empty string when supplied");
 	if (input.country !== void 0 && input.country !== "" && !isSupportedCountryCode(input.country)) throw unsupportedCountryError(input.country);
-	if (input.fiscalYearEnd !== void 0 && input.fiscalYearEnd !== "" && !isFiscalYearEnd(input.fiscalYearEnd)) throw unsupportedFiscalYearEndError(input.fiscalYearEnd);
 }
 async function createBook(input, workspaceRoot) {
 	if (typeof input.name !== "string" || input.name.trim() === "") throw new AccountingError(400, "name is required");
 	if (input.country !== void 0 && !isSupportedCountryCode(input.country)) throw unsupportedCountryError(input.country);
-	const fiscalYearEnd = narrowFiscalYearEnd(input.fiscalYearEnd);
+	const fiscalYearEnd = coerceFiscalYearEndInput(input.fiscalYearEnd) ?? 12;
 	const config = await loadOrInitConfig(workspaceRoot);
 	const bookId = input.id ?? await generateBookId(config, workspaceRoot);
 	if (!isSafeBookId(bookId)) throw new AccountingError(400, `invalid book id ${JSON.stringify(bookId)} — allowed characters are A-Z a-z 0-9 _ - (1-64 chars; cannot start with _ or -)`);
@@ -1511,11 +1548,12 @@ async function updateBook(input, workspaceRoot) {
 	const target = findBook(config, input.bookId);
 	if (!target) throw new AccountingError(404, `book ${JSON.stringify(input.bookId)} not found`);
 	validateUpdateBookInput(input);
+	const fiscalYearEnd = coerceFiscalYearEndInput(input.fiscalYearEnd);
 	const next = {
 		...target,
 		...input.name !== void 0 ? { name: input.name } : {},
 		...input.country !== void 0 && input.country !== "" ? { country: input.country } : {},
-		...input.fiscalYearEnd !== void 0 && input.fiscalYearEnd !== "" ? { fiscalYearEnd: input.fiscalYearEnd } : {}
+		...fiscalYearEnd !== void 0 ? { fiscalYearEnd } : {}
 	};
 	if (input.country === "") delete next.country;
 	await writeConfig({ books: config.books.map((book) => book.id === input.bookId ? next : book) }, workspaceRoot);
@@ -1800,7 +1838,7 @@ async function loadTimeSeriesBookContext(requestedBookId, workspaceRoot) {
 	const bookId = resolveBookId(config, requestedBookId);
 	return {
 		bookId,
-		fiscalYearEnd: findBook(config, bookId)?.fiscalYearEnd ?? "Q4",
+		fiscalYearEnd: resolveFiscalYearEnd(findBook(config, bookId)?.fiscalYearEnd),
 		accounts: await readAccounts(bookId, workspaceRoot)
 	};
 }
@@ -1911,7 +1949,7 @@ var ACTION_HANDLERS = {
 			name: String(rest.name ?? ""),
 			currency: typeof rest.currency === "string" ? rest.currency : void 0,
 			country: typeof rest.country === "string" ? rest.country : void 0,
-			fiscalYearEnd: typeof rest.fiscalYearEnd === "string" ? rest.fiscalYearEnd : void 0
+			fiscalYearEnd: rest.fiscalYearEnd
 		});
 		return {
 			bookId: result.book.id,
@@ -1923,7 +1961,7 @@ var ACTION_HANDLERS = {
 			bookId: String(rest.bookId ?? ""),
 			name: typeof rest.name === "string" ? rest.name : void 0,
 			country: typeof rest.country === "string" ? rest.country : void 0,
-			fiscalYearEnd: typeof rest.fiscalYearEnd === "string" ? rest.fiscalYearEnd : void 0
+			fiscalYearEnd: rest.fiscalYearEnd
 		});
 		return {
 			bookId: result.book.id,