@mulmoclaude/accounting-plugin 0.2.0 → 0.3.0

package/dist/server.js

@@ -1,4 +1,4 @@
-import { ACCOUNTING_ACTIONS, ACCOUNTING_API, ACCOUNTING_BOOKS_CHANNEL, ACCOUNTING_DIRS, BOOK_EVENT_KINDS, FISCAL_YEAR_ENDS, SUPPORTED_COUNTRY_CODES, TIME_SERIES_GRANULARITIES, TIME_SERIES_METRICS, bookChannel, errorMessage, fiscalYearEndMonth, isFiscalYearEnd, isSupportedCountryCode } from "./shared.js";
+import { ACCOUNTING_ACTIONS, ACCOUNTING_API, ACCOUNTING_BOOKS_CHANNEL, ACCOUNTING_DIRS, BOOK_EVENT_KINDS, FISCAL_YEAR_END_MONTHS, SUPPORTED_COUNTRY_CODES, TIME_SERIES_GRANULARITIES, TIME_SERIES_METRICS, bookChannel, errorMessage, fiscalYearEndMonth, isFiscalYearEnd, isSupportedCountryCode, resolveFiscalYearEnd } from "./shared.js";
 import { Router } from "express";
 import { randomUUID } from "node:crypto";
 import { promises } from "node:fs";
@@ -142,8 +142,27 @@ async function readJsonStrict(filePath) {
 		throw err;
 	}
 }
+/** Migrate a legacy calendar-quarter `fiscalYearEnd` token ("Q1".."Q4")
+*  to its closing-month number in memory so every downstream consumer
+*  (reports, time-series, the UI selects) sees one shape. Absent stays
+*  absent — the field is optional and resolves to the default on read;
+*  we don't stamp an explicit December onto a book that never chose one.
+*  Nothing is written back here (no auto-migrate on disk). */
+function normalizeBookFiscalYearEnd(book) {
+	if (book.fiscalYearEnd === void 0) return book;
+	const resolved = resolveFiscalYearEnd(book.fiscalYearEnd);
+	return book.fiscalYearEnd === resolved ? book : {
+		...book,
+		fiscalYearEnd: resolved
+	};
+}
 async function readConfig(workspaceRoot) {
-	return readJsonStrict(configPath(workspaceRoot));
+	const config = await readJsonStrict(configPath(workspaceRoot));
+	if (!config) return null;
+	return {
+		...config,
+		books: config.books.map(normalizeBookFiscalYearEnd)
+	};
 }
 async function writeConfig(config, workspaceRoot) {
 	await writeJsonAtomic(configPath(workspaceRoot), config);
@@ -1464,13 +1483,13 @@ function unsupportedCountryError(received) {
 	return new AccountingError(400, `unsupported country code ${JSON.stringify(received)} — must be one of: ${SUPPORTED_COUNTRY_CODES.join(", ")}`);
 }
 function unsupportedFiscalYearEndError(received) {
-	return new AccountingError(400, `unsupported fiscalYearEnd ${JSON.stringify(received)} — must be one of: ${FISCAL_YEAR_ENDS.join(", ")}`);
+	return new AccountingError(400, `unsupported fiscalYearEnd ${JSON.stringify(received)} — must be a closing-month number ${FISCAL_YEAR_END_MONTHS.join(", ")} (1 = January … 12 = December)`);
 }
-/** Narrow a free-form `fiscalYearEnd` input. Empty / absent → default
+/** Narrow a free-form `fiscalYearEnd` input. Absent → default
 *  (back-compat with old callers and pre-field on-disk books); any
-*  other value must match the enum or 400. */
+*  other value must be a month number 1-12 or 400. */
 function narrowFiscalYearEnd(raw) {
-	if (raw === void 0 || raw === "") return "Q4";
+	if (raw === void 0) return 12;
 	if (!isFiscalYearEnd(raw)) throw unsupportedFiscalYearEndError(raw);
 	return raw;
 }
@@ -1481,7 +1500,7 @@ function narrowFiscalYearEnd(raw) {
 function validateUpdateBookInput(input) {
 	if (input.name !== void 0 && (typeof input.name !== "string" || input.name.trim() === "")) throw new AccountingError(400, "name must be a non-empty string when supplied");
 	if (input.country !== void 0 && input.country !== "" && !isSupportedCountryCode(input.country)) throw unsupportedCountryError(input.country);
-	if (input.fiscalYearEnd !== void 0 && input.fiscalYearEnd !== "" && !isFiscalYearEnd(input.fiscalYearEnd)) throw unsupportedFiscalYearEndError(input.fiscalYearEnd);
+	if (input.fiscalYearEnd !== void 0 && !isFiscalYearEnd(input.fiscalYearEnd)) throw unsupportedFiscalYearEndError(input.fiscalYearEnd);
 }
 async function createBook(input, workspaceRoot) {
 	if (typeof input.name !== "string" || input.name.trim() === "") throw new AccountingError(400, "name is required");
@@ -1515,7 +1534,7 @@ async function updateBook(input, workspaceRoot) {
 		...target,
 		...input.name !== void 0 ? { name: input.name } : {},
 		...input.country !== void 0 && input.country !== "" ? { country: input.country } : {},
-		...input.fiscalYearEnd !== void 0 && input.fiscalYearEnd !== "" ? { fiscalYearEnd: input.fiscalYearEnd } : {}
+		...input.fiscalYearEnd !== void 0 ? { fiscalYearEnd: input.fiscalYearEnd } : {}
 	};
 	if (input.country === "") delete next.country;
 	await writeConfig({ books: config.books.map((book) => book.id === input.bookId ? next : book) }, workspaceRoot);
@@ -1800,7 +1819,7 @@ async function loadTimeSeriesBookContext(requestedBookId, workspaceRoot) {
 	const bookId = resolveBookId(config, requestedBookId);
 	return {
 		bookId,
-		fiscalYearEnd: findBook(config, bookId)?.fiscalYearEnd ?? "Q4",
+		fiscalYearEnd: resolveFiscalYearEnd(findBook(config, bookId)?.fiscalYearEnd),
 		accounts: await readAccounts(bookId, workspaceRoot)
 	};
 }
@@ -1863,6 +1882,15 @@ function asyncHandler(namespace, fallbackMessage, handler) {
 }
 //#endregion
 //#region src/server/router.ts
+/** Coerce an inbound `fiscalYearEnd` to a number. The UI select and
+*  the LLM tool (JSON-schema `number` enum) both send a number, but a
+*  numeric string ("8") from a hand-rolled client is accepted too so
+*  it isn't silently dropped to `undefined` (→ the December default).
+*  Range validation stays authoritative in the service layer. */
+function coerceFiscalYearEnd(raw) {
+	if (typeof raw === "number") return raw;
+	if (typeof raw === "string" && raw.trim() !== "" && Number.isInteger(Number(raw))) return Number(raw);
+}
 async function handleOpenBook(rest) {
 	if (typeof rest.bookId !== "string" || rest.bookId === "") throw new AccountingError(400, "openBook: bookId is required. Call 'getBooks' to enumerate, or 'createBook' first on a fresh workspace.");
 	const list = await listBooks();
@@ -1911,7 +1939,7 @@ var ACTION_HANDLERS = {
 			name: String(rest.name ?? ""),
 			currency: typeof rest.currency === "string" ? rest.currency : void 0,
 			country: typeof rest.country === "string" ? rest.country : void 0,
-			fiscalYearEnd: typeof rest.fiscalYearEnd === "string" ? rest.fiscalYearEnd : void 0
+			fiscalYearEnd: coerceFiscalYearEnd(rest.fiscalYearEnd)
 		});
 		return {
 			bookId: result.book.id,
@@ -1923,7 +1951,7 @@ var ACTION_HANDLERS = {
 			bookId: String(rest.bookId ?? ""),
 			name: typeof rest.name === "string" ? rest.name : void 0,
 			country: typeof rest.country === "string" ? rest.country : void 0,
-			fiscalYearEnd: typeof rest.fiscalYearEnd === "string" ? rest.fiscalYearEnd : void 0
+			fiscalYearEnd: coerceFiscalYearEnd(rest.fiscalYearEnd)
 		});
 		return {
 			bookId: result.book.id,