@mulmobridge/chat-service 1.2.0 → 1.3.1

package/dist/relay.d.ts

@@ -34,6 +34,8 @@ export interface RelayDeps {
     getRole: (roleId: string) => Role;
     defaultRoleId: string;
     logger: Logger;
+    /** Monotonic milliseconds for the reply limit. Defaults to `performance.now()`. */
+    now?: () => number;
 }
 export declare function createRelay(deps: RelayDeps): RelayFn;
 export declare function resolveDefaultRole(bridgeOptions: Readonly<Record<string, string | number | boolean>> | undefined, getRole: (roleId: string) => Role, fallbackRoleId: string, logger: Logger, transportId: string): string;

package/dist/relay.js

@@ -6,10 +6,9 @@
 // point, session events, role lookup, logger) arrive through
 // `createRelay(deps)` so the module has no direct imports from the
 // host.
-import { EVENT_TYPES } from "@mulmobridge/protocol";
+import { EVENT_TYPES, resolveReplyTimeoutMs } from "@mulmobridge/protocol";
 import { createKeyedSerializer } from "./keyed-serializer.js";
-// ── Constants ────────────────────────────────────────────────
-const REPLY_TIMEOUT_MS = 5 * 60 * 1000;
+import { remainingReplyMs } from "./reply-deadline.js";
 // ── Factory ──────────────────────────────────────────────────
 export function createRelay(deps) {
     const serialize = createKeyedSerializer();
@@ -19,10 +18,19 @@ export function createRelay(deps) {
         // sessions, and split the conversation across them (#1878). The
         // JSON pair is an unambiguous composite key for the two ids.
         const key = JSON.stringify([params.transportId, params.externalChatId]);
-        return serialize.run(key, () => processRelayMessage(deps, params));
+        const budget = {
+            receivedAtMs: clockOf(deps)(),
+            replyTimeoutMs: resolveBridgeReplyTimeout(params.bridgeOptions, deps.logger, params.transportId),
+        };
+        return serialize.run(key, () => processRelayMessage(deps, params, budget));
     };
 }
-async function processRelayMessage(deps, params) {
+// Neutral about the cause: a queue behind an earlier message, or slow setup on an idle chat.
+const EXPIRED_BEFORE_START_REPLY = "The request timed out before the agent could start on it. Please send it again.";
+// Monotonic by default, so a wall-clock step between receipt and processing cannot move the limit.
+const clockOf = (deps) => deps.now ?? (() => performance.now());
+const remainingOf = (budget, deps) => remainingReplyMs(budget.receivedAtMs, budget.replyTimeoutMs, clockOf(deps)());
+async function processRelayMessage(deps, params, budget) {
     const { store, handleCommand, startChat, onSessionEvent, getRole, defaultRoleId, logger } = deps;
     const { transportId, externalChatId, attachments, bridgeOptions } = params;
     let { text } = params;
@@ -62,6 +70,12 @@ async function processRelayMessage(deps, params) {
             chatState = commandResult.nextState;
         text = commandResult.forwardAs;
     }
+    // Checked here, not on entry: a command above still runs and answers at once, but an agent turn
+    // started after the limit would produce a reply nobody is waiting for.
+    if (remainingOf(budget, deps) === 0) {
+        logger.info("chat-service", "message expired before its turn started", { transportId, externalChatId });
+        return { kind: "ok", reply: EXPIRED_BEFORE_START_REPLY };
+    }
     const result = await startChat({
         message: text,
         roleId: chatState.roleId,
@@ -96,7 +110,7 @@ async function processRelayMessage(deps, params) {
         };
     }
     try {
-        const reply = await collectAgentReply(onSessionEvent, chatState.sessionId, params.onChunk);
+        const reply = await collectAgentReply(onSessionEvent, chatState.sessionId, remainingOf(budget, deps), params.onChunk);
         await store.setChatState(transportId, {
             ...chatState,
             updatedAt: new Date().toISOString(),
@@ -139,15 +153,23 @@ export function resolveDefaultRole(bridgeOptions, getRole, fallbackRoleId, logge
     }
     return resolved.id;
 }
+// The bridge client reads the same option for its ack timer, so a bad value
+// is warned about on both ends and both fall back to the same default.
+function resolveBridgeReplyTimeout(bridgeOptions, logger, transportId) {
+    const { replyTimeoutMs, warning } = resolveReplyTimeoutMs(bridgeOptions?.replyTimeoutMs);
+    if (warning)
+        logger.warn("chat-service", "bridge reply timeout option ignored", { transportId, warning });
+    return replyTimeoutMs;
+}
 // Kept out of the factory closure so future packaging doesn't need
 // to re-capture anything; `onSessionEvent` arrives as a plain param.
-function collectAgentReply(onSessionEvent, chatSessionId, onChunk) {
+function collectAgentReply(onSessionEvent, chatSessionId, replyTimeoutMs, onChunk) {
     return new Promise((resolve) => {
         const textChunks = [];
         const timer = setTimeout(() => {
             unsubscribe();
             resolve(textChunks.join("") || "The request timed out before a reply was generated.");
-        }, REPLY_TIMEOUT_MS);
+        }, replyTimeoutMs);
         const unsubscribe = onSessionEvent(chatSessionId, (event) => {
             const type = event.type;
             if (type === EVENT_TYPES.text) {

package/dist/reply-deadline.d.ts

@@ -0,0 +1,2 @@
+/** Milliseconds of the reply limit still left at `nowMs`; never negative. */
+export declare function remainingReplyMs(receivedAtMs: number, replyTimeoutMs: number, nowMs: number): number;

package/dist/reply-deadline.js

@@ -0,0 +1,9 @@
+// A turn's reply limit is counted from when the relay RECEIVED the message,
+// not from when the turn reached the front of its chat's queue. The bridge
+// client starts its ack timer when it sends, so a limit counted from the start
+// of collection let a queued or slow-to-start turn outlive the client's wait
+// and have its reply dropped (#3312).
+/** Milliseconds of the reply limit still left at `nowMs`; never negative. */
+export function remainingReplyMs(receivedAtMs, replyTimeoutMs, nowMs) {
+    return Math.max(0, receivedAtMs + replyTimeoutMs - nowMs);
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mulmobridge/chat-service",
-  "version": "1.2.0",
+  "version": "1.3.1",
   "description": "Server-side chat service for MulmoBridge — socket.io + REST bridge to Claude Code agents",
   "type": "module",
   "main": "./dist/index.js",
@@ -20,14 +20,14 @@
   "scripts": {
     "build": "tsc",
     "prepack": "yarn build",
-    "typecheck": "tsc --noEmit",
+    "typecheck": "tsc -p tsconfig.typecheck.json",
     "test": "tsx --test test/test_*.ts",
     "lint": "eslint src test"
   },
   "license": "MIT",
   "author": "Receptron Team",
   "dependencies": {
-    "@mulmobridge/protocol": "^1.0.1"
+    "@mulmobridge/protocol": "^1.1.0"
   },
   "peerDependencies": {
     "express": "^5.0.0",