@mui/internal-code-infra 0.1.1-canary.24 → 0.1.1-canary.26

package/build/cli/cmdBuild.d.mts

@@ -35,6 +35,10 @@ export type Args = {
      * - Whether to skip checking for main field in package.json.
      */
     skipMainCheck: boolean;
+    /**
+     * - Whether to skip validating the output directory with publint.
+     */
+    skipPublint: boolean;
     /**
      * - Globs to be ignored by Babel.
      */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mui/internal-code-infra",
-  "version": "0.1.1-canary.24",
+  "version": "0.1.1-canary.26",
   "author": "MUI Team",
   "description": "Infra scripts and configs to be used across MUI repos.",
   "license": "MIT",
@@ -116,6 +116,7 @@
     "node-html-parser": "^9.0.5",
     "open": "^11.0.4",
     "postcss-styled-syntax": "^0.7.4",
+    "publint": "^0.3.25",
     "regexp.escape": "^2.0.1",
     "rehype-slug": "^6.0.0",
     "rehype-stringify": "^10.0.1",
@@ -191,7 +192,7 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitSha": "d14c1ec7e620c0bf10d09090e718ff376a8a190d",
+  "gitSha": "cb47b4587dd0f55f095a4fe67c059dd8baf2acba",
   "scripts": {
     "build": "tsc -p tsconfig.build.json",
     "typescript": "tsc -noEmit",

package/src/cli/cmdBuild.mjs

@@ -28,6 +28,7 @@ import { readPnpmConfig } from '../utils/pnpm.mjs';
  * @property {boolean} skipBabelRuntimeCheck - Whether to skip checking for Babel runtime dependencies in the package.
  * @property {boolean} skipPackageJson - Whether to skip generating the package.json file in the bundle output.
  * @property {boolean} skipMainCheck - Whether to skip checking for main field in package.json.
+ * @property {boolean} skipPublint - Whether to skip validating the output directory with publint.
  * @property {string[]} ignore - Globs to be ignored by Babel.
  * @property {string[]} [copy] - Files/Directories to be copied. Can be a glob pattern.
  * @property {boolean} [enableReactCompiler] - Whether to use the React compiler.
@@ -216,6 +217,11 @@ export default /** @type {import('yargs').CommandModule<{}, Args>} */ ({
         default: false,
         description: 'Skip checking for main field in package.json.',
       })
+      .option('skipPublint', {
+        type: 'boolean',
+        default: false,
+        description: 'Skip validating the output directory with publint.',
+      })
       .option('copy', {
         type: 'string',
         array: true,
@@ -392,9 +398,48 @@ export default /** @type {import('yargs').CommandModule<{}, Args>} */ ({
       buildDir,
       verbose: args.verbose,
     });
+
+    if (!args.skipPublint) {
+      await validateWithPublint(buildDir);
+    }
   },
 });
 
+/**
+ * Lints the output directory with publint. Errors fail the build, warnings are only reported.
+ * @param {string} buildDir - The build directory to validate.
+ * @returns {Promise<void>}
+ */
+async function validateWithPublint(buildDir) {
+  const [{ publint }, { formatMessage }] = await Promise.all([
+    import('publint'),
+    import('publint/utils'),
+  ]);
+  // Everything in the output directory is published, so there is nothing to pack.
+  const result = await publint({ pkgDir: buildDir, pack: false, level: 'warning' });
+  const { pkg } = result;
+  // TODO: remove this filter and bump publint to >=0.3.25, which ships the fix from
+  // https://github.com/publint/publint/pull/265 (publint checks `browser` values
+  // that point at another package as local files).
+  const messages = result.messages.filter((message) => {
+    if (message.code !== 'FILE_DOES_NOT_EXIST' || message.path[0] !== 'browser') {
+      return true;
+    }
+    const value = message.path.length === 2 ? pkg.browser?.[message.path[1]] : undefined;
+    return typeof value !== 'string' || value.startsWith('.');
+  });
+
+  for (const message of messages) {
+    const log = message.type === 'error' ? console.error : console.warn;
+    log(`publint ${message.type}: ${formatMessage(message, pkg)}`);
+  }
+
+  const errorCount = messages.filter((message) => message.type === 'error').length;
+  if (errorCount > 0) {
+    throw new Error(`publint found ${errorCount} error(s) in "${buildDir}".`);
+  }
+}
+
 /**
  * @param {Object} param0
  * @param {string} param0.cwd - The current working directory.

package/src/eslint/testConfig.mjs

@@ -91,6 +91,9 @@ export function createTestConfig() {
         '@typescript-eslint/no-non-null-asserted-optional-chain': 'off',
         // end migration
         'vitest/prefer-importing-vitest-globals': 'error',
+        // Vitest accepts a failure message as the second argument of `expect`, also when it is
+        // not a literal.
+        'vitest/valid-expect': ['error', { maxArgs: 2 }],
       },
     },
   );