@mui/internal-code-infra 0.1.1-canary.22 → 0.1.1-canary.24

package/build/eslint/index.d.mts

@@ -1,4 +1,5 @@
 export * from './baseConfig.mjs';
 export * from './docsConfig.mjs';
+export * from './nodeSupportConfig.mjs';
 export * from './testConfig.mjs';
 export * from './extensions.mjs';

package/build/eslint/nodeSupportConfig.d.mts

@@ -0,0 +1,11 @@
+/**
+ * Reports syntax, ECMAScript built-ins and Node.js APIs in package sources that the Node.js
+ * versions allowed by the package's "engines.node" don't support. The ESM bundle is compiled for
+ * the "stable" browserslist environment rather than for "engines.node", and nothing polyfills
+ * built-ins, so all of them reach Node.js consumers as written.
+ * Only packages that declare "engines.node", meaning they're intended to run in Node.js, are
+ * checked.
+ * @param {string} baseDirectory - The repository root. File patterns are resolved against it.
+ * @returns {import('eslint').Linter.Config[]}
+ */
+export declare function createNodeSupportConfig(baseDirectory: string): import('eslint').Linter.Config[];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mui/internal-code-infra",
-  "version": "0.1.1-canary.22",
+  "version": "0.1.1-canary.24",
   "author": "MUI Team",
   "description": "Infra scripts and configs to be used across MUI repos.",
   "license": "MIT",
@@ -67,23 +67,23 @@
     "@eslint/compat": "^2.1.1",
     "@eslint/js": "^10.0.1",
     "@eslint/json": "^2.1.1",
-    "@inquirer/confirm": "^6.3.3",
-    "@inquirer/select": "^5.2.6",
+    "@inquirer/confirm": "^6.3.4",
+    "@inquirer/select": "^5.2.7",
     "@mui/internal-babel-plugin-display-name": "2.0.1-canary.2",
     "@mui/internal-babel-plugin-minify-errors": "3.0.1-canary.2",
     "@mui/internal-babel-plugin-resolve-imports": "3.0.1-canary.3",
-    "@napi-rs/keyring": "^2.1.1",
+    "@napi-rs/keyring": "^2.1.2",
     "@octokit/auth-action": "^6.0.3",
     "@octokit/oauth-methods": "^6.0.5",
     "@octokit/plugin-retry": "^8.1.1",
     "@octokit/plugin-throttling": "^11.0.5",
     "@octokit/rest": "^22.0.1",
-    "@pnpm/config.version-policy": "^1100.2.8",
+    "@pnpm/config.version-policy": "^1100.2.9",
     "@pnpm/find-workspace-dir": "^1000.1.5",
     "@pnpm/parse-wanted-dependency": "^1001.0.0",
-    "@typescript-eslint/types": "^8.71.2",
-    "@typescript-eslint/utils": "^8.71.2",
-    "@vitest/eslint-plugin": "^1.6.27",
+    "@typescript-eslint/types": "^8.72.0",
+    "@typescript-eslint/utils": "^8.72.0",
+    "@vitest/eslint-plugin": "^1.6.28",
     "babel-plugin-optimize-clsx": "^2.6.2",
     "babel-plugin-react-compiler": "^1.0.0",
     "babel-plugin-transform-import-meta": "^3.1.0",
@@ -100,19 +100,20 @@
     "eslint-plugin-compat": "^7.0.2",
     "eslint-plugin-import": "^2.32.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
-    "eslint-plugin-mdx": "^3.8.1",
+    "eslint-plugin-mdx": "^3.8.2",
+    "eslint-plugin-n": "^18.5.0",
     "eslint-plugin-package-json": "^1.10.1",
     "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-compiler": "^19.1.0-rc.2",
     "eslint-plugin-react-hooks": "^7.1.1",
     "eslint-plugin-testing-library": "^7.16.2",
-    "execa": "^10.1.1",
+    "execa": "^10.2.0",
     "git-url-parse": "^16.1.0",
     "globals": "^17.13.0",
     "globby": "^16.2.4",
-    "html-validate": "^11.16.2",
+    "html-validate": "^11.17.0",
     "minimatch": "^10.2.6",
-    "node-html-parser": "^9.0.4",
+    "node-html-parser": "^9.0.5",
     "open": "^11.0.4",
     "postcss-styled-syntax": "^0.7.4",
     "regexp.escape": "^2.0.1",
@@ -137,7 +138,7 @@
     "resolve-pkg-maps": "^1.0.0",
     "semver": "^7.8.5",
     "stylelint-config-standard": "^40.0.0",
-    "typescript-eslint": "^8.71.2",
+    "typescript-eslint": "^8.72.0",
     "unified": "^11.0.5",
     "unified-lint-rule": "^3.0.1",
     "unist-util-visit": "^5.1.0",
@@ -166,10 +167,10 @@
     "@types/mdast": "4.0.4",
     "@types/regexp.escape": "2.0.0",
     "@types/yargs": "17.0.35",
-    "@typescript-eslint/parser": "8.71.2",
-    "@typescript-eslint/rule-tester": "8.71.2",
+    "@typescript-eslint/parser": "8.72.0",
+    "@typescript-eslint/rule-tester": "8.72.0",
     "@typescript/native": "npm:typescript@7.0.2",
-    "eslint": "10.12.0",
+    "eslint": "10.13.0",
     "get-port": "7.2.0",
     "prettier": "3.9.10",
     "remark": "15.0.1",
@@ -190,7 +191,7 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitSha": "7be938414716e74df30e861271c65d7885da8c98",
+  "gitSha": "d14c1ec7e620c0bf10d09090e718ff376a8a190d",
   "scripts": {
     "build": "tsc -p tsconfig.build.json",
     "typescript": "tsc -noEmit",

package/src/eslint/baseConfig.mjs

@@ -3,6 +3,7 @@ import eslintJs from '@eslint/js';
 import { defineConfig } from 'eslint/config';
 import prettier from 'eslint-config-prettier/flat';
 import compatPlugin from 'eslint-plugin-compat';
+import nPlugin from 'eslint-plugin-n';
 import importPlugin from 'eslint-plugin-import';
 import jsxA11yPlugin from 'eslint-plugin-jsx-a11y';
 import reactPlugin from 'eslint-plugin-react';
@@ -17,6 +18,7 @@ import { createCoreConfig } from './mui/config.mjs';
 import muiPlugin from './mui/index.mjs';
 import { EXTENSION_TS } from './extensions.mjs';
 import { createJsonConfig } from './jsonConfig.mjs';
+import { createNodeSupportConfig } from './nodeSupportConfig.mjs';
 import { createPackageJsonConfig } from './packageJsonConfig.mjs';
 
 /**
@@ -59,6 +61,9 @@ export function createBaseConfig({
       },
       plugins: {
         mui: muiPlugin,
+        // Registered once for all files, so consumers can enable `n/*` rules without registering
+        // a second, possibly different, instance of the plugin.
+        n: nPlugin,
       },
       settings: {
         react: {
@@ -74,6 +79,7 @@ export function createBaseConfig({
     includeIgnoreIfExists(path.join(baseDirectory, '.gitignore'), `Ignore rules from .gitignore`),
     includeIgnoreIfExists(path.join(baseDirectory, '.lintignore'), `Ignore rules from .lintignore`),
     createJsonConfig(),
+    createNodeSupportConfig(baseDirectory),
     createPackageJsonConfig(),
     prettier,
     // Markdown + MDX linting via eslint-plugin-mdx. Severities for markdown

package/src/eslint/index.mjs

@@ -3,5 +3,6 @@
 
 export * from './baseConfig.mjs';
 export * from './docsConfig.mjs';
+export * from './nodeSupportConfig.mjs';
 export * from './testConfig.mjs';
 export * from './extensions.mjs';

package/src/eslint/nodeSupportConfig.mjs

@@ -0,0 +1,70 @@
+import * as fs from 'node:fs';
+import * as path from 'node:path';
+import { defineConfig } from 'eslint/config';
+import nPlugin from 'eslint-plugin-n';
+import { globbySync } from 'globby';
+import { EXTENSION_TEST_FILE, EXTENSION_TS } from './extensions.mjs';
+
+/**
+ * Finds the packages in the `packages*` directories of the repository that declare the Node.js
+ * versions they support in "engines.node". Packages without it, like development tooling, run
+ * on the repository's own Node.js version.
+ * @param {string} baseDirectory
+ * @returns {string[]} Package directories, relative to `baseDirectory`.
+ */
+function findPackageDirsWithEnginesNode(baseDirectory) {
+  return globbySync('packages*/*/package.json', { cwd: baseDirectory })
+    .filter((packageJsonPath) => {
+      const packageJson = JSON.parse(
+        fs.readFileSync(path.join(baseDirectory, packageJsonPath), 'utf8'),
+      );
+      return typeof packageJson.engines?.node === 'string';
+    })
+    .map((packageJsonPath) => path.posix.dirname(packageJsonPath));
+}
+
+/**
+ * Reports syntax, ECMAScript built-ins and Node.js APIs in package sources that the Node.js
+ * versions allowed by the package's "engines.node" don't support. The ESM bundle is compiled for
+ * the "stable" browserslist environment rather than for "engines.node", and nothing polyfills
+ * built-ins, so all of them reach Node.js consumers as written.
+ * Only packages that declare "engines.node", meaning they're intended to run in Node.js, are
+ * checked.
+ * @param {string} baseDirectory - The repository root. File patterns are resolved against it.
+ * @returns {import('eslint').Linter.Config[]}
+ */
+export function createNodeSupportConfig(baseDirectory) {
+  const packageDirs = findPackageDirsWithEnginesNode(baseDirectory);
+  if (packageDirs.length === 0) {
+    return [];
+  }
+  return defineConfig([
+    {
+      name: 'Node.js support of package sources',
+      basePath: baseDirectory,
+      files: packageDirs.map((packageDir) => `${packageDir}/src/**/*${EXTENSION_TS}`),
+      ignores: [`**/*${EXTENSION_TEST_FILE}`, `**/*.spec${EXTENSION_TS}`],
+      plugins: { n: nPlugin },
+      rules: {
+        'n/no-unsupported-features/es-builtins': 'error',
+        'n/no-unsupported-features/es-syntax': 'error',
+        'n/no-unsupported-features/node-builtins': [
+          'error',
+          // Browser APIs that Node.js also exposes, behind an experimental flag. In packages that
+          // combine Node.js tooling with browser code, these refer to the browser API.
+          {
+            ignores: [
+              'localStorage',
+              'sessionStorage',
+              'Storage',
+              'navigator',
+              'Navigator',
+              'Worker',
+              'ErrorEvent',
+            ],
+          },
+        ],
+      },
+    },
+  ]);
+}