@mui/internal-code-infra 0.1.1-canary.13 → 0.1.1-canary.15

package/README.md

@@ -14,9 +14,9 @@ This is stored in the `docs` top-level directory.
 
 1. Go to the publish action -
 
-- [Base UI](https://github.com/mui/base-ui/actions/workflows/publish.yml)
+- [Base UI](https://github.com/mui/base-ui/actions/workflows/publish.yml)
 - [Core](https://github.com/mui/material-ui/actions/workflows/publish.yml)
-- [MUI X](https://github.com/mui/mui-x/actions/workflows/publish.yml)
+- [MUI X](https://github.com/mui/mui-x/actions/workflows/publish.yml)
 
 2. Choose "Run workflow" dropdown
 
@@ -59,7 +59,7 @@ If publishing fails with npm asking for `otp`, run the command again with 6 digi
 pnpm code-infra publish-new-package --otp=123456
 ```
 
-3. Go to the settings link for each package, e.g., `https://www.npmjs.com/package/<pkg-name>/access`, and setup `Trusted Publisher`.
+3. Go to the settings link for each package, for example, `https://www.npmjs.com/package/<pkg-name>/access`, and setup `Trusted Publisher`.
 4. In the `Select your publisher` step in the above link, click on the `GitHub Actions` button to configure GitHub Actions-based trusted publishing.
 5. Fill in the details of the repo -
    1. `Organization or user` as `mui`,

package/build/utils/build.d.mts

@@ -93,6 +93,20 @@ export declare function validatePkgJson(packageJson: Record<string, any>, option
     skipMainCheck?: boolean;
     enableReactCompiler?: boolean;
 }): void;
+/**
+ * Validates that "engines.node" in package.json doesn't allow Node.js versions older than the
+ * "node" browserslist environment, which the CommonJS bundle is compiled for. Otherwise the
+ * build can emit syntax that the oldest supported Node.js version can't run.
+ * Targets are resolved the same way `@babel/preset-env` resolves them during the build.
+ * @param {{ name?: string; engines?: { node?: string } }} packageJson
+ * @param {string} cwd - The package directory, used to find the browserslist config.
+ */
+export declare function validateEnginesNode(packageJson: {
+    name?: string;
+    engines?: {
+        node?: string;
+    };
+}, cwd: string): void;
 /**
  * Marks the start and end of a function execution for performance measurement.
  * Uses the Performance API to create marks and measure the duration.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mui/internal-code-infra",
-  "version": "0.1.1-canary.13",
+  "version": "0.1.1-canary.15",
   "author": "MUI Team",
   "description": "Infra scripts and configs to be used across MUI repos.",
   "license": "MIT",
@@ -56,6 +56,7 @@
     "@argos-ci/core": "6.8.7",
     "@babel/cli": "^8.0.6",
     "@babel/core": "^8.0.7",
+    "@babel/helper-compilation-targets": "^8.0.7",
     "@babel/plugin-syntax-jsx": "^8.0.1",
     "@babel/plugin-syntax-typescript": "^8.0.3",
     "@babel/plugin-transform-react-pure-annotations": "^8.0.1",
@@ -189,7 +190,7 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitSha": "abd0d2ce073f905bfa623ebf593a5d37de499b72",
+  "gitSha": "4ee02d8d0a78249ef9aadb30f919489c56b89ebe",
   "scripts": {
     "build": "tsc -p tsconfig.build.json",
     "typescript": "tsc -noEmit",

package/src/cli/cmdBuild.mjs

@@ -12,6 +12,7 @@ import {
   createPackageExports,
   createPackageImports,
   getOutExtension,
+  validateEnginesNode,
   validatePkgJson,
 } from '../utils/build.mjs';
 import { readPnpmConfig } from '../utils/pnpm.mjs';
@@ -266,6 +267,7 @@ export default /** @type {import('yargs').CommandModule<{}, Args>} */ ({
     const pkgJsonPath = path.join(cwd, 'package.json');
     const packageJson = JSON.parse(await fs.readFile(pkgJsonPath, { encoding: 'utf8' }));
     validatePkgJson(packageJson, { skipMainCheck: args.skipMainCheck, enableReactCompiler });
+    validateEnginesNode(packageJson, cwd);
 
     const buildDirBase = /** @type {string} */ (packageJson.publishConfig?.directory);
     const buildDir = path.join(cwd, buildDirBase);

package/src/utils/build.mjs

@@ -1,5 +1,6 @@
 import * as fs from 'node:fs/promises';
 import * as path from 'node:path';
+import getTargets from '@babel/helper-compilation-targets';
 import { globby } from 'globby';
 import * as semver from 'semver';
 
@@ -867,6 +868,39 @@ export function validatePkgJson(packageJson, options = {}) {
   }
 }
 
+/**
+ * Validates that "engines.node" in package.json doesn't allow Node.js versions older than the
+ * "node" browserslist environment, which the CommonJS bundle is compiled for. Otherwise the
+ * build can emit syntax that the oldest supported Node.js version can't run.
+ * Targets are resolved the same way `@babel/preset-env` resolves them during the build.
+ * @param {{ name?: string; engines?: { node?: string } }} packageJson
+ * @param {string} cwd - The package directory, used to find the browserslist config.
+ */
+export function validateEnginesNode(packageJson, cwd) {
+  const enginesNode = packageJson.engines?.node;
+  if (!enginesNode) {
+    return;
+  }
+
+  const minEnginesVersion = semver.minVersion(enginesNode);
+  if (!minEnginesVersion) {
+    throw new Error(
+      `Unable to determine the minimum Node.js version from "engines.node" in "${packageJson.name}" package.json: "${enginesNode}".`,
+    );
+  }
+
+  const targetNode = getTargets(undefined, { configPath: cwd, browserslistEnv: 'node' }).node;
+  if (!targetNode) {
+    return;
+  }
+
+  if (semver.gt(targetNode, minEnginesVersion)) {
+    throw new Error(
+      `"engines.node" in "${packageJson.name}" package.json allows Node.js ${minEnginesVersion.version}, but the "node" browserslist environment compiles for Node.js ${targetNode} and up. Raise "engines.node" to at least ${targetNode}, or lower the "node" browserslist target.`,
+    );
+  }
+}
+
 /**
  * Marks the start and end of a function execution for performance measurement.
  * Uses the Performance API to create marks and measure the duration.