@mui/internal-code-infra 0.0.4-canary.8 → 0.0.4-canary.81

package/src/eslint/mui/config.mjs

@@ -1,4 +1,5 @@
 import { defineConfig } from 'eslint/config';
+import { EXTENSION_DTS } from '../extensions.mjs';
 
 const restrictedMethods = ['setTimeout', 'setInterval', 'clearTimeout', 'clearInterval'];
 
@@ -414,10 +415,12 @@ export function createCoreConfig(options = {}) {
               'mui/material-ui-no-styled-box': 'error',
             }
           : {}),
+        'mui/no-guarded-throw': 'error',
         'mui/straight-quotes': 'off',
         'mui/consistent-production-guard': 'error',
         'mui/add-undef-to-optional': 'off',
         'mui/flatten-parentheses': 'warn',
+        'mui/no-presentation-role': 'off',
 
         'react-hooks/exhaustive-deps': [
           'error',
@@ -460,9 +463,9 @@ export function createCoreConfig(options = {}) {
         'react/state-in-constructor': 'off',
         // stylistic opinion. For conditional assignment we want it outside, otherwise as static
         'react/static-property-placement': 'off',
-        // noopener is enough
-        // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-target-blank.md#rule-options
-        'react/jsx-no-target-blank': ['error', { allowReferrer: true }],
+        // This rule is outdated, rel are no longer needed for security on target="_blank" links.
+        // See https://github.com/mui/material-ui/pull/40447 for more details.
+        'react/jsx-no-target-blank': 'off',
 
         'no-restricted-syntax': [
           'error',
@@ -499,6 +502,15 @@ export function createCoreConfig(options = {}) {
             message: 'Do not call `Error(...)` without `new`. Use `new Error(...)` instead.',
             selector: "CallExpression[callee.name='Error']",
           },
+          {
+            // xmlns="http://www.w3.org/2000/svg" is only needed on standalone .svg files so the
+            // browser treats them as SVG instead of generic XML. Inside HTML the <svg> element is
+            // already recognised by the browser, so the attribute is dead weight.
+            // https://github.com/mui/mui-public/pull/1321
+            message:
+              'Remove xmlns from inline <svg>. The attribute is redundant in HTML and adds unnecessary bytes.',
+            selector: 'JSXOpeningElement[name.name="svg"] > JSXAttribute[name.name="xmlns"]',
+          },
           ...restrictedSyntaxRules,
         ],
 
@@ -515,9 +527,10 @@ export function createCoreConfig(options = {}) {
               '@typescript-eslint/consistent-type-imports': [
                 'error',
                 {
-                  fixStyle: 'inline-type-imports',
+                  fixStyle: 'separate-type-imports',
                 },
               ],
+              'import/consistent-type-specifier-style': ['error', 'prefer-top-level'],
             }
           : {}),
         // Prevent the use of `e` as a shorthand for `event`, `error`, etc.
@@ -525,5 +538,12 @@ export function createCoreConfig(options = {}) {
         '@typescript-eslint/return-await': 'off',
       },
     },
+    {
+      name: 'mui-base/dts',
+      files: [`**/*${EXTENSION_DTS}`],
+      rules: {
+        '@typescript-eslint/consistent-type-imports': 'off',
+      },
+    },
   ]);
 }

package/src/eslint/mui/index.mjs

@@ -4,6 +4,7 @@ import disallowReactApiInServerComponents from './rules/disallow-react-api-in-se
 import docgenIgnoreBeforeComment from './rules/docgen-ignore-before-comment.mjs';
 import muiNameMatchesComponentName from './rules/mui-name-matches-component-name.mjs';
 import noEmptyBox from './rules/no-empty-box.mjs';
+import noGuardedThrow from './rules/no-guarded-throw.mjs';
 import noRestrictedResolvedImports from './rules/no-restricted-resolved-imports.mjs';
 import noStyledBox from './rules/no-styled-box.mjs';
 import requireDevWrapper from './rules/require-dev-wrapper.mjs';
@@ -11,6 +12,8 @@ import rulesOfUseThemeVariants from './rules/rules-of-use-theme-variants.mjs';
 import straightQuotes from './rules/straight-quotes.mjs';
 import addUndefToOptional from './rules/add-undef-to-optional.mjs';
 import flattenParentheses from './rules/flatten-parentheses.mjs';
+import noPresentationRole from './rules/no-presentation-role.mjs';
+import noFloatingCleanup from './rules/no-floating-cleanup.mjs';
 
 /** @type {import('eslint').ESLint.Plugin} */
 const muiPlugin = {
@@ -22,6 +25,7 @@ const muiPlugin = {
     'consistent-production-guard': consistentProductionGuard,
     'disallow-active-element-as-key-event-target': disallowActiveElementAsKeyEventTarget,
     'docgen-ignore-before-comment': docgenIgnoreBeforeComment,
+    'no-guarded-throw': noGuardedThrow,
     'material-ui-name-matches-component-name': muiNameMatchesComponentName,
     'material-ui-rules-of-use-theme-variants': rulesOfUseThemeVariants,
     'material-ui-no-empty-box': noEmptyBox,
@@ -33,6 +37,8 @@ const muiPlugin = {
     // Some discrepancies between TypeScript and ESLint types - casting to any
     'add-undef-to-optional': /** @type {any} */ (addUndefToOptional),
     'flatten-parentheses': /** @type {any} */ (flattenParentheses),
+    'no-presentation-role': noPresentationRole,
+    'no-floating-cleanup': /** @type {any} */ (noFloatingCleanup),
   },
 };
 

package/src/eslint/mui/rules/no-floating-cleanup.mjs

@@ -0,0 +1,187 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+import ts from 'typescript';
+
+/**
+ * no-floating-cleanup
+ *
+ * Like `@typescript-eslint/no-floating-promises`, but for functions: reports
+ * call expressions used as statements whose return value is a function
+ * (e.g. an `unsubscribe` / cleanup callback). Ignoring such a value usually
+ * means the subscription can never be torn down — a leak.
+ *
+ * Requires type information (parserOptions.project / projectService).
+ *
+ * Calls whose resolved signature declares a `this` return type are never
+ * reported: fluent / builder APIs (e.g. d3 scales) chain by returning `this`,
+ * so the discarded result is callable but not a leaked cleanup function.
+ *
+ * Opt-out at a call site, same convention as no-floating-promises:
+ *   void subscribe(cb);
+ */
+
+const RULE_NAME = 'no-floating-cleanup';
+
+const createRule = ESLintUtils.RuleCreator(
+  (name) =>
+    `https://github.com/mui/mui-public/blob/master/packages/code-infra/src/eslint/mui/rules/${name}.mjs`,
+);
+
+export default createRule({
+  meta: {
+    type: 'problem',
+    docs: {
+      description:
+        'Disallow ignoring returned cleanup/unsubscribe functions, which leaks subscriptions.',
+    },
+    messages: {
+      floatingCleanup:
+        "Return value of type '{{typeName}}' is ignored. This likely leaks a subscription — " +
+        'store the cleanup function, or discard it explicitly with the `void` operator.',
+    },
+    schema: [],
+  },
+  name: RULE_NAME,
+  defaultOptions: [],
+  create(context) {
+    const services = ESLintUtils.getParserServices(context);
+    const checker = services.program.getTypeChecker();
+
+    /**
+     * Does this type (or any union member) look like a cleanup function?
+     * @param {import('typescript').Type} type
+     * @returns {boolean}
+     */
+    function isCleanupType(type) {
+      if (type.isUnion()) {
+        return type.types.some(isCleanupType);
+      }
+      // Never fire on any/unknown/never — too noisy and not provable.
+      // eslint-disable-next-line no-bitwise -- TypeScript type flags are a bitmask
+      if (type.flags & (ts.TypeFlags.Any | ts.TypeFlags.Unknown | ts.TypeFlags.Never)) {
+        return false;
+      }
+
+      return checker.getSignaturesOfType(type, ts.SignatureKind.Call).length > 0;
+    }
+
+    /**
+     * @param {import('typescript').Type} type
+     * @returns {string}
+     */
+    function describeType(type) {
+      return (type.aliasSymbol && type.aliasSymbol.getName()) || checker.typeToString(type);
+    }
+
+    /**
+     * Does this call resolve to a signature that returns `this`? Fluent /
+     * builder APIs (e.g. d3 scales) chain by returning `this`, so the
+     * discarded result is callable but never a leaked cleanup function —
+     * those calls should not be reported. Covers both an explicit `: this`
+     * annotation and an inferred `this` return (no annotation).
+     * @param {import('@typescript-eslint/utils').TSESTree.Node} estreeCall
+     * @returns {boolean}
+     */
+    function returnsThis(estreeCall) {
+      /** @type {import('typescript').Node | undefined} */
+      let tsNode = services.esTreeNodeToTSNodeMap.get(estreeCall);
+      // Unwrap `await (...)` / parens down to the underlying call.
+      while (tsNode && (ts.isAwaitExpression(tsNode) || ts.isParenthesizedExpression(tsNode))) {
+        tsNode = tsNode.expression;
+      }
+      if (!tsNode || !(ts.isCallExpression(tsNode) || ts.isNewExpression(tsNode))) {
+        return false;
+      }
+      const declaration = checker.getResolvedSignature(tsNode)?.getDeclaration();
+      if (!declaration) {
+        return false;
+      }
+      // Explicit `: this` annotation.
+      if (declaration.type?.kind === ts.SyntaxKind.ThisType) {
+        return true;
+      }
+      // Inferred `this` return: the *declared* (uninstantiated) signature's
+      // return type is the polymorphic `this` type, which prints as `this`.
+      // (The resolved signature would have it bound to the receiver type.)
+      const declaredSignature = checker.getSignatureFromDeclaration(declaration);
+      return (
+        !!declaredSignature &&
+        checker.typeToString(checker.getReturnTypeOfSignature(declaredSignature)) === 'this'
+      );
+    }
+
+    /**
+     * Unwrap an expression-statement expression down to the calls whose
+     * results are being discarded. Mirrors the cases no-floating-promises
+     * handles: plain calls, optional chains, `await`, comma sequences,
+     * and the operand(s) of unary / logical / conditional expressions.
+     * A top-level `void` operator is the explicit opt-out, so we stop there.
+     * @param {import('@typescript-eslint/utils').TSESTree.Node} expr
+     * @param {import('@typescript-eslint/utils').TSESTree.Node[]} [out]
+     * @returns {import('@typescript-eslint/utils').TSESTree.Node[]}
+     */
+    function findDiscardedCalls(expr, out = []) {
+      switch (expr.type) {
+        case 'CallExpression':
+        case 'NewExpression':
+          out.push(expr);
+          break;
+        case 'ChainExpression':
+          findDiscardedCalls(expr.expression, out);
+          break;
+        case 'AwaitExpression':
+          // type of the AwaitExpression node is already the awaited type
+          if (expr.argument.type === 'CallExpression' || expr.argument.type === 'ChainExpression') {
+            out.push(expr);
+          }
+          break;
+        case 'UnaryExpression':
+          // `void expr` is the explicit opt-out; any other unary operator
+          // (e.g. `!subscribe()`) still discards the operand's result.
+          if (expr.operator !== 'void') {
+            findDiscardedCalls(expr.argument, out);
+          }
+          break;
+        case 'LogicalExpression':
+          // `a && subscribe()`, `a || subscribe()`, `a ?? subscribe()`:
+          // either side may be the discarded value.
+          findDiscardedCalls(expr.left, out);
+          findDiscardedCalls(expr.right, out);
+          break;
+        case 'ConditionalExpression':
+          // `cond ? subscribe() : other()`: the branches are discarded,
+          // not the test.
+          findDiscardedCalls(expr.consequent, out);
+          findDiscardedCalls(expr.alternate, out);
+          break;
+        case 'SequenceExpression':
+          // every value except the last is discarded; the last one is the
+          // statement's value, which is also discarded here
+          expr.expressions.forEach((subExpr) => findDiscardedCalls(subExpr, out));
+          break;
+        default:
+          break;
+      }
+      return out;
+    }
+
+    return {
+      /** @param {import('@typescript-eslint/utils').TSESTree.ExpressionStatement} node */
+      ExpressionStatement(node) {
+        findDiscardedCalls(node.expression).forEach((call) => {
+          // Fluent/builder calls return `this` for chaining — not a leak.
+          if (returnsThis(call)) {
+            return;
+          }
+          const type = services.getTypeAtLocation(call);
+          if (isCleanupType(type)) {
+            context.report({
+              node: call,
+              messageId: 'floatingCleanup',
+              data: { typeName: describeType(type) },
+            });
+          }
+        });
+      },
+    };
+  },
+});

package/src/eslint/mui/rules/no-guarded-throw.mjs

@@ -0,0 +1,115 @@
+import { isProcessEnvNodeEnv } from './nodeEnvUtils.mjs';
+
+/**
+ * Recursively checks if process.env.NODE_ENV appears anywhere in the node tree
+ * @param {import('estree').Node | null | undefined} node
+ * @returns {boolean}
+ */
+function containsProcessEnvNodeEnv(node) {
+  if (!node || typeof node !== 'object') {
+    return false;
+  }
+
+  if (isProcessEnvNodeEnv(node)) {
+    return true;
+  }
+
+  // Traverse all child nodes, skipping parent references to avoid circular traversal
+  for (const key of Object.keys(node)) {
+    if (key === 'parent') {
+      continue;
+    }
+    const child = /** @type {unknown} */ (/** @type {any} */ (node)[key]);
+    if (Array.isArray(child)) {
+      if (child.some(containsProcessEnvNodeEnv)) {
+        return true;
+      }
+    } else if (
+      child &&
+      typeof child === 'object' &&
+      /** @type {import('estree').Node} */ (child).type
+    ) {
+      if (containsProcessEnvNodeEnv(/** @type {import('estree').Node} */ (child))) {
+        return true;
+      }
+    }
+  }
+  return false;
+}
+
+/**
+ * ESLint rule that disallows throw statements guarded by process.env.NODE_ENV checks.
+ *
+ * NODE_ENV guards cause throw statements to only execute in certain environments,
+ * leading to inconsistent control flow between development and production. Whether
+ * the guard excludes production (tree-shaking the throw away) or targets production
+ * specifically, the result is environment-dependent behavior that should be avoided.
+ *
+ * The rule stops at function boundaries, so throws inside functions defined within
+ * a NODE_ENV guard are not flagged, as the function may be called from other contexts.
+ *
+ * @example
+ * // Invalid - throw only in development, removed in production
+ * if (process.env.NODE_ENV !== 'production') {
+ *   throw new Error('Missing required prop');
+ * }
+ *
+ * @example
+ * // Invalid - throw only in production
+ * if (process.env.NODE_ENV === 'production') {
+ *   throw new Error('Production-only error');
+ * }
+ *
+ * @example
+ * // Valid - unconditional throw
+ * throw new Error('Something went wrong');
+ *
+ * @type {import('eslint').Rule.RuleModule}
+ */
+const rule = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description:
+        'Disallow throw statements guarded by process.env.NODE_ENV checks, as they cause environment-dependent control flow',
+    },
+    messages: {
+      guardedThrow:
+        'Do not guard `throw` statements with `process.env.NODE_ENV` checks. Guarded throws execute only in certain environments, causing inconsistent control flow between development and production.',
+    },
+    schema: [],
+  },
+  create(context) {
+    return {
+      ThrowStatement(node) {
+        /** @type {import('eslint').Rule.Node | null} */
+        let current = node.parent;
+        /** @type {import('eslint').Rule.Node} */
+        let currentChild = node;
+
+        while (current) {
+          if (
+            current.type === 'FunctionDeclaration' ||
+            current.type === 'FunctionExpression' ||
+            current.type === 'ArrowFunctionExpression'
+          ) {
+            break;
+          }
+          if (current.type === 'IfStatement') {
+            const isInConsequent = current.consequent === currentChild;
+            const isInAlternate = current.alternate === currentChild;
+
+            if ((isInConsequent || isInAlternate) && containsProcessEnvNodeEnv(current.test)) {
+              context.report({ node, messageId: 'guardedThrow' });
+              return;
+            }
+          }
+          currentChild = current;
+          current = current.parent;
+        }
+      },
+    };
+  },
+};
+
+export default rule;

package/src/eslint/mui/rules/no-presentation-role.mjs

@@ -0,0 +1,60 @@
+/**
+ * @type {import('eslint').Rule.RuleModule}
+ */
+const rule = {
+  meta: {
+    docs: {
+      description:
+        'Disallow role="presentation" in favor of role="none". Both are equivalent, but role="none" is clearer and shorter.',
+    },
+    messages: {
+      noPresentation:
+        'Use role="none" instead of role="presentation". They are equivalent, but role="none" is preferred.',
+    },
+    fixable: 'code',
+    type: 'suggestion',
+    schema: [],
+  },
+  create(context) {
+    return {
+      /** @param {import('estree-jsx').JSXAttribute} node */
+      JSXAttribute(node) {
+        if (node.name.type !== 'JSXIdentifier' || node.name.name !== 'role') {
+          return;
+        }
+
+        const { value } = node;
+
+        // role="presentation"
+        if (value !== null && value.type === 'Literal' && value.value === 'presentation') {
+          context.report({
+            node,
+            messageId: 'noPresentation',
+            fix(fixer) {
+              return fixer.replaceText(value, '"none"');
+            },
+          });
+          return;
+        }
+
+        // role={'presentation'}
+        if (
+          value !== null &&
+          value.type === 'JSXExpressionContainer' &&
+          value.expression.type === 'Literal' &&
+          value.expression.value === 'presentation'
+        ) {
+          context.report({
+            node,
+            messageId: 'noPresentation',
+            fix(fixer) {
+              return fixer.replaceText(value, '"none"');
+            },
+          });
+        }
+      },
+    };
+  },
+};
+
+export default rule;

package/src/eslint/mui/rules/nodeEnvUtils.mjs

@@ -39,3 +39,55 @@ export function isLiteralEq(node, value) {
 export function isLiteralNeq(node, value) {
   return node.type === 'Literal' && node.value !== value;
 }
+
+/**
+ * Checks if a BinaryExpression compares process.env.NODE_ENV with === or !==
+ * @param {import('estree').Node} node
+ * @returns {boolean}
+ */
+export function isNodeEnvBinaryComparison(node) {
+  return (
+    node.type === 'BinaryExpression' &&
+    (node.operator === '===' || node.operator === '!==') &&
+    (isProcessEnvNodeEnv(node.left) || isProcessEnvNodeEnv(node.right))
+  );
+}
+
+/**
+ * Walks up the parent chain and checks if the node is inside an IfStatement
+ * whose test is a NODE_ENV binary comparison.
+ * If a callback is provided, it is called with the IfStatement and the direct
+ * child that leads to the node. The function returns true only when the callback
+ * returns true. Without a callback the function returns true when the node is
+ * inside any branch (consequent or alternate) of such an IfStatement.
+ * @param {import('eslint').Rule.Node} node
+ * @param {(ifStatement: import('estree').IfStatement & import('eslint').Rule.NodeParentExtension, child: import('eslint').Rule.Node) => boolean} [callback]
+ * @returns {boolean}
+ */
+export function isInsideNodeEnvCheck(node, callback) {
+  /** @type {import('eslint').Rule.Node | null} */
+  let current = node.parent;
+  /** @type {import('eslint').Rule.Node} */
+  let currentChild = node;
+
+  while (current) {
+    if (current.type === 'IfStatement' && isNodeEnvBinaryComparison(current.test)) {
+      if (callback) {
+        if (callback(current, currentChild)) {
+          return true;
+        }
+      } else {
+        const isInConsequent = current.consequent === currentChild;
+        const isInAlternate = current.alternate === currentChild;
+        if (isInConsequent || isInAlternate) {
+          return true;
+        }
+      }
+    }
+
+    currentChild = current;
+    current = current.parent;
+  }
+
+  return false;
+}

package/src/eslint/mui/rules/require-dev-wrapper.mjs

@@ -1,4 +1,9 @@
-import { isProcessEnvNodeEnv, isLiteralEq, isLiteralNeq } from './nodeEnvUtils.mjs';
+import {
+  isProcessEnvNodeEnv,
+  isLiteralEq,
+  isLiteralNeq,
+  isInsideNodeEnvCheck,
+} from './nodeEnvUtils.mjs';
 
 /**
  * ESLint rule that enforces certain function calls to be wrapped with
@@ -58,18 +63,21 @@ const rule = {
     const functionNames = options.functionNames || ['warnOnce', 'warn', 'checkSlot'];
 
     /**
-     * Checks if a binary expression is comparing process.env.NODE_ENV appropriately
-     * @param {import('estree').BinaryExpression} binaryExpression - The binary expression to check
+     * Checks if an expression is comparing process.env.NODE_ENV appropriately
+     * @param {import('estree').Expression} expression - The expression to check
      * @param {string} operator - The expected comparison operator (===, !==, etc.)
      * @param {string} value - The value to compare with
      * @returns {boolean}
      */
-    function isNodeEnvComparison(binaryExpression, operator, value) {
-      const { left, right } = binaryExpression;
+    function isNodeEnvComparison(expression, operator, value) {
+      if (expression.type !== 'BinaryExpression') {
+        return false;
+      }
+      const { left, right } = expression;
 
       // Check for exact match with the specified value
       if (
-        binaryExpression.operator === operator &&
+        expression.operator === operator &&
         ((isProcessEnvNodeEnv(left) && isLiteralEq(right, value)) ||
           (isProcessEnvNodeEnv(right) && isLiteralEq(left, value)))
       ) {
@@ -79,7 +87,7 @@ const rule = {
       // For !== operator also allow === with any literal value that's NOT 'production'
       if (
         operator === '!==' &&
-        binaryExpression.operator === '===' &&
+        expression.operator === '===' &&
         ((isProcessEnvNodeEnv(left) && isLiteralNeq(right, value)) ||
           (isProcessEnvNodeEnv(right) && isLiteralNeq(left, value)))
       ) {
@@ -95,41 +103,18 @@ const rule = {
      * @returns {boolean}
      */
     function isWrappedInProductionCheck(node) {
-      /** @type {import('eslint').Rule.Node | null} */
-      let current = node.parent;
-      /** @type {import('eslint').Rule.Node} */
-      let currentChild = node;
-
-      while (current) {
-        // Check if we're inside an if statement
-        if (current.type === 'IfStatement') {
-          // Determine which branch we're in
-          const isInConsequent = current.consequent === currentChild;
-          const isInAlternate = current.alternate === currentChild;
-
-          // Skip if not in a branch
-          if (isInConsequent || isInAlternate) {
-            const test = current.test;
+      return isInsideNodeEnvCheck(node, (ifStatement, child) => {
+        const isInConsequent = ifStatement.consequent === child;
+        const isInAlternate = ifStatement.alternate === child;
 
-            // If we're in the consequent, we need !==
-            // If we're in the alternate (else), we need ===
-            const operator = isInConsequent ? '!==' : '===';
-
-            // Check for the specific pattern with the right operator
-            if (
-              test.type === 'BinaryExpression' &&
-              isNodeEnvComparison(test, operator, 'production')
-            ) {
-              return true;
-            }
-          }
+        if (isInConsequent || isInAlternate) {
+          // If we're in the consequent, we need !==
+          // If we're in the alternate (else), we need ===
+          const operator = isInConsequent ? '!==' : '===';
+          return isNodeEnvComparison(ifStatement.test, operator, 'production');
         }
-
-        currentChild = current;
-        current = current.parent;
-      }
-
-      return false;
+        return false;
+      });
     }
 
     return {

package/src/estree-typescript.d.ts

@@ -1,4 +1,4 @@
-import { BaseExpression, Expression } from 'estree';
+import type { BaseExpression, Expression } from 'estree';
 
 export * from 'estree';