@mui/internal-code-infra 0.0.4-canary.31 → 0.0.4-canary.33

package/build/eslint/mui/rules/no-guarded-throw.d.mts

@@ -0,0 +1,31 @@
+/**
+ * ESLint rule that disallows throw statements guarded by process.env.NODE_ENV checks.
+ *
+ * NODE_ENV guards cause throw statements to only execute in certain environments,
+ * leading to inconsistent control flow between development and production. Whether
+ * the guard excludes production (tree-shaking the throw away) or targets production
+ * specifically, the result is environment-dependent behavior that should be avoided.
+ *
+ * The rule stops at function boundaries, so throws inside functions defined within
+ * a NODE_ENV guard are not flagged, as the function may be called from other contexts.
+ *
+ * @example
+ * // Invalid - throw only in development, removed in production
+ * if (process.env.NODE_ENV !== 'production') {
+ *   throw new Error('Missing required prop');
+ * }
+ *
+ * @example
+ * // Invalid - throw only in production
+ * if (process.env.NODE_ENV === 'production') {
+ *   throw new Error('Production-only error');
+ * }
+ *
+ * @example
+ * // Valid - unconditional throw
+ * throw new Error('Something went wrong');
+ *
+ * @type {import('eslint').Rule.RuleModule}
+ */
+declare const rule: import('eslint').Rule.RuleModule;
+export default rule;

package/build/eslint/mui/rules/nodeEnvUtils.d.mts

@@ -21,3 +21,21 @@ export declare function isLiteralEq(node: import('estree').Node, value: string):
  * @returns {boolean}
  */
 export declare function isLiteralNeq(node: import('estree').Node, value: string): boolean;
+/**
+ * Checks if a BinaryExpression compares process.env.NODE_ENV with === or !==
+ * @param {import('estree').Node} node
+ * @returns {boolean}
+ */
+export declare function isNodeEnvBinaryComparison(node: import('estree').Node): boolean;
+/**
+ * Walks up the parent chain and checks if the node is inside an IfStatement
+ * whose test is a NODE_ENV binary comparison.
+ * If a callback is provided, it is called with the IfStatement and the direct
+ * child that leads to the node. The function returns true only when the callback
+ * returns true. Without a callback the function returns true when the node is
+ * inside any branch (consequent or alternate) of such an IfStatement.
+ * @param {import('eslint').Rule.Node} node
+ * @param {(ifStatement: import('estree').IfStatement & import('eslint').Rule.NodeParentExtension, child: import('eslint').Rule.Node) => boolean} [callback]
+ * @returns {boolean}
+ */
+export declare function isInsideNodeEnvCheck(node: import('eslint').Rule.Node, callback?: (ifStatement: import('estree').IfStatement & import('eslint').Rule.NodeParentExtension, child: import('eslint').Rule.Node) => boolean): boolean;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mui/internal-code-infra",
-  "version": "0.0.4-canary.31",
+  "version": "0.0.4-canary.33",
   "author": "MUI Team",
   "description": "Infra scripts and configs to be used across MUI repos.",
   "license": "MIT",
@@ -120,8 +120,8 @@
     "unified": "^11.0.5",
     "yargs": "^18.0.0",
     "@mui/internal-babel-plugin-display-name": "1.0.4-canary.18",
-    "@mui/internal-babel-plugin-minify-errors": "2.0.8-canary.27",
-    "@mui/internal-babel-plugin-resolve-imports": "2.0.7-canary.36"
+    "@mui/internal-babel-plugin-resolve-imports": "2.0.7-canary.36",
+    "@mui/internal-babel-plugin-minify-errors": "2.0.8-canary.27"
   },
   "peerDependencies": {
     "@next/eslint-plugin-next": "*",
@@ -168,7 +168,7 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitSha": "b5ecb08ed447855ed858e123d924a08949b6ad6d",
+  "gitSha": "9f107efaadc47ab0bd7c7474b69c9099e5c46dd7",
   "scripts": {
     "build": "tsgo -p tsconfig.build.json",
     "typescript": "tsgo -noEmit",

package/src/eslint/mui/config.mjs

@@ -1,5 +1,6 @@
 // TODO: change back to 'eslint/config' once https://github.com/eslint/rewrite/issues/425 is fixed
 import { defineConfig } from '@eslint/config-helpers';
+import { EXTENSION_DTS } from '../extensions.mjs';
 
 const restrictedMethods = ['setTimeout', 'setInterval', 'clearTimeout', 'clearInterval'];
 
@@ -415,6 +416,7 @@ export function createCoreConfig(options = {}) {
               'mui/material-ui-no-styled-box': 'error',
             }
           : {}),
+        'mui/no-guarded-throw': 'error',
         'mui/straight-quotes': 'off',
         'mui/consistent-production-guard': 'error',
         'mui/add-undef-to-optional': 'off',
@@ -535,5 +537,12 @@ export function createCoreConfig(options = {}) {
         '@typescript-eslint/return-await': 'off',
       },
     },
+    {
+      name: 'mui-base/dts',
+      files: [`**/*${EXTENSION_DTS}`],
+      rules: {
+        '@typescript-eslint/consistent-type-imports': 'off',
+      },
+    },
   ]);
 }

package/src/eslint/mui/index.mjs

@@ -4,6 +4,7 @@ import disallowReactApiInServerComponents from './rules/disallow-react-api-in-se
 import docgenIgnoreBeforeComment from './rules/docgen-ignore-before-comment.mjs';
 import muiNameMatchesComponentName from './rules/mui-name-matches-component-name.mjs';
 import noEmptyBox from './rules/no-empty-box.mjs';
+import noGuardedThrow from './rules/no-guarded-throw.mjs';
 import noRestrictedResolvedImports from './rules/no-restricted-resolved-imports.mjs';
 import noStyledBox from './rules/no-styled-box.mjs';
 import requireDevWrapper from './rules/require-dev-wrapper.mjs';
@@ -22,6 +23,7 @@ const muiPlugin = {
     'consistent-production-guard': consistentProductionGuard,
     'disallow-active-element-as-key-event-target': disallowActiveElementAsKeyEventTarget,
     'docgen-ignore-before-comment': docgenIgnoreBeforeComment,
+    'no-guarded-throw': noGuardedThrow,
     'material-ui-name-matches-component-name': muiNameMatchesComponentName,
     'material-ui-rules-of-use-theme-variants': rulesOfUseThemeVariants,
     'material-ui-no-empty-box': noEmptyBox,

package/src/eslint/mui/rules/no-guarded-throw.mjs

@@ -0,0 +1,115 @@
+import { isProcessEnvNodeEnv } from './nodeEnvUtils.mjs';
+
+/**
+ * Recursively checks if process.env.NODE_ENV appears anywhere in the node tree
+ * @param {import('estree').Node | null | undefined} node
+ * @returns {boolean}
+ */
+function containsProcessEnvNodeEnv(node) {
+  if (!node || typeof node !== 'object') {
+    return false;
+  }
+
+  if (isProcessEnvNodeEnv(node)) {
+    return true;
+  }
+
+  // Traverse all child nodes, skipping parent references to avoid circular traversal
+  for (const key of Object.keys(node)) {
+    if (key === 'parent') {
+      continue;
+    }
+    const child = /** @type {unknown} */ (/** @type {any} */ (node)[key]);
+    if (Array.isArray(child)) {
+      if (child.some(containsProcessEnvNodeEnv)) {
+        return true;
+      }
+    } else if (
+      child &&
+      typeof child === 'object' &&
+      /** @type {import('estree').Node} */ (child).type
+    ) {
+      if (containsProcessEnvNodeEnv(/** @type {import('estree').Node} */ (child))) {
+        return true;
+      }
+    }
+  }
+  return false;
+}
+
+/**
+ * ESLint rule that disallows throw statements guarded by process.env.NODE_ENV checks.
+ *
+ * NODE_ENV guards cause throw statements to only execute in certain environments,
+ * leading to inconsistent control flow between development and production. Whether
+ * the guard excludes production (tree-shaking the throw away) or targets production
+ * specifically, the result is environment-dependent behavior that should be avoided.
+ *
+ * The rule stops at function boundaries, so throws inside functions defined within
+ * a NODE_ENV guard are not flagged, as the function may be called from other contexts.
+ *
+ * @example
+ * // Invalid - throw only in development, removed in production
+ * if (process.env.NODE_ENV !== 'production') {
+ *   throw new Error('Missing required prop');
+ * }
+ *
+ * @example
+ * // Invalid - throw only in production
+ * if (process.env.NODE_ENV === 'production') {
+ *   throw new Error('Production-only error');
+ * }
+ *
+ * @example
+ * // Valid - unconditional throw
+ * throw new Error('Something went wrong');
+ *
+ * @type {import('eslint').Rule.RuleModule}
+ */
+const rule = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description:
+        'Disallow throw statements guarded by process.env.NODE_ENV checks, as they cause environment-dependent control flow',
+    },
+    messages: {
+      guardedThrow:
+        'Do not guard `throw` statements with `process.env.NODE_ENV` checks. Guarded throws execute only in certain environments, causing inconsistent control flow between development and production.',
+    },
+    schema: [],
+  },
+  create(context) {
+    return {
+      ThrowStatement(node) {
+        /** @type {import('eslint').Rule.Node | null} */
+        let current = node.parent;
+        /** @type {import('eslint').Rule.Node} */
+        let currentChild = node;
+
+        while (current) {
+          if (
+            current.type === 'FunctionDeclaration' ||
+            current.type === 'FunctionExpression' ||
+            current.type === 'ArrowFunctionExpression'
+          ) {
+            break;
+          }
+          if (current.type === 'IfStatement') {
+            const isInConsequent = current.consequent === currentChild;
+            const isInAlternate = current.alternate === currentChild;
+
+            if ((isInConsequent || isInAlternate) && containsProcessEnvNodeEnv(current.test)) {
+              context.report({ node, messageId: 'guardedThrow' });
+              return;
+            }
+          }
+          currentChild = current;
+          current = current.parent;
+        }
+      },
+    };
+  },
+};
+
+export default rule;

package/src/eslint/mui/rules/no-guarded-throw.test.mjs

@@ -0,0 +1,206 @@
+import eslint from 'eslint';
+import parser from '@typescript-eslint/parser';
+import rule from './no-guarded-throw.mjs';
+
+const ruleTester = new eslint.RuleTester({
+  languageOptions: {
+    parser,
+  },
+});
+
+ruleTester.run('no-guarded-throw', rule, {
+  valid: [
+    // Should pass: Unconditional throw
+    {
+      code: `
+throw new Error('Something went wrong');
+      `,
+    },
+    // Should pass: Throw inside a non-NODE_ENV conditional
+    {
+      code: `
+if (value == null) {
+  throw new TypeError('value is required');
+}
+      `,
+    },
+    // Should pass: Throw inside a catch block (no NODE_ENV guard)
+    {
+      code: `
+try {
+  doSomething();
+} catch (error) {
+  throw new Error('Failed');
+}
+      `,
+    },
+    // Should pass: Throw inside arrow function inside NODE_ENV guard
+    {
+      code: `
+if (process.env.NODE_ENV !== 'production') {
+  const fn = () => {
+    throw new Error('inside arrow function');
+  };
+}
+      `,
+    },
+    // Should pass: Throw inside function expression inside NODE_ENV guard
+    {
+      code: `
+if (process.env.NODE_ENV !== 'production') {
+  const fn = function () {
+    throw new Error('inside function expression');
+  };
+}
+      `,
+    },
+    // Should pass: Throw inside function declaration inside NODE_ENV guard
+    {
+      code: `
+if (process.env.NODE_ENV !== 'production') {
+  function validate() {
+    throw new Error('inside function declaration');
+  }
+}
+      `,
+    },
+  ],
+  invalid: [
+    // Should fail: Throw inside !== 'production' guard
+    {
+      code: `
+if (process.env.NODE_ENV !== 'production') {
+  throw new Error('Dev-only error');
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+    // Should fail: Throw inside === 'production' guard
+    {
+      code: `
+if (process.env.NODE_ENV === 'production') {
+  throw new Error('Prod-only error');
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+    // Should fail: Throw in else block of === 'production' check
+    {
+      code: `
+if (process.env.NODE_ENV === 'production') {
+  // production path
+} else {
+  throw new Error('Non-production error');
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+    // Should fail: Throw nested inside NODE_ENV guard
+    {
+      code: `
+if (process.env.NODE_ENV !== 'production') {
+  if (value == null) {
+    throw new TypeError('value is required');
+  }
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+    // Should fail: Reversed comparison (literal on left)
+    {
+      code: `
+if ('production' !== process.env.NODE_ENV) {
+  throw new Error('Dev-only error');
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+    // Should fail: Throw in loop inside NODE_ENV guard
+    {
+      code: `
+if (process.env.NODE_ENV !== 'production') {
+  for (const item of items) {
+    throw new Error('Invalid item');
+  }
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+    // Should fail: NODE_ENV combined with other conditions using &&
+    {
+      code: `
+if (process.env.NODE_ENV !== 'production' && value == null) {
+  throw new TypeError('value is required');
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+    // Should fail: NODE_ENV combined with other conditions using ||
+    {
+      code: `
+if (condition || process.env.NODE_ENV === 'test') {
+  throw new Error('Test or condition error');
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+    // Should fail: Unary not on process.env.NODE_ENV
+    {
+      code: `
+if (!process.env.NODE_ENV) {
+  throw new Error('NODE_ENV not set');
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+    // Should fail: NODE_ENV passed to a function
+    {
+      code: `
+if (fn(process.env.NODE_ENV)) {
+  throw new Error('Function check failed');
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+    // Should fail: Throw inside try/catch inside NODE_ENV guard
+    {
+      code: `
+if (process.env.NODE_ENV !== 'production') {
+  try {
+    doSomething();
+  } catch (error) {
+    throw new Error('caught inside guard');
+  }
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+    // Should fail: Throw deeply nested in control flow inside NODE_ENV guard
+    {
+      code: `
+if (process.env.NODE_ENV !== 'production') {
+  if (value == null) {
+    for (const item of items) {
+      if (!item.valid) {
+        throw new Error('invalid item');
+      }
+    }
+  }
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+    // Should fail: Throw inside switch/case inside NODE_ENV guard
+    {
+      code: `
+if (process.env.NODE_ENV !== 'production') {
+  switch (type) {
+    case 'a':
+      throw new Error('invalid type a');
+  }
+}
+      `,
+      errors: [{ messageId: 'guardedThrow' }],
+    },
+  ],
+});

package/src/eslint/mui/rules/nodeEnvUtils.mjs

@@ -39,3 +39,55 @@ export function isLiteralEq(node, value) {
 export function isLiteralNeq(node, value) {
   return node.type === 'Literal' && node.value !== value;
 }
+
+/**
+ * Checks if a BinaryExpression compares process.env.NODE_ENV with === or !==
+ * @param {import('estree').Node} node
+ * @returns {boolean}
+ */
+export function isNodeEnvBinaryComparison(node) {
+  return (
+    node.type === 'BinaryExpression' &&
+    (node.operator === '===' || node.operator === '!==') &&
+    (isProcessEnvNodeEnv(node.left) || isProcessEnvNodeEnv(node.right))
+  );
+}
+
+/**
+ * Walks up the parent chain and checks if the node is inside an IfStatement
+ * whose test is a NODE_ENV binary comparison.
+ * If a callback is provided, it is called with the IfStatement and the direct
+ * child that leads to the node. The function returns true only when the callback
+ * returns true. Without a callback the function returns true when the node is
+ * inside any branch (consequent or alternate) of such an IfStatement.
+ * @param {import('eslint').Rule.Node} node
+ * @param {(ifStatement: import('estree').IfStatement & import('eslint').Rule.NodeParentExtension, child: import('eslint').Rule.Node) => boolean} [callback]
+ * @returns {boolean}
+ */
+export function isInsideNodeEnvCheck(node, callback) {
+  /** @type {import('eslint').Rule.Node | null} */
+  let current = node.parent;
+  /** @type {import('eslint').Rule.Node} */
+  let currentChild = node;
+
+  while (current) {
+    if (current.type === 'IfStatement' && isNodeEnvBinaryComparison(current.test)) {
+      if (callback) {
+        if (callback(current, currentChild)) {
+          return true;
+        }
+      } else {
+        const isInConsequent = current.consequent === currentChild;
+        const isInAlternate = current.alternate === currentChild;
+        if (isInConsequent || isInAlternate) {
+          return true;
+        }
+      }
+    }
+
+    currentChild = current;
+    current = current.parent;
+  }
+
+  return false;
+}

package/src/eslint/mui/rules/require-dev-wrapper.mjs

@@ -1,4 +1,9 @@
-import { isProcessEnvNodeEnv, isLiteralEq, isLiteralNeq } from './nodeEnvUtils.mjs';
+import {
+  isProcessEnvNodeEnv,
+  isLiteralEq,
+  isLiteralNeq,
+  isInsideNodeEnvCheck,
+} from './nodeEnvUtils.mjs';
 
 /**
  * ESLint rule that enforces certain function calls to be wrapped with
@@ -58,18 +63,21 @@ const rule = {
     const functionNames = options.functionNames || ['warnOnce', 'warn', 'checkSlot'];
 
     /**
-     * Checks if a binary expression is comparing process.env.NODE_ENV appropriately
-     * @param {import('estree').BinaryExpression} binaryExpression - The binary expression to check
+     * Checks if an expression is comparing process.env.NODE_ENV appropriately
+     * @param {import('estree').Expression} expression - The expression to check
      * @param {string} operator - The expected comparison operator (===, !==, etc.)
      * @param {string} value - The value to compare with
      * @returns {boolean}
      */
-    function isNodeEnvComparison(binaryExpression, operator, value) {
-      const { left, right } = binaryExpression;
+    function isNodeEnvComparison(expression, operator, value) {
+      if (expression.type !== 'BinaryExpression') {
+        return false;
+      }
+      const { left, right } = expression;
 
       // Check for exact match with the specified value
       if (
-        binaryExpression.operator === operator &&
+        expression.operator === operator &&
         ((isProcessEnvNodeEnv(left) && isLiteralEq(right, value)) ||
           (isProcessEnvNodeEnv(right) && isLiteralEq(left, value)))
       ) {
@@ -79,7 +87,7 @@ const rule = {
       // For !== operator also allow === with any literal value that's NOT 'production'
       if (
         operator === '!==' &&
-        binaryExpression.operator === '===' &&
+        expression.operator === '===' &&
         ((isProcessEnvNodeEnv(left) && isLiteralNeq(right, value)) ||
           (isProcessEnvNodeEnv(right) && isLiteralNeq(left, value)))
       ) {
@@ -95,41 +103,18 @@ const rule = {
      * @returns {boolean}
      */
     function isWrappedInProductionCheck(node) {
-      /** @type {import('eslint').Rule.Node | null} */
-      let current = node.parent;
-      /** @type {import('eslint').Rule.Node} */
-      let currentChild = node;
-
-      while (current) {
-        // Check if we're inside an if statement
-        if (current.type === 'IfStatement') {
-          // Determine which branch we're in
-          const isInConsequent = current.consequent === currentChild;
-          const isInAlternate = current.alternate === currentChild;
-
-          // Skip if not in a branch
-          if (isInConsequent || isInAlternate) {
-            const test = current.test;
+      return isInsideNodeEnvCheck(node, (ifStatement, child) => {
+        const isInConsequent = ifStatement.consequent === child;
+        const isInAlternate = ifStatement.alternate === child;
 
-            // If we're in the consequent, we need !==
-            // If we're in the alternate (else), we need ===
-            const operator = isInConsequent ? '!==' : '===';
-
-            // Check for the specific pattern with the right operator
-            if (
-              test.type === 'BinaryExpression' &&
-              isNodeEnvComparison(test, operator, 'production')
-            ) {
-              return true;
-            }
-          }
+        if (isInConsequent || isInAlternate) {
+          // If we're in the consequent, we need !==
+          // If we're in the alternate (else), we need ===
+          const operator = isInConsequent ? '!==' : '===';
+          return isNodeEnvComparison(ifStatement.test, operator, 'production');
         }
-
-        currentChild = current;
-        current = current.parent;
-      }
-
-      return false;
+        return false;
+      });
     }
 
     return {