@mui/internal-code-infra 0.0.4-canary.13 → 0.0.4-canary.14

package/README.md

@@ -45,13 +45,13 @@ pnpm code-infra publish-new-package
 
 This command detects the new public packages in the repo and asks for your confirmation before publishing them to the npm registry. Add the `--dryRun` flag to skip the actual publishing.
 
-2. Goto the settings link for each packages, ie, https://www.npmjs.com/package/<pkg-name>/access , and setup `Trusted Publisher`.
+2. Goto the settings link for each packages, ie, `https://www.npmjs.com/package/<pkg-name>/access` , and setup `Trusted Publisher`.
 3. In `Select your publisher` step in the above link, click on the `Github Actions` button to configure Github actions based trusted publishing.
 4. Fill in the details of the repo -
    1. `Organization or user` as `mui`,
    2. `Repository` as per the new package
    3. `Workflow filename*` should be `publish.yml`
-   4. `Environment name` should be `npm-publish`
+   4. `Environment name` should be `npm-publish` or `npm-publish-internal` based on whether the package is user facing package or internal package respectively.
 5. In the `Publishing access` section, toggle the recommended option of `Require two-factor authentication and disallow tokens`.
 6. Finally, save the changes by clicking on `Update Package Settings` button.
 

package/build/utils/pnpm.d.mts

@@ -69,10 +69,12 @@ export type GetTransitiveDependenciesOptions = {
 /**
  * Get all transitive workspace dependencies for a set of packages.
  *
- * Traverses `dependencies`, `peerDependencies`, and optionally `devDependencies`,
- * following only packages that exist in `workspacePathByName`. Results are cached
- * per package so each package is read from disk at most once regardless of how many
- * roots depend on it.
+ * Only follows deps whose version spec starts with `workspace:` (e.g. `workspace:*`
+ * or `workspace:^`), meaning they are sourced directly from the monorepo. Pinned
+ * external versions (e.g. `^1.0.0`) are ignored even when the package name exists
+ * in the workspace. Traverses `dependencies` and optionally `devDependencies`.
+ * Results are cached per package so each package is read from disk at most once
+ * regardless of how many roots depend on it.
  *
  * @param {string[]} packageNames - Package names to start the traversal from
  * @param {GetTransitiveDependenciesOptions} [options]
@@ -80,7 +82,28 @@ export type GetTransitiveDependenciesOptions = {
  */
 export declare function getTransitiveDependencies(packageNames: string[], options?: GetTransitiveDependenciesOptions): Promise<Set<string>>;
 /**
- * Validate that a set of packages covers all of their transitive workspace dependencies,
+ * Pure validation logic: given a publish set and workspace maps, checks that all
+ * transitive hard workspace dependencies are covered and none are private.
+ *
+ * A hard dependency is one listed in `dependencies` (not `peerDependencies` or
+ * `devDependencies`) using a `workspace:` version specifier (e.g. `workspace:*` or
+ * `workspace:^`). Peer dependencies are never bundled and dev dependencies are not installed
+ * on consumer devices - both are excluded regardless of version specifier. Pinned-version
+ * references in `dependencies` are also excluded - they resolve from the registry and do
+ * not need to be co-published.
+ *
+ * @param {PublicPackage[]} packages - The packages intended for publishing
+ * @param {Map<string, PublicPackage | PrivatePackage>} workspacePackageByName - All workspace packages by name
+ * @param {Map<string, string>} workspacePathByName - Map of workspace package name to directory path
+ * @returns {Promise<{issues: string[]}>}
+ *   List of human-readable issue strings. Empty when the dependency set is valid.
+ * @internal
+ */
+export declare function checkPublishDependencies(packages: PublicPackage[], workspacePackageByName: Map<string, PublicPackage | PrivatePackage>, workspacePathByName: Map<string, string>): Promise<{
+    issues: string[];
+}>;
+/**
+ * Validate that a set of packages covers all of their transitive hard workspace dependencies,
  * and that none of those dependencies are private (which would make them unpublishable).
  *
  * @param {PublicPackage[]} packages - The packages intended for publishing

package/build/utils/testUtils.d.mts

@@ -0,0 +1,7 @@
+/**
+ * Creates a temporary directory and registers an `onTestFinished` hook to
+ * remove it automatically when the current test ends — even if the test throws.
+ *
+ * @returns {Promise<string>} The path of the created temporary directory.
+ */
+export declare function makeTempDir(): Promise<string>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mui/internal-code-infra",
-  "version": "0.0.4-canary.13",
+  "version": "0.0.4-canary.14",
   "description": "Infra scripts and configs to be used across MUI repos.",
   "type": "module",
   "license": "MIT",
@@ -117,8 +117,8 @@
     "unified": "^11.0.5",
     "yargs": "^18.0.0",
     "@mui/internal-babel-plugin-display-name": "1.0.4-canary.15",
-    "@mui/internal-babel-plugin-resolve-imports": "2.0.7-canary.33",
-    "@mui/internal-babel-plugin-minify-errors": "2.0.8-canary.24"
+    "@mui/internal-babel-plugin-minify-errors": "2.0.8-canary.24",
+    "@mui/internal-babel-plugin-resolve-imports": "2.0.7-canary.33"
   },
   "peerDependencies": {
     "@next/eslint-plugin-next": "*",
@@ -164,7 +164,7 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitSha": "e9b7cbb09759d50b3a1c391f6df49c19cfc927bc",
+  "gitSha": "0913e8254e8626b56e03ea048567da0273f0bd18",
   "scripts": {
     "build": "tsgo -p tsconfig.build.json",
     "typescript": "tsgo -noEmit",

package/src/cli/cmdPublishCanary.mjs

@@ -159,7 +159,10 @@ async function prepareChangelogsFromGitCli(packagesToPublish, allPackages, canar
 
   const transitiveDepSets = await Promise.all(
     allPackages.map((pkg) =>
-      getTransitiveDependencies([pkg.name], { includeDev: false, workspacePathByName }),
+      getTransitiveDependencies([pkg.name], {
+        includeDev: false,
+        workspacePathByName,
+      }),
     ),
   );
 
@@ -315,7 +318,14 @@ async function getLastCanaryTag() {
     // Tag might not exist locally, which is fine
   }
 
-  await $`git fetch origin tag ${CANARY_TAG}`;
+  try {
+    await $`git fetch origin tag ${CANARY_TAG}`;
+  } catch (err) {
+    // Tag might not exist on the remote yet (first canary run), which is fine
+    if (!(/** @type {Error} */ (err).message?.includes("couldn't find remote ref"))) {
+      throw err;
+    }
+  }
   const { stdout: remoteCanaryTag } = await $`git ls-remote --tags origin ${CANARY_TAG}`;
   return remoteCanaryTag.trim() ? CANARY_TAG : null;
 }

package/src/cli/cmdPublishNewPackage.mjs

@@ -62,7 +62,7 @@ export default /** @type {import('yargs').CommandModule<{}, Args>} */ ({
             version: '0.0.1',
             repository: {
               type: 'git',
-              url: `git+https://github.com/${repo.owner}/${repo.remoteName}.git`,
+              url: `git+https://github.com/${repo.owner}/${repo.repo}.git`,
               directory: toPosixPath(path.relative(workspaceDir, pkg.path)),
             },
           };