@mterminal/manifest-validator 0.1.0 → 0.2.0

package/dist/index.d.ts

@@ -22,7 +22,7 @@ interface PanelContribution {
     id: string;
     title: string;
     icon?: string;
-    location: 'sidebar' | 'sidebar.bottom' | 'bottombar';
+    location: 'sidebar' | 'sidebar.bottom' | 'bottombar' | `workspace-section.${string}`;
     initialCollapsed?: boolean;
 }
 interface StatusBarContribution {

package/dist/index.js

@@ -161,7 +161,9 @@ function readContributes(v, errors) {
       if (!isObject(x)) return false;
       if (typeof x.id !== "string" || typeof x.title !== "string") return false;
       const loc = x.location;
-      if (loc !== "sidebar" && loc !== "sidebar.bottom" && loc !== "bottombar") {
+      const isBuiltinSlot = loc === "sidebar" || loc === "sidebar.bottom" || loc === "bottombar";
+      const isWorkspaceSectionSlot = typeof loc === "string" && loc.startsWith("workspace-section.") && loc.length > "workspace-section.".length;
+      if (!isBuiltinSlot && !isWorkspaceSectionSlot) {
         errors.push(`panel "${String(x.id)}" has invalid location "${String(loc)}"`);
         return false;
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mterminal/manifest-validator",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "description": "shared manifest validator for mterminal extensions",
   "license": "MIT",
   "type": "module",

package/src/index.test.ts

@@ -95,6 +95,50 @@ describe('validateManifest', () => {
     expect(result.ok).toBe(false)
   })
 
+  it('accepts panels with built-in location slots', () => {
+    const m: any = baseManifest()
+    m.mterminal.contributes = {
+      panels: [
+        { id: 'p1', title: 'one', location: 'sidebar' },
+        { id: 'p2', title: 'two', location: 'sidebar.bottom' },
+        { id: 'p3', title: 'three', location: 'bottombar' },
+      ],
+    }
+    const result = validateManifest(m)
+    expect(result.ok).toBe(true)
+  })
+
+  it('accepts panels mounted in a workspace-section.<id> slot', () => {
+    const m: any = baseManifest()
+    m.mterminal.contributes = {
+      panels: [
+        { id: 'p', title: 'remote', location: 'workspace-section.remote-ssh' },
+      ],
+    }
+    const result = validateManifest(m)
+    expect(result.ok).toBe(true)
+  })
+
+  it('rejects panel with unknown location', () => {
+    const m: any = baseManifest()
+    m.mterminal.contributes = {
+      panels: [{ id: 'p', title: 't', location: 'nowhere' }],
+    }
+    const result = validateManifest(m)
+    expect(result.ok).toBe(false)
+    if (!result.ok)
+      expect(result.errors.join('\n')).toMatch(/invalid location "nowhere"/)
+  })
+
+  it('rejects panel with empty workspace-section suffix', () => {
+    const m: any = baseManifest()
+    m.mterminal.contributes = {
+      panels: [{ id: 'p', title: 't', location: 'workspace-section.' }],
+    }
+    const result = validateManifest(m)
+    expect(result.ok).toBe(false)
+  })
+
   it('accepts theme-only declarative manifest', () => {
     const m: any = baseManifest()
     delete m.main

package/src/index.ts

@@ -32,7 +32,11 @@ export interface PanelContribution {
   id: string
   title: string
   icon?: string
-  location: 'sidebar' | 'sidebar.bottom' | 'bottombar'
+  location:
+    | 'sidebar'
+    | 'sidebar.bottom'
+    | 'bottombar'
+    | `workspace-section.${string}`
   initialCollapsed?: boolean
 }
 
@@ -369,7 +373,13 @@ function readContributes(v: unknown, errors: string[]): ExtensionManifest['contr
       if (!isObject(x)) return false
       if (typeof x.id !== 'string' || typeof x.title !== 'string') return false
       const loc = x.location
-      if (loc !== 'sidebar' && loc !== 'sidebar.bottom' && loc !== 'bottombar') {
+      const isBuiltinSlot =
+        loc === 'sidebar' || loc === 'sidebar.bottom' || loc === 'bottombar'
+      const isWorkspaceSectionSlot =
+        typeof loc === 'string' &&
+        loc.startsWith('workspace-section.') &&
+        loc.length > 'workspace-section.'.length
+      if (!isBuiltinSlot && !isWorkspaceSectionSlot) {
         errors.push(`panel "${String(x.id)}" has invalid location "${String(loc)}"`)
         return false
       }