@mstar-harness/opencode 1.7.1 → 1.8.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +16 -0
- package/harness-commands/codebase-audit.md +34 -0
- package/harness-commands/iteration-drive.md +17 -159
- package/harness-commands/iteration-loop.md +16 -194
- package/harness-commands/iteration-start.md +17 -183
- package/harness-skills/mstar-audit/SKILL.md +181 -0
- package/harness-skills/mstar-audit/references/audit-playbook.md +130 -0
- package/harness-skills/mstar-audit/references/finding-format.md +65 -0
- package/harness-skills/mstar-branch-worktree/SKILL.md +38 -27
- package/harness-skills/mstar-coding-behavior/SKILL.md +40 -114
- package/harness-skills/mstar-compound/SKILL.md +25 -197
- package/harness-skills/mstar-compound/references/compound-workflow.md +155 -0
- package/harness-skills/mstar-dispatch-gates/SKILL.md +3 -8
- package/harness-skills/mstar-harness-core/SKILL.md +3 -1
- package/harness-skills/mstar-host/references/_shared/host-role-binding-core.md +44 -0
- package/harness-skills/mstar-host/references/_shared/plan-mode-bridge-core.md +91 -0
- package/harness-skills/mstar-host/references/codex-plan-goal-mode-bridge.md +6 -11
- package/harness-skills/mstar-host/references/codex.md +1 -1
- package/harness-skills/mstar-host/references/cursor-plan-mode-bridge.md +9 -78
- package/harness-skills/mstar-host/references/cursor.md +3 -3
- package/harness-skills/mstar-host/references/kimi-plan-mode-bridge.md +5 -24
- package/harness-skills/mstar-host/references/kimi.md +5 -32
- package/harness-skills/mstar-host/references/omp-plan-mode-bridge.md +3 -13
- package/harness-skills/mstar-host/references/omp.md +5 -32
- package/harness-skills/mstar-host/references/opencode.md +1 -3
- package/harness-skills/mstar-host/references/zcode-plan-mode-bridge.md +5 -24
- package/harness-skills/mstar-host/references/zcode.md +5 -32
- package/harness-skills/mstar-iteration/SKILL.md +21 -211
- package/harness-skills/mstar-iteration/references/phase-3-iteration-close.md +95 -0
- package/harness-skills/mstar-iteration/references/phase-4-5-pr-delivery.md +81 -0
- package/harness-skills/mstar-iteration/references/phase5-helper-discovery.md +24 -0
- package/harness-skills/mstar-phase-gates/SKILL.md +2 -2
- package/harness-skills/mstar-plan-artifacts/references/plan-quality-bar.md +99 -0
- package/harness-skills/mstar-roles/SKILL.md +1 -1
- package/harness-skills/mstar-roles/references/_shared/leaf-executor-core.md +46 -0
- package/harness-skills/mstar-roles/references/architect.md +3 -23
- package/harness-skills/mstar-roles/references/frontend-dev.md +4 -24
- package/harness-skills/mstar-roles/references/fullstack-dev-shared.md +4 -24
- package/harness-skills/mstar-roles/references/ops-engineer.md +3 -23
- package/harness-skills/mstar-roles/references/product-manager.md +3 -23
- package/harness-skills/mstar-roles/references/project-manager/dispatch-and-assignment.md +5 -5
- package/harness-skills/mstar-roles/references/project-manager.md +4 -13
- package/harness-skills/mstar-roles/references/prompt-engineer.md +4 -23
- package/harness-skills/mstar-roles/references/qa-engineer.md +3 -22
- package/harness-skills/mstar-roles/references/qc-specialist/deep-review-lenses.md +16 -75
- package/harness-skills/mstar-roles/references/qc-specialist/reviewer-workflow.md +1 -1
- package/harness-skills/mstar-roles/references/qc-specialist-shared.md +4 -17
- package/harness-skills/mstar-roles/references/writing-specialist.md +4 -24
- package/harness-skills/mstar-sdd/SKILL.md +1 -0
- package/harness-skills/pm/SKILL.md +2 -0
- package/package.json +1 -1
|
@@ -0,0 +1,46 @@
|
|
|
1
|
+
# Leaf Executor Core (shared blocks)
|
|
2
|
+
|
|
3
|
+
> Shared by all leaf-executor role references in `mstar-roles/references/`. Each role file references this for the identical Completion Report template, repo-write Git discipline, and plan/documentation rules. **Read `mstar-harness-core` first.** Role-specific NEVER rules, mission, and responsibilities stay in each role file — this file holds only the uniform blocks.
|
|
4
|
+
|
|
5
|
+
## Completion Report
|
|
6
|
+
|
|
7
|
+
Every leaf executor returns this template (only `**Agent**` and content fields change per role):
|
|
8
|
+
|
|
9
|
+
```markdown
|
|
10
|
+
## Completion Report
|
|
11
|
+
|
|
12
|
+
**Agent**: {role_id}
|
|
13
|
+
**Task**: ...
|
|
14
|
+
**Status**: Done | Blocked | Partial
|
|
15
|
+
**Scope Delivered**: ...
|
|
16
|
+
**Artifacts**: ...
|
|
17
|
+
**Validation**: ...
|
|
18
|
+
**Issues/Risks**: ...
|
|
19
|
+
**Plan Update**: ...
|
|
20
|
+
**Handoff**: ...
|
|
21
|
+
**Git**: ...
|
|
22
|
+
```
|
|
23
|
+
|
|
24
|
+
`{role_id}` = the role's own id (e.g. `fullstack-dev`, `frontend-dev`, `ops-engineer`, `qa-engineer`, `architect`, `product-manager`, `prompt-engineer`, `writing-specialist`, `qc-specialist*`).
|
|
25
|
+
|
|
26
|
+
## Git NEVER (repo writes)
|
|
27
|
+
|
|
28
|
+
Apply when the assignment writes tracked repo files:
|
|
29
|
+
|
|
30
|
+
- **NEVER** skip per–task-ID commits on the authorized `Working branch` when you wrote tracked files — Completion Report **Git** must be a real `git log -1 --oneline` unless read-only was assigned.
|
|
31
|
+
- **NEVER** batch everything into a single closing commit unless PM explicitly allowed it.
|
|
32
|
+
|
|
33
|
+
## Plan & Documentation Rules
|
|
34
|
+
|
|
35
|
+
- Follow `{HARNESS_DIR}` / `{PLAN_DIR}` conventions from `mstar-plan-conventions`.
|
|
36
|
+
- Update assigned task checkboxes and plan notes for your scope.
|
|
37
|
+
- Do not mark full plan `Done` (only `project-manager` or `qa-engineer` per `mstar-harness-core`).
|
|
38
|
+
|
|
39
|
+
## Non-Recursive Dispatch Rule (shared shape)
|
|
40
|
+
|
|
41
|
+
All leaf executors share this hard rule (role-specific sibling lists stay in each role file):
|
|
42
|
+
|
|
43
|
+
- Complete assigned work in this session.
|
|
44
|
+
- Do not recursively dispatch sibling roles unless explicitly authorized via `Delegation: allowed (...)`.
|
|
45
|
+
- `Execute as: {role_id}` is identity lock, not orchestration permission.
|
|
46
|
+
- If required inputs are missing or prerequisites unmet, return `Blocked` to PM rather than inventing delegation.
|
|
@@ -105,30 +105,10 @@ Do not create your own branch strategy.
|
|
|
105
105
|
## Effort (agent-oriented)
|
|
106
106
|
```
|
|
107
107
|
|
|
108
|
-
## Completion Report
|
|
108
|
+
## Completion Report
|
|
109
109
|
|
|
110
|
-
|
|
111
|
-
## Completion Report v2
|
|
112
|
-
|
|
113
|
-
**Agent**: architect
|
|
114
|
-
**Task**: ...
|
|
115
|
-
**Status**: Done | Blocked | Partial
|
|
116
|
-
**Scope Delivered**: ...
|
|
117
|
-
**Artifacts**: ...
|
|
118
|
-
**Validation**: ...
|
|
119
|
-
**Issues/Risks**: ...
|
|
120
|
-
**Plan Update**: ...
|
|
121
|
-
**Handoff**: ...
|
|
122
|
-
**Git**: ...
|
|
123
|
-
```
|
|
110
|
+
Template (`{role_id}` = `architect`) → **`references/_shared/leaf-executor-core.md`**「Completion Report」。
|
|
124
111
|
|
|
125
112
|
## Plan & Documentation Rules
|
|
126
113
|
|
|
127
|
-
-
|
|
128
|
-
- Update architecture-related plan sections and task checkboxes only for your assigned scope.
|
|
129
|
-
- Do not mark overall plan `Done`; that authority belongs to `project-manager` or `qa-engineer` only (`mstar-harness-core`).
|
|
130
|
-
|
|
131
|
-
### Git NEVER (when you touched tracked repo files)
|
|
132
|
-
|
|
133
|
-
- **NEVER** finish a task ID / coverage unit with saves but **no** `git commit` on the authorized `Working branch` when repo writes were required—Completion Report **Git** must show a real `git log -1 --oneline` (not `N/A`) unless the assignment declared read-only or user-exclusive commits.
|
|
134
|
-
- **NEVER** defer every commit to one giant end-of-task batch unless PM explicitly allowed batched commits for this scope.
|
|
114
|
+
Repo-write Git discipline + plan/documentation rules → **`references/_shared/leaf-executor-core.md`**(「Git NEVER (repo writes)」+「Plan & Documentation Rules」)。**Architect-specific**:只更新 architecture 相关 plan section 与本 scope task checkbox;不标 overall plan `Done`。
|
|
@@ -61,30 +61,10 @@ If plan drift appears during implementation, request plan write-back before cont
|
|
|
61
61
|
- Same-repo concurrent writes require worktree isolation
|
|
62
62
|
- Do not self-decide branch pivots to default branch
|
|
63
63
|
|
|
64
|
-
## Completion Report
|
|
65
|
-
|
|
66
|
-
```markdown
|
|
67
|
-
## Completion Report v2
|
|
68
|
-
|
|
69
|
-
**Agent**: frontend-dev
|
|
70
|
-
**Task**: ...
|
|
71
|
-
**Status**: Done | Blocked | Partial
|
|
72
|
-
**Scope Delivered**: ...
|
|
73
|
-
**Artifacts**: ...
|
|
74
|
-
**Validation**: ...
|
|
75
|
-
**Issues/Risks**: ...
|
|
76
|
-
**Plan Update**: ...
|
|
77
|
-
**Handoff**: ...
|
|
78
|
-
**Git**: ...
|
|
79
|
-
```
|
|
64
|
+
## Completion Report
|
|
80
65
|
|
|
81
|
-
|
|
82
|
-
|
|
83
|
-
- Follow `{HARNESS_DIR}` / `{PLAN_DIR}` conventions from `mstar-plan-conventions`.
|
|
84
|
-
- Update assigned task checkboxes and related plan sections.
|
|
85
|
-
- Do not mark full plan `Done` (only `project-manager` or `qa-engineer` per `mstar-harness-core`).
|
|
66
|
+
Template (`{role_id}` = `frontend-dev`) → **`references/_shared/leaf-executor-core.md`**「Completion Report」。
|
|
86
67
|
|
|
87
|
-
|
|
68
|
+
## Plan & Documentation Rules
|
|
88
69
|
|
|
89
|
-
-
|
|
90
|
-
- **NEVER** batch everything into a single closing commit unless PM explicitly allowed it.
|
|
70
|
+
Repo-write Git discipline + plan/documentation rules → **`references/_shared/leaf-executor-core.md`**(「Git NEVER (repo writes)」+「Plan & Documentation Rules」)。
|
|
@@ -80,30 +80,10 @@ If plan drift appears, request plan update before continuing.
|
|
|
80
80
|
3. Test implementation for assigned scope
|
|
81
81
|
4. Self-verification and evidence generation
|
|
82
82
|
|
|
83
|
-
## Completion Report
|
|
84
|
-
|
|
85
|
-
```markdown
|
|
86
|
-
## Completion Report v2
|
|
87
|
-
|
|
88
|
-
**Agent**: {role_id}
|
|
89
|
-
**Task**: ...
|
|
90
|
-
**Status**: Done | Blocked | Partial
|
|
91
|
-
**Scope Delivered**: ...
|
|
92
|
-
**Artifacts**: ...
|
|
93
|
-
**Validation**: ...
|
|
94
|
-
**Issues/Risks**: ...
|
|
95
|
-
**Plan Update**: ...
|
|
96
|
-
**Handoff**: ...
|
|
97
|
-
**Git**: ...
|
|
98
|
-
```
|
|
83
|
+
## Completion Report
|
|
99
84
|
|
|
100
|
-
|
|
101
|
-
|
|
102
|
-
- Follow `{HARNESS_DIR}` / `{PLAN_DIR}` conventions from `mstar-plan-conventions`.
|
|
103
|
-
- Update assigned task checkboxes and plan notes for your scope.
|
|
104
|
-
- Do not mark full plan `Done` (only `project-manager` or `qa-engineer` per `mstar-harness-core`).
|
|
85
|
+
Template (fill `{role_id}` = `{role_id}`) → **`references/_shared/leaf-executor-core.md`**「Completion Report」。
|
|
105
86
|
|
|
106
|
-
|
|
87
|
+
## Plan & Documentation Rules
|
|
107
88
|
|
|
108
|
-
-
|
|
109
|
-
- **NEVER** batch everything into a single closing commit unless PM explicitly allowed it.
|
|
89
|
+
Repo-write Git discipline + plan/documentation rules → **`references/_shared/leaf-executor-core.md`**(「Git NEVER (repo writes)」+「Plan & Documentation Rules」)。
|
|
@@ -69,30 +69,10 @@ When assignment is marked `high-risk`:
|
|
|
69
69
|
## Monitoring Checks
|
|
70
70
|
```
|
|
71
71
|
|
|
72
|
-
## Completion Report
|
|
72
|
+
## Completion Report
|
|
73
73
|
|
|
74
|
-
|
|
75
|
-
## Completion Report v2
|
|
76
|
-
|
|
77
|
-
**Agent**: ops-engineer
|
|
78
|
-
**Task**: ...
|
|
79
|
-
**Status**: Done | Blocked | Partial
|
|
80
|
-
**Scope Delivered**: ...
|
|
81
|
-
**Artifacts**: ...
|
|
82
|
-
**Validation**: ...
|
|
83
|
-
**Issues/Risks**: ...
|
|
84
|
-
**Plan Update**: ...
|
|
85
|
-
**Handoff**: ...
|
|
86
|
-
**Git**: ...
|
|
87
|
-
```
|
|
74
|
+
Template (`{role_id}` = `ops-engineer`) → **`references/_shared/leaf-executor-core.md`**「Completion Report」。
|
|
88
75
|
|
|
89
76
|
## Plan & Documentation Rules
|
|
90
77
|
|
|
91
|
-
-
|
|
92
|
-
- Update assigned plan tasks and notes.
|
|
93
|
-
- Do not mark full plan `Done`.
|
|
94
|
-
|
|
95
|
-
### Git NEVER (repo writes)
|
|
96
|
-
|
|
97
|
-
- **NEVER** skip per–task-ID commits on the authorized `Working branch` when you wrote tracked files—Completion Report **Git** must be a real `git log -1 --oneline` unless read-only was assigned.
|
|
98
|
-
- **NEVER** batch everything into a single closing commit unless PM explicitly allowed it.
|
|
78
|
+
Repo-write Git discipline + plan/documentation rules → **`references/_shared/leaf-executor-core.md`**(「Git NEVER (repo writes)」+「Plan & Documentation Rules」)。
|
|
@@ -98,30 +98,10 @@ If writing files to business repo, use only PM-assigned `Working branch` / `Bran
|
|
|
98
98
|
|
|
99
99
|
- **NEVER** embed human calendar estimates (person-days, FTE, “waiting for review X days”) inside **Effort (agent-oriented)** fields; keep agent-only sizing per `mstar-plan-conventions` `references/effort-estimation.md`.
|
|
100
100
|
|
|
101
|
-
## Completion Report
|
|
101
|
+
## Completion Report
|
|
102
102
|
|
|
103
|
-
|
|
104
|
-
## Completion Report v2
|
|
105
|
-
|
|
106
|
-
**Agent**: product-manager
|
|
107
|
-
**Task**: ...
|
|
108
|
-
**Status**: Done | Blocked | Partial
|
|
109
|
-
**Scope Delivered**: ...
|
|
110
|
-
**Artifacts**: ...
|
|
111
|
-
**Validation**: ...
|
|
112
|
-
**Issues/Risks**: ...
|
|
113
|
-
**Plan Update**: ...
|
|
114
|
-
**Handoff**: ...
|
|
115
|
-
**Git**: ...
|
|
116
|
-
```
|
|
103
|
+
Template (`{role_id}` = `product-manager`) → **`references/_shared/leaf-executor-core.md`**「Completion Report」。
|
|
117
104
|
|
|
118
105
|
## Plan & Documentation Rules
|
|
119
106
|
|
|
120
|
-
-
|
|
121
|
-
- Update assigned plan sections and task checkboxes.
|
|
122
|
-
- Do not set full plan to `Done`.
|
|
123
|
-
|
|
124
|
-
### Git NEVER (repo writes)
|
|
125
|
-
|
|
126
|
-
- **NEVER** skip per–task-ID commits on the authorized `Working branch` when you wrote tracked files—Completion Report **Git** must be a real `git log -1 --oneline` unless read-only was assigned.
|
|
127
|
-
- **NEVER** batch everything into a single closing commit unless PM explicitly allowed it.
|
|
107
|
+
Repo-write Git discipline + plan/documentation rules → **`references/_shared/leaf-executor-core.md`**(「Git NEVER (repo writes)」+「Plan & Documentation Rules」)。**Product-specific**:只更新 assigned plan section 与 task checkbox;不标 full plan `Done`。
|
|
@@ -27,7 +27,7 @@ For assignees (non-PM):
|
|
|
27
27
|
- **NEVER** assume exposed `Task` / subagent menus imply you may call them; **tool availability ≠ delegation authorization**.
|
|
28
28
|
- **NEVER** execute parallel-agent dispatch as a leaf assignee; dispatch is **PM-orchestration-only** (`mstar-dispatch-gates`).
|
|
29
29
|
- **NEVER** delegate the main deliverable of this assignment to `explore` (read-only orientation only, per `mstar-harness-core`).
|
|
30
|
-
- **NEVER** claim `Done` / pass in **Completion Report
|
|
30
|
+
- **NEVER** claim `Done` / pass in **Completion Report** without the commands, logs, or artifacts explicitly required by the assignment’s **Evidence Required** section (see `mstar-harness-core` evidence gates).
|
|
31
31
|
|
|
32
32
|
## Assignment Template (Canonical)
|
|
33
33
|
|
|
@@ -103,7 +103,7 @@ The **`**You are a leaf executor. You MUST NOT:**`** section (previously just pr
|
|
|
103
103
|
**PM Task Board coverage**: <task ids>
|
|
104
104
|
**Roadmap / deferred scope**: <required when staged, partial, or temporary; otherwise N/A>
|
|
105
105
|
**Task**: <concrete work aligned with coverage>
|
|
106
|
-
**Checkpoint Comment Rule**: commit -> Completion Report
|
|
106
|
+
**Checkpoint Comment Rule**: commit -> Completion Report -> PM Status Update -> next batch
|
|
107
107
|
**Why batching is safe**: <required when batching >=3 IDs>
|
|
108
108
|
**Scope**:
|
|
109
109
|
- In: ...
|
|
@@ -124,7 +124,7 @@ The **`**You are a leaf executor. You MUST NOT:**`** section (previously just pr
|
|
|
124
124
|
- `explore` is read-only orientation only
|
|
125
125
|
- Tool availability ≠ delegation authorization
|
|
126
126
|
**Plan Path**: absolute `<control_worktree_path>/{PLAN_DIR}/...` when L1 lease gate active | `{PLAN_DIR}/...` when waived / single checkout | N/A
|
|
127
|
-
**Report Format**: Completion Report
|
|
127
|
+
**Report Format**: Completion Report
|
|
128
128
|
**Execution evidence**: <RCA/test-first/review feedback/evidence expectations for the assignee, if applicable>
|
|
129
129
|
```
|
|
130
130
|
|
|
@@ -140,10 +140,10 @@ When `metadata.control_worktree_path` is set and worktree mode is **not** waived
|
|
|
140
140
|
| **`SDD dir`** | Absolute under control harness; run `sdd-workspace` with `MSTAR_CONTROL_ROOT=<control_worktree_path>` when cwd is the feature tree |
|
|
141
141
|
|
|
142
142
|
Do **not** waive worktree because default-gitignored `plans/` are missing under the feature checkout — see `mstar-branch-worktree` 「Harness path SSOT under default gitignore」.
|
|
143
|
-
## Completion Report
|
|
143
|
+
## Completion Report Template
|
|
144
144
|
|
|
145
145
|
```markdown
|
|
146
|
-
## Completion Report
|
|
146
|
+
## Completion Report
|
|
147
147
|
|
|
148
148
|
**Agent**: <role-id>
|
|
149
149
|
**Task**: ...
|
|
@@ -138,18 +138,9 @@ If any item below matches, fix the dispatch/plan state or mark `Blocked`—do **
|
|
|
138
138
|
|
|
139
139
|
---
|
|
140
140
|
|
|
141
|
-
## Phase Gates
|
|
141
|
+
## Phase Gates
|
|
142
142
|
|
|
143
|
-
|
|
144
|
-
|
|
145
|
-
1. `specify` done
|
|
146
|
-
2. `clarify` done (no unresolved high-impact ambiguity)
|
|
147
|
-
3. `plan` done and referenceable
|
|
148
|
-
4. `tasks` + PM Task Board ready for non-trivial plan
|
|
149
|
-
5. Roadmap written when delivery is split, deferred, or temporary
|
|
150
|
-
6. New constraints discovered are written back to plan first
|
|
151
|
-
|
|
152
|
-
If any fail -> do not dispatch implement.
|
|
143
|
+
完整 Prepare/Execute 门禁树(`specify → clarify → plan` → `plan(locked) → tasks → implement`)、意图门禁、hotfix 压缩路径、Phase Gate 最小证据 → **`mstar-phase-gates`**。PM 首次 implement dispatch(非 hotfix)前须确认 phase-gates 全绿:specify/clarify/plan 完成、tasks + PM Task Board ready、split/deferred/temporary 已写 roadmap、新约束已回写 plan。任一未过 → 不 dispatch implement。
|
|
153
144
|
|
|
154
145
|
### PM entry sessions
|
|
155
146
|
|
|
@@ -252,7 +243,7 @@ Before first implement dispatch:
|
|
|
252
243
|
- If delivery spans batches, include the full roadmap: batch order, deferred scope, dependencies, owner/trigger, and final Done definition
|
|
253
244
|
- Every implement Assignment declares `PM Task Board coverage`
|
|
254
245
|
- Default batch size 1-2 IDs; `>=3` requires `Why batching is safe`
|
|
255
|
-
- Completion rhythm: commit -> Completion Report
|
|
246
|
+
- Completion rhythm: commit -> Completion Report -> PM Status Update -> next dispatch
|
|
256
247
|
|
|
257
248
|
---
|
|
258
249
|
|
|
@@ -281,7 +272,7 @@ Use canonical templates from:
|
|
|
281
272
|
`references/project-manager/dispatch-and-assignment.md`
|
|
282
273
|
|
|
283
274
|
- `## Assignment`
|
|
284
|
-
- `## Completion Report
|
|
275
|
+
- `## Completion Report`
|
|
285
276
|
- `## Status Update`
|
|
286
277
|
|
|
287
278
|
Minimum invariants:
|
|
@@ -62,29 +62,10 @@ When creating a new skill, making a major skill rewrite, changing frontmatter `d
|
|
|
62
62
|
- Redundancy removed before adding new constraints
|
|
63
63
|
- At least one replayable scenario exists for regression check
|
|
64
64
|
|
|
65
|
-
## Completion Report
|
|
66
|
-
|
|
67
|
-
```markdown
|
|
68
|
-
## Completion Report v2
|
|
69
|
-
|
|
70
|
-
**Agent**: prompt-engineer
|
|
71
|
-
**Task**: ...
|
|
72
|
-
**Status**: Done | Blocked | Partial
|
|
73
|
-
**Scope Delivered**: ...
|
|
74
|
-
**Artifacts**: ...
|
|
75
|
-
**Validation**: ...
|
|
76
|
-
**Issues/Risks**: ...
|
|
77
|
-
**Plan Update**: ...
|
|
78
|
-
**Handoff**: ...
|
|
79
|
-
**Git**: ...
|
|
80
|
-
```
|
|
65
|
+
## Completion Report
|
|
81
66
|
|
|
82
|
-
|
|
83
|
-
|
|
84
|
-
- Follow `{HARNESS_DIR}` / `{PLAN_DIR}` conventions from `mstar-plan-conventions`.
|
|
85
|
-
- Keep role text concise; move reusable long-form guidance into shared `mstar-*` skills.
|
|
67
|
+
Template (`{role_id}` = `prompt-engineer`) → **`references/_shared/leaf-executor-core.md`**「Completion Report」。
|
|
86
68
|
|
|
87
|
-
|
|
69
|
+
## Plan & Documentation Rules
|
|
88
70
|
|
|
89
|
-
-
|
|
90
|
-
- **NEVER** batch everything into a single closing commit unless PM explicitly allowed it.
|
|
71
|
+
Repo-write Git discipline + plan/documentation rules → **`references/_shared/leaf-executor-core.md`**(「Git NEVER (repo writes)」+「Plan & Documentation Rules」)。**Prompt-engineer-specific**:role text 保持精简;可复用长文 guidance 移入 shared `mstar-*` skills。
|
|
@@ -65,32 +65,13 @@ When Assignment provides a report path, write report-only output under `{SDD_DIR
|
|
|
65
65
|
## Recommended owners
|
|
66
66
|
```
|
|
67
67
|
|
|
68
|
-
## Completion Report
|
|
68
|
+
## Completion Report
|
|
69
69
|
|
|
70
|
-
|
|
71
|
-
## Completion Report v2
|
|
72
|
-
|
|
73
|
-
**Agent**: qa-engineer
|
|
74
|
-
**Task**: ...
|
|
75
|
-
**Status**: Done | Blocked | Partial
|
|
76
|
-
**Scope Delivered**: ...
|
|
77
|
-
**Artifacts**: ...
|
|
78
|
-
**Validation**: <AC mapping; reused L1/CI/prior-QA evidence vs new runs; QC findings addressed>
|
|
79
|
-
**Issues/Risks**: ...
|
|
80
|
-
**Plan Update**: ...
|
|
81
|
-
**Handoff**: ...
|
|
82
|
-
**Git**: ...
|
|
83
|
-
```
|
|
70
|
+
Template (`{role_id}` = `qa-engineer`) → **`references/_shared/leaf-executor-core.md`**「Completion Report」。
|
|
84
71
|
|
|
85
72
|
## Plan & Residual Rules
|
|
86
73
|
|
|
87
|
-
-
|
|
88
|
-
- QA and PM are the only roles allowed to finalize plan `Done`.
|
|
89
|
-
|
|
90
|
-
### Git NEVER (repo writes)
|
|
91
|
-
|
|
92
|
-
- **NEVER** skip per–task-ID commits on the authorized `Working branch` when you wrote tracked files—Completion Report **Git** must be a real `git log -1 --oneline` unless read-only was assigned.
|
|
93
|
-
- **NEVER** batch everything into a single closing commit unless PM explicitly allowed it.
|
|
74
|
+
Repo-write Git discipline + plan/documentation rules → **`references/_shared/leaf-executor-core.md`**(「Git NEVER (repo writes)」+「Plan & Documentation Rules」)。**QA-specific**:QA 和 PM 是唯一可终结 plan `Done` 的角色;residual lifecycle 来自 `mstar-plan-artifacts`。
|
|
94
75
|
|
|
95
76
|
## Detailed References Index
|
|
96
77
|
|
|
@@ -47,81 +47,22 @@ QC reviewer 在开工时根据以下信号自判是否启用 deep review。满
|
|
|
47
47
|
|
|
48
48
|
---
|
|
49
49
|
|
|
50
|
-
##
|
|
51
|
-
|
|
52
|
-
|
|
53
|
-
|
|
54
|
-
|
|
55
|
-
-
|
|
56
|
-
-
|
|
57
|
-
-
|
|
58
|
-
-
|
|
59
|
-
|
|
60
|
-
|
|
61
|
-
-
|
|
62
|
-
-
|
|
63
|
-
-
|
|
64
|
-
-
|
|
65
|
-
|
|
66
|
-
### Security Lens
|
|
67
|
-
- [ ] 变更是否涉及认证/授权流程?session、token、permission 逻辑是否正确?
|
|
68
|
-
- [ ] 是否存在未验证的用户输入被直接用于数据库查询、命令执行或文件操作?
|
|
69
|
-
- [ ] 敏感数据(密钥、token、密码、PII)是否在日志/错误信息/返回值中泄露?
|
|
70
|
-
- [ ] 新增的访问控制点是否覆盖了所有调用路径?
|
|
71
|
-
|
|
72
|
-
### Correctness Lens
|
|
73
|
-
- [ ] 错误处理是否显式、可恢复?是否有吞掉关键异常的 catch-all?
|
|
74
|
-
- [ ] 边界条件是否覆盖?(空值、零值、溢出、并发冲突)
|
|
75
|
-
- [ ] 状态转换逻辑是否一致?是否存在中间状态会被外部观察到?
|
|
76
|
-
- [ ] 返回值/副作用是否与声明一致?
|
|
77
|
-
|
|
78
|
-
### Performance Lens
|
|
79
|
-
- [ ] 是否引入了 N+1 查询?新增的 ORM 调用是否有 eager loading?
|
|
80
|
-
- [ ] 循环或批处理中是否有无界操作?
|
|
81
|
-
- [ ] 新索引是否必要且不会造成写入性能退化?
|
|
82
|
-
- [ ] 大对象/大列表是否做分页或流式处理?
|
|
83
|
-
|
|
84
|
-
### Reliability Lens
|
|
85
|
-
- [ ] 资源(连接、文件句柄、锁)是否在异常路径中也正确释放?
|
|
86
|
-
- [ ] 外部服务调用是否有超时和重试策略?
|
|
87
|
-
- [ ] 缓存失效策略是否正确(不会长期返回过期数据)?
|
|
88
|
-
- [ ] 是否存在可能无限增长的结构(无界缓存、无界日志、无界队列)?
|
|
89
|
-
|
|
90
|
-
### Auth Lens
|
|
91
|
-
- [ ] 认证中间件是否覆盖了所有新增端点?
|
|
92
|
-
- [ ] 权限检查是否在业务逻辑执行前完成(先鉴权再操作)?
|
|
93
|
-
- [ ] session 生命周期管理是否正确(创建、续期、失效)?
|
|
94
|
-
- [ ] 是否有权限提升路径(如 admin 操作需二次确认)?
|
|
95
|
-
|
|
96
|
-
### Input Validation Lens
|
|
97
|
-
- [ ] 所有外部输入(query params、body、headers)是否经过类型/范围/格式验证?
|
|
98
|
-
- [ ] 是否存在可通过输入触发的路径遍历、注入或 XSS?
|
|
99
|
-
- [ ] 文件上传是否有大小/类型检查?
|
|
100
|
-
- [ ] API 返回的错误信息是否在暴露内部实现细节?
|
|
101
|
-
|
|
102
|
-
### Data Migration Lens
|
|
103
|
-
- [ ] migration 是否可回滚?`down` 方法是否存在且正确?
|
|
104
|
-
- [ ] 是否对大数据量表使用了非阻塞的 migration 策略?
|
|
105
|
-
- [ ] 数据迁移是否保持了一致性(不丢数据、不产生中间脏状态)?
|
|
106
|
-
- [ ] 是否考虑了并发写入场景下的迁移安全性?
|
|
107
|
-
|
|
108
|
-
### Error Handling Lens
|
|
109
|
-
- [ ] 异常层级是否清晰(业务异常 vs 系统异常)?
|
|
110
|
-
- [ ] 面向用户的错误消息是否安全(不泄露内部细节)?
|
|
111
|
-
- [ ] 关键操作失败后的副作用是否被正确处理(事务回滚、补偿操作)?
|
|
112
|
-
- [ ] 是否有"静默失败"的路径(错误被忽略但后续逻辑假定成功)?
|
|
113
|
-
|
|
114
|
-
### Standards Lens
|
|
115
|
-
- [ ] 代码风格、命名、文件组织是否符合项目已有约定?
|
|
116
|
-
- [ ] 是否引入了与现有方案冲突的重复实现?
|
|
117
|
-
- [ ] 新依赖的引入是否有充分理由?
|
|
118
|
-
- [ ] 是否遵循了项目 `AGENTS.md` 中的维护契约?
|
|
119
|
-
|
|
120
|
-
### Testing Lens
|
|
121
|
-
- [ ] 对关键逻辑路径是否有测试覆盖?
|
|
122
|
-
- [ ] 边界和异常路径是否被测试覆盖?
|
|
123
|
-
- [ ] 是否存在仅验证 happy path 而跳过了 failure mode 的测试?
|
|
124
|
-
- [ ] 集成测试是否覆盖了与外部服务的交互边界?
|
|
50
|
+
## 透镜清单(每透镜一行焦点;详细追问由 reviewer 按专业判断展开)
|
|
51
|
+
|
|
52
|
+
每个透镜是一组审查焦点。QC reviewer 在报告中按透镜分节列出发现,每个发现标注来自哪个透镜(`Source Type: deep-lens: <Lens>`)。
|
|
53
|
+
|
|
54
|
+
- **Modularity Lens** — 新依赖方向合理;无逻辑错放层级(controller 业务逻辑、model 视图逻辑);公共接口职责单一边界清晰;无循环依赖/隐含耦合。
|
|
55
|
+
- **Contract Lens** — 公共 API/接口签名无未声明 breaking change(有则 plan 声明 + 迁移说明);新端点遵循命名/参数约定;返回类型稳定(新字段不破坏已有解析)。
|
|
56
|
+
- **Security Lens** — 认证/授权/session/token/permission 逻辑正确;未验证输入未直入 DB/命令/文件;敏感数据(密钥/token/PII)未在日志/错误/返回值泄露;新访问控制点覆盖所有调用路径。
|
|
57
|
+
- **Correctness Lens** — 错误处理显式可恢复(无吞关键异常的 catch-all);边界条件覆盖(空/零/溢出/并发);状态转换一致(无外部可观察中间态);返回值/副作用与声明一致。
|
|
58
|
+
- **Performance Lens** — 无 N+1 查询(ORM eager loading);循环/批处理无无界操作;新索引必要且不退化写入;大对象/列表分页或流式。
|
|
59
|
+
- **Reliability Lens** — 资源(连接/句柄/锁)异常路径也释放;外部调用有超时+重试;缓存失效正确(不长期返回过期);无可能无限增长的结构(无界缓存/日志/队列)。
|
|
60
|
+
- **Auth Lens** — 认证中间件覆盖所有新端点;权限检查在业务逻辑前(先鉴权再操作);session 生命周期正确(创建/续期/失效);权限提升路径需二次确认。
|
|
61
|
+
- **Input Validation Lens** — 外部输入(query/body/headers)经类型/范围/格式验证;无可触发路径遍历/注入/XSS;文件上传有大小/类型检查;错误信息不暴露内部实现细节。
|
|
62
|
+
- **Data Migration Lens** — migration 可回滚(`down` 存在且正确);大表用非阻塞策略;数据一致(不丢/无脏中间态);并发写入下安全。
|
|
63
|
+
- **Error Handling Lens** — 异常层级清晰(业务 vs 系统);面向用户错误消息安全;关键操作失败副作用正确处理(事务回滚/补偿);无"静默失败"路径。
|
|
64
|
+
- **Standards Lens** — 风格/命名/文件组织符项目约定;无与现有冲突的重复实现;新依赖有充分理由;遵循项目 `AGENTS.md` 维护契约。
|
|
65
|
+
- **Testing Lens** — 关键逻辑路径有覆盖;边界/异常路径覆盖;无仅 happy-path 跳 failure-mode;集成测试覆盖外部服务交互边界。
|
|
125
66
|
|
|
126
67
|
---
|
|
127
68
|
|
|
@@ -32,7 +32,7 @@ Layer SSOT → `mstar-review-qc/references/review-responsibility-boundaries.md`.
|
|
|
32
32
|
5. Execute **`reviewer-checklist.md`** manually against the diff.
|
|
33
33
|
6. Produce structured findings with severity and evidence. PM maps report sections to `residual_findings` **`severity`** per `mstar-plan-artifacts/references/status-and-residuals.md` — do not invent non-canonical severity strings.
|
|
34
34
|
7. **Write report:** Write `.md` to the Assignment-provided `{SDD_DIR}/review/` report path. Do not commit raw bundle reports unless Assignment explicitly says `Review archive mode: tracked reports`.
|
|
35
|
-
8. **No stall:** When done, emit **Completion Report
|
|
35
|
+
8. **No stall:** When done, emit **Completion Report** in the same turn — no “notify PM?” choosers.
|
|
36
36
|
|
|
37
37
|
## Evidence gaps (hand to QA — do not self-execute)
|
|
38
38
|
|
|
@@ -32,7 +32,7 @@ Detailed execution: `references/qc-specialist/*.md`.
|
|
|
32
32
|
|
|
33
33
|
You are QC reviewer #{reviewer_index} (or sole reviewer when `QC mode: single`), dispatched by `project-manager`.
|
|
34
34
|
You are a **code reviewer** (diff + language/logic + risk lenses) — **not** a test runner and **not** a substitute for `qa-engineer`.
|
|
35
|
-
Your output is a structured QC report plus Completion Report
|
|
35
|
+
Your output is a structured QC report plus Completion Report.
|
|
36
36
|
|
|
37
37
|
**Default (SDD):** plan QC tri on whole-branch review-package (`QC mode: full tri-review`). **Exception:** `Execution mode: inline` → single-seat `qc.md`.
|
|
38
38
|
|
|
@@ -107,22 +107,9 @@ generated_at: "YYYY-MM-DD"
|
|
|
107
107
|
---
|
|
108
108
|
```
|
|
109
109
|
|
|
110
|
-
## Completion Report
|
|
111
|
-
|
|
112
|
-
|
|
113
|
-
## Completion Report v2
|
|
114
|
-
|
|
115
|
-
**Agent**: {role_id}
|
|
116
|
-
**Task**: ...
|
|
117
|
-
**Status**: Done | Blocked | Partial
|
|
118
|
-
**Scope Delivered**: ...
|
|
119
|
-
**Artifacts**: ...
|
|
120
|
-
**Validation**: ...
|
|
121
|
-
**Issues/Risks**: ...
|
|
122
|
-
**Plan Update**: ...
|
|
123
|
-
**Handoff**: ...
|
|
124
|
-
**Git**: ...
|
|
125
|
-
```
|
|
110
|
+
## Completion Report
|
|
111
|
+
|
|
112
|
+
Template (fill `{role_id}`) → **`references/_shared/leaf-executor-core.md`**「Completion Report」。
|
|
126
113
|
|
|
127
114
|
## Repository Write Scope
|
|
128
115
|
|
|
@@ -50,30 +50,10 @@ If any item below matches, **stop** and return `Blocked` to `project-manager` in
|
|
|
50
50
|
- Keep writing usable and publication-ready
|
|
51
51
|
- Include source notes when factual claims require evidence
|
|
52
52
|
|
|
53
|
-
## Completion Report
|
|
54
|
-
|
|
55
|
-
```markdown
|
|
56
|
-
## Completion Report v2
|
|
57
|
-
|
|
58
|
-
**Agent**: writing-specialist
|
|
59
|
-
**Task**: ...
|
|
60
|
-
**Status**: Done | Blocked | Partial
|
|
61
|
-
**Scope Delivered**: ...
|
|
62
|
-
**Artifacts**: ...
|
|
63
|
-
**Validation**: ...
|
|
64
|
-
**Issues/Risks**: ...
|
|
65
|
-
**Plan Update**: ...
|
|
66
|
-
**Handoff**: ...
|
|
67
|
-
**Git**: ...
|
|
68
|
-
```
|
|
53
|
+
## Completion Report
|
|
69
54
|
|
|
70
|
-
|
|
71
|
-
|
|
72
|
-
- Follow `{HARNESS_DIR}` / `{PLAN_DIR}` conventions from `mstar-plan-conventions`.
|
|
73
|
-
- Update assigned plan tasks only.
|
|
74
|
-
- Do not mark full plan `Done`.
|
|
55
|
+
Template (`{role_id}` = `writing-specialist`) → **`references/_shared/leaf-executor-core.md`**「Completion Report」。
|
|
75
56
|
|
|
76
|
-
|
|
57
|
+
## Plan Rules
|
|
77
58
|
|
|
78
|
-
-
|
|
79
|
-
- **NEVER** batch unrelated edits into one opaque commit unless PM explicitly allowed it.
|
|
59
|
+
Repo-write Git discipline + plan/documentation rules → **`references/_shared/leaf-executor-core.md`**(「Git NEVER (repo writes)」+「Plan & Documentation Rules」)。**Writing-specific**:只更新 assigned plan tasks;writing-only scope,PM/QA 拥有 closure。
|
|
@@ -124,3 +124,4 @@ From repo: `skills/mstar-sdd/scripts/` (bundled in OpenCode as `harness-skills/m
|
|
|
124
124
|
- `references/implementer-prompt.md`
|
|
125
125
|
- `references/implementer-continuation-prompt.md`
|
|
126
126
|
- `references/task-reviewer-prompt.md`
|
|
127
|
+
- `mstar-plan-artifacts/references/plan-quality-bar.md` — plan self-containment standard (plans must meet this before SDD dispatch)
|
|
@@ -20,6 +20,8 @@ description: "PM entry shim — force project-manager orchestration when user in
|
|
|
20
20
|
|
|
21
21
|
**Iteration lifecycle** (optional): host `commands/` may sequence Phase 1–5; semantics SSOT → **`mstar-iteration`**. Not required for ordinary PM work.
|
|
22
22
|
|
|
23
|
+
**Codebase audit** (optional): `/codebase-audit` command → **`mstar-audit`** — read-only codebase survey producing prioritized, self-contained improvement plans. Output feeds iteration-start §1 Research or normal Prepare → Execute. Dispatched by PM under `Task category: audit`.
|
|
24
|
+
|
|
23
25
|
Detect host → **`mstar-host`** → `references/codex.md` | `cursor.md` | `opencode.md` | `kimi.md` | `zcode.md` | `omp.md`.
|
|
24
26
|
|
|
25
27
|
## Read next (in order)
|