@mstar-harness/engine 3.1.0 → 3.1.2

package/dist/dispatch.d.ts

@@ -173,8 +173,10 @@ export declare function assertTriIdentity(reviewerRoles: readonly string[]): Gat
 export type ComposeDispatchGateOptions = {
     /**
      * Host role-binding field (omp task entry `agent` / opencode `subagent` /
-     * cursor `subagent_type`); the anti-recursion precheck runs only when
-     * non-empty.
+     * cursor `subagent_type` / dsh `dispatchBinding`). The anti-recursion
+     * precheck runs for EVERY Assignment-shaped text: an empty or omitted
+     * binding fails closed (`dispatch.anti-recursion.empty-binding`) — the
+     * host cannot prove the dispatching agent is not recursing.
      */
     agent?: string;
     /**
@@ -204,7 +206,10 @@ export type ComposeDispatchGateResult = GateResult & {
  *    Assignment-shaped passes silently (`shaped: false`).
  * 2. `validateAssignmentFields` with `writable: false` when `opts.writable
  *    === false` (read-only roles), else the writable default.
- * 3. Anti-recursion precheck when `opts.agent` is non-empty.
+ * 3. Anti-recursion precheck — runs for every Assignment-shaped text; an
+ *    empty/omitted host binding fails closed (`dispatch.anti-recursion.
+ *    empty-binding`), a binding equal to `Execute as` is the existing
+ *    `dispatch.anti-recursion.self-type` critical.
  * 4. Default-branch gate for writable text: the branch comes from the
  *    Assignment's own branch forms (create-form name / Working branch /
  *    Branch policy branch), else `$MSTAR_WORKING_BRANCH`; a well-formed
@@ -221,7 +226,11 @@ export declare function composeDispatchGate(text: string, opts?: ComposeDispatch
  * Anti-recursion precheck (NEVER red line, mstar-dispatch-gates § 承接方反递归
  * 红线): a leaf executor MUST NOT invoke a Task/subagent whose role-binding
  * field (`subagent_type` / `agent` / `subagent`) equals its own `Execute as`.
- * Comparison is case-insensitive after trim; an empty binding is not a
- * self-recursion (its presence is the field gate's job, not this precheck).
+ * Comparison is case-insensitive after trim. An EMPTY binding fails closed
+ * (`dispatch.anti-recursion.empty-binding`, critical): the host cannot
+ * report which agent is calling, so anti-recursion cannot be proven — the
+ * dispatch must not proceed as if the NEVER red line held. An empty
+ * `executeAs` with a set binding stays ok (field presence is
+ * `validateAssignmentFields`' job, not this precheck).
  */
 export declare function antiRecursionPrecheck(subagentType: string, executeAs: string): GateResult;

package/dist/engine.js

@@ -170,7 +170,7 @@ function isAtOrBelow(dir, root) {
   return rel === "" || !rel.startsWith("..") && !isAbsolute(rel);
 }
 // src/path.ts
-import { mkdirSync as mkdirSync2, readdirSync, readFileSync as readFileSync3, statSync as statSync2 } from "node:fs";
+import { existsSync as existsSync2, mkdirSync as mkdirSync2, readdirSync, readFileSync as readFileSync3, realpathSync, statSync as statSync2 } from "node:fs";
 import { execFileSync } from "node:child_process";
 import { basename as basename2, dirname as dirname3, isAbsolute as isAbsolute2, join as join3, relative as relative2, resolve as resolve3 } from "node:path";
 function resolveHarnessDir(startDir = process.cwd(), opts = {}) {
@@ -425,6 +425,23 @@ function assertPlanWritingPath(planPath, harnessDir) {
       fix: `write the plan under ${planDir}`
     };
   }
+  if (existsSync2(planAbs)) {
+    try {
+      const canonicalPlan = realpathSync(planAbs);
+      const canonicalPlanDir = existsSync2(planDir) ? realpathSync(planDir) : resolve3(planDir);
+      const canonicalRel = relative2(canonicalPlanDir, canonicalPlan);
+      const canonicalInside = canonicalRel === "" || !canonicalRel.startsWith("..") && !isAbsolute2(canonicalRel);
+      if (!canonicalInside) {
+        return {
+          ok: false,
+          severity: "high",
+          code: "plan-path.symlink-escape",
+          message: `plan file ${planAbs} resolves to ${canonicalPlan}, outside {PLAN_DIR} (${canonicalPlanDir})`,
+          fix: `write the plan under ${planDir}`
+        };
+      }
+    } catch {}
+  }
   return {
     ok: true,
     severity: "low",
@@ -455,7 +472,7 @@ function hasFiles(dir) {
   }
 }
 // src/status.ts
-import { existsSync as existsSync2, readFileSync as readFileSync4, readdirSync as readdirSync2, realpathSync } from "node:fs";
+import { existsSync as existsSync3, readFileSync as readFileSync4, readdirSync as readdirSync2, realpathSync as realpathSync2 } from "node:fs";
 import { dirname as dirname5, join as join6, resolve as resolve5, sep } from "node:path";
 
 // src/lease.ts
@@ -910,10 +927,8 @@ function composeDispatchGate(text, opts = {}) {
     const violations = [];
     const writable = opts.writable !== false;
     violations.push(...validateAssignmentFields(text, { writable }).violations);
-    const agent = (opts.agent ?? "").trim();
-    if (agent !== "") {
-      violations.push(...antiRecursionPrecheck(agent, parseAssignmentFields(text).executeAs ?? "").violations);
-    }
+    const agent = opts.agent ?? "";
+    violations.push(...antiRecursionPrecheck(agent, parseAssignmentFields(text).executeAs ?? "").violations);
     if (writable) {
       const forms = parseAssignmentBranchForms(text);
       const branch = forms.createForm?.name ?? forms.workingBranch ?? forms.directOn?.branch ?? process.env.MSTAR_WORKING_BRANCH;
@@ -932,7 +947,15 @@ function composeDispatchGate(text, opts = {}) {
 function antiRecursionPrecheck(subagentType, executeAs) {
   const binding = subagentType.trim().toLowerCase();
   const role = executeAs.trim().toLowerCase();
-  if (binding !== "" && binding === role) {
+  if (binding === "") {
+    return {
+      ok: false,
+      violations: [
+        violation2("critical", "dispatch.anti-recursion.empty-binding", `empty host role binding — the host cannot report which agent is calling, so anti-recursion cannot be proven (a dispatch could silently recurse)`, "set the host role-binding field (omp task entry `agent` / opencode `subagent` / cursor `subagent_type` / dsh `dispatchBinding`) before dispatching")
+      ]
+    };
+  }
+  if (binding === role) {
     return {
       ok: false,
       violations: [
@@ -1294,7 +1317,7 @@ function validateStatusV2(docOrPath, opts = {}) {
   if (harnessDir !== undefined && Array.isArray(doc.workflows)) {
     let realHarnessDir = null;
     try {
-      realHarnessDir = realpathSync(harnessDir);
+      realHarnessDir = realpathSync2(harnessDir);
     } catch {}
     for (const entry of doc.workflows) {
       if (!isPlainObject3(entry) || typeof entry.dir !== "string")
@@ -1304,7 +1327,7 @@ function validateStatusV2(docOrPath, opts = {}) {
       const label = typeof entry.id === "string" ? entry.id : relSnapshot;
       let physical;
       try {
-        physical = realpathSync(snapshotPath);
+        physical = realpathSync2(snapshotPath);
       } catch {
         violations.push(violation4("high", "status.workflow.snapshot-missing", `workflows[] lists ${JSON.stringify(label)} but its snapshot does not exist at ${JSON.stringify(relSnapshot)} — the root holds active lifecycles only; unregister the id when its snapshot is removed`));
         continue;
@@ -1394,7 +1417,7 @@ async function unregisterWorkflow(root, id) {
 }
 function resolveCompassEnforcement(harnessDir) {
   const iterationsDir = resolveIterationDir(harnessDir);
-  if (!existsSync2(iterationsDir))
+  if (!existsSync3(iterationsDir))
     return { hard: false, source: "none" };
   let entries;
   try {
@@ -1406,7 +1429,7 @@ function resolveCompassEnforcement(harnessDir) {
     if (!entry.isDirectory())
       continue;
     const compassPath = join6(iterationsDir, entry.name, "delivery-compass.md");
-    if (!existsSync2(compassPath))
+    if (!existsSync3(compassPath))
       continue;
     let content;
     try {
@@ -1442,7 +1465,7 @@ function resolveRepoEnforcement(harnessDir) {
 }
 // src/worktree.ts
 import { execFileSync as execFileSync2 } from "node:child_process";
-import { existsSync as existsSync3 } from "node:fs";
+import { existsSync as existsSync4 } from "node:fs";
 import { isAbsolute as isAbsolute4, resolve as resolve6 } from "node:path";
 var DEFAULT_PROBE_TIMEOUT_MS = 1e4;
 function probeTimeoutMs() {
@@ -1497,7 +1520,7 @@ function l1PreDispatchCheck(input, opts = {}) {
   if (controlWorktreePath !== "" && leaseWorktreePath !== "" && resolve6(controlWorktreePath) === resolve6(leaseWorktreePath)) {
     violations.push(violation5("critical", "worktree.l1.lease-equals-control", `execution_lease.worktree_path "${leaseWorktreePath}" equals metadata.control_worktree_path — the feature worktree MUST differ from the control worktree (L1 isolation; product edits never land in the control checkout)`, "use a distinct feature worktree for the plan (git worktree add <path> <branch>) and update the lease"));
   }
-  if (leaseWorktreePath !== "" && !existsSync3(leaseWorktreePath)) {
+  if (leaseWorktreePath !== "" && !existsSync4(leaseWorktreePath)) {
     violations.push(violation5("high", "worktree.l1.feature-missing", `feature worktree directory "${leaseWorktreePath}" does not exist for plan "${planId}"`, `create it before dispatch: git worktree add ${leaseWorktreePath} <working-branch>`));
   } else if (leaseWorktreePath !== "" && leaseWorkingBranch !== "") {
     const probe = probeBranch(leaseWorktreePath, opts);
@@ -1531,7 +1554,7 @@ function l2PreDispatchCheck(input, opts = {}) {
       return;
     }
     seenPaths.add(normalized);
-    if (!existsSync3(track.worktreePath)) {
+    if (!existsSync4(track.worktreePath)) {
       violations.push(violation5("high", "worktree.l2.track-missing", `track worktree directory "${track.worktreePath}" does not exist`, `create it before dispatch: git worktree add ${track.worktreePath} ${track.workingBranch}`));
       return;
     }
@@ -1594,7 +1617,7 @@ function singleReviewSnapshot(assignments) {
 }
 // src/sdd.ts
 import { execFileSync as execFileSync3 } from "node:child_process";
-import { mkdirSync as mkdirSync5, readdirSync as readdirSync3, readFileSync as readFileSync5, realpathSync as realpathSync2, statSync as statSync4, writeFileSync as writeFileSync3 } from "node:fs";
+import { mkdirSync as mkdirSync5, readdirSync as readdirSync3, readFileSync as readFileSync5, realpathSync as realpathSync3, statSync as statSync4, writeFileSync as writeFileSync3 } from "node:fs";
 import { basename as basename3, dirname as dirname6, isAbsolute as isAbsolute5, join as join7, resolve as resolve7 } from "node:path";
 class SddScriptError extends Error {
   exitCode;
@@ -1671,8 +1694,8 @@ function isLinkedWorktree(root) {
   if (gitDir.includes("/.git/worktrees/") || gitDir.includes("/worktrees/"))
     return true;
   try {
-    const gdParent = realpathSync2(dirname6(gitDir));
-    const cmAbs = realpathSync2(common);
+    const gdParent = realpathSync3(dirname6(gitDir));
+    const cmAbs = realpathSync3(common);
     return join7(gdParent, basename3(gitDir)) !== cmAbs && gitDir !== cmAbs;
   } catch {
     return false;
@@ -1690,10 +1713,10 @@ function sddWorkspace(planId, opts = {}) {
     if (!isDirectory2(controlRoot)) {
       throw new SddScriptError(`mstar sdd workspace: CONTROL_ROOT / MSTAR_CONTROL_ROOT is not a directory: ${controlRoot}`, 1);
     }
-    root = realpathSync2(controlRoot);
+    root = realpathSync3(controlRoot);
   } else {
     const topLevel = gitOut(cwd, ["rev-parse", "--show-toplevel"]);
-    root = realpathSync2(topLevel ?? cwd);
+    root = realpathSync3(topLevel ?? cwd);
   }
   if (!controlRoot && isLinkedWorktree(root)) {
     throw new SddScriptError(`mstar sdd workspace: linked worktree at ${root} has no {HARNESS_DIR}/status.json (default gitignore).
@@ -1727,7 +1750,7 @@ function sddWorkspace(planId, opts = {}) {
   mkdirSync5(sddDir, { recursive: true });
   writeFileSync3(join7(sddDir, ".gitignore"), `*
 `);
-  return realpathSync2(sddDir);
+  return realpathSync3(sddDir);
 }
 function taskBrief(planFile, taskN, outFile, opts = {}) {
   if (!planFile || !Number.isInteger(taskN) || taskN < 1) {
@@ -1879,7 +1902,7 @@ function implementerSessionStickyRules(input) {
   return { resume: true, reason: `sticky resume OK: host_agent_id ${session.host_agent_id}, next task ${nextTask}` };
 }
 // src/iteration.ts
-import { existsSync as existsSync4, readdirSync as readdirSync4, readFileSync as readFileSync6 } from "node:fs";
+import { existsSync as existsSync5, readdirSync as readdirSync4, readFileSync as readFileSync6 } from "node:fs";
 import { join as join8 } from "node:path";
 var COMPASS_STATUSES = ["active", "locked", "completed"];
 var DATE_RE2 = /^\d{4}-\d{2}-\d{2}$/;
@@ -2108,7 +2131,7 @@ function pushCadenceProbe(ciRunning, reviewWaveActive) {
   return { ok: violations.length === 0, violations };
 }
 function assertIndexRowObligations(iterationsDir) {
-  if (!existsSync4(iterationsDir)) {
+  if (!existsSync5(iterationsDir)) {
     return {
       ok: false,
       violations: [
@@ -2116,9 +2139,9 @@ function assertIndexRowObligations(iterationsDir) {
       ]
     };
   }
-  const iterationIds = readdirSync4(iterationsDir, { withFileTypes: true }).filter((entry) => entry.isDirectory()).filter((entry) => existsSync4(join8(iterationsDir, entry.name, COMPASS_FILE))).map((entry) => entry.name).sort();
+  const iterationIds = readdirSync4(iterationsDir, { withFileTypes: true }).filter((entry) => entry.isDirectory()).filter((entry) => existsSync5(join8(iterationsDir, entry.name, COMPASS_FILE))).map((entry) => entry.name).sort();
   const readmePath = join8(iterationsDir, INDEX_README);
-  if (!existsSync4(readmePath)) {
+  if (!existsSync5(readmePath)) {
     return {
       ok: false,
       violations: [
@@ -2209,7 +2232,7 @@ function parseFlowArray(raw, filePath) {
   return items;
 }
 // src/project.ts
-import { existsSync as existsSync5, readFileSync as readFileSync7, readdirSync as readdirSync5 } from "node:fs";
+import { existsSync as existsSync6, readFileSync as readFileSync7, readdirSync as readdirSync5 } from "node:fs";
 import { join as join9 } from "node:path";
 var PROJECT_ROADMAP_FILE = "roadmap.md";
 var PROJECT_REFERENCES_DIR = "references";
@@ -2393,7 +2416,7 @@ function techDebtRollup(projectDir) {
     if (!project.isDirectory())
       continue;
     const registerPath = join9(projectDir, project.name, PROJECT_REGISTER_FILE);
-    if (!existsSync5(registerPath))
+    if (!existsSync6(registerPath))
       continue;
     let register;
     try {
@@ -3674,7 +3697,7 @@ function scaffoldAuditPlan(outDir, findings, options = {}) {
   return { outDir: resolve9(outDir), date, files: written, nextNumber: next };
 }
 // src/compound.ts
-import { existsSync as existsSync6, readdirSync as readdirSync8, readFileSync as readFileSync10 } from "node:fs";
+import { existsSync as existsSync7, readdirSync as readdirSync8, readFileSync as readFileSync10 } from "node:fs";
 import { basename as basename4, isAbsolute as isAbsolute7, join as join12, relative as relative4, resolve as resolve10, sep as sep3 } from "node:path";
 function violation10(severity, code, message, fix) {
   return { ok: false, severity, code, message, fix };
@@ -3982,7 +4005,7 @@ function referenceExists(repoRoot, docText) {
   for (const { ref, isSymbol, module } of refs) {
     if (!isSymbol || module === undefined) {
       const candidate = ref.replace(LINE_SUFFIX_RE, "").replace(ANCHOR_RE, "");
-      if (existsSync6(resolve10(repoRoot, candidate))) {
+      if (existsSync7(resolve10(repoRoot, candidate))) {
         checked++;
       } else {
         violations.push(violation10("medium", "compound.reference.missing-file", `referenced path \`${ref}\` does not exist under ${repoRoot} (compound-refresh Phase 2: referenced code still exists?)`, "update the doc to reference an existing path, or delete the stale reference"));
@@ -4030,7 +4053,7 @@ function normalizeIndexRef(cell) {
 function assertIndexRows(knowledgeDir) {
   const violations = [];
   const readmePath = join12(knowledgeDir, "README.md");
-  if (!existsSync6(readmePath)) {
+  if (!existsSync7(readmePath)) {
     violations.push(violation10("medium", "compound.index.missing-readme", `missing ${readmePath} — the knowledge index is required (mstar-compound Phase 6: every doc gets a README.md row)`, "create knowledge/README.md with a Document / Source Plan / Description / Status table"));
     return { ok: false, violations };
   }
@@ -4315,7 +4338,7 @@ function lintStrategySections(docText) {
   return { ok: violations.length === 0, violations };
 }
 // src/roles.ts
-import { existsSync as existsSync7 } from "node:fs";
+import { existsSync as existsSync8 } from "node:fs";
 import { join as join13 } from "node:path";
 function violation12(severity, code, message, fix) {
   return { ok: false, severity, code, message, fix };
@@ -4372,7 +4395,7 @@ function validateRoleMapping(rolesDir, options = {}) {
   const violations = [];
   const referenceById = new Map(mapping.map((m) => [m.agentId, m.reference]));
   for (const { agentId, reference } of mapping) {
-    if (!existsSync7(join13(rolesDir, reference))) {
+    if (!existsSync8(join13(rolesDir, reference))) {
       violations.push(violation12("medium", "roles.mapping.reference.missing", `role "${agentId}" maps to ${reference} which does not exist under ${rolesDir} (mstar-roles § Role Reference Mapping)`, `create ${join13(rolesDir, reference)} or fix the mapping row`));
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mstar-harness/engine",
-  "version": "3.1.0",
+  "version": "3.1.2",
   "description": "Morning Star Harness Workflow Engine — deterministic workflow enforcement library (path, status, lease, dispatch, sdd, iteration, lint gates).",
   "license": "MIT",
   "repository": {