@msafe/sui3-sdk 1.0.23 → 1.0.24

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@msafe/sui3-sdk",
-  "version": "1.0.23",
+  "version": "1.0.24",
   "description": "SDK for MSafe SUI V3",
   "type": "module",
   "module": "./dist/index.js",

package/src/utils/gasFunding.ts

@@ -8,6 +8,12 @@ import { getAllCoins, SUI_COIN } from '@/utils/sui';
 
 const GAS_SAFE_OVERHEAD = 1000n;
 
+/** Protocol cap: a transaction may smash at most this many gas payment objects. */
+export const MAX_GAS_PAYMENT_OBJECTS = 256;
+
+/** Cover target for estimate probes (1 SUI is enough for a normal dry-run). */
+const ESTIMATE_GAS_COVER = 1_000_000_000n;
+
 export type GasFundingMode = 'classic' | 'addressBalance' | 'mixedTopUp';
 
 export interface GasFundingResult {
@@ -49,7 +55,37 @@ export function computeGasBudget(
   return BigInt(computationCost) + BigInt(storageCost) + safeOverhead;
 }
 
-type PaymentCoinRef = { objectId: string; version: string; digest: string; balance: bigint };
+export type PaymentCoinRef = { objectId: string; version: string; digest: string; balance: bigint };
+
+/**
+ * Pick the fewest large SUI coins that cover `cover`, capped at 256.
+ * Never attach every owned coin — accounts with hundreds of SUI objects
+ * exceed max_gas_payment_objects and trip gasless estimate
+ * ("gas_budget must be 0 for gasless transactions").
+ */
+export function pickGasPaymentCoins(coins: PaymentCoinRef[], cover: bigint): PaymentCoinRef[] {
+  if (cover <= 0n) {
+    return [];
+  }
+
+  const sorted = [...coins]
+    .filter((coin) => coin.balance > 0n)
+    .sort((a, b) => (a.balance === b.balance ? 0 : a.balance < b.balance ? 1 : -1));
+
+  const selected: PaymentCoinRef[] = [];
+  let sum = 0n;
+  for (const coin of sorted) {
+    if (selected.length >= MAX_GAS_PAYMENT_OBJECTS) {
+      break;
+    }
+    selected.push(coin);
+    sum += coin.balance;
+    if (sum >= cover) {
+      break;
+    }
+  }
+  return selected;
+}
 
 interface SuiGasFunding {
   paymentCoins: PaymentCoinRef[];
@@ -285,17 +321,18 @@ export async function selectGasFunding(input: {
   // gas (payment: []) is stricter on budget and is what Mysten auto-picks when
   // addressBalance > 0 — avoid it unless there is no usable gas coin.
   if (paymentCoins.length > 0 && coinBalance >= gasBudget) {
-    tx.setGasPayment(toObjectRefs(paymentCoins));
+    tx.setGasPayment(toObjectRefs(pickGasPaymentCoins(paymentCoins, gasBudget)));
     return { mode: 'classic', gasBudget, coinBalance, addressBalance };
   }
 
   if (paymentCoins.length > 0 && total >= gasBudget) {
     const topUpAmount = gasBudget - coinBalance; // > 0 and <= addressBalance
+    // One real coin is enough — reservation smashes into it.
     await applyMixedTopUp({
       tx,
       suiClient,
       owner,
-      paymentCoins,
+      paymentCoins: pickGasPaymentCoins(paymentCoins, 1n),
       topUpAmount,
     });
     return { mode: 'mixedTopUp', gasBudget, coinBalance, addressBalance };
@@ -381,9 +418,9 @@ export async function estimateGasBudget(input: {
   probe.setSender(owner);
   probe.setGasPrice(gasPrice);
 
-  // Prefer classic coins for the probe when available (cheaper than address-balance gas).
+  // Prefer a few large classic coins for the probe (never attach every owned coin).
   if (funding.paymentCoins.length > 0) {
-    probe.setGasPayment(toObjectRefs(funding.paymentCoins));
+    probe.setGasPayment(toObjectRefs(pickGasPaymentCoins(funding.paymentCoins, ESTIMATE_GAS_COVER)));
   }
 
   let built: Uint8Array;
@@ -500,6 +537,6 @@ export async function preferClassicGasPayment(input: {
   if (funding.paymentCoins.length === 0) {
     return false;
   }
-  tx.setGasPayment(toObjectRefs(funding.paymentCoins));
+  tx.setGasPayment(toObjectRefs(pickGasPaymentCoins(funding.paymentCoins, ESTIMATE_GAS_COVER)));
   return true;
 }