@msafe/sui3-sdk 0.0.75 → 0.0.76

package/src/simulate/simulator.ts

@@ -34,17 +34,6 @@ export const DEF_GAS_PRICE_OPTION: GasPriceOption = {
   },
 };
 
-// Default to 120% of the reference gas budget
-export const DEF_GAS_BUDGET_NUM = 120n;
-export const DEF_GAS_BUDGET_DEN = 100n;
-
-export const DEF_GAS_BUDGET_OPTION: GasBudgetOption = {
-  multiplier: {
-    numerator: DEF_GAS_BUDGET_NUM,
-    denominator: DEF_GAS_BUDGET_DEN,
-  },
-};
-
 export class Simulator {
   constructor(private globals: MSafeGlobals) {}
 
@@ -54,7 +43,6 @@ export class Simulator {
       sender: string;
     },
     gasOption: GasPriceOption = DEF_GAS_PRICE_OPTION,
-    budgetOption: GasBudgetOption = DEF_GAS_BUDGET_OPTION,
   ): Promise<SimulationResult> {
     const tx = this.copyTransactionBlock(input.txb);
 
@@ -62,49 +50,31 @@ export class Simulator {
 
     const gasPrice = await this.getGasPrice(gasOption);
 
-    // temporary disable gas price setting, unblock alphafi simulate error issue
-    // tx.setGasPrice(gasPrice);
-
-    try {
-      const inspectResult = await suiClient.dryRunTransactionBlock({
-        transactionBlock: await tx.build({ client: suiClient }),
-      });
-      const { gasUsed } = inspectResult.effects;
-      const gasBudget = this.toGasBudget(gasUsed, gasPrice);
-      const success = inspectResult.effects.status.status === 'success';
-      let error: string | undefined;
+    tx.setGasPrice(gasPrice);
 
-      if (!success) {
-        error = inspectResult.effects.status.error;
-      }
+    const inspectResult = await suiClient.dryRunTransactionBlock({
+      transactionBlock: await tx.build({ client: suiClient }),
+    });
+    const success = inspectResult.effects.status.status === 'success';
 
+    if (!success) {
       return {
         success,
         gasPrice,
-        gasObject: inspectResult.effects.gasObject.reference,
-        gasUsed,
-        gasBudget: this.applyBudgetOption(gasBudget, budgetOption),
-        simulationError: error,
         response: inspectResult,
+        simulationError: inspectResult.effects.status.error!,
       };
-    } catch (err) {
-      if (err instanceof Error) {
-        return {
-          success: false,
-          gasObject: { digest: '', objectId: '', version: '' },
-          gasPrice: 0n,
-          gasBudget: 0n,
-          gasUsed: {
-            computationCost: '',
-            nonRefundableStorageFee: '',
-            storageCost: '',
-            storageRebate: '',
-          },
-          simulationError: err.message,
-        };
-      }
-      throw err;
     }
+    const gasBudget = this.toGasBudget(inspectResult.effects.gasUsed, gasPrice);
+
+    return {
+      success,
+      gasPrice,
+      gasObject: inspectResult.effects.gasObject.reference,
+      gasUsed: inspectResult.effects.gasUsed,
+      gasBudget,
+      response: inspectResult,
+    };
   }
 
   private async getGasPrice(option: GasPriceOption) {
@@ -118,14 +88,13 @@ export class Simulator {
   }
 
   private toGasBudget(gasUsed: GasCostSummary, gasPrice: bigint) {
-    const { computationCost, storageCost } = gasUsed;
+    const { computationCost, storageCost, storageRebate } = gasUsed;
     const safeOverhead = GAS_SAFE_OVERHEAD * gasPrice;
 
     const baseComputationCostWithOverhead = BigInt(computationCost) + safeOverhead;
 
     // do not subtract rebate for now, because it may cause normally tx gas to be lower than empty tx gas
-    // const gasBudget = baseComputationCostWithOverhead + BigInt(storageCost) - BigInt(storageRebate);
-    const gasBudget = baseComputationCostWithOverhead + BigInt(storageCost);
+    const gasBudget = baseComputationCostWithOverhead + BigInt(storageCost) - BigInt(storageRebate);
 
     // Set the budget to max(computation, computation + storage - rebate)
     return gasBudget > baseComputationCostWithOverhead ? gasBudget : baseComputationCostWithOverhead;
@@ -150,17 +119,6 @@ export class Simulator {
     throw new Error('Sanity: Unknown gas price option');
   }
 
-  private applyBudgetOption(val: bigint, option: GasBudgetOption) {
-    if (this.isFixedValue(option)) {
-      return option.fixedVal;
-    }
-    if (this.isMultiplier(option)) {
-      const { multiplier } = option;
-      return (val * multiplier.numerator) / multiplier.denominator;
-    }
-    throw new Error('Sanity: Unknown gas budget option');
-  }
-
   private copyTransactionBlock(tx: TransactionBlock): TransactionBlock {
     return TransactionBlock.from(tx.serialize());
   }

package/src/types/msafe.ts

@@ -80,14 +80,22 @@ export interface ProposeIntention {
   signature: SerializedSignature;
 }
 
-export interface SimulationResult {
-  success: boolean;
+export type SimulationResult = SimulationSuccessResult | SimulationFailedResult;
+
+export interface SimulationSuccessResult {
+  success: true;
   gasPrice: bigint;
   gasUsed: GasCostSummary;
   gasBudget: bigint;
   gasObject: SuiObjectRef;
-  simulationError?: string;
-  response?: DryRunTransactionBlockResponse;
+  response: DryRunTransactionBlockResponse;
+}
+
+export interface SimulationFailedResult {
+  success: false;
+  gasPrice: bigint;
+  response: DryRunTransactionBlockResponse;
+  simulationError: string;
 }
 
 export interface SimulationOption extends IGasOption {