npm - @mrpalmer/eslint-config - Versions diffs - 2.3.0 → 2.4.0 - Mend

@mrpalmer/eslint-config 2.3.0 → 2.4.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (16) hide show

package/configs/react.js +1 -1
package/configs/tests.js +190 -0
package/configs/typescript.js +1 -0
package/index.js +3 -3
package/package.json +20 -13
package/types/configs/base.d.ts +1 -1
package/types/configs/react.d.ts +1 -1
package/types/configs/tests.d.ts +2 -0
package/types/configs/typescript.d.ts +1 -1
package/types/index.d.ts +3 -3
package/.turbo/turbo-build.log +0 -8
package/CHANGELOG.md +0 -39
package/configs/jest.js +0 -105
package/tsconfig.json +0 -10
package/turbo.json +0 -8
package/types/configs/jest.d.ts +0 -2

package/configs/react.js CHANGED Viewed

@@ -57,6 +57,7 @@ export default defineConfig(
       'jsx-a11y/prefer-tag-over-role': 'off',
       'jsx-a11y/tabindex-no-positive': 'warn',
+      '@eslint-react/jsx-dollar': 'warn',
       '@eslint-react/jsx-key-before-spread': 'warn',
       '@eslint-react/jsx-no-iife': 'warn',
       '@eslint-react/jsx-no-undef': 'error',
@@ -64,7 +65,6 @@ export default defineConfig(
       '@eslint-react/jsx-shorthand-fragment': 'warn',
       '@eslint-react/no-children-prop': 'warn',
       '@eslint-react/no-class-component': 'warn',
-      '@eslint-react/no-forbidden-props': 'off',
       '@eslint-react/no-leaked-conditional-rendering': 'off', // will be enabled for typescript files below
       '@eslint-react/no-missing-component-display-name': 'warn',
       '@eslint-react/no-missing-context-display-name': 'warn',

package/configs/tests.js ADDED Viewed

@@ -0,0 +1,190 @@
+import pluginVitest from '@vitest/eslint-plugin'
+import { defineConfig } from 'eslint/config'
+import pluginJest from 'eslint-plugin-jest'
+import pluginJestDom from 'eslint-plugin-jest-dom'
+import pluginTestingLibrary from 'eslint-plugin-testing-library'
+import { getAllDependencies } from '../utils/packageJson.js'
+const allDeps = new Set(Object.keys(getAllDependencies()))
+const hasJest = allDeps.has('jest')
+const hasVitest = allDeps.has('vitest')
+const hasJestDom = allDeps.has('@testing-library/jest-dom')
+const hasTestingLibraryDom = allDeps.has('@testing-library/dom')
+const hasTestingLibraryReact = allDeps.has('@testing-library/react')
+const hasTestingLibrary = hasTestingLibraryDom || hasTestingLibraryReact
+export default defineConfig(
+  {
+    extends: [
+      hasJest && {
+        name: 'jest/recommended',
+        ...pluginJest.configs['flat/recommended'],
+      },
+      hasJest && { name: 'jest/style', ...pluginJest.configs['flat/style'] },
+      hasVitest && pluginVitest.configs.recommended,
+      hasJestDom && {
+        name: 'jest-dom/recommended',
+        ...pluginJestDom.configs['flat/recommended'],
+      },
+      hasTestingLibraryReact
+        ? {
+            name: 'testing-library/react',
+            ...pluginTestingLibrary.configs['flat/react'],
+          }
+        : hasTestingLibraryDom
+          ? {
+              name: 'testing-library/dom',
+              ...pluginTestingLibrary.configs['flat/dom'],
+            }
+          : null,
+    ].filter(Boolean),
+    files: ['**/__tests__/**/*.+(js|ts)?(x)', '**/*.{spec,test}.+(js|ts)?(x)'],
+    name: 'mrpalmer/jest',
+    rules: {
+      // we don't need a display name in test files
+      '@eslint-react/no-missing-component-display-name': 'off',
+      '@eslint-react/no-missing-context-display-name': 'off',
+      ...(hasJest
+        ? {
+            'jest/consistent-test-it': 'warn',
+            'jest/max-expects': 'off',
+            'jest/max-nested-describe': 'error',
+            'jest/no-conditional-in-test': 'error',
+            'jest/no-confusing-set-timeout': 'error',
+            'jest/no-duplicate-hooks': 'off',
+            'jest/no-hooks': 'off',
+            'jest/no-large-snapshots': ['warn', { maxSize: 300 }],
+            'jest/no-restricted-jest-methods': 'off',
+            'jest/no-restricted-matchers': 'off',
+            'jest/no-test-return-statement': 'off',
+            'jest/no-untyped-mock-factory': 'error',
+            'jest/padding-around-after-all-blocks': 'off',
+            'jest/padding-around-after-each-blocks': 'off',
+            'jest/padding-around-all': 'off',
+            'jest/padding-around-before-all-blocks': 'off',
+            'jest/padding-around-before-each-blocks': 'off',
+            'jest/padding-around-describe-blocks': 'off',
+            'jest/padding-around-expect-groups': 'off',
+            'jest/padding-around-test-blocks': 'off',
+            'jest/prefer-called-with': 'error',
+            'jest/prefer-comparison-matcher': 'warn',
+            'jest/prefer-each': 'warn',
+            'jest/prefer-ending-with-an-expect': 'warn',
+            'jest/prefer-equality-matcher': 'warn',
+            'jest/prefer-expect-assertions': 'off',
+            'jest/prefer-expect-resolves': 'off',
+            'jest/prefer-hooks-in-order': 'error',
+            'jest/prefer-hooks-on-top': 'error',
+            'jest/prefer-importing-jest-globals': 'off',
+            'jest/prefer-jest-mocked': 'warn',
+            'jest/prefer-lowercase-title': 'off',
+            'jest/prefer-mock-promise-shorthand': 'warn',
+            'jest/prefer-snapshot-hint': ['error', 'multi'],
+            'jest/prefer-spy-on': 'warn',
+            'jest/prefer-strict-equal': 'off',
+            'jest/prefer-todo': 'warn',
+            'jest/require-hook': 'off',
+            'jest/require-to-throw-message': 'off',
+            'jest/require-top-level-describe': 'off',
+            'jest/unbound-method': 'off',
+            'jest/valid-mock-module-path': 'warn',
+          }
+        : {}),
+      ...(hasVitest
+        ? {
+            'vitest/consistent-test-filename': 'off',
+            'vitest/consistent-test-it': 'warn',
+            'vitest/consistent-vitest-vi': 'warn',
+            'vitest/hoisted-apis-on-top': 'error',
+            'vitest/max-expects': 'off',
+            'vitest/max-nested-describe': 'error',
+            'vitest/no-alias-methods': 'off',
+            'vitest/no-conditional-expect': 'error',
+            'vitest/no-conditional-in-test': 'error',
+            'vitest/no-conditional-tests': 'error',
+            'vitest/no-disabled-tests': 'warn',
+            'vitest/no-duplicate-hooks': 'off',
+            'vitest/no-focused-tests': 'error',
+            'vitest/no-hooks': 'off',
+            'vitest/no-importing-vitest-globals': 'off',
+            'vitest/no-interpolation-in-snapshots': 'warn',
+            'vitest/no-large-snapshots': ['warn', { maxSize: 300 }],
+            'vitest/no-mocks-import': 'error',
+            'vitest/no-restricted-matchers': 'off',
+            'vitest/no-restricted-vi-methods': 'off',
+            'vitest/no-standalone-expect': 'error',
+            'vitest/no-test-prefixes': 'off',
+            'vitest/no-test-return-statement': 'error',
+            'vitest/prefer-called-once': 'warn',
+            'vitest/prefer-called-times': 'off',
+            'vitest/prefer-called-with': 'error',
+            'vitest/prefer-comparison-matcher': 'warn',
+            'vitest/prefer-describe-function-title': 'warn',
+            'vitest/prefer-each': 'warn',
+            'vitest/prefer-equality-matcher': 'warn',
+            'vitest/prefer-expect-assertions': 'off',
+            'vitest/prefer-expect-resolves': 'off',
+            'vitest/prefer-expect-type-of': 'warn',
+            'vitest/prefer-hooks-in-order': 'error',
+            'vitest/prefer-hooks-on-top': 'error',
+            'vitest/prefer-import-in-mock': 'warn',
+            'vitest/prefer-importing-vitest-globals': 'off',
+            'vitest/prefer-lowercase-title': 'off',
+            'vitest/prefer-mock-promise-shorthand': 'warn',
+            'vitest/prefer-snapshot-hint': ['error', 'multi'],
+            'vitest/prefer-spy-on': 'warn',
+            'vitest/prefer-strict-boolean-matchers': 'off',
+            'vitest/prefer-strict-equal': 'off',
+            'vitest/prefer-to-be': 'warn',
+            'vitest/prefer-to-be-falsy': 'off',
+            'vitest/prefer-to-be-object': 'warn',
+            'vitest/prefer-to-be-truthy': 'off',
+            'vitest/prefer-to-contain': 'warn',
+            'vitest/prefer-to-have-length': 'warn',
+            'vitest/prefer-todo': 'warn',
+            'vitest/prefer-vi-mocked': 'warn',
+            'vitest/require-awaited-expect-poll': 'error',
+            'vitest/require-hook': 'off',
+            'vitest/require-mock-type-parameters': 'off',
+            'vitest/require-to-throw-message': 'off',
+            'vitest/require-top-level-describe': 'off',
+            'vitest/valid-expect-in-promise': 'error',
+            'vitest/warn-todo': 'warn',
+            // disable style rules
+            'vitest/padding-around-after-all-blocks': 'off',
+            'vitest/padding-around-after-each-blocks': 'off',
+            'vitest/padding-around-all': 'off',
+            'vitest/padding-around-before-all-blocks': 'off',
+            'vitest/padding-around-before-each-blocks': 'off',
+            'vitest/padding-around-describe-blocks': 'off',
+            'vitest/padding-around-expect-groups': 'off',
+            'vitest/padding-around-test-blocks': 'off',
+          }
+        : {}),
+      ...(hasTestingLibrary
+        ? {
+            'testing-library/consistent-data-testid': 'off',
+            'testing-library/no-test-id-queries': 'warn',
+            'testing-library/prefer-explicit-assert': 'warn',
+            'testing-library/prefer-implicit-assert': 'off',
+            'testing-library/prefer-query-matchers': 'off',
+            'testing-library/prefer-user-event': 'error',
+          }
+        : null),
+    },
+  },
+  {
+    files: ['**/__tests__/**/*.ts?(x)', '**/*.{spec,test}.ts?(x)'],
+    name: 'mrpalmer/jest/typescript',
+    rules: {
+      '@typescript-eslint/unbound-method': 'off',
+      'jest/unbound-method': 'error',
+    },
+  }
+)

package/configs/typescript.js CHANGED Viewed

@@ -133,6 +133,7 @@ export default defineConfig({
     '@typescript-eslint/no-unnecessary-type-arguments': 'warn',
     '@typescript-eslint/no-unnecessary-type-conversion': 'warn',
     '@typescript-eslint/no-unsafe-type-assertion': 'error',
+    '@typescript-eslint/no-unused-private-class-members': 'error',
     '@typescript-eslint/no-useless-empty-export': 'error',
     '@typescript-eslint/parameter-properties': [
       'error',

package/index.js CHANGED Viewed

@@ -1,14 +1,14 @@
 import globals from 'globals'
 import base from './configs/base.js'
-import jest from './configs/jest.js'
 import react from './configs/react.js'
+import tests from './configs/tests.js'
 import typescript from './configs/typescript.js'
 const configs = {
-  all: [...base, ...typescript, ...react, ...jest],
+  all: [...base, ...typescript, ...react, ...tests],
   base,
-  jest,
   react,
+  tests,
   typescript,
 }

package/package.json CHANGED Viewed

@@ -1,44 +1,51 @@
 {
   "name": "@mrpalmer/eslint-config",
-  "version": "2.3.0",
+  "version": "2.4.0",
   "description": "Mike Palmer's personal ESLint rules",
   "license": "MIT",
   "type": "module",
   "exports": {
     ".": {
-      "import": "./index.js",
-      "types": "./types/index.d.ts"
+      "types": "./types/index.d.ts",
+      "default": "./index.js"
     },
     "./package.json": "./package.json"
   },
-  "main": "index.js",
+  "module": "index.js",
   "types": "types/index.d.ts",
+  "files": [
+    "index.js",
+    "configs",
+    "types",
+    "utils"
+  ],
   "scripts": {
     "prebuild": "rm -rf types",
     "build": "tsc",
     "check-config": "run-p check-config:*",
-    "check-config:jest": "cd test && validate-config -f component.test.js",
-    "check-config:jest-ts": "cd test && validate-config -f component.test.ts",
     "check-config:js": "cd test && validate-config -f index.js",
+    "check-config:tests": "cd test && validate-config -f component.test.js",
+    "check-config:tests-ts": "cd test && validate-config -f component.test.ts",
     "check-config:ts": "cd test && validate-config -f index.ts",
     "dev": "cd test && eslint-config-inspector",
     "validate": "npm run check-config"
   },
   "dependencies": {
-    "@eslint-react/eslint-plugin": "^2.2.2",
-    "@eslint/js": "^9.31.0",
-    "@mrpalmer/eslint-plugin": "^1.0.2",
+    "@eslint-react/eslint-plugin": "^2.3.7",
+    "@eslint/js": "^9.39.1",
+    "@mrpalmer/eslint-plugin": "^1.0.3",
+    "@vitest/eslint-plugin": "^1.4.3",
     "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-import-x": "^4.16.1",
-    "eslint-plugin-jest": "^29.0.1",
+    "eslint-plugin-jest": "^29.2.0",
     "eslint-plugin-jest-dom": "^5.5.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
-    "eslint-plugin-react-hooks": "^7.0.0",
-    "eslint-plugin-testing-library": "^7.13.3",
+    "eslint-plugin-react-hooks": "^7.0.1",
+    "eslint-plugin-testing-library": "^7.13.5",
     "globals": "^16.4.0",
     "read-package-up": "^11.0.0",
     "semver": "^7.7.3",
-    "typescript-eslint": "^8.46.1"
+    "typescript-eslint": "^8.47.0"
   },
   "peerDependencies": {
     "@testing-library/dom": "*",

package/types/configs/base.d.ts CHANGED Viewed

@@ -1,2 +1,2 @@
-declare const _default: import("@eslint/core", { with: { "resolution-mode": "require" } }).ConfigObject<import("@eslint/core", { with: { "resolution-mode": "require" } }).RulesConfig>[];
+declare const _default: import("eslint/config").Config[];
 export default _default;

package/types/configs/react.d.ts CHANGED Viewed

@@ -1,2 +1,2 @@
-declare const _default: import("@eslint/core", { with: { "resolution-mode": "require" } }).ConfigObject<import("@eslint/core", { with: { "resolution-mode": "require" } }).RulesConfig>[];
+declare const _default: import("eslint/config").Config[];
 export default _default;

package/types/configs/tests.d.ts ADDED Viewed

	@@ -0,0 +1,2 @@
1	+ declare const _default: import("eslint/config").Config[];
2	+ export default _default;

package/types/configs/typescript.d.ts CHANGED Viewed

@@ -1,2 +1,2 @@
-declare const _default: import("@eslint/core", { with: { "resolution-mode": "require" } }).ConfigObject<import("@eslint/core", { with: { "resolution-mode": "require" } }).RulesConfig>[];
+declare const _default: import("eslint/config").Config[];
 export default _default;

package/types/index.d.ts CHANGED Viewed

@@ -4,15 +4,15 @@ declare namespace _default {
 }
 export default _default;
 export namespace configs {
-    export let all: import("@eslint/core", { with: { "resolution-mode": "require" } }).ConfigObject<import("@eslint/core", { with: { "resolution-mode": "require" } }).RulesConfig>[];
+    export let all: import("eslint/config").Config[];
     export { base };
-    export { jest };
     export { react };
+    export { tests };
     export { typescript };
 }
 import globals from 'globals';
 import base from './configs/base.js';
-import jest from './configs/jest.js';
 import react from './configs/react.js';
+import tests from './configs/tests.js';
 import typescript from './configs/typescript.js';
 export { globals };

package/.turbo/turbo-build.log DELETED Viewed

@@ -1,8 +0,0 @@
-> @mrpalmer/eslint-config@2.3.0 prebuild
-> rm -rf types
-> @mrpalmer/eslint-config@2.3.0 build
-> tsc

package/CHANGELOG.md DELETED Viewed

@@ -1,39 +0,0 @@
-# @mrpalmer/eslint-config
-## 2.3.0
-### Minor Changes
-- 5e223a2: Upgrade plugins and configure new rules
-### Patch Changes
-- b99f7df: Update dependencies
-- Updated dependencies [03c9f7f]
-  - @mrpalmer/eslint-plugin@1.0.2
-## 2.2.0
-### Minor Changes
-- afbdd32: Replace `eslint-plugin-react` with `@eslint-react/eslint-plugin`
-### Patch Changes
-- 1e43272: Update ESLint plugins
-- 32711bf: Fix order of configs in "all"
-- df14ce7: Export TypeScript types
-- Updated dependencies [96a657e]
-  - @mrpalmer/eslint-plugin@1.0.1
-## 2.1.0
-### Minor Changes
-- 63cec80: - Replace `eslint-plugin-import` with `eslint-plugin-import-x`
-  - Add `@mrpalmer/eslint-plugin` to default config
-### Patch Changes
-- Updated dependencies [1e5fa18]
-  - @mrpalmer/eslint-plugin@1.0.0

package/configs/jest.js DELETED Viewed

@@ -1,105 +0,0 @@
-import { defineConfig } from 'eslint/config'
-import pluginJest from 'eslint-plugin-jest'
-import pluginJestDom from 'eslint-plugin-jest-dom'
-import pluginTestingLibrary from 'eslint-plugin-testing-library'
-import { getAllDependencies } from '../utils/packageJson.js'
-const allDeps = new Set(Object.keys(getAllDependencies()))
-const hasJestDom = allDeps.has('@testing-library/jest-dom')
-const hasTestingLibraryDom = allDeps.has('@testing-library/dom')
-const hasTestingLibraryReact = allDeps.has('@testing-library/react')
-const hasTestingLibrary = hasTestingLibraryDom || hasTestingLibraryReact
-export default defineConfig(
-  {
-    extends: [
-      { name: 'jest/recommended', ...pluginJest.configs['flat/recommended'] },
-      { name: 'jest/style', ...pluginJest.configs['flat/style'] },
-      hasJestDom && {
-        name: 'jest-dom/recommended',
-        ...pluginJestDom.configs['flat/recommended'],
-      },
-      hasTestingLibraryReact
-        ? {
-            name: 'testing-library/react',
-            ...pluginTestingLibrary.configs['flat/react'],
-          }
-        : hasTestingLibraryDom
-          ? {
-              name: 'testing-library/dom',
-              ...pluginTestingLibrary.configs['flat/dom'],
-            }
-          : null,
-    ].filter(Boolean),
-    files: ['**/__tests__/**/*.+(js|ts)?(x)', '**/*.{spec,test}.+(js|ts)?(x)'],
-    name: 'mrpalmer/jest',
-    rules: {
-      // we don't need a display name in test files
-      '@eslint-react/no-missing-component-display-name': 'off',
-      '@eslint-react/no-missing-context-display-name': 'off',
-      'jest/consistent-test-it': 'off',
-      'jest/max-expects': 'off',
-      'jest/max-nested-describe': 'error',
-      'jest/no-conditional-in-test': 'error',
-      'jest/no-confusing-set-timeout': 'error',
-      'jest/no-duplicate-hooks': 'off',
-      'jest/no-hooks': 'off',
-      'jest/no-large-snapshots': ['warn', { maxSize: 300 }],
-      'jest/no-restricted-jest-methods': 'off',
-      'jest/no-restricted-matchers': 'off',
-      'jest/no-test-return-statement': 'off',
-      'jest/no-untyped-mock-factory': 'error',
-      'jest/padding-around-after-all-blocks': 'off',
-      'jest/padding-around-after-each-blocks': 'off',
-      'jest/padding-around-all': 'off',
-      'jest/padding-around-before-all-blocks': 'off',
-      'jest/padding-around-before-each-blocks': 'off',
-      'jest/padding-around-describe-blocks': 'off',
-      'jest/padding-around-expect-groups': 'off',
-      'jest/padding-around-test-blocks': 'off',
-      'jest/prefer-called-with': 'error',
-      'jest/prefer-comparison-matcher': 'warn',
-      'jest/prefer-each': 'warn',
-      'jest/prefer-ending-with-an-expect': 'warn',
-      'jest/prefer-equality-matcher': 'warn',
-      'jest/prefer-expect-assertions': 'off',
-      'jest/prefer-expect-resolves': 'off',
-      'jest/prefer-hooks-in-order': 'error',
-      'jest/prefer-hooks-on-top': 'error',
-      'jest/prefer-importing-jest-globals': 'off',
-      'jest/prefer-jest-mocked': 'warn',
-      'jest/prefer-lowercase-title': 'off',
-      'jest/prefer-mock-promise-shorthand': 'warn',
-      'jest/prefer-snapshot-hint': ['error', 'multi'],
-      'jest/prefer-spy-on': 'off',
-      'jest/prefer-strict-equal': 'off',
-      'jest/prefer-todo': 'warn',
-      'jest/require-hook': 'off',
-      'jest/require-to-throw-message': 'off',
-      'jest/require-top-level-describe': 'off',
-      'jest/unbound-method': 'off',
-      ...(hasTestingLibrary
-        ? {
-            'testing-library/consistent-data-testid': 'off',
-            'testing-library/no-test-id-queries': 'warn',
-            'testing-library/prefer-explicit-assert': 'warn',
-            'testing-library/prefer-implicit-assert': 'off',
-            'testing-library/prefer-query-matchers': 'off',
-            'testing-library/prefer-user-event': 'error',
-          }
-        : null),
-    },
-  },
-  {
-    files: ['**/__tests__/**/*.ts?(x)', '**/*.{spec,test}.ts?(x)'],
-    name: 'mrpalmer/jest/typescript',
-    rules: {
-      '@typescript-eslint/unbound-method': 'off',
-      'jest/unbound-method': 'error',
-    },
-  }
-)

package/tsconfig.json DELETED Viewed

@@ -1,10 +0,0 @@
-{
-  "extends": "../../tsconfig.json",
-  "compilerOptions": {
-    "allowJs": true,
-    "declaration": true,
-    "declarationDir": "./types",
-    "emitDeclarationOnly": true
-  },
-  "include": ["index.js"]
-}

package/turbo.json DELETED Viewed

@@ -1,8 +0,0 @@
-{
-  "extends": ["//"],
-  "tasks": {
-    "build": {
-      "outputs": ["types/**"]
-    }
-  }
-}

package/types/configs/jest.d.ts DELETED Viewed

	@@ -1,2 +0,0 @@
1	- declare const _default: import("@eslint/core", { with: { "resolution-mode": "require" } }).ConfigObject<import("@eslint/core", { with: { "resolution-mode": "require" } }).RulesConfig>[];
2	- export default _default;