@mrpalmer/eslint-config 2.2.0 → 2.3.1

package/configs/base.js

@@ -1,9 +1,9 @@
 import eslint from '@eslint/js'
 import mrpalmerPlugin from '@mrpalmer/eslint-plugin'
+import { defineConfig } from 'eslint/config'
 import pluginImport from 'eslint-plugin-import-x'
-import { config } from 'typescript-eslint'
 
-export default config(
+export default defineConfig(
   {
     name: 'eslint/recommended',
     ...eslint.configs.recommended,
@@ -120,6 +120,7 @@ export default config(
       'no-template-curly-in-string': 'error',
       'no-ternary': 'off',
       'no-throw-literal': 'error',
+      'no-unassigned-vars': 'error',
       'no-undef-init': 'error',
       'no-undefined': 'off',
       'no-underscore-dangle': 'off',
@@ -170,6 +171,7 @@ export default config(
       'prefer-rest-params': 'error',
       'prefer-spread': 'error',
       'prefer-template': 'error',
+      'preserve-caught-error': 'warn',
       radix: 'error',
       'require-atomic-updates': 'off',
       'require-await': 'off',

package/configs/jest.js

@@ -1,7 +1,7 @@
+import { defineConfig } from 'eslint/config'
 import pluginJest from 'eslint-plugin-jest'
 import pluginJestDom from 'eslint-plugin-jest-dom'
 import pluginTestingLibrary from 'eslint-plugin-testing-library'
-import tseslint from 'typescript-eslint'
 import { getAllDependencies } from '../utils/packageJson.js'
 
 const allDeps = new Set(Object.keys(getAllDependencies()))
@@ -11,7 +11,7 @@ const hasTestingLibraryDom = allDeps.has('@testing-library/dom')
 const hasTestingLibraryReact = allDeps.has('@testing-library/react')
 const hasTestingLibrary = hasTestingLibraryDom || hasTestingLibraryReact
 
-export default tseslint.config(
+export default defineConfig(
   {
     extends: [
       { name: 'jest/recommended', ...pluginJest.configs['flat/recommended'] },

package/configs/react.js

@@ -1,8 +1,8 @@
 import pluginReact from '@eslint-react/eslint-plugin'
+import { defineConfig } from 'eslint/config'
 import pluginJsxA11y from 'eslint-plugin-jsx-a11y'
 import pluginReactHooks from 'eslint-plugin-react-hooks'
 import globals from 'globals'
-import tseslint from 'typescript-eslint'
 import * as deprecated from '../utils/deprecated.js'
 import {
   getAllDependencies,
@@ -21,17 +21,14 @@ const jsxA11yRecommended = deprecated.remove(
   ['jsx-a11y/label-has-for']
 )
 
-export default tseslint.config(
+export default defineConfig(
   {
     extends: [
       pluginReact.configs.recommended,
       jsxA11yRecommended,
       {
         name: 'react-hooks/recommended',
-        plugins: {
-          'react-hooks': pluginReactHooks,
-        },
-        rules: pluginReactHooks.configs.recommended.rules,
+        ...pluginReactHooks.configs.flat['recommended-latest'],
       },
     ],
     files: ['**/*.{js,jsx,ts,tsx}'],
@@ -42,43 +39,55 @@ export default tseslint.config(
     },
     name: 'mrpalmer/react',
     rules: {
+      'react-hooks/automatic-effect-dependencies': 'off',
+      'react-hooks/capitalized-calls': 'off',
+      'react-hooks/fbt': 'off',
+      'react-hooks/fire': 'off',
+      'react-hooks/hooks': 'off',
+      'react-hooks/invariant': 'off',
+      'react-hooks/memoized-effect-dependencies': 'off',
+      'react-hooks/no-deriving-state-in-effects': 'off',
+      'react-hooks/rule-suppression': 'off',
+      'react-hooks/syntax': 'off',
+      'react-hooks/todo': 'off',
+
       'jsx-a11y/lang': 'error',
       'jsx-a11y/no-aria-hidden-on-focusable': 'off',
       'jsx-a11y/no-autofocus': 'off',
       'jsx-a11y/prefer-tag-over-role': 'off',
       'jsx-a11y/tabindex-no-positive': 'warn',
 
-      '@eslint-react/avoid-shorthand-boolean': 'off',
-      '@eslint-react/avoid-shorthand-fragment': 'off',
+      '@eslint-react/jsx-key-before-spread': 'warn',
       '@eslint-react/jsx-no-iife': 'warn',
       '@eslint-react/jsx-no-undef': 'error',
+      '@eslint-react/jsx-shorthand-boolean': 'warn',
+      '@eslint-react/jsx-shorthand-fragment': 'warn',
       '@eslint-react/no-children-prop': 'warn',
       '@eslint-react/no-class-component': 'warn',
-      '@eslint-react/no-complex-conditional-rendering': 'warn',
+      '@eslint-react/no-forbidden-props': 'off',
       '@eslint-react/no-leaked-conditional-rendering': 'off', // will be enabled for typescript files below
       '@eslint-react/no-missing-component-display-name': 'warn',
       '@eslint-react/no-missing-context-display-name': 'warn',
+      '@eslint-react/no-misused-capture-owner-stack': 'error',
+      '@eslint-react/no-unnecessary-key': 'warn',
+      '@eslint-react/no-unnecessary-use-callback': 'warn',
+      '@eslint-react/no-unnecessary-use-memo': 'warn',
+      '@eslint-react/no-unstable-context-value': 'warn',
+      '@eslint-react/no-unstable-default-props': 'warn',
+      '@eslint-react/no-unused-props': 'warn',
+      '@eslint-react/no-unused-state': 'warn',
       '@eslint-react/no-useless-fragment': 'warn',
       '@eslint-react/prefer-destructuring-assignment': 'warn',
-      '@eslint-react/prefer-react-namespace-import': 'warn',
+      '@eslint-react/prefer-namespace-import': 'warn',
       '@eslint-react/prefer-read-only-props': 'off', // may be enabled for typescript files below
-      '@eslint-react/prefer-shorthand-boolean': 'warn',
-      '@eslint-react/prefer-shorthand-fragment': 'warn',
-
-      '@eslint-react/debug/class-component': 'off',
-      '@eslint-react/debug/function-component': 'off',
-      '@eslint-react/debug/hook': 'off',
-      '@eslint-react/debug/is-from-react': 'off',
-      '@eslint-react/debug/jsx': 'off',
-      '@eslint-react/debug/react-hooks': 'off',
 
-      '@eslint-react/dom/no-children-in-void-dom-elements': 'error',
+      '@eslint-react/dom/no-missing-button-type': 'off',
+      '@eslint-react/dom/no-missing-iframe-sandbox': 'off',
+      '@eslint-react/dom/no-string-style-prop': 'error',
       '@eslint-react/dom/no-unknown-property': 'error',
-
-      '@eslint-react/hooks-extra/no-direct-set-state-in-use-layout-effect':
-        'warn',
-      '@eslint-react/hooks-extra/no-unnecessary-use-callback': 'warn',
-      '@eslint-react/hooks-extra/no-unnecessary-use-memo': 'warn',
+      '@eslint-react/dom/no-unsafe-target-blank': 'warn',
+      '@eslint-react/dom/no-void-elements-with-children': 'error',
+      '@eslint-react/dom/prefer-namespace-import': 'error',
 
       '@eslint-react/naming-convention/component-name': 'warn',
       '@eslint-react/naming-convention/filename': 'off', // this needs to be configured per project
@@ -87,21 +96,6 @@ export default tseslint.config(
         'as-needed',
       ],
       '@eslint-react/naming-convention/use-state': 'off',
-
-      // @eslint-react/eslint-plugin marks their rules as deprecated in jsdoc,
-      // but not in the rule's metadata.
-      ...deprecated.disable('@eslint-react', [
-        'ensure-forward-ref-using-ref',
-        'no-complicated-conditional-rendering',
-        'no-duplicate-jsx-props',
-        'no-nested-components',
-        'use-jsx-vars',
-        'hooks-extra/ensure-custom-hooks-using-other-hooks',
-        'hooks-extra/ensure-use-callback-has-non-empty-deps',
-        'hooks-extra/ensure-use-memo-has-non-empty-deps',
-        'hooks-extra/no-redundant-custom-hook',
-        'hooks-extra/no-useless-custom-hooks',
-      ]),
     },
     settings: {
       'react-x': {

package/configs/typescript.js

@@ -1,3 +1,4 @@
+import { defineConfig } from 'eslint/config'
 import { createTypeScriptImportResolver } from 'eslint-import-resolver-typescript'
 import pluginImport from 'eslint-plugin-import-x'
 import tseslint from 'typescript-eslint'
@@ -13,7 +14,7 @@ tseslint.configs.stylisticTypeChecked.forEach(disableDeprecatedRules)
 
 delete pluginImport.flatConfigs.typescript.settings['import-x/resolver']
 
-export default tseslint.config({
+export default defineConfig({
   extends: [
     ...tseslint.configs.strictTypeChecked,
     ...tseslint.configs.stylisticTypeChecked,

package/index.js

@@ -1,5 +1,4 @@
 import globals from 'globals'
-import { config } from 'typescript-eslint'
 import base from './configs/base.js'
 import jest from './configs/jest.js'
 import react from './configs/react.js'
@@ -14,8 +13,7 @@ const configs = {
 }
 
 export default {
-  config,
   configs,
   globals,
 }
-export { config, configs, globals }
+export { configs, globals }

package/package.json

@@ -1,18 +1,24 @@
 {
   "name": "@mrpalmer/eslint-config",
-  "version": "2.2.0",
+  "version": "2.3.1",
   "description": "Mike Palmer's personal ESLint rules",
   "license": "MIT",
   "type": "module",
   "exports": {
     ".": {
-      "import": "./index.js",
-      "types": "./types/index.d.ts"
+      "types": "./types/index.d.ts",
+      "default": "./index.js"
     },
     "./package.json": "./package.json"
   },
-  "main": "index.js",
+  "module": "index.js",
   "types": "types/index.d.ts",
+  "files": [
+    "index.js",
+    "configs",
+    "types",
+    "utils"
+  ],
   "scripts": {
     "prebuild": "rm -rf types",
     "build": "tsc",
@@ -25,20 +31,20 @@
     "validate": "npm run check-config"
   },
   "dependencies": {
-    "@eslint-react/eslint-plugin": "^1.52.3",
+    "@eslint-react/eslint-plugin": "^2.2.2",
     "@eslint/js": "^9.31.0",
-    "@mrpalmer/eslint-plugin": "^1.0.1",
+    "@mrpalmer/eslint-plugin": "^1.0.3",
     "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-import-x": "^4.16.1",
     "eslint-plugin-jest": "^29.0.1",
     "eslint-plugin-jest-dom": "^5.5.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
-    "eslint-plugin-react-hooks": "^5.2.0",
-    "eslint-plugin-testing-library": "^7.5.4",
-    "globals": "^16.3.0",
+    "eslint-plugin-react-hooks": "^7.0.0",
+    "eslint-plugin-testing-library": "^7.13.3",
+    "globals": "^16.4.0",
     "read-package-up": "^11.0.0",
-    "semver": "^7.7.2",
-    "typescript-eslint": "^8.36.0"
+    "semver": "^7.7.3",
+    "typescript-eslint": "^8.46.1"
   },
   "peerDependencies": {
     "@testing-library/dom": "*",
@@ -63,7 +69,7 @@
   },
   "engines": {
     "node": ">=20",
-    "npm": ">=8",
+    "npm": ">=10",
     "yarn": ">=1"
   }
 }

package/types/configs/base.d.ts

@@ -1,2 +1,2 @@
-declare const _default: import("@typescript-eslint/utils/ts-eslint").FlatConfig.ConfigArray;
+declare const _default: import("@eslint/core", { with: { "resolution-mode": "require" } }).ConfigObject<import("@eslint/core", { with: { "resolution-mode": "require" } }).RulesConfig>[];
 export default _default;

package/types/configs/jest.d.ts

@@ -1,2 +1,2 @@
-declare const _default: import("@typescript-eslint/utils/ts-eslint").FlatConfig.ConfigArray;
+declare const _default: import("@eslint/core", { with: { "resolution-mode": "require" } }).ConfigObject<import("@eslint/core", { with: { "resolution-mode": "require" } }).RulesConfig>[];
 export default _default;

package/types/configs/react.d.ts

@@ -1,2 +1,2 @@
-declare const _default: import("@typescript-eslint/utils/ts-eslint").FlatConfig.ConfigArray;
+declare const _default: import("@eslint/core", { with: { "resolution-mode": "require" } }).ConfigObject<import("@eslint/core", { with: { "resolution-mode": "require" } }).RulesConfig>[];
 export default _default;

package/types/configs/typescript.d.ts

@@ -1,2 +1,2 @@
-declare const _default: import("@typescript-eslint/utils/ts-eslint").FlatConfig.ConfigArray;
+declare const _default: import("@eslint/core", { with: { "resolution-mode": "require" } }).ConfigObject<import("@eslint/core", { with: { "resolution-mode": "require" } }).RulesConfig>[];
 export default _default;

package/types/index.d.ts

@@ -1,12 +1,10 @@
 declare namespace _default {
-    export { config };
     export { configs };
     export { globals };
 }
 export default _default;
-import { config } from 'typescript-eslint';
 export namespace configs {
-    export let all: import("@typescript-eslint/utils/ts-eslint").FlatConfig.Config[];
+    export let all: import("@eslint/core", { with: { "resolution-mode": "require" } }).ConfigObject<import("@eslint/core", { with: { "resolution-mode": "require" } }).RulesConfig>[];
     export { base };
     export { jest };
     export { react };
@@ -17,4 +15,4 @@ import base from './configs/base.js';
 import jest from './configs/jest.js';
 import react from './configs/react.js';
 import typescript from './configs/typescript.js';
-export { config, globals };
+export { globals };

package/.turbo/turbo-build.log

@@ -1,8 +0,0 @@
-
-> @mrpalmer/eslint-config@2.2.0 prebuild
-> rm -rf types
-
-
-> @mrpalmer/eslint-config@2.2.0 build
-> tsc
-

package/CHANGELOG.md

@@ -1,27 +0,0 @@
-# @mrpalmer/eslint-config
-
-## 2.2.0
-
-### Minor Changes
-
-- afbdd32: Replace `eslint-plugin-react` with `@eslint-react/eslint-plugin`
-
-### Patch Changes
-
-- 1e43272: Update ESLint plugins
-- 32711bf: Fix order of configs in "all"
-- df14ce7: Export TypeScript types
-- Updated dependencies [96a657e]
-  - @mrpalmer/eslint-plugin@1.0.1
-
-## 2.1.0
-
-### Minor Changes
-
-- 63cec80: - Replace `eslint-plugin-import` with `eslint-plugin-import-x`
-  - Add `@mrpalmer/eslint-plugin` to default config
-
-### Patch Changes
-
-- Updated dependencies [1e5fa18]
-  - @mrpalmer/eslint-plugin@1.0.0

package/tsconfig.json

@@ -1,10 +0,0 @@
-{
-  "extends": "../../tsconfig.json",
-  "compilerOptions": {
-    "allowJs": true,
-    "declaration": true,
-    "declarationDir": "./types",
-    "emitDeclarationOnly": true
-  },
-  "include": ["index.js"]
-}

package/turbo.json

@@ -1,8 +0,0 @@
-{
-  "extends": ["//"],
-  "tasks": {
-    "build": {
-      "outputs": ["types/**"]
-    }
-  }
-}