@mrpalmer/eslint-config 1.0.0 → 1.0.1

package/import.js

@@ -11,6 +11,7 @@ module.exports = {
     'import/ignore': ['node_modules', '.json$', '.(scss|less|css|styl)$'],
   },
   rules: {
+    'import/consistent-type-specifier-style': ['error', 'prefer-top-level'],
     'import/default': 'error',
     'import/dynamic-import-chunkname': 'off',
     'import/export': 'error',
@@ -31,6 +32,7 @@ module.exports = {
     'import/no-deprecated': 'warn',
     'import/no-duplicates': 'error',
     'import/no-dynamic-require': 'off',
+    'import/no-empty-named-blocks': 'warn',
     'import/no-extraneous-dependencies': 'error',
     'import/no-import-module-exports': 'error',
     'import/no-internal-modules': 'off',

package/index.js

@@ -4,8 +4,8 @@ const path = require('path')
 const tsConfig = fs.existsSync('tsconfig.json')
   ? path.resolve('tsconfig.json')
   : fs.existsSync('types/tsconfig.json')
-  ? path.resolve('types/tsconfig.json')
-  : undefined
+    ? path.resolve('types/tsconfig.json')
+    : undefined
 
 module.exports = {
   env: {
@@ -13,7 +13,7 @@ module.exports = {
     es6: true,
     node: true,
   },
-  extends: ['prettier', './import.js'],
+  extends: ['eslint:recommended', 'prettier', './import.js'],
   rules: {
     'accessor-pairs': 'error',
     'array-callback-return': 'error',
@@ -25,14 +25,12 @@ module.exports = {
     complexity: ['error', 20],
     'consistent-return': 'error',
     'consistent-this': 'off',
-    'constructor-super': 'error',
     curly: ['error', 'multi-line'],
     'default-case': 'error',
     'default-case-last': 'error',
     'default-param-last': 'off',
     'dot-notation': 'error',
     eqeqeq: ['error', 'smart'],
-    'for-direction': 'error',
     'func-name-matching': 'error',
     'func-names': 'error',
     'func-style': 'off',
@@ -48,7 +46,11 @@ module.exports = {
     ],
     'init-declarations': 'off',
     'line-comment-position': 'off',
-    'lines-between-class-members': 'off',
+    'logical-assignment-operators': [
+      'warn',
+      'always',
+      { enforceForIfStatements: true },
+    ],
     'max-classes-per-file': 'off',
     'max-depth': ['error', 4],
     'max-lines': [
@@ -57,121 +59,75 @@ module.exports = {
     ],
     'max-lines-per-function': 'off',
     'max-nested-callbacks': ['error', 7],
-    'max-params': ['error', 7],
+    'max-params': ['error', { max: 7 }],
     'max-statements': 'off',
-    'max-statements-per-line': ['error', { max: 1 }],
     'multiline-comment-style': 'off',
     'new-cap': 'error',
     'no-alert': 'error',
     'no-array-constructor': 'error',
-    'no-async-promise-executor': 'off',
     'no-await-in-loop': 'error',
     'no-bitwise': 'error',
     'no-caller': 'error',
-    'no-case-declarations': 'error',
-    'no-class-assign': 'error',
-    'no-compare-neg-zero': 'error',
-    'no-cond-assign': 'error',
     'no-console': 'off',
-    'no-const-assign': 'error',
-    'no-constant-condition': 'error',
+    'no-constant-binary-expression': 'error',
     'no-constructor-return': 'error',
     'no-continue': 'off',
-    'no-control-regex': 'error',
-    'no-debugger': 'error',
-    'no-delete-var': 'error',
     'no-div-regex': 'error',
-    'no-dupe-args': 'error',
-    'no-dupe-class-members': 'error',
-    'no-dupe-else-if': 'error',
-    'no-dupe-keys': 'error',
-    'no-duplicate-case': 'error',
-    'no-duplicate-imports': 'error',
+    'no-duplicate-imports': 'off',
     'no-else-return': 'off',
-    'no-empty': 'error',
-    'no-empty-character-class': 'error',
     'no-empty-function': 'off',
-    'no-empty-pattern': 'error',
+    'no-empty-static-block': 'warn',
     'no-eq-null': 'off',
     'no-eval': 'error',
-    'no-ex-assign': 'error',
     'no-extend-native': 'error',
     'no-extra-bind': 'error',
-    'no-extra-boolean-cast': 'off',
     'no-extra-label': 'error',
-    'no-fallthrough': 'error',
-    'no-func-assign': 'error',
-    'no-global-assign': 'error',
     'no-implicit-coercion': 'off',
     'no-implicit-globals': 'error',
     'no-implied-eval': 'error',
-    'no-import-assign': 'error',
     'no-inline-comments': 'off',
-    'no-inner-declarations': 'error',
-    'no-invalid-regexp': 'error',
     'no-invalid-this': 'error',
-    'no-irregular-whitespace': 'error',
     'no-iterator': 'error',
     'no-label-var': 'error',
     'no-labels': 'error',
     'no-lone-blocks': 'error',
     'no-lonely-if': 'error',
     'no-loop-func': 'error',
-    'no-loss-of-precision': 'error',
     'no-magic-numbers': 'off',
-    'no-misleading-character-class': 'off',
     'no-multi-assign': 'error',
     'no-multi-str': 'error',
     'no-negated-condition': 'error',
     'no-nested-ternary': 'off',
     'no-new': 'error',
     'no-new-func': 'error',
-    'no-new-object': 'error',
-    'no-new-symbol': 'error',
+    'no-new-native-nonconstructor': 'error',
     'no-new-wrappers': 'error',
-    'no-nonoctal-decimal-escape': 'error',
-    'no-obj-calls': 'error',
-    'no-octal': 'error',
+    'no-object-constructor': 'error',
     'no-octal-escape': 'error',
     'no-param-reassign': 'off',
     'no-plusplus': 'off',
     'no-promise-executor-return': 'off',
     'no-proto': 'error',
-    'no-prototype-builtins': 'off',
-    'no-redeclare': 'error',
-    'no-regex-spaces': 'error',
     'no-restricted-exports': 'off',
     'no-restricted-globals': ['error', 'event', 'fdescribe'],
     'no-restricted-imports': 'off',
     'no-restricted-properties': 'off',
     'no-restricted-syntax': ['error', 'WithStatement'],
     'no-return-assign': 'error',
-    'no-return-await': 'error',
     'no-script-url': 'error',
-    'no-self-assign': 'error',
     'no-self-compare': 'error',
     'no-sequences': 'error',
-    'no-setter-return': 'error',
     'no-shadow': 'off',
-    'no-shadow-restricted-names': 'error',
-    'no-sparse-arrays': 'error',
     'no-template-curly-in-string': 'error',
     'no-ternary': 'off',
-    'no-this-before-super': 'error',
     'no-throw-literal': 'error',
-    'no-undef': 'error',
     'no-undef-init': 'error',
     'no-undefined': 'off',
     'no-underscore-dangle': 'off',
     'no-unmodified-loop-condition': 'error',
     'no-unneeded-ternary': 'error',
-    'no-unreachable': 'error',
     'no-unreachable-loop': 'error',
-    'no-unsafe-finally': 'error',
-    'no-unsafe-negation': 'error',
-    'no-unsafe-optional-chaining': 'error',
     'no-unused-expressions': 'off',
-    'no-unused-labels': 'error',
     'no-unused-private-class-members': 'error',
     'no-unused-vars': [
       'error',
@@ -183,13 +139,10 @@ module.exports = {
       },
     ],
     'no-use-before-define': ['error', 'nofunc'],
-    'no-useless-backreference': 'error',
     'no-useless-call': 'error',
-    'no-useless-catch': 'error',
     'no-useless-computed-key': 'error',
     'no-useless-concat': 'error',
     'no-useless-constructor': 'error',
-    'no-useless-escape': 'error',
     'no-useless-rename': 'error',
     'no-useless-return': 'error',
     'no-var': 'error',
@@ -198,11 +151,9 @@ module.exports = {
       'error',
       { location: 'anywhere', terms: ['fixme'] },
     ],
-    'no-with': 'off',
     'object-shorthand': ['error', 'properties'],
     'one-var': ['error', { initialized: 'never', uninitialized: 'always' }],
     'operator-assignment': 'off',
-    'padding-line-between-statements': 'off',
     'prefer-arrow-callback': [
       'error',
       { allowNamedFunctions: true, allowUnboundThis: true },
@@ -223,15 +174,12 @@ module.exports = {
     'require-atomic-updates': 'off',
     'require-await': 'off',
     'require-unicode-regexp': 'off',
-    'require-yield': 'error',
     'sort-imports': 'off',
     'sort-keys': 'off',
     'sort-vars': 'off',
-    'spaced-comment': 'off',
     strict: 'error',
     'symbol-description': 'error',
-    'use-isnan': 'error',
-    'valid-typeof': 'error',
+    'unicode-bom': ['error', 'never'],
     'vars-on-top': 'error',
     yoda: 'error',
   },
@@ -245,6 +193,10 @@ module.exports = {
         sourceType: 'module',
       },
       plugins: ['@typescript-eslint'],
+      extends: [
+        'plugin:@typescript-eslint/strict-type-checked',
+        'plugin:@typescript-eslint/stylistic-type-checked',
+      ],
       rules: {
         'constructor-super': 'off', // ts(2335) & ts(2377)
         'getter-return': 'off', // ts(2378)
@@ -262,66 +214,44 @@ module.exports = {
         'no-unsafe-negation': 'off', // ts(2365) & ts(2360) & ts(2358)
         'valid-typeof': 'off', // ts(2367)
 
-        'consistent-return': 'off', // in TS this is much less an issue
         'no-var': 'error', // TS transpiles let/const to var, so no need for vars anymore
         'prefer-const': 'error', // TS provides better types with const
         'prefer-rest-params': 'error', // TS provides better types with rest args over arguments
         'prefer-spread': 'error', // TS transpiles spread to apply, so no need for manual apply
 
+        'consistent-return': 'off',
+        '@typescript-eslint/consistent-return': 'error',
+
         'default-param-last': 'off',
         '@typescript-eslint/default-param-last': 'off',
 
-        'dot-notation': 'off',
-        '@typescript-eslint/dot-notation': 'error',
-
         'init-declarations': 'off',
         '@typescript-eslint/init-declarations': 'off',
 
-        'lines-between-class-members': 'off',
-        '@typescript-eslint/lines-between-class-members': 'off',
-
-        'no-array-constructor': 'off',
-        '@typescript-eslint/no-array-constructor': 'error',
+        'max-params': 'off',
+        '@typescript-eslint/max-params': ['error', { max: 7 }],
 
         'no-dupe-class-members': 'off',
         '@typescript-eslint/no-dupe-class-members': 'off', // ts(2393) & ts(2300)
 
-        'no-duplicate-imports': 'off',
-        '@typescript-eslint/no-duplicate-imports': 'error',
-
         'no-empty-function': 'off',
         '@typescript-eslint/no-empty-function': 'off',
 
-        'no-implied-eval': 'error',
-        '@typescript-eslint/no-implied-eval': 'error',
-
         'no-invalid-this': 'off',
         '@typescript-eslint/no-invalid-this': 'error',
 
         'no-loop-func': 'off',
         '@typescript-eslint/no-loop-func': 'error',
 
-        'no-loss-of-precision': 'off',
-        '@typescript-eslint/no-loss-of-precision': 'error',
-
         'no-magic-numbers': 'off',
         '@typescript-eslint/no-magic-numbers': 'off',
 
         'no-redeclare': 'off',
         '@typescript-eslint/no-redeclare': 'off', // ts(2451)
 
-        'no-return-await': 'off',
-        '@typescript-eslint/return-await': 'error',
-
         'no-shadow': 'off',
         '@typescript-eslint/no-shadow': 'off',
 
-        'no-throw-literal': 'off',
-        '@typescript-eslint/no-throw-literal': 'error',
-
-        'no-use-before-define': 'off',
-        '@typescript-eslint/no-use-before-define': ['error', 'nofunc'],
-
         'no-unused-expressions': 'off',
         '@typescript-eslint/no-unused-expressions': 'off',
 
@@ -336,90 +266,74 @@ module.exports = {
           },
         ],
 
-        'no-useless-constructor': 'off',
-        '@typescript-eslint/no-useless-constructor': 'error',
+        'no-use-before-define': 'off',
+        '@typescript-eslint/no-use-before-define': ['error', 'nofunc'],
 
-        '@typescript-eslint/adjacent-overload-signatures': 'error',
-        '@typescript-eslint/array-type': 'off',
-        '@typescript-eslint/await-thenable': 'error',
-        '@typescript-eslint/ban-ts-comment': 'error',
-        '@typescript-eslint/ban-tslint-comment': 'error',
-        '@typescript-eslint/ban-types': 'off',
-        '@typescript-eslint/class-literal-property-style': 'off',
-        '@typescript-eslint/consistent-indexed-object-style': 'off',
-        '@typescript-eslint/consistent-type-assertions': 'off',
+        '@typescript-eslint/array-type': ['error', { default: 'array-simple' }],
+        '@typescript-eslint/class-methods-use-this': 'off',
         '@typescript-eslint/consistent-type-definitions': 'off',
-        '@typescript-eslint/consistent-type-imports': 'off',
+        '@typescript-eslint/consistent-type-exports': [
+          'error',
+          { fixMixedExportsWithInlineTypeSpecifier: true },
+        ],
+        'import/consistent-type-specifier-style': 'off',
+        '@typescript-eslint/consistent-type-imports': [
+          'error',
+          { fixStyle: 'inline-type-imports' },
+        ],
         '@typescript-eslint/explicit-function-return-type': 'off',
+        '@typescript-eslint/explicit-member-accessibility': 'off',
         '@typescript-eslint/explicit-module-boundary-types': 'off',
-        '@typescript-eslint/member-delimiter-style': 'off',
         '@typescript-eslint/member-ordering': 'off',
         '@typescript-eslint/method-signature-style': 'off',
         '@typescript-eslint/naming-convention': 'off',
         '@typescript-eslint/no-base-to-string': 'warn',
-        '@typescript-eslint/no-confusing-non-null-assertion': 'off',
-        '@typescript-eslint/no-confusing-void-expression': 'off',
-        '@typescript-eslint/no-dynamic-delete': 'error',
-        '@typescript-eslint/no-empty-interface': 'error',
-        '@typescript-eslint/no-explicit-any': 'error',
-        '@typescript-eslint/no-extra-non-null-assertion': 'error',
-        '@typescript-eslint/no-extraneous-class': 'error',
+        '@typescript-eslint/no-confusing-void-expression': [
+          'warn',
+          { ignoreArrowShorthand: true, ignoreVoidOperator: true },
+        ],
+        '@typescript-eslint/no-empty-object-type': 'error',
         '@typescript-eslint/no-floating-promises': 'warn',
-        '@typescript-eslint/no-for-in-array': 'error',
-        '@typescript-eslint/no-implicit-any-catch': 'warn',
+        '@typescript-eslint/no-import-type-side-effects': 'error',
         '@typescript-eslint/no-inferrable-types': 'off',
         '@typescript-eslint/no-invalid-void-type': 'warn',
-        '@typescript-eslint/no-misused-new': 'error',
         '@typescript-eslint/no-misused-promises': [
           'warn',
           { checksVoidReturn: false },
         ],
-        '@typescript-eslint/no-namespace': 'error',
-        '@typescript-eslint/no-non-null-asserted-optional-chain': 'error',
-        '@typescript-eslint/no-non-null-assertion': 'error',
-        '@typescript-eslint/no-parameter-properties': 'off',
         '@typescript-eslint/no-require-imports': 'off',
-        '@typescript-eslint/no-this-alias': 'error',
-        '@typescript-eslint/no-type-alias': 'off',
+        '@typescript-eslint/no-restricted-imports': 'off',
+        '@typescript-eslint/no-restricted-types': 'off',
         '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'warn',
-        '@typescript-eslint/no-unnecessary-condition': 'error',
+        '@typescript-eslint/no-unnecessary-parameter-property-assignment':
+          'warn',
         '@typescript-eslint/no-unnecessary-qualifier': 'warn',
-        '@typescript-eslint/no-unnecessary-type-arguments': 'off',
-        '@typescript-eslint/no-unnecessary-type-assertion': 'error',
-        '@typescript-eslint/no-unnecessary-type-constraint': 'error',
-        '@typescript-eslint/no-unsafe-argument': 'error',
+        '@typescript-eslint/no-unnecessary-type-arguments': 'warn',
         '@typescript-eslint/no-unsafe-assignment': 'warn',
         '@typescript-eslint/no-unsafe-call': 'warn',
         '@typescript-eslint/no-unsafe-member-access': 'warn',
-        '@typescript-eslint/no-unsafe-return': 'off',
-        '@typescript-eslint/no-var-requires': 'error',
-        '@typescript-eslint/non-nullable-type-assertion-style': 'off',
-        '@typescript-eslint/prefer-as-const': 'error',
+        '@typescript-eslint/no-unsafe-return': 'warn',
+        '@typescript-eslint/no-unsafe-unary-minus': 'error',
+        '@typescript-eslint/no-useless-empty-export': 'error',
+        '@typescript-eslint/parameter-properties': [
+          'error',
+          { prefer: 'parameter-property' },
+        ],
+        '@typescript-eslint/prefer-destructuring': 'off',
         '@typescript-eslint/prefer-enum-initializers': 'error',
-        '@typescript-eslint/prefer-for-of': 'off',
-        '@typescript-eslint/prefer-function-type': 'off',
-        '@typescript-eslint/prefer-includes': 'error',
-        '@typescript-eslint/prefer-literal-enum-member': 'error',
-        '@typescript-eslint/prefer-namespace-keyword': 'error',
-        '@typescript-eslint/prefer-nullish-coalescing': 'error',
-        '@typescript-eslint/prefer-optional-chain': 'error',
+        '@typescript-eslint/prefer-find': 'warn',
+        '@typescript-eslint/prefer-for-of': 'warn',
+        '@typescript-eslint/prefer-function-type': 'warn',
         '@typescript-eslint/prefer-readonly': 'off',
         '@typescript-eslint/prefer-readonly-parameter-types': 'off',
         '@typescript-eslint/prefer-reduce-type-parameter': 'warn',
         '@typescript-eslint/prefer-regexp-exec': 'off',
-        '@typescript-eslint/prefer-string-starts-ends-with': 'error',
-        '@typescript-eslint/prefer-ts-expect-error': 'error',
         '@typescript-eslint/promise-function-async': 'off',
         '@typescript-eslint/require-array-sort-compare': 'off',
-        '@typescript-eslint/require-await': 'off',
-        '@typescript-eslint/restrict-plus-operands': 'error',
-        '@typescript-eslint/restrict-template-expressions': 'off',
-        '@typescript-eslint/sort-type-union-intersection-members': 'off',
+        '@typescript-eslint/return-await': 'off',
         '@typescript-eslint/strict-boolean-expressions': 'off',
         '@typescript-eslint/switch-exhaustiveness-check': 'error',
-        '@typescript-eslint/triple-slash-reference': 'error',
         '@typescript-eslint/typedef': 'off',
-        '@typescript-eslint/unbound-method': 'error',
         '@typescript-eslint/unified-signatures': 'warn',
       },
     },

package/jest.js

@@ -1,7 +1,8 @@
 const readPkgUp = require('read-pkg-up')
 
 let hasJestDom = false
-let hasTestingLibrary = false
+let hasTestingLibraryDom = false
+let hasTestingLibraryReact = false
 
 try {
   const { packageJson } = readPkgUp.sync({ normalize: true })
@@ -12,107 +13,13 @@ try {
   })
 
   hasJestDom = allDeps.includes('@testing-library/jest-dom')
-  hasTestingLibrary = ['@testing-library/dom', '@testing-library/react'].some(
-    (dependency) => allDeps.includes(dependency)
-  )
+  hasTestingLibraryDom = allDeps.includes('@testing-library/dom')
+  hasTestingLibraryReact = allDeps.includes('@testing-library/react')
 } catch (error) {
   // ignore error
 }
 
-const rules = {
-  'react/display-name': 'off', // we don't need a display name in test files
-
-  'jest/consistent-test-it': 'off',
-  'jest/expect-expect': 'off',
-  'jest/max-nested-describe': 'error',
-  'jest/no-alias-methods': 'off',
-  'jest/no-commented-out-tests': 'warn',
-  'jest/no-conditional-expect': 'error',
-  'jest/no-deprecated-functions': 'error',
-  'jest/no-disabled-tests': 'warn',
-  'jest/no-done-callback': 'error',
-  'jest/no-duplicate-hooks': 'off',
-  'jest/no-export': 'error',
-  'jest/no-focused-tests': 'error',
-  'jest/no-hooks': 'off',
-  'jest/no-identical-title': 'error',
-  'jest/no-if': 'error',
-  'jest/no-interpolation-in-snapshots': 'error',
-  'jest/no-jasmine-globals': 'off',
-  'jest/no-jest-import': 'error',
-  'jest/no-large-snapshots': ['warn', { maxSize: 300 }],
-  'jest/no-mocks-import': 'error',
-  'jest/no-restricted-matchers': 'off',
-  'jest/no-standalone-expect': 'off',
-  'jest/no-test-prefixes': 'error',
-  'jest/no-test-return-statement': 'off',
-  'jest/prefer-called-with': 'error',
-  'jest/prefer-expect-assertions': 'off',
-  'jest/prefer-expect-resolves': 'off',
-  'jest/prefer-hooks-on-top': 'error',
-  'jest/prefer-lowercase-title': 'off',
-  'jest/prefer-spy-on': 'off',
-  'jest/prefer-strict-equal': 'off',
-  'jest/prefer-to-be': 'off',
-  'jest/prefer-to-contain': 'warn',
-  'jest/prefer-to-have-length': 'warn',
-  'jest/prefer-todo': 'warn',
-  'jest/require-hook': 'off',
-  'jest/require-to-throw-message': 'off',
-  'jest/require-top-level-describe': 'off',
-  'jest/unbound-method': 'off',
-  'jest/valid-describe-callback': 'error',
-  'jest/valid-expect': 'error',
-  'jest/valid-expect-in-promise': 'error',
-  'jest/valid-title': 'warn',
-
-  ...(hasJestDom
-    ? {
-        'jest-dom/prefer-checked': 'error',
-        'jest-dom/prefer-empty': 'error',
-        'jest-dom/prefer-enabled-disabled': 'error',
-        'jest-dom/prefer-focus': 'error',
-        'jest-dom/prefer-in-document': 'error',
-        'jest-dom/prefer-required': 'error',
-        'jest-dom/prefer-to-have-attribute': 'error',
-        'jest-dom/prefer-to-have-class': 'error',
-        'jest-dom/prefer-to-have-style': 'error',
-        'jest-dom/prefer-to-have-text-content': 'error',
-        'jest-dom/prefer-to-have-value': 'error',
-      }
-    : null),
-
-  ...(hasTestingLibrary
-    ? {
-        'testing-library/await-async-query': 'error',
-        'testing-library/await-async-utils': 'error',
-        'testing-library/await-fire-event': 'off',
-        'testing-library/consistent-data-testid': 'off',
-        'testing-library/no-await-sync-events': 'error',
-        'testing-library/no-await-sync-query': 'error',
-        'testing-library/no-container': 'error',
-        'testing-library/no-debugging-utils': 'error',
-        'testing-library/no-dom-import': ['error', 'react'],
-        'testing-library/no-manual-cleanup': 'error',
-        'testing-library/no-node-access': 'error',
-        'testing-library/no-promise-in-fire-event': 'error',
-        'testing-library/no-render-in-setup': 'error',
-        'testing-library/no-unnecessary-act': 'error',
-        'testing-library/no-wait-for-empty-callback': 'error',
-        'testing-library/no-wait-for-multiple-assertions': 'error',
-        'testing-library/no-wait-for-side-effects': 'error',
-        'testing-library/no-wait-for-snapshot': 'error',
-        'testing-library/prefer-explicit-assert': 'warn',
-        'testing-library/prefer-find-by': 'error',
-        'testing-library/prefer-presence-queries': 'error',
-        'testing-library/prefer-query-by-disappearance': 'error',
-        'testing-library/prefer-screen-queries': 'error',
-        'testing-library/prefer-user-event': 'error',
-        'testing-library/prefer-wait-for': 'error',
-        'testing-library/render-result-naming-convention': 'error',
-      }
-    : null),
-}
+const hasTestingLibrary = hasTestingLibraryDom || hasTestingLibraryReact
 
 module.exports = {
   env: {
@@ -123,14 +30,83 @@ module.exports = {
     hasJestDom && 'jest-dom',
     hasTestingLibrary && 'testing-library',
   ].filter(Boolean),
-  rules: disableAll(rules),
   overrides: [
     {
       files: [
         '**/__tests__/**/*.+(js|ts)?(x)',
         '**/*.{spec,test}.+(js|ts)?(x)',
       ],
-      rules,
+      extends: [
+        'plugin:jest/recommended',
+        'plugin:jest/style',
+        hasJestDom && 'plugin:jest-dom/recommended',
+        hasTestingLibraryReact
+          ? 'plugin:testing-library/react'
+          : hasTestingLibraryDom
+            ? 'plugin:testing-library/dom'
+            : null,
+      ].filter(Boolean),
+      rules: {
+        'react/display-name': 'off', // we don't need a display name in test files
+
+        'jest/consistent-test-it': 'off',
+        'jest/max-expects': 'off',
+        'jest/max-nested-describe': 'error',
+        'jest/no-conditional-in-test': 'error',
+        'jest/no-confusing-set-timeout': 'error',
+        'jest/no-duplicate-hooks': 'off',
+        'jest/no-hooks': 'off',
+        'jest/no-large-snapshots': ['warn', { maxSize: 300 }],
+        'jest/no-restricted-jest-methods': 'off',
+        'jest/no-restricted-matchers': 'off',
+        'jest/no-test-return-statement': 'off',
+        'jest/no-untyped-mock-factory': 'error',
+        'jest/padding-around-after-all-blocks': 'off',
+        'jest/padding-around-after-each-blocks': 'off',
+        'jest/padding-around-all': 'off',
+        'jest/padding-around-before-all-blocks': 'off',
+        'jest/padding-around-before-each-blocks': 'off',
+        'jest/padding-around-describe-blocks': 'off',
+        'jest/padding-around-expect-groups': 'off',
+        'jest/padding-around-test-blocks': 'off',
+        'jest/prefer-called-with': 'error',
+        'jest/prefer-comparison-matcher': 'warn',
+        'jest/prefer-each': 'warn',
+        'jest/prefer-equality-matcher': 'warn',
+        'jest/prefer-expect-assertions': 'off',
+        'jest/prefer-expect-resolves': 'off',
+        'jest/prefer-hooks-in-order': 'error',
+        'jest/prefer-hooks-on-top': 'error',
+        'jest/prefer-importing-jest-globals': 'off',
+        'jest/prefer-jest-mocked': 'warn',
+        'jest/prefer-lowercase-title': 'off',
+        'jest/prefer-mock-promise-shorthand': 'warn',
+        'jest/prefer-snapshot-hint': ['error', 'multi'],
+        'jest/prefer-spy-on': 'off',
+        'jest/prefer-strict-equal': 'off',
+        'jest/prefer-todo': 'warn',
+        'jest/require-hook': 'off',
+        'jest/require-to-throw-message': 'off',
+        'jest/require-top-level-describe': 'off',
+        'jest/unbound-method': 'off',
+
+        ...(hasTestingLibrary
+          ? {
+              'testing-library/consistent-data-testid': 'off',
+              'testing-library/no-container': 'error',
+              'testing-library/no-debugging-utils': 'error',
+              'testing-library/no-dom-import': ['error', 'react'],
+              'testing-library/no-manual-cleanup': 'error',
+              'testing-library/no-render-in-lifecycle': 'error',
+              'testing-library/no-unnecessary-act': 'error',
+              'testing-library/prefer-explicit-assert': 'warn',
+              'testing-library/prefer-implicit-assert': 'off',
+              'testing-library/prefer-query-matchers': 'off',
+              'testing-library/prefer-user-event': 'error',
+              'testing-library/render-result-naming-convention': 'error',
+            }
+          : null),
+      },
     },
     {
       files: ['**/__tests__/**/*.ts?(x)', '**/*.{spec,test}.ts?(x)'],
@@ -141,10 +117,3 @@ module.exports = {
     },
   ],
 }
-
-function disableAll(obj) {
-  return Object.keys(obj).reduce((rules, rule) => {
-    rules[rule] = 'off'
-    return rules
-  }, {})
-}

package/jsx-a11y.js

@@ -8,41 +8,15 @@ module.exports = {
     },
   },
   plugins: ['jsx-a11y'],
+  extends: ['plugin:jsx-a11y/recommended'],
   rules: {
-    'jsx-a11y/accessible-emoji': 'error',
     'jsx-a11y/alt-text': 'warn',
-    'jsx-a11y/anchor-has-content': 'error',
-    'jsx-a11y/anchor-is-valid': 'error',
-    'jsx-a11y/aria-activedescendant-has-tabindex': 'error',
-    'jsx-a11y/aria-props': 'error',
-    'jsx-a11y/aria-proptypes': 'error',
-    'jsx-a11y/aria-role': 'error',
-    'jsx-a11y/aria-unsupported-elements': 'error',
-    'jsx-a11y/autocomplete-valid': 'error',
-    'jsx-a11y/click-events-have-key-events': 'error',
-    'jsx-a11y/control-has-associated-label': 'off',
-    'jsx-a11y/heading-has-content': 'error',
-    'jsx-a11y/html-has-lang': 'error',
-    'jsx-a11y/iframe-has-title': 'error',
-    'jsx-a11y/img-redundant-alt': 'error',
-    'jsx-a11y/interactive-supports-focus': 'warn',
-    'jsx-a11y/label-has-associated-control': 'error',
     'jsx-a11y/lang': 'error',
-    'jsx-a11y/media-has-caption': 'warn',
-    'jsx-a11y/mouse-events-have-key-events': 'error',
-    'jsx-a11y/no-access-key': 'error',
+    'jsx-a11y/no-aria-hidden-on-focusable': 'off',
     'jsx-a11y/no-autofocus': 'off',
-    'jsx-a11y/no-distracting-elements': 'error',
-    'jsx-a11y/no-interactive-element-to-noninteractive-role': 'warn',
-    'jsx-a11y/no-noninteractive-element-interactions': 'warn',
-    'jsx-a11y/no-noninteractive-element-to-interactive-role': 'warn',
     'jsx-a11y/no-noninteractive-tabindex': 'off',
-    'jsx-a11y/no-onchange': 'off',
-    'jsx-a11y/no-redundant-roles': 'error',
     'jsx-a11y/no-static-element-interactions': 'off',
-    'jsx-a11y/role-has-required-aria-props': 'error',
-    'jsx-a11y/role-supports-aria-props': 'error',
-    'jsx-a11y/scope': 'error',
+    'jsx-a11y/prefer-tag-over-role': 'off',
     'jsx-a11y/tabindex-no-positive': 'warn',
   },
 }

package/package.json

@@ -1,37 +1,51 @@
 {
   "name": "@mrpalmer/eslint-config",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Mike Palmer's personal ESLint rules",
   "license": "MIT",
   "main": "index.js",
   "scripts": {
-    "find-new-rules": "run-p find-new-rules:*",
-    "find-new-rules:jest": "eslint-find-rules --unused ./test/jest.js",
-    "find-new-rules:jsx-a11y": "eslint-find-rules --unused ./test/jsx-a11y.js",
-    "find-new-rules:main": "eslint-find-rules --unused ./index.js",
-    "find-new-rules:react": "eslint-find-rules --unused ./test/react.js",
+    "check-config": "run-p check-config:*",
+    "check-config:jest": "validate-config -f component.test.js ./test/jest.js",
+    "check-config:jest-ts": "validate-config -f component.test.ts ./test/jest.js",
+    "check-config:js": "validate-config -f index.js ./index.js",
+    "check-config:jsx-a11y": "validate-config -f component.jsx ./test/jsx-a11y.js",
+    "check-config:react": "validate-config -f component.jsx ./test/react.js",
+    "check-config:ts": "validate-config -f index.ts ./index.js",
     "lint": "eslint --config index.js .",
-    "validate": "run-p lint find-new-rules"
+    "validate": "run-p lint check-config"
   },
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^5.9.0",
-    "@typescript-eslint/parser": "^5.9.0",
-    "eslint-config-prettier": "^8.3.0",
-    "eslint-plugin-import": "^2.25.4",
-    "eslint-plugin-jest": "^25.3.4",
-    "eslint-plugin-jest-dom": "^4.0.1",
-    "eslint-plugin-jsx-a11y": "^6.5.1",
-    "eslint-plugin-react": "^7.28.0",
-    "eslint-plugin-react-hooks": "^4.3.0",
-    "eslint-plugin-testing-library": "^5.0.1",
+    "@typescript-eslint/eslint-plugin": "^8.1.0",
+    "@typescript-eslint/parser": "^8.1.0",
+    "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-import": "^2.29.1",
+    "eslint-plugin-jest": "^28.8.0",
+    "eslint-plugin-jest-dom": "^5.4.0",
+    "eslint-plugin-jsx-a11y": "^6.9.0",
+    "eslint-plugin-react": "^7.35.0",
+    "eslint-plugin-react-hooks": "^4.6.2",
+    "eslint-plugin-testing-library": "^6.3.0",
     "read-pkg-up": "^7.0.1",
     "semver": "^7.3.2"
   },
   "peerDependencies": {
+    "@testing-library/dom": "*",
+    "@testing-library/jest-dom": "*",
+    "@testing-library/react": "*",
     "eslint": "^8.0.0",
-    "typescript": "^4.0.0"
+    "typescript": "^4.0.0 || ^5.0.0"
   },
   "peerDependenciesMeta": {
+    "@testing-library/dom": {
+      "optional": true
+    },
+    "@testing-library/jest-dom": {
+      "optional": true
+    },
+    "@testing-library/react": {
+      "optional": true
+    },
     "typescript": {
       "optional": true
     }

package/react.js

@@ -43,6 +43,7 @@ module.exports = {
   rules: {
     'react/boolean-prop-naming': 'off',
     'react/button-has-type': 'off',
+    'react/checked-requires-onchange-or-readonly': 'error',
     'react/default-props-match-prop-types': hasPropTypes ? 'error' : 'off',
     'react/destructuring-assignment': 'off',
     'react/display-name': ['error', { ignoreTranspilerName: false }],
@@ -52,6 +53,8 @@ module.exports = {
     'react/forbid-foreign-prop-types': hasPropTypes ? 'error' : 'off',
     'react/forbid-prop-types': 'off',
     'react/function-component-definition': 'off',
+    'react/hook-use-state': 'off',
+    'react/iframe-missing-sandbox': 'warn',
     'react/jsx-boolean-value': 'off',
     'react/jsx-curly-brace-presence': [
       'warn',
@@ -66,14 +69,15 @@ module.exports = {
     'react/jsx-no-comment-textnodes': 'error',
     'react/jsx-no-constructed-context-values': 'off',
     'react/jsx-no-duplicate-props': 'error',
+    'react/jsx-no-leaked-render': 'off',
     'react/jsx-no-literals': 'off',
     'react/jsx-no-script-url': 'error',
     'react/jsx-no-target-blank': 'error',
     'react/jsx-no-undef': 'error',
     'react/jsx-no-useless-fragment': 'warn',
     'react/jsx-pascal-case': 'error',
+    'react/jsx-props-no-spread-multi': 'warn',
     'react/jsx-props-no-spreading': 'off',
-    'react/jsx-sort-default-props': 'off',
     'react/jsx-sort-props': 'off',
     'react/jsx-uses-react': 'error',
     'react/jsx-uses-vars': 'error',
@@ -93,6 +97,7 @@ module.exports = {
     'react/no-is-mounted': 'error',
     'react/no-multi-comp': 'off',
     'react/no-namespace': 'error',
+    'react/no-object-type-as-default-prop': 'warn',
     'react/no-redundant-should-component-update': 'error',
     'react/no-render-return-value': 'error',
     'react/no-set-state': 'off',
@@ -118,6 +123,7 @@ module.exports = {
     'react/require-render-return': 'error',
     'react/self-closing-comp': 'error',
     'react/sort-comp': 'off',
+    'react/sort-default-props': 'off',
     'react/sort-prop-types': 'off',
     'react/state-in-constructor': 'off',
     'react/static-property-placement': 'off',