@mrkaran/hodor 0.7.0 → 0.7.1

package/dist/{chunk-Q5AQKNSE.js → chunk-VERO4XYJ.js}

@@ -42,7 +42,8 @@ function buildPrReviewPrompt(opts) {
     previousReviewSha,
     reviewDiffMode,
     changedFiles = [],
-    localMode = false
+    localMode = false,
+    singleTurn = false
   } = opts;
   let templateText;
   try {
@@ -92,22 +93,24 @@ function buildPrReviewPrompt(opts) {
     diffExplanation = `**Three-dot syntax** shows ONLY changes introduced on the source branch, excluding changes already on \`${targetBranch}\`.`;
   }
   const { contextSection, notesSection, reminderSection } = buildMrSections(mrMetadata);
+  const oneTurn = singleTurn && Boolean(embeddedDiff);
   let incrementalSection = "";
   if (previousReviewSha) {
     incrementalSection = `## ${reviewDiffMode === "snapshot" ? "Snapshot Delta" : "Incremental Review"} Mode
 
-This is a follow-up review. A previous hodor review was done at commit \`${previousReviewSha.slice(0, 8)}\`. ` + (reviewDiffMode === "snapshot" ? "The branch history was rewritten, so the diff below compares that reviewed snapshot directly with the current HEAD. " : "The diff below shows ONLY changes since that review. ") + "Your job is to review that delta, not the whole MR again.\n\nRules for incremental reviews:\n1. Only report findings introduced or still affected by the new delta.\n2. Do not re-report issues that are already mentioned in existing notes unless the new delta changes the same code and the issue remains newly relevant.\n3. If the delta is small and self-contained, decide from the embedded diff and submit the review without broad repository exploration.\n4. For mechanical changes like route/path/string renames, verify the direct call sites or tests only when the diff itself leaves a concrete compatibility question.\n5. If the delta does not produce a qualifying finding under the selected review instructions, submit no findings.\n\n";
+This is a follow-up review. A previous hodor review was done at commit \`${previousReviewSha.slice(0, 8)}\`. ` + (reviewDiffMode === "snapshot" ? "The branch history was rewritten, so the diff below compares that reviewed snapshot directly with the current HEAD. " : "The diff below shows ONLY changes since that review. ") + "Your job is to review that delta, not the whole MR again.\n\nRules for incremental reviews:\n1. Only report findings introduced or still affected by the new delta.\n2. Do not re-report issues that are already mentioned in existing notes unless the new delta changes the same code and the issue remains newly relevant.\n3. If the delta is small and self-contained, decide from the embedded diff and submit the review without broad repository exploration.\n" + (oneTurn ? "4. No file-inspection tools are available; if a mechanical change like a route/path/string rename leaves a compatibility question you cannot settle from the diff, do not report it.\n" : "4. For mechanical changes like route/path/string renames, verify the direct call sites or tests only when the diff itself leaves a concrete compatibility question.\n") + "5. If the delta does not produce a qualifying finding under the selected review instructions, submit no findings.\n\n";
   }
   let embeddedDiffSection;
   let diffFetchInstructions;
   let reviewProcessSection;
   let startInstruction;
+  let runtimeToolsSection;
   if (embeddedDiff) {
     const changedFileManifest = changedFiles.length > 0 ? `
 Changed files (${changedFiles.length}):
 ${changedFiles.map((file) => `- \`${file}\``).join("\n")}
 ` : "";
-    embeddedDiffSection = "## Full Diff (Pre-fetched)\n\nThe complete diff for this PR is provided below. Analyze it directly. Do not run another command to list changed files. Use `read` or `grep` only if you need additional file context beyond what the diff shows.\n" + changedFileManifest + "\n````diff\n" + embeddedDiff + "\n````\n";
+    embeddedDiffSection = "## Full Diff (Pre-fetched)\n\nThe complete diff for this PR is provided below. Analyze it directly. Do not run another command to list changed files. " + (oneTurn ? "This diff is small and self-contained; it is the complete basis for your review.\n" : "Use `read` or `grep` only if you need additional file context beyond what the diff shows.\n") + changedFileManifest + "\n````diff\n" + embeddedDiff + "\n````\n";
     diffFetchInstructions = `## Review the Diff Above
 
 ### Critical Rules
@@ -118,8 +121,13 @@ ${changedFiles.map((file) => `- \`${file}\``).join("\n")}
 - NEVER flag "dependency version downgrade" (branch not rebased)
 - NEVER compare entire codebase to ${targetBranch} - DIFF ONLY
 `;
-    reviewProcessSection = "## Review Process\n\n1. Analyze the embedded diff above thoroughly\n2. Use `grep` to search for patterns when needed\n3. Use bounded line-range reads when surrounding context is essential; avoid reading entire large files\n4. Do not repeat a diff, grep, or read operation whose result is already in context\n5. Submit your review using `submit_review`\n";
-    startInstruction = previousReviewSha ? "Analyze only the incremental diff provided above. If it is self-contained, submit your review without extra tool calls." : "Analyze the diff provided above, then submit your review using `submit_review`.";
+    if (oneTurn) {
+      reviewProcessSection = "## Review Process\n\n1. Analyze the embedded diff above thoroughly\n2. Call `submit_review` in this same turn with your findings\n\nNo file-inspection tools are available for this review. Base every finding on the diff above. If a potential issue cannot be established from the diff alone, do not report it.\n";
+      startInstruction = "Analyze the diff above and call `submit_review` now, in this turn.";
+    } else {
+      reviewProcessSection = "## Review Process\n\n1. Analyze the embedded diff above thoroughly\n2. Use `grep` to search for patterns when needed\n3. Use bounded line-range reads when surrounding context is essential; avoid reading entire large files\n4. Do not repeat a diff, grep, or read operation whose result is already in context\n5. Submit your review using `submit_review`\n";
+      startInstruction = previousReviewSha ? "Analyze only the incremental diff provided above. If it is self-contained, submit your review without extra tool calls." : "Analyze the diff provided above, then submit your review using `submit_review`.";
+    }
   } else {
     embeddedDiffSection = "";
     diffFetchInstructions = "## Step 1: List Changed Files (MANDATORY FIRST STEP)\n\n**Run this command FIRST to get the list of changed files:**\n```bash\n" + prDiffCmd + "\n```\n\nThis lists ONLY the filenames changed in this PR. **Do NOT dump the entire diff here** - you'll inspect each file individually in Step 2. Only review files that appear in this output.\n\n## Step 2: Review Changed Files Only\n\n### Critical Rules\n- ONLY review files that appear in the diff from Step 1\n- ONLY analyze actual code changes (+ and - lines in the diff)\n- Use the most reliable diff command: `" + gitDiffCmd + `\`
@@ -146,7 +154,15 @@ ${changedFiles.map((file) => `- \`${file}\``).join("\n")}
 `;
     startInstruction = `Start by running \`${prDiffCmd}\` to list the changed files, then analyze each file individually using \`${gitDiffCmd} -- path/to/file\`.`;
   }
-  return templateText.replace(/\{pr_url\}/g, prUrl).replace(/\{pr_diff_cmd\}/g, prDiffCmd).replace(/\{git_diff_cmd\}/g, gitDiffCmd).replace(/\{mr_context_section\}/g, contextSection).replace(/\{mr_notes_section\}/g, notesSection).replace(/\{mr_reminder_section\}/g, reminderSection).replace(/\{incremental_section\}/g, incrementalSection).replace(/\{embedded_diff_section\}/g, embeddedDiffSection).replace(/\{diff_fetch_instructions\}/g, diffFetchInstructions).replace(/\{review_process_section\}/g, reviewProcessSection).replace(/\{start_instruction\}/g, startInstruction);
+  runtimeToolsSection = oneTurn ? "## Runtime Tools\n\n- `submit_review` submits the completed review. It is the only tool available for this review.\n" : `## Runtime Tools
+
+- \`${prDiffCmd}\` lists the changed files when a diff is not embedded.
+- \`${gitDiffCmd} -- path/to/file\` shows the delta for one changed file.
+- \`read\` provides bounded surrounding context.
+- \`grep\` searches for directly relevant code and contracts.
+- \`submit_review\` submits the completed review.
+`;
+  return templateText.replace(/\{pr_url\}/g, prUrl).replace(/\{pr_diff_cmd\}/g, prDiffCmd).replace(/\{git_diff_cmd\}/g, gitDiffCmd).replace(/\{mr_context_section\}/g, contextSection).replace(/\{mr_notes_section\}/g, notesSection).replace(/\{mr_reminder_section\}/g, reminderSection).replace(/\{incremental_section\}/g, incrementalSection).replace(/\{embedded_diff_section\}/g, embeddedDiffSection).replace(/\{diff_fetch_instructions\}/g, diffFetchInstructions).replace(/\{runtime_tools_section\}/g, runtimeToolsSection).replace(/\{review_process_section\}/g, reviewProcessSection).replace(/\{start_instruction\}/g, startInstruction);
 }
 function buildMrSections(mrMetadata) {
   if (!mrMetadata) {
@@ -265,6 +281,17 @@ function parseModelString(model) {
       if (modelId.startsWith("converse/")) {
         modelId = modelId.slice("converse/".length);
       }
+      const separator = modelId.indexOf("@");
+      if (separator !== -1) {
+        const baseModelId = modelId.slice(separator + 1).trim();
+        modelId = modelId.slice(0, separator).trim();
+        if (!modelId || !baseModelId) {
+          throw new Error(
+            `Invalid bedrock model "${trimmed}". Use "bedrock/<arn>@<base-model-id>", for example "bedrock/arn:aws:bedrock:ap-south-1:123:application-inference-profile/abc@global.anthropic.claude-opus-5".`
+          );
+        }
+        return { provider, modelId, baseModelId };
+      }
       return { provider, modelId };
     }
     if (knownProviders.has(provider)) {
@@ -286,6 +313,36 @@ function parseModelString(model) {
   }
   return { provider: "anthropic", modelId: trimmed };
 }
+function extractBedrockArnRegion(arn) {
+  const parts = arn.split(":");
+  return parts.length >= 4 && parts[3] ? parts[3] : "us-east-1";
+}
+function buildBedrockArnModel(opts) {
+  const region = opts.region ?? extractBedrockArnRegion(opts.arn);
+  const baseUrl = `https://bedrock-runtime.${region}.amazonaws.com`;
+  if (opts.baseModel) {
+    return {
+      ...opts.baseModel,
+      id: opts.arn,
+      // Keep the registry id as the name so pi-ai's capability matchers still
+      // see the vendor and model version behind the ARN.
+      name: opts.baseModel.id,
+      baseUrl
+    };
+  }
+  return {
+    id: opts.arn,
+    name: opts.arn,
+    api: "bedrock-converse-stream",
+    provider: "amazon-bedrock",
+    baseUrl,
+    reasoning: false,
+    input: ["text"],
+    cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
+    contextWindow: 2e5,
+    maxTokens: 16384
+  };
+}
 function mapReasoningEffort(effort) {
   if (!effort) return void 0;
   switch (effort.toLowerCase()) {
@@ -315,16 +372,26 @@ function getDefaultReasoningEffortForModel(model) {
 }
 var HIGH_RISK_PATH_RE = /(?:^|\/)(?:migrations?|schema|auth|security|permissions?|crypto|iam)(?:\/|\.|$)|\.tf$/im;
 var HIGH_RISK_CHANGE_RE = /^\+.*\b(?:authorization|authentication|permission|transaction|mutex|semaphore|encrypt|decrypt|credential|secret)\b/im;
+function isHighRiskDiff(diff) {
+  return HIGH_RISK_PATH_RE.test(diff) || HIGH_RISK_CHANGE_RE.test(diff);
+}
+var SINGLE_TURN_MAX_FILES = 5;
+var SINGLE_TURN_MAX_CHANGED_LINES = 50;
+function qualifiesForSingleTurnReview(opts) {
+  if (!opts.embedded || !opts.stats) return false;
+  const { files, additions, deletions } = opts.stats;
+  if (files === 0 || files > SINGLE_TURN_MAX_FILES) return false;
+  if (additions + deletions > SINGLE_TURN_MAX_CHANGED_LINES) return false;
+  if (opts.diff && isHighRiskDiff(opts.diff)) return false;
+  return true;
+}
 function selectReasoningEffort(opts) {
   const requested = mapReasoningEffort(opts.requested);
   if (requested) return requested;
   const modelDefault = opts.modelDefault;
   if (modelDefault !== "xhigh") return modelDefault;
   if (opts.forcedFull) return modelDefault;
-  const risky = Boolean(
-    opts.diff && (HIGH_RISK_PATH_RE.test(opts.diff) || HIGH_RISK_CHANGE_RE.test(opts.diff))
-  );
-  if (risky) return modelDefault;
+  if (opts.diff && isHighRiskDiff(opts.diff)) return modelDefault;
   if (opts.mode === "incremental" || opts.mode === "snapshot") return "high";
   const changedLines = (opts.stats?.additions ?? 0) + (opts.stats?.deletions ?? 0);
   if (opts.stats && opts.stats.files <= 10 && changedLines <= 500) return "high";
@@ -466,6 +533,9 @@ async function pushMetrics(opts) {
     `# HELP hodor_review_reused Whether an existing identical-HEAD review was reused`,
     `# TYPE hodor_review_reused gauge`,
     `hodor_review_reused${labelSuffix} ${metrics.reused ? 1 : 0}`,
+    `# HELP hodor_review_fast_path Whether the single-turn tiny-diff fast path gated tools to submit_review`,
+    `# TYPE hodor_review_fast_path gauge`,
+    `hodor_review_fast_path${labelSuffix} ${metrics.fastPath ? 1 : 0}`,
     ""
   ];
   const body = lines.join("\n");
@@ -2102,7 +2172,8 @@ async function reviewPr(opts) {
     localMode = false,
     diffAgainst,
     full = false,
-    targetBranchOverride
+    targetBranchOverride,
+    tinyDiffFastPath = false
   } = opts;
   const effectiveReviewInstructions = reviewInstructions == null ? loadDefaultReviewInstructions() : validateReviewInstructions(reviewInstructions, "review instructions");
   const effectiveAdditionalInstructions = additionalInstructions == null ? null : validateReviewInstructions(additionalInstructions, "additional instructions");
@@ -2137,24 +2208,26 @@ async function reviewPr(opts) {
   }
   let piModel = modelRuntime.getModel(parsed.provider, parsed.modelId);
   if (parsed.modelId.startsWith("arn:")) {
-    const arnParts = parsed.modelId.split(":");
-    const region = arnParts.length >= 4 ? arnParts[3] : "us-east-1";
+    const region = extractBedrockArnRegion(parsed.modelId);
     if (!process.env.AWS_REGION && !process.env.AWS_DEFAULT_REGION) {
       process.env.AWS_REGION = region;
     }
-    piModel = {
-      id: parsed.modelId,
-      name: parsed.modelId,
-      api: "bedrock-converse-stream",
-      provider: "amazon-bedrock",
-      baseUrl: `https://bedrock-runtime.${region}.amazonaws.com`,
-      reasoning: false,
-      input: ["text"],
-      cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
-      contextWindow: 2e5,
-      maxTokens: 16384
-    };
-    logger.info(`Custom bedrock ARN model \u2014 region: ${region}`);
+    const baseModel = parsed.baseModelId ? modelRuntime.getModel(parsed.provider, parsed.baseModelId) : void 0;
+    if (parsed.baseModelId && !baseModel) {
+      throw new Error(
+        `Base model "${parsed.baseModelId}" for Bedrock ARN "${parsed.modelId}" was not found in the installed pi-ai registry.`
+      );
+    }
+    piModel = buildBedrockArnModel({ arn: parsed.modelId, baseModel, region });
+    if (baseModel) {
+      logger.info(
+        `Custom bedrock ARN model \u2014 region: ${region}, capabilities from ${baseModel.id}`
+      );
+    } else {
+      logger.warn(
+        `Custom bedrock ARN model \u2014 region: ${region}, no base model given. Prompt caching, reasoning, and cost reporting are disabled. Append "@<base-model-id>" to the model string (e.g. "${model}@global.anthropic.claude-opus-5") to restore them.`
+      );
+    }
   } else if (!piModel) {
     if (parsed.provider === "openrouter") {
       piModel = {
@@ -2315,13 +2388,19 @@ async function reviewPr(opts) {
           diffAdditions: 0,
           diffDeletions: 0,
           diffBytes: 0,
-          reused: true
+          reused: true,
+          fastPath: false
         };
         logger.info(`Review telemetry: ${JSON.stringify({
+          project: `${owner}/${repo}`,
+          mr: prNumber,
+          headSha: headSha.slice(0, 12),
+          model,
+          outcome: "reused",
           reviewMode: metrics2.reviewMode,
           reasoningEffort: metrics2.reasoningEffort,
+          fastPath: false,
           reused: true,
-          headSha: headSha.slice(0, 12),
           findings: cachedReview.findings.length
         })}`);
         printMetrics(metrics2);
@@ -2380,6 +2459,16 @@ async function reviewPr(opts) {
     if (thinkingLevel) {
       logger.info(`Reasoning effort for ${piModel.name}: ${thinkingLevel}${reasoningEffort ? " (explicit)" : " (adaptive)"}`);
     }
+    const singleTurn = tinyDiffFastPath && qualifiesForSingleTurnReview({
+      diff: reviewDiff,
+      stats: diffStats,
+      embedded: embeddedDiff != null
+    });
+    if (singleTurn) {
+      logger.info(
+        `Single-turn fast path: tiny low-risk diff (${diffStats?.files} file(s), ${(diffStats?.additions ?? 0) + (diffStats?.deletions ?? 0)} changed line(s)); exposing only submit_review`
+      );
+    }
     const prompt = buildPrReviewPrompt({
       prUrl: prUrl ?? `local diff (against ${targetBranch})`,
       platform,
@@ -2390,7 +2479,8 @@ async function reviewPr(opts) {
       previousReviewSha,
       reviewDiffMode: reviewMode,
       changedFiles,
-      localMode
+      localMode,
+      singleTurn
     });
     const startTime = Date.now();
     const settingsManager = SettingsManager.inMemory({
@@ -2469,7 +2559,7 @@ async function reviewPr(opts) {
       // (see _refreshToolRegistry in @earendil-works/pi-coding-agent's
       // agent-session.ts). The submit_review custom tool must be named here
       // or the LLM never sees it and the agent loop exits without calling it.
-      tools: ["read", "bash", "grep", "find", "ls", "submit_review"],
+      tools: singleTurn ? ["submit_review"] : ["read", "bash", "grep", "find", "ls", "submit_review"],
       customTools: [submitReviewTool],
       modelRuntime,
       sessionManager: SessionManager.inMemory(),
@@ -2627,11 +2717,18 @@ async function reviewPr(opts) {
       diffAdditions: diffStats?.additions ?? 0,
       diffDeletions: diffStats?.deletions ?? 0,
       diffBytes: diffStats?.bytes ?? 0,
-      reused: false
+      reused: false,
+      fastPath: singleTurn
     };
     logger.info(`Review telemetry: ${JSON.stringify({
+      project: localMode ? null : `${owner}/${repo}`,
+      mr: localMode ? null : prNumber,
+      headSha: headSha?.slice(0, 12) ?? null,
+      model,
+      outcome: "reviewed",
       reviewMode: metrics.reviewMode,
       reasoningEffort: metrics.reasoningEffort,
+      fastPath: singleTurn,
       reused: false,
       diffFiles: metrics.diffFiles,
       diffAdditions: metrics.diffAdditions,
@@ -2699,4 +2796,4 @@ export {
   postReviewStructured,
   reviewPr
 };
-//# sourceMappingURL=chunk-Q5AQKNSE.js.map
+//# sourceMappingURL=chunk-VERO4XYJ.js.map