@mrclrchtr/supi-review 2.8.0 → 3.1.0

package/src/tui/common.ts

@@ -0,0 +1,237 @@
+/**
+ * Shared TUI rendering helpers for supi-review tool output.
+ *
+ * Dual-surface rendering: chrome built from details, markdown body excluded.
+ * Follows the tool-rendering convention in docs/tool-rendering.md.
+ */
+
+import type { Theme } from "@earendil-works/pi-coding-agent";
+import { type Container, Spacer, Text } from "@earendil-works/pi-tui";
+import { formatEvidenceBadge } from "@mrclrchtr/supi-core/evidence-badge";
+import type {
+  ChildFailureDiagnostics,
+  FindingEffort,
+  FindingImpact,
+  ReviewFinding,
+  ReviewTaskResult,
+  TaskVerdict,
+} from "../types.ts";
+
+// ── Spinner state ────────────────────────────────────────────────
+
+/** Progress indicator shown while the tool is still running. */
+export function renderPartial(label: string, theme: Theme): Text {
+  return new Text(theme.fg("warning", `● ${label}`), 0, 0);
+}
+
+/** Error state when the tool fails. */
+export function renderError(label: string, theme: Theme): Text {
+  return new Text(theme.fg("error", label), 0, 0);
+}
+
+// ── Verdict / status badges ──────────────────────────────────────
+
+/** Colored verdict label for PASS or ISSUES. */
+export function formatVerdictBadge(verdict: TaskVerdict, theme: Theme): string {
+  return verdict === "pass"
+    ? theme.fg("success", theme.bold("PASS"))
+    : theme.fg("error", theme.bold("ISSUES"));
+}
+
+/** Colored status label for non-completed task results. */
+export function formatStatusLabel(
+  status: "failed" | "canceled" | "timeout",
+  failureCode?: string,
+  timeoutMs?: number,
+): string {
+  switch (status) {
+    case "failed":
+      return `FAILED${failureCode ? ` (${failureCode})` : ""}`;
+    case "canceled":
+      return "CANCELED";
+    case "timeout":
+      return `TIMEOUT (${timeoutMs} ms)`;
+  }
+}
+
+// ── Finding badges ───────────────────────────────────────────────
+
+const IMPACT_LABEL: Record<FindingImpact, string> = {
+  low: "low",
+  medium: "medium",
+  high: "high",
+};
+
+const EFFORT_LABEL: Record<FindingEffort, string> = {
+  small: "small",
+  medium: "medium",
+  large: "large",
+};
+
+/** Build a compact finding summary line with impact, effort, and confidence badges. */
+export function formatFindingLine(finding: ReviewFinding, theme: Theme): string {
+  const blocking = finding.blocksAcceptance
+    ? theme.fg("error", "BLOCKING")
+    : theme.fg("muted", "non-blocking");
+  const impact = theme.fg("dim", `impact: ${IMPACT_LABEL[finding.impact]}`);
+  const effort = theme.fg("dim", `effort: ${EFFORT_LABEL[finding.effort]}`);
+  const confidence = theme.fg("dim", `confidence: ${finding.confidence.toFixed(1)}`);
+  return `[${blocking}] ${theme.fg("accent", finding.title)} · ${impact} · ${effort} · ${confidence}`;
+}
+
+// ── Tool call rendering ──────────────────────────────────────────
+
+/** Compact single-line renderCall shared by both review tools. */
+export function renderReviewToolCall(
+  name: string,
+  primary: string,
+  theme: Theme,
+  secondary?: string,
+): Text {
+  let content = theme.fg("toolTitle", name);
+  if (primary) {
+    content += ` ${theme.fg("accent", primary)}`;
+  }
+  if (secondary) {
+    content += theme.fg("dim", ` — ${secondary}`);
+  }
+  return new Text(content, 0, 0);
+}
+
+// ── Task section (expanded) ──────────────────────────────────────
+
+/** Render a single finding's details into the container. */
+function renderFinding(container: Container, finding: ReviewFinding, theme: Theme): void {
+  container.addChild(new Text(formatFindingLine(finding, theme), 1, 0));
+  if (finding.location) {
+    container.addChild(
+      new Text(
+        theme.fg(
+          "dim",
+          `  ${finding.location.path}:${finding.location.startLine}-${finding.location.endLine}`,
+        ),
+        1,
+        0,
+      ),
+    );
+  }
+  container.addChild(new Text(theme.fg("text", `  ${finding.description}`), 1, 0));
+  container.addChild(new Spacer(1));
+}
+
+/** Build a compact diagnostics section for non-completed (failed/canceled/timeout) task results. */
+function buildNonCompletedSection(
+  container: Container,
+  result: ReviewTaskResult & { status: "failed" | "canceled" | "timeout" },
+  theme: Theme,
+): void {
+  const diagnostics: ChildFailureDiagnostics | undefined =
+    "diagnostics" in result ? result.diagnostics : undefined;
+  if (!diagnostics) return;
+
+  container.addChild(new Spacer(1));
+  container.addChild(
+    new Text(
+      theme.fg("dim", `${diagnostics.turns} turns · ${diagnostics.toolUses} tool uses`),
+      1,
+      0,
+    ),
+  );
+
+  if (diagnostics.lastAssistantStopReason) {
+    container.addChild(
+      new Text(
+        theme.fg(
+          diagnostics.lastAssistantStopReason === "error" ? "error" : "dim",
+          `Last assistant stop: ${diagnostics.lastAssistantStopReason}`,
+        ),
+        1,
+        0,
+      ),
+    );
+  }
+
+  if (diagnostics.lastAssistantErrorText) {
+    const truncated =
+      diagnostics.lastAssistantErrorText.length > 200
+        ? `${diagnostics.lastAssistantErrorText.slice(0, 200)}…`
+        : diagnostics.lastAssistantErrorText;
+    container.addChild(new Text(theme.fg("error", truncated), 1, 0));
+  } else if (diagnostics.lastLifecycleErrorText) {
+    const truncated =
+      diagnostics.lastLifecycleErrorText.length > 200
+        ? `${diagnostics.lastLifecycleErrorText.slice(0, 200)}…`
+        : diagnostics.lastLifecycleErrorText;
+    container.addChild(new Text(theme.fg("error", truncated), 1, 0));
+  } else if (diagnostics.lastAssistantStopReason === "error") {
+    container.addChild(
+      new Text(
+        theme.fg(
+          "dim",
+          "The model produced an error with no further details — check provider quota, auth, or configuration.",
+        ),
+        1,
+        0,
+      ),
+    );
+  }
+}
+
+/** Build an expanded-view section for a single review task result. */
+export function buildTaskSection(
+  container: Container,
+  result: ReviewTaskResult,
+  theme: Theme,
+): void {
+  // Header
+  const verdictOrStatus =
+    result.status === "completed"
+      ? formatVerdictBadge(result.verdict, theme)
+      : theme.fg(
+          "warning",
+          formatStatusLabel(
+            result.status,
+            result.status === "failed" ? result.failureCode : undefined,
+            result.status === "timeout" ? result.timeoutMs : undefined,
+          ),
+        );
+
+  const findingCount =
+    result.status === "completed"
+      ? formatEvidenceBadge({
+          shownCount: result.findings.length,
+          totalCount: result.findings.length,
+          omittedCount: 0,
+          partialReason: null,
+          label: result.findings.length === 1 ? "finding" : "findings",
+        })
+      : "";
+
+  const headerParts = [verdictOrStatus];
+  if (findingCount) headerParts.push(theme.fg("muted", findingCount));
+  container.addChild(new Text(headerParts.join("  "), 1, 0));
+
+  const metaParts = [
+    theme.fg("dim", `model: ${result.modelId}`),
+    theme.fg("dim", `hash: ${result.packetHash.slice(0, 12)}…`),
+  ];
+  container.addChild(new Text(metaParts.join("  "), 1, 0));
+
+  // Completed task — show summary and findings
+  if (result.status !== "completed") {
+    buildNonCompletedSection(container, result, theme);
+    return;
+  }
+
+  if (result.summary) {
+    container.addChild(new Spacer(1));
+    container.addChild(new Text(theme.fg("muted", result.summary), 1, 0));
+  }
+
+  if (result.findings.length === 0) return;
+
+  container.addChild(new Spacer(1));
+  for (const finding of result.findings) {
+    renderFinding(container, finding, theme);
+  }
+}

package/src/tui/prepare.ts

@@ -0,0 +1,132 @@
+/**
+ * TUI renderer for supi_review_prepare — renderCall + renderResult.
+ *
+ * Dual-surface rendering: chrome built from details, markdown body excluded.
+ */
+
+import type { Theme } from "@earendil-works/pi-coding-agent";
+import { Container, Spacer, Text } from "@earendil-works/pi-tui";
+import type { PreparedReviewDetails } from "../types.ts";
+import { renderError, renderPartial, renderReviewToolCall } from "./common.ts";
+
+/** Plan details shape extracted from execute's details return. */
+interface PrepareDetails extends PreparedReviewDetails {
+  plannerDraft?: {
+    sharedContext?: string;
+    tasks: Array<{ id: string; instructions: string }>;
+  };
+}
+
+// ── renderCall ───────────────────────────────────────────────────
+
+export function renderPrepareCall(args: unknown, theme: Theme): Text {
+  const params = (args ?? {}) as {
+    planning?: string;
+    target?: { kind?: string };
+  };
+  const planning = params.planning ?? "none";
+  const targetKind = params.target?.kind ?? "working-tree";
+
+  return renderReviewToolCall("supi_review_prepare", planning, theme, targetKind);
+}
+
+// ── renderResult ─────────────────────────────────────────────────
+
+export function renderPrepareResult(
+  result: {
+    content?: Array<{ type: string; text?: string }>;
+    details?: unknown;
+    isError?: boolean;
+  },
+  options: { expanded: boolean; isPartial: boolean },
+  theme: Theme,
+): Container | Text {
+  if (options.isPartial) return renderPartial("Preparing review…", theme);
+
+  const details = result.details as PrepareDetails | undefined;
+
+  if (result.isError || !details) {
+    return renderError("supi_review_prepare failed", theme);
+  }
+
+  if (!options.expanded) {
+    return buildCollapsed(details, theme);
+  }
+
+  return buildExpanded(details, theme);
+}
+
+// ── Collapsed ────────────────────────────────────────────────────
+
+function buildCollapsed(details: PrepareDetails, theme: Theme): Text {
+  const fileCount = details.snapshot.changedFiles.length;
+  const targetKind = details.snapshot.requestedTarget.kind;
+  const hasPlanner = details.plannerDraft !== undefined;
+
+  const segments: string[] = [];
+  segments.push(theme.fg("accent", "Plan ready"));
+  segments.push(theme.fg("muted", targetKind));
+  segments.push(theme.fg("dim", `${fileCount} file${fileCount !== 1 ? "s" : ""} changed`));
+  if (hasPlanner) {
+    segments.push(theme.fg("muted", "with draft"));
+  }
+
+  return new Text(segments.join(` ${theme.fg("dim", "·")} `), 0, 0);
+}
+
+// ── Expanded ─────────────────────────────────────────────────────
+
+function buildExpanded(details: PrepareDetails, theme: Theme): Container {
+  const container = new Container();
+
+  // Header
+  container.addChild(new Text(theme.fg("accent", theme.bold("Review Plan Prepared")), 1, 0));
+  container.addChild(new Spacer(1));
+
+  // Plan identity
+  container.addChild(new Text(theme.fg("muted", `Plan ID: ${details.planId}`), 1, 0));
+
+  // Target info
+  const snapshot = details.snapshot;
+  container.addChild(new Spacer(1));
+  container.addChild(new Text(theme.fg("accent", theme.bold("Target")), 1, 0));
+  container.addChild(new Text(theme.fg("muted", snapshot.title), 1, 0));
+  container.addChild(
+    new Text(
+      theme.fg(
+        "dim",
+        `${snapshot.changedFiles.length} file${snapshot.changedFiles.length !== 1 ? "s" : ""} changed · +${snapshot.stats.additions} / -${snapshot.stats.deletions}`,
+      ),
+      1,
+      0,
+    ),
+  );
+
+  // Model info
+  container.addChild(new Spacer(1));
+  container.addChild(new Text(theme.fg("dim", `Reviewer model: ${details.reviewerModelId}`), 1, 0));
+  if (details.plannerModelId) {
+    container.addChild(new Text(theme.fg("dim", `Planner model: ${details.plannerModelId}`), 1, 0));
+  }
+
+  // Planner draft
+  if (details.plannerDraft) {
+    container.addChild(new Spacer(1));
+    container.addChild(new Text(theme.fg("accent", theme.bold("Planner Draft")), 1, 0));
+    if (details.plannerDraft.sharedContext) {
+      container.addChild(new Spacer(1));
+      container.addChild(new Text(theme.fg("muted", details.plannerDraft.sharedContext), 1, 0));
+    }
+    if (details.plannerDraft.tasks.length > 0) {
+      container.addChild(new Spacer(1));
+      for (const task of details.plannerDraft.tasks) {
+        container.addChild(
+          new Text(`${theme.fg("accent", task.id)}: ${theme.fg("muted", task.instructions)}`, 1, 0),
+        );
+        container.addChild(new Text(theme.fg("dim", "─".repeat(40)), 1, 0));
+      }
+    }
+  }
+
+  return container;
+}

package/src/tui/run.ts

@@ -0,0 +1,160 @@
+/**
+ * TUI renderer for supi_review_run — renderCall + renderResult.
+ *
+ * Dual-surface rendering: chrome built from details, markdown body excluded.
+ */
+
+import type { Theme } from "@earendil-works/pi-coding-agent";
+import { Container, Spacer, Text } from "@earendil-works/pi-tui";
+import type { ReviewBatchDetails, ReviewTaskResult } from "../types.ts";
+import {
+  buildTaskSection,
+  formatStatusLabel,
+  formatVerdictBadge,
+  renderError,
+  renderPartial,
+  renderReviewToolCall,
+} from "./common.ts";
+
+// ── Helpers ──────────────────────────────────────────────────────
+
+/** Format a compact per-task collapsed line. */
+function formatTaskCollapsed(result: ReviewTaskResult, theme: Theme): string {
+  if (result.status === "completed") {
+    const findingCount = result.findings.length;
+    const findingLabel =
+      findingCount > 0 ? ` (${findingCount} finding${findingCount !== 1 ? "s" : ""})` : "";
+    return `${result.taskId}: ${formatVerdictBadge(result.verdict, theme)}${theme.fg("dim", findingLabel)}`;
+  }
+  // Non-completed task — show status
+  const label = formatStatusLabel(
+    result.status,
+    result.status === "failed" ? result.failureCode : undefined,
+    result.status === "timeout" ? result.timeoutMs : undefined,
+  );
+  return `${result.taskId}: ${theme.fg("warning", label)}`;
+}
+
+// ── renderCall ───────────────────────────────────────────────────
+
+export function renderRunCall(args: unknown, theme: Theme): Text {
+  const params = (args ?? {}) as {
+    mode?: string;
+    target?: { kind?: string };
+    planId?: string;
+  };
+  const mode = params.mode ?? "direct";
+  const primary = mode;
+  const secondary = mode === "prepared" ? "from plan" : (params.target?.kind ?? undefined);
+
+  return renderReviewToolCall("supi_review_run", primary, theme, secondary);
+}
+
+// ── renderResult ─────────────────────────────────────────────────
+
+export function renderRunResult(
+  result: {
+    content?: Array<{ type: string; text?: string }>;
+    details?: unknown;
+    isError?: boolean;
+  },
+  options: { expanded: boolean; isPartial: boolean },
+  theme: Theme,
+): Container | Text {
+  if (options.isPartial) {
+    const details = result.details as { completedCount?: number; totalCount?: number } | undefined;
+    const completed = details?.completedCount ?? 0;
+    const total = details?.totalCount ?? 0;
+    const label = total > 0 ? `Reviewing… (${completed} of ${total} tasks complete)` : "Reviewing…";
+    return renderPartial(label, theme);
+  }
+
+  const details = result.details as ReviewBatchDetails | undefined;
+
+  if (result.isError || !details) {
+    return renderError("supi_review_run failed", theme);
+  }
+
+  if (!options.expanded) {
+    return buildCollapsed(details, theme);
+  }
+
+  return buildExpanded(details, theme);
+}
+
+// ── Collapsed ────────────────────────────────────────────────────
+
+function buildCollapsed(details: ReviewBatchDetails, theme: Theme): Container {
+  const taskLines = details.results.map((r) => formatTaskCollapsed(r, theme));
+  const fileCount = details.snapshot.changedFiles.length;
+
+  const container = new Container();
+  // Per-task verdicts
+  container.addChild(new Text(taskLines.join(` ${theme.fg("dim", "·")} `), 0, 0));
+  // Target summary
+  container.addChild(
+    new Text(
+      theme.fg("dim", `${details.snapshot.title} (${fileCount} file${fileCount !== 1 ? "s" : ""})`),
+      0,
+      0,
+    ),
+  );
+  return container;
+}
+
+// ── Expanded ─────────────────────────────────────────────────────
+
+function buildExpanded(details: ReviewBatchDetails, theme: Theme): Container {
+  const container = new Container();
+
+  // Header
+  const provenanceLabel =
+    details.provenance === "planner-assisted"
+      ? theme.fg("muted", "(planner-assisted)")
+      : theme.fg("dim", "(caller-supplied)");
+  container.addChild(
+    new Text(`${theme.fg("accent", theme.bold("Review Complete"))}  ${provenanceLabel}`, 1, 0),
+  );
+  container.addChild(new Spacer(1));
+
+  // Preamble: mode + target
+  container.addChild(
+    new Text(`${theme.fg("dim", "mode:")} ${theme.fg("muted", details.mode)}`, 1, 0),
+  );
+  container.addChild(
+    new Text(`${theme.fg("dim", "target:")} ${theme.fg("muted", details.snapshot.title)}`, 1, 0),
+  );
+  const fileCount = details.snapshot.changedFiles.length;
+  container.addChild(
+    new Text(
+      theme.fg(
+        "dim",
+        `${fileCount} file${fileCount !== 1 ? "s" : ""} changed · +${details.snapshot.stats.additions} / -${details.snapshot.stats.deletions}`,
+      ),
+      1,
+      0,
+    ),
+  );
+
+  // Planning info
+  if (details.planning) {
+    container.addChild(new Spacer(1));
+    container.addChild(
+      new Text(
+        `${theme.fg("dim", "planner:")} ${theme.fg("muted", details.planning.modelId)} · ${theme.fg("dim", "decision:")} ${theme.fg("muted", details.planning.decision)}`,
+        1,
+        0,
+      ),
+    );
+  }
+
+  // Per-task sections
+  for (const result of details.results) {
+    container.addChild(new Spacer(1));
+    container.addChild(new Text(theme.fg("accent", theme.bold(result.taskId)), 1, 0));
+    container.addChild(new Text(theme.fg("dim", "─".repeat(40)), 1, 0));
+    buildTaskSection(container, result, theme);
+  }
+
+  return container;
+}