@mrclrchtr/supi-review 2.8.0 → 3.0.0

package/src/ui/format-content.ts

@@ -1,143 +0,0 @@
-import {
-  formatChildFailureCopy,
-  formatChildFailureDiagnostics,
-} from "../tool/child-failure-diagnostics.ts";
-import type {
-  BriefSynthesisRunResult,
-  ChildFailureDiagnostics,
-  ReviewItem,
-  ReviewResult,
-} from "../types.ts";
-
-/** Format a `impact` or `effort` level value. */
-export function formatLevel(value: ReviewItem["impact"] | ReviewItem["effort"]): string {
-  return `${value[0]?.toUpperCase() ?? ""}${value.slice(1)}`;
-}
-
-/** Format a code location as a human-readable `file:line` or `file:start-end`. */
-export function formatLocation(file: string, startLine: number, endLine: number): string {
-  return `${file}:${startLine === endLine ? startLine : `${startLine}-${endLine}`}`;
-}
-
-/** Format one non-success brief-synthesis result for parent-facing custom-message content. */
-export function formatBriefSynthesisFailureContent(
-  result: Exclude<BriefSynthesisRunResult, { kind: "success" }>,
-): string {
-  const parts = [formatBriefSynthesisFailureCopy(result)];
-  appendChildFailureDiagnostics(parts, result.diagnostics);
-  return parts.join("\n");
-}
-
-/** Generate short static parent-facing copy for a brief-synthesis outcome. */
-export function formatBriefSynthesisFailureCopy(
-  result: Exclude<BriefSynthesisRunResult, { kind: "success" }>,
-): string {
-  switch (result.kind) {
-    case "failed":
-      return formatChildFailureCopy("brief-synthesis", result.failureCode);
-    case "canceled":
-      return "Brief synthesis was canceled.";
-    case "timeout":
-      return "Brief synthesis timed out.";
-  }
-}
-
-/** Format review results for the LLM-visible custom message content. */
-export function formatReviewContent(result: ReviewResult): string {
-  switch (result.kind) {
-    case "success":
-      return formatSuccessContent(result);
-    case "failed":
-      return formatFailureContent(result);
-    case "canceled":
-      return formatCanceledContent(result);
-    case "timeout":
-      return formatTimeoutContent(result);
-  }
-}
-
-function formatFailureContent(result: Extract<ReviewResult, { kind: "failed" }>): string {
-  const parts = [formatChildFailureCopy("reviewer", result.failureCode)];
-  appendChildFailureDiagnostics(parts, result.diagnostics);
-  return parts.join("\n");
-}
-
-function formatCanceledContent(result: Extract<ReviewResult, { kind: "canceled" }>): string {
-  const parts = ["Reviewer was canceled."];
-  appendChildFailureDiagnostics(parts, result.diagnostics);
-  return parts.join("\n");
-}
-
-function formatTimeoutContent(result: Extract<ReviewResult, { kind: "timeout" }>): string {
-  const parts = ["Reviewer timed out."];
-  appendChildFailureDiagnostics(parts, result.diagnostics);
-  return parts.join("\n");
-}
-
-function appendChildFailureDiagnostics(
-  parts: string[],
-  diagnostics: ChildFailureDiagnostics | undefined,
-): void {
-  if (!diagnostics) return;
-  parts.push("", "Diagnostics:", ...formatChildFailureDiagnostics(diagnostics));
-}
-
-function formatSuccessContent(result: Extract<ReviewResult, { kind: "success" }>): string {
-  const { output } = result;
-  const confidencePercent = Math.round(output.overall_confidence_score * 100);
-  const lines: string[] = ["## Code Review Result", "", `**Model:** ${result.modelId}`];
-
-  if (result.brief) {
-    lines.push("", "### Session-derived Brief", "");
-    lines.push(`**Summary:** ${result.brief.summary}`);
-    lines.push(`**Intended outcome:** ${result.brief.intendedOutcome}`);
-    if (result.brief.constraints.length > 0) {
-      lines.push("**Constraints:**");
-      lines.push(...result.brief.constraints.map((item) => `- ${item}`));
-    }
-    if (result.brief.focusAreas.length > 0) {
-      lines.push("**Focus areas:**");
-      lines.push(...result.brief.focusAreas.map((item) => `- ${item}`));
-    }
-    if (result.brief.riskyFiles.length > 0) {
-      lines.push("**Risky files:**");
-      lines.push(...result.brief.riskyFiles.map((item) => `- ${item}`));
-    }
-  }
-
-  lines.push("", `Verdict: ${output.overall_correctness} (confidence: ${confidencePercent}%)`);
-  lines.push(
-    `Summary: ${output.summary.actions.mustFix} must-fix, ${output.summary.actions.shouldFix} should-fix, ${output.summary.actions.consider} consider`,
-  );
-
-  if (output.items.length > 0) {
-    lines.push("", "### Review Items", "", ...formatReviewItems(output.items));
-  }
-
-  lines.push("", `Overall: ${output.overall_explanation}`);
-  return lines.join("\n");
-}
-
-function formatReviewItems(items: ReviewItem[]): string[] {
-  return items.flatMap((item, index) => {
-    const location = item.code_location
-      ? `      ${formatLocation(item.code_location.absolute_file_path, item.code_location.line_range.start, item.code_location.line_range.end)}`
-      : undefined;
-
-    const lines = [
-      `   #${index + 1} ${item.title} [${item.recommended_action}]`,
-      `      Category: ${item.category}`,
-      `      Impact: ${formatLevel(item.impact)}`,
-      `      Effort: ${formatLevel(item.effort)}`,
-    ];
-
-    if (location) {
-      lines.push(location);
-    }
-
-    lines.push(`      ${item.body}`);
-    lines.push(`      Suggested fix: ${item.suggested_fix}`);
-    lines.push(`      Verification: ${item.verification_hint}`);
-    return lines;
-  });
-}

package/src/ui/renderer.ts

@@ -1,274 +0,0 @@
-import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
-import { Box, Container, Spacer, Text } from "@earendil-works/pi-tui";
-import {
-  formatChildFailureCopy,
-  formatChildFailureDiagnostics,
-} from "../tool/child-failure-diagnostics.ts";
-import type {
-  BriefSynthesisRunResult,
-  ChildFailureDiagnostics,
-  ReviewItem,
-  ReviewResult,
-  ReviewSnapshot,
-} from "../types.ts";
-import { formatBriefSynthesisFailureCopy, formatLevel, formatLocation } from "./format-content.ts";
-
-/** Register the custom TUI renderer for `supi-review` messages. */
-interface BriefSynthesisFailureMessage {
-  result: Exclude<BriefSynthesisRunResult, { kind: "success" }>;
-  snapshot: ReviewSnapshot;
-  modelId: string;
-}
-
-interface ReviewMessageDetails {
-  result?: ReviewResult;
-  briefSynthesisFailure?: BriefSynthesisFailureMessage;
-}
-
-export function registerReviewRenderer(pi: ExtensionAPI): void {
-  pi.registerMessageRenderer("supi-review", (message, { expanded }, theme) => {
-    const details = message.details as ReviewMessageDetails | undefined;
-    if (details?.briefSynthesisFailure) {
-      return renderBriefSynthesisFailure(details.briefSynthesisFailure, theme);
-    }
-
-    const result = details?.result;
-    if (!result) {
-      return new Text(theme.fg("dim", "No review data"), 1, 0);
-    }
-
-    switch (result.kind) {
-      case "success":
-        return renderSuccess(result, theme, expanded);
-      case "failed":
-        return renderFailed(result, theme);
-      case "canceled":
-        return renderCanceled(result, theme);
-      case "timeout":
-        return renderTimeout(result, theme);
-      default:
-        return new Text(theme.fg("dim", "Unknown review state"), 1, 0);
-    }
-  });
-}
-
-function renderBriefSynthesisFailure(
-  failure: BriefSynthesisFailureMessage,
-  theme: Parameters<Parameters<ExtensionAPI["registerMessageRenderer"]>[1]>[2],
-): Container {
-  const container = new Container();
-  const title =
-    failure.result.kind === "failed"
-      ? "◆ Brief Synthesis Failed"
-      : failure.result.kind === "timeout"
-        ? "◆ Brief Synthesis Timed Out"
-        : "◆ Brief Synthesis Canceled";
-  const color = failure.result.kind === "failed" ? "error" : "warning";
-
-  container.addChild(new Text(theme.fg(color, title), 1, 0));
-  container.addChild(new Spacer(1));
-  container.addChild(new Text(theme.fg("muted", `Model: ${failure.modelId}`), 1, 0));
-  container.addChild(new Text(theme.fg("muted", `Snapshot: ${failure.snapshot.title}`), 1, 0));
-  container.addChild(new Spacer(1));
-  container.addChild(
-    new Text(theme.fg(color, formatBriefSynthesisFailureCopy(failure.result)), 1, 0),
-  );
-  renderChildFailureDiagnostics(container, failure.result.diagnostics, theme);
-  return container;
-}
-
-function renderSuccess(
-  result: Extract<ReviewResult, { kind: "success" }>,
-  theme: Parameters<Parameters<ExtensionAPI["registerMessageRenderer"]>[1]>[2],
-  expanded: boolean,
-): Container {
-  const container = new Container();
-  const output = result.output;
-
-  container.addChild(new Text(theme.fg("accent", "◆ Code Review Results"), 1, 0));
-  container.addChild(new Text(theme.fg("muted", `Model: ${result.modelId}`), 1, 0));
-  container.addChild(new Text(theme.fg("muted", `Snapshot: ${result.snapshot.title}`), 1, 0));
-  container.addChild(new Spacer(1));
-
-  if (result.brief) {
-    renderBriefContext(container, result.brief, theme);
-    container.addChild(new Spacer(1));
-  }
-
-  const normalizedVerdict = output.overall_correctness.toLowerCase();
-  const verdictColor = normalizedVerdict.includes("issues") ? "warning" : "success";
-  container.addChild(
-    new Text(
-      `${theme.fg(verdictColor, "●")} ${theme.fg(verdictColor, output.overall_correctness)}` +
-        theme.fg("dim", `  (confidence: ${(output.overall_confidence_score * 100).toFixed(0)}%)`),
-      1,
-      0,
-    ),
-  );
-  container.addChild(
-    new Text(
-      theme.fg(
-        "dim",
-        `Summary: ${output.summary.actions.mustFix} must-fix, ${output.summary.actions.shouldFix} should-fix, ${output.summary.actions.consider} consider`,
-      ),
-      1,
-      0,
-    ),
-  );
-
-  if (output.overall_explanation) {
-    container.addChild(new Spacer(1));
-    container.addChild(new Text(theme.fg("dim", output.overall_explanation), 1, 0));
-  }
-
-  if (expanded) {
-    container.addChild(new Spacer(1));
-
-    if (output.items.length === 0) {
-      container.addChild(new Text(theme.fg("success", "✓ No review items"), 1, 0));
-    } else {
-      container.addChild(
-        new Text(theme.fg("accent", `Review Items (${output.items.length})`), 1, 0),
-      );
-      output.items.forEach((item, index) => {
-        container.addChild(renderReviewItem(item, index, theme));
-      });
-    }
-  }
-
-  return container;
-}
-
-function renderBriefContext(
-  container: Container,
-  brief: NonNullable<Extract<ReviewResult, { kind: "success" }>["brief"]>,
-  theme: Parameters<Parameters<ExtensionAPI["registerMessageRenderer"]>[1]>[2],
-): void {
-  container.addChild(new Text(theme.fg("muted", `Summary: ${brief.summary}`), 1, 0));
-  container.addChild(new Text(theme.fg("muted", `Outcome: ${brief.intendedOutcome}`), 1, 0));
-  if (brief.focusAreas.length > 0) {
-    container.addChild(
-      new Text(theme.fg("muted", `Focus: ${brief.focusAreas.slice(0, 3).join(", ")}`), 1, 0),
-    );
-  }
-  if (brief.riskyFiles.length > 0) {
-    container.addChild(
-      new Text(theme.fg("muted", `Risky files: ${brief.riskyFiles.slice(0, 3).join(", ")}`), 1, 0),
-    );
-  }
-}
-
-function renderReviewItem(
-  item: ReviewItem,
-  index: number,
-  theme: Parameters<Parameters<ExtensionAPI["registerMessageRenderer"]>[1]>[2],
-): Container {
-  const container = new Container();
-  const actionColor = actionColorName(item.recommended_action);
-  const locationText = item.code_location
-    ? formatLocation(
-        item.code_location.absolute_file_path,
-        item.code_location.line_range.start,
-        item.code_location.line_range.end,
-      )
-    : undefined;
-
-  container.addChild(new Spacer(1));
-  container.addChild(
-    new Text(
-      `${theme.fg("text", `#${index + 1} ${item.title}`)} ${theme.fg(actionColor, `[${item.recommended_action}]`)}`,
-      1,
-      0,
-    ),
-  );
-  container.addChild(new Text(theme.fg("dim", `Category: ${item.category}`), 2, 0));
-  container.addChild(new Text(theme.fg("dim", `Impact: ${formatLevel(item.impact)}`), 2, 0));
-  container.addChild(new Text(theme.fg("dim", `Effort: ${formatLevel(item.effort)}`), 2, 0));
-
-  if (locationText) {
-    container.addChild(new Text(theme.fg("dim", locationText), 2, 0));
-  }
-
-  if (item.body) {
-    const body = new Box(2, 0);
-    body.addChild(new Text(theme.fg("text", item.body), 0, 0));
-    container.addChild(body);
-  }
-
-  container.addChild(new Text(theme.fg("dim", `Suggested fix: ${item.suggested_fix}`), 2, 0));
-  container.addChild(new Text(theme.fg("dim", `Verification: ${item.verification_hint}`), 2, 0));
-
-  return container;
-}
-
-function renderFailed(
-  result: Extract<ReviewResult, { kind: "failed" }>,
-  theme: Parameters<Parameters<ExtensionAPI["registerMessageRenderer"]>[1]>[2],
-): Container {
-  const container = new Container();
-  container.addChild(new Text(theme.fg("error", "◆ Review Failed"), 1, 0));
-  container.addChild(new Spacer(1));
-  container.addChild(new Text(theme.fg("muted", `Model: ${result.modelId}`), 1, 0));
-  container.addChild(new Text(theme.fg("muted", `Snapshot: ${result.snapshot.title}`), 1, 0));
-  container.addChild(new Spacer(1));
-  container.addChild(
-    new Text(theme.fg("error", formatChildFailureCopy("reviewer", result.failureCode)), 1, 0),
-  );
-  renderChildFailureDiagnostics(container, result.diagnostics, theme);
-  return container;
-}
-
-function renderTimeout(
-  result: Extract<ReviewResult, { kind: "timeout" }>,
-  theme: Parameters<Parameters<ExtensionAPI["registerMessageRenderer"]>[1]>[2],
-): Container {
-  const container = new Container();
-  container.addChild(new Text(theme.fg("warning", "◆ Review Timed Out"), 1, 0));
-  container.addChild(new Spacer(1));
-  container.addChild(new Text(theme.fg("muted", `Model: ${result.modelId}`), 1, 0));
-  container.addChild(new Text(theme.fg("muted", `Snapshot: ${result.snapshot.title}`), 1, 0));
-  container.addChild(new Spacer(1));
-  container.addChild(new Text(theme.fg("warning", "Reviewer timed out."), 1, 0));
-  renderChildFailureDiagnostics(container, result.diagnostics, theme);
-  return container;
-}
-
-function renderCanceled(
-  result: Extract<ReviewResult, { kind: "canceled" }>,
-  theme: Parameters<Parameters<ExtensionAPI["registerMessageRenderer"]>[1]>[2],
-): Container {
-  const container = new Container();
-  container.addChild(new Text(theme.fg("warning", "◆ Review Canceled"), 1, 0));
-  container.addChild(new Text(theme.fg("warning", "Reviewer was canceled."), 1, 0));
-  renderChildFailureDiagnostics(container, result.diagnostics, theme);
-  return container;
-}
-
-function renderChildFailureDiagnostics(
-  container: Container,
-  diagnostics: ChildFailureDiagnostics | undefined,
-  theme: Parameters<Parameters<ExtensionAPI["registerMessageRenderer"]>[1]>[2],
-): void {
-  if (!diagnostics) return;
-
-  container.addChild(new Spacer(1));
-  container.addChild(new Text(theme.fg("dim", "Diagnostics:"), 1, 0));
-  for (const line of formatChildFailureDiagnostics(diagnostics)) {
-    container.addChild(new Text(theme.fg("dim", line), 1, 0));
-  }
-}
-
-function actionColorName(
-  action: ReviewItem["recommended_action"],
-): "success" | "warning" | "error" {
-  switch (action) {
-    case "must-fix":
-      return "error";
-    case "should-fix":
-      return "warning";
-    case "consider":
-      return "success";
-    default:
-      return "success";
-  }
-}