@mrclrchtr/supi-review 2.6.1 → 2.8.0

package/src/ui/renderer.ts

@@ -1,12 +1,38 @@
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 import { Box, Container, Spacer, Text } from "@earendil-works/pi-tui";
-import type { ReviewFailureDebugInfo, ReviewItem, ReviewResult } from "../types.ts";
-import { formatLevel, formatLocation } from "./format-content.ts";
+import {
+  formatChildFailureCopy,
+  formatChildFailureDiagnostics,
+} from "../tool/child-failure-diagnostics.ts";
+import type {
+  BriefSynthesisRunResult,
+  ChildFailureDiagnostics,
+  ReviewItem,
+  ReviewResult,
+  ReviewSnapshot,
+} from "../types.ts";
+import { formatBriefSynthesisFailureCopy, formatLevel, formatLocation } from "./format-content.ts";
 
 /** Register the custom TUI renderer for `supi-review` messages. */
+interface BriefSynthesisFailureMessage {
+  result: Exclude<BriefSynthesisRunResult, { kind: "success" }>;
+  snapshot: ReviewSnapshot;
+  modelId: string;
+}
+
+interface ReviewMessageDetails {
+  result?: ReviewResult;
+  briefSynthesisFailure?: BriefSynthesisFailureMessage;
+}
+
 export function registerReviewRenderer(pi: ExtensionAPI): void {
   pi.registerMessageRenderer("supi-review", (message, { expanded }, theme) => {
-    const result = (message.details as { result?: ReviewResult } | undefined)?.result;
+    const details = message.details as ReviewMessageDetails | undefined;
+    if (details?.briefSynthesisFailure) {
+      return renderBriefSynthesisFailure(details.briefSynthesisFailure, theme);
+    }
+
+    const result = details?.result;
     if (!result) {
       return new Text(theme.fg("dim", "No review data"), 1, 0);
     }
@@ -26,6 +52,31 @@ export function registerReviewRenderer(pi: ExtensionAPI): void {
   });
 }
 
+function renderBriefSynthesisFailure(
+  failure: BriefSynthesisFailureMessage,
+  theme: Parameters<Parameters<ExtensionAPI["registerMessageRenderer"]>[1]>[2],
+): Container {
+  const container = new Container();
+  const title =
+    failure.result.kind === "failed"
+      ? "◆ Brief Synthesis Failed"
+      : failure.result.kind === "timeout"
+        ? "◆ Brief Synthesis Timed Out"
+        : "◆ Brief Synthesis Canceled";
+  const color = failure.result.kind === "failed" ? "error" : "warning";
+
+  container.addChild(new Text(theme.fg(color, title), 1, 0));
+  container.addChild(new Spacer(1));
+  container.addChild(new Text(theme.fg("muted", `Model: ${failure.modelId}`), 1, 0));
+  container.addChild(new Text(theme.fg("muted", `Snapshot: ${failure.snapshot.title}`), 1, 0));
+  container.addChild(new Spacer(1));
+  container.addChild(
+    new Text(theme.fg(color, formatBriefSynthesisFailureCopy(failure.result)), 1, 0),
+  );
+  renderChildFailureDiagnostics(container, failure.result.diagnostics, theme);
+  return container;
+}
+
 function renderSuccess(
   result: Extract<ReviewResult, { kind: "success" }>,
   theme: Parameters<Parameters<ExtensionAPI["registerMessageRenderer"]>[1]>[2],
@@ -160,8 +211,10 @@ function renderFailed(
   container.addChild(new Text(theme.fg("muted", `Model: ${result.modelId}`), 1, 0));
   container.addChild(new Text(theme.fg("muted", `Snapshot: ${result.snapshot.title}`), 1, 0));
   container.addChild(new Spacer(1));
-  container.addChild(new Text(theme.fg("error", result.reason), 1, 0));
-  renderFailureDebug(container, result.debug, theme);
+  container.addChild(
+    new Text(theme.fg("error", formatChildFailureCopy("reviewer", result.failureCode)), 1, 0),
+  );
+  renderChildFailureDiagnostics(container, result.diagnostics, theme);
   return container;
 }
 
@@ -175,19 +228,8 @@ function renderTimeout(
   container.addChild(new Text(theme.fg("muted", `Model: ${result.modelId}`), 1, 0));
   container.addChild(new Text(theme.fg("muted", `Snapshot: ${result.snapshot.title}`), 1, 0));
   container.addChild(new Spacer(1));
-  container.addChild(
-    new Text(
-      theme.fg("warning", `Reviewer exceeded the ${(result.timeoutMs / 1000).toFixed(0)}s timeout`),
-      1,
-      0,
-    ),
-  );
-  if (result.partialOutput) {
-    container.addChild(new Spacer(1));
-    container.addChild(new Text(theme.fg("dim", "Partial output:"), 1, 0));
-    container.addChild(new Text(theme.fg("dim", result.partialOutput.slice(0, 500)), 1, 0));
-  }
-  renderFailureDebug(container, result.debug, theme);
+  container.addChild(new Text(theme.fg("warning", "Reviewer timed out."), 1, 0));
+  renderChildFailureDiagnostics(container, result.diagnostics, theme);
   return container;
 }
 
@@ -197,41 +239,21 @@ function renderCanceled(
 ): Container {
   const container = new Container();
   container.addChild(new Text(theme.fg("warning", "◆ Review Canceled"), 1, 0));
-  renderFailureDebug(container, result.debug, theme);
+  container.addChild(new Text(theme.fg("warning", "Reviewer was canceled."), 1, 0));
+  renderChildFailureDiagnostics(container, result.diagnostics, theme);
   return container;
 }
 
-function renderFailureDebug(
+function renderChildFailureDiagnostics(
   container: Container,
-  debug: ReviewFailureDebugInfo | undefined,
+  diagnostics: ChildFailureDiagnostics | undefined,
   theme: Parameters<Parameters<ExtensionAPI["registerMessageRenderer"]>[1]>[2],
 ): void {
-  if (!debug) return;
-
-  const lines = [
-    `Turns: ${debug.turns} · Tool uses: ${debug.toolUses}`,
-    debug.tokens
-      ? `Tokens: ${debug.tokens.input} in / ${debug.tokens.output} out / ${debug.tokens.total} total`
-      : undefined,
-    debug.recentEvents && debug.recentEvents.length > 0
-      ? `Recent events: ${debug.recentEvents.join(" → ")}`
-      : undefined,
-    debug.lastAssistantStopReason
-      ? `Last assistant stop: ${debug.lastAssistantStopReason}`
-      : undefined,
-    debug.lastAssistantToolCalls && debug.lastAssistantToolCalls.length > 0
-      ? `Last assistant tools: ${debug.lastAssistantToolCalls.join(", ")}`
-      : undefined,
-    debug.lastAssistantErrorMessage
-      ? `Last assistant error: ${debug.lastAssistantErrorMessage}`
-      : undefined,
-  ].filter((line): line is string => !!line);
-
-  if (lines.length === 0) return;
+  if (!diagnostics) return;
 
   container.addChild(new Spacer(1));
-  container.addChild(new Text(theme.fg("dim", "Debug:"), 1, 0));
-  for (const line of lines) {
+  container.addChild(new Text(theme.fg("dim", "Diagnostics:"), 1, 0));
+  for (const line of formatChildFailureDiagnostics(diagnostics)) {
     container.addChild(new Text(theme.fg("dim", line), 1, 0));
   }
 }

package/src/ui/review-tool-renderer.ts

@@ -1,6 +1,10 @@
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 import { Container, Spacer, Text } from "@earendil-works/pi-tui";
 import type { PrepareAgentReviewInput, RunAgentReviewInput } from "../tool/agent-review-schemas.ts";
+import {
+  formatChildFailureCopy,
+  formatChildFailureDiagnostics,
+} from "../tool/child-failure-diagnostics.ts";
 import type {
   AgentReviewBatchDetails,
   PreparedAgentReviewDetails,
@@ -150,6 +154,7 @@ export function renderRunReviewResult(
   }
 
   if (expanded) {
+    renderReviewerDiagnostics(container, details, theme);
     container.addChild(new Spacer(1));
     for (const line of formatCritique(details.evaluation.critique)) {
       container.addChild(new Text(theme.fg("dim", line), 0, 0));
@@ -165,6 +170,28 @@ export function renderRunReviewResult(
   return container;
 }
 
+function renderReviewerDiagnostics(
+  container: Container,
+  details: AgentReviewBatchDetails,
+  theme: ReviewTheme,
+): void {
+  if (
+    !details.results.some((entry) => entry.result.kind !== "success" && entry.result.diagnostics)
+  ) {
+    return;
+  }
+
+  container.addChild(new Spacer(1));
+  container.addChild(new Text(theme.fg("accent", "Reviewer diagnostics"), 0, 0));
+  for (const { assignment, result } of details.results) {
+    if (result.kind === "success" || !result.diagnostics) continue;
+    container.addChild(new Text(theme.fg("muted", `${assignment.id}:`), 0, 0));
+    for (const line of formatChildFailureDiagnostics(result.diagnostics)) {
+      container.addChild(new Text(theme.fg("dim", line), 0, 0));
+    }
+  }
+}
+
 function renderProgress(details: AgentReviewProgressDetails, theme: ReviewTheme): Text {
   if (details.phase === "prepare") {
     return new Text(theme.fg("warning", "Synthesizing review brief…"), 0, 0);
@@ -189,7 +216,11 @@ function summarizeResult(result: AgentReviewBatchDetails["results"][number]["res
         text: `${result.output.items.length} item(s), ${result.output.overall_correctness}`,
       };
     case "failed":
-      return { icon: "✗", color: "error", text: result.reason };
+      return {
+        icon: "✗",
+        color: "error",
+        text: formatChildFailureCopy("reviewer", result.failureCode),
+      };
     case "canceled":
       return { icon: "○", color: "warning", text: "canceled" };
     case "timeout":

package/src/tool/review-debug.ts

@@ -1,124 +0,0 @@
-import type { AgentSession, AgentSessionEvent } from "@earendil-works/pi-coding-agent";
-import type { ReviewFailureDebugInfo, ReviewProgress } from "../types.ts";
-import { buildProgressTokens, extractAssistantText } from "./runner-helpers.ts";
-
-export const RECENT_EVENTS_MAX = 10;
-export const LAST_ASSISTANT_TEXT_DEBUG_MAX = 2_000;
-
-export interface LastAssistantDebugInfo {
-  text?: string;
-  stopReason?: string;
-  errorMessage?: string;
-  toolCalls?: string[];
-}
-
-export function extractLastAssistantDebugFromMessages(
-  messages: ArrayLike<Record<string, unknown>> | undefined,
-): LastAssistantDebugInfo | undefined {
-  if (!messages) return undefined;
-  for (let i = messages.length - 1; i >= 0; i--) {
-    const message = messages[i];
-    if (message?.role !== "assistant") continue;
-
-    const text = extractAssistantText(message.content);
-    const stopReason =
-      typeof message.stopReason === "string" ? (message.stopReason as string) : undefined;
-    const errorMessage =
-      typeof message.errorMessage === "string" ? (message.errorMessage as string) : undefined;
-    const toolCalls = extractAssistantToolCalls(message.content);
-
-    return {
-      text: text ? truncateText(text, LAST_ASSISTANT_TEXT_DEBUG_MAX) : undefined,
-      stopReason,
-      errorMessage,
-      toolCalls: toolCalls.length > 0 ? toolCalls : undefined,
-    };
-  }
-  return undefined;
-}
-
-export function extractLastAssistantDebug(
-  session: AgentSession,
-): LastAssistantDebugInfo | undefined {
-  return extractLastAssistantDebugFromMessages(
-    session.messages as unknown as Array<Record<string, unknown>>,
-  );
-}
-
-function extractAssistantToolCalls(content: unknown): string[] {
-  if (!Array.isArray(content)) return [];
-
-  return content
-    .map((part) => {
-      if (typeof part !== "object" || !part) return undefined;
-      const toolPart = part as { type?: unknown; name?: unknown };
-      return toolPart.type === "toolCall" && typeof toolPart.name === "string"
-        ? toolPart.name
-        : undefined;
-    })
-    .filter((name): name is string => !!name);
-}
-
-export function summarizeSessionEvent(event: AgentSessionEvent): string | undefined {
-  switch (event.type) {
-    case "message_end": {
-      const message = event.message as unknown as Record<string, unknown>;
-      if (message.role !== "assistant") return undefined;
-      const stopReason =
-        typeof message.stopReason === "string" ? String(message.stopReason) : undefined;
-      const suffix = stopReason ? `:${stopReason}` : "";
-      return `assistant:end${suffix}`;
-    }
-    case "tool_execution_start":
-      return `tool:start:${event.toolName}`;
-    case "tool_execution_end":
-      return `tool:end:${event.toolName}${event.isError ? ":error" : ""}`;
-    case "turn_end":
-      return "turn:end";
-    case "agent_end":
-      return `agent:end${event.willRetry ? ":retry" : ""}`;
-    case "agent_settled":
-      return "agent:settled";
-    case "auto_retry_start":
-      return `retry:start:${event.attempt}/${event.maxAttempts}`;
-    case "auto_retry_end":
-      return `retry:end:${event.success ? "success" : "failed"}`;
-    default:
-      return undefined;
-  }
-}
-
-export function pushRecentEvent(recentEvents: string[], summary: string | undefined): void {
-  if (!summary) return;
-  recentEvents.push(summary);
-  if (recentEvents.length > RECENT_EVENTS_MAX) {
-    recentEvents.splice(0, recentEvents.length - RECENT_EVENTS_MAX);
-  }
-}
-
-export interface BuildFailureDebugInput {
-  progress: ReviewProgress;
-  session: AgentSession;
-  recentEvents: string[];
-}
-
-export function buildFailureDebug(input: BuildFailureDebugInput): ReviewFailureDebugInfo {
-  input.progress.tokens = buildProgressTokens(() => input.session.getSessionStats());
-  const lastAssistant = extractLastAssistantDebug(input.session);
-
-  return {
-    turns: input.progress.turns,
-    toolUses: input.progress.toolUses,
-    tokens: input.progress.tokens,
-    recentEvents: input.recentEvents.length > 0 ? [...input.recentEvents] : undefined,
-    lastAssistantText: lastAssistant?.text,
-    lastAssistantStopReason: lastAssistant?.stopReason,
-    lastAssistantErrorMessage: lastAssistant?.errorMessage,
-    lastAssistantToolCalls: lastAssistant?.toolCalls,
-  };
-}
-
-function truncateText(text: string, maxLen: number): string {
-  if (text.length <= maxLen) return text;
-  return `${text.slice(0, maxLen)}... (${text.length - maxLen} more chars)`;
-}