@mrclrchtr/supi-review 0.1.0

package/src/target-resolution.ts

@@ -0,0 +1,102 @@
+import {
+  getCommitFileNames,
+  getCommitShow,
+  getDiff,
+  getDiffFileNames,
+  getMergeBase,
+  getUncommittedDiff,
+  getUncommittedFileNames,
+} from "./git.ts";
+import type { ReviewResult, ReviewTarget } from "./types.ts";
+
+interface TargetResolutionContext {
+  cwd: string;
+}
+
+type TargetResolutionSuccess = {
+  kind: "success";
+  target: ReviewTarget;
+};
+
+export async function resolveGitTarget(
+  target: ReviewTarget,
+  ctx: TargetResolutionContext,
+): Promise<TargetResolutionSuccess | ReviewResult> {
+  switch (target.type) {
+    case "base-branch":
+      return resolveBaseBranchTarget(target, ctx);
+    case "uncommitted":
+      return resolveUncommittedTarget(target, ctx);
+    case "commit":
+      return resolveCommitTarget(target, ctx);
+    case "custom":
+      return { kind: "success", target };
+  }
+}
+
+async function resolveBaseBranchTarget(
+  target: Extract<ReviewTarget, { type: "base-branch" }>,
+  ctx: TargetResolutionContext,
+): Promise<TargetResolutionSuccess | ReviewResult> {
+  if (target.diff) {
+    return { kind: "success", target };
+  }
+
+  const baseSha = await getMergeBase(ctx.cwd, target.branch);
+  if (!baseSha) {
+    return { kind: "failed", reason: `No merge base found for ${target.branch}`, target };
+  }
+
+  const [diff, changedFiles] = await Promise.all([
+    getDiff(ctx.cwd, baseSha),
+    resolveChangedFiles(target.changedFiles, () => getDiffFileNames(ctx.cwd, baseSha)),
+  ]);
+
+  return { kind: "success", target: { ...target, diff, changedFiles } };
+}
+
+async function resolveUncommittedTarget(
+  target: Extract<ReviewTarget, { type: "uncommitted" }>,
+  ctx: TargetResolutionContext,
+): Promise<TargetResolutionSuccess | ReviewResult> {
+  if (target.diff) {
+    return { kind: "success", target };
+  }
+
+  const [diff, changedFiles] = await Promise.all([
+    getUncommittedDiff(ctx.cwd),
+    resolveChangedFiles(target.changedFiles, () => getUncommittedFileNames(ctx.cwd)),
+  ]);
+
+  if (!diff) {
+    return { kind: "failed", reason: "No uncommitted changes", target };
+  }
+
+  return { kind: "success", target: { ...target, diff, changedFiles } };
+}
+
+async function resolveCommitTarget(
+  target: Extract<ReviewTarget, { type: "commit" }>,
+  ctx: TargetResolutionContext,
+): Promise<TargetResolutionSuccess | ReviewResult> {
+  if (target.show) {
+    return { kind: "success", target };
+  }
+
+  const [show, changedFiles] = await Promise.all([
+    getCommitShow(ctx.cwd, target.sha),
+    resolveChangedFiles(target.changedFiles, () => getCommitFileNames(ctx.cwd, target.sha)),
+  ]);
+
+  return {
+    kind: "success",
+    target: { ...target, show, changedFiles },
+  };
+}
+
+function resolveChangedFiles(
+  changedFiles: string[] | undefined,
+  load: () => Promise<string[]>,
+): Promise<string[]> {
+  return changedFiles ? Promise.resolve(changedFiles) : load();
+}

package/src/types.ts

@@ -0,0 +1,49 @@
+// TypeScript interfaces for structured review output.
+
+export interface ReviewLineRange {
+  start: number;
+  end: number;
+}
+
+export interface ReviewCodeLocation {
+  absolute_file_path: string;
+  line_range: ReviewLineRange;
+}
+
+export interface ReviewFinding {
+  title: string;
+  body: string;
+  confidence_score: number;
+  priority: 0 | 1 | 2 | 3;
+  code_location: ReviewCodeLocation;
+}
+
+export interface ReviewOutputEvent {
+  findings: ReviewFinding[];
+  overall_correctness: string;
+  overall_explanation: string;
+  overall_confidence_score: number;
+}
+
+export type ReviewTarget =
+  | { type: "base-branch"; branch: string; diff: string; changedFiles?: string[] }
+  | { type: "uncommitted"; diff: string; changedFiles?: string[] }
+  | { type: "commit"; sha: string; show: string; changedFiles?: string[] }
+  | { type: "custom"; instructions: string; changedFiles?: string[] };
+
+export interface ReviewSettings {
+  reviewModel: string;
+  maxDiffBytes: number;
+  autoFix: boolean;
+}
+
+export type ReviewResult =
+  | { kind: "success"; output: ReviewOutputEvent; target: ReviewTarget }
+  | { kind: "failed"; reason: string; target: ReviewTarget }
+  | { kind: "canceled"; target: ReviewTarget }
+  | {
+      kind: "timeout";
+      target: ReviewTarget;
+      timeoutMs: number;
+      partialOutput?: string;
+    };

package/src/ui.ts

@@ -0,0 +1,116 @@
+import { DynamicBorder, type ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { Container, type SelectItem, SelectList, Text } from "@earendil-works/pi-tui";
+import { getLocalBranches, getRecentCommits } from "./git.ts";
+
+export type Preset = "base-branch" | "uncommitted" | "commit" | "custom";
+
+interface SelectFromListOptions<T> {
+  items: SelectItem[];
+  title: string;
+  maxHeight: number;
+  onSelect: (item: SelectItem) => T | undefined;
+  initialIndex?: number;
+}
+
+/**
+ * Shared TUI helper: renders a SelectList inside a bordered container with
+ * standard theme colors, keyboard hints, and cancel-on-escape behavior.
+ */
+function selectFromList<T>(
+  ctx: ExtensionContext,
+  options: SelectFromListOptions<T>,
+): Promise<T | undefined> {
+  const { items, title, maxHeight, onSelect, initialIndex } = options;
+  return ctx.ui.custom<T | undefined>((tui, theme, _kb, done) => {
+    const container = new Container();
+    container.addChild(new DynamicBorder((s: string) => theme.fg("accent", s)));
+    container.addChild(new Text(theme.fg("accent", title), 1, 0));
+
+    const selectList = new SelectList(items, Math.min(items.length, maxHeight), {
+      selectedPrefix: (t) => theme.fg("accent", t),
+      selectedText: (t) => theme.fg("accent", t),
+      description: (t) => theme.fg("muted", t),
+      scrollInfo: (t) => theme.fg("dim", t),
+      noMatch: (t) => theme.fg("warning", t),
+    });
+    if (initialIndex !== undefined) {
+      selectList.setSelectedIndex(initialIndex);
+    }
+    selectList.onSelect = (item) => done(onSelect(item));
+    selectList.onCancel = () => done(undefined);
+    container.addChild(selectList);
+    container.addChild(new Text(theme.fg("dim", "↑↓ navigate • enter select • esc cancel"), 1, 0));
+    container.addChild(new DynamicBorder((s: string) => theme.fg("accent", s)));
+
+    return {
+      render: (w) => container.render(w),
+      invalidate: () => container.invalidate(),
+      handleInput: (data) => {
+        selectList.handleInput(data);
+        tui.requestRender();
+      },
+    };
+  });
+}
+
+export async function selectPreset(ctx: ExtensionContext): Promise<Preset | undefined> {
+  return selectFromList(ctx, {
+    items: [
+      { value: "base-branch", label: "Review against a base branch" },
+      { value: "uncommitted", label: "Review uncommitted changes" },
+      { value: "commit", label: "Review a commit" },
+      { value: "custom", label: "Custom review instructions" },
+    ],
+    title: "Select review target",
+    maxHeight: 10,
+    onSelect: (item) => item.value as Preset,
+  });
+}
+
+export async function selectAutoFix(
+  ctx: ExtensionContext,
+  defaultValue: boolean,
+): Promise<boolean | undefined> {
+  return selectFromList(ctx, {
+    items: [
+      { value: "true", label: "Yes — fix all findings" },
+      { value: "false", label: "No — review only" },
+    ],
+    title: "Auto-fix after review?",
+    maxHeight: 2,
+    onSelect: (item) => item.value === "true",
+    initialIndex: defaultValue ? 0 : 1,
+  });
+}
+
+export async function selectBranch(ctx: ExtensionContext): Promise<string | undefined> {
+  const branches = await getLocalBranches(ctx.cwd);
+  if (branches.length === 0) {
+    ctx.ui.notify("No local branches found", "warning");
+    return undefined;
+  }
+  return selectFromList(ctx, {
+    items: branches.map((b) => ({ value: b, label: b })),
+    title: "Select base branch",
+    maxHeight: 15,
+    onSelect: (item) => item.value,
+  });
+}
+
+export async function selectCommit(ctx: ExtensionContext): Promise<string | undefined> {
+  const commits = await getRecentCommits(ctx.cwd, 30);
+  if (commits.length === 0) {
+    ctx.ui.notify("No recent commits found", "warning");
+    return undefined;
+  }
+  return selectFromList(ctx, {
+    items: commits.map((c) => ({
+      value: c.sha,
+      label: `${c.sha.slice(0, 7)}  ${c.subject}`,
+      description: c.sha,
+    })),
+    title: "Select commit to review",
+    maxHeight: 15,
+    onSelect: (item) => item.value,
+  });
+}