@mrclrchtr/supi-prompt-suggestions 11.2.0 → 11.4.0

package/CHANGELOG.md

@@ -0,0 +1,9 @@
+# Changelog
+
+## [11.4.0]
+
+- Suggestions now predict your next message, preferring commands such as "push it" over questions, instead of continuing in the assistant's voice. When the assistant asked a question, the suggestion answers it as a command.
+
+## [11.3.0]
+
+- Added package-specific release notes for model-powered prompt suggestions.

package/node_modules/@mrclrchtr/supi-core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mrclrchtr/supi-core",
-  "version": "11.2.0",
+  "version": "11.4.0",
   "description": "Shared settings, configuration, reporting, and session infrastructure",
   "license": "MIT",
   "repository": {

package/node_modules/@mrclrchtr/supi-core/src/child-web-tools.ts

@@ -0,0 +1,110 @@
+// Session-provided Web tools for SuPi child sessions (Agent Runs and Reviewer Sessions).
+//
+// The loaded supi-web extension answers a synchronous request on the parent event bus.
+// Consumers never depend on supi-web; when it is absent or provides no tools, the
+// request returns undefined and the child simply lacks Web tools.
+
+import type { ExtensionAPI, ExtensionFactory } from "@earendil-works/pi-coding-agent";
+
+/** Web tools that child sessions may receive when the containing session provides them. */
+export const CHILD_WEB_TOOL_NAMES = [
+  "web_fetch_md",
+  "web_search",
+  "web_docs_search",
+  "web_docs_fetch",
+] as const;
+
+/** One session-provided Web tool name. */
+export type ChildWebToolName = (typeof CHILD_WEB_TOOL_NAMES)[number];
+
+/**
+ * Web tools currently callable in the containing session plus a child-only extension
+ * factory that registers them. The factory must not capture the parent session; it may
+ * capture plain data such as the containing session's configuration directory.
+ */
+export interface ChildWebToolProvision {
+  readonly toolNames: readonly ChildWebToolName[];
+  /** Register the requested subset of `toolNames` in a child session. */
+  readonly createFactory: (toolNames: readonly ChildWebToolName[]) => ExtensionFactory;
+}
+
+/** Plain containing-session data supplied with a child Web tool request. */
+export interface ChildWebToolsRequestContext {
+  /**
+   * Working directory whose SuPi configuration governs Web settings such as Firecrawl.
+   * Children with a different cwd (for example a frozen Review Workspace) keep this policy.
+   */
+  readonly configCwd: string;
+}
+
+type EventBusLike = Pick<ExtensionAPI["events"], "on" | "emit">;
+
+const REQUEST_CHANNEL = "supi:child-web-tools:request";
+const RESPONSE_CHANNEL = "supi:child-web-tools:response";
+
+interface ChildWebToolsRequest extends ChildWebToolsRequestContext {
+  readonly requestId: string;
+}
+
+interface ChildWebToolsResponse {
+  readonly requestId: string;
+  readonly provision: ChildWebToolProvision;
+}
+
+let nextRequestId = 0;
+
+/**
+ * Answer child Web tool requests on the parent event bus. The callback must be synchronous
+ * because Pi's event bus does not await listeners. Returns an unsubscribe function.
+ */
+export function provideChildWebTools(
+  events: EventBusLike,
+  resolve: (context: ChildWebToolsRequestContext) => ChildWebToolProvision | undefined,
+): () => void {
+  return events.on(REQUEST_CHANNEL, (data) => {
+    const request = data as Partial<ChildWebToolsRequest> | undefined;
+    if (typeof request?.requestId !== "string" || typeof request.configCwd !== "string") return;
+    const { requestId, configCwd } = request;
+    const provision = resolve({ configCwd });
+    if (!provision || provision.toolNames.length === 0) return;
+    events.emit(RESPONSE_CHANNEL, { requestId, provision } satisfies ChildWebToolsResponse);
+  });
+}
+
+/** Capture the Web tools the containing session currently provides, if any. */
+export function requestChildWebTools(
+  events: EventBusLike,
+  context: ChildWebToolsRequestContext,
+): ChildWebToolProvision | undefined {
+  const requestId = `child-web-${process.pid}-${++nextRequestId}`;
+  let provision: ChildWebToolProvision | undefined;
+  const unsubscribe = events.on(RESPONSE_CHANNEL, (data) => {
+    const response = data as Partial<ChildWebToolsResponse> | undefined;
+    if (response?.requestId === requestId && response.provision) provision = response.provision;
+  });
+  try {
+    events.emit(REQUEST_CHANNEL, { requestId, ...context } satisfies ChildWebToolsRequest);
+  } finally {
+    unsubscribe();
+  }
+  return provision;
+}
+
+/**
+ * Return the Web tools callable in a session under Pi's exposure rules: active `direct`
+ * tools, plus registered `codemode` and `deferred` tools. `model-only` and `hidden`
+ * tools are not callable.
+ */
+export function callableChildWebToolNames(
+  pi: Pick<ExtensionAPI, "getAllTools" | "getActiveTools">,
+): ChildWebToolName[] {
+  const active = new Set(pi.getActiveTools());
+  const exposures = new Map(
+    pi.getAllTools().map((tool) => [tool.name, tool.exposure ?? "direct"] as const),
+  );
+  return CHILD_WEB_TOOL_NAMES.filter((name) => {
+    const exposure = exposures.get(name);
+    if (exposure === "direct") return active.has(name);
+    return exposure === "codemode" || exposure === "deferred";
+  });
+}

package/node_modules/@mrclrchtr/supi-core/src/session.ts

@@ -1,5 +1,16 @@
 // supi-core session domain — session utilities and registries.
 
+export type {
+  ChildWebToolName,
+  ChildWebToolProvision,
+  ChildWebToolsRequestContext,
+} from "./child-web-tools.ts";
+export {
+  CHILD_WEB_TOOL_NAMES,
+  callableChildWebToolNames,
+  provideChildWebTools,
+  requestChildWebTools,
+} from "./child-web-tools.ts";
 export { createRegistry, createSessionStateRegistry } from "./registry-utils.ts";
 export type {
   SessionCapabilitySkill,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mrclrchtr/supi-prompt-suggestions",
-  "version": "11.2.0",
+  "version": "11.4.0",
   "description": "Optional model-powered ghost-text prompt suggestions",
   "license": "MIT",
   "repository": {
@@ -27,6 +27,7 @@
   ],
   "type": "module",
   "files": [
+    "CHANGELOG.md",
     "src/**/*.ts",
     "!__tests__"
   ],
@@ -48,7 +49,7 @@
     "video": "https://raw.githubusercontent.com/mrclrchtr/supi/main/packages/supi-prompt-suggestions/assets/demo.mp4"
   },
   "dependencies": {
-    "@mrclrchtr/supi-core": "11.2.0"
+    "@mrclrchtr/supi-core": "11.4.0"
   },
   "bundledDependencies": [
     "@mrclrchtr/supi-core"

package/src/generation/client.ts

@@ -14,28 +14,38 @@ import {
 export const GENERATION_TIMEOUT_MS = 20_000;
 
 /**
- * System prompt instructs the model to suggest a follow-up user message
- * (question, answer, or directive) or return the NO_SUGGESTION sentinel
- * when none is useful.
+ * System prompt instructs the model to predict the user's next message,
+ * preferably an imperative command to the assistant, or return the
+ * NO_SUGGESTION sentinel when none is useful.
  *
  * The model receives no PI, SuPi, project, or conversation context —
  * only the last assistant message text is sent.
  */
-const SYSTEM_PROMPT =
-  "You suggest follow-up messages for a coding assistant conversation. " +
-  "Given the assistant's last message, write a single line the user would type next. " +
-  "It must be a direct question, answer, or directive — nothing else. " +
-  "If the assistant asks for a decision, suggest a concise, specific answer to that decision, not the action that would follow from it. " +
-  "When answering yes/no, include the relevant constraint or option text when present. " +
-  "Do NOT include greetings, thank-yous, politeness, or conversational filler. " +
-  "If there is no useful follow-up, respond with exactly the word NO_SUGGESTION and nothing else. " +
-  "Keep suggestions under 240 characters.";
+const SYSTEM_PROMPT = `You predict the next message a developer types to their coding assistant.
+You receive the assistant's last message. Write the single line the USER would send next.
+
+Rules:
+- Write as the user talking to the assistant. Never write in the assistant's voice and never ask the user anything (no "Should I…?", "Do you want…?", "Shall we…?").
+- Prefer a short imperative command that moves the work forward: "Push the branch.", "Run the tests.", "Fix the lint errors."
+- If the assistant asks a question or offers options, answer it as a command that picks the most sensible option, e.g. "Yes, push it to origin." or "Use option 2."
+- Name concrete targets from the message (branch, file, command, option) when they make the command unambiguous.
+- Ask a question only when the user clearly needs information before deciding.
+- No greetings, thanks, politeness, explanations, quotes, or prefixes like "Suggestion:".
+- Keep it under 120 characters.
+- If no useful next message exists, respond with exactly NO_SUGGESTION.
+
+Examples (assistant message → your output):
+"Committed as abc123. Not pushed: the branch is 3 commits ahead of origin." → Push the branch to origin.
+"Should I also update the README, or keep the change code-only?" → Update the README too.
+"Two options: A) add a cache, B) batch the requests. Which do you prefer?" → Go with B and batch the requests.
+
+Output only the message text.`;
 
 // ── Prompt building ────────────────────────────────────────────────────────
 
 /** Format the tail text as a completion prompt. */
 export function buildPrompt(tail: string): string {
-  return `<assistant_message>\n${tail}\n</assistant_message>\n\nSuggestion:`;
+  return `<assistant_message>\n${tail}\n</assistant_message>\n\nUser's next message:`;
 }
 
 // ── Types ───────────────────────────────────────────────────────────────────