@mrclrchtr/supi-lsp 1.7.0 → 1.9.0

package/src/tool/tool-specs.ts

@@ -1,81 +1,59 @@
-import { StringEnum } from "@earendil-works/pi-ai";
 import { type TSchema, Type } from "typebox";
 import type { ServerCapabilities } from "../config/types.ts";
 import type { SessionLspService } from "../session/service-registry.ts";
 import {
+  LSP_CODE_ACTIONS_TOOL,
+  LSP_DEFINITION_TOOL,
   LSP_DIAGNOSTICS_TOOL,
   LSP_DOCUMENT_SYMBOLS_TOOL,
-  LSP_LOOKUP_TOOL,
+  LSP_HOVER_TOOL,
+  LSP_IMPLEMENTATION_TOOL,
   LSP_RECOVER_TOOL,
-  LSP_REFACTOR_TOOL,
+  LSP_REFERENCES_TOOL,
+  LSP_RENAME_TOOL,
   LSP_WORKSPACE_SYMBOLS_TOOL,
   type LspToolName,
 } from "./names.ts";
 import {
+  executeCodeActions,
+  executeDefinition,
   executeDiagnostics,
   executeDocumentSymbols,
-  executeLookup,
+  executeHover,
+  executeImplementation,
   executeRecover,
-  executeRefactor,
+  executeReferences,
+  executeRename,
   executeWorkspaceSymbols,
 } from "./service-actions.ts";
 
-const FileParam = Type.String({ description: "File path (relative or absolute)" });
-const LineParam = Type.Number({ description: "1-based line number", minimum: 1 });
-const CharacterParam = Type.Number({ description: "1-based column number", minimum: 1 });
-const QueryParam = Type.String({ description: "Symbol query string" });
-const NewNameParam = Type.String({ description: "New name for rename" });
+// Shared parameter builders
+const FileParam = Type.String({ description: "File path" });
+const LineParam = Type.Number({ description: "1-based line", minimum: 1 });
+const CharacterParam = Type.Number({ description: "1-based column", minimum: 1 });
+const QueryParam = Type.String({ description: "Symbol query" });
+const NewNameParam = Type.String({ description: "New name" });
 
-export const LSP_LOOKUP_KIND_NAMES = [
-  "hover",
-  "definition",
-  "references",
-  "implementation",
-] as const;
-export const LSP_REFACTOR_KIND_NAMES = ["rename", "code_actions"] as const;
-
-const LookupKindEnum = StringEnum(LSP_LOOKUP_KIND_NAMES);
-const RefactorKindEnum = StringEnum(LSP_REFACTOR_KIND_NAMES);
-
-const LookupParameters = Type.Object(
-  {
-    kind: LookupKindEnum,
-    file: FileParam,
-    line: LineParam,
-    character: CharacterParam,
-  },
+// Parameter schemas
+const PositionParams = Type.Object(
+  { file: FileParam, line: LineParam, character: CharacterParam },
   { additionalProperties: false },
 );
 
-const DocumentSymbolsParameters = Type.Object(
-  {
-    file: FileParam,
-  },
+const RenameParams = Type.Object(
+  { file: FileParam, line: LineParam, character: CharacterParam, newName: NewNameParam },
   { additionalProperties: false },
 );
 
+const DocumentSymbolsParameters = Type.Object({ file: FileParam }, { additionalProperties: false });
+
 const WorkspaceSymbolsParameters = Type.Object(
-  {
-    query: QueryParam,
-  },
+  { query: QueryParam },
   { additionalProperties: false },
 );
 
 const DiagnosticsParameters = Type.Object(
-  {
-    file: Type.Optional(FileParam),
-  },
-  { additionalProperties: false },
-);
-
-const RefactorParameters = Type.Object(
-  {
-    kind: RefactorKindEnum,
-    file: FileParam,
-    line: LineParam,
-    character: CharacterParam,
-    newName: Type.Optional(NewNameParam),
-  },
+  { file: Type.Optional(FileParam) },
   { additionalProperties: false },
 );
 
@@ -89,36 +67,57 @@ export interface LspToolDefinitionSpec {
   basePromptGuidelines: string[];
   parameters: TSchema;
   run: (service: SessionLspService, cwd: string, params: unknown) => Promise<string>;
-  includeCoverageGuidelines?: boolean;
 }
 
 export const LSP_TOOL_DEFINITION_SPECS = [
   {
-    name: LSP_LOOKUP_TOOL,
-    label: "LSP Lookup",
-    description:
-      "Language Server Protocol lookup tool — semantic hover, definition, references, and implementation for supported files. Use lsp_lookup when you know the file and 1-based line/character position and need semantic drill-down rather than text search.",
-    promptSnippet:
-      "lsp_lookup — semantic hover/definition/references/implementation at a known file position",
+    name: LSP_HOVER_TOOL,
+    label: "LSP Hover",
+    description: "Semantic hover/type info at a file position.",
+    promptSnippet: "lsp_hover — hover/type info",
+    basePromptGuidelines: ["Use lsp_hover(file,line,character) for semantic hover/type info."],
+    parameters: PositionParams,
+    run: (service, cwd, params) =>
+      executeHover(service, cwd, params as Parameters<typeof executeHover>[2]),
+  },
+  {
+    name: LSP_DEFINITION_TOOL,
+    label: "LSP Definition",
+    description: "Jump to a symbol definition at a file position.",
+    promptSnippet: "lsp_definition — jump to definition",
     basePromptGuidelines: [
-      'Use lsp_lookup with `kind: "hover"` for semantic type or symbol information at a known `file`, `line`, and `character`.',
-      'Use lsp_lookup with `kind: "definition"`, `"references"`, or `"implementation"` for semantic navigation at a known position.',
-      "Use lsp_lookup after code_brief, code_map, or tree_sitter has already narrowed the target file and position.",
+      "Use lsp_definition(file,line,character) to jump to a symbol definition.",
     ],
-    parameters: LookupParameters,
+    parameters: PositionParams,
+    run: (service, cwd, params) =>
+      executeDefinition(service, cwd, params as Parameters<typeof executeDefinition>[2]),
+  },
+  {
+    name: LSP_REFERENCES_TOOL,
+    label: "LSP References",
+    description: "Find semantic references to a symbol at a file position.",
+    promptSnippet: "lsp_references — semantic references",
+    basePromptGuidelines: ["Use lsp_references(file,line,character) for semantic references."],
+    parameters: PositionParams,
     run: (service, cwd, params) =>
-      executeLookup(service, cwd, params as Parameters<typeof executeLookup>[2]),
-    includeCoverageGuidelines: true,
+      executeReferences(service, cwd, params as Parameters<typeof executeReferences>[2]),
+  },
+  {
+    name: LSP_IMPLEMENTATION_TOOL,
+    label: "LSP Implementation",
+    description: "Find implementations from a file position.",
+    promptSnippet: "lsp_implementation — implementations",
+    basePromptGuidelines: ["Use lsp_implementation(file,line,character) for implementations."],
+    parameters: PositionParams,
+    run: (service, cwd, params) =>
+      executeImplementation(service, cwd, params as Parameters<typeof executeImplementation>[2]),
   },
   {
     name: LSP_DOCUMENT_SYMBOLS_TOOL,
     label: "LSP Document Symbols",
-    description:
-      "Language Server Protocol document symbols tool — list semantic declarations in one supported file. Use lsp_document_symbols when you need a symbol-aware outline rather than raw text structure.",
-    promptSnippet: "lsp_document_symbols — semantic declarations for one supported file",
-    basePromptGuidelines: [
-      "Use lsp_document_symbols(file) for semantic declarations in one supported file.",
-    ],
+    description: "List semantic declarations in one file.",
+    promptSnippet: "lsp_document_symbols — one-file semantic outline",
+    basePromptGuidelines: ["Use lsp_document_symbols(file) for one-file semantic declarations."],
     parameters: DocumentSymbolsParameters,
     run: (service, cwd, params) =>
       executeDocumentSymbols(service, cwd, params as Parameters<typeof executeDocumentSymbols>[2]),
@@ -126,12 +125,9 @@ export const LSP_TOOL_DEFINITION_SPECS = [
   {
     name: LSP_WORKSPACE_SYMBOLS_TOOL,
     label: "LSP Workspace Symbols",
-    description:
-      "Language Server Protocol workspace symbols tool — semantic symbol-name lookup across the current project. Use lsp_workspace_symbols to find declarations by name before opening a specific file.",
-    promptSnippet: "lsp_workspace_symbols — semantic symbol-name lookup across the project",
-    basePromptGuidelines: [
-      "Use lsp_workspace_symbols(query) for semantic symbol-name lookup across the current project.",
-    ],
+    description: "Find symbol declarations by name across the project.",
+    promptSnippet: "lsp_workspace_symbols — project symbol lookup",
+    basePromptGuidelines: ["Use lsp_workspace_symbols(query) to find declarations by name."],
     parameters: WorkspaceSymbolsParameters,
     run: (service, cwd, params) =>
       executeWorkspaceSymbols(
@@ -143,38 +139,42 @@ export const LSP_TOOL_DEFINITION_SPECS = [
   {
     name: LSP_DIAGNOSTICS_TOOL,
     label: "LSP Diagnostics",
-    description:
-      "Language Server Protocol diagnostics tool — current diagnostics for one file or a workspace summary. Use lsp_diagnostics for semantic compiler or language-server issues instead of guessing from text alone.",
-    promptSnippet: "lsp_diagnostics — current diagnostics for one file or the workspace",
-    basePromptGuidelines: [
-      "Use lsp_diagnostics(file?) when you need current diagnostics for one file or a workspace-level summary.",
-    ],
+    description: "Show semantic diagnostics for one file or the workspace.",
+    promptSnippet: "lsp_diagnostics — semantic diagnostics",
+    basePromptGuidelines: ["Use lsp_diagnostics(file?) for semantic diagnostics."],
     parameters: DiagnosticsParameters,
     run: (service, cwd, params) =>
       executeDiagnostics(service, cwd, params as Parameters<typeof executeDiagnostics>[2]),
   },
   {
-    name: LSP_REFACTOR_TOOL,
-    label: "LSP Refactor",
-    description:
-      "Language Server Protocol refactor tool — semantic rename planning and code actions at a known file position. Use lsp_refactor when you need language-server-backed edits or quick-fix suggestions.",
-    promptSnippet: "lsp_refactor — semantic rename planning and code actions at a known position",
+    name: LSP_RENAME_TOOL,
+    label: "LSP Rename",
+    description: "Plan a semantic rename from a file position.",
+    promptSnippet: "lsp_rename — semantic rename plan",
     basePromptGuidelines: [
-      'Use lsp_refactor with `kind: "rename"` for semantic rename planning at a known `file`, `line`, and `character`.',
-      'Use lsp_refactor with `kind: "code_actions"` for semantic fixes or refactors at a known position.',
+      "Use lsp_rename(file,line,character,newName) to plan a semantic rename.",
     ],
-    parameters: RefactorParameters,
+    parameters: RenameParams,
+    run: (service, cwd, params) =>
+      executeRename(service, cwd, params as Parameters<typeof executeRename>[2]),
+  },
+  {
+    name: LSP_CODE_ACTIONS_TOOL,
+    label: "LSP Code Actions",
+    description: "List code fixes/refactors at a file position.",
+    promptSnippet: "lsp_code_actions — quick fixes/refactors",
+    basePromptGuidelines: ["Use lsp_code_actions(file,line,character) for quick fixes/refactors."],
+    parameters: PositionParams,
     run: (service, cwd, params) =>
-      executeRefactor(service, cwd, params as Parameters<typeof executeRefactor>[2]),
+      executeCodeActions(service, cwd, params as Parameters<typeof executeCodeActions>[2]),
   },
   {
     name: LSP_RECOVER_TOOL,
     label: "LSP Recover",
-    description:
-      "Language Server Protocol recover tool — refresh diagnostics after workspace changes and stale language-server state. Use lsp_recover when new files, generated types, or config updates leave diagnostics out of sync.",
-    promptSnippet: "lsp_recover — refresh stale diagnostics after workspace changes",
+    description: "Refresh LSP diagnostics after workspace changes.",
+    promptSnippet: "lsp_recover — refresh stale diagnostics",
     basePromptGuidelines: [
-      "Use lsp_recover() when diagnostics look stale after workspace-level changes or generated-file updates.",
+      "Use lsp_recover() when diagnostics look stale after workspace changes.",
     ],
     parameters: RecoverParameters,
     run: (service) => executeRecover(service),

package/src/utils.ts

@@ -7,7 +7,7 @@ export {
   fileToUri,
   resolveToolPath as resolveSessionPath,
   uriToFile,
-} from "@mrclrchtr/supi-core/api";
+} from "@mrclrchtr/supi-core/path";
 
 // ── Language ID Detection ─────────────────────────────────────────────
 

package/src/workspace-change.ts

@@ -0,0 +1,40 @@
+// Workspace change tracking helpers shared by handlers/session-lifecycle.ts,
+// handlers/diagnostic-injection.ts, and handlers/workspace-recovery.ts.
+
+import * as path from "node:path";
+import { clearTsconfigCache } from "./config/tsconfig-scope.ts";
+import type { FileEvent } from "./config/types.ts";
+import { syncWorkspaceSentinelSnapshot } from "./diagnostics/workspace-sentinels.ts";
+import type { LspRuntimeState } from "./session/lsp-state.ts";
+
+/** Update the state's workspace-change tracking fields after a file modification. */
+export function markWorkspaceChange(state: LspRuntimeState): void {
+  state.lastWorkspaceChangeAt = Date.now();
+  state.staleSuspected = true;
+  state.lastDiagnosticsFingerprint = null;
+  state.currentContextToken = null;
+}
+
+/** Notify the LSP manager about file changes and reset pull-diagnostic state. */
+export function softRecoverWorkspaceChanges(state: LspRuntimeState, changes: FileEvent[]): boolean {
+  if (!state.manager || changes.length === 0) return false;
+
+  clearTsconfigCache();
+  state.manager.clearAllPullResultIds();
+  state.manager.notifyWorkspaceFileChanges(changes);
+  markWorkspaceChange(state);
+  return true;
+}
+
+/** Sync the sentinel-file snapshot and recover from any detected changes. */
+export function refreshWorkspaceSentinels(state: LspRuntimeState, cwd: string): boolean {
+  const { snapshot, changes } = syncWorkspaceSentinelSnapshot(cwd, state.sentinelSnapshot);
+  state.sentinelSnapshot = snapshot;
+  return softRecoverWorkspaceChanges(state, changes);
+}
+
+/** Check whether a given file path's extension suggests tsconfig-scope invalidation. */
+export function shouldInvalidateTsconfigScopeCache(filePath: string): boolean {
+  const ext = path.extname(filePath).toLowerCase();
+  return ext === ".json" || ext === ".jsonc";
+}

package/node_modules/@mrclrchtr/supi-core/src/extension.ts

@@ -1 +0,0 @@
-export { registerSettingsCommand as default } from "./settings/settings-command.ts";