@mrclrchtr/supi-code-intelligence 3.2.0 → 4.1.0

package/src/tool/refactor-plan/orchestrate.ts

@@ -1,355 +0,0 @@
-/**
- * Refactor plan orchestration use-case.
- *
- * Handles operation normalization, target resolution, provider-based
- * refactor planning, plan storage, and safety validation. Returns a
- * rendered CodeIntelResult with a stored planId for later application.
- *
- * Extracted from execute-refactor-plan.ts as part of the thin-executor
- * normalization.
- */
-
-import {
-  normalizeRefactorOperation,
-  type RefactorOperation,
-  type RefactorResult,
-  type SemanticProvider,
-  type SourceRange,
-} from "@mrclrchtr/supi-code-runtime/api";
-import { toLspPosition } from "@mrclrchtr/supi-lsp/api";
-import { validateEdit } from "../../analysis/refactor/safety.ts";
-import { normalizePath } from "../../analysis/search/ripgrep.ts";
-import {
-  computeFileFingerprint,
-  generatePlanId,
-  type RefactorPlan,
-} from "../../session/refactor-plans.ts";
-import type { WorkspaceCodeIntelligenceSession } from "../../session/session.ts";
-import type { CodeIntelResult } from "../../types/index.ts";
-import { unavailableSearchDetails } from "../infra/error-results.ts";
-import { assembleRefactorPlanDetails } from "../result/refactor.ts";
-import { renderRefactorPlanResult } from "./markdown.ts";
-
-type CanonicalRefactorOperation = Exclude<RefactorOperation, "rename">;
-
-export interface RefactorPlanInput {
-  targetId?: string;
-  operation: string;
-  file?: string;
-  line?: number;
-  character?: number;
-  range?: {
-    start: { line: number; character: number };
-    end: { line: number; character: number };
-  };
-  newName?: string;
-}
-
-export interface RefactorPlanDeps {
-  cwd: string;
-  session: WorkspaceCodeIntelligenceSession;
-  /** Semantic provider for refactor planning. */
-  provider: SemanticProvider | null;
-}
-
-/**
- * Execute the refactor plan use-case.
- *
- * Returns a CodeIntelResult with a stored planId on success, or an
- * error result on invalid input or unavailable provider.
- */
-export async function executeRefactorPlan(
-  input: RefactorPlanInput,
-  deps: RefactorPlanDeps,
-): Promise<CodeIntelResult> {
-  const normalizedOperation = normalizeRequestedOperation(input.operation);
-  if (normalizedOperation.kind === "error") {
-    return {
-      content: normalizedOperation.message,
-      details: unavailableSearchDetails(null, [
-        'Use one of: "rename", "rename_symbol", "extract_function", "extract_variable"',
-      ]),
-    };
-  }
-  const operation = normalizedOperation.operation;
-
-  const target = await resolveRefactorTarget(input, operation, deps.session);
-  if ("content" in target) return target;
-
-  const resolvedFile = normalizePath(target.file, deps.cwd);
-  const position = toLspPosition(target.line, target.character);
-
-  const refactorResult = await planRefactorWithProvider(deps.provider, {
-    operation,
-    file: resolvedFile,
-    position,
-    range: input.range ? toLspRange(input.range) : undefined,
-    newName: input.newName,
-  });
-
-  if (refactorResult.kind === "unavailable") {
-    throw new Error(`Refactor unavailable: ${refactorResult.reason}`);
-  }
-
-  if (refactorResult.kind === "ambiguous") {
-    return renderAmbiguousRefactorResult(refactorResult);
-  }
-
-  const validation = validateEdit(refactorResult.edits);
-  if (!validation.safe) {
-    return {
-      content: `**Refactor safety check failed:** ${validation.reason}`,
-      details: unavailableSearchDetails(null, ["Adjust the target or range and retry"]),
-    };
-  }
-
-  const fileFingerprints = collectFileFingerprints(refactorResult.edits.edits);
-  const planId = generatePlanId(
-    operation,
-    resolvedFile,
-    target.line,
-    target.character,
-    input.newName ?? "",
-  );
-
-  const plan: RefactorPlan = {
-    id: planId,
-    operation,
-    newName: input.newName,
-    targetFile: resolvedFile,
-    targetLine: target.line,
-    targetCharacter: target.character,
-    edits: refactorResult.edits,
-    fileFingerprints,
-    createdAt: Date.now(),
-  };
-  deps.session.storePlan(plan);
-
-  const content = renderRefactorPlanResult(plan, deps.cwd);
-
-  return {
-    content,
-    details: {
-      type: "search" as const,
-      data: assembleRefactorPlanDetails(refactorResult.edits, planId),
-    },
-  };
-}
-
-// ── Validation ────────────────────────────────────────────────────────
-
-function normalizeRequestedOperation(
-  operation: string,
-): { kind: "ok"; operation: CanonicalRefactorOperation } | { kind: "error"; message: string } {
-  if (
-    operation === "rename" ||
-    operation === "rename_symbol" ||
-    operation === "extract_function" ||
-    operation === "extract_variable"
-  ) {
-    return {
-      kind: "ok",
-      operation: normalizeRefactorOperation(operation as RefactorOperation),
-    };
-  }
-
-  return {
-    kind: "error",
-    message:
-      `**Error:** Unsupported refactor operation: "${operation}". The public \`code_refactor_plan\` tool currently supports: ` +
-      '"rename", "rename_symbol", "extract_function", "extract_variable".',
-  };
-}
-
-// biome-ignore lint/complexity/noExcessiveCognitiveComplexity: target expansion and operation-specific validation are kept together for clear user-facing errors.
-async function resolveRefactorTarget(
-  input: RefactorPlanInput,
-  operation: CanonicalRefactorOperation,
-  session: WorkspaceCodeIntelligenceSession,
-): Promise<CodeIntelResult | { file: string; line: number; character: number }> {
-  // ── Deep seam: resolve target through the session target workflow ──
-  if (input.targetId) {
-    const policy = {
-      fileLevelAllowed: false,
-      nameAnchorRequired: operation === "rename_symbol",
-      waitForSemantic: false,
-    } as const;
-
-    const outcome = await session.resolveTarget({ targetId: input.targetId }, policy);
-    if (outcome.kind === "resolved") {
-      input.file = outcome.entry.file;
-      input.line = outcome.entry.displayLine;
-      input.character = outcome.entry.displayCharacter;
-    } else if (outcome.kind === "invalid-input") {
-      // Declaration-anchor refusal for rename_symbol comes back as invalid-input
-      return {
-        content: `**Cannot plan rename:** ${outcome.message}`,
-        details: unavailableSearchDetails(null, [
-          "Re-resolve via `code_resolve` when the LSP has indexed the file",
-          "Or use `file` + `line` + `character` anchored on the identifier directly",
-        ]),
-      };
-    } else {
-      return {
-        content:
-          outcome.kind === "unavailable"
-            ? `**Error:** ${outcome.reason}`
-            : `**Error:** Target resolution failed. Verify the targetId is valid and from this session.`,
-        details: unavailableSearchDetails(null, [
-          "Verify the `targetId` is valid and from this session",
-        ]),
-      };
-    }
-  }
-
-  if (!input.file) {
-    return {
-      content:
-        "**Error:** Refactor preview requires a `file`. Provide `targetId` (from `code_resolve`) or `file` + `line` + `character`.",
-      details: unavailableSearchDetails(null, [
-        "Provide `targetId` from `code_resolve` or `file` + `line` + `character`",
-      ]),
-    };
-  }
-
-  if (isExtractOperation(operation) && input.range) {
-    const rangeError = validatePublicRange(input.range);
-    if (rangeError) {
-      return {
-        content: rangeError,
-        details: unavailableSearchDetails(null, ["Ensure `range.end` is after `range.start`"]),
-      };
-    }
-    if (input.line == null || input.character == null) {
-      input.line = input.range.start.line;
-      input.character = input.range.start.character;
-    }
-  }
-
-  if (input.line == null || input.character == null) {
-    return {
-      content:
-        "**Error:** Refactor preview requires `line` and `character`. Provide `targetId` (from `code_resolve`) or `file` + `line` + `character`.",
-      details: unavailableSearchDetails(null, [
-        "Provide `targetId` from `code_resolve` or `file` + `line` + `character`",
-      ]),
-    };
-  }
-
-  if ((operation === "rename_symbol" || isExtractOperation(operation)) && !input.newName) {
-    return {
-      content: `**Error:** Refactor preview requires \`newName\` for \`${operation}\`.`,
-      details: unavailableSearchDetails(null, [`Provide \`newName\` for \`${operation}\``]),
-    };
-  }
-
-  if (isExtractOperation(operation) && !input.range) {
-    return {
-      content: `**Error:** Refactor preview requires \`range\` for \`${operation}\`.`,
-      details: unavailableSearchDetails(null, [`Provide a 1-based \`range\` for \`${operation}\``]),
-    };
-  }
-
-  return {
-    file: input.file,
-    line: input.line,
-    character: input.character,
-  };
-}
-
-// ── Provider interaction ──────────────────────────────────────────────
-
-async function planRefactorWithProvider(
-  provider: SemanticProvider | null,
-  request: {
-    operation: CanonicalRefactorOperation;
-    file: string;
-    position: { line: number; character: number };
-    range?: SourceRange;
-    newName?: string;
-  },
-): Promise<RefactorResult> {
-  if (!provider) {
-    return {
-      kind: "unavailable",
-      reason: "No semantic provider is available.",
-    };
-  }
-
-  if (provider.refactor) {
-    return provider.refactor(request);
-  }
-
-  if (request.operation === "rename_symbol" && provider.rename && request.newName) {
-    return provider.rename(request.file, request.position, request.newName);
-  }
-
-  return {
-    kind: "unavailable",
-    reason: `The active semantic provider does not support refactor planning for operation "${request.operation}".`,
-  };
-}
-
-// ── Helpers ───────────────────────────────────────────────────────────
-
-function isExtractOperation(operation: CanonicalRefactorOperation): boolean {
-  return operation === "extract_function" || operation === "extract_variable";
-}
-
-function validatePublicRange(range: {
-  start: { line: number; character: number };
-  end: { line: number; character: number };
-}): string | null {
-  if (
-    range.end.line < range.start.line ||
-    (range.end.line === range.start.line && range.end.character <= range.start.character)
-  ) {
-    return "**Error:** Refactor preview requires `range.end` to be after `range.start`.";
-  }
-  return null;
-}
-
-function toLspRange(range: {
-  start: { line: number; character: number };
-  end: { line: number; character: number };
-}): SourceRange {
-  return {
-    start: toLspPosition(range.start.line, range.start.character),
-    end: toLspPosition(range.end.line, range.end.character),
-  };
-}
-
-function collectFileFingerprints(
-  edits: Array<{ file: string }>,
-): Array<{ file: string; fingerprint: string }> {
-  const seen = new Set<string>();
-  const fingerprints: Array<{ file: string; fingerprint: string }> = [];
-
-  for (const edit of edits) {
-    if (seen.has(edit.file)) continue;
-    seen.add(edit.file);
-    fingerprints.push({
-      file: edit.file,
-      fingerprint: computeFileFingerprint(edit.file),
-    });
-  }
-
-  return fingerprints;
-}
-
-function renderAmbiguousRefactorResult(
-  refactorResult: Extract<RefactorResult, { kind: "ambiguous" }>,
-): CodeIntelResult {
-  const candidates = refactorResult.candidates
-    .map(
-      (candidate, index) =>
-        `${index + 1}. ${candidate.description} (${candidate.file}:${candidate.line})`,
-    )
-    .join("\n");
-  return {
-    content: `**Refactor ambiguous:** Multiple matching targets found. Please disambiguate:\n${candidates}`,
-    details: unavailableSearchDetails(null, [
-      "Use `targetId` from `code_resolve` or provide precise anchored coordinates",
-    ]),
-  };
-}

package/src/tool/resolve/orchestrate.ts

@@ -1,38 +0,0 @@
-/**
- * code_resolve orchestration — resolve facts, assemble tool evidence, render adapters.
- */
-
-import { executeResolveService, type ResolveServiceParams } from "../../analysis/target/service.ts";
-import type { WorkspaceCodeIntelligenceSession } from "../../session/session.ts";
-import type { CodeIntelResult } from "../../types/index.ts";
-import { assembleResolveResult, suggestedResolveRelations } from "../result/resolve.ts";
-import { renderResolveResult } from "./markdown.ts";
-
-export interface ResolveOrchestrateInput {
-  params: ResolveServiceParams;
-  session: WorkspaceCodeIntelligenceSession;
-  cwd: string;
-}
-
-export async function orchestrateResolve(input: ResolveOrchestrateInput): Promise<CodeIntelResult> {
-  const { params, session, cwd } = input;
-  const result = await executeResolveService(params, session);
-  const assembly = assembleResolveResult(result, cwd);
-
-  let content = renderResolveResult(assembly);
-
-  // For single-target resolutions, append actionable "Chain next" guidance.
-  if (result.kind === "resolved" && result.targets.length === 1) {
-    const target = result.targets[0];
-    const rels = suggestedResolveRelations(target.kind);
-    if (rels) {
-      const chainLine = `Chain next: \`code_graph(targetId: "${target.targetId}", relations: ${JSON.stringify(rels)})\``;
-      content = `${content}\n${chainLine}\n`;
-    }
-  }
-
-  return {
-    content,
-    details: { type: "resolve", data: assembly.details },
-  };
-}

package/src/tool/result/impact.ts

@@ -1,50 +0,0 @@
-import type { EvidenceListMetadata } from "../../analysis/evidence.ts";
-import type { PrioritySignalsSummary } from "../../analysis/signals/project.ts";
-import type { CodeIntelResult } from "../../types/index.ts";
-import type { ImpactAnalysis } from "../impact/types.ts";
-import type { AffectedDetails, ImpactDetails } from "./types.ts";
-
-// biome-ignore lint/complexity/useMaxParams: detail assembly keeps shared counts, queries, and signals explicit for both surfaces
-export function assembleImpactDetails(
-  analysis: ImpactAnalysis,
-  directCount: number,
-  omittedCount: number,
-  nextQueries: string[],
-  prioritySignals: PrioritySignalsSummary | null,
-  evidenceLists: EvidenceListMetadata[] = [],
-): AffectedDetails | ImpactDetails {
-  return {
-    confidence: analysis.confidence,
-    directCount,
-    downstreamCount: analysis.downstreamCount,
-    riskLevel: analysis.riskLevel,
-    checkNext: analysis.checkNext,
-    likelyTests: analysis.likelyTests,
-    likelyTestCommands: analysis.likelyTestCommands,
-    omittedCount,
-    evidenceLists,
-    nextQueries,
-    prioritySignals,
-    tests: analysis.tests,
-  };
-}
-
-export function unavailableImpactResult(content: string, nextQueries: string[]): CodeIntelResult {
-  return {
-    content,
-    details: {
-      type: "impact",
-      data: {
-        confidence: "unavailable",
-        directCount: 0,
-        downstreamCount: 0,
-        riskLevel: "low" as const,
-        checkNext: [],
-        likelyTests: [],
-        likelyTestCommands: [],
-        omittedCount: 0,
-        nextQueries,
-      },
-    },
-  };
-}

package/src/ui/markdown/brief.ts

@@ -1,218 +0,0 @@
-// Brief markdown renderer — consumes use-case data and produces markdown content + details metadata.
-
-import * as path from "node:path";
-import type { ArchitectureModel } from "../../analysis/architecture/model.ts";
-import { findModuleForPath } from "../../analysis/architecture/model.ts";
-import type { BriefDetails } from "../../types/index.ts";
-
-interface TreeSitterContext {
-  nodeInfo: unknown;
-  outline: Array<{ name: string; kind: string; startLine: number; endLine: number }>;
-  imports: Array<{ moduleSpecifier: string }>;
-  exports: Array<{ name: string; kind: string }>;
-}
-
-// ── Symbol brief ──────────────────────────────────────────────────────
-
-export function renderSymbolBrief(params: {
-  relPath: string;
-  symbolName: string;
-  targetLine: number;
-  targetCharacter: number;
-  targetKind: string | null;
-  context: TreeSitterContext;
-  model: ArchitectureModel | null;
-  details: BriefDetails;
-  cwd: string;
-}): { content: string; details: BriefDetails } {
-  const lines: string[] = [];
-  lines.push(`# Symbol Brief: ${params.symbolName || params.relPath}`);
-  lines.push("");
-  lines.push(
-    `**Resolved to:** \`${params.relPath}:${params.targetLine}:${params.targetCharacter}\`${params.targetKind ? ` (${params.targetKind})` : ""}`,
-  );
-  lines.push("");
-
-  appendFileOrientationContext(lines, params.context);
-
-  if (params.model) {
-    const resolvedFile = path.resolve(params.cwd, params.relPath);
-    const mod = findModuleForPath(params.model, resolvedFile);
-    if (mod) {
-      const shortName = mod.name.replace(/^@[^/]+\//, "");
-      lines.push(`_Module: ${shortName} (\`${mod.relativePath}\`)_`);
-      lines.push("");
-    }
-  }
-
-  return { content: lines.join("\n"), details: params.details };
-}
-
-function getOutlinePrefix(kind: string): string {
-  if (kind === "function" || kind === "method") return "ƒ";
-  if (kind === "class") return "◆";
-  return "·";
-}
-
-function appendFileOrientationContext(lines: string[], context: TreeSitterContext): void {
-  if (context.outline.length > 0) {
-    lines.push("## File Outline");
-    const shown = context.outline.slice(0, 15);
-    for (const item of shown) {
-      const prefix = getOutlinePrefix(item.kind);
-      lines.push(`- ${prefix} \`${item.name}\` (${item.kind}) L${item.startLine}`);
-    }
-    if (context.outline.length > 15) {
-      lines.push(`- _+${context.outline.length - 15} more declarations_`);
-    }
-    lines.push("");
-  }
-
-  if (context.imports.length > 0) {
-    lines.push("## Imports");
-    const shown = context.imports.slice(0, 10);
-    for (const imp of shown) {
-      lines.push(`- \`${imp.moduleSpecifier}\``);
-    }
-    if (context.imports.length > 10) {
-      lines.push(`- _+${context.imports.length - 10} more_`);
-    }
-    lines.push("");
-  }
-
-  if (context.exports.length > 0) {
-    lines.push("## Exports");
-    const shown = context.exports.slice(0, 10);
-    for (const exp of shown) {
-      lines.push(`- \`${exp.name}\` (${exp.kind})`);
-    }
-    if (context.exports.length > 10) {
-      lines.push(`- _+${context.exports.length - 10} more_`);
-    }
-    lines.push("");
-  }
-}
-
-// ── File brief ───────────────────────────────────────────────────────
-
-interface FileBriefInput {
-  relPath: string;
-  lineCount: number;
-  isEntrypoint: boolean;
-  moduleName: string | null;
-  moduleRelativePath: string | null;
-  enrichment: {
-    outline: Array<{ name: string; kind: string; startLine: number; endLine: number }>;
-    imports: Array<{ moduleSpecifier: string }>;
-    exports: Array<{ name: string; kind: string }>;
-    diagnostics: Array<{ line: number; severity: number; message: string }>;
-  };
-  maxResults?: number;
-}
-
-export function renderFileBrief(input: FileBriefInput): string {
-  const lines: string[] = [];
-  lines.push(`# File: ${input.relPath}`);
-  lines.push("");
-
-  if (input.moduleName) {
-    lines.push(`_Module: ${input.moduleName} (\`${input.moduleRelativePath}\`)_`);
-    lines.push("");
-  }
-
-  if (input.isEntrypoint) {
-    lines.push("**This file is a module entrypoint.**");
-    lines.push("");
-  }
-
-  lines.push(`- Lines: ${input.lineCount}`);
-  lines.push("");
-
-  // Diagnostics section (inline first diagnostic messages)
-  appendDiagnosticsSection(lines, input.enrichment.diagnostics, input.maxResults);
-
-  // Structural context (outline, imports, exports)
-  if (input.enrichment.outline.length > 0) {
-    lines.push("## File Outline");
-    const shown = input.enrichment.outline;
-    for (const item of shown) {
-      const prefix = getOutlinePrefix(item.kind);
-      lines.push(`- ${prefix} \`${item.name}\` (${item.kind}) L${item.startLine}`);
-    }
-    lines.push("");
-  }
-
-  if (input.enrichment.imports.length > 0) {
-    lines.push("## Imports");
-    for (const imp of input.enrichment.imports) {
-      lines.push(`- \`${imp.moduleSpecifier}\``);
-    }
-    lines.push("");
-  }
-
-  if (input.enrichment.exports.length > 0) {
-    lines.push("## Exports");
-    for (const exp of input.enrichment.exports) {
-      lines.push(`- \`${exp.name}\` (${exp.kind})`);
-    }
-    lines.push("");
-  }
-
-  return lines.join("\n");
-}
-
-// ── Module brief diagnostics section ─────────────────────────────────
-
-export function renderModuleDiagnostics(
-  fileDiagnostics: Array<{ file: string; errors: number; warnings: number }>,
-  maxResults?: number,
-): string | null {
-  if (fileDiagnostics.length === 0) return null;
-
-  const lines: string[] = [];
-  lines.push("## Diagnostics");
-  const cap = maxResults ?? 5;
-  for (const entry of fileDiagnostics.slice(0, cap)) {
-    const parts: string[] = [];
-    if (entry.errors > 0) parts.push(`${entry.errors} error${entry.errors > 1 ? "s" : ""}`);
-    if (entry.warnings > 0) parts.push(`${entry.warnings} warning${entry.warnings > 1 ? "s" : ""}`);
-    lines.push(`- \`${entry.file}\` — ${parts.join(", ")}`);
-  }
-  if (fileDiagnostics.length > cap) {
-    lines.push(`- _+${fileDiagnostics.length - cap} more files_`);
-  }
-  lines.push("");
-
-  return lines.join("\n");
-}
-
-// ── Diagnostics section (inline) ─────────────────────────────────────
-
-function severityLabel(severity: number): string {
-  switch (severity) {
-    case 1:
-      return "Error";
-    case 2:
-      return "Warning";
-    case 3:
-      return "Info";
-    case 4:
-      return "Hint";
-    default:
-      return "Diagnostic";
-  }
-}
-
-function appendDiagnosticsSection(
-  lines: string[],
-  diagnostics: Array<{ line: number; severity: number; message: string }>,
-  _maxResults?: number,
-): void {
-  if (diagnostics.length === 0) return;
-
-  lines.push("## Diagnostics");
-  for (const d of diagnostics) {
-    lines.push(`- L${d.line}: ${severityLabel(d.severity)}: ${d.message}`);
-  }
-  lines.push("");
-}