@mrclrchtr/supi-bash-timeout 0.1.0 → 0.2.0

package/node_modules/@mrclrchtr/supi-core/src/settings-ui.ts

@@ -0,0 +1,226 @@
+// Generic settings overlay for SuPi extensions.
+//
+// Uses pi-tui's SettingsList with scope toggle (Tab), extension grouping,
+// and search. Each extension declares its settings via registerSettings().
+
+import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { getSettingsListTheme } from "@earendil-works/pi-coding-agent";
+import {
+  Container,
+  Input,
+  Key,
+  matchesKey,
+  type SettingItem,
+  SettingsList,
+  Text,
+} from "@earendil-works/pi-tui";
+import {
+  getRegisteredSettings,
+  type SettingsScope,
+  type SettingsSection,
+} from "./settings-registry.ts";
+
+// ── Input submenu component ──────────────────────────────────
+
+/**
+ * Creates a pi-tui Input-backed submenu component with enter-to-confirm
+ * and escape-to-cancel handling.
+ *
+ * @param currentValue - Initial value for the text input.
+ * @param label - Label text displayed above the input.
+ * @param done - Callback invoked with the confirmed value, or undefined on cancel.
+ */
+export function createInputSubmenu(
+  currentValue: string,
+  label: string,
+  done: (selectedValue?: string) => void,
+): {
+  render: (width: number) => string[];
+  invalidate: () => void;
+  handleInput: (data: string) => boolean;
+} {
+  const input = new Input();
+  input.setValue(currentValue);
+
+  return {
+    render: (_width: number) => {
+      const lines = [`  ${label}`];
+      lines.push(...input.render(_width));
+      lines.push("  enter confirm • esc cancel");
+      return lines;
+    },
+    invalidate: () => {
+      input.invalidate();
+    },
+    handleInput: (data: string) => {
+      if (matchesKey(data, Key.escape)) {
+        done();
+        return true;
+      }
+      if (matchesKey(data, Key.enter)) {
+        done(input.getValue());
+        return true;
+      }
+      input.handleInput(data);
+      return true;
+    },
+  };
+}
+
+// ── Types ────────────────────────────────────────────────────
+
+interface OverlayState {
+  scope: SettingsScope;
+  cwd: string;
+}
+
+// ── Pure helpers ─────────────────────────────────────────────
+
+function getScopeLabel(scope: SettingsScope): string {
+  return scope === "project" ? "Project" : "Global";
+}
+
+function buildFlatItems(
+  sections: SettingsSection[],
+  scope: SettingsScope,
+  cwd: string,
+): SettingItem[] {
+  const items: SettingItem[] = [];
+  for (const section of sections) {
+    const sectionItems = section.loadValues(scope, cwd);
+    for (const item of sectionItems) {
+      items.push({
+        ...item,
+        id: `${section.id}.${item.id}`,
+        label: `${section.label}: ${item.label}`,
+      });
+    }
+  }
+  return items;
+}
+
+function findSectionAndId(
+  sections: SettingsSection[],
+  flatId: string,
+): { section: SettingsSection; itemId: string } | null {
+  const dotIndex = flatId.indexOf(".");
+  if (dotIndex === -1) return null;
+  const sectionId = flatId.slice(0, dotIndex);
+  const itemId = flatId.slice(dotIndex + 1);
+  const section = sections.find((s) => s.id === sectionId);
+  if (!section) return null;
+  return { section, itemId };
+}
+
+// ── Component ────────────────────────────────────────────────
+
+interface SettingsOverlayDeps {
+  state: OverlayState;
+  container: Container;
+  settingsList: SettingsList | null;
+  tui: Parameters<Parameters<ExtensionContext["ui"]["custom"]>[0]>[0];
+  theme: Parameters<Parameters<ExtensionContext["ui"]["custom"]>[0]>[1];
+  done: () => void;
+}
+
+function createSettingsList(deps: SettingsOverlayDeps): SettingsList {
+  const sections = getRegisteredSettings();
+  const items = buildFlatItems(sections, deps.state.scope, deps.state.cwd);
+  const onChange = (flatId: string, newValue: string) => {
+    const found = findSectionAndId(sections, flatId);
+    if (found) {
+      found.section.persistChange(deps.state.scope, deps.state.cwd, found.itemId, newValue);
+    }
+    // Re-read all values to reflect persisted changes, but keep the list
+    // instance (and its selectedIndex) intact.
+    const updatedItems = buildFlatItems(sections, deps.state.scope, deps.state.cwd);
+    for (const updated of updatedItems) {
+      const existing = items.find((i) => i.id === updated.id);
+      if (existing && existing.currentValue !== updated.currentValue) {
+        settingsList.updateValue(updated.id, updated.currentValue);
+      }
+    }
+    deps.tui.requestRender();
+  };
+  const settingsList = new SettingsList(
+    items,
+    Math.min(items.length + 4, 20),
+    getSettingsListTheme(),
+    onChange,
+    () => deps.done(),
+    { enableSearch: true },
+  );
+  return settingsList;
+}
+
+function rebuildSettingsList(deps: SettingsOverlayDeps): SettingsList {
+  const settingsList = createSettingsList(deps);
+  deps.settingsList = settingsList;
+
+  deps.container.clear();
+  deps.container.addChild(createHeaderComponent(deps));
+  deps.container.addChild(settingsList);
+
+  return settingsList;
+}
+
+function createHeaderComponent(deps: SettingsOverlayDeps): Text {
+  const { theme, state } = deps;
+  const scopeLabel = getScopeLabel(state.scope);
+  const otherScope = state.scope === "project" ? "Global" : "Project";
+  const headerText = new Text(
+    `${theme.fg("accent", theme.bold("SuPi Settings"))}  ${theme.fg("text", `Scope: ${scopeLabel}`)} ${theme.fg("dim", `(tab → ${otherScope})`)}`,
+    0,
+    0,
+  );
+  return headerText;
+}
+
+function handleScopeToggle(deps: SettingsOverlayDeps): void {
+  deps.state.scope = deps.state.scope === "project" ? "global" : "project";
+  rebuildSettingsList(deps);
+  deps.tui.requestRender();
+}
+
+// ── Entry point ──────────────────────────────────────────────
+
+export function openSettingsOverlay(ctx: ExtensionContext): void {
+  const sections = getRegisteredSettings();
+  if (sections.length === 0) {
+    ctx.ui.notify("No settings registered by SuPi extensions", "info");
+    return;
+  }
+
+  void ctx.ui.custom<void>((tui, theme, _kb, done) => {
+    const state: OverlayState = { scope: "project", cwd: ctx.cwd };
+    const container = new Container();
+
+    const deps: SettingsOverlayDeps = {
+      state,
+      container,
+      settingsList: null,
+      tui,
+      theme,
+      done,
+    };
+
+    rebuildSettingsList(deps);
+
+    const component = {
+      render: (width: number) => container.render(width),
+      invalidate: () => container.invalidate(),
+      handleInput: (data: string) => {
+        if (matchesKey(data, Key.tab)) {
+          handleScopeToggle(deps);
+          return true;
+        }
+        // Delegate input to the settings list (always set after rebuildSettingsList)
+        deps.settingsList?.handleInput?.(data);
+        deps.tui.requestRender();
+        return true;
+      },
+    };
+
+    return component;
+  });
+}

package/node_modules/@mrclrchtr/supi-core/src/terminal.ts

@@ -0,0 +1,60 @@
+/**
+ * Shared terminal title formatting and signaling utilities.
+ *
+ * Centralized place for pi title convention (π prefix), completion (✓)
+ * and waiting (●) indicators, and the audible terminal bell.
+ */
+import path from "node:path";
+
+/** Unicode checkmark shown when the agent finishes a turn. */
+export const DONE_SYMBOL = "\u2713";
+/** Unicode dot shown when waiting for user input. */
+export const WAITING_SYMBOL = "\u25CF";
+
+/** Minimal UI surface needed for title operations. */
+export interface TitleTarget {
+  ui: {
+    setTitle?(title: string): void;
+  };
+}
+
+/**
+ * Format pi's canonical terminal title from session name and cwd.
+ * Falls back gracefully when either is missing.
+ *
+ * @example
+ *   formatTitle("my-session", "/home/projects/foo")  // "π - my-session - foo"
+ *   formatTitle(undefined, "/home/projects/foo")      // "π - foo"
+ *   formatTitle("my-session")                         // "π - my-session"
+ *   formatTitle()                                     // "π"
+ */
+export function formatTitle(sessionName?: string, cwd?: string): string {
+  const base = cwd ? path.basename(cwd) : undefined;
+  if (sessionName && base) return `π - ${sessionName} - ${base}`;
+  if (sessionName) return `π - ${sessionName}`;
+  if (base) return `π - ${base}`;
+  return "π";
+}
+
+/** Sound the audible terminal bell (ASCII BEL). */
+export function signalBell(): void {
+  process.stdout.write("\x07");
+}
+
+/**
+ * Set the terminal title to indicate the agent is waiting for user input.
+ * Prefixes with ● and sounds the terminal bell.
+ */
+export function signalWaiting(ctx: TitleTarget, title: string): void {
+  ctx.ui.setTitle?.(`${WAITING_SYMBOL}  ${title}`);
+  signalBell();
+}
+
+/**
+ * Set the terminal title to indicate the agent turn has completed.
+ * Prefixes with ✓ and sounds the terminal bell.
+ */
+export function signalDone(ctx: TitleTarget, title: string): void {
+  ctx.ui.setTitle?.(`${DONE_SYMBOL} ${title}`);
+  signalBell();
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mrclrchtr/supi-bash-timeout",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "description": "SuPi bash-timeout extension — injects default timeout on bash tool calls",
   "license": "MIT",
   "repository": {
@@ -16,14 +16,28 @@
     "pi-coding-agent"
   ],
   "files": [
-    "index.ts"
+    "src/**/*.ts",
+    "!__tests__"
+  ],
+  "dependencies": {
+    "@mrclrchtr/supi-core": "workspace:*"
+  },
+  "bundledDependencies": [
+    "@mrclrchtr/supi-core"
   ],
   "peerDependencies": {
-    "@mariozechner/pi-coding-agent": "~0.66.0"
+    "@earendil-works/pi-coding-agent": "*",
+    "@earendil-works/pi-tui": "*"
+  },
+  "devDependencies": {
+    "@types/node": "25.6.2",
+    "vitest": "4.1.5",
+    "@mrclrchtr/supi-test-utils": "workspace:*"
   },
   "pi": {
     "extensions": [
-      "./index.ts"
+      "./src/bash-timeout.ts"
     ]
-  }
+  },
+  "main": "src/index.ts"
 }

package/src/bash-timeout.ts

@@ -0,0 +1,28 @@
+// Bash Timeout — inject default timeouts on bash tool calls.
+//
+// The pi bash tool accepts an optional `timeout` parameter, but the LLM
+// doesn't always specify one.  In a headless gateway daemon with no human
+// watching, a single hung command (e.g. `find /` over a huge filesystem)
+// blocks all subsequent messages indefinitely.
+//
+// This extension intercepts every bash `tool_call` event and sets a default
+// timeout when the LLM omits one.  The timeout is configurable via
+// /supi-settings or the SuPi config system (default 120s).
+
+import { type ExtensionAPI, isToolCallEventType } from "@earendil-works/pi-coding-agent";
+import { loadBashTimeoutConfig } from "./config.ts";
+import { registerBashTimeoutSettings } from "./settings-registration.ts";
+
+export default function bashTimeout(pi: ExtensionAPI) {
+  registerBashTimeoutSettings();
+
+  pi.on("tool_call", async (event, ctx) => {
+    if (!isToolCallEventType("bash", event)) return;
+
+    // Only inject when the LLM didn't specify a timeout
+    if (event.input.timeout !== undefined && event.input.timeout !== null) return;
+
+    const config = loadBashTimeoutConfig(ctx.cwd);
+    event.input.timeout = config.defaultTimeout;
+  });
+}

package/src/config.ts

@@ -0,0 +1,22 @@
+import { loadSupiConfig } from "@mrclrchtr/supi-core";
+
+export interface BashTimeoutConfig {
+  defaultTimeout: number;
+}
+
+export const BASH_TIMEOUT_DEFAULTS: BashTimeoutConfig = {
+  defaultTimeout: 120,
+};
+
+function isValidTimeout(value: unknown): value is number {
+  return typeof value === "number" && Number.isFinite(value) && value > 0;
+}
+
+export function loadBashTimeoutConfig(cwd: string, homeDir?: string): BashTimeoutConfig {
+  const raw = loadSupiConfig("bash-timeout", cwd, BASH_TIMEOUT_DEFAULTS, { homeDir });
+  return {
+    defaultTimeout: isValidTimeout(raw.defaultTimeout)
+      ? raw.defaultTimeout
+      : BASH_TIMEOUT_DEFAULTS.defaultTimeout,
+  };
+}

package/src/index.ts

@@ -0,0 +1 @@
+export { default } from "./bash-timeout.ts";

package/src/settings-registration.ts

@@ -0,0 +1,37 @@
+import type { SettingItem } from "@earendil-works/pi-tui";
+import { createInputSubmenu, registerConfigSettings } from "@mrclrchtr/supi-core";
+import { BASH_TIMEOUT_DEFAULTS, type BashTimeoutConfig } from "./config.ts";
+
+export function registerBashTimeoutSettings(): void {
+  registerConfigSettings({
+    id: "bash-timeout",
+    label: "Bash Timeout",
+    section: "bash-timeout",
+    defaults: BASH_TIMEOUT_DEFAULTS,
+    buildItems: (settings) => buildBashTimeoutSettingItems(settings),
+    // biome-ignore lint/complexity/useMaxParams: ConfigSettingsOptions interface callback
+    persistChange: (_scope, _cwd, settingId, value, helpers) => {
+      if (settingId === "defaultTimeout") {
+        const num = Number.parseInt(value, 10);
+        if (Number.isFinite(num) && num > 0) {
+          helpers.set("defaultTimeout", num);
+        } else {
+          helpers.unset("defaultTimeout");
+        }
+      }
+    },
+  });
+}
+
+function buildBashTimeoutSettingItems(settings: BashTimeoutConfig): SettingItem[] {
+  return [
+    {
+      id: "defaultTimeout",
+      label: "Default Timeout",
+      description: "Default timeout for bash tool calls in seconds",
+      currentValue: String(settings.defaultTimeout),
+      submenu: (currentValue, done) =>
+        createInputSubmenu(currentValue, "Timeout in seconds:", done),
+    },
+  ];
+}

package/index.ts

@@ -1,39 +0,0 @@
-// Bash Timeout — inject default timeouts on bash tool calls.
-//
-// The pi bash tool accepts an optional `timeout` parameter, but the LLM
-// doesn't always specify one.  In a headless gateway daemon with no human
-// watching, a single hung command (e.g. `find /` over a huge filesystem)
-// blocks all subsequent messages indefinitely.
-//
-// This extension intercepts every bash `tool_call` event and sets a default
-// timeout when the LLM omits one.  The timeout is configurable via the
-// PI_BASH_DEFAULT_TIMEOUT env var (seconds, default 120).
-//
-// ADR-0049: Gateway TUI via WebSocket
-
-import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
-
-const DEFAULT_TIMEOUT_SECONDS = 120;
-
-function getDefaultTimeout(): number {
-  const env = process.env.PI_BASH_DEFAULT_TIMEOUT;
-  if (env) {
-    const parsed = parseInt(env, 10);
-    if (Number.isFinite(parsed) && parsed > 0) return parsed;
-  }
-  return DEFAULT_TIMEOUT_SECONDS;
-}
-
-export default function bashTimeout(pi: ExtensionAPI) {
-  pi.on("tool_call", async (event) => {
-    if (event.toolName !== "bash") return;
-
-    const input = event.input as { command?: string; timeout?: number };
-
-    // Only inject when the LLM didn't specify a timeout
-    if (input.timeout !== undefined && input.timeout !== null) return;
-
-    const defaultTimeout = getDefaultTimeout();
-    input.timeout = defaultTimeout;
-  });
-}