@mrciphersmith/keryx 0.3.59 → 0.3.61

package/dist/cli.js

@@ -16229,7 +16229,7 @@ var init_skill_length_ceilings = __esm(() => {
     "orchestration/context-collector": 671,
     "orchestration/feature-analyzer": 447,
     "orchestration/feature-dev": 177,
-    "orchestration/flow-orchestrator": 696,
+    "orchestration/flow-orchestrator": 694,
     "orchestration/issue-analyzer": 373,
     "orchestration/job-documenter": 414,
     "orchestration/job-orchestrator": 2243,
@@ -20104,7 +20104,7 @@ var package_default;
 var init_package = __esm(() => {
   package_default = {
     name: "@mrciphersmith/keryx",
-    version: "0.3.59",
+    version: "0.3.61",
     description: "Version-controlled project context for AI coding agents: code graph, architecture wiki, project memory, relevant tests, quality signals, and task flows.",
     private: false,
     publishConfig: {
@@ -56454,7 +56454,7 @@ async function reviewGate(input) {
   const verdict = await runReviewGate(input);
   return { name: "review", status: verdict.status, detail: verdict.detail };
 }
-var BLOCKING_SEVERITY_FLOORS, REVIEW_GATE_SEVERITY_FLOOR_DEFAULT = "minor", REVIEW_ROUND_CAP = 3, REVIEW_GATE_CONFIG_PATH = ".metaproject/tasks.config.json", DEFAULT_REVIEW_GATE_CONFIG, SEVERITY_RANK2, SHA_PATTERN3, HUMAN_DECISION_PATTERN, CORRECT_BUT_DISMISSED, REPLY_EVIDENCE_PATTERN, durableExternalCommentsGate = async (input) => {
+var BLOCKING_SEVERITY_FLOORS, REVIEW_GATE_SEVERITY_FLOOR_DEFAULT = "minor", REVIEW_ROUND_CAP = 5, REVIEW_GATE_CONFIG_PATH = ".metaproject/tasks.config.json", DEFAULT_REVIEW_GATE_CONFIG, SEVERITY_RANK2, SHA_PATTERN3, HUMAN_DECISION_PATTERN, CORRECT_BUT_DISMISSED, REPLY_EVIDENCE_PATTERN, durableExternalCommentsGate = async (input) => {
   const url = input.flow.pr.url;
   if (url === null) {
     return null;

package/dist/core.js

@@ -9801,7 +9801,7 @@ var init_skill_length_ceilings = __esm(() => {
     "orchestration/context-collector": 671,
     "orchestration/feature-analyzer": 447,
     "orchestration/feature-dev": 177,
-    "orchestration/flow-orchestrator": 696,
+    "orchestration/flow-orchestrator": 694,
     "orchestration/issue-analyzer": 373,
     "orchestration/job-documenter": 414,
     "orchestration/job-orchestrator": 2243,
@@ -24759,7 +24759,7 @@ function unansweredComments(state) {
 // src/flow/review-gate.ts
 var BLOCKING_SEVERITY_FLOORS = ["blocker", "major", "minor"];
 var REVIEW_GATE_SEVERITY_FLOOR_DEFAULT = "minor";
-var REVIEW_ROUND_CAP = 3;
+var REVIEW_ROUND_CAP = 5;
 var REVIEW_GATE_CONFIG_PATH = ".metaproject/tasks.config.json";
 var DEFAULT_REVIEW_GATE_CONFIG = {
   severityFloor: REVIEW_GATE_SEVERITY_FLOOR_DEFAULT,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mrciphersmith/keryx",
-  "version": "0.3.59",
+  "version": "0.3.61",
   "description": "Version-controlled project context for AI coding agents: code graph, architecture wiki, project memory, relevant tests, quality signals, and task flows.",
   "private": false,
   "publishConfig": {

package/src/gdskills/bundled/skills/orchestration/flow-orchestrator/SKILL.md

@@ -81,8 +81,8 @@ flowchart TD
   H -- "yes" --> I{"Ask user how to finish"}
   I -- "create PR" --> J["create PR and run review/fix loop"]
   J --> K{"review clean, PR mergeable?"}
-  K -- "no, attempts < 3" --> J
-  K -- "no, attempts = 3 or repetition detected" --> R["enrich context and change fix strategy"]
+  K -- "no, attempts < 5" --> J
+  K -- "no, attempts = 5 or repetition detected" --> R["enrich context and change fix strategy"]
   R --> J
   K -- "yes" --> L["merge PR into recorded base branch"]
   L --> M["keryx flow implemented --pr"]
@@ -153,7 +153,7 @@ it already tried. The flow package does.
       ```
 
    6. Apply the Phase 4 attempt budget against the **persisted** count. If
-      `attempts.count` for the task has already reached **three**, do not
+      `attempts.count` for the task has already reached **five**, do not
       re-dispatch the same approach: go to the re-planning step (Phase 4, PR
       review/fix loop, step 4) and record the decision in `journal.md`.
    7. Run the repetition check before spending an attempt, whatever the count
@@ -533,7 +533,7 @@ answered it and who is behind it.
 | `completion: <anything>` as a constraint STRING | **Not an outcome. Refuse it and ask for the typed field.** `constraints[]` is parsed by nothing, so a completion arriving there is never read at all. Such a dispatch is now refused for the missing `completion_outcome` rather than silently accepted — but the refusal is the contract's, not this row's, and a row telling you to honour the string would be a documented bypass of the fence in the file that owns it. |
 
 A constraint that would raise this skill's own attempt budget is **not** obeyed.
-The three-attempt bound and the `keryx review loop` repetition check are this
+The five-attempt bound and the `keryx review loop` repetition check are this
 skill's, they are evidence-backed, and a caller asking for "loop until clean" gets
 the bound plus an escalation — never an unbounded loop.
 
@@ -551,23 +551,21 @@ the bound plus an escalation — never an unbounded loop.
    remaining `info` findings in the completion report rather than fixing them
    under a loop that was not opened for them. A caller may lower the threshold in
    `constraints`; it cannot raise it to merge over a `minor`.
-3. Allow at most **three** review/fix attempts for the current approach. Count
+3. Allow at most **five** review/fix attempts for the current approach. Count
    an attempt when review/check results are available, including a clean result,
    and record it with `keryx flow task attempt <id> <Tn> --outcome ...` so the
    count survives a session restart. Read the budget from that task's
    `attempts.count` in `flow.json`, never from this session's memory.
 
-   Three, and the same three that `task-implementer` and `job-orchestrator`
-   already use. This skill said six, which was an outlier with nothing behind
-   it. The evidence converges on three: *"the first three to four repair
+   Five here by operator decision (message 178020; review findings surface across rounds, and the repetition check below stops a loop that is not converging), three in `task-implementer` and `job-orchestrator`. This skill said six, an outlier with nothing behind it. The evidence for a repair loop converges on three: *"the first three to four repair
    iterations account for most achievable gains"*
    ([arXiv:2607.05197](https://arxiv.org/abs/2607.05197)); correctness falls
    **0.820 -> 0.673** across two forced revisions while cumulative ever-correct
    is **0.847** ([arXiv:2607.24604](https://arxiv.org/abs/2607.24604)) — the
    agent finds the fix and then destroys it, throwing away ~15 points by not
    stopping. Aider hardcodes `max_reflections = 3`; OpenHands' critic uses 3.
-   Rounds four through six were not buying convergence; they were buying
-   regressions.
+   Rounds four through six of a self-fix loop were not buying convergence; they
+   were buying regressions. Review rounds are the exception, as stated above.
 
 4. **Before** spending an attempt, and regardless of how much budget is left,
    run the repetition check:
@@ -583,7 +581,7 @@ the bound plus an escalation — never an unbounded loop.
    emitting the identical failing output three times must be caught on the
    second, not after the budget runs out.
 
-5. If the third attempt is not clean, **or the repetition check escalated
+5. If the fifth attempt is not clean, **or the repetition check escalated
    earlier**, do not blindly repeat the same loop. Enrich context from the
    findings, affected graph, relevant wiki, and health/testing artifacts;
    identify the likely cycle cause; choose a materially different fix strategy

package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.md

@@ -1265,8 +1265,8 @@ with evidence, not silence.
 
 Only runs if NEEDS_FIX is true. Default max: **3 iterations** (`max_review_iterations`).
 
-Three is the shared round bound: `task-implementer`, `flow-orchestrator` and
-this skill all use it. *"The first three to four repair iterations account for
+Three is the self-fix bound `task-implementer` and this skill share
+(`flow-orchestrator`'s review bound is five, by operator decision). *"The first three to four repair iterations account for
 most achievable gains"* ([arXiv:2607.05197](https://arxiv.org/abs/2607.05197));
 correctness falls **0.820 -> 0.673** across two forced revisions while
 cumulative ever-correct is **0.847**

package/src/gdskills/bundled/skills/orchestration/job-orchestrator/input-contract.schema.json

@@ -106,7 +106,7 @@
           "minimum": 1,
           "maximum": 3,
           "default": 3,
-          "description": "Max review → fix iterations. Three: the same bound `task-implementer`, `flow-orchestrator` and SKILL.md 2.7 carry, pinned across all of them by src/gdskills/round-bound.test.ts. The default was 2 here, which made the contract disagree with the skill it validates."
+          "description": "Max review → fix iterations. Three: the same bound `task-implementer` and SKILL.md 2.7 carry (`flow-orchestrator`'s review bound is five, by operator decision), pinned by src/gdskills/round-bound.test.ts. The default was 2 here, which made the contract disagree with the skill it validates."
         },
         "plan_approval": {
           "type": "boolean",

package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.md

@@ -362,8 +362,8 @@ non-zero exit the signal; if tests were created or modified they must pass.
 
 Maximum 3 self-fix attempts per verification step.
 
-Three, and it is the same three `job-orchestrator` and `flow-orchestrator`
-use: one round bound, not four. *"The first three to four repair iterations
+Three, the same three `job-orchestrator` uses; `flow-orchestrator`'s review
+bound is five by operator decision, so two repair bounds, not four. *"The first three to four repair iterations
 account for most achievable gains"*
 ([arXiv:2607.05197](https://arxiv.org/abs/2607.05197)); correctness falls
 **0.820 -> 0.673** across two forced revisions while cumulative ever-correct is

package/src/gdskills/bundled/skills/orchestration/task-implementer/input-contract.schema.json

@@ -188,7 +188,7 @@
           "type": "integer",
           "minimum": 1,
           "maximum": 3,
-          "description": "Fix iteration number. Three, the same bound `flow-orchestrator`, `job-orchestrator` and SKILL.md Phase 5.4 carry and `src/gdskills/round-bound.test.ts` pins; it was 2 here, a fourth disagreeing repair bound."
+          "description": "Fix iteration number. Three, the same bound `job-orchestrator` and SKILL.md Phase 5.4 carry and `src/gdskills/round-bound.test.ts` pins (`flow-orchestrator`'s review bound is five); it was 2 here, a fourth disagreeing repair bound."
         }
       }
     },