@mrciphersmith/keryx 0.2.98 → 0.2.99

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (182) hide show
  1. package/dist/cli.js +4057 -2510
  2. package/dist/core.js +39 -1
  3. package/package.json +1 -1
  4. package/src/gdskills/bundled/rules/core/cli-interface-design.mdc +237 -0
  5. package/src/gdskills/bundled/rules/core/definition-of-done.mdc +116 -0
  6. package/src/gdskills/bundled/rules/core/skills-storage-workflow.mdc +101 -11
  7. package/src/gdskills/bundled/rules/core/subagent-status-protocol.md +9 -2
  8. package/src/gdskills/bundled/skills/core/reviewer-skill-creator/SKILL.md +42 -5
  9. package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.md +19 -3
  10. package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.md +20 -4
  11. package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.md +32 -9
  12. package/src/gdskills/bundled/skills/orchestration/feature-dev/SKILL.md +18 -4
  13. package/src/gdskills/bundled/skills/orchestration/flow-orchestrator/SKILL.md +21 -5
  14. package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.md +4 -4
  15. package/src/gdskills/bundled/skills/orchestration/issue-analyzer/orchestrator-prompt.md +1 -1
  16. package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.md +42 -2
  17. package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.md +23 -9
  18. package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.md +33 -31
  19. package/src/gdskills/bundled/skills/orchestration/task-implementer/output-contract.schema.json +32 -1
  20. package/src/gdskills/bundled/skills/planning/autodoc-analyst/SKILL.md +16 -0
  21. package/src/gdskills/bundled/skills/planning/autodoc-architect/SKILL.md +16 -0
  22. package/src/gdskills/bundled/skills/planning/autodoc-assembler/SKILL.md +16 -0
  23. package/src/gdskills/bundled/skills/planning/autodoc-orchestrator/SKILL.md +17 -0
  24. package/src/gdskills/bundled/skills/planning/autodoc-scanner/SKILL.md +16 -0
  25. package/src/gdskills/bundled/skills/planning/autodoc-writer/SKILL.md +16 -0
  26. package/src/gdskills/bundled/skills/planning/brainstorm/SKILL.md +28 -3
  27. package/src/gdskills/bundled/skills/planning/consistency-checker/SKILL.codex.md +17 -0
  28. package/src/gdskills/bundled/skills/planning/consistency-checker/SKILL.cursor.md +17 -0
  29. package/src/gdskills/bundled/skills/planning/consistency-checker/SKILL.md +17 -0
  30. package/src/gdskills/bundled/skills/planning/docpack-orchestrator/SKILL.md +32 -2
  31. package/src/gdskills/bundled/skills/planning/docpack-review/SKILL.md +14 -2
  32. package/src/gdskills/bundled/skills/planning/interview/SKILL.md +29 -7
  33. package/src/gdskills/bundled/skills/planning/interviewer/SKILL.md +32 -6
  34. package/src/gdskills/bundled/skills/planning/patterns-researcher/SKILL.codex.md +16 -0
  35. package/src/gdskills/bundled/skills/planning/patterns-researcher/SKILL.cursor.md +16 -0
  36. package/src/gdskills/bundled/skills/planning/patterns-researcher/SKILL.md +16 -0
  37. package/src/gdskills/bundled/skills/planning/planner/SKILL.codex.md +17 -0
  38. package/src/gdskills/bundled/skills/planning/planner/SKILL.cursor.md +17 -0
  39. package/src/gdskills/bundled/skills/planning/planner/SKILL.md +17 -0
  40. package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.md +20 -3
  41. package/src/gdskills/bundled/skills/planning/problem-definer/SKILL.codex.md +16 -0
  42. package/src/gdskills/bundled/skills/planning/problem-definer/SKILL.cursor.md +16 -0
  43. package/src/gdskills/bundled/skills/planning/problem-definer/SKILL.md +16 -0
  44. package/src/gdskills/bundled/skills/planning/project-discovery/SKILL.codex.md +16 -0
  45. package/src/gdskills/bundled/skills/planning/project-discovery/SKILL.cursor.md +16 -0
  46. package/src/gdskills/bundled/skills/planning/project-discovery/SKILL.md +16 -0
  47. package/src/gdskills/bundled/skills/planning/spec-writer/SKILL.codex.md +4 -0
  48. package/src/gdskills/bundled/skills/planning/spec-writer/SKILL.cursor.md +4 -0
  49. package/src/gdskills/bundled/skills/planning/spec-writer/SKILL.md +4 -0
  50. package/src/gdskills/bundled/skills/planning/stack-advisor/SKILL.codex.md +4 -0
  51. package/src/gdskills/bundled/skills/planning/stack-advisor/SKILL.cursor.md +4 -0
  52. package/src/gdskills/bundled/skills/planning/stack-advisor/SKILL.md +4 -0
  53. package/src/gdskills/bundled/skills/platform/agent-entrypoint-distiller/SKILL.md +31 -4
  54. package/src/gdskills/bundled/skills/platform/claude-md-management/SKILL.md +26 -2
  55. package/src/gdskills/bundled/skills/platform/hookify/SKILL.md +28 -3
  56. package/src/gdskills/bundled/skills/quality/api-truth/SKILL.md +226 -0
  57. package/src/gdskills/bundled/skills/quality/changelog/SKILL.md +24 -4
  58. package/src/gdskills/bundled/skills/quality/commit/SKILL.md +24 -3
  59. package/src/gdskills/bundled/skills/quality/db-migrate/SKILL.md +24 -3
  60. package/src/gdskills/bundled/skills/quality/dependency-update/SKILL.md +25 -4
  61. package/src/gdskills/bundled/skills/quality/deploy/SKILL.md +26 -3
  62. package/src/gdskills/bundled/skills/quality/deprecation-path/SKILL.md +268 -0
  63. package/src/gdskills/bundled/skills/quality/fresh-eyes/SKILL.md +190 -0
  64. package/src/gdskills/bundled/skills/quality/metaproject-security/SKILL.md +24 -3
  65. package/src/gdskills/bundled/skills/quality/perf-check/SKILL.md +29 -8
  66. package/src/gdskills/bundled/skills/quality/pr/SKILL.md +24 -4
  67. package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.md +25 -2
  68. package/src/gdskills/bundled/skills/quality/push/SKILL.md +24 -3
  69. package/src/gdskills/bundled/skills/quality/root-cause/SKILL.md +204 -0
  70. package/src/gdskills/bundled/skills/quality/security-audit/SKILL.md +25 -4
  71. package/src/gdskills/bundled/skills/quality/test-gen/SKILL.md +24 -3
  72. package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.md +17 -2
  73. package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.md +40 -5
  74. package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.md +41 -1
  75. package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.md +44 -2
  76. package/src/gdskills/bundled/skills/review/code-style-review/SKILL.md +44 -4
  77. package/src/gdskills/bundled/skills/review/review-architecture/SKILL.md +3 -3
  78. package/src/gdskills/bundled/skills/review/review-backend/SKILL.md +2 -3
  79. package/src/gdskills/bundled/skills/review/review-clean-code/SKILL.md +4 -4
  80. package/src/gdskills/bundled/skills/review/review-core-boundaries/SKILL.md +36 -2
  81. package/src/gdskills/bundled/skills/review/review-flow-graph/SKILL.md +37 -3
  82. package/src/gdskills/bundled/skills/review/review-frontend/SKILL.md +2 -4
  83. package/src/gdskills/bundled/skills/review/review-frontend-conventions/SKILL.md +36 -2
  84. package/src/gdskills/bundled/skills/review/review-highload/SKILL.md +3 -5
  85. package/src/gdskills/bundled/skills/review/review-layout/SKILL.md +23 -2
  86. package/src/gdskills/bundled/skills/review/review-logic/SKILL.md +3 -3
  87. package/src/gdskills/bundled/skills/review/review-orchestrator/SKILL.md +9 -29
  88. package/src/gdskills/bundled/skills/review/review-performance/SKILL.md +9 -9
  89. package/src/gdskills/bundled/skills/review/review-pr-feedback/SKILL.md +3 -2
  90. package/src/gdskills/bundled/skills/review/review-regression/SKILL.md +33 -2
  91. package/src/gdskills/bundled/skills/review/review-security-code/SKILL.md +4 -2
  92. package/src/gdskills/bundled/skills/review/review-style/SKILL.md +2 -2
  93. package/src/gdskills/bundled/skills/review/review-testing-practices/SKILL.md +40 -2
  94. package/src/gdskills/bundled/skills/review/review-verifier/SKILL.md +1 -1
  95. package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.codex.md +0 -330
  96. package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.cursor.md +0 -330
  97. package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.opencode.md +0 -330
  98. package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.zed.md +0 -330
  99. package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.codex.md +0 -655
  100. package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.cursor.md +0 -655
  101. package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.opencode.md +0 -655
  102. package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.zed.md +0 -655
  103. package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.codex.md +0 -424
  104. package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.cursor.md +0 -424
  105. package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.opencode.md +0 -424
  106. package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.zed.md +0 -424
  107. package/src/gdskills/bundled/skills/orchestration/feature-dev/SKILL.codex.md +0 -163
  108. package/src/gdskills/bundled/skills/orchestration/feature-dev/SKILL.cursor.md +0 -163
  109. package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.codex.md +0 -373
  110. package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.cursor.md +0 -373
  111. package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.opencode.md +0 -373
  112. package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.zed.md +0 -373
  113. package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.codex.md +0 -374
  114. package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.cursor.md +0 -374
  115. package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.opencode.md +0 -374
  116. package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.zed.md +0 -374
  117. package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.codex.md +0 -2232
  118. package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.cursor.md +0 -2232
  119. package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.opencode.md +0 -2232
  120. package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.zed.md +0 -2232
  121. package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.codex.md +0 -668
  122. package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.cursor.md +0 -668
  123. package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.opencode.md +0 -668
  124. package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.zed.md +0 -668
  125. package/src/gdskills/bundled/skills/planning/brainstorm/SKILL.codex.md +0 -90
  126. package/src/gdskills/bundled/skills/planning/brainstorm/SKILL.cursor.md +0 -90
  127. package/src/gdskills/bundled/skills/planning/interview/SKILL.codex.md +0 -187
  128. package/src/gdskills/bundled/skills/planning/interview/SKILL.cursor.md +0 -187
  129. package/src/gdskills/bundled/skills/planning/interviewer/SKILL.codex.md +0 -105
  130. package/src/gdskills/bundled/skills/planning/interviewer/SKILL.cursor.md +0 -105
  131. package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.codex.md +0 -193
  132. package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.cursor.md +0 -193
  133. package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.opencode.md +0 -193
  134. package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.zed.md +0 -193
  135. package/src/gdskills/bundled/skills/platform/claude-md-management/SKILL.codex.md +0 -87
  136. package/src/gdskills/bundled/skills/platform/claude-md-management/SKILL.cursor.md +0 -87
  137. package/src/gdskills/bundled/skills/platform/hookify/SKILL.codex.md +0 -100
  138. package/src/gdskills/bundled/skills/platform/hookify/SKILL.cursor.md +0 -100
  139. package/src/gdskills/bundled/skills/quality/changelog/SKILL.codex.md +0 -84
  140. package/src/gdskills/bundled/skills/quality/changelog/SKILL.cursor.md +0 -84
  141. package/src/gdskills/bundled/skills/quality/commit/SKILL.codex.md +0 -66
  142. package/src/gdskills/bundled/skills/quality/commit/SKILL.cursor.md +0 -66
  143. package/src/gdskills/bundled/skills/quality/db-migrate/SKILL.codex.md +0 -66
  144. package/src/gdskills/bundled/skills/quality/db-migrate/SKILL.cursor.md +0 -66
  145. package/src/gdskills/bundled/skills/quality/dependency-update/SKILL.codex.md +0 -81
  146. package/src/gdskills/bundled/skills/quality/dependency-update/SKILL.cursor.md +0 -81
  147. package/src/gdskills/bundled/skills/quality/deploy/SKILL.codex.md +0 -70
  148. package/src/gdskills/bundled/skills/quality/deploy/SKILL.cursor.md +0 -70
  149. package/src/gdskills/bundled/skills/quality/perf-check/SKILL.codex.md +0 -83
  150. package/src/gdskills/bundled/skills/quality/perf-check/SKILL.cursor.md +0 -83
  151. package/src/gdskills/bundled/skills/quality/pr/SKILL.codex.md +0 -75
  152. package/src/gdskills/bundled/skills/quality/pr/SKILL.cursor.md +0 -75
  153. package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.codex.md +0 -378
  154. package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.cursor.md +0 -378
  155. package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.opencode.md +0 -378
  156. package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.zed.md +0 -378
  157. package/src/gdskills/bundled/skills/quality/push/SKILL.codex.md +0 -52
  158. package/src/gdskills/bundled/skills/quality/push/SKILL.cursor.md +0 -52
  159. package/src/gdskills/bundled/skills/quality/security-audit/SKILL.codex.md +0 -108
  160. package/src/gdskills/bundled/skills/quality/security-audit/SKILL.cursor.md +0 -108
  161. package/src/gdskills/bundled/skills/quality/test-gen/SKILL.codex.md +0 -80
  162. package/src/gdskills/bundled/skills/quality/test-gen/SKILL.cursor.md +0 -80
  163. package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.codex.md +0 -345
  164. package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.cursor.md +0 -345
  165. package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.opencode.md +0 -345
  166. package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.zed.md +0 -345
  167. package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.codex.md +0 -203
  168. package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.cursor.md +0 -203
  169. package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.opencode.md +0 -203
  170. package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.zed.md +0 -203
  171. package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.codex.md +0 -243
  172. package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.cursor.md +0 -243
  173. package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.opencode.md +0 -243
  174. package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.zed.md +0 -243
  175. package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.codex.md +0 -259
  176. package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.cursor.md +0 -259
  177. package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.opencode.md +0 -259
  178. package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.zed.md +0 -259
  179. package/src/gdskills/bundled/skills/review/code-style-review/SKILL.codex.md +0 -168
  180. package/src/gdskills/bundled/skills/review/code-style-review/SKILL.cursor.md +0 -168
  181. package/src/gdskills/bundled/skills/review/code-style-review/SKILL.opencode.md +0 -168
  182. package/src/gdskills/bundled/skills/review/code-style-review/SKILL.zed.md +0 -168
@@ -1,203 +0,0 @@
1
- ---
2
- name: code-ai-review
3
- description: "Performs strict AI code review following code-review-ai-assistant.mdc standards. Reviews current branch changes from merge-base by default, including both committed and local uncommitted changes. Use when: code review requested, checking branch changes, reviewing implementation quality."
4
- triggers:
5
- - "Code review"
6
- - "Review my changes"
7
- - "Check this code"
8
- - "Review code"
9
- metadata:
10
- author: "MrCipherSmith"
11
- version: "1.0.0"
12
- category: "review"
13
- compatible_harnesses: "cursor,codex,zed,opencode,claude"
14
- license: "MIT"
15
- ---
16
-
17
-
18
- # Code AI Review (только текущая ветка)
19
-
20
- ## Workflow
21
-
22
- Copy this checklist and track progress:
23
-
24
- ```
25
- Code Review Progress:
26
- - [ ] Step 1: Determine parent branch and calculate merge-base
27
- - [ ] Step 2: Collect git diff (committed + local changes)
28
- - [ ] Step 3: Identify changed files and categorize
29
- - [ ] Step 4: Review each file following standards
30
- - [ ] Step 5: Document findings with severity and location
31
- - [ ] Step 6: Generate report with patches
32
- ```
33
-
34
- ## Scope Boundaries
35
- This skill focuses on:
36
- - Correctness and logic bugs
37
- - Type safety and TypeScript contract violations
38
- - Security and null-safety issues
39
- - Error handling completeness
40
- - Performance anti-patterns
41
-
42
- This skill does NOT duplicate:
43
- - MobX store-specific patterns → covered by code-mobx-store-review
44
- - Naming/formatting/import organization → covered by code-style-review
45
- - Architecture opinions and persona-specific insights → covered by code-learned-review
46
-
47
- ## Главное правило: скоуп ревью
48
-
49
- Ревьюй только изменения, внесённые в текущей ветке с момента её ответвления от родительской.
50
-
51
- - Если пользователь **не передал commit hash/range**, включай **весь срез ветки от merge-base до рабочего дерева**:
52
- - закоммиченные (`BASE_SHA..HEAD`)
53
- - локальные незакоммиченные (`staged/unstaged/untracked`)
54
- - Если пользователь **явно передал commit hash/range**, ревьюй только запрошенный диапазон; локальные незакоммиченные изменения не добавляй, если это отдельно не попросили.
55
- - Не ревьюй не связанные с веткой части репозитория.
56
-
57
- ## Scope Detection
58
-
59
- See shared script: `.metaproject/skills/gdskills/shared/git-merge-base.md`
60
-
61
- Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
62
-
63
- ## Команды, чтобы собрать “срез” для ревью
64
-
65
- ### A) Режим по умолчанию (пользователь НЕ дал hash/range)
66
-
67
- ```bash
68
- git status
69
-
70
- # Закоммиченная часть ветки
71
- git log --oneline "${BASE_SHA}..HEAD"
72
- git diff --stat "${BASE_SHA}..HEAD"
73
- git diff --name-status "${BASE_SHA}..HEAD"
74
- git diff "${BASE_SHA}..HEAD"
75
-
76
- # Полный текущий срез от merge-base до рабочего дерева:
77
- # включает commit'ы + staged + unstaged
78
- # (untracked смотри через git status / git ls-files)
79
- git diff --stat "${BASE_SHA}"
80
- git diff --name-status "${BASE_SHA}"
81
- git diff "${BASE_SHA}"
82
- git ls-files --others --exclude-standard
83
- ```
84
-
85
- ### B) Режим с явным hash/range
86
-
87
- ```bash
88
- # Примеры:
89
- git show --stat --name-status --patch <COMMIT_SHA>
90
- git log --oneline <FROM_SHA>..<TO_SHA>
91
- git diff --stat <FROM_SHA>..<TO_SHA>
92
- git diff --name-status <FROM_SHA>..<TO_SHA>
93
- git diff <FROM_SHA>..<TO_SHA>
94
- ```
95
-
96
- ## Правила ревью (обязательно)
97
-
98
- Ты обязан следовать стандарту ревью из `.metaproject/rules/core/code-review-ai-assistant.mdc`:
99
-
100
- - Structure output as: short summary -> structured findings by category -> concrete suggestions / optional patches.
101
- - Prioritize correctness and safety over style.
102
- - Avoid noise; focus on actionable, high-signal findings.
103
- - Do not request large refactors unless explicitly asked.
104
-
105
- ## Формат вывода (шаблон подробного отчёта)
106
-
107
- Пиши ревью по структуре ниже:
108
-
109
- ```markdown
110
- ## Краткое резюме
111
- <1-3 предложения: что сделано и общий вердикт (OK / needs work).>
112
-
113
- ## Скоуп ревью (только текущая ветка)
114
- - Ветка: `<BRANCH>`
115
- - Parent ref: `<PARENT>`
116
- - Merge-base: `<BASE_SHA>`
117
- - Режим скоупа: `<default-with-uncommitted | explicit-hash-range>`
118
- - Коммиты (merge-base..HEAD): <N>
119
- - Изменённые файлы: <список или количество>
120
-
121
- ## Находки
122
- ### Correctness
123
- <находки>
124
-
125
- ### Types & Safety
126
- <находки>
127
-
128
- ### Architecture & State
129
- <находки>
130
-
131
- ### Readability & Style
132
- <находки>
133
-
134
- ### Performance
135
- <находки>
136
-
137
- ### UX/UI
138
- <находки>
139
-
140
- ### A11y
141
- <находки>
142
-
143
- ### Tests
144
- <находки>
145
-
146
- ## Предложенные исправления (patches)
147
- <минимальные, точечные диффы для самых очевидных фиксов>
148
- ```
149
-
150
- ### Формат каждой находки (обязательно)
151
-
152
- Для каждой находки укажи:
153
-
154
- - **Severity**: `blocker` / `major` / `minor`
155
- - **Location**: file path + relevant lines/hunk (from the diff)
156
- - **Problem**: what is wrong
157
- - **Why it matters**: correctness/safety/perf/maintainability impact
158
- - **Suggested fix**: concrete change
159
- - **Optional patch**: provide a minimal unified diff when straightforward
160
-
161
- Пример блока патча:
162
-
163
- ```diff
164
- diff --git a/path/file.ts b/path/file.ts
165
- index 0000000..1111111 100644
166
- --- a/path/file.ts
167
- +++ b/path/file.ts
168
- @@ -1,3 +1,3 @@
169
- -const x = 1;
170
- +const x = 2;
171
- ```
172
-
173
- ---
174
-
175
- ## Scope Boundaries
176
-
177
- This skill covers **general AI code quality review** following `code-review-ai-assistant.mdc`.
178
-
179
- | Concern | This skill | Use instead |
180
- |---------|-----------|-------------|
181
- | Types, safety, architecture, readability, performance, tests | ✅ YES | — |
182
- | MobX store internals (actions, computed, reactions, async) | ⚠️ surface-level only | `code-mobx-store-review` for deep store analysis |
183
- | Review against this project's own learned conventions | ❌ NO | `code-learned-review` |
184
- | Pure style/naming/pattern audit | ❌ NO | `code-style-review` |
185
-
186
- ---
187
-
188
- ## Job Context Awareness
189
-
190
- When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
191
-
192
- ```
193
- JOB_NAME: <job-name>
194
- CONTEXT_PATH: .metaproject/jobs/<job-name>/ai/context.md
195
- ```
196
-
197
- If provided and the file exists, read the context document before starting the review. Use it to:
198
- - Understand which libraries and patterns were intentionally chosen for the implementation
199
- - Avoid flagging correct library usage as issues (e.g., if context documents the API pattern)
200
- - Provide more accurate findings by understanding the project's architectural decisions
201
- - Reference context when justifying suggestions
202
-
203
- If the file does not exist or is not provided, proceed normally — context is optional and non-blocking.
@@ -1,203 +0,0 @@
1
- ---
2
- name: code-ai-review
3
- description: "Performs strict AI code review following code-review-ai-assistant.mdc standards. Reviews current branch changes from merge-base by default, including both committed and local uncommitted changes. Use when: code review requested, checking branch changes, reviewing implementation quality."
4
- triggers:
5
- - "Code review"
6
- - "Review my changes"
7
- - "Check this code"
8
- - "Review code"
9
- metadata:
10
- author: "MrCipherSmith"
11
- version: "1.0.0"
12
- category: "review"
13
- compatible_harnesses: "cursor,codex,zed,opencode,claude"
14
- license: "MIT"
15
- ---
16
-
17
-
18
- # Code AI Review (только текущая ветка)
19
-
20
- ## Workflow
21
-
22
- Copy this checklist and track progress:
23
-
24
- ```
25
- Code Review Progress:
26
- - [ ] Step 1: Determine parent branch and calculate merge-base
27
- - [ ] Step 2: Collect git diff (committed + local changes)
28
- - [ ] Step 3: Identify changed files and categorize
29
- - [ ] Step 4: Review each file following standards
30
- - [ ] Step 5: Document findings with severity and location
31
- - [ ] Step 6: Generate report with patches
32
- ```
33
-
34
- ## Scope Boundaries
35
- This skill focuses on:
36
- - Correctness and logic bugs
37
- - Type safety and TypeScript contract violations
38
- - Security and null-safety issues
39
- - Error handling completeness
40
- - Performance anti-patterns
41
-
42
- This skill does NOT duplicate:
43
- - MobX store-specific patterns → covered by code-mobx-store-review
44
- - Naming/formatting/import organization → covered by code-style-review
45
- - Architecture opinions and persona-specific insights → covered by code-learned-review
46
-
47
- ## Главное правило: скоуп ревью
48
-
49
- Ревьюй только изменения, внесённые в текущей ветке с момента её ответвления от родительской.
50
-
51
- - Если пользователь **не передал commit hash/range**, включай **весь срез ветки от merge-base до рабочего дерева**:
52
- - закоммиченные (`BASE_SHA..HEAD`)
53
- - локальные незакоммиченные (`staged/unstaged/untracked`)
54
- - Если пользователь **явно передал commit hash/range**, ревьюй только запрошенный диапазон; локальные незакоммиченные изменения не добавляй, если это отдельно не попросили.
55
- - Не ревьюй не связанные с веткой части репозитория.
56
-
57
- ## Scope Detection
58
-
59
- See shared script: `.metaproject/skills/gdskills/shared/git-merge-base.md`
60
-
61
- Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
62
-
63
- ## Команды, чтобы собрать “срез” для ревью
64
-
65
- ### A) Режим по умолчанию (пользователь НЕ дал hash/range)
66
-
67
- ```bash
68
- git status
69
-
70
- # Закоммиченная часть ветки
71
- git log --oneline "${BASE_SHA}..HEAD"
72
- git diff --stat "${BASE_SHA}..HEAD"
73
- git diff --name-status "${BASE_SHA}..HEAD"
74
- git diff "${BASE_SHA}..HEAD"
75
-
76
- # Полный текущий срез от merge-base до рабочего дерева:
77
- # включает commit'ы + staged + unstaged
78
- # (untracked смотри через git status / git ls-files)
79
- git diff --stat "${BASE_SHA}"
80
- git diff --name-status "${BASE_SHA}"
81
- git diff "${BASE_SHA}"
82
- git ls-files --others --exclude-standard
83
- ```
84
-
85
- ### B) Режим с явным hash/range
86
-
87
- ```bash
88
- # Примеры:
89
- git show --stat --name-status --patch <COMMIT_SHA>
90
- git log --oneline <FROM_SHA>..<TO_SHA>
91
- git diff --stat <FROM_SHA>..<TO_SHA>
92
- git diff --name-status <FROM_SHA>..<TO_SHA>
93
- git diff <FROM_SHA>..<TO_SHA>
94
- ```
95
-
96
- ## Правила ревью (обязательно)
97
-
98
- Ты обязан следовать стандарту ревью из `.metaproject/rules/core/code-review-ai-assistant.mdc`:
99
-
100
- - Structure output as: short summary -> structured findings by category -> concrete suggestions / optional patches.
101
- - Prioritize correctness and safety over style.
102
- - Avoid noise; focus on actionable, high-signal findings.
103
- - Do not request large refactors unless explicitly asked.
104
-
105
- ## Формат вывода (шаблон подробного отчёта)
106
-
107
- Пиши ревью по структуре ниже:
108
-
109
- ```markdown
110
- ## Краткое резюме
111
- <1-3 предложения: что сделано и общий вердикт (OK / needs work).>
112
-
113
- ## Скоуп ревью (только текущая ветка)
114
- - Ветка: `<BRANCH>`
115
- - Parent ref: `<PARENT>`
116
- - Merge-base: `<BASE_SHA>`
117
- - Режим скоупа: `<default-with-uncommitted | explicit-hash-range>`
118
- - Коммиты (merge-base..HEAD): <N>
119
- - Изменённые файлы: <список или количество>
120
-
121
- ## Находки
122
- ### Correctness
123
- <находки>
124
-
125
- ### Types & Safety
126
- <находки>
127
-
128
- ### Architecture & State
129
- <находки>
130
-
131
- ### Readability & Style
132
- <находки>
133
-
134
- ### Performance
135
- <находки>
136
-
137
- ### UX/UI
138
- <находки>
139
-
140
- ### A11y
141
- <находки>
142
-
143
- ### Tests
144
- <находки>
145
-
146
- ## Предложенные исправления (patches)
147
- <минимальные, точечные диффы для самых очевидных фиксов>
148
- ```
149
-
150
- ### Формат каждой находки (обязательно)
151
-
152
- Для каждой находки укажи:
153
-
154
- - **Severity**: `blocker` / `major` / `minor`
155
- - **Location**: file path + relevant lines/hunk (from the diff)
156
- - **Problem**: what is wrong
157
- - **Why it matters**: correctness/safety/perf/maintainability impact
158
- - **Suggested fix**: concrete change
159
- - **Optional patch**: provide a minimal unified diff when straightforward
160
-
161
- Пример блока патча:
162
-
163
- ```diff
164
- diff --git a/path/file.ts b/path/file.ts
165
- index 0000000..1111111 100644
166
- --- a/path/file.ts
167
- +++ b/path/file.ts
168
- @@ -1,3 +1,3 @@
169
- -const x = 1;
170
- +const x = 2;
171
- ```
172
-
173
- ---
174
-
175
- ## Scope Boundaries
176
-
177
- This skill covers **general AI code quality review** following `code-review-ai-assistant.mdc`.
178
-
179
- | Concern | This skill | Use instead |
180
- |---------|-----------|-------------|
181
- | Types, safety, architecture, readability, performance, tests | ✅ YES | — |
182
- | MobX store internals (actions, computed, reactions, async) | ⚠️ surface-level only | `code-mobx-store-review` for deep store analysis |
183
- | Review against this project's own learned conventions | ❌ NO | `code-learned-review` |
184
- | Pure style/naming/pattern audit | ❌ NO | `code-style-review` |
185
-
186
- ---
187
-
188
- ## Job Context Awareness
189
-
190
- When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
191
-
192
- ```
193
- JOB_NAME: <job-name>
194
- CONTEXT_PATH: .metaproject/jobs/<job-name>/ai/context.md
195
- ```
196
-
197
- If provided and the file exists, read the context document before starting the review. Use it to:
198
- - Understand which libraries and patterns were intentionally chosen for the implementation
199
- - Avoid flagging correct library usage as issues (e.g., if context documents the API pattern)
200
- - Provide more accurate findings by understanding the project's architectural decisions
201
- - Reference context when justifying suggestions
202
-
203
- If the file does not exist or is not provided, proceed normally — context is optional and non-blocking.
@@ -1,203 +0,0 @@
1
- ---
2
- name: code-ai-review
3
- description: "Performs strict AI code review following code-review-ai-assistant.mdc standards. Reviews current branch changes from merge-base by default, including both committed and local uncommitted changes. Use when: code review requested, checking branch changes, reviewing implementation quality."
4
- triggers:
5
- - "Code review"
6
- - "Review my changes"
7
- - "Check this code"
8
- - "Review code"
9
- metadata:
10
- author: "MrCipherSmith"
11
- version: "1.0.0"
12
- category: "review"
13
- compatible_harnesses: "cursor,codex,zed,opencode,claude"
14
- license: "MIT"
15
- ---
16
-
17
-
18
- # Code AI Review (только текущая ветка)
19
-
20
- ## Workflow
21
-
22
- Copy this checklist and track progress:
23
-
24
- ```
25
- Code Review Progress:
26
- - [ ] Step 1: Determine parent branch and calculate merge-base
27
- - [ ] Step 2: Collect git diff (committed + local changes)
28
- - [ ] Step 3: Identify changed files and categorize
29
- - [ ] Step 4: Review each file following standards
30
- - [ ] Step 5: Document findings with severity and location
31
- - [ ] Step 6: Generate report with patches
32
- ```
33
-
34
- ## Scope Boundaries
35
- This skill focuses on:
36
- - Correctness and logic bugs
37
- - Type safety and TypeScript contract violations
38
- - Security and null-safety issues
39
- - Error handling completeness
40
- - Performance anti-patterns
41
-
42
- This skill does NOT duplicate:
43
- - MobX store-specific patterns → covered by code-mobx-store-review
44
- - Naming/formatting/import organization → covered by code-style-review
45
- - Architecture opinions and persona-specific insights → covered by code-learned-review
46
-
47
- ## Главное правило: скоуп ревью
48
-
49
- Ревьюй только изменения, внесённые в текущей ветке с момента её ответвления от родительской.
50
-
51
- - Если пользователь **не передал commit hash/range**, включай **весь срез ветки от merge-base до рабочего дерева**:
52
- - закоммиченные (`BASE_SHA..HEAD`)
53
- - локальные незакоммиченные (`staged/unstaged/untracked`)
54
- - Если пользователь **явно передал commit hash/range**, ревьюй только запрошенный диапазон; локальные незакоммиченные изменения не добавляй, если это отдельно не попросили.
55
- - Не ревьюй не связанные с веткой части репозитория.
56
-
57
- ## Scope Detection
58
-
59
- See shared script: `.metaproject/skills/gdskills/shared/git-merge-base.md`
60
-
61
- Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
62
-
63
- ## Команды, чтобы собрать “срез” для ревью
64
-
65
- ### A) Режим по умолчанию (пользователь НЕ дал hash/range)
66
-
67
- ```bash
68
- git status
69
-
70
- # Закоммиченная часть ветки
71
- git log --oneline "${BASE_SHA}..HEAD"
72
- git diff --stat "${BASE_SHA}..HEAD"
73
- git diff --name-status "${BASE_SHA}..HEAD"
74
- git diff "${BASE_SHA}..HEAD"
75
-
76
- # Полный текущий срез от merge-base до рабочего дерева:
77
- # включает commit'ы + staged + unstaged
78
- # (untracked смотри через git status / git ls-files)
79
- git diff --stat "${BASE_SHA}"
80
- git diff --name-status "${BASE_SHA}"
81
- git diff "${BASE_SHA}"
82
- git ls-files --others --exclude-standard
83
- ```
84
-
85
- ### B) Режим с явным hash/range
86
-
87
- ```bash
88
- # Примеры:
89
- git show --stat --name-status --patch <COMMIT_SHA>
90
- git log --oneline <FROM_SHA>..<TO_SHA>
91
- git diff --stat <FROM_SHA>..<TO_SHA>
92
- git diff --name-status <FROM_SHA>..<TO_SHA>
93
- git diff <FROM_SHA>..<TO_SHA>
94
- ```
95
-
96
- ## Правила ревью (обязательно)
97
-
98
- Ты обязан следовать стандарту ревью из `.metaproject/rules/core/code-review-ai-assistant.mdc`:
99
-
100
- - Structure output as: short summary -> structured findings by category -> concrete suggestions / optional patches.
101
- - Prioritize correctness and safety over style.
102
- - Avoid noise; focus on actionable, high-signal findings.
103
- - Do not request large refactors unless explicitly asked.
104
-
105
- ## Формат вывода (шаблон подробного отчёта)
106
-
107
- Пиши ревью по структуре ниже:
108
-
109
- ```markdown
110
- ## Краткое резюме
111
- <1-3 предложения: что сделано и общий вердикт (OK / needs work).>
112
-
113
- ## Скоуп ревью (только текущая ветка)
114
- - Ветка: `<BRANCH>`
115
- - Parent ref: `<PARENT>`
116
- - Merge-base: `<BASE_SHA>`
117
- - Режим скоупа: `<default-with-uncommitted | explicit-hash-range>`
118
- - Коммиты (merge-base..HEAD): <N>
119
- - Изменённые файлы: <список или количество>
120
-
121
- ## Находки
122
- ### Correctness
123
- <находки>
124
-
125
- ### Types & Safety
126
- <находки>
127
-
128
- ### Architecture & State
129
- <находки>
130
-
131
- ### Readability & Style
132
- <находки>
133
-
134
- ### Performance
135
- <находки>
136
-
137
- ### UX/UI
138
- <находки>
139
-
140
- ### A11y
141
- <находки>
142
-
143
- ### Tests
144
- <находки>
145
-
146
- ## Предложенные исправления (patches)
147
- <минимальные, точечные диффы для самых очевидных фиксов>
148
- ```
149
-
150
- ### Формат каждой находки (обязательно)
151
-
152
- Для каждой находки укажи:
153
-
154
- - **Severity**: `blocker` / `major` / `minor`
155
- - **Location**: file path + relevant lines/hunk (from the diff)
156
- - **Problem**: what is wrong
157
- - **Why it matters**: correctness/safety/perf/maintainability impact
158
- - **Suggested fix**: concrete change
159
- - **Optional patch**: provide a minimal unified diff when straightforward
160
-
161
- Пример блока патча:
162
-
163
- ```diff
164
- diff --git a/path/file.ts b/path/file.ts
165
- index 0000000..1111111 100644
166
- --- a/path/file.ts
167
- +++ b/path/file.ts
168
- @@ -1,3 +1,3 @@
169
- -const x = 1;
170
- +const x = 2;
171
- ```
172
-
173
- ---
174
-
175
- ## Scope Boundaries
176
-
177
- This skill covers **general AI code quality review** following `code-review-ai-assistant.mdc`.
178
-
179
- | Concern | This skill | Use instead |
180
- |---------|-----------|-------------|
181
- | Types, safety, architecture, readability, performance, tests | ✅ YES | — |
182
- | MobX store internals (actions, computed, reactions, async) | ⚠️ surface-level only | `code-mobx-store-review` for deep store analysis |
183
- | Review against this project's own learned conventions | ❌ NO | `code-learned-review` |
184
- | Pure style/naming/pattern audit | ❌ NO | `code-style-review` |
185
-
186
- ---
187
-
188
- ## Job Context Awareness
189
-
190
- When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
191
-
192
- ```
193
- JOB_NAME: <job-name>
194
- CONTEXT_PATH: .metaproject/jobs/<job-name>/ai/context.md
195
- ```
196
-
197
- If provided and the file exists, read the context document before starting the review. Use it to:
198
- - Understand which libraries and patterns were intentionally chosen for the implementation
199
- - Avoid flagging correct library usage as issues (e.g., if context documents the API pattern)
200
- - Provide more accurate findings by understanding the project's architectural decisions
201
- - Reference context when justifying suggestions
202
-
203
- If the file does not exist or is not provided, proceed normally — context is optional and non-blocking.