@mrciphersmith/keryx 0.2.96 → 0.2.98

package/src/gdskills/bundled/skills/review/review-orchestrator/reviewer-input.schema.json

@@ -7,7 +7,7 @@
     "review_context",
     "reviewer",
     "scope_mode",
-    "model_class",
+    "model",
     "budget"
   ],
   "properties": {
@@ -36,14 +36,58 @@
         "null"
       ]
     },
-    "model_class": {
-      "type": "string",
-      "enum": [
-        "simple",
-        "normal",
-        "complex",
-        "current-session"
-      ]
+    "model": {
+      "description": "The `model` block `keryx review tier` printed for this dispatch (Step 6) — pasted verbatim, never composed by hand. `tier` is the mechanical vocabulary the command emits (`light`/`standard`/`deep`), never a model name. `provider`/`model` are present when the command resolved a concrete model; `inherit: true` replaces them when it could not, meaning the dispatch runs on the caller's own model. Field naming matches `model` in `contracts/subagent-dispatch.schema.json` and the object `keryx review tier --json` prints under its own `model` key.",
+      "type": "object",
+      "additionalProperties": false,
+      "required": [
+        "tier",
+        "tier_reasons",
+        "tier_resolution",
+        "model_discovery"
+      ],
+      "properties": {
+        "tier": {
+          "type": "string",
+          "enum": [
+            "light",
+            "standard",
+            "deep"
+          ]
+        },
+        "tier_reasons": {
+          "type": "array",
+          "items": {
+            "type": "string",
+            "minLength": 1
+          }
+        },
+        "provider": {
+          "type": "string",
+          "minLength": 1
+        },
+        "model": {
+          "type": "string",
+          "minLength": 1
+        },
+        "inherit": {
+          "type": "boolean",
+          "description": "Run this dispatch on the caller's own model. Present in place of `provider`/`model`, never alongside them, when `keryx review tier` could not resolve a concrete model."
+        },
+        "tier_resolution": {
+          "type": "string",
+          "enum": [
+            "discovered",
+            "session-ranked",
+            "session-fallback"
+          ]
+        },
+        "model_discovery": {
+          "type": "object",
+          "description": "What `keryx review tier` discovered and how it ranked it, as printed. Not re-validated field by field here — that contract lives in `contracts/subagent-dispatch.schema.json`.",
+          "additionalProperties": true
+        }
+      }
     },
     "budget": {
       "type": "object",

package/src/gdskills/bundled/skills/review/review-performance/SKILL.md

@@ -62,7 +62,7 @@ This skill focuses on **measurable or high-likelihood bottlenecks** only. Premat
 
 ## Scope Detection
 
-See shared script: `skills/shared/git-merge-base.md`
+See shared script: `.metaproject/skills/gdskills/shared/git-merge-base.md`
 
 Run the script from that file to determine `MERGE_BASE` (`BASE_SHA`) and `SCOPE` before proceeding.
 
@@ -368,7 +368,7 @@ If the file does not exist or is not provided, proceed normally — context is o
 
 ## Orchestrated Review Contract
 
-When dispatched by `review-orchestrator`, follow the provided `reviewer-input.schema.json` payload. Return a `REVIEW_RESULT` object compatible with `skills/review/review-orchestrator/reviewer-finding.schema.json`, then a concise markdown summary. Keep findings evidence-based, include concrete `suggested_fix` for every blocker/major, and return `NEEDS_CONTEXT` instead of guessing when required context is missing.
+When dispatched by `review-orchestrator`, follow the provided `reviewer-input.schema.json` payload. Return a `REVIEW_RESULT` object compatible with `.metaproject/skills/gdskills/review/review-orchestrator/reviewer-finding.schema.json`, then a concise markdown summary. Keep findings evidence-based, include concrete `suggested_fix` for every blocker/major, and return `NEEDS_CONTEXT` instead of guessing when required context is missing.
 
 ---
 

package/src/gdskills/bundled/skills/review/review-pr-feedback/SKILL.md

@@ -80,8 +80,8 @@ review-pr-feedback Progress:
 | `comment_ids` | string[] | no | Restrict the run to these collected comment ids. Every excluded comment is listed with that reason. |
 | `max_fix_rounds` | integer | no | Sent in the Step 9 dispatch as an `attempt budget:` constraint. It only ever LOWERS the bound `flow-orchestrator` owns; omit it to take that skill's own. |
 
-Schemas: `skills/review/review-pr-feedback/input-contract.schema.json` and
-`skills/review/review-pr-feedback/output-contract.schema.json`. Nothing refuses a
+Schemas: `.metaproject/skills/gdskills/review/review-pr-feedback/input-contract.schema.json` and
+`.metaproject/skills/gdskills/review/review-pr-feedback/output-contract.schema.json`. Nothing refuses a
 dispatch that ignores them — no production code loads either file — so they are a
 contract between agents, and this skill validating its own output against the
 output schema is what makes them worth writing.
@@ -297,7 +297,7 @@ For each comment, classify intent before explaining:
 
 This maps the **intent of an incoming human comment**, which is not a code
 condition. It is not a second severity rubric: the levels themselves are defined
-once, in `skills/review/review-orchestrator/SKILL.md` → **Severity (canonical)**,
+once, in `.metaproject/skills/gdskills/review/review-orchestrator/SKILL.md` → **Severity (canonical)**,
 and a mapped value is a starting point that the canonical test overrides whenever
 the comment names a concrete trigger and outcome.
 
@@ -504,7 +504,7 @@ implementation loop of its own, and a second one would diverge from the one that
 is tested.
 
 Dispatch payload, conforming to
-`skills/orchestration/flow-orchestrator/input-contract.schema.json` — a registered
+`.metaproject/skills/gdskills/orchestration/flow-orchestrator/input-contract.schema.json` — a registered
 contract, so `keryx skills contracts validate <file> --schema flow-orchestrator-input`
 refuses a malformed one. Validate before dispatching.
 
@@ -539,13 +539,13 @@ criterion rather than by an author's assertion.
 ### The loop, and its bound
 
 The review→fix→review loop belongs to `flow-orchestrator`, and so does its exit
-threshold: `skills/orchestration/flow-orchestrator/SKILL.md` → **PR review/fix
+threshold: `.metaproject/skills/gdskills/orchestration/flow-orchestrator/SKILL.md` → **PR review/fix
 loop** defines it once, beside the bound. Do not restate the level here — the
 bound was centralised and the threshold was left copied four ways in the same
 edit, which is how one of them ends up stale while every guard stays green.
 
 The bound is defined once, in
-`skills/orchestration/flow-orchestrator/SKILL.md` → **PR review/fix loop**, along
+`.metaproject/skills/gdskills/orchestration/flow-orchestrator/SKILL.md` → **PR review/fix loop**, along
 with the evidence behind it and the `keryx review loop` repetition check that
 runs before any attempt is spent. Do not restate the number here: two copies of a
 bound are two things to edit when the evidence changes, and the copy nobody edits

package/src/gdskills/bundled/skills/review/review-security-code/SKILL.md

@@ -61,7 +61,7 @@ This skill covers **code-level security only**. It does NOT audit npm/bun depend
 
 ## Scope Detection
 
-See shared script: `skills/shared/git-merge-base.md`
+See shared script: `.metaproject/skills/gdskills/shared/git-merge-base.md`
 
 Run the script from that file to determine `MERGE_BASE` (`BASE_SHA`) and `SCOPE` before proceeding.
 
@@ -373,7 +373,7 @@ If the file does not exist or is not provided, proceed normally — context is o
 
 ## Orchestrated Review Contract
 
-When dispatched by `review-orchestrator`, follow the provided `reviewer-input.schema.json` payload. Return a `REVIEW_RESULT` object compatible with `skills/review/review-orchestrator/reviewer-finding.schema.json`, then a concise markdown summary. Keep findings evidence-based, include concrete `suggested_fix` for every blocker/major, and return `NEEDS_CONTEXT` instead of guessing when required context is missing.
+When dispatched by `review-orchestrator`, follow the provided `reviewer-input.schema.json` payload. Return a `REVIEW_RESULT` object compatible with `.metaproject/skills/gdskills/review/review-orchestrator/reviewer-finding.schema.json`, then a concise markdown summary. Keep findings evidence-based, include concrete `suggested_fix` for every blocker/major, and return `NEEDS_CONTEXT` instead of guessing when required context is missing.
 
 ---
 

package/src/gdskills/bundled/skills/review/review-style/SKILL.md

@@ -34,7 +34,7 @@ Never touches logic correctness, architecture, security, or performance.
 ```
 review-style Progress:
 - [ ] Step 1: Read Job Context (if CONTEXT_PATH provided)
-- [ ] Step 2: Determine git scope (merge-base) — see skills/shared/git-merge-base.md
+- [ ] Step 2: Determine git scope (merge-base) — see .metaproject/skills/gdskills/shared/git-merge-base.md
 - [ ] Step 3: Collect diff and changed file list
 - [ ] Step 4: Naming conventions check
 - [ ] Step 5: Dead code and imports check
@@ -60,7 +60,7 @@ review-style Progress:
 
 ## Scope Detection
 
-See shared script: `skills/shared/git-merge-base.md`
+See shared script: `.metaproject/skills/gdskills/shared/git-merge-base.md`
 
 Run that script to determine `BASE_SHA` before collecting the diff.
 
@@ -228,7 +228,7 @@ boundary is the trigger-and-outcome test.
 
 ## Orchestrated Review Contract
 
-When dispatched by `review-orchestrator`, follow the provided `reviewer-input.schema.json` payload. Return a `REVIEW_RESULT` object compatible with `skills/review/review-orchestrator/reviewer-finding.schema.json`, then a concise markdown summary. Keep findings evidence-based, include concrete `suggested_fix` for every blocker/major, and return `NEEDS_CONTEXT` instead of guessing when required context is missing.
+When dispatched by `review-orchestrator`, follow the provided `reviewer-input.schema.json` payload. Return a `REVIEW_RESULT` object compatible with `.metaproject/skills/gdskills/review/review-orchestrator/reviewer-finding.schema.json`, then a concise markdown summary. Keep findings evidence-based, include concrete `suggested_fix` for every blocker/major, and return `NEEDS_CONTEXT` instead of guessing when required context is missing.
 
 ---
 

package/src/gdskills/bundled/skills/review/review-testing-practices/SKILL.md

@@ -207,7 +207,7 @@ boundary is the trigger-and-outcome test.
 
 ## Orchestrated Review Contract
 
-When dispatched by `review-orchestrator`, follow the provided `reviewer-input.schema.json` payload. Return a `REVIEW_RESULT` object compatible with `skills/review/review-orchestrator/reviewer-finding.schema.json`, then a concise markdown summary. Keep findings evidence-based, include concrete `suggested_fix` for every blocker/major, and return `NEEDS_CONTEXT` instead of guessing when required context is missing.
+When dispatched by `review-orchestrator`, follow the provided `reviewer-input.schema.json` payload. Return a `REVIEW_RESULT` object compatible with `.metaproject/skills/gdskills/review/review-orchestrator/reviewer-finding.schema.json`, then a concise markdown summary. Keep findings evidence-based, include concrete `suggested_fix` for every blocker/major, and return `NEEDS_CONTEXT` instead of guessing when required context is missing.
 
 ---
 

package/src/gdskills/bundled/skills/review/review-verifier/SKILL.md

@@ -224,7 +224,7 @@ STATUS: DONE | NEEDS_CONTEXT | BLOCKED
 There is no `DONE_WITH_CONCERNS`: a verifier has no concerns of its own.
 
 Return one object conforming to
-`skills/review/review-orchestrator/verification-claim.schema.json`:
+`.metaproject/skills/gdskills/review/review-orchestrator/verification-claim.schema.json`:
 
 ````text
 ```json keryx:verifications

package/src/gdskills/bundled/rules/core/review-agent-profile.mdc

@@ -1,49 +0,0 @@
----
-description: "Baseline AI code review standards for correctness, architecture, safety, and maintainability."
-alwaysApply: false
----
-
-# AI Code Review Assistant
-
-## Purpose
-Provide strict, high-signal code reviews with actionable findings.
-
-## When To Apply
-Apply when performing AI-assisted code review; loaded automatically by the code-ai-review skill.
-
-## Verdict Labels
-
-All reviews must end with exactly one of the following verdict labels:
-
-| Verdict | Meaning |
-|---------|---------|
-| `APPROVE` | Changes accepted as-is; no outstanding issues. |
-| `APPROVE WITH SUGGESTIONS` | Accepted and can merge, but improvements are noted for follow-up. |
-| `REQUEST CHANGES` | Must fix identified issues before merge. |
-| `COMMENT` | Informational findings only; no blocking action required. |
-
-## Review Output Structure
-1. Verdict label (from the table above)
-2. Findings by severity and category
-3. Concrete fix proposals
-4. Residual risks and test gaps
-
-## Priority Categories
-- Correctness
-- Types and safety
-- Architecture and state boundaries
-- Performance
-- UX/A11y
-- Tests
-
-## Mandatory Rules
-- Prioritize correctness over style.
-- Do not request massive refactors unless user asks.
-- Flag unsafe casts and hidden complexity.
-- Align suggestions with existing project patterns.
-- Keep comments specific, respectful, and actionable.
-
-## Output Contract
-- Final review must be Markdown.
-- Code snippets/diffs must be fenced code blocks.
-- Response language follows user query language.

package/src/gdskills/bundled/rules/core/review-strict-profile.mdc

@@ -1,48 +0,0 @@
----
-description: "Strict review profile: direct, architecture-first feedback with concrete fixes."
-alwaysApply: false
----
-
-# Strict Review Profile
-
-## Purpose
-Apply a strict, architecture-first pass: name the defect, name where the logic
-belongs, and give the replacement.
-
-## When To Apply
-Apply when the caller explicitly asks for a strict review. For a checklist this
-project learned from its own pull-request comments, use
-`core/code-review-learned-profile.mdc` instead — that one carries no conventions
-of its own and reads them from the project.
-
-## Style Profile
-- Direct and concise.
-- Architecture-first.
-- Strongly against duct-tape fixes.
-- Focus on testability and single source of truth.
-
-## What To Flag
-- Business logic in UI instead of store/service.
-- Duplicate rule checks in multiple places.
-- Unsafe casts (`any`, disguised casts).
-- Mocks inheriting production classes.
-- Loading/no-data semantics confusion.
-- Magic numbers without rationale.
-- **Status/result mapping semantics**: Mapping "none" or absence-of-result to a semantic outcome (e.g. canceled, failed) without domain justification. Verify that source enum values (e.g. none, killed, cancelled) have distinct meanings and that the mapping preserves them; flag mappings that equate semantically different states (e.g. `none === canceled`, `killed === canceled` without explicit product rationale).
-- **Store method accessibility** — See `core/mobx-store-template.mdc` for definitive rules on public vs private store methods. Key violations to flag:
-  - Public `onChangeX` / `handleX` methods (must be private)
-  - Public `action.bound` that should be private callbacks
-
-## Response Format
-1. Verdict in one line — use the canonical verdict vocabulary (same set as `core/code-review-ai-assistant.mdc`):
-   - `APPROVE` — no blocking issues; changes accepted as-is
-   - `APPROVE WITH SUGGESTIONS` — accepted but improvements noted for follow-up
-   - `REQUEST CHANGES` — has issues that must be fixed before merge
-   - `COMMENT` — informational findings only; no blocking action required
-2. Top 1-3 blocking findings.
-3. Concrete replacement/fix path.
-
-## Guardrails
-- No personal attacks.
-- No empty nitpicks.
-- Keep recommendations lint-safe and scoped.