@mrciphersmith/keryx 0.2.9

package/src/gdskills/bundled/skills/review/review-orchestrator/reviewer-finding.schema.json

@@ -0,0 +1,189 @@
+{
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "reviewer-finding",
+  "title": "Reviewer Result and Findings",
+  "type": "object",
+  "required": [
+    "status",
+    "reviewer",
+    "summary",
+    "findings",
+    "stats"
+  ],
+  "properties": {
+    "status": {
+      "type": "string",
+      "enum": [
+        "DONE",
+        "DONE_WITH_CONCERNS",
+        "NEEDS_CONTEXT",
+        "BLOCKED"
+      ]
+    },
+    "reviewer": {
+      "type": "string"
+    },
+    "summary": {
+      "type": "string"
+    },
+    "findings": {
+      "type": "array",
+      "items": {
+        "type": "object",
+        "required": [
+          "id",
+          "severity",
+          "problem",
+          "impact",
+          "suggested_fix",
+          "evidence",
+          "confidence",
+          "reviewer"
+        ],
+        "properties": {
+          "id": {
+            "type": "string"
+          },
+          "severity": {
+            "type": "string",
+            "enum": [
+              "blocker",
+              "major",
+              "minor",
+              "info"
+            ]
+          },
+          "file": {
+            "type": [
+              "string",
+              "null"
+            ]
+          },
+          "line": {
+            "type": [
+              "integer",
+              "null"
+            ],
+            "minimum": 1
+          },
+          "problem": {
+            "type": "string"
+          },
+          "impact": {
+            "type": "string"
+          },
+          "suggested_fix": {
+            "type": "string"
+          },
+          "evidence": {
+            "type": "string"
+          },
+          "confidence": {
+            "type": "string",
+            "enum": [
+              "high",
+              "medium",
+              "low"
+            ]
+          },
+          "reviewer": {
+            "type": "string"
+          },
+          "dedupe_key": {
+            "type": [
+              "string",
+              "null"
+            ]
+          },
+          "blocking_merge": {
+            "type": "boolean",
+            "default": false
+          },
+          "class_scope": {
+            "title": "Every site of this shape, and how the set was derived",
+            "description": "A finding anchored to one file:line is a claim about one site. Repeatedly, a fix repaired that site and left its siblings — one writer of five, one operator instruction of four, six readers of eight — and the next review round found them. Required for blocker and major; optional below, because enumerating the class for every info finding is theatre. Kept identical to src/gdskills/contracts/review-finding.schema.json, which is stricter (additionalProperties: false) and would reject this property if it were declared only here.",
+            "type": "object",
+            "additionalProperties": false,
+            "required": [
+              "sites",
+              "enumeration_method"
+            ],
+            "properties": {
+              "sites": {
+                "type": "array",
+                "minItems": 1,
+                "items": {
+                  "type": "string"
+                },
+                "description": "Every location carrying the shape, including ones already correct. A single-entry list is a claim that the class has one member."
+              },
+              "enumeration_method": {
+                "type": "string",
+                "minLength": 1,
+                "description": "How the set was derived: the grep or query run, the source-level guard that enumerates it, or why the list is exhaustive. 'I checked the others' is not a method."
+              }
+            }
+          }
+        },
+        "additionalProperties": true,
+        "if": {
+          "required": [
+            "severity"
+          ],
+          "properties": {
+            "severity": {
+              "enum": [
+                "blocker",
+                "major"
+              ]
+            }
+          }
+        },
+        "then": {
+          "required": [
+            "class_scope"
+          ]
+        }
+      }
+    },
+    "needs_context": {
+      "type": "array",
+      "items": {
+        "type": "string"
+      }
+    },
+    "stats": {
+      "type": "object",
+      "required": [
+        "blocker",
+        "major",
+        "minor",
+        "info"
+      ],
+      "properties": {
+        "blocker": {
+          "type": "integer",
+          "minimum": 0
+        },
+        "major": {
+          "type": "integer",
+          "minimum": 0
+        },
+        "minor": {
+          "type": "integer",
+          "minimum": 0
+        },
+        "info": {
+          "type": "integer",
+          "minimum": 0
+        }
+      },
+      "additionalProperties": false
+    },
+    "tokens": {
+      "type": "object",
+      "additionalProperties": true
+    }
+  },
+  "additionalProperties": true
+}

package/src/gdskills/bundled/skills/review/review-orchestrator/reviewer-input.schema.json

@@ -0,0 +1,241 @@
+{
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "reviewer-input",
+  "title": "Reviewer Input",
+  "type": "object",
+  "required": [
+    "review_context",
+    "reviewer",
+    "scope_mode",
+    "model_class",
+    "budget"
+  ],
+  "properties": {
+    "review_context": {
+      "$ref": "review-context.schema.json"
+    },
+    "reviewer": {
+      "type": "string"
+    },
+    "scope_mode": {
+      "type": "string",
+      "enum": [
+        "diff",
+        "path"
+      ]
+    },
+    "context_doc": {
+      "type": [
+        "string",
+        "null"
+      ]
+    },
+    "issue_url": {
+      "type": [
+        "string",
+        "null"
+      ]
+    },
+    "model_class": {
+      "type": "string",
+      "enum": [
+        "simple",
+        "normal",
+        "complex",
+        "current-session"
+      ]
+    },
+    "budget": {
+      "type": "object",
+      "required": [
+        "max_findings"
+      ],
+      "properties": {
+        "max_prompt_tokens": {
+          "type": [
+            "integer",
+            "null"
+          ],
+          "minimum": 1000
+        },
+        "max_findings": {
+          "type": "integer",
+          "minimum": 1,
+          "maximum": 100
+        }
+      },
+      "additionalProperties": false
+    },
+    "branch": {
+      "type": [
+        "string",
+        "null"
+      ]
+    },
+    "base_sha": {
+      "type": [
+        "string",
+        "null"
+      ]
+    },
+    "diff": {
+      "type": [
+        "string",
+        "null"
+      ]
+    },
+    "target_path": {
+      "type": [
+        "string",
+        "array",
+        "null"
+      ],
+      "items": {
+        "type": "string"
+      }
+    },
+    "file_contents": {
+      "type": [
+        "string",
+        "null"
+      ]
+    },
+    "round": {
+      "type": "integer",
+      "minimum": 1,
+      "description": "Which review round this dispatch is. Round 1 is the first review of a change; every later round is reviewing work produced in response to the previous one."
+    },
+    "is_fix_round": {
+      "type": "boolean",
+      "default": false,
+      "description": "True when the diff under review was produced to answer earlier findings. A fix round without the earlier findings is the failure this field exists to stop: the reviewer cannot tell whether a fix is complete when it does not know what the fix was answering."
+    },
+    "prior_findings": {
+      "type": "array",
+      "description": "Every finding from earlier rounds on this change, with what the fix claimed about each. Eleven rounds across two flows were dispatched without this, and twice in a row the fix repaired the site the finding named while leaving its siblings — which the NEXT round then found. A reviewer that can see the earlier finding and the claimed disposition can check the claim.",
+      "items": {
+        "type": "object",
+        "required": [
+          "round",
+          "finding",
+          "claimed_disposition"
+        ],
+        "properties": {
+          "round": {
+            "type": "integer",
+            "minimum": 1
+          },
+          "finding": {
+            "$ref": "review-finding.schema.json",
+            "description": "The finding as reported, including its class_scope when it carried one. Deliberately the normalized contract in src/gdskills/contracts/, not the bundled reviewer-output shape: a prior finding is one finding, and it is the same object the learning and ingest paths already consume."
+          },
+          "claimed_disposition": {
+            "type": "string",
+            "enum": [
+              "fixed",
+              "partially-fixed",
+              "wont-fix",
+              "disputed",
+              "deferred"
+            ],
+            "description": "What the fix round claimed. A claim, not a verified state — verifying it is the reviewer's job."
+          },
+          "claimed_evidence": {
+            "type": [
+              "string",
+              "null"
+            ],
+            "description": "What the fix offered as proof: the test added, the mutation that went red, the command run."
+          }
+        },
+        "additionalProperties": true
+      }
+    },
+    "metaproject": {
+      "type": "object",
+      "description": "Shared project context, the same context `keryx flow init` already collects for an implementation flow. The review pipeline collected none of it for eleven rounds, which is why a recorded lesson naming the exact recurring failure never reached a reviewer.",
+      "properties": {
+        "memory": {
+          "type": "array",
+          "description": "Accepted memory entries whose recorded scope intersects the changed files or modules. Accepted only: a draft entry is a hypothesis, and putting one in front of a reviewer as project truth is how a wrong hypothesis becomes a wrong finding.",
+          "items": {
+            "type": "object",
+            "required": [
+              "path",
+              "type",
+              "status",
+              "title"
+            ],
+            "properties": {
+              "path": {
+                "type": "string"
+              },
+              "type": {
+                "type": "string"
+              },
+              "status": {
+                "type": "string",
+                "enum": [
+                  "accepted"
+                ]
+              },
+              "title": {
+                "type": "string"
+              },
+              "summary": {
+                "type": [
+                  "string",
+                  "null"
+                ]
+              }
+            },
+            "additionalProperties": true
+          }
+        },
+        "wiki": {
+          "type": "array",
+          "description": "Wiki pages covering the architecture, domain rules or decisions the changed files participate in.",
+          "items": {
+            "type": "object",
+            "required": [
+              "path",
+              "title"
+            ],
+            "properties": {
+              "path": {
+                "type": "string"
+              },
+              "title": {
+                "type": "string"
+              }
+            },
+            "additionalProperties": true
+          }
+        },
+        "graph": {
+          "type": "object",
+          "description": "Blast radius from `keryx gdgraph affected`, so a reviewer can see what a changed symbol reaches without reading the tree.",
+          "additionalProperties": true
+        }
+      },
+      "additionalProperties": true
+    }
+  },
+  "additionalProperties": true,
+  "if": {
+    "required": [
+      "is_fix_round"
+    ],
+    "properties": {
+      "is_fix_round": {
+        "const": true
+      }
+    }
+  },
+  "then": {
+    "required": [
+      "prior_findings",
+      "metaproject"
+    ]
+  }
+}