@mrciphersmith/keryx 0.2.72 → 0.2.74
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/cli.js +33409 -32626
- package/package.json +2 -2
- package/src/gdskills/bundled/rules/core/gproject-contracts.mdc +1 -1
- package/src/gdskills/bundled/rules/core/jobs-documentation.mdc +1 -1
- package/src/gdskills/bundled/rules/core/subagent-context-construction.md +1 -1
- package/src/gdskills/bundled/skills/core/reviewer-skill-creator/SKILL.md +214 -0
- package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.codex.md +326 -20
- package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.cursor.md +320 -22
- package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.opencode.md +326 -12
- package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.zed.md +333 -9
- package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.codex.md +92 -4
- package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.cursor.md +92 -4
- package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.opencode.md +92 -4
- package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.zed.md +92 -4
- package/src/gdskills/bundled/skills/orchestration/context-collector/orchestrator-prompt.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.codex.md +154 -1098
- package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.cursor.md +154 -1098
- package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.opencode.md +154 -1098
- package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.zed.md +154 -1098
- package/src/gdskills/bundled/skills/orchestration/feature-analyzer/orchestrator-prompt.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/feature-dev/SKILL.codex.md +101 -41
- package/src/gdskills/bundled/skills/orchestration/feature-dev/SKILL.cursor.md +101 -41
- package/src/gdskills/bundled/skills/orchestration/flow-orchestrator/SKILL.md +48 -1
- package/src/gdskills/bundled/skills/orchestration/flow-orchestrator/input-contract.schema.json +70 -4
- package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.codex.md +115 -49
- package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.cursor.md +115 -49
- package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.opencode.md +115 -49
- package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.zed.md +115 -49
- package/src/gdskills/bundled/skills/orchestration/issue-analyzer/orchestrator-prompt.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.codex.md +15 -6
- package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.cursor.md +15 -6
- package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.opencode.md +15 -6
- package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.zed.md +15 -6
- package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.opencode.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.zed.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.codex.md +300 -55
- package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.cursor.md +300 -55
- package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.md +120 -37
- package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.opencode.md +300 -55
- package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.zed.md +300 -55
- package/src/gdskills/bundled/skills/orchestration/task-implementer/input-contract.schema.json +56 -14
- package/src/gdskills/bundled/skills/orchestration/task-implementer/orchestrator-prompt.md +50 -23
- package/src/gdskills/bundled/skills/orchestration/task-implementer/output-contract.schema.json +6 -2
- package/src/gdskills/bundled/skills/orchestration/task-implementer/task-request.template.md +18 -12
- package/src/gdskills/bundled/skills/planning/brainstorm/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/planning/brainstorm/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/planning/consistency-checker/SKILL.codex.md +169 -10
- package/src/gdskills/bundled/skills/planning/consistency-checker/SKILL.cursor.md +169 -10
- package/src/gdskills/bundled/skills/planning/consistency-checker/SKILL.md +1 -1
- package/src/gdskills/bundled/skills/planning/interview/SKILL.codex.md +7 -1
- package/src/gdskills/bundled/skills/planning/interview/SKILL.cursor.md +7 -1
- package/src/gdskills/bundled/skills/planning/interviewer/SKILL.codex.md +7 -1
- package/src/gdskills/bundled/skills/planning/interviewer/SKILL.cursor.md +7 -1
- package/src/gdskills/bundled/skills/planning/patterns-researcher/SKILL.codex.md +216 -10
- package/src/gdskills/bundled/skills/planning/patterns-researcher/SKILL.cursor.md +216 -10
- package/src/gdskills/bundled/skills/planning/patterns-researcher/SKILL.md +1 -1
- package/src/gdskills/bundled/skills/planning/planner/SKILL.codex.md +169 -10
- package/src/gdskills/bundled/skills/planning/planner/SKILL.cursor.md +169 -10
- package/src/gdskills/bundled/skills/planning/planner/SKILL.md +1 -1
- package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.codex.md +2 -2
- package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.cursor.md +2 -2
- package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.opencode.md +2 -2
- package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.zed.md +2 -2
- package/src/gdskills/bundled/skills/planning/problem-definer/SKILL.codex.md +134 -10
- package/src/gdskills/bundled/skills/planning/problem-definer/SKILL.cursor.md +134 -10
- package/src/gdskills/bundled/skills/planning/problem-definer/SKILL.md +1 -1
- package/src/gdskills/bundled/skills/planning/project-discovery/SKILL.codex.md +146 -10
- package/src/gdskills/bundled/skills/planning/project-discovery/SKILL.cursor.md +146 -10
- package/src/gdskills/bundled/skills/planning/project-discovery/SKILL.md +1 -1
- package/src/gdskills/bundled/skills/planning/spec-writer/SKILL.codex.md +211 -10
- package/src/gdskills/bundled/skills/planning/spec-writer/SKILL.cursor.md +211 -10
- package/src/gdskills/bundled/skills/planning/spec-writer/SKILL.md +1 -1
- package/src/gdskills/bundled/skills/planning/stack-advisor/SKILL.codex.md +162 -10
- package/src/gdskills/bundled/skills/planning/stack-advisor/SKILL.cursor.md +162 -10
- package/src/gdskills/bundled/skills/planning/stack-advisor/SKILL.md +1 -1
- package/src/gdskills/bundled/skills/platform/claude-md-management/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/platform/claude-md-management/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/platform/hookify/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/platform/hookify/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/changelog/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/changelog/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/commit/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/commit/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/db-migrate/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/db-migrate/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/dependency-update/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/dependency-update/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/deploy/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/deploy/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/perf-check/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/perf-check/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/pr/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/pr/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.codex.md +15 -1
- package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.cursor.md +248 -165
- package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.opencode.md +15 -1
- package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.zed.md +359 -19
- package/src/gdskills/bundled/skills/quality/push/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/push/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/security-audit/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/security-audit/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/test-gen/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/test-gen/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.codex.md +299 -24
- package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.cursor.md +296 -31
- package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.opencode.md +309 -18
- package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.zed.md +312 -17
- package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.codex.md +29 -30
- package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.cursor.md +29 -30
- package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.opencode.md +29 -30
- package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.zed.md +29 -30
- package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.codex.md +21 -30
- package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.cursor.md +21 -30
- package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.opencode.md +21 -30
- package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.zed.md +21 -30
- package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.codex.md +19 -23
- package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.cursor.md +19 -23
- package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.opencode.md +19 -23
- package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.zed.md +19 -23
- package/src/gdskills/bundled/skills/review/code-style-review/SKILL.codex.md +17 -24
- package/src/gdskills/bundled/skills/review/code-style-review/SKILL.cursor.md +17 -24
- package/src/gdskills/bundled/skills/review/code-style-review/SKILL.opencode.md +17 -24
- package/src/gdskills/bundled/skills/review/code-style-review/SKILL.zed.md +17 -24
- package/src/gdskills/bundled/skills/review/review-clean-code/SKILL.md +33 -1
- package/src/gdskills/bundled/skills/review/review-layout/SKILL.md +217 -0
- package/src/gdskills/bundled/skills/review/review-logic/SKILL.md +26 -0
- package/src/gdskills/bundled/skills/review/review-orchestrator/SKILL.md +320 -5
- package/src/gdskills/bundled/skills/review/review-pr-feedback/SKILL.md +644 -113
- package/src/gdskills/bundled/skills/review/review-pr-feedback/input-contract.schema.json +79 -0
- package/src/gdskills/bundled/skills/review/review-pr-feedback/output-contract.schema.json +375 -0
- package/src/gdskills/bundled/skills/review/review-testing-practices/SKILL.md +111 -1
- package/src/gdskills/bundled/skills/review/review-verifier/SKILL.md +25 -1
- package/src/gdskills/bundled/skills/planning/brainstorm/SKILL.claude.md +0 -46
- package/src/gdskills/bundled/skills/planning/interviewer/SKILL.claude.md +0 -94
- package/src/gdskills/bundled/skills/quality/changelog/SKILL.claude.md +0 -45
- package/src/gdskills/bundled/skills/quality/db-migrate/SKILL.claude.md +0 -40
- package/src/gdskills/bundled/skills/quality/dependency-update/SKILL.claude.md +0 -45
- package/src/gdskills/bundled/skills/quality/deploy/SKILL.claude.md +0 -42
- package/src/gdskills/bundled/skills/quality/perf-check/SKILL.claude.md +0 -48
- package/src/gdskills/bundled/skills/quality/security-audit/SKILL.claude.md +0 -40
- package/src/gdskills/bundled/skills/quality/test-gen/SKILL.claude.md +0 -30
|
@@ -85,38 +85,12 @@ An author the config does not name contributes nothing — their text reaches no
|
|
|
85
85
|
proposal and no `SKILL.md`. A project with no config file does not learn, and
|
|
86
86
|
that is a supported state rather than an error.
|
|
87
87
|
|
|
88
|
-
##
|
|
88
|
+
## Scope Detection
|
|
89
89
|
|
|
90
|
-
|
|
90
|
+
See shared script: `skills/shared/git-merge-base.md`
|
|
91
91
|
|
|
92
|
-
|
|
93
|
-
|
|
94
|
-
3. `main`
|
|
95
|
-
4. `master`
|
|
96
|
-
5. `@{upstream}` **only when it is not the current feature branch**
|
|
97
|
-
|
|
98
|
-
```bash
|
|
99
|
-
BRANCH="$(git rev-parse --abbrev-ref HEAD)"
|
|
100
|
-
UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
|
|
101
|
-
|
|
102
|
-
PARENT=""
|
|
103
|
-
if git rev-parse --verify -q "origin/main" >/dev/null; then
|
|
104
|
-
PARENT="origin/main"
|
|
105
|
-
elif git rev-parse --verify -q "origin/master" >/dev/null; then
|
|
106
|
-
PARENT="origin/master"
|
|
107
|
-
elif git rev-parse --verify -q "main" >/dev/null; then
|
|
108
|
-
PARENT="main"
|
|
109
|
-
elif git rev-parse --verify -q "master" >/dev/null; then
|
|
110
|
-
PARENT="master"
|
|
111
|
-
elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
|
|
112
|
-
PARENT="@{upstream}"
|
|
113
|
-
else
|
|
114
|
-
echo "Cannot determine parent ref" >&2
|
|
115
|
-
exit 1
|
|
116
|
-
fi
|
|
117
|
-
|
|
118
|
-
BASE_SHA="$(git merge-base HEAD "$PARENT")"
|
|
119
|
-
```
|
|
92
|
+
Run the script from that file to determine MERGE_BASE and SCOPE before
|
|
93
|
+
proceeding with the review.
|
|
120
94
|
|
|
121
95
|
## Commands to assemble the review slice
|
|
122
96
|
|
|
@@ -229,6 +203,23 @@ index 0000000..1111111 100644
|
|
|
229
203
|
+const x = 2;
|
|
230
204
|
```
|
|
231
205
|
|
|
206
|
+
---
|
|
207
|
+
|
|
208
|
+
## Scope Boundaries
|
|
209
|
+
|
|
210
|
+
This skill covers **review against this project's own learned conventions**,
|
|
211
|
+
following `code-review-learned-profile.mdc`. It has no opinions of its own.
|
|
212
|
+
|
|
213
|
+
| Concern | This skill | Use instead |
|
|
214
|
+
| -------------------------------------------------------------- | ---------- | ------------------------ |
|
|
215
|
+
| This project's accumulated review conventions | ✅ YES | — |
|
|
216
|
+
| General AI review (broader quality, performance, UX) | ❌ NO | `code-ai-review` |
|
|
217
|
+
| MobX store internals (actions, computed, reactions) | ❌ NO | `code-mobx-store-review` |
|
|
218
|
+
| Pure style/naming/architecture pattern audit | ❌ NO | `code-style-review` |
|
|
219
|
+
| Logic correctness with no learned lesson behind it | ❌ NO | `review-logic` |
|
|
220
|
+
|
|
221
|
+
---
|
|
222
|
+
|
|
232
223
|
## Job Context Awareness
|
|
233
224
|
|
|
234
225
|
When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY
|
|
@@ -85,38 +85,12 @@ An author the config does not name contributes nothing — their text reaches no
|
|
|
85
85
|
proposal and no `SKILL.md`. A project with no config file does not learn, and
|
|
86
86
|
that is a supported state rather than an error.
|
|
87
87
|
|
|
88
|
-
##
|
|
88
|
+
## Scope Detection
|
|
89
89
|
|
|
90
|
-
|
|
90
|
+
See shared script: `skills/shared/git-merge-base.md`
|
|
91
91
|
|
|
92
|
-
|
|
93
|
-
|
|
94
|
-
3. `main`
|
|
95
|
-
4. `master`
|
|
96
|
-
5. `@{upstream}` **only when it is not the current feature branch**
|
|
97
|
-
|
|
98
|
-
```bash
|
|
99
|
-
BRANCH="$(git rev-parse --abbrev-ref HEAD)"
|
|
100
|
-
UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
|
|
101
|
-
|
|
102
|
-
PARENT=""
|
|
103
|
-
if git rev-parse --verify -q "origin/main" >/dev/null; then
|
|
104
|
-
PARENT="origin/main"
|
|
105
|
-
elif git rev-parse --verify -q "origin/master" >/dev/null; then
|
|
106
|
-
PARENT="origin/master"
|
|
107
|
-
elif git rev-parse --verify -q "main" >/dev/null; then
|
|
108
|
-
PARENT="main"
|
|
109
|
-
elif git rev-parse --verify -q "master" >/dev/null; then
|
|
110
|
-
PARENT="master"
|
|
111
|
-
elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
|
|
112
|
-
PARENT="@{upstream}"
|
|
113
|
-
else
|
|
114
|
-
echo "Cannot determine parent ref" >&2
|
|
115
|
-
exit 1
|
|
116
|
-
fi
|
|
117
|
-
|
|
118
|
-
BASE_SHA="$(git merge-base HEAD "$PARENT")"
|
|
119
|
-
```
|
|
92
|
+
Run the script from that file to determine MERGE_BASE and SCOPE before
|
|
93
|
+
proceeding with the review.
|
|
120
94
|
|
|
121
95
|
## Commands to assemble the review slice
|
|
122
96
|
|
|
@@ -229,6 +203,23 @@ index 0000000..1111111 100644
|
|
|
229
203
|
+const x = 2;
|
|
230
204
|
```
|
|
231
205
|
|
|
206
|
+
---
|
|
207
|
+
|
|
208
|
+
## Scope Boundaries
|
|
209
|
+
|
|
210
|
+
This skill covers **review against this project's own learned conventions**,
|
|
211
|
+
following `code-review-learned-profile.mdc`. It has no opinions of its own.
|
|
212
|
+
|
|
213
|
+
| Concern | This skill | Use instead |
|
|
214
|
+
| -------------------------------------------------------------- | ---------- | ------------------------ |
|
|
215
|
+
| This project's accumulated review conventions | ✅ YES | — |
|
|
216
|
+
| General AI review (broader quality, performance, UX) | ❌ NO | `code-ai-review` |
|
|
217
|
+
| MobX store internals (actions, computed, reactions) | ❌ NO | `code-mobx-store-review` |
|
|
218
|
+
| Pure style/naming/architecture pattern audit | ❌ NO | `code-style-review` |
|
|
219
|
+
| Logic correctness with no learned lesson behind it | ❌ NO | `review-logic` |
|
|
220
|
+
|
|
221
|
+
---
|
|
222
|
+
|
|
232
223
|
## Job Context Awareness
|
|
233
224
|
|
|
234
225
|
When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY
|
|
@@ -85,38 +85,12 @@ An author the config does not name contributes nothing — their text reaches no
|
|
|
85
85
|
proposal and no `SKILL.md`. A project with no config file does not learn, and
|
|
86
86
|
that is a supported state rather than an error.
|
|
87
87
|
|
|
88
|
-
##
|
|
88
|
+
## Scope Detection
|
|
89
89
|
|
|
90
|
-
|
|
90
|
+
See shared script: `skills/shared/git-merge-base.md`
|
|
91
91
|
|
|
92
|
-
|
|
93
|
-
|
|
94
|
-
3. `main`
|
|
95
|
-
4. `master`
|
|
96
|
-
5. `@{upstream}` **only when it is not the current feature branch**
|
|
97
|
-
|
|
98
|
-
```bash
|
|
99
|
-
BRANCH="$(git rev-parse --abbrev-ref HEAD)"
|
|
100
|
-
UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
|
|
101
|
-
|
|
102
|
-
PARENT=""
|
|
103
|
-
if git rev-parse --verify -q "origin/main" >/dev/null; then
|
|
104
|
-
PARENT="origin/main"
|
|
105
|
-
elif git rev-parse --verify -q "origin/master" >/dev/null; then
|
|
106
|
-
PARENT="origin/master"
|
|
107
|
-
elif git rev-parse --verify -q "main" >/dev/null; then
|
|
108
|
-
PARENT="main"
|
|
109
|
-
elif git rev-parse --verify -q "master" >/dev/null; then
|
|
110
|
-
PARENT="master"
|
|
111
|
-
elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
|
|
112
|
-
PARENT="@{upstream}"
|
|
113
|
-
else
|
|
114
|
-
echo "Cannot determine parent ref" >&2
|
|
115
|
-
exit 1
|
|
116
|
-
fi
|
|
117
|
-
|
|
118
|
-
BASE_SHA="$(git merge-base HEAD "$PARENT")"
|
|
119
|
-
```
|
|
92
|
+
Run the script from that file to determine MERGE_BASE and SCOPE before
|
|
93
|
+
proceeding with the review.
|
|
120
94
|
|
|
121
95
|
## Commands to assemble the review slice
|
|
122
96
|
|
|
@@ -229,6 +203,23 @@ index 0000000..1111111 100644
|
|
|
229
203
|
+const x = 2;
|
|
230
204
|
```
|
|
231
205
|
|
|
206
|
+
---
|
|
207
|
+
|
|
208
|
+
## Scope Boundaries
|
|
209
|
+
|
|
210
|
+
This skill covers **review against this project's own learned conventions**,
|
|
211
|
+
following `code-review-learned-profile.mdc`. It has no opinions of its own.
|
|
212
|
+
|
|
213
|
+
| Concern | This skill | Use instead |
|
|
214
|
+
| -------------------------------------------------------------- | ---------- | ------------------------ |
|
|
215
|
+
| This project's accumulated review conventions | ✅ YES | — |
|
|
216
|
+
| General AI review (broader quality, performance, UX) | ❌ NO | `code-ai-review` |
|
|
217
|
+
| MobX store internals (actions, computed, reactions) | ❌ NO | `code-mobx-store-review` |
|
|
218
|
+
| Pure style/naming/architecture pattern audit | ❌ NO | `code-style-review` |
|
|
219
|
+
| Logic correctness with no learned lesson behind it | ❌ NO | `review-logic` |
|
|
220
|
+
|
|
221
|
+
---
|
|
222
|
+
|
|
232
223
|
## Job Context Awareness
|
|
233
224
|
|
|
234
225
|
When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY
|
|
@@ -85,38 +85,12 @@ An author the config does not name contributes nothing — their text reaches no
|
|
|
85
85
|
proposal and no `SKILL.md`. A project with no config file does not learn, and
|
|
86
86
|
that is a supported state rather than an error.
|
|
87
87
|
|
|
88
|
-
##
|
|
88
|
+
## Scope Detection
|
|
89
89
|
|
|
90
|
-
|
|
90
|
+
See shared script: `skills/shared/git-merge-base.md`
|
|
91
91
|
|
|
92
|
-
|
|
93
|
-
|
|
94
|
-
3. `main`
|
|
95
|
-
4. `master`
|
|
96
|
-
5. `@{upstream}` **only when it is not the current feature branch**
|
|
97
|
-
|
|
98
|
-
```bash
|
|
99
|
-
BRANCH="$(git rev-parse --abbrev-ref HEAD)"
|
|
100
|
-
UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
|
|
101
|
-
|
|
102
|
-
PARENT=""
|
|
103
|
-
if git rev-parse --verify -q "origin/main" >/dev/null; then
|
|
104
|
-
PARENT="origin/main"
|
|
105
|
-
elif git rev-parse --verify -q "origin/master" >/dev/null; then
|
|
106
|
-
PARENT="origin/master"
|
|
107
|
-
elif git rev-parse --verify -q "main" >/dev/null; then
|
|
108
|
-
PARENT="main"
|
|
109
|
-
elif git rev-parse --verify -q "master" >/dev/null; then
|
|
110
|
-
PARENT="master"
|
|
111
|
-
elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
|
|
112
|
-
PARENT="@{upstream}"
|
|
113
|
-
else
|
|
114
|
-
echo "Cannot determine parent ref" >&2
|
|
115
|
-
exit 1
|
|
116
|
-
fi
|
|
117
|
-
|
|
118
|
-
BASE_SHA="$(git merge-base HEAD "$PARENT")"
|
|
119
|
-
```
|
|
92
|
+
Run the script from that file to determine MERGE_BASE and SCOPE before
|
|
93
|
+
proceeding with the review.
|
|
120
94
|
|
|
121
95
|
## Commands to assemble the review slice
|
|
122
96
|
|
|
@@ -229,6 +203,23 @@ index 0000000..1111111 100644
|
|
|
229
203
|
+const x = 2;
|
|
230
204
|
```
|
|
231
205
|
|
|
206
|
+
---
|
|
207
|
+
|
|
208
|
+
## Scope Boundaries
|
|
209
|
+
|
|
210
|
+
This skill covers **review against this project's own learned conventions**,
|
|
211
|
+
following `code-review-learned-profile.mdc`. It has no opinions of its own.
|
|
212
|
+
|
|
213
|
+
| Concern | This skill | Use instead |
|
|
214
|
+
| -------------------------------------------------------------- | ---------- | ------------------------ |
|
|
215
|
+
| This project's accumulated review conventions | ✅ YES | — |
|
|
216
|
+
| General AI review (broader quality, performance, UX) | ❌ NO | `code-ai-review` |
|
|
217
|
+
| MobX store internals (actions, computed, reactions) | ❌ NO | `code-mobx-store-review` |
|
|
218
|
+
| Pure style/naming/architecture pattern audit | ❌ NO | `code-style-review` |
|
|
219
|
+
| Logic correctness with no learned lesson behind it | ❌ NO | `review-logic` |
|
|
220
|
+
|
|
221
|
+
---
|
|
222
|
+
|
|
232
223
|
## Job Context Awareness
|
|
233
224
|
|
|
234
225
|
When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY
|
|
@@ -10,6 +10,7 @@ metadata:
|
|
|
10
10
|
version: "1.1.0"
|
|
11
11
|
category: "review"
|
|
12
12
|
compatible_harnesses: "cursor,codex,zed,opencode"
|
|
13
|
+
stack_requires: "mobx"
|
|
13
14
|
license: "MIT"
|
|
14
15
|
---
|
|
15
16
|
|
|
@@ -28,30 +29,11 @@ license: "MIT"
|
|
|
28
29
|
- Не ревьюй легаси вне измененного скоупа.
|
|
29
30
|
- Привязывай замечания к измененным строкам в diff.
|
|
30
31
|
|
|
31
|
-
##
|
|
32
|
+
## Scope Detection
|
|
32
33
|
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
PARENT=""
|
|
38
|
-
if git rev-parse --verify -q "origin/main" >/dev/null; then
|
|
39
|
-
PARENT="origin/main"
|
|
40
|
-
elif git rev-parse --verify -q "origin/master" >/dev/null; then
|
|
41
|
-
PARENT="origin/master"
|
|
42
|
-
elif git rev-parse --verify -q "main" >/dev/null; then
|
|
43
|
-
PARENT="main"
|
|
44
|
-
elif git rev-parse --verify -q "master" >/dev/null; then
|
|
45
|
-
PARENT="master"
|
|
46
|
-
elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
|
|
47
|
-
PARENT="@{upstream}"
|
|
48
|
-
else
|
|
49
|
-
echo "Cannot determine parent ref" >&2
|
|
50
|
-
exit 1
|
|
51
|
-
fi
|
|
52
|
-
|
|
53
|
-
BASE_SHA="$(git merge-base HEAD "$PARENT")"
|
|
54
|
-
```
|
|
34
|
+
See shared script: `skills/shared/git-merge-base.md`
|
|
35
|
+
|
|
36
|
+
Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
|
|
55
37
|
|
|
56
38
|
### Команды сбора изменений
|
|
57
39
|
|
|
@@ -246,6 +228,20 @@ if (executor?.id !== this.executorId) {
|
|
|
246
228
|
|
|
247
229
|
---
|
|
248
230
|
|
|
231
|
+
## Scope Boundaries
|
|
232
|
+
|
|
233
|
+
This skill covers **MobX store and state logic** — targeted review of store internals following `mobx-store-template.mdc` and `code-style-patterns.mdc`.
|
|
234
|
+
|
|
235
|
+
| Concern | This skill | Use instead |
|
|
236
|
+
|---------|-----------|-------------|
|
|
237
|
+
| Store structure, actions, computed, reactions, async runInAction | ✅ YES | — |
|
|
238
|
+
| View↔Store boundary violations | ✅ YES | — |
|
|
239
|
+
| General code quality, readability, tests | ❌ NO | `code-ai-review` |
|
|
240
|
+
| Learned-convention enforcement | ❌ NO | `code-learned-review` |
|
|
241
|
+
| Naming/style/architecture patterns outside stores | ❌ NO | `code-style-review` |
|
|
242
|
+
|
|
243
|
+
---
|
|
244
|
+
|
|
249
245
|
## Job Context Awareness
|
|
250
246
|
|
|
251
247
|
When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
|
|
@@ -10,6 +10,7 @@ metadata:
|
|
|
10
10
|
version: "1.1.0"
|
|
11
11
|
category: "review"
|
|
12
12
|
compatible_harnesses: "cursor,codex,zed,opencode"
|
|
13
|
+
stack_requires: "mobx"
|
|
13
14
|
license: "MIT"
|
|
14
15
|
---
|
|
15
16
|
|
|
@@ -28,30 +29,11 @@ license: "MIT"
|
|
|
28
29
|
- Не ревьюй легаси вне измененного скоупа.
|
|
29
30
|
- Привязывай замечания к измененным строкам в diff.
|
|
30
31
|
|
|
31
|
-
##
|
|
32
|
+
## Scope Detection
|
|
32
33
|
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
PARENT=""
|
|
38
|
-
if git rev-parse --verify -q "origin/main" >/dev/null; then
|
|
39
|
-
PARENT="origin/main"
|
|
40
|
-
elif git rev-parse --verify -q "origin/master" >/dev/null; then
|
|
41
|
-
PARENT="origin/master"
|
|
42
|
-
elif git rev-parse --verify -q "main" >/dev/null; then
|
|
43
|
-
PARENT="main"
|
|
44
|
-
elif git rev-parse --verify -q "master" >/dev/null; then
|
|
45
|
-
PARENT="master"
|
|
46
|
-
elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
|
|
47
|
-
PARENT="@{upstream}"
|
|
48
|
-
else
|
|
49
|
-
echo "Cannot determine parent ref" >&2
|
|
50
|
-
exit 1
|
|
51
|
-
fi
|
|
52
|
-
|
|
53
|
-
BASE_SHA="$(git merge-base HEAD "$PARENT")"
|
|
54
|
-
```
|
|
34
|
+
See shared script: `skills/shared/git-merge-base.md`
|
|
35
|
+
|
|
36
|
+
Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
|
|
55
37
|
|
|
56
38
|
### Команды сбора изменений
|
|
57
39
|
|
|
@@ -246,6 +228,20 @@ if (executor?.id !== this.executorId) {
|
|
|
246
228
|
|
|
247
229
|
---
|
|
248
230
|
|
|
231
|
+
## Scope Boundaries
|
|
232
|
+
|
|
233
|
+
This skill covers **MobX store and state logic** — targeted review of store internals following `mobx-store-template.mdc` and `code-style-patterns.mdc`.
|
|
234
|
+
|
|
235
|
+
| Concern | This skill | Use instead |
|
|
236
|
+
|---------|-----------|-------------|
|
|
237
|
+
| Store structure, actions, computed, reactions, async runInAction | ✅ YES | — |
|
|
238
|
+
| View↔Store boundary violations | ✅ YES | — |
|
|
239
|
+
| General code quality, readability, tests | ❌ NO | `code-ai-review` |
|
|
240
|
+
| Learned-convention enforcement | ❌ NO | `code-learned-review` |
|
|
241
|
+
| Naming/style/architecture patterns outside stores | ❌ NO | `code-style-review` |
|
|
242
|
+
|
|
243
|
+
---
|
|
244
|
+
|
|
249
245
|
## Job Context Awareness
|
|
250
246
|
|
|
251
247
|
When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
|
|
@@ -10,6 +10,7 @@ metadata:
|
|
|
10
10
|
version: "1.1.0"
|
|
11
11
|
category: "review"
|
|
12
12
|
compatible_harnesses: "cursor,codex,zed,opencode"
|
|
13
|
+
stack_requires: "mobx"
|
|
13
14
|
license: "MIT"
|
|
14
15
|
---
|
|
15
16
|
|
|
@@ -28,30 +29,11 @@ license: "MIT"
|
|
|
28
29
|
- Не ревьюй легаси вне измененного скоупа.
|
|
29
30
|
- Привязывай замечания к измененным строкам в diff.
|
|
30
31
|
|
|
31
|
-
##
|
|
32
|
+
## Scope Detection
|
|
32
33
|
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
PARENT=""
|
|
38
|
-
if git rev-parse --verify -q "origin/main" >/dev/null; then
|
|
39
|
-
PARENT="origin/main"
|
|
40
|
-
elif git rev-parse --verify -q "origin/master" >/dev/null; then
|
|
41
|
-
PARENT="origin/master"
|
|
42
|
-
elif git rev-parse --verify -q "main" >/dev/null; then
|
|
43
|
-
PARENT="main"
|
|
44
|
-
elif git rev-parse --verify -q "master" >/dev/null; then
|
|
45
|
-
PARENT="master"
|
|
46
|
-
elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
|
|
47
|
-
PARENT="@{upstream}"
|
|
48
|
-
else
|
|
49
|
-
echo "Cannot determine parent ref" >&2
|
|
50
|
-
exit 1
|
|
51
|
-
fi
|
|
52
|
-
|
|
53
|
-
BASE_SHA="$(git merge-base HEAD "$PARENT")"
|
|
54
|
-
```
|
|
34
|
+
See shared script: `skills/shared/git-merge-base.md`
|
|
35
|
+
|
|
36
|
+
Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
|
|
55
37
|
|
|
56
38
|
### Команды сбора изменений
|
|
57
39
|
|
|
@@ -246,6 +228,20 @@ if (executor?.id !== this.executorId) {
|
|
|
246
228
|
|
|
247
229
|
---
|
|
248
230
|
|
|
231
|
+
## Scope Boundaries
|
|
232
|
+
|
|
233
|
+
This skill covers **MobX store and state logic** — targeted review of store internals following `mobx-store-template.mdc` and `code-style-patterns.mdc`.
|
|
234
|
+
|
|
235
|
+
| Concern | This skill | Use instead |
|
|
236
|
+
|---------|-----------|-------------|
|
|
237
|
+
| Store structure, actions, computed, reactions, async runInAction | ✅ YES | — |
|
|
238
|
+
| View↔Store boundary violations | ✅ YES | — |
|
|
239
|
+
| General code quality, readability, tests | ❌ NO | `code-ai-review` |
|
|
240
|
+
| Learned-convention enforcement | ❌ NO | `code-learned-review` |
|
|
241
|
+
| Naming/style/architecture patterns outside stores | ❌ NO | `code-style-review` |
|
|
242
|
+
|
|
243
|
+
---
|
|
244
|
+
|
|
249
245
|
## Job Context Awareness
|
|
250
246
|
|
|
251
247
|
When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
|
|
@@ -10,6 +10,7 @@ metadata:
|
|
|
10
10
|
version: "1.1.0"
|
|
11
11
|
category: "review"
|
|
12
12
|
compatible_harnesses: "cursor,codex,zed,opencode"
|
|
13
|
+
stack_requires: "mobx"
|
|
13
14
|
license: "MIT"
|
|
14
15
|
---
|
|
15
16
|
|
|
@@ -28,30 +29,11 @@ license: "MIT"
|
|
|
28
29
|
- Не ревьюй легаси вне измененного скоупа.
|
|
29
30
|
- Привязывай замечания к измененным строкам в diff.
|
|
30
31
|
|
|
31
|
-
##
|
|
32
|
+
## Scope Detection
|
|
32
33
|
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
PARENT=""
|
|
38
|
-
if git rev-parse --verify -q "origin/main" >/dev/null; then
|
|
39
|
-
PARENT="origin/main"
|
|
40
|
-
elif git rev-parse --verify -q "origin/master" >/dev/null; then
|
|
41
|
-
PARENT="origin/master"
|
|
42
|
-
elif git rev-parse --verify -q "main" >/dev/null; then
|
|
43
|
-
PARENT="main"
|
|
44
|
-
elif git rev-parse --verify -q "master" >/dev/null; then
|
|
45
|
-
PARENT="master"
|
|
46
|
-
elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
|
|
47
|
-
PARENT="@{upstream}"
|
|
48
|
-
else
|
|
49
|
-
echo "Cannot determine parent ref" >&2
|
|
50
|
-
exit 1
|
|
51
|
-
fi
|
|
52
|
-
|
|
53
|
-
BASE_SHA="$(git merge-base HEAD "$PARENT")"
|
|
54
|
-
```
|
|
34
|
+
See shared script: `skills/shared/git-merge-base.md`
|
|
35
|
+
|
|
36
|
+
Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
|
|
55
37
|
|
|
56
38
|
### Команды сбора изменений
|
|
57
39
|
|
|
@@ -246,6 +228,20 @@ if (executor?.id !== this.executorId) {
|
|
|
246
228
|
|
|
247
229
|
---
|
|
248
230
|
|
|
231
|
+
## Scope Boundaries
|
|
232
|
+
|
|
233
|
+
This skill covers **MobX store and state logic** — targeted review of store internals following `mobx-store-template.mdc` and `code-style-patterns.mdc`.
|
|
234
|
+
|
|
235
|
+
| Concern | This skill | Use instead |
|
|
236
|
+
|---------|-----------|-------------|
|
|
237
|
+
| Store structure, actions, computed, reactions, async runInAction | ✅ YES | — |
|
|
238
|
+
| View↔Store boundary violations | ✅ YES | — |
|
|
239
|
+
| General code quality, readability, tests | ❌ NO | `code-ai-review` |
|
|
240
|
+
| Learned-convention enforcement | ❌ NO | `code-learned-review` |
|
|
241
|
+
| Naming/style/architecture patterns outside stores | ❌ NO | `code-style-review` |
|
|
242
|
+
|
|
243
|
+
---
|
|
244
|
+
|
|
249
245
|
## Job Context Awareness
|
|
250
246
|
|
|
251
247
|
When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
|
|
@@ -28,32 +28,11 @@ license: "MIT"
|
|
|
28
28
|
- Фидбек должен быть подробным: проблема -> почему это проблема -> где (файл/участок) -> что сделать -> пример исправления.
|
|
29
29
|
- Исправления предлагай в виде unified diff-патчей, не вноси изменения в код напрямую.
|
|
30
30
|
|
|
31
|
-
##
|
|
31
|
+
## Scope Detection
|
|
32
32
|
|
|
33
|
-
|
|
33
|
+
See shared script: `skills/shared/git-merge-base.md`
|
|
34
34
|
|
|
35
|
-
|
|
36
|
-
BRANCH="$(git rev-parse --abbrev-ref HEAD)"
|
|
37
|
-
UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
|
|
38
|
-
|
|
39
|
-
PARENT=""
|
|
40
|
-
if git rev-parse --verify -q "origin/main" >/dev/null; then
|
|
41
|
-
PARENT="origin/main"
|
|
42
|
-
elif git rev-parse --verify -q "origin/master" >/dev/null; then
|
|
43
|
-
PARENT="origin/master"
|
|
44
|
-
elif git rev-parse --verify -q "main" >/dev/null; then
|
|
45
|
-
PARENT="main"
|
|
46
|
-
elif git rev-parse --verify -q "master" >/dev/null; then
|
|
47
|
-
PARENT="master"
|
|
48
|
-
elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
|
|
49
|
-
PARENT="@{upstream}"
|
|
50
|
-
else
|
|
51
|
-
echo "Cannot determine parent ref" >&2
|
|
52
|
-
exit 1
|
|
53
|
-
fi
|
|
54
|
-
|
|
55
|
-
BASE_SHA="$(git merge-base HEAD "$PARENT")"
|
|
56
|
-
```
|
|
35
|
+
Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
|
|
57
36
|
|
|
58
37
|
Собери входные данные:
|
|
59
38
|
|
|
@@ -158,6 +137,20 @@ git diff --find-renames <FROM_SHA>..<TO_SHA>
|
|
|
158
137
|
|
|
159
138
|
---
|
|
160
139
|
|
|
140
|
+
## Scope Boundaries
|
|
141
|
+
|
|
142
|
+
This skill covers **code style and architecture patterns** — naming, organization, TypeScript usage, pattern compliance per `code-style-patterns.mdc`.
|
|
143
|
+
|
|
144
|
+
| Concern | This skill | Use instead |
|
|
145
|
+
|---------|-----------|-------------|
|
|
146
|
+
| Naming conventions, file organization, import order | ✅ YES | — |
|
|
147
|
+
| TypeScript patterns, component/hook structure | ✅ YES | — |
|
|
148
|
+
| Architecture pattern compliance | ✅ YES | — |
|
|
149
|
+
| Logic correctness, type safety deep dives | ❌ NO | `code-ai-review` or `code-learned-review` |
|
|
150
|
+
| MobX store internals | ❌ NO | `code-mobx-store-review` |
|
|
151
|
+
|
|
152
|
+
---
|
|
153
|
+
|
|
161
154
|
## Job Context Awareness
|
|
162
155
|
|
|
163
156
|
When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
|
|
@@ -28,32 +28,11 @@ license: "MIT"
|
|
|
28
28
|
- Фидбек должен быть подробным: проблема -> почему это проблема -> где (файл/участок) -> что сделать -> пример исправления.
|
|
29
29
|
- Исправления предлагай в виде unified diff-патчей, не вноси изменения в код напрямую.
|
|
30
30
|
|
|
31
|
-
##
|
|
31
|
+
## Scope Detection
|
|
32
32
|
|
|
33
|
-
|
|
33
|
+
See shared script: `skills/shared/git-merge-base.md`
|
|
34
34
|
|
|
35
|
-
|
|
36
|
-
BRANCH="$(git rev-parse --abbrev-ref HEAD)"
|
|
37
|
-
UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
|
|
38
|
-
|
|
39
|
-
PARENT=""
|
|
40
|
-
if git rev-parse --verify -q "origin/main" >/dev/null; then
|
|
41
|
-
PARENT="origin/main"
|
|
42
|
-
elif git rev-parse --verify -q "origin/master" >/dev/null; then
|
|
43
|
-
PARENT="origin/master"
|
|
44
|
-
elif git rev-parse --verify -q "main" >/dev/null; then
|
|
45
|
-
PARENT="main"
|
|
46
|
-
elif git rev-parse --verify -q "master" >/dev/null; then
|
|
47
|
-
PARENT="master"
|
|
48
|
-
elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
|
|
49
|
-
PARENT="@{upstream}"
|
|
50
|
-
else
|
|
51
|
-
echo "Cannot determine parent ref" >&2
|
|
52
|
-
exit 1
|
|
53
|
-
fi
|
|
54
|
-
|
|
55
|
-
BASE_SHA="$(git merge-base HEAD "$PARENT")"
|
|
56
|
-
```
|
|
35
|
+
Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
|
|
57
36
|
|
|
58
37
|
Собери входные данные:
|
|
59
38
|
|
|
@@ -158,6 +137,20 @@ git diff --find-renames <FROM_SHA>..<TO_SHA>
|
|
|
158
137
|
|
|
159
138
|
---
|
|
160
139
|
|
|
140
|
+
## Scope Boundaries
|
|
141
|
+
|
|
142
|
+
This skill covers **code style and architecture patterns** — naming, organization, TypeScript usage, pattern compliance per `code-style-patterns.mdc`.
|
|
143
|
+
|
|
144
|
+
| Concern | This skill | Use instead |
|
|
145
|
+
|---------|-----------|-------------|
|
|
146
|
+
| Naming conventions, file organization, import order | ✅ YES | — |
|
|
147
|
+
| TypeScript patterns, component/hook structure | ✅ YES | — |
|
|
148
|
+
| Architecture pattern compliance | ✅ YES | — |
|
|
149
|
+
| Logic correctness, type safety deep dives | ❌ NO | `code-ai-review` or `code-learned-review` |
|
|
150
|
+
| MobX store internals | ❌ NO | `code-mobx-store-review` |
|
|
151
|
+
|
|
152
|
+
---
|
|
153
|
+
|
|
161
154
|
## Job Context Awareness
|
|
162
155
|
|
|
163
156
|
When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
|