@mrciphersmith/keryx 0.2.71 → 0.2.72

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mrciphersmith/keryx",
-  "version": "0.2.71",
+  "version": "0.2.72",
   "description": "Version-controlled project context for AI coding agents: code graph, architecture wiki, project memory, relevant tests, quality signals, and task flows.",
   "private": false,
   "publishConfig": {

package/src/gdskills/bundled/rules/core/code-review-learned-profile.mdc

@@ -0,0 +1,81 @@
+---
+description: "Learned review profile: a review checklist this project built from its own pull-request comments, not a style shipped with the tool."
+alwaysApply: false
+---
+
+# Learned Review Profile
+
+## What This Rule Is
+
+This is a **dynamic rule**. It carries no conventions of its own, and it ships
+empty of them on purpose.
+
+Every other review rule in `rules/core/` states what to flag. This one states
+**where the things to flag come from**: the pull-request comments left on this
+project, by the people this project named, applied to this project's own code.
+Nothing here describes a reviewer, a team, or a stack — because a rule that
+described one would be wrong for the next project that installed it.
+
+The checklist a reader wants lives in the project, in a project skill under
+`.metaproject/project-skills/<module>/<skill>/SKILL.md`. That file is written by
+`keryx review learn` proposing and `keryx skills learn apply` applying, and it
+never travels back into the tool.
+
+## Where The Content Comes From
+
+```
+keryx review comments collect   →  the durable record: who commented, and what they said
+keryx review learn              →  keeps the configured authors, writes a proposal
+keryx skills learn apply        →  writes the lesson into the project skill, bumps its version
+```
+
+`.metaproject/review-learning.config.json` names the three things the join needs:
+the local skill to teach, the repository to read, and the comment authors whose
+text counts. A project without that file does not learn — that is a supported
+state, not an error.
+
+`keryx review learn` reads the record `collect` already wrote; it does not talk
+to GitHub. An author the config does not name contributes nothing: their text
+reaches no proposal and no `SKILL.md`.
+
+## Two Boundaries That Are Enforced In Code, Not Advised Here
+
+- **Proposing never writes.** `keryx review learn` writes a proposal under
+  `.metaproject/data/gdskills/proposals/` and changes no skill. `keryx skills
+  learn apply` is the only writer, it refuses a proposal it has already applied,
+  and it records what it did in `skill-changelog.md`.
+- **Learned content cannot leave the project.** `applyLearningProposal` resolves
+  the target and refuses any path outside `.metaproject/project-skills/`. A
+  project that misconfigures its skill path cannot write into the shipped
+  templates under `src/gdskills/bundled/`; the apply fails instead.
+
+Both are assertions about code that exists. Neither is a request to be careful.
+
+## When To Apply
+
+Apply when the project has a learned review skill and the reader wants that
+project's accumulated review conventions rather than a generic pass. If the
+project has no learned skill yet, prefer `review-orchestrator` and its
+domain reviewers — an empty learned profile has nothing to say and should say
+nothing.
+
+## Response Format
+
+1. Verdict in one line — the canonical verdict vocabulary (same set as
+   `core/code-review-ai-assistant.mdc`):
+   - `APPROVE` — no blocking issues; changes accepted as-is
+   - `APPROVE WITH SUGGESTIONS` — accepted but improvements noted for follow-up
+   - `REQUEST CHANGES` — has issues that must be fixed before merge
+   - `COMMENT` — informational findings only; no blocking action required
+2. Top 1-3 blocking findings, each traceable to a line in the learned skill.
+3. Concrete replacement/fix path.
+
+## Guardrails
+
+- Cite the learned lesson a finding rests on. A finding with no line behind it in
+  the project skill is a generic review finding and belongs to the reviewer that
+  owns it.
+- Do not restate a lesson as a rule about people. The record says a comment was
+  left; it does not license a claim about who is usually right.
+- No personal attacks. No empty nitpicks. Keep recommendations lint-safe and
+  scoped.

package/src/gdskills/bundled/rules/core/jobs-documentation.mdc

@@ -112,7 +112,7 @@ The README is the entry point for both humans and AI agents. It MUST contain:
 1. [x] Analyze issue (issue-analyzer)
 2. [ ] Prepare feature branch
 3. [ ] Implement tasks (task-implementer)
-4. [ ] Review (code-ai-review, code-boss-review, code-style-review)
+4. [ ] Review (code-ai-review, code-learned-review, code-style-review)
 5. [ ] Fix review findings
 6. [ ] Final checks
 7. [ ] Generate report

package/src/gdskills/bundled/rules/core/review-strict-profile.mdc

@@ -1,15 +1,19 @@
 ---
-description: "boss-style review profile: direct, strict, architecture-first feedback with concrete fixes."
+description: "Strict review profile: direct, architecture-first feedback with concrete fixes."
 alwaysApply: false
 ---
 
-# boss Review Profile
+# Strict Review Profile
 
 ## Purpose
-Replicate the boss review style for requested reviews.
+Apply a strict, architecture-first pass: name the defect, name where the logic
+belongs, and give the replacement.
 
 ## When To Apply
-Apply when user explicitly asks for review in boss style.
+Apply when the caller explicitly asks for a strict review. For a checklist this
+project learned from its own pull-request comments, use
+`core/code-review-learned-profile.mdc` instead — that one carries no conventions
+of its own and reads them from the project.
 
 ## Style Profile
 - Direct and concise.

package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.codex.md

@@ -512,7 +512,7 @@ When the orchestrator dispatches this skill as a sub-agent:
 You are the context-collector agent. Your task is to research and build
 a context document for the current job.
 
-Load the skill from: skills/context-collector/SKILL.md
+Load the skill from: skills/orchestration/context-collector/SKILL.md
 
 ACTION: collect
 JOB_NAME: <job-name>
@@ -534,7 +534,7 @@ For updates:
 You are the context-collector agent. Your task is to update the existing
 context document for this job.
 
-Load the skill from: skills/context-collector/SKILL.md
+Load the skill from: skills/orchestration/context-collector/SKILL.md
 
 ACTION: update
 JOB_NAME: <job-name>

package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.cursor.md

@@ -512,7 +512,7 @@ When the orchestrator dispatches this skill as a sub-agent:
 You are the context-collector agent. Your task is to research and build
 a context document for the current job.
 
-Load the skill from: skills/context-collector/SKILL.md
+Load the skill from: skills/orchestration/context-collector/SKILL.md
 
 ACTION: collect
 JOB_NAME: <job-name>
@@ -534,7 +534,7 @@ For updates:
 You are the context-collector agent. Your task is to update the existing
 context document for this job.
 
-Load the skill from: skills/context-collector/SKILL.md
+Load the skill from: skills/orchestration/context-collector/SKILL.md
 
 ACTION: update
 JOB_NAME: <job-name>

package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.md

@@ -600,7 +600,7 @@ When the orchestrator dispatches this skill as a sub-agent:
 You are the context-collector agent. Your task is to research and build
 a context document for the current job.
 
-Load the skill from: skills/context-collector/SKILL.md
+Load the skill from: skills/orchestration/context-collector/SKILL.md
 
 ACTION: collect
 JOB_NAME: <job-name>
@@ -622,7 +622,7 @@ For updates:
 You are the context-collector agent. Your task is to update the existing
 context document for this job.
 
-Load the skill from: skills/context-collector/SKILL.md
+Load the skill from: skills/orchestration/context-collector/SKILL.md
 
 ACTION: update
 JOB_NAME: <job-name>

package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.opencode.md

@@ -512,7 +512,7 @@ When the orchestrator dispatches this skill as a sub-agent:
 You are the context-collector agent. Your task is to research and build
 a context document for the current job.
 
-Load the skill from: skills/context-collector/SKILL.md
+Load the skill from: skills/orchestration/context-collector/SKILL.md
 
 ACTION: collect
 JOB_NAME: <job-name>
@@ -534,7 +534,7 @@ For updates:
 You are the context-collector agent. Your task is to update the existing
 context document for this job.
 
-Load the skill from: skills/context-collector/SKILL.md
+Load the skill from: skills/orchestration/context-collector/SKILL.md
 
 ACTION: update
 JOB_NAME: <job-name>

package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.zed.md

@@ -512,7 +512,7 @@ When the orchestrator dispatches this skill as a sub-agent:
 You are the context-collector agent. Your task is to research and build
 a context document for the current job.
 
-Load the skill from: skills/context-collector/SKILL.md
+Load the skill from: skills/orchestration/context-collector/SKILL.md
 
 ACTION: collect
 JOB_NAME: <job-name>
@@ -534,7 +534,7 @@ For updates:
 You are the context-collector agent. Your task is to update the existing
 context document for this job.
 
-Load the skill from: skills/context-collector/SKILL.md
+Load the skill from: skills/orchestration/context-collector/SKILL.md
 
 ACTION: update
 JOB_NAME: <job-name>

package/src/gdskills/bundled/skills/orchestration/context-collector/orchestrator-prompt.md

@@ -58,7 +58,7 @@ IF ACTION == "update":
 You are the context-collector agent. Your task is to research and build
 a context document for the current job.
 
-Load the skill from: skills/context-collector/SKILL.md
+Load the skill from: skills/orchestration/context-collector/SKILL.md
 
 DO NOT ask the user any questions. Execute all phases autonomously.
 
@@ -85,7 +85,7 @@ and return a CONTEXT_RESULT block as your final message.
 You are the context-collector agent. Your task is to update the existing
 context document for this job.
 
-Load the skill from: skills/context-collector/SKILL.md
+Load the skill from: skills/orchestration/context-collector/SKILL.md
 
 DO NOT ask the user any questions. Execute the update flow autonomously.
 

package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.codex.md

@@ -996,9 +996,9 @@ For UI changes, use Playwright/Storybook (see AGENTS.md for available tools):
 **Leverage other skills via AGENTS.md catalog:**
 
 Before finalizing analysis, consider running:
-- `skills/code-style-review` - if architecture changes detected
-- `skills/code-ai-review` - for self-validation of findings
-- `skills/code-mobx-store-review` - if store changes found
+- `skills/review/code-style-review` - if architecture changes detected
+- `skills/review/code-ai-review` - for self-validation of findings
+- `skills/review/code-mobx-store-review` - if store changes found
 
 **How to invoke:**
 1. Reference `AGENTS.md` Skills Catalog

package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.cursor.md

@@ -996,9 +996,9 @@ For UI changes, use Playwright/Storybook (see AGENTS.md for available tools):
 **Leverage other skills via AGENTS.md catalog:**
 
 Before finalizing analysis, consider running:
-- `skills/code-style-review` - if architecture changes detected
-- `skills/code-ai-review` - for self-validation of findings
-- `skills/code-mobx-store-review` - if store changes found
+- `skills/review/code-style-review` - if architecture changes detected
+- `skills/review/code-ai-review` - for self-validation of findings
+- `skills/review/code-mobx-store-review` - if store changes found
 
 **How to invoke:**
 1. Reference `AGENTS.md` Skills Catalog

package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.md

@@ -322,9 +322,9 @@ Check `AGENTS.md` for available tools (`playwright-testing.mdc`, `storybook-guid
 ## Step 8: Integration with Other Skills
 
 Before finalizing, consider running:
-- `skills/code-style-review` — if architecture changes detected
-- `skills/code-ai-review` — for self-validation of findings
-- `skills/code-mobx-store-review` — if store changes found
+- `skills/review/code-style-review` — if architecture changes detected
+- `skills/review/code-ai-review` — for self-validation of findings
+- `skills/review/code-mobx-store-review` — if store changes found
 
 ---
 

package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.opencode.md

@@ -996,9 +996,9 @@ For UI changes, use Playwright/Storybook (see AGENTS.md for available tools):
 **Leverage other skills via AGENTS.md catalog:**
 
 Before finalizing analysis, consider running:
-- `skills/code-style-review` - if architecture changes detected
-- `skills/code-ai-review` - for self-validation of findings
-- `skills/code-mobx-store-review` - if store changes found
+- `skills/review/code-style-review` - if architecture changes detected
+- `skills/review/code-ai-review` - for self-validation of findings
+- `skills/review/code-mobx-store-review` - if store changes found
 
 **How to invoke:**
 1. Reference `AGENTS.md` Skills Catalog

package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.zed.md

@@ -996,9 +996,9 @@ For UI changes, use Playwright/Storybook (see AGENTS.md for available tools):
 **Leverage other skills via AGENTS.md catalog:**
 
 Before finalizing analysis, consider running:
-- `skills/code-style-review` - if architecture changes detected
-- `skills/code-ai-review` - for self-validation of findings
-- `skills/code-mobx-store-review` - if store changes found
+- `skills/review/code-style-review` - if architecture changes detected
+- `skills/review/code-ai-review` - for self-validation of findings
+- `skills/review/code-mobx-store-review` - if store changes found
 
 **How to invoke:**
 1. Reference `AGENTS.md` Skills Catalog

package/src/gdskills/bundled/skills/orchestration/feature-dev/SKILL.codex.md

@@ -70,7 +70,7 @@ End-to-end feature development workflow from idea to merge-ready PR.
 5. Fix failing tests (max 3 attempts per test)
 
 ### Phase 6: REVIEW (Self)
-1. Launch `code-review` skill on own changes (if available)
+1. Launch the `review-orchestrator` skill on own changes
 2. Or run a focused self-review:
    - `git diff main...HEAD` — review the full diff
    - Check for: TODOs left behind, console.logs, hardcoded values

package/src/gdskills/bundled/skills/orchestration/feature-dev/SKILL.cursor.md

@@ -70,7 +70,7 @@ End-to-end feature development workflow from idea to merge-ready PR.
 5. Fix failing tests (max 3 attempts per test)
 
 ### Phase 6: REVIEW (Self)
-1. Launch `code-review` skill on own changes (if available)
+1. Launch the `review-orchestrator` skill on own changes
 2. Or run a focused self-review:
    - `git diff main...HEAD` — review the full diff
    - Check for: TODOs left behind, console.logs, hardcoded values

package/src/gdskills/bundled/skills/orchestration/feature-dev/SKILL.md

@@ -97,7 +97,7 @@ End-to-end feature development workflow from idea to merge-ready PR.
 Run `code-verifier` on the full diff:
 
 ```
-Invoke: skills/code-verifier/SKILL.md
+Invoke: skills/orchestration/code-verifier/SKILL.md
 Input:  codebase_path=<project_root>, scope=changed, base_branch=<base>
 ```
 
@@ -107,7 +107,7 @@ Input:  codebase_path=<project_root>, scope=changed, base_branch=<base>
 
 ### Phase 7: REVIEW (Self)
 
-1. Launch `code-review` skill on own changes (if available)
+1. Launch the `review-orchestrator` skill on own changes
 2. Or run a focused self-review:
    - `git diff main...HEAD` — review the full diff
    - Check for: TODOs left behind, console.logs, hardcoded values

package/src/gdskills/bundled/skills/orchestration/flow-orchestrator/SKILL.md

@@ -385,8 +385,8 @@ Before accepting implementation:
    the `skill_drift` fields from task-implementer results and the
    `## Skill Learning` block from review-orchestrator. For each flagged
    project-skill, dispatch a subagent — on a cheaper / non-flagship model if one
-   is available (`.metaproject/scripts/detect-models.sh`; see
-   `rules/core/model-selection.mdc`), otherwise the session model — to run
+   is available (`keryx review tier --findings 1 --diff-lines 0` resolves one from runtime
+   provider detection; see `rules/core/model-selection.mdc`), otherwise the session model — to run
    `keryx skills learn --from-review <report> --skill <m>/<s>` and return the
    proposal. Then read the proposal and `skills learn apply` it, or discard it.
    Never apply unread; never put `learn` in a hook.

package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.codex.md

@@ -336,7 +336,7 @@ When the orchestrator dispatches this skill as a sub-agent, it should use this p
 ```
 You are the job-documenter agent. Your task is to manage job documentation.
 
-Load the skill from: skills/job-documenter/SKILL.md
+Load the skill from: skills/orchestration/job-documenter/SKILL.md
 Follow the rules from: rules/core/jobs-documentation.mdc
 
 ACTION: <action>

package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.cursor.md

@@ -336,7 +336,7 @@ When the orchestrator dispatches this skill as a sub-agent, it should use this p
 ```
 You are the job-documenter agent. Your task is to manage job documentation.
 
-Load the skill from: skills/job-documenter/SKILL.md
+Load the skill from: skills/orchestration/job-documenter/SKILL.md
 Follow the rules from: rules/core/jobs-documentation.mdc
 
 ACTION: <action>

package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.md

@@ -345,7 +345,7 @@ When the orchestrator dispatches this skill as a sub-agent, it should use this p
 ```
 You are the job-documenter agent. Your task is to manage job documentation.
 
-Load the skill from: skills/job-documenter/SKILL.md
+Load the skill from: skills/orchestration/job-documenter/SKILL.md
 Follow the rules from: rules/core/jobs-documentation.mdc
 
 ACTION: <action>

package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.opencode.md

@@ -336,7 +336,7 @@ When the orchestrator dispatches this skill as a sub-agent, it should use this p
 ```
 You are the job-documenter agent. Your task is to manage job documentation.
 
-Load the skill from: skills/job-documenter/SKILL.md
+Load the skill from: skills/orchestration/job-documenter/SKILL.md
 Follow the rules from: rules/core/jobs-documentation.mdc
 
 ACTION: <action>

package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.zed.md

@@ -336,7 +336,7 @@ When the orchestrator dispatches this skill as a sub-agent, it should use this p
 ```
 You are the job-documenter agent. Your task is to manage job documentation.
 
-Load the skill from: skills/job-documenter/SKILL.md
+Load the skill from: skills/orchestration/job-documenter/SKILL.md
 Follow the rules from: rules/core/jobs-documentation.mdc
 
 ACTION: <action>