@mpgd/adapter-devvit 0.13.3 → 0.13.4

package/dist/server/commerce-bridge.d.ts

@@ -20,6 +20,12 @@ export declare const devvitCommerceV2MethodUnsupportedBridgeErrorCode: 'COMMERCE
 export declare const devvitCommerceCheckoutClientOnlyBridgeErrorCode: 'DEVVIT_COMMERCE_CHECKOUT_CLIENT_ONLY';
 /** Bridge error when the payments plugin fails; retryable. */
 export declare const devvitPaymentsUnavailableBridgeErrorCode: 'DEVVIT_PAYMENTS_UNAVAILABLE';
+/**
+* Bridge error when the paid-order scan hit its page cap with pages left.
+* Retryable. A caller must not treat orders absent from this scan as delivered:
+* the list was not finished.
+*/
+export declare const devvitOrderScanIncompleteBridgeErrorCode: 'DEVVIT_ORDER_SCAN_INCOMPLETE';
 /** `Order.status` as `@devvit/protos` encodes it (`OrderStatus` enum) or as the handler types spell it. */
 export type DevvitPaymentsOrderStatusLike = number | string;
 /** The fields of a `@devvit/payments` `Order` the handler reads. */
@@ -81,6 +87,17 @@ export interface DevvitCommerceV2BridgeHandler {
   request(input: BridgeRequest): Promise<BridgeResponse>;
 }
 /**
+* Hard cap on the pages scanned per listing. `@devvit/payments` 0.14 ignores
+* `status` and `buyer` (`GetOrdersRequest` marks both "currently does nothing";
+* an empty filter means every order), and `PaymentsClient` forwards the
+* request unchanged, so every status is scanned. Devvit serves this handler
+* inside a time-bounded HTTP request. Thirty-two serial plugin calls stay
+* inside that budget (the kit treats about 20 seconds as the practical limit
+* for a Devvit task). Hitting the cap with a next page fails the request
+* instead of returning a partial list: unseen orders are not delivered.
+*/
+export declare const maximumDevvitOrderScanPages = 32;
+/**
 * Serves `commerce.v2.*` from the payments plugin:
 *
 * - `getCapabilities` answers the Devvit profile (`createDevvitCommerceCapabilities`).
@@ -92,13 +109,10 @@ export interface DevvitCommerceV2BridgeHandler {
 *   `purchased` (the order id as `transactionId` and `token`,
 *   `devvit.order.v1` evidence whose `status` says which), bounded by
 *   `maximumDevvitAvailableOrders`. Reddit marks an order `DELIVERED` as soon
-*   as the fulfillment handler answered, so the delivered orders are the ones
-*   whose ledger entry exists; the webview provider lists only the `PAID`
-*   ones as available and reports both as events, so a session that lost its
-*   checkout result still finds the order. The scan reads pages of 64
-*   (newest first, as the Devvit docs describe) and stops after two
-*   consecutive pages without a paid or delivered order or after
-*   `maximumOrderPages`, warning when pages are left.
+*   as the fulfillment handler answered. The scan reads pages of 64 until the
+*   cursor ends, or until `maximumDevvitOrderScanPages`. A scan that still has
+*   a next page at that cap fails with `DEVVIT_ORDER_SCAN_INCOMPLETE` rather
+*   than returning a partial list: an order that was not read is not delivered.
 * - `requestPurchase` is refused with `DEVVIT_COMMERCE_CHECKOUT_CLIENT_ONLY`,
 *   `finishTransaction` with `COMMERCE_V2_METHOD_UNSUPPORTED`, and
 *   `restorePurchases` answers `{ restored: false }`: the webview provider

package/dist/server/commerce-bridge.js

@@ -22,6 +22,12 @@ export const devvitCommerceV2MethodUnsupportedBridgeErrorCode = 'COMMERCE_V2_MET
 export const devvitCommerceCheckoutClientOnlyBridgeErrorCode = 'DEVVIT_COMMERCE_CHECKOUT_CLIENT_ONLY';
 /** Bridge error when the payments plugin fails; retryable. */
 export const devvitPaymentsUnavailableBridgeErrorCode = 'DEVVIT_PAYMENTS_UNAVAILABLE';
+/**
+ * Bridge error when the paid-order scan hit its page cap with pages left.
+ * Retryable. A caller must not treat orders absent from this scan as delivered:
+ * the list was not finished.
+ */
+export const devvitOrderScanIncompleteBridgeErrorCode = 'DEVVIT_ORDER_SCAN_INCOMPLETE';
 /** `OrderStatus.ORDER_STATUS_PAID` of `@devvit/protos`, and its handler-type spelling. */
 const paidOrderStatuses = new Set([
     3,
@@ -61,17 +67,16 @@ const durableAccountingTypes = new Set([
 ]);
 const orderPageSize = maximumDevvitAvailableOrders;
 /**
- * Hard cap on the pages scanned per listing. The plugin's `status` filter
- * does nothing in `@devvit/payments` 0.14 (its proto marks it so, and the
- * `PaymentsClient` forwards it unchanged), so every status is scanned. The
- * Devvit docs describe the list as newest first ("Manage Payments", "Check
- * orders"); that is documentation, not a plugin guarantee, so the scan stops
- * early only after two consecutive pages without a paid or delivered order,
- * and warns when it stops with pages left.
+ * Hard cap on the pages scanned per listing. `@devvit/payments` 0.14 ignores
+ * `status` and `buyer` (`GetOrdersRequest` marks both "currently does nothing";
+ * an empty filter means every order), and `PaymentsClient` forwards the
+ * request unchanged, so every status is scanned. Devvit serves this handler
+ * inside a time-bounded HTTP request. Thirty-two serial plugin calls stay
+ * inside that budget (the kit treats about 20 seconds as the practical limit
+ * for a Devvit task). Hitting the cap with a next page fails the request
+ * instead of returning a partial list: unseen orders are not delivered.
  */
-const maximumOrderPages = 8;
-/** Consecutive pages without a paid or delivered order after which the scan stops early. */
-const settledPagesBeforeStop = 2;
+export const maximumDevvitOrderScanPages = 32;
 /**
  * Serves `commerce.v2.*` from the payments plugin:
  *
@@ -84,13 +89,10 @@ const settledPagesBeforeStop = 2;
  *   `purchased` (the order id as `transactionId` and `token`,
  *   `devvit.order.v1` evidence whose `status` says which), bounded by
  *   `maximumDevvitAvailableOrders`. Reddit marks an order `DELIVERED` as soon
- *   as the fulfillment handler answered, so the delivered orders are the ones
- *   whose ledger entry exists; the webview provider lists only the `PAID`
- *   ones as available and reports both as events, so a session that lost its
- *   checkout result still finds the order. The scan reads pages of 64
- *   (newest first, as the Devvit docs describe) and stops after two
- *   consecutive pages without a paid or delivered order or after
- *   `maximumOrderPages`, warning when pages are left.
+ *   as the fulfillment handler answered. The scan reads pages of 64 until the
+ *   cursor ends, or until `maximumDevvitOrderScanPages`. A scan that still has
+ *   a next page at that cap fails with `DEVVIT_ORDER_SCAN_INCOMPLETE` rather
+ *   than returning a partial list: an order that was not read is not delivered.
  * - `requestPurchase` is refused with `DEVVIT_COMMERCE_CHECKOUT_CLIENT_ONLY`,
  *   `finishTransaction` with `COMMERCE_V2_METHOD_UNSUPPORTED`, and
  *   `restorePurchases` answers `{ restored: false }`: the webview provider
@@ -113,19 +115,14 @@ export function createDevvitCommerceV2BridgeHandler(input) {
     const listPaidOrders = async () => {
         const orders = [];
         let cursor;
-        let settledPages = 0;
-        for (let page = 0; page < maximumOrderPages; page += 1) {
+        for (let page = 0; page < maximumDevvitOrderScanPages; page += 1) {
             const response = await input.payments.getOrders({
                 limit: orderPageSize,
                 ...(cursor === undefined ? {} : { cursor }),
             });
             const next = response.pageInfo;
             const hasNextPage = next !== undefined && next.hasNextPage && next.endCursor.length > 0;
-            let listableOnPage = 0;
             for (const [index, order] of response.orders.entries()) {
-                if (paidOrderStatuses.has(order.status) || deliveredOrderStatuses.has(order.status)) {
-                    listableOnPage += 1;
-                }
                 const paid = readListedOrder(order, productsBySku);
                 if (paid !== undefined) {
                     orders.push(paid);
@@ -138,21 +135,15 @@ export function createDevvitCommerceV2BridgeHandler(input) {
                 }
             }
             if (!hasNextPage || next === undefined) {
-                break;
+                return orders;
             }
-            settledPages = listableOnPage === 0 ? settledPages + 1 : 0;
-            if (settledPages >= settledPagesBeforeStop) {
-                // Newest first, as documented: the older pages left hold nothing to list.
-                warn(`Devvit order scan stopped after ${String(settledPagesBeforeStop)} pages without a `
-                    + 'paid or delivered order; older pages were not read.');
-                break;
-            }
-            if (page + 1 === maximumOrderPages) {
-                warn('Devvit order scan reached its page cap; older pages were not read.');
+            if (page + 1 === maximumDevvitOrderScanPages) {
+                // A partial list would look complete. Unseen orders are not delivered.
+                throw incompleteOrderScan();
             }
             cursor = next.endCursor;
         }
-        return orders;
+        throw incompleteOrderScan();
     };
     const serve = async (request) => {
         const { payload } = request;
@@ -343,6 +334,14 @@ function normalizeBridgeProducts(input) {
         return { productId: product.productId, sku: product.sku };
     });
 }
+function incompleteOrderScan() {
+    return new PlatformOperationError({
+        code: devvitOrderScanIncompleteBridgeErrorCode,
+        message: `Devvit order scan is incomplete: it reached ${String(maximumDevvitOrderScanPages)} `
+            + 'pages with pages left. Unseen orders were not read and are not delivered.',
+        retryable: true,
+    });
+}
 async function paymentsCall(call) {
     try {
         return await call();

package/dist/server/redis-verified-leaderboard.js

@@ -4,6 +4,8 @@ const defaultSnapshotLimit = 10;
 const defaultTransactionAttempts = 3;
 const maximumTransactionAttempts = 32;
 const keyPrefixPattern = /^[A-Za-z0-9:_-]{1,128}$/;
+/** The commit marker's value; its SET replies `OK`, which `@devvit/redis` always maps. */
+const commitMarkerValue = '1';
 /**
  * Durable Devvit Redis provider for modest verified leaderboards. Writes are
  * fenced with WATCH/MULTI/EXEC and keep the original idempotency response.
@@ -66,13 +68,22 @@ export function createDevvitRedisVerifiedLeaderboardService(redis, options = {})
                     await transaction.hSet(keys.attempts, {
                         [attemptMember]: serializeAttemptDecision(request.attempt, response),
                     });
+                    // `@devvit/redis` `TxClient.exec()` resolves an aborted WATCH as `[]`
+                    // and drops zero or nil replies. The marker's `OK` always maps, so a
+                    // committed EXEC answers at least that reply even when the array is
+                    // shorter than the queued commands. Only an empty, `null`, or all-nil
+                    // result is an abort. Requiring `results.length === queued` would
+                    // retry a landed score whose zero replies Devvit dropped.
+                    await transaction.set(keys.commitMarker, commitMarkerValue);
                     const results = await transaction.exec();
-                    if (results === null || (Array.isArray(results) && results.length === 0)) {
-                        continue;
-                    }
-                    if (!Array.isArray(results)) {
+                    if (results !== null && !Array.isArray(results)) {
                         throw new Error('Devvit Redis transaction returned an unsupported response.');
                     }
+                    if (results === null
+                        || results.length === 0
+                        || results.every((reply) => reply === null || reply === undefined)) {
+                        continue;
+                    }
                     return response;
                 }
                 catch (error) {
@@ -136,6 +147,7 @@ async function createBoardKeys(keyPrefix, leaderboardId) {
         attempts: `${base}:attempts`,
         entries: `${base}:entries`,
         ranking: `${base}:ranking`,
+        commitMarker: `${keyPrefix}:commit`,
     };
     return {
         ...keys,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mpgd/adapter-devvit",
-  "version": "0.13.3",
+  "version": "0.13.4",
   "description": "Reddit Devvit Web platform adapter for mpgd games.",
   "license": "MIT",
   "repository": {
@@ -55,9 +55,9 @@
   ],
   "dependencies": {
     "@devvit/web": "0.14.1",
-    "@mpgd/bridge": "0.14.2",
-    "@mpgd/platform": "0.27.0",
-    "@mpgd/game-services": "0.27.0"
+    "@mpgd/bridge": "0.14.3",
+    "@mpgd/platform": "0.27.1",
+    "@mpgd/game-services": "0.27.1"
   },
   "devDependencies": {
     "@types/node": "^24.0.0",