@mparticle/web-sdk 2.23.7 → 2.23.8

package/src/identity.js

@@ -4,6 +4,8 @@ import Types from './types';
 var Messages = Constants.Messages,
     HTTPCodes = Constants.HTTPCodes;
 
+const { Identify, Modify } = Constants.IdentityMethods;
+
 export default function Identity(mpInstance) {
     var self = this;
     this.checkIdentitySwap = function(
@@ -1476,7 +1478,7 @@ export default function Identity(mpInstance) {
             }
 
             if (xhr.status === 200) {
-                if (method === 'modify') {
+                if (method === Modify) {
                     newIdentitiesByType = mpInstance._Identity.IdentityRequest.combineUserIdentities(
                         previousUIByName,
                         identityApiData.userIdentities
@@ -1507,7 +1509,7 @@ export default function Identity(mpInstance) {
                     //will not have a value for "fst" until the current MPID changes, and in some cases,
                     //the current MPID will never change
                     if (
-                        method === 'identify' &&
+                        method === Identify &&
                         prevUser &&
                         identityApiResult.mpid === prevUser.getMPID()
                     ) {
@@ -1568,6 +1570,7 @@ export default function Identity(mpInstance) {
                         );
                     }
 
+                    // https://go.mparticle.com/work/SQDSDKS-6041
                     mpInstance._Persistence.saveUserIdentitiesToPersistence(
                         identityApiResult.mpid,
                         newIdentitiesByType
@@ -1620,6 +1623,8 @@ export default function Identity(mpInstance) {
                             mpInstance._APIClient.prepareForwardingStats
                         );
                     }
+
+                    // TODO: https://go.mparticle.com/work/SQDSDKS-6036
                     mpInstance._Forwarders.setForwarderUserIdentities(
                         newUser.getUserIdentities().userIdentities
                     );
@@ -1628,8 +1633,7 @@ export default function Identity(mpInstance) {
                         method
                     );
                     mpInstance._Forwarders.setForwarderOnUserIdentified(
-                        newUser,
-                        method
+                        newUser
                     );
                 }
                 var newIdentitiesByName = {};
@@ -1646,7 +1650,7 @@ export default function Identity(mpInstance) {
                     newIdentitiesByName,
                     method,
                     identityApiResult.mpid,
-                    method === 'modify'
+                    method === Modify
                         ? previousUIByNameCopy
                         : incomingMpidUIByNameCopy
                 );

package/src/identityApiClient.js

@@ -3,6 +3,8 @@ import Constants from './constants';
 var HTTPCodes = Constants.HTTPCodes,
     Messages = Constants.Messages;
 
+const { Modify } = Constants.IdentityMethods;
+
 export default function IdentityAPIClient(mpInstance) {
     this.sendAliasRequest = function(aliasRequest, callback) {
         var xhr,
@@ -107,7 +109,7 @@ export default function IdentityAPIClient(mpInstance) {
                     );
                 } else {
                     previousMPID = mpid || null;
-                    if (method === 'modify') {
+                    if (method === Modify) {
                         xhr.open(
                             'post',
                             mpInstance._Helpers.createServiceUrl(

package/src/mp-instance.js

@@ -1330,6 +1330,7 @@ function completeSDKInitialization(apiKey, config, mpInstance) {
 
     mpInstance._Store.configurationLoaded = true;
 
+    // https://go.mparticle.com/work/SQDSDKS-6044
     if (!mpInstance._Store.webviewBridgeEnabled) {
         // Load any settings/identities/attributes from cookie or localStorage
         mpInstance._Persistence.initializeStorage();
@@ -1401,6 +1402,7 @@ function completeSDKInitialization(apiKey, config, mpInstance) {
         mpInstance._Events.logAST();
 
         // Call mParticle._Store.SDKConfig.identityCallback when identify was not called due to a reload or a sessionId already existing
+        // Any identity callback should always be ran regardless if an identity call is made
         if (
             !mpInstance._Store.identifyCalled &&
             mpInstance._Store.SDKConfig.identityCallback &&
@@ -1455,6 +1457,7 @@ function completeSDKInitialization(apiKey, config, mpInstance) {
         mpInstance._preInit.readyQueue = [];
     }
 
+    // https://go.mparticle.com/work/SQDSDKS-6040
     if (mpInstance._Store.isFirstRun) {
         mpInstance._Store.isFirstRun = false;
     }

package/src/persistence.js

@@ -10,6 +10,8 @@ var Base64 = Polyfill.Base64,
 
 export default function _Persistence(mpInstance) {
     var self = this;
+
+    // https://go.mparticle.com/work/SQDSDKS-5022
     this.useLocalStorage = function() {
         return (
             !mpInstance._Store.SDKConfig.useCookieStorage &&
@@ -24,6 +26,7 @@ export default function _Persistence(mpInstance) {
                 cookies = self.getCookie(),
                 allData;
 
+            // https://go.mparticle.com/work/SQDSDKS-6045
             // Determine if there is any data in cookies or localStorage to figure out if it is the first time the browser is loading mParticle
             if (!localStorageData && !cookies) {
                 mpInstance._Store.isFirstRun = true;
@@ -32,10 +35,12 @@ export default function _Persistence(mpInstance) {
                 mpInstance._Store.isFirstRun = false;
             }
 
+            // https://go.mparticle.com/work/SQDSDKS-6045
             if (!mpInstance._Store.isLocalStorageAvailable) {
                 mpInstance._Store.SDKConfig.useCookieStorage = true;
             }
 
+            // https://go.mparticle.com/work/SQDSDKS-6046
             if (mpInstance._Store.isLocalStorageAvailable) {
                 storage = window.localStorage;
                 if (mpInstance._Store.SDKConfig.useCookieStorage) {
@@ -43,6 +48,7 @@ export default function _Persistence(mpInstance) {
                     // no mParticle cookie exists yet and there is localStorage. Get the localStorage, set them to cookies, then delete the localStorage item.
                     if (localStorageData) {
                         if (cookies) {
+                            // https://go.mparticle.com/work/SQDSDKS-6047
                             allData = mpInstance._Helpers.extend(
                                 false,
                                 localStorageData,
@@ -61,6 +67,7 @@ export default function _Persistence(mpInstance) {
                     // no mParticle localStorage exists yet and there are cookies. Get the cookies, set them to localStorage, then delete the cookies.
                     if (cookies) {
                         if (localStorageData) {
+                            // https://go.mparticle.com/work/SQDSDKS-6047
                             allData = mpInstance._Helpers.extend(
                                 false,
                                 localStorageData,
@@ -79,6 +86,7 @@ export default function _Persistence(mpInstance) {
                 self.storeDataInMemory(cookies);
             }
 
+            // https://go.mparticle.com/work/SQDSDKS-6048
             try {
                 if (mpInstance._Store.isLocalStorageAvailable) {
                     var encodedProducts = localStorage.getItem(
@@ -107,6 +115,8 @@ export default function _Persistence(mpInstance) {
                 );
             }
 
+            // https://go.mparticle.com/work/SQDSDKS-6046
+            // Stores all non-current user MPID information into the store
             for (var key in allData) {
                 if (allData.hasOwnProperty(key)) {
                     if (!SDKv2NonMPIDCookieKeys[key]) {
@@ -117,6 +127,8 @@ export default function _Persistence(mpInstance) {
             }
             self.update();
         } catch (e) {
+            // If cookies or local storage is corrupt, we want to remove it
+            // so that in the future, initializeStorage will work
             if (
                 self.useLocalStorage() &&
                 mpInstance._Store.isLocalStorageAvailable
@@ -154,6 +166,7 @@ export default function _Persistence(mpInstance) {
         }
     };
 
+    // https://go.mparticle.com/work/SQDSDKS-6045
     this.storeDataInMemory = function(obj, currentMPID) {
         try {
             if (!obj) {
@@ -235,6 +248,7 @@ export default function _Persistence(mpInstance) {
         }
     };
 
+    // https://go.mparticle.com/work/SQDSDKS-5022
     this.determineLocalStorageAvailability = function(storage) {
         var result;
 
@@ -310,6 +324,7 @@ export default function _Persistence(mpInstance) {
         return parsedDecodedProducts;
     };
 
+    // https://go.mparticle.com/work/SQDSDKS-6021
     this.setLocalStorage = function() {
         if (!mpInstance._Store.isLocalStorageAvailable) {
             return;
@@ -492,7 +507,8 @@ export default function _Persistence(mpInstance) {
         }
     };
 
-    // only used in persistence
+    // https://go.mparticle.com/work/SQDSDKS-5022
+    // https://go.mparticle.com/work/SQDSDKS-6021
     this.setCookie = function() {
         var mpid,
             currentUser = mpInstance.Identity.getCurrentUser();
@@ -996,6 +1012,7 @@ export default function _Persistence(mpInstance) {
         }
     };
 
+    // https://go.mparticle.com/work/SQDSDKS-6021
     this.savePersistence = function(persistence) {
         var encodedPersistence = self.encodePersistence(
                 JSON.stringify(persistence)
@@ -1168,6 +1185,7 @@ export default function _Persistence(mpInstance) {
         }
     };
 
+    // https://go.mparticle.com/work/SQDSDKS-6045
     // Forwarder Batching Code
     this.forwardingStatsBatches = {
         uploadsTable: {},

package/src/sdkRuntimeModels.ts

@@ -10,6 +10,7 @@ import { SDKConsentApi, SDKConsentState } from './consent';
 import { IPersistence } from './persistence.interfaces';
 import { IMPSideloadedKit } from './sideloadedKit';
 import { ISessionManager } from './sessionManager';
+import { Kit, MPForwarder } from './forwarders.interfaces';
 
 // TODO: Resolve this with version in @mparticle/web-sdk
 export type SDKEventCustomFlags = Dictionary<any>;
@@ -184,10 +185,6 @@ export type BooleanStringTitleCase = 'False' | 'True';
 
 export type LogLevelType = 'none' | 'verbose' | 'warning' | 'error';
 
-// TODO: Create true types for Kits and Kit Configs
-export type Kit = Dictionary;
-export type MPForwarder = Dictionary;
-
 // TODO: This should eventually be moved into wherever init logic lives
 // TODO: Replace/Merge this with MPConfiguration in @types/mparticle__web-sdk
 // SDK Init Config represents the config that is passed into mParticle.init when

package/src/serverModel.ts

@@ -13,7 +13,12 @@ import {
     SDKProduct,
     SDKUserIdentity,
 } from './sdkRuntimeModels';
-import { parseNumber, parseStringOrNumber, Dictionary } from './utils';
+import {
+    parseNumber,
+    parseStringOrNumber,
+    Dictionary,
+    isValidCustomFlagProperty,
+} from './utils';
 import { ServerSettings } from './store';
 import { MPID } from '@mparticle/web-sdk';
 import {
@@ -145,22 +150,12 @@ function convertCustomFlags(event: SDKEvent, dto: IServerV2DTO) {
 
         if (event.CustomFlags.hasOwnProperty(prop)) {
             if (Array.isArray(event.CustomFlags[prop])) {
-                event.CustomFlags[prop].forEach(function(customFlagProperty) {
-                    // TODO: Can we use our utility functions here?
-                    if (
-                        typeof customFlagProperty === 'number' ||
-                        typeof customFlagProperty === 'string' ||
-                        typeof customFlagProperty === 'boolean'
-                    ) {
+                event.CustomFlags[prop].forEach(customFlagProperty => {
+                    if (isValidCustomFlagProperty(customFlagProperty)) {
                         valueArray.push(customFlagProperty.toString());
                     }
                 });
-            } else if (
-                // TODO: Can we use our utility functions here?
-                typeof event.CustomFlags[prop] === 'number' ||
-                typeof event.CustomFlags[prop] === 'string' ||
-                typeof event.CustomFlags[prop] === 'boolean'
-            ) {
+            } else if (isValidCustomFlagProperty(event.CustomFlags[prop])) {
                 valueArray.push(event.CustomFlags[prop].toString());
             }
 

package/src/sessionManager.ts

@@ -44,6 +44,7 @@ export default function SessionManager(
                 self.endSession();
                 self.startNewSession();
             } else {
+                // https://go.mparticle.com/work/SQDSDKS-6045
                 const persistence: IPersistenceMinified = mpInstance._Persistence.getPersistence();
                 if (persistence && !persistence.cu) {
                     mpInstance.Identity.identify(

package/src/store.ts

@@ -11,11 +11,9 @@ import { IKitConfigs } from './configAPIClient';
 import Constants from './constants';
 import {
     DataPlanResult,
-    Kit,
     KitBlockerOptions,
     LogLevelType,
     MParticleWebSDK,
-    MPForwarder,
     SDKDataPlan,
     SDKEvent,
     SDKGeoLocation,
@@ -24,6 +22,7 @@ import {
 } from './sdkRuntimeModels';
 import { isNumber, isDataPlanSlug, Dictionary } from './utils';
 import { SDKConsentState } from './consent';
+import { Kit, MPForwarder } from './forwarders.interfaces';
 
 // This represents the runtime configuration of the SDK AFTER
 // initialization has been complete and all settings and

package/src/utils.ts

@@ -201,7 +201,10 @@ const converted = (s: string): string => {
 
 const isString = (value: any): boolean => typeof value === 'string';
 const isNumber = (value: any): boolean => typeof value === 'number';
+const isBoolean = (value: any): boolean => typeof value === 'boolean';
 const isFunction = (fn: any): boolean => typeof fn === 'function';
+const isValidCustomFlagProperty = (value: any): boolean =>
+    isNumber(value) || isString(value) || isBoolean(value);
 
 const toDataPlanSlug = (value: any): string =>
     // Make sure we are only acting on strings or numbers
@@ -247,4 +250,5 @@ export {
     isFunction,
     isDataPlanSlug,
     isEmpty,
+    isValidCustomFlagProperty,
 };

package/src/validators.ts

@@ -1,5 +1,11 @@
 import Types from './types';
-import { isFunction, isNumber, isObject, isStringOrNumber, valueof } from './utils';
+import {
+    isFunction,
+    isNumber,
+    isObject,
+    isStringOrNumber,
+    valueof,
+} from './utils';
 import Constants from './constants';
 import { IdentityApiData } from '@mparticle/web-sdk';
 
@@ -10,6 +16,8 @@ type ValidationIdentitiesReturn = {
     error?: valueof<typeof Constants.Messages.ValidationMessages>;
 };
 
+const { Modify } = Constants.IdentityMethods;
+
 const Validators = {
     // From ./utils
     // Utility Functions for backwards compatability
@@ -43,7 +51,7 @@ const Validators = {
             copyUserAttributes: 1,
         };
         if (identityApiData) {
-            if (method === 'modify') {
+            if (method === Modify) {
                 if (
                     (isObject(identityApiData.userIdentities) &&
                         !Object.keys(identityApiData.userIdentities).length) ||