@mp-consulting/homebridge-daikin-cloud 1.3.6 → 1.3.7

package/package.json

@@ -2,12 +2,12 @@
   "displayName": "Daikin Cloud",
   "platformname": "daikincloud",
   "name": "@mp-consulting/homebridge-daikin-cloud",
-  "version": "1.3.6",
+  "version": "1.3.7",
   "description": "Integrate with the Daikin Cloud to control your Daikin air conditioning via the cloud",
-  "license": "Apache-2.0",
+  "license": "(Apache-2.0 AND MIT)",
   "repository": {
     "type": "git",
-    "url": "git://github.com/mp-consulting/homebridge-daikin-cloud.git"
+    "url": "git+https://github.com/mp-consulting/homebridge-daikin-cloud.git"
   },
   "bugs": {
     "url": "https://github.com/mp-consulting/homebridge-daikin-cloud/issues"
@@ -20,11 +20,13 @@
   "customUi": true,
   "customUiPath": "./homebridge-ui",
   "scripts": {
-    "test": "jest",
-    "test:updateSnapshots": "jest --updateSnapshot",
-    "lint": "eslint 'src/**/*.ts' --max-warnings=0",
+    "test": "vitest run",
+    "test:watch": "vitest",
+    "test:coverage": "vitest run --coverage",
+    "lint": "eslint . --max-warnings=0",
     "watch": "npm run build && npm link && nodemon",
     "build": "rimraf ./dist && tsc",
+    "prepublishOnly": "npm run lint && npm run build",
     "release": "npm publish",
     "release:beta": "npm publish --tag beta"
   },
@@ -37,26 +39,27 @@
     "zod": "^3.23.8"
   },
   "devDependencies": {
-    "@types/jest": "^29.5.4",
-    "@types/node": "^20.14.6",
+    "@eslint/js": "^9.39.2",
+    "@types/node": "^24.0.0",
     "@types/ws": "^8.18.1",
-    "@typescript-eslint/eslint-plugin": "^5.30.7",
-    "@typescript-eslint/parser": "^5.30.7",
-    "eslint": "^8.20.0",
+    "@vitest/coverage-v8": "^4.0.18",
+    "eslint": "^9.39.2",
     "hap-nodejs": "^1.1.0",
-    "homebridge": "^1.8.4",
-    "homebridge-config-ui-x": "^4.56.4",
-    "jest": "^29.7.0",
-    "nodemon": "^3.0.1",
-    "rimraf": "^3.0.2",
-    "ts-jest": "^29.1.1",
-    "ts-node": "^10.3.0",
-    "typescript": "^4.4.4"
+    "homebridge": "^2.0.0-beta.55",
+    "homebridge-config-ui-x": "^5.15.0",
+    "nodemon": "^3.1.11",
+    "rimraf": "^6.1.0",
+    "typescript": "^5.9.3",
+    "typescript-eslint": "^8.53.1",
+    "vitest": "^4.0.18"
   },
-  "funding": [
-    {
-      "type": "paypal",
-      "url": "https://www.paypal.me/MickaelPalma"
-    }
+  "funding": {
+    "type": "paypal",
+    "url": "https://paypal.me/mickaelpalma"
+  },
+  "files": [
+    "dist",
+    "homebridge-ui",
+    "config.schema.json"
   ]
 }

package/.claude/settings.json

@@ -1,3 +0,0 @@
-{
-  "coAuthoredBy": false
-}

package/.claude/settings.local.json

@@ -1,24 +0,0 @@
-{
-  "permissions": {
-    "allow": [
-      "Bash(npm test)",
-      "Bash(npm run lint)",
-      "Bash(curl:*)",
-      "Bash(npm run build:*)",
-      "Bash(grep:*)",
-      "Bash(python3:*)",
-      "Bash(npm test:*)",
-      "Bash(timeout 60 npm test -- test/integration/air-conditioning.test.ts --testTimeout=30000)",
-      "Bash(npm install)",
-      "mcp__chrome-devtools__list_pages",
-      "Bash(ls:*)",
-      "Bash(git config:*)",
-      "Bash(FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch:*)",
-      "Bash(git stash:*)",
-      "Bash(git add:*)",
-      "Bash(git commit:*)",
-      "Bash(gh pr view:*)",
-      "Bash(gh pr:*)"
-    ]
-  }
-}

package/CHANGELOG.md

@@ -1,114 +0,0 @@
-# Changelog
-
-All notable changes to this project will be documented in this file.
-
-The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
-and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
-
-## [1.3.6] - 2026-02-21
-
-### Fixed
-
-- **`holidayMode` schema mismatch**: Corrected Zod schema and TypeScript type for `holidayMode` — the Daikin API returns `value` as an object (`{ enabled: boolean, startDate?, endDate? }`) not a string, preventing all devices from loading on startup
-- **Error mutation crash**: Fixed `TypeError: Cannot set property message of [object Object] which has only a getter` in `discoverDevices` by avoiding mutation of the `Error.message` property
-
-### Changed
-
-- Updated Mobile App daily API rate limit from 5000 to 3000 across all documentation, UI labels, and code comments to reflect the current Daikin Cloud limit
-
-## [1.3.5] - 2026-01-10
-
-### Fixed
-
-- **Device Visibility initialization**: Fixed "Token expired or invalid" error in Device Visibility section while Discovered Devices worked correctly. Settings.load() now waits for AuthMode initialization to complete before loading device toggles, ensuring the correct authentication token is used.
-
-## [1.3.4] - 2026-01-10
-
-### Fixed
-
-- **UI error message display**: Device Visibility section now displays specific error messages from the backend instead of generic text. Users can now see helpful messages distinguishing between authentication failures and empty device lists, making troubleshooting easier.
-
-## [1.3.3] - 2026-01-10
-
-### Fixed
-
-- **UI initialization race condition**: Fixed "Token expired or invalid" error on initial UI load. The device list now waits for `AuthMode` initialization to complete before fetching devices. Backend now gracefully falls back to active token if the requested mode's token is unavailable, ensuring device list loads even during initialization.
-
-## [1.3.2] - 2026-01-10
-
-### Fixed
-
-- **UI JavaScript error**: Fixed "Can't find variable: AuthModeManager" error by correcting variable reference to `AuthMode`. This error prevented the device list from loading in the plugin UI.
-
-## [1.3.1] - 2026-01-10
-
-### Fixed
-
-- **UI device list authentication**: Fixed `/devices/list` endpoint to use the token matching the configured `authMode` instead of always prioritizing mobile token. Previously, if both mobile_app and developer_portal tokens existed, the endpoint would always use the mobile token regardless of the configured authMode setting, causing authentication mismatches.
-
-## [1.3.0] - 2026-01-10
-
-### Added
-
-- **Strict TypeScript checking**: Enabled `strict`, `noImplicitAny`, `strictNullChecks`, `strictFunctionTypes`, and `strictPropertyInitialization` for improved type safety
-- **Runtime validation with Zod**: Added comprehensive validation schemas for API responses, WebSocket messages, and configuration
-  - Token set validation
-  - Device data validation
-  - Configuration validation with helpful error messages
-- **Utility modules** for improved reliability:
-  - `retry.ts`: Exponential backoff retry logic with configurable options
-  - `daikin-device-tracker.ts`: Device state tracking with change detection and error history
-- **Comprehensive documentation** in `docs/` folder:
-  - `ARCHITECTURE.md`: System architecture, component design, and extension guides
-  - `IMPLEMENTATION_GUIDE.md`: Step-by-step guide for future improvements
-  - `IMPROVEMENTS_SUMMARY.md`: Executive summary of completed work
-  - `NEXT_STEPS.md`: Quick-start guide for continuing development
-- **Enhanced CLAUDE.md**: Project-specific development guidelines and workflows
-
-### Changed
-
-- Consolidated WebSocket update logic using UpdateMapper (removed 180+ lines of duplication)
-- Updated GitHub Actions workflows from v2/v3 to v4 (removed deprecation warnings)
-- Improved test coverage with strict TypeScript compatibility
-
-### Fixed
-
-- 2 implicit `any` type errors in daikin-cloud.repository.ts
-- Test compatibility issues with strict TypeScript mode
-- UpdateMapper type compatibility issue
-
-### Security
-
-- Verified token file permissions (already secure at mode 0o600)
-- Updated CI/CD dependencies to latest versions
-
-### Documentation
-
-- Moved all architectural and implementation documentation to `docs/` folder
-- Enhanced project documentation for maintainers and contributors
-- Added code examples and usage patterns for utilities
-
-## [1.2.5] - 2026-01-10
-
-### Fixed
-
-- Fix API request format for temperature control to match mobile app format
-- Path parameter now sent in request body instead of URL, resolving 504 Gateway Timeout errors when setting temperature
-
-## [1.2.4] - 2026-01-09
-
-### Fixed
-
-- Handle API gateway timeout errors (502, 503, 504) with automatic retry and exponential backoff
-- Requests now retry up to 3 times before failing, resolving most transient Daikin API issues
-
-## [1.2.3] - 2026-01-09
-
-### Fixed
-
-- Check getData value property instead of result object in service
-- Enable skipped tests and fix test isolation
-
-### Added
-
-- Automatic token refresh with exponential backoff for 401 errors

package/CLAUDE.md

@@ -1,269 +0,0 @@
-# Claude Code Settings
-
-## Project Overview
-
-This is a Homebridge plugin for Daikin Cloud (Onecta) integration that allows controlling Daikin air conditioning units through Apple HomeKit. The plugin supports both Developer Portal and Mobile App authentication methods.
-
-**Key Technologies:**
-- TypeScript (target: ESNext)
-- Homebridge Plugin API
-- HAP-nodejs (HomeKit Accessory Protocol)
-- Jest for testing
-- ESLint for code quality
-
-## Git Settings
-
-- `coAuthoredBy`: false
-
-## Git Commit Convention
-
-Use conventional commits format for all commit messages:
-
-```
-<type>(<scope>): <description>
-
-[optional body]
-
-[optional footer]
-```
-
-### Types
-- `feat`: New feature
-- `fix`: Bug fix
-- `docs`: Documentation changes
-- `style`: Code style changes (formatting, semicolons, etc.)
-- `refactor`: Code refactoring (no functional changes)
-- `test`: Adding or updating tests
-- `chore`: Maintenance tasks, dependencies, build changes
-- `perf`: Performance improvements
-- `ci`: CI/CD changes
-
-### Scopes
-Common scopes used in this project:
-- `api`: Daikin API client, OAuth, WebSocket
-- `service`: Climate control, hot water tank services
-- `accessory`: Air conditioning, Altherma accessories
-- `feature`: Feature modules (modes like powerful, econo, etc.)
-- `device`: Device profiles, capability detection
-- `config`: Configuration management
-- `utils`: Utility functions
-- `build`: Build system and TypeScript configuration
-- `deps`: Dependency updates
-
-### Examples
-- `feat(api): add device capability detection`
-- `fix(service): resolve temperature validation warning`
-- `chore(deps): update dependencies`
-- `refactor(features): extract feature modules from service`
-- `test(utils): add comprehensive StructuredLogger tests`
-
-## Code Style Guidelines
-
-### TypeScript & Code Quality
-
-1. **Indentation**: Use 4 spaces (enforced by ESLint)
-2. **Quotes**: Use single quotes for strings
-3. **Semicolons**: Optional but should be consistent
-4. **Trailing commas**: Required in multiline objects/arrays
-5. **Type safety**:
-   - `strict: true` in tsconfig
-   - `noImplicitAny: false` (be mindful of types)
-   - Prefer explicit types for public APIs
-
-### ESLint Rules
-The project uses `@typescript-eslint` with custom rules:
-- No `console.log` - use Homebridge logger instead
-- Prefer arrow callbacks
-- Always use curly braces
-- Enforce comma spacing
-- No trailing spaces
-
-### File Organization
-
-```
-src/
-├── accessories/          # HAP accessories (air-conditioning, altherma)
-├── api/                  # Daikin API clients (OAuth, WebSocket, repository)
-├── config/               # Configuration management
-├── constants/            # Shared constants (API, auth, device, time)
-├── device/               # Device profiles and capability detection
-├── di/                   # Dependency injection (service container)
-├── features/             # Feature modules (modes as switches)
-├── services/             # HAP services (climate control, hot water)
-├── types/                # TypeScript type definitions
-├── utils/                # Utility functions (logging, error handling)
-├── index.ts             # Plugin entry point
-├── platform.ts          # Main platform class
-└── settings.ts          # Plugin settings
-```
-
-### Test Organization
-
-```
-test/
-├── fixtures/            # Test data (device responses)
-├── mocks/               # Mock objects for testing
-├── helpers/             # Test utilities
-├── unit/                # Unit tests
-│   ├── api/
-│   ├── device/
-│   ├── services/
-│   └── utils/
-└── integration/         # Integration tests
-```
-
-## Development Workflow
-
-### Building and Testing
-
-```bash
-# Install dependencies
-npm install
-
-# Build TypeScript
-npm run build
-
-# Run linter
-npm run lint
-
-# Run tests
-npm test
-
-# Update test snapshots
-npm run test:updateSnapshots
-
-# Development with auto-rebuild
-npm run watch
-```
-
-### Testing Guidelines
-
-1. **Write tests for new features**: All new functionality should include unit tests
-2. **Update snapshots carefully**: Review snapshot changes before committing
-3. **Use fixtures**: Add device response fixtures in `test/fixtures/` for new device types
-4. **Mock external dependencies**: Use mocks from `test/mocks/` for API calls
-5. **Test coverage**: Aim for good coverage, especially for API and service layers
-
-### Common Development Tasks
-
-#### Adding a New Feature Mode
-
-1. Create feature class in `src/features/modes/`
-2. Extend `BaseFeature` class
-3. Register in feature registry
-4. Add configuration option in settings
-5. Add tests in `test/unit/features/`
-6. Update documentation
-
-#### Adding Device Support
-
-1. Add device response fixture in `test/fixtures/`
-2. Update capability detector if needed
-3. Create/update device profile in `src/device/profiles/`
-4. Add integration test
-5. Document in [README.md](README.md)
-
-#### Fixing API Issues
-
-1. Check error handling in `src/utils/error-handler.ts`
-2. Review rate limiting in `src/api/daikin-cloud.repository.ts`
-3. Update retry logic if needed
-4. Add tests for error scenarios
-
-## Homebridge-Specific Considerations
-
-### Platform Plugin Structure
-
-- **Platform**: [platform.ts](src/platform.ts) - Main entry point, manages accessories
-- **Accessories**: [src/accessories/](src/accessories/) - HAP accessory implementations
-- **Services**: [src/services/](src/services/) - HAP service wrappers
-
-### HAP Service Types Used
-
-- `HeaterCooler`: Main climate control
-- `TemperatureSensor`: Room temperature
-- `Switch`: Feature modes (powerful, econo, etc.)
-- `Thermostat`: Altherma heating (optional)
-
-### Configuration Schema
-
-Configuration is managed via Homebridge UI:
-- `homebridge-ui/` directory contains custom UI
-- Config schema defined in `package.json`
-- Validation in [src/config/config-manager.ts](src/config/config-manager.ts)
-
-## API Integration Notes
-
-### Authentication Methods
-
-1. **Developer Portal** (OAuth 2.0):
-   - Client ID/Secret from Daikin Developer Portal
-   - 200 API calls/day limit
-   - Callback server for OAuth flow
-
-2. **Mobile App** (Gigya):
-   - Email/password authentication
-   - 3000 API calls/day limit
-   - WebSocket support for real-time updates
-
-### Rate Limiting
-
-- Implemented in [daikin-cloud.repository.ts](src/api/daikin-cloud.repository.ts)
-- Exponential backoff for retries
-- Gateway timeout handling (502, 503, 504)
-
-### WebSocket Support
-
-- Only available in Mobile App mode
-- Real-time device state updates
-- Implemented in [daikin-websocket.ts](src/api/daikin-websocket.ts)
-
-## Debugging Tips
-
-### Enable Debug Logging
-
-Set Homebridge debug mode:
-```bash
-homebridge -D
-```
-
-### Common Issues
-
-1. **Token expired**: Delete `~/.homebridge/.daikin-controller-cloud-tokenset`
-2. **Device not found**: Check `excludedDevicesByDeviceId` in config
-3. **WebSocket connection fails**: Verify Mobile App credentials
-4. **Rate limit hit**: Increase `updateIntervalInMinutes`
-
-### Useful Log Contexts
-
-The codebase uses structured logging:
-- Check [log-context.ts](src/utils/log-context.ts) for log formatting
-- Error handling in [error-handler.ts](src/utils/error-handler.ts)
-
-## Release Process
-
-1. Update version in [package.json](package.json)
-2. Update [README.md](README.md) if needed
-3. Run tests: `npm test`
-4. Build: `npm run build`
-5. Commit with version bump: `chore: bump version to X.Y.Z`
-6. Tag release: `git tag vX.Y.Z`
-7. Push: `git push && git push --tags`
-8. Publish: `npm run release` (or `npm run release:beta`)
-
-## Important Constraints
-
-### Do NOT
-- Use `console.log` - always use Homebridge logger
-- Commit without running tests and linter
-- Add dependencies without considering bundle size
-- Break backward compatibility without major version bump
-- Hardcode sensitive data (credentials, tokens)
-
-### DO
-- Follow the established directory structure
-- Add tests for new features
-- Update documentation
-- Use dependency injection via service container
-- Handle errors gracefully with user-friendly messages
-- Consider API rate limits in all API calls

package/config.md

@@ -1,2 +0,0 @@
-
-