@mouse_484/oxc-config 0.8.9 → 0.8.10

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@mouse_484/oxc-config",
   "type": "module",
-  "version": "0.8.9",
+  "version": "0.8.10",
   "author": "mouse_484",
   "license": "MIT",
   "homepage": "https://github.com/mouse484/config/tree/main/packages/oxc",
@@ -15,12 +15,13 @@
   "main": "src/index.js",
   "types": "src/index.d.ts",
   "scripts": {
+    "test": "node --test",
     "typegen": "node scripts/typegen.js"
   },
   "dependencies": {
     "eslint-plugin-antfu": "^3.3.1",
     "eslint-plugin-perfectionist": "^5.13.0",
-    "local-pkg": "^1.2.1",
+    "exsolve": "^1.0.7",
     "oxfmt": "^0.75.0",
     "oxlint": "^1.90.0",
     "oxlint-tsgolint": "^7.0.2005"

package/src/configs/index.js

@@ -1,4 +1,4 @@
-import { isPackageExists } from 'local-pkg'
+import { createPackageDetector } from '../lib/packages.js'
 import eslint from './eslint.js'
 import importConfig from './import.js'
 import javascript from './javascript.js'
@@ -30,7 +30,7 @@ const CONFIGS = /** @type {const} */[
 @returns {import("oxlint").OxlintConfig[]} Generated configs for the enabled options
  */
 export default function buildConfigs(options) {
-  const context = { isPackageExists, options }
+  const context = { isPackageExists: createPackageDetector(), options }
   return CONFIGS.flatMap(({ name, build, enable = true }) => {
     const option = options[name]
     if (option === false) {

package/src/configs/opinionated.js

@@ -11,7 +11,6 @@ export default createConfigs({
       }],
       rules: {
         'antfu/top-level-function': 'error',
-        'antfu/consistent-chaining': 'error',
         'antfu/import-dedupe': 'error',
         'antfu/indent-unindent': ['error', { indent: 2 }],
         'antfu/no-ts-export-equal': 'error',

package/src/lib/packages.js

@@ -0,0 +1,22 @@
+import { createResolver } from 'exsolve'
+
+/**
+ * Create a package detector rooted in the consuming project.
+ * @param {string} [cwd] Project directory
+ * @returns {(name: string) => boolean} Package detector
+ */
+export function createPackageDetector(cwd) {
+  const { resolveModulePath } = createResolver({
+    from: cwd,
+    cache: false,
+    conditions: ['node', 'import', 'types'],
+  })
+
+  return (name) => {
+    // Check the manifest first to support packages containing only types.
+    return Boolean(
+      resolveModulePath(`${name}/package.json`, { try: true })
+      || resolveModulePath(name, { try: true }),
+    )
+  }
+}

package/src/lib/packages.test.js

@@ -0,0 +1,59 @@
+import assert from 'node:assert/strict'
+import { mkdirSync, mkdtempSync, rmSync, symlinkSync, writeFileSync } from 'node:fs'
+import { tmpdir } from 'node:os'
+import path from 'node:path'
+// eslint-disable-next-line test/no-import-node-test -- This package uses the built-in test runner.
+import { test } from 'node:test'
+import { createPackageDetector } from './packages.js'
+
+void test('detects packages from the consumer, including import-only and types-only packages', (context) => {
+  const root = mkdtempSync(path.join(tmpdir(), 'oxc-package-detection-'))
+  context.after(() => rmSync(root, { recursive: true, force: true }))
+
+  const project = path.join(root, 'project')
+  mkdirSync(project)
+  const fixtures = {
+    'import-only': { exports: { import: './index.js' }, type: 'module' },
+    'hidden-manifest': { exports: './index.js', type: 'module' },
+    'types-only-export': { exports: { '.': { types: './index.d.ts' } } },
+    '@types/example': { types: './index.d.ts' },
+    'conditional': { exports: { import: './index.js', require: './missing.cjs' }, type: 'module' },
+  }
+  for (const [name, manifest] of Object.entries(fixtures)) {
+    const directory = path.join(root, 'node_modules', name)
+    mkdirSync(directory, { recursive: true })
+    writeFileSync(path.join(directory, 'package.json'), JSON.stringify({ name, ...manifest }))
+    if (!('types' in manifest)) {
+      writeFileSync(path.join(directory, 'index.js'), 'export {}\n')
+    }
+    writeFileSync(path.join(directory, 'index.d.ts'), 'export {}\n')
+  }
+
+  const detect = createPackageDetector(project)
+  for (const name of Object.keys(fixtures)) {
+    assert.equal(detect(name), true, name)
+  }
+  assert.equal(detect('missing-package'), false)
+  // Packages installed beside the config must not enable consumer presets.
+  assert.equal(detect('eslint-plugin-antfu'), false)
+
+  symlinkSync(path.join(root, 'node_modules/import-only'), path.join(root, 'node_modules/linked-package'), 'junction')
+  assert.equal(detect('linked-package'), true)
+
+  const broken = path.join(root, 'node_modules/broken-export')
+  mkdirSync(broken)
+  writeFileSync(path.join(broken, 'package.json'), JSON.stringify({ exports: './missing.js' }))
+  assert.equal(detect('broken-export'), false)
+})
+
+void test('a new detector observes the current project and newly installed packages', (context) => {
+  const root = mkdtempSync(path.join(tmpdir(), 'oxc-package-detection-'))
+  context.after(() => rmSync(root, { recursive: true, force: true }))
+  const detect = createPackageDetector(root)
+  assert.equal(detect('react'), false)
+
+  const directory = path.join(root, 'node_modules/react')
+  mkdirSync(directory, { recursive: true })
+  writeFileSync(path.join(directory, 'package.json'), JSON.stringify({ name: 'react' }))
+  assert.equal(createPackageDetector(root)('react'), true)
+})