@morriconeluca/eslint-plugin-faf 0.2.0 → 0.4.0

package/dist/main.js

@@ -1,7 +1,7 @@
 // package.json
 var package_default = {
   name: "@morriconeluca/eslint-plugin-faf",
-  version: "0.2.0",
+  version: "0.4.0",
   description: "An ESLint plugin for FAF projects.",
   repository: {
     type: "git",
@@ -442,6 +442,17 @@ function getProjectRoot() {
 
 // src/_rules/naming-conventions/naming-conventions.rule.ts
 var KEBAB_CASE_REGEX = /^[a-z0-9]+(-[a-z0-9]+)*$/;
+var DEFAULT_HTTP_METHODS = [
+  "connect",
+  "delete",
+  "get",
+  "head",
+  "options",
+  "patch",
+  "post",
+  "put",
+  "trace"
+];
 var rule3 = {
   create(context) {
     return {
@@ -605,15 +616,6 @@ var rule3 = {
         if (parentType === "invalid-fragment") {
           return;
         }
-        if (fileName === "index.ts" || fileName === "index.js") {
-          if (parentType !== "fragment") {
-            context.report({
-              message: `Access Nodes ("index.ts/index.js") are exclusive to Fragments. Found index file directly inside "${folderName}" (classified as ${parentType}).`,
-              node
-            });
-          }
-          return;
-        }
         const rfConfig = getRootFragmentConfig(relDir, config);
         if (rfConfig) {
           const flatRootNodes = rfConfig.rootNodes.flat();
@@ -629,11 +631,34 @@ var rule3 = {
             return;
           }
         }
+        if (fileName === "index.ts" || fileName === "index.js") {
+          if (parentType !== "fragment") {
+            context.report({
+              message: `Access Nodes ("index.ts/index.js") are exclusive to Fragments. Found index file directly inside "${folderName}" (classified as ${parentType}).`,
+              node
+            });
+          } else {
+            const contents = readDirCached(relDir);
+            const hasFragmentNode = contents.files.some(
+              (f) => f !== "index.ts" && f !== "index.js" && f !== "README.md" && f !== "package.json" && f !== "tsconfig.json"
+            );
+            if (!hasFragmentNode) {
+              context.report({
+                message: `Fragment "${folderName}" has no Master Node. Every Fragment must contain at least one Fragment Node establishing its Role.`,
+                node
+              });
+            }
+          }
+          return;
+        }
         if (fileName === "README.md" || fileName === "package.json" || fileName === "tsconfig.json") {
           return;
         }
         const role = getFileRole(fileName, config);
         const ext = path7.extname(fileName);
+        const allRoleNames = new Set(config.roles.flat());
+        const roleSegments = fileName.slice(0, fileName.length - ext.length).split(".").slice(1).filter((part) => allRoleNames.has(part));
+        const multiRoleMessage = `File "${fileName}" composes multiple Roles ("${roleSegments.join('", "')}") in its name. A Logical Node may declare only one Role; promote the detail that needs its own Role to an autonomous Sub-Fragment.`;
         if (parentType === "fragment") {
           const matchedRoute = config.routeHierarchies?.find(
             (rh) => rh.paths.some((rp) => relDir === rp || relDir.startsWith(rp + "/"))
@@ -647,6 +672,16 @@ var rule3 = {
                 node
               });
             }
+            const httpMethods = matchedRoute.httpMethods ?? DEFAULT_HTTP_METHODS;
+            const routeNameRegex = new RegExp(
+              `^(${httpMethods.join("|")})-[a-z0-9]+(-[a-z0-9]+)*$`
+            );
+            if (!routeNameRegex.test(folderName)) {
+              context.report({
+                message: `Route terminal Fragment "${folderName}" must follow the "<method>-<object>" pattern with a lowercase HTTP method (${httpMethods.join(", ")}).`,
+                node
+              });
+            }
           }
           let currentParent = path7.dirname(relDir).replace(/\\/g, "/");
           let categoryConfig = null;
@@ -685,6 +720,19 @@ var rule3 = {
               message: `File "${fileName}" inside Fragment "${folderName}" must have an explicit role suffix (e.g. "${folderName}.style${ext}").`,
               node
             });
+          } else if (roleSegments.length > 1) {
+            context.report({ message: multiRoleMessage, node });
+          } else {
+            const contents = readDirCached(relDir);
+            const duplicate = contents.files.find(
+              (f) => f !== fileName && f !== "index.ts" && f !== "index.js" && getFileRole(f, config) === role
+            );
+            if (duplicate) {
+              context.report({
+                message: `Fragment Node "${fileName}" shares Role "${role}" with sibling "${duplicate}". Each Fragment Node must have a unique Role within its Fragment.`,
+                node
+              });
+            }
           }
         }
         if (parentType === "category") {
@@ -715,6 +763,8 @@ var rule3 = {
                   message: `Role "${role}" for file "${fileName}" does not match the expected Category role "${catConfig.role}".`,
                   node
                 });
+              } else if (roleSegments.length > 1) {
+                context.report({ message: multiRoleMessage, node });
               }
             } else {
               if (role && role !== catConfig.role) {
@@ -722,6 +772,8 @@ var rule3 = {
                   message: `Role "${role}" for asset "${fileName}" does not match the expected Category role "${catConfig.role}".`,
                   node
                 });
+              } else if (role && roleSegments.length > 1) {
+                context.report({ message: multiRoleMessage, node });
               }
             }
           }
@@ -791,6 +843,16 @@ function _resolveImportPath(importPath, currentFileRelative, settings) {
   }
   return finalizeResolvedPath(relResolved);
 }
+var SCRIPT_EXTENSIONS = /* @__PURE__ */ new Set([
+  "cjs",
+  "cts",
+  "js",
+  "jsx",
+  "mjs",
+  "mts",
+  "ts",
+  "tsx"
+]);
 function finalizeResolvedPath(relResolved) {
   const resolvedDir = path8.dirname(relResolved).replace(/\\/g, "/");
   const resolvedBase = path8.basename(relResolved);
@@ -804,9 +866,12 @@ function finalizeResolvedPath(relResolved) {
   const parentContents = readDirCached(resolvedDir);
   const exactMatch = parentContents.files.find((f) => f === resolvedBase);
   if (!exactMatch) {
-    const matchWithExt = parentContents.files.find(
+    const candidates = parentContents.files.filter(
       (f) => f.startsWith(resolvedBase + ".")
     );
+    const matchWithExt = candidates.find(
+      (f) => SCRIPT_EXTENSIONS.has(f.slice(resolvedBase.length + 1))
+    ) ?? candidates[0];
     if (matchWithExt) {
       return (resolvedDir === "." ? "" : resolvedDir + "/") + matchWithExt;
     }
@@ -875,7 +940,7 @@ var rule4 = {
       if (importedFolderType === "fragment") {
         const isAccessNode = importedFile === "index.ts" || importedFile === "index.js";
         if (!isAccessNode) {
-          const isInside = relPath === importedDir || relPath.startsWith(importedDir + "/");
+          const isInside = path9.dirname(relPath) === importedDir;
           if (!isInside) {
             context.report({
               message: `Direct import of Fragment internal file "${importedFile}" is forbidden. You must import through its Access Node (index file) in "${importedDir}".`,
@@ -982,19 +1047,19 @@ var rule5 = {
         return;
       }
       const importedDir = path12.dirname(resolvedRelPath);
-      const owner = getFractalBranchOwner(importedDir);
-      if (owner) {
-        const isDescendant = relPath === owner || relPath.startsWith(owner + "/");
+      const fractalBranchOwner = getFractalBranchOwner(importedDir);
+      if (fractalBranchOwner) {
+        const isDescendant = relPath === fractalBranchOwner || relPath.startsWith(fractalBranchOwner + "/");
         if (!isDescendant) {
           context.report({
-            message: `Importing from Fractal Branch is forbidden. The imported resource is private to "${owner}" and its descendants.`,
+            message: `Importing from Fractal Branch is forbidden. The imported resource is private to "${fractalBranchOwner}" and its descendants.`,
             node
           });
         } else {
           const info = getPrivateCategoryInfo(importedDir, config);
           if (info) {
-            const { owner: owner2, privateCategoryPath } = info;
-            const isPrivateDirectChild = path12.dirname(relPath) === owner2;
+            const { owner, privateCategoryPath } = info;
+            const isPrivateDirectChild = path12.dirname(relPath) === owner;
             const importerSubDomain = getImmediateSubDomain(
               relPath,
               privateCategoryPath
@@ -1004,17 +1069,10 @@ var rule5 = {
               privateCategoryPath
             );
             const isInsideSameSubDomain = importerSubDomain !== "" && importerSubDomain === importedSubDomain;
-            let isFractalBranchAllowed = false;
-            const fbOwner = getFractalBranchOwner(importedDir);
-            if (fbOwner) {
-              const isFbInsidePrivateCategory = fbOwner === privateCategoryPath || fbOwner.startsWith(privateCategoryPath + "/");
-              if (isFbInsidePrivateCategory) {
-                isFractalBranchAllowed = relPath === fbOwner || relPath.startsWith(fbOwner + "/");
-              }
-            }
+            const isFractalBranchAllowed = fractalBranchOwner === privateCategoryPath || fractalBranchOwner.startsWith(privateCategoryPath + "/");
             if (!isPrivateDirectChild && !isInsideSameSubDomain && !isFractalBranchAllowed) {
               context.report({
-                message: `Importing from Private Category is forbidden. The imported resource is private to "${owner2}".`,
+                message: `Importing from Private Category is forbidden. The imported resource is private to "${owner}".`,
                 node
               });
             }
@@ -1124,24 +1182,6 @@ function resolveHorizontalHierarchy(lcaPath, subA, subB, config) {
 }
 
 // src/_rules/no-peer-dependency/no-peer-dependency.rule.ts
-function getDirectoryRole(dirPath, config) {
-  const folderName = path13.basename(dirPath);
-  if (folderName.startsWith("_")) {
-    return getRoleFromFolderName(folderName, config);
-  }
-  const contents = readDirCached(dirPath);
-  for (const file of contents.files) {
-    if (file.startsWith(folderName + ".")) {
-      const role = getFileRole(file, config);
-      if (role) return role;
-    }
-  }
-  return null;
-}
-function getRoleFromFolderName(name, config) {
-  const catConfig = config.categories?.find((c) => c.name === name);
-  return catConfig ? catConfig.role ?? null : null;
-}
 function getRootNodeIndex(relPath, rfConfig, lcaPath) {
   const relToLca = path13.relative(lcaPath, relPath).replace(/\\/g, "/");
   for (let i = 0; i < rfConfig.rootNodes.length; i++) {
@@ -1245,6 +1285,10 @@ var rule6 = {
         return;
       }
       if (subB === "" && classifyFolder(lca, config) === "fragment") {
+        context.report({
+          message: `Peer separation violation: "${subA}" cannot import directly from the root of Fragment "${lca}". A node nested inside a Private Category or Fractal Branch has no privileged access to its owning Fragment's other direct children; promote the shared resource to a Fractal Branch if the sharing need is genuine.`,
+          node
+        });
         return;
       }
       const rfConfig = getRootFragmentConfig(lca, config);
@@ -1261,6 +1305,15 @@ var rule6 = {
           return;
         }
       }
+      const isSubARootFragment = classifyFolder(path13.posix.join(lca, subA), config) === "root-fragment";
+      const isSubBRootFragment = classifyFolder(path13.posix.join(lca, subB), config) === "root-fragment";
+      if (isSubARootFragment || isSubBRootFragment) {
+        context.report({
+          message: `Root Node import violation: "${relPath}" cannot import from "${resolvedRelPath}" because no "rootNodes" relationship is configured under Root Fragment "${lca}". Relationships between Root Nodes must always be explicitly authorized by the architect.`,
+          node
+        });
+        return;
+      }
       const { allowed, defined: hasDefinedHierarchy } = resolveHorizontalHierarchy(lca, subA, subB, config);
       if (hasDefinedHierarchy) {
         if (!allowed) {
@@ -1270,23 +1323,10 @@ var rule6 = {
           });
         }
       } else {
-        const roleA = getDirectoryRole(path13.posix.join(lca, subA), config);
-        const roleB = getDirectoryRole(path13.posix.join(lca, subB), config);
-        const idxA = roleA ? getRoleHierarchyIndex(roleA, config) : -1;
-        const idxB = roleB ? getRoleHierarchyIndex(roleB, config) : -1;
-        if (idxA !== -1 && idxB !== -1) {
-          if (idxB >= idxA) {
-            context.report({
-              message: `Horizontal hierarchy violation (fallback to roles): sibling directory "${subA}" (mapped to role "${roleA}", level ${idxA}) cannot import from "${subB}" (mapped to role "${roleB}", level ${idxB}) under parent "${lca}".`,
-              node
-            });
-          }
-        } else {
-          context.report({
-            message: `Peer separation violation: sibling directories "${subA}" and "${subB}" cannot import each other because no horizontal hierarchy is defined under parent "${lca}".`,
-            node
-          });
-        }
+        context.report({
+          message: `Peer separation violation: sibling directories "${subA}" and "${subB}" cannot import each other because no horizontal hierarchy is defined under parent "${lca}".`,
+          node
+        });
       }
     }
     return {
@@ -1340,6 +1380,16 @@ var rule7 = {
       const info = getPrivateCategoryInfo(importedDir, config);
       if (info) {
         const { owner, privateCategoryPath } = info;
+        let isFractalBranchInPrivateCategory = false;
+        let isFractalBranchAllowed = false;
+        const fbOwner = getFractalBranchOwner(importedDir);
+        if (fbOwner) {
+          const isFbInsidePrivateCategory = fbOwner === privateCategoryPath || fbOwner.startsWith(privateCategoryPath + "/");
+          if (isFbInsidePrivateCategory) {
+            isFractalBranchInPrivateCategory = true;
+            isFractalBranchAllowed = relPath === fbOwner || relPath.startsWith(fbOwner + "/");
+          }
+        }
         const isDirectChild = path14.dirname(relPath) === owner;
         const importerSubDomain = getImmediateSubDomain(
           relPath,
@@ -1350,15 +1400,8 @@ var rule7 = {
           privateCategoryPath
         );
         const isInsideSameSubDomain = importerSubDomain !== "" && importerSubDomain === importedSubDomain;
-        let isFractalBranchAllowed = false;
-        const fbOwner = getFractalBranchOwner(importedDir);
-        if (fbOwner) {
-          const isFbInsidePrivateCategory = fbOwner === privateCategoryPath || fbOwner.startsWith(privateCategoryPath + "/");
-          if (isFbInsidePrivateCategory) {
-            isFractalBranchAllowed = relPath === fbOwner || relPath.startsWith(fbOwner + "/");
-          }
-        }
-        if (!isDirectChild && !isInsideSameSubDomain && !isFractalBranchAllowed) {
+        const isAllowed = isFractalBranchInPrivateCategory ? isFractalBranchAllowed : isDirectChild || isInsideSameSubDomain;
+        if (!isAllowed) {
           context.report({
             message: `Importing from Private Category is forbidden. The imported resource is private to "${owner}".`,
             node