@morriconeluca/eslint-plugin-faf 0.1.1 → 0.3.0

package/dist/main.js

@@ -1,8 +1,12 @@
 // package.json
 var package_default = {
   name: "@morriconeluca/eslint-plugin-faf",
-  version: "0.1.1",
+  version: "0.3.0",
   description: "An ESLint plugin for FAF projects.",
+  repository: {
+    type: "git",
+    url: "git+https://github.com/morriconeluca/eslint-plugin-faf.git"
+  },
   main: "./dist/main.cjs",
   module: "./dist/main.js",
   types: "./dist/main.d.ts",
@@ -14,7 +18,8 @@ var package_default = {
     }
   },
   publishConfig: {
-    access: "public"
+    access: "public",
+    provenance: true
   },
   imports: {
     "#_rules@shared/*": "./src/_rules/_rules@shared/*",
@@ -315,6 +320,9 @@ var rule = {
           if (catConfig) {
             const ext = path5.extname(fileName);
             const isAllowedAsset = catConfig.allowedExtensions?.includes(ext) ?? false;
+            if (!isAllowedAsset && catConfig.allowedExtensions && catConfig.allowedExtensions.length > 0) {
+              return;
+            }
             if (!catConfig.allowSingleFiles && !isAllowedAsset) {
               context.report({
                 message: `Category "${folderName}" cannot contain file nodes directly. File "${fileName}" must be encapsulated inside a Fragment.`,
@@ -434,6 +442,17 @@ function getProjectRoot() {
 
 // src/_rules/naming-conventions/naming-conventions.rule.ts
 var KEBAB_CASE_REGEX = /^[a-z0-9]+(-[a-z0-9]+)*$/;
+var DEFAULT_HTTP_METHODS = [
+  "connect",
+  "delete",
+  "get",
+  "head",
+  "options",
+  "patch",
+  "post",
+  "put",
+  "trace"
+];
 var rule3 = {
   create(context) {
     return {
@@ -597,15 +616,6 @@ var rule3 = {
         if (parentType === "invalid-fragment") {
           return;
         }
-        if (fileName === "index.ts" || fileName === "index.js") {
-          if (parentType !== "fragment") {
-            context.report({
-              message: `Access Nodes ("index.ts/index.js") are exclusive to Fragments. Found index file directly inside "${folderName}" (classified as ${parentType}).`,
-              node
-            });
-          }
-          return;
-        }
         const rfConfig = getRootFragmentConfig(relDir, config);
         if (rfConfig) {
           const flatRootNodes = rfConfig.rootNodes.flat();
@@ -621,11 +631,34 @@ var rule3 = {
             return;
           }
         }
+        if (fileName === "index.ts" || fileName === "index.js") {
+          if (parentType !== "fragment") {
+            context.report({
+              message: `Access Nodes ("index.ts/index.js") are exclusive to Fragments. Found index file directly inside "${folderName}" (classified as ${parentType}).`,
+              node
+            });
+          } else {
+            const contents = readDirCached(relDir);
+            const hasFragmentNode = contents.files.some(
+              (f) => f !== "index.ts" && f !== "index.js" && f !== "README.md" && f !== "package.json" && f !== "tsconfig.json"
+            );
+            if (!hasFragmentNode) {
+              context.report({
+                message: `Fragment "${folderName}" has no Master Node. Every Fragment must contain at least one Fragment Node establishing its Role.`,
+                node
+              });
+            }
+          }
+          return;
+        }
         if (fileName === "README.md" || fileName === "package.json" || fileName === "tsconfig.json") {
           return;
         }
         const role = getFileRole(fileName, config);
         const ext = path7.extname(fileName);
+        const allRoleNames = new Set(config.roles.flat());
+        const roleSegments = fileName.slice(0, fileName.length - ext.length).split(".").slice(1).filter((part) => allRoleNames.has(part));
+        const multiRoleMessage = `File "${fileName}" composes multiple Roles ("${roleSegments.join('", "')}") in its name. A Logical Node may declare only one Role; promote the detail that needs its own Role to an autonomous Sub-Fragment.`;
         if (parentType === "fragment") {
           const matchedRoute = config.routeHierarchies?.find(
             (rh) => rh.paths.some((rp) => relDir === rp || relDir.startsWith(rp + "/"))
@@ -639,6 +672,16 @@ var rule3 = {
                 node
               });
             }
+            const httpMethods = matchedRoute.httpMethods ?? DEFAULT_HTTP_METHODS;
+            const routeNameRegex = new RegExp(
+              `^(${httpMethods.join("|")})-[a-z0-9]+(-[a-z0-9]+)*$`
+            );
+            if (!routeNameRegex.test(folderName)) {
+              context.report({
+                message: `Route terminal Fragment "${folderName}" must follow the "<method>-<object>" pattern with a lowercase HTTP method (${httpMethods.join(", ")}).`,
+                node
+              });
+            }
           }
           let currentParent = path7.dirname(relDir).replace(/\\/g, "/");
           let categoryConfig = null;
@@ -677,6 +720,19 @@ var rule3 = {
               message: `File "${fileName}" inside Fragment "${folderName}" must have an explicit role suffix (e.g. "${folderName}.style${ext}").`,
               node
             });
+          } else if (roleSegments.length > 1) {
+            context.report({ message: multiRoleMessage, node });
+          } else {
+            const contents = readDirCached(relDir);
+            const duplicate = contents.files.find(
+              (f) => f !== fileName && f !== "index.ts" && f !== "index.js" && getFileRole(f, config) === role
+            );
+            if (duplicate) {
+              context.report({
+                message: `Fragment Node "${fileName}" shares Role "${role}" with sibling "${duplicate}". Each Fragment Node must have a unique Role within its Fragment.`,
+                node
+              });
+            }
           }
         }
         if (parentType === "category") {
@@ -707,6 +763,8 @@ var rule3 = {
                   message: `Role "${role}" for file "${fileName}" does not match the expected Category role "${catConfig.role}".`,
                   node
                 });
+              } else if (roleSegments.length > 1) {
+                context.report({ message: multiRoleMessage, node });
               }
             } else {
               if (role && role !== catConfig.role) {
@@ -714,6 +772,8 @@ var rule3 = {
                   message: `Role "${role}" for asset "${fileName}" does not match the expected Category role "${catConfig.role}".`,
                   node
                 });
+              } else if (role && roleSegments.length > 1) {
+                context.report({ message: multiRoleMessage, node });
               }
             }
           }
@@ -783,6 +843,16 @@ function _resolveImportPath(importPath, currentFileRelative, settings) {
   }
   return finalizeResolvedPath(relResolved);
 }
+var SCRIPT_EXTENSIONS = /* @__PURE__ */ new Set([
+  "cjs",
+  "cts",
+  "js",
+  "jsx",
+  "mjs",
+  "mts",
+  "ts",
+  "tsx"
+]);
 function finalizeResolvedPath(relResolved) {
   const resolvedDir = path8.dirname(relResolved).replace(/\\/g, "/");
   const resolvedBase = path8.basename(relResolved);
@@ -796,9 +866,12 @@ function finalizeResolvedPath(relResolved) {
   const parentContents = readDirCached(resolvedDir);
   const exactMatch = parentContents.files.find((f) => f === resolvedBase);
   if (!exactMatch) {
-    const matchWithExt = parentContents.files.find(
+    const candidates = parentContents.files.filter(
       (f) => f.startsWith(resolvedBase + ".")
     );
+    const matchWithExt = candidates.find(
+      (f) => SCRIPT_EXTENSIONS.has(f.slice(resolvedBase.length + 1))
+    ) ?? candidates[0];
     if (matchWithExt) {
       return (resolvedDir === "." ? "" : resolvedDir + "/") + matchWithExt;
     }
@@ -867,7 +940,7 @@ var rule4 = {
       if (importedFolderType === "fragment") {
         const isAccessNode = importedFile === "index.ts" || importedFile === "index.js";
         if (!isAccessNode) {
-          const isInside = relPath === importedDir || relPath.startsWith(importedDir + "/");
+          const isInside = path9.dirname(relPath) === importedDir;
           if (!isInside) {
             context.report({
               message: `Direct import of Fragment internal file "${importedFile}" is forbidden. You must import through its Access Node (index file) in "${importedDir}".`,
@@ -902,43 +975,56 @@ var rule4 = {
 var no_direct_fragment_import_rule_default = rule4;
 
 // src/_rules/no-fractal-branch-leak/no-fractal-branch-leak.rule.ts
-import path11 from "path";
+import path12 from "path";
 
-// src/_rules/_rules@shared/_utils/_systems/get-private-category-owner/get-private-category-owner.util.ts
+// src/_rules/_rules@shared/_utils/_primitives/get-fractal-branch-owner/get-fractal-branch-owner.util.ts
 import path10 from "path";
-function getPrivateCategoryOwner(relPath, config) {
+function getFractalBranchOwner(relPath) {
   let current = relPath;
   while (current && current !== "." && current !== "/") {
+    const folderName = path10.basename(current);
+    if (folderName.startsWith("_") && folderName.includes("@shared")) {
+      return path10.dirname(current).replace(/\\/g, "/");
+    }
     const parent = path10.dirname(current).replace(/\\/g, "/");
     if (parent === current) {
       break;
     }
-    const currentType = classifyFolder(current, config);
-    const parentType = classifyFolder(parent, config);
-    if (currentType === "category" && (parentType === "fragment" || parentType === "root-fragment")) {
-      return parent;
-    }
     current = parent;
   }
   return null;
 }
 
-// src/_rules/no-fractal-branch-leak/no-fractal-branch-leak.rule.ts
-function getFractalBranchOwner(relPath) {
+// src/_rules/_rules@shared/_utils/_primitives/get-immediate-sub-domain/get-immediate-sub-domain.util.ts
+function getImmediateSubDomain(relPath, privateCategoryPath) {
+  if (relPath !== privateCategoryPath && !relPath.startsWith(privateCategoryPath + "/")) {
+    return "";
+  }
+  const relative = relPath.substring(privateCategoryPath.length + 1);
+  const firstSegment = relative.split("/")[0];
+  return firstSegment ? privateCategoryPath + "/" + firstSegment : privateCategoryPath;
+}
+
+// src/_rules/_rules@shared/_utils/_systems/get-private-category-info/get-private-category-info.util.ts
+import path11 from "path";
+function getPrivateCategoryInfo(relPath, config) {
   let current = relPath;
   while (current && current !== "." && current !== "/") {
-    const folderName = path11.basename(current);
-    if (folderName.startsWith("_") && folderName.includes("@shared")) {
-      return path11.dirname(current).replace(/\\/g, "/");
-    }
     const parent = path11.dirname(current).replace(/\\/g, "/");
     if (parent === current) {
       break;
     }
+    const currentType = classifyFolder(current, config);
+    const parentType = classifyFolder(parent, config);
+    if (currentType === "category" && (parentType === "fragment" || parentType === "root-fragment")) {
+      return { owner: parent, privateCategoryPath: current };
+    }
     current = parent;
   }
   return null;
 }
+
+// src/_rules/no-fractal-branch-leak/no-fractal-branch-leak.rule.ts
 var rule5 = {
   create(context) {
     const absPath = context.filename;
@@ -960,22 +1046,33 @@ var rule5 = {
       if (!resolvedRelPath) {
         return;
       }
-      const importedDir = path11.dirname(resolvedRelPath);
-      const owner = getFractalBranchOwner(importedDir);
-      if (owner) {
-        const isDescendant = relPath === owner || relPath.startsWith(owner + "/");
+      const importedDir = path12.dirname(resolvedRelPath);
+      const fractalBranchOwner = getFractalBranchOwner(importedDir);
+      if (fractalBranchOwner) {
+        const isDescendant = relPath === fractalBranchOwner || relPath.startsWith(fractalBranchOwner + "/");
         if (!isDescendant) {
           context.report({
-            message: `Importing from Fractal Branch is forbidden. The imported resource is private to "${owner}" and its descendants.`,
+            message: `Importing from Fractal Branch is forbidden. The imported resource is private to "${fractalBranchOwner}" and its descendants.`,
             node
           });
         } else {
-          const privateOwner = getPrivateCategoryOwner(importedDir, config);
-          if (privateOwner) {
-            const isPrivateDescendant = relPath === privateOwner || relPath.startsWith(privateOwner + "/");
-            if (!isPrivateDescendant) {
+          const info = getPrivateCategoryInfo(importedDir, config);
+          if (info) {
+            const { owner, privateCategoryPath } = info;
+            const isPrivateDirectChild = path12.dirname(relPath) === owner;
+            const importerSubDomain = getImmediateSubDomain(
+              relPath,
+              privateCategoryPath
+            );
+            const importedSubDomain = getImmediateSubDomain(
+              resolvedRelPath,
+              privateCategoryPath
+            );
+            const isInsideSameSubDomain = importerSubDomain !== "" && importerSubDomain === importedSubDomain;
+            const isFractalBranchAllowed = fractalBranchOwner === privateCategoryPath || fractalBranchOwner.startsWith(privateCategoryPath + "/");
+            if (!isPrivateDirectChild && !isInsideSameSubDomain && !isFractalBranchAllowed) {
               context.report({
-                message: `Importing from Private Category is forbidden. The imported resource is private to "${privateOwner}".`,
+                message: `Importing from Private Category is forbidden. The imported resource is private to "${owner}".`,
                 node
               });
             }
@@ -1008,7 +1105,7 @@ var rule5 = {
 var no_fractal_branch_leak_rule_default = rule5;
 
 // src/_rules/no-peer-dependency/no-peer-dependency.rule.ts
-import path12 from "path";
+import path13 from "path";
 
 // src/_rules/_rules@shared/_utils/_primitives/find-tree-config-including-excluded/find-tree-config-including-excluded.util.ts
 function findTreeConfigIncludingExcluded(relPath, settings) {
@@ -1086,7 +1183,7 @@ function resolveHorizontalHierarchy(lcaPath, subA, subB, config) {
 
 // src/_rules/no-peer-dependency/no-peer-dependency.rule.ts
 function getDirectoryRole(dirPath, config) {
-  const folderName = path12.basename(dirPath);
+  const folderName = path13.basename(dirPath);
   if (folderName.startsWith("_")) {
     return getRoleFromFolderName(folderName, config);
   }
@@ -1104,7 +1201,7 @@ function getRoleFromFolderName(name, config) {
   return catConfig ? catConfig.role ?? null : null;
 }
 function getRootNodeIndex(relPath, rfConfig, lcaPath) {
-  const relToLca = path12.relative(lcaPath, relPath).replace(/\\/g, "/");
+  const relToLca = path13.relative(lcaPath, relPath).replace(/\\/g, "/");
   for (let i = 0; i < rfConfig.rootNodes.length; i++) {
     const group = rfConfig.rootNodes[i];
     if (group && group.includes(relToLca)) {
@@ -1116,7 +1213,7 @@ function getRootNodeIndex(relPath, rfConfig, lcaPath) {
 function isInsidePrivateCategoryOfLca(relPathB, lcaPath, config) {
   let current = relPathB;
   while (current && current !== "." && current !== "/" && current !== lcaPath) {
-    const parent = path12.dirname(current).replace(/\\/g, "/");
+    const parent = path13.dirname(current).replace(/\\/g, "/");
     if (parent === current) {
       break;
     }
@@ -1141,7 +1238,7 @@ var rule6 = {
     if (!config) {
       return {};
     }
-    const currentDir = path12.dirname(relPath);
+    const currentDir = path13.dirname(relPath);
     const isCurrentFileExcluded = config.excludes?.some(
       (exc) => relPath === exc || relPath.startsWith(exc + "/")
     ) ?? false;
@@ -1174,10 +1271,10 @@ var rule6 = {
       if (isCurrentFileExcluded || isImportedFileExcluded) {
         return;
       }
-      const importedDir = path12.dirname(resolvedRelPath);
+      const importedDir = path13.dirname(resolvedRelPath);
       if (currentDir === importedDir) {
-        const fileA = path12.basename(relPath);
-        const fileB = path12.basename(resolvedRelPath);
+        const fileA = path13.basename(relPath);
+        const fileB = path13.basename(resolvedRelPath);
         const roleA = getFileRole(fileA, config);
         const roleB = getFileRole(fileB, config);
         if (roleA && roleB) {
@@ -1206,6 +1303,10 @@ var rule6 = {
         return;
       }
       if (subB === "" && classifyFolder(lca, config) === "fragment") {
+        context.report({
+          message: `Peer separation violation: "${subA}" cannot import directly from the root of Fragment "${lca}". A node nested inside a Private Category or Fractal Branch has no privileged access to its owning Fragment's other direct children; promote the shared resource to a Fractal Branch if the sharing need is genuine.`,
+          node
+        });
         return;
       }
       const rfConfig = getRootFragmentConfig(lca, config);
@@ -1215,13 +1316,22 @@ var rule6 = {
         if (idxRootA !== -1 && idxRootB !== -1) {
           if (idxRootB >= idxRootA) {
             context.report({
-              message: `Root Node import violation: "${path12.basename(relPath)}" cannot import from "${path12.basename(resolvedRelPath)}" under Root Fragment "${lca}".`,
+              message: `Root Node import violation: "${path13.basename(relPath)}" cannot import from "${path13.basename(resolvedRelPath)}" under Root Fragment "${lca}".`,
               node
             });
           }
           return;
         }
       }
+      const isSubARootFragment = classifyFolder(path13.posix.join(lca, subA), config) === "root-fragment";
+      const isSubBRootFragment = classifyFolder(path13.posix.join(lca, subB), config) === "root-fragment";
+      if (isSubARootFragment || isSubBRootFragment) {
+        context.report({
+          message: `Root Node import violation: "${relPath}" cannot import from "${resolvedRelPath}" because no "rootNodes" relationship is configured under Root Fragment "${lca}". Relationships between Root Nodes must always be explicitly authorized by the architect.`,
+          node
+        });
+        return;
+      }
       const { allowed, defined: hasDefinedHierarchy } = resolveHorizontalHierarchy(lca, subA, subB, config);
       if (hasDefinedHierarchy) {
         if (!allowed) {
@@ -1231,8 +1341,8 @@ var rule6 = {
           });
         }
       } else {
-        const roleA = getDirectoryRole(path12.posix.join(lca, subA), config);
-        const roleB = getDirectoryRole(path12.posix.join(lca, subB), config);
+        const roleA = getDirectoryRole(path13.posix.join(lca, subA), config);
+        const roleB = getDirectoryRole(path13.posix.join(lca, subB), config);
         const idxA = roleA ? getRoleHierarchyIndex(roleA, config) : -1;
         const idxB = roleB ? getRoleHierarchyIndex(roleB, config) : -1;
         if (idxA !== -1 && idxB !== -1) {
@@ -1275,7 +1385,7 @@ var rule6 = {
 var no_peer_dependency_rule_default = rule6;
 
 // src/_rules/no-private-category-leak/no-private-category-leak.rule.ts
-import path13 from "path";
+import path14 from "path";
 var rule7 = {
   create(context) {
     const absPath = context.filename;
@@ -1297,11 +1407,32 @@ var rule7 = {
       if (!resolvedRelPath) {
         return;
       }
-      const importedDir = path13.dirname(resolvedRelPath);
-      const owner = getPrivateCategoryOwner(importedDir, config);
-      if (owner) {
-        const isDescendant = relPath === owner || relPath.startsWith(owner + "/");
-        if (!isDescendant) {
+      const importedDir = path14.dirname(resolvedRelPath);
+      const info = getPrivateCategoryInfo(importedDir, config);
+      if (info) {
+        const { owner, privateCategoryPath } = info;
+        let isFractalBranchInPrivateCategory = false;
+        let isFractalBranchAllowed = false;
+        const fbOwner = getFractalBranchOwner(importedDir);
+        if (fbOwner) {
+          const isFbInsidePrivateCategory = fbOwner === privateCategoryPath || fbOwner.startsWith(privateCategoryPath + "/");
+          if (isFbInsidePrivateCategory) {
+            isFractalBranchInPrivateCategory = true;
+            isFractalBranchAllowed = relPath === fbOwner || relPath.startsWith(fbOwner + "/");
+          }
+        }
+        const isDirectChild = path14.dirname(relPath) === owner;
+        const importerSubDomain = getImmediateSubDomain(
+          relPath,
+          privateCategoryPath
+        );
+        const importedSubDomain = getImmediateSubDomain(
+          resolvedRelPath,
+          privateCategoryPath
+        );
+        const isInsideSameSubDomain = importerSubDomain !== "" && importerSubDomain === importedSubDomain;
+        const isAllowed = isFractalBranchInPrivateCategory ? isFractalBranchAllowed : isDirectChild || isInsideSameSubDomain;
+        if (!isAllowed) {
           context.report({
             message: `Importing from Private Category is forbidden. The imported resource is private to "${owner}".`,
             node