@morriconeluca/eslint-plugin-faf 0.1.1 → 0.2.0

package/README.md

@@ -1,4 +1,4 @@
-# eslint-plugin-faf
+# @morriconeluca/eslint-plugin-faf
 
 An ESLint plugin to deterministically enforce the rules and constraints of the **[Fractal Architecture Framework (FAF)](https://github.com/morriconeluca/fractal-architecture-framework)**.
 
@@ -20,18 +20,18 @@ This plugin is designed for complex TypeScript/JavaScript codebases to ensure **
 Install the plugin along with its peer dependencies:
 
 ```bash
-npm install eslint-plugin-faf --save-dev
+npm install @morriconeluca/eslint-plugin-faf --save-dev
 # or
-yarn add eslint-plugin-faf --dev
+yarn add @morriconeluca/eslint-plugin-faf --dev
 # or
-pnpm add eslint-plugin-faf -D
+pnpm add @morriconeluca/eslint-plugin-faf -D
 ```
 
 ---
 
 ## Configuration
 
-`eslint-plugin-faf` is configured via the ESLint flat config file (`eslint.config.ts` or `eslint.config.js`). All architectural settings are loaded from the global `settings.faf` object.
+`@morriconeluca/eslint-plugin-faf` is configured via the ESLint flat config file (`eslint.config.ts` or `eslint.config.js`). All architectural settings are loaded from the global `settings.faf` object.
 
 ### 1. Integration in `eslint.config.ts`
 
@@ -40,7 +40,7 @@ For a clean setup, we recommend defining your FAF taxonomy settings in a separat
 Since FAF is an **all-or-nothing architectural system**, all rules must be active as blocking errors to prevent architectural drift. The canonical way to integrate it is by extending `fafPlugin.configs.recommended` (which pre-configures all rules as `"error"`) and injecting your settings:
 
 ```typescript
-import fafPlugin from 'eslint-plugin-faf';
+import fafPlugin from '@morriconeluca/eslint-plugin-faf';
 import fafSettings from './faf.config';
 
 export default [

package/dist/main.cjs

@@ -39,8 +39,12 @@ module.exports = __toCommonJS(main_exports);
 // package.json
 var package_default = {
   name: "@morriconeluca/eslint-plugin-faf",
-  version: "0.1.1",
+  version: "0.2.0",
   description: "An ESLint plugin for FAF projects.",
+  repository: {
+    type: "git",
+    url: "git+https://github.com/morriconeluca/eslint-plugin-faf.git"
+  },
   main: "./dist/main.cjs",
   module: "./dist/main.js",
   types: "./dist/main.d.ts",
@@ -52,7 +56,8 @@ var package_default = {
     }
   },
   publishConfig: {
-    access: "public"
+    access: "public",
+    provenance: true
   },
   imports: {
     "#_rules@shared/*": "./src/_rules/_rules@shared/*",
@@ -353,6 +358,9 @@ var rule = {
           if (catConfig) {
             const ext = import_path5.default.extname(fileName);
             const isAllowedAsset = catConfig.allowedExtensions?.includes(ext) ?? false;
+            if (!isAllowedAsset && catConfig.allowedExtensions && catConfig.allowedExtensions.length > 0) {
+              return;
+            }
             if (!catConfig.allowSingleFiles && !isAllowedAsset) {
               context.report({
                 message: `Category "${folderName}" cannot contain file nodes directly. File "${fileName}" must be encapsulated inside a Fragment.`,
@@ -940,43 +948,56 @@ var rule4 = {
 var no_direct_fragment_import_rule_default = rule4;
 
 // src/_rules/no-fractal-branch-leak/no-fractal-branch-leak.rule.ts
-var import_path11 = __toESM(require("path"), 1);
+var import_path12 = __toESM(require("path"), 1);
 
-// src/_rules/_rules@shared/_utils/_systems/get-private-category-owner/get-private-category-owner.util.ts
+// src/_rules/_rules@shared/_utils/_primitives/get-fractal-branch-owner/get-fractal-branch-owner.util.ts
 var import_path10 = __toESM(require("path"), 1);
-function getPrivateCategoryOwner(relPath, config) {
+function getFractalBranchOwner(relPath) {
   let current = relPath;
   while (current && current !== "." && current !== "/") {
+    const folderName = import_path10.default.basename(current);
+    if (folderName.startsWith("_") && folderName.includes("@shared")) {
+      return import_path10.default.dirname(current).replace(/\\/g, "/");
+    }
     const parent = import_path10.default.dirname(current).replace(/\\/g, "/");
     if (parent === current) {
       break;
     }
-    const currentType = classifyFolder(current, config);
-    const parentType = classifyFolder(parent, config);
-    if (currentType === "category" && (parentType === "fragment" || parentType === "root-fragment")) {
-      return parent;
-    }
     current = parent;
   }
   return null;
 }
 
-// src/_rules/no-fractal-branch-leak/no-fractal-branch-leak.rule.ts
-function getFractalBranchOwner(relPath) {
+// src/_rules/_rules@shared/_utils/_primitives/get-immediate-sub-domain/get-immediate-sub-domain.util.ts
+function getImmediateSubDomain(relPath, privateCategoryPath) {
+  if (relPath !== privateCategoryPath && !relPath.startsWith(privateCategoryPath + "/")) {
+    return "";
+  }
+  const relative = relPath.substring(privateCategoryPath.length + 1);
+  const firstSegment = relative.split("/")[0];
+  return firstSegment ? privateCategoryPath + "/" + firstSegment : privateCategoryPath;
+}
+
+// src/_rules/_rules@shared/_utils/_systems/get-private-category-info/get-private-category-info.util.ts
+var import_path11 = __toESM(require("path"), 1);
+function getPrivateCategoryInfo(relPath, config) {
   let current = relPath;
   while (current && current !== "." && current !== "/") {
-    const folderName = import_path11.default.basename(current);
-    if (folderName.startsWith("_") && folderName.includes("@shared")) {
-      return import_path11.default.dirname(current).replace(/\\/g, "/");
-    }
     const parent = import_path11.default.dirname(current).replace(/\\/g, "/");
     if (parent === current) {
       break;
     }
+    const currentType = classifyFolder(current, config);
+    const parentType = classifyFolder(parent, config);
+    if (currentType === "category" && (parentType === "fragment" || parentType === "root-fragment")) {
+      return { owner: parent, privateCategoryPath: current };
+    }
     current = parent;
   }
   return null;
 }
+
+// src/_rules/no-fractal-branch-leak/no-fractal-branch-leak.rule.ts
 var rule5 = {
   create(context) {
     const absPath = context.filename;
@@ -998,7 +1019,7 @@ var rule5 = {
       if (!resolvedRelPath) {
         return;
       }
-      const importedDir = import_path11.default.dirname(resolvedRelPath);
+      const importedDir = import_path12.default.dirname(resolvedRelPath);
       const owner = getFractalBranchOwner(importedDir);
       if (owner) {
         const isDescendant = relPath === owner || relPath.startsWith(owner + "/");
@@ -1008,12 +1029,30 @@ var rule5 = {
             node
           });
         } else {
-          const privateOwner = getPrivateCategoryOwner(importedDir, config);
-          if (privateOwner) {
-            const isPrivateDescendant = relPath === privateOwner || relPath.startsWith(privateOwner + "/");
-            if (!isPrivateDescendant) {
+          const info = getPrivateCategoryInfo(importedDir, config);
+          if (info) {
+            const { owner: owner2, privateCategoryPath } = info;
+            const isPrivateDirectChild = import_path12.default.dirname(relPath) === owner2;
+            const importerSubDomain = getImmediateSubDomain(
+              relPath,
+              privateCategoryPath
+            );
+            const importedSubDomain = getImmediateSubDomain(
+              resolvedRelPath,
+              privateCategoryPath
+            );
+            const isInsideSameSubDomain = importerSubDomain !== "" && importerSubDomain === importedSubDomain;
+            let isFractalBranchAllowed = false;
+            const fbOwner = getFractalBranchOwner(importedDir);
+            if (fbOwner) {
+              const isFbInsidePrivateCategory = fbOwner === privateCategoryPath || fbOwner.startsWith(privateCategoryPath + "/");
+              if (isFbInsidePrivateCategory) {
+                isFractalBranchAllowed = relPath === fbOwner || relPath.startsWith(fbOwner + "/");
+              }
+            }
+            if (!isPrivateDirectChild && !isInsideSameSubDomain && !isFractalBranchAllowed) {
               context.report({
-                message: `Importing from Private Category is forbidden. The imported resource is private to "${privateOwner}".`,
+                message: `Importing from Private Category is forbidden. The imported resource is private to "${owner2}".`,
                 node
               });
             }
@@ -1046,7 +1085,7 @@ var rule5 = {
 var no_fractal_branch_leak_rule_default = rule5;
 
 // src/_rules/no-peer-dependency/no-peer-dependency.rule.ts
-var import_path12 = __toESM(require("path"), 1);
+var import_path13 = __toESM(require("path"), 1);
 
 // src/_rules/_rules@shared/_utils/_primitives/find-tree-config-including-excluded/find-tree-config-including-excluded.util.ts
 function findTreeConfigIncludingExcluded(relPath, settings) {
@@ -1124,7 +1163,7 @@ function resolveHorizontalHierarchy(lcaPath, subA, subB, config) {
 
 // src/_rules/no-peer-dependency/no-peer-dependency.rule.ts
 function getDirectoryRole(dirPath, config) {
-  const folderName = import_path12.default.basename(dirPath);
+  const folderName = import_path13.default.basename(dirPath);
   if (folderName.startsWith("_")) {
     return getRoleFromFolderName(folderName, config);
   }
@@ -1142,7 +1181,7 @@ function getRoleFromFolderName(name, config) {
   return catConfig ? catConfig.role ?? null : null;
 }
 function getRootNodeIndex(relPath, rfConfig, lcaPath) {
-  const relToLca = import_path12.default.relative(lcaPath, relPath).replace(/\\/g, "/");
+  const relToLca = import_path13.default.relative(lcaPath, relPath).replace(/\\/g, "/");
   for (let i = 0; i < rfConfig.rootNodes.length; i++) {
     const group = rfConfig.rootNodes[i];
     if (group && group.includes(relToLca)) {
@@ -1154,7 +1193,7 @@ function getRootNodeIndex(relPath, rfConfig, lcaPath) {
 function isInsidePrivateCategoryOfLca(relPathB, lcaPath, config) {
   let current = relPathB;
   while (current && current !== "." && current !== "/" && current !== lcaPath) {
-    const parent = import_path12.default.dirname(current).replace(/\\/g, "/");
+    const parent = import_path13.default.dirname(current).replace(/\\/g, "/");
     if (parent === current) {
       break;
     }
@@ -1179,7 +1218,7 @@ var rule6 = {
     if (!config) {
       return {};
     }
-    const currentDir = import_path12.default.dirname(relPath);
+    const currentDir = import_path13.default.dirname(relPath);
     const isCurrentFileExcluded = config.excludes?.some(
       (exc) => relPath === exc || relPath.startsWith(exc + "/")
     ) ?? false;
@@ -1212,10 +1251,10 @@ var rule6 = {
       if (isCurrentFileExcluded || isImportedFileExcluded) {
         return;
       }
-      const importedDir = import_path12.default.dirname(resolvedRelPath);
+      const importedDir = import_path13.default.dirname(resolvedRelPath);
       if (currentDir === importedDir) {
-        const fileA = import_path12.default.basename(relPath);
-        const fileB = import_path12.default.basename(resolvedRelPath);
+        const fileA = import_path13.default.basename(relPath);
+        const fileB = import_path13.default.basename(resolvedRelPath);
         const roleA = getFileRole(fileA, config);
         const roleB = getFileRole(fileB, config);
         if (roleA && roleB) {
@@ -1253,7 +1292,7 @@ var rule6 = {
         if (idxRootA !== -1 && idxRootB !== -1) {
           if (idxRootB >= idxRootA) {
             context.report({
-              message: `Root Node import violation: "${import_path12.default.basename(relPath)}" cannot import from "${import_path12.default.basename(resolvedRelPath)}" under Root Fragment "${lca}".`,
+              message: `Root Node import violation: "${import_path13.default.basename(relPath)}" cannot import from "${import_path13.default.basename(resolvedRelPath)}" under Root Fragment "${lca}".`,
               node
             });
           }
@@ -1269,8 +1308,8 @@ var rule6 = {
           });
         }
       } else {
-        const roleA = getDirectoryRole(import_path12.default.posix.join(lca, subA), config);
-        const roleB = getDirectoryRole(import_path12.default.posix.join(lca, subB), config);
+        const roleA = getDirectoryRole(import_path13.default.posix.join(lca, subA), config);
+        const roleB = getDirectoryRole(import_path13.default.posix.join(lca, subB), config);
         const idxA = roleA ? getRoleHierarchyIndex(roleA, config) : -1;
         const idxB = roleB ? getRoleHierarchyIndex(roleB, config) : -1;
         if (idxA !== -1 && idxB !== -1) {
@@ -1313,7 +1352,7 @@ var rule6 = {
 var no_peer_dependency_rule_default = rule6;
 
 // src/_rules/no-private-category-leak/no-private-category-leak.rule.ts
-var import_path13 = __toESM(require("path"), 1);
+var import_path14 = __toESM(require("path"), 1);
 var rule7 = {
   create(context) {
     const absPath = context.filename;
@@ -1335,11 +1374,29 @@ var rule7 = {
       if (!resolvedRelPath) {
         return;
       }
-      const importedDir = import_path13.default.dirname(resolvedRelPath);
-      const owner = getPrivateCategoryOwner(importedDir, config);
-      if (owner) {
-        const isDescendant = relPath === owner || relPath.startsWith(owner + "/");
-        if (!isDescendant) {
+      const importedDir = import_path14.default.dirname(resolvedRelPath);
+      const info = getPrivateCategoryInfo(importedDir, config);
+      if (info) {
+        const { owner, privateCategoryPath } = info;
+        const isDirectChild = import_path14.default.dirname(relPath) === owner;
+        const importerSubDomain = getImmediateSubDomain(
+          relPath,
+          privateCategoryPath
+        );
+        const importedSubDomain = getImmediateSubDomain(
+          resolvedRelPath,
+          privateCategoryPath
+        );
+        const isInsideSameSubDomain = importerSubDomain !== "" && importerSubDomain === importedSubDomain;
+        let isFractalBranchAllowed = false;
+        const fbOwner = getFractalBranchOwner(importedDir);
+        if (fbOwner) {
+          const isFbInsidePrivateCategory = fbOwner === privateCategoryPath || fbOwner.startsWith(privateCategoryPath + "/");
+          if (isFbInsidePrivateCategory) {
+            isFractalBranchAllowed = relPath === fbOwner || relPath.startsWith(fbOwner + "/");
+          }
+        }
+        if (!isDirectChild && !isInsideSameSubDomain && !isFractalBranchAllowed) {
           context.report({
             message: `Importing from Private Category is forbidden. The imported resource is private to "${owner}".`,
             node