@moretea-labs/forge 1.7.0 → 1.7.2

package/src/runtime/gateway/mcp/legacy-ios-tool-adapter.ts

@@ -0,0 +1,61 @@
+/**
+ * Compatibility translation only: legacy iOS MCP tool names are normalized to
+ * the canonical typed iOS plugin action surface. This module owns no runtime,
+ * repository, Work, approval, or plugin execution state.
+ */
+export interface LegacyIosPluginInvocation {
+  actionId: string;
+  requestId: string;
+  arguments: Record<string, unknown>;
+  confirmAuthorization: boolean;
+}
+
+function definedArguments(value: Record<string, unknown>): Record<string, unknown> {
+  return Object.fromEntries(Object.entries(value).filter(([, entry]) => entry !== undefined));
+}
+
+function optionalString(args: Record<string, unknown>, key: string): string | undefined {
+  return typeof args[key] === 'string' ? args[key] as string : undefined;
+}
+
+function optionalNumber(args: Record<string, unknown>, key: string): number | undefined {
+  return typeof args[key] === 'number' ? args[key] as number : undefined;
+}
+
+export function legacyIosPluginInvocation(
+  legacyTool: string,
+  args: Record<string, unknown>,
+): LegacyIosPluginInvocation | undefined {
+  const invocation = (() => {
+    switch (legacyTool) {
+      case 'ios_xcode_status':
+        return { actionId: 'xcode_status', arguments: {} };
+      case 'ios_simulators_list':
+        return { actionId: 'list_simulators', arguments: { runtime: optionalString(args, 'runtime'), name: optionalString(args, 'name') } };
+      case 'ios_project_discover':
+        return { actionId: 'discover_project', arguments: {} };
+      case 'ios_schemes_list':
+        return { actionId: 'list_schemes', arguments: { workspace: optionalString(args, 'workspace'), project: optionalString(args, 'project') } };
+      case 'ios_simulator_boot':
+        return { actionId: 'launch_simulator', arguments: { udid: String(args.udid ?? '').trim(), open_simulator: args.open_simulator !== false, timeout_ms: optionalNumber(args, 'timeout_ms') } };
+      case 'ios_app_build':
+        return { actionId: 'build', arguments: { scheme: String(args.scheme ?? '').trim(), udid: optionalString(args, 'udid'), simulator_name: optionalString(args, 'simulator_name'), workspace: optionalString(args, 'workspace'), project: optionalString(args, 'project'), configuration: optionalString(args, 'configuration'), timeout_ms: optionalNumber(args, 'timeout_ms') } };
+      case 'ios_simulator_screenshot':
+        return { actionId: 'capture_screenshot', arguments: { udid: String(args.udid ?? '').trim(), label: optionalString(args, 'label') } };
+      case 'ios_ui_smoke_test':
+        return { actionId: 'smoke_review', arguments: { scheme: optionalString(args, 'scheme'), bundle_id: optionalString(args, 'bundle_id'), udid: optionalString(args, 'udid'), simulator_name: optionalString(args, 'simulator_name'), workspace: optionalString(args, 'workspace'), project: optionalString(args, 'project'), configuration: optionalString(args, 'configuration'), app_path: optionalString(args, 'app_path'), screenshot_label: optionalString(args, 'screenshot_label') } };
+      default:
+        return undefined;
+    }
+  })();
+  if (!invocation) return undefined;
+  const requestId = typeof args.request_id === 'string' && args.request_id.trim()
+    ? args.request_id.trim()
+    : `legacy-${legacyTool}-${Date.now()}`;
+  return {
+    actionId: invocation.actionId,
+    requestId,
+    arguments: definedArguments(invocation.arguments),
+    confirmAuthorization: args.confirm_authorization === true,
+  };
+}

package/src/runtime/gateway/mcp/router.ts

@@ -1,5 +1,5 @@
 import { createHash } from 'crypto';
-import type { CallToolResult, McpToolDefinition } from '../../../cli/mcp/tools';
+import type { CallToolResult, McpToolDefinition } from '../../../cli/mcp/tool-contract';
 import {
   buildMultiRepositoryToolDefinitions,
   type MultiRepositoryMcpToolContext,
@@ -9,7 +9,7 @@ import {
   claimedSessionEditBinding,
   repositoryToolDefinitions,
 } from '../../../cli/mcp/repository-tools';
-import { runtimeToolDefinitions } from './runtime-tools';
+import { runtimeToolDefinitions } from './runtime-tool-definitions';
 import { executionToolDefinitions } from './execution-tools';
 import { processToolDefinitions } from './process-tools';
 import { resolveRepositorySelection } from '../../../cli/repositories/registry';

package/src/runtime/gateway/mcp/runtime-tool-definitions.ts

@@ -92,6 +92,7 @@ export const runtimeToolDefinitions: McpToolDefinition[] = [
     handoff_id: { type: 'string', description: 'Optional existing HandoffItem used to resume controller context. Required for controller_disposition=wait_for_user.' },
     disposition: { type: 'string', enum: ['continue_immediately', 'wait', 'wait_for_user', 'goal_complete'], description: 'Explicit ChatGPT end-of-round semantic decision. continue_immediately is consumed only after the current controller lease closes.' },
     relay_scope_id: { type: 'string', description: 'Stable Requirement/Goal relay identity. Requirement-bound Work uses requirement:<id>; otherwise reuse the exact returned goal scope across Works.' },
+    controller_authority_id: { type: 'string', description: 'Opaque durable authority for the currently dispatched ChatGPT controller round. Required with relay_scope_id for lifecycle mutation of relay-bound Work; rotates before a successor round while surviving MCP transport/Runtime rotation within the same round.' },
     state_fingerprint: { type: 'string', description: 'Optional controller-observed semantic-state fingerprint. When omitted, Forge derives a mechanical fingerprint from current Requirement/Work/Handoff state.' },
     max_rounds: { type: 'number', description: 'Mechanical immediate-relay round budget; defaults to 8 and cannot be loosened within an existing relay scope.' },
     max_repeated_state: { type: 'number', description: 'Mechanical repeated-state fence; defaults to 2 repeated observations and cannot be loosened within an existing relay scope.' },
@@ -155,7 +156,7 @@ export const runtimeToolDefinitions: McpToolDefinition[] = [
     expected_files: { type: 'number' },
     expected_changed_lines: { type: 'number' },
     mode: { type: 'string', enum: ['scale'], description: 'Explicit Scale coordination mode for start. Scale requires a bound approved PlanContract step and uses existing Work/Process/resource-claim authorities; it does not create an agent-swarm lifecycle.' },
-    work_kind: { type: 'string', enum: ['repository_change', 'completed_no_change', 'investigation', 'local_effect', 'remote_effect', 'reconciliation'], description: 'Explicit technical Work evidence shape for operation=start. local_effect/remote_effect represent effect-only execution and do not require a repository diff; completed_no_change/investigation/reconciliation likewise do not imply a source mutation. None of these imply semantic completion; ChatGPT must still explicitly finalize after reviewing evidence.' },
+    work_kind: { type: 'string', enum: ['repository_change', 'completed_no_change', 'read_only_review', 'investigation', 'local_effect', 'remote_effect', 'reconciliation'], description: 'Explicit technical Work evidence shape for operation=start. read_only_review is a recoverable source-frozen review lifecycle: it permits inspected-path/finding persistence without repository edits and only clean-finalizes after unchanged-source proof. local_effect/remote_effect represent effect-only execution; completed_no_change/investigation/reconciliation likewise do not imply a source mutation. None imply semantic completion; ChatGPT must still explicitly finalize after reviewing evidence.' },
     scope_clear: { type: 'boolean' },
     requires_investigation: { type: 'boolean' },
     requires_long_running_checks: { type: 'boolean' },
@@ -178,9 +179,27 @@ export const runtimeToolDefinitions: McpToolDefinition[] = [
     initial_likely_paths: { type: 'array', items: { type: 'string' }, description: 'Non-authoritative first-pass discovery candidates. May expand after investigation; allowed_paths remains a policy fence only.' },
     additional_likely_paths: { type: 'array', items: { type: 'string' }, description: 'Non-authoritative candidates discovered after Work start. Valid for continue; does not widen allowed_paths.' },
     inspected_paths: { type: 'array', items: { type: 'string' }, description: 'Paths actually inspected during progressive discovery. Valid for continue; does not widen allowed_paths.' },
+    review_findings: { type: 'array', items: { type: 'string' }, description: 'Concise semantic findings for operation=continue on work_kind=read_only_review. Findings are source-bound durable review evidence and prevent clean completed_no_change finalization until a successor repair/review resolves them.' },
+    acceptance_evidence: { type: 'array', items: { type: 'object', required: ['criterion', 'evidence_ids', 'rationale'], properties: { criterion: { type: 'string', description: 'Exact declared Work acceptance criterion reviewed by the Controller.' }, evidence_ids: { type: 'array', items: { type: 'string' }, description: 'Durable evidence ids already attributed to this Work that support this exact criterion.' }, rationale: { type: 'string', description: 'Controller rationale for why the cited evidence satisfies this exact criterion.' } }, additionalProperties: false }, description: 'Operation=continue only. Explicit Controller-reviewed criterion-to-evidence bindings for no-check local_effect Work. Mechanical plugin/process attribution alone never implies semantic acceptance.' },
     acceptance_failure_decision: { type: 'string', enum: ['repair', 'rescope'], description: 'Explicit Controller decision for operation=continue after a deterministic valid_fail. Bypasses acceptance-review handoff only for this bounded repair/re-scope decision; never inferred from free text.' },
     forbidden_paths: { type: 'array', items: { type: 'string' } },
-    constraints: { type: 'object' },
+    constraints: {
+      type: 'object',
+      properties: {
+        max_changed_files: { type: 'number' },
+        max_changed_lines: { type: 'number' },
+        allow_commit: { type: 'boolean' },
+        allow_merge: { type: 'boolean' },
+        allow_cleanup: { type: 'boolean' },
+        allow_destructive: { type: 'boolean' },
+        require_handoff_on_ambiguity: { type: 'boolean' },
+        access_mode: { type: 'string', enum: ['request', 'full_access'] },
+        workspace_mode: { type: 'string', enum: ['current', 'isolated', 'auto'], description: 'Typed placement policy. isolated is an admission fence and cannot be downgraded to Direct Control.' },
+        require_worktree: { type: 'boolean', description: 'Typed placement policy. true requires isolated Work placement before routing.' },
+        direct_main_prohibited: { type: 'boolean', description: 'Typed admission fence. true forbids Direct Control/current-main repository mutation.' },
+      },
+      additionalProperties: true,
+    },
     repair_operation: { type: 'string', enum: ['diagnose', 'repair', 'verify', 'handoff'] },
     target: { type: 'string', enum: ['codex', 'grok', 'claude'], description: 'Explicit small-brain delegate target for operation=delegate. Delegation is never the default execution path.' },
     available: { type: 'boolean', description: 'Whether the delegate target is currently available.' },