@moretea-labs/forge 1.6.0 → 1.7.1

package/src/cli/mcp/auth.ts

@@ -25,7 +25,7 @@ export interface McpLocalConfig {
     localEndpoint?: string;
   };
   profile?: string;
-  toolset?: 'core' | 'advanced' | 'full';
+  toolset?: 'facade' | 'core' | 'advanced' | 'full';
   /** Compatibility marker retained for previously persisted toolset choices. */
   toolsetExplicit?: boolean;
   accessMode?: AccessMode;
@@ -88,7 +88,7 @@ export interface McpRuntimeState {
     forgeVersion?: string;
     toolSurfaceFingerprint?: string;
     runtimeToolSurfaceFingerprint?: string;
-    toolset?: 'core' | 'advanced' | 'full';
+    toolset?: 'facade' | 'core' | 'advanced' | 'full';
     configuredAccessMode?: AccessMode;
     effectiveAccessMode?: AccessMode;
     effectiveToolset?: McpToolset;
@@ -131,7 +131,7 @@ export interface McpRuntimeState {
   }>;
 }
 
-export type McpHttpAuthMode = 'oauth' | 'bearer';
+export type McpHttpAuthMode = 'oauth' | 'bearer' | 'none';
 
 export function mcpLocalConfigPath(repoRoot: string): string {
   return join(repoRoot, '.forge', 'mcp.local.json');
@@ -356,8 +356,8 @@ export function syncMcpControllerHomeBearerToken(
 
 export function parseMcpHttpAuthMode(value: string | undefined): McpHttpAuthMode {
   const mode = (value ?? 'oauth').trim().toLowerCase();
-  if (mode === 'oauth' || mode === 'bearer') return mode;
-  throw new Error(`invalid --auth "${value}" (expected: oauth, bearer)`);
+  if (mode === 'oauth' || mode === 'bearer' || mode === 'none') return mode;
+  throw new Error(`invalid --auth "${value}" (expected: oauth, bearer, none)`);
 }
 
 export function readMcpOAuthPassphrase(repoRoot: string): string | null {

package/src/cli/mcp/instructions.ts

@@ -10,10 +10,11 @@ export function mcpServerInstructions(profile: McpProfileName): string {
     return [
       ...common,
       'Use the shortest valid execution path. Investigation or parallelism alone must not create durable Work, Issues, Plans, Agents, isolation, or worktrees; escalate only for actual recovery, dependency, risk, scope, external-effect, or long-running requirements.',
-      'For bounded implementation, use rh_context(operation=search, retrieval_mode=implementation) once as the default code retrieval router when the exact path is unknown. Its current raw snippets and file SHA identities are valid implementation evidence; ChatGPT decides semantic sufficiency and should request wider exact ranges only when impact ambiguity, truncation, drift, or an expansion signal can materially change the edit. For cross-cutting state/time/schema/cache/API/event/concurrency changes, ChatGPT should select relevant impact_domains in that first search so Forge expands those evidence dimensions mechanically in the same call; Forge never infers that the selected domains are semantically complete. Use retrieval_mode=plan|debug|review when the task intentionally needs a broader evidence surface. Do not fall back to shell grep unless retrieval is unavailable or raw Git semantics are explicitly needed. The low-level search_repository handler is compatibility/internal surface, not a second default search path. Prefer repository_command_execute for ordinary local Git and shell operations, repository_safe_patch_apply for bounded source changes, and rh_work only when the task genuinely requires durable orchestration.',
+      'For bounded implementation, start with rh_context(operation=search, retrieval_mode=implementation) as the default code retrieval router when the exact path is unknown, then repeat it with exact paths, symbols, tests, relationships, or impact domains whenever more evidence can materially improve correctness. Its current raw snippets and file SHA identities are valid implementation evidence; ChatGPT alone decides semantic sufficiency. For cross-cutting state/time/schema/cache/API/event/concurrency changes, ChatGPT should select relevant impact_domains so Forge expands those evidence dimensions mechanically; Forge never infers that the selected domains are semantically complete. Use retrieval_mode=plan|debug|review when the task intentionally needs a broader evidence surface. Do not fall back to shell grep unless retrieval is unavailable or raw Git semantics are explicitly needed. The low-level search_repository handler is compatibility/internal surface, not a second default search path. Prefer repository_command_execute for ordinary local Git and shell operations, repository_safe_patch_apply for bounded source changes, and rh_work only when the task genuinely requires durable orchestration.',
       'Do not preflight unrelated Git history, prior Work, plugins, permissions, TCC, browser mode, maintenance, or recovery state. Inspect them only when the requested operation depends on them or a real failure points there.',
+      'Minimize mechanically redundant MCP round trips. For an ongoing Forge-controlled task, prefer one rh_status(summary) as the initial controller snapshot: it includes bounded readiness, repository identity, top active Work, active Plans, and pending handoffs. Do not immediately follow it with rh_work(plan_list) or rh_context(list/get) unless the next decision needs details that the snapshot does not contain. Use rh_context(work_id=..., detail_level=summary) for one Work, and request detail/raw or capability hydration only when that extra evidence can change the decision.',
       'Run independent reads, searches, diagnostics, checks, repositories, checkouts, and tasks concurrently by default. Serialize only on a real dependency or Resource Claim conflict, and reuse existing projections, process handles, and check evidence instead of repeating successful observations.',
-      'Validation must be proportional to the change: cheap patch-safety checks belong to every coherent edit batch, focused tests run after that batch is stable, and expensive full-suite checks belong at candidate/release or explicitly high-risk boundaries. When a Direct Edit batch is stable, repository_safe_patch_apply may receive explicit check_ids to start revision-bound validation; omit check_ids during intermediate edits. Long checks return managed Processes: continue independent read/review work, then use validation_only with the returned edit-session/validation ids as the synchronization join instead of polling repeatedly. Do not perform maintenance or deep runtime diagnosis before ordinary work unless execution is actually blocked.',
+      'Validation must be proportional to the change: cheap patch-safety checks belong to every coherent edit batch, focused tests run after that batch is stable, and expensive full-suite checks belong at candidate/release or explicitly high-risk boundaries. When a Direct Edit batch is stable, repository_safe_patch_apply may receive explicit check_ids to start revision-bound validation; omit check_ids during intermediate edits. Long checks return managed Processes: continue independent read/review work. Do not call process_wait while useful independent work remains. Use process_get only when a non-blocking observation can change the next decision; when the exact check result becomes a dependency, attach with process_wait (or validation_only with the returned edit-session/validation ids). An attach is transport-bounded: if it returns a running handle, resume useful work and attach again only at a later real dependency boundary, never as periodic polling. Do not perform maintenance or deep runtime diagnosis before ordinary work unless execution is actually blocked.',
       'repository_safe_patch_apply returns bounded edit-session diff evidence for semantic review. Review that evidence directly instead of issuing a mandatory follow-up diff/status call; expand it only when truncated or semantically ambiguous. After a bounded successful change, finish the requested delivery directly. Avoid additional investigation whose result cannot change implementation or acceptance, and do not invoke hidden atomic compatibility tools merely because they exist in the full profile.',
     ].join(' ');
   }

package/src/cli/mcp/legacy-tool-service.ts

@@ -1,4 +1,5 @@
-import type { CallToolResult as SdkCallToolResult } from '@modelcontextprotocol/sdk/types.js';
+import type { CallToolResult, McpToolDefinition } from './tool-contract';
+export type { CallToolResult, McpToolDefinition } from './tool-contract';
 import { createHash } from "crypto";
 import {
   existsSync,
@@ -71,7 +72,8 @@ import {
 import { normalizeCheckIds } from '../../runtime/control-plane/facade/check-normalization';
 import { buildExecutionDiagnostics, buildRequirementBoard } from '../../runtime/control-plane/facade/requirement-board';
 import { acceptVerifiedTaskFromControllerWork } from '../../runtime/control-plane/execution/work-task-receipt';
-import { createWorkContract, getWorkContract } from '../../runtime/control-plane/facade/work-contract-store';
+import { getWorkContract } from '../../runtime/control-plane/facade/work-contract-store';
+import { admitDirectEditWorkContract } from '../../runtime/control-plane/facade/repository-work-admission';
 import { decideRoute } from '../../runtime/control-plane/routing/route-policy';
 import { listCapabilityDescriptors, summarizeCapabilityGroups } from '../../runtime/control-plane/facade/capability-registry';
 import {
@@ -113,7 +115,6 @@ import type {
 import {
   gitDiff,
   gitSnapshot,
-  readRepositoryRange,
   searchRepository,
 } from "../repository/inspector";
 import {
@@ -150,6 +151,11 @@ import { hashMcpInput, tryWriteMcpAuditEntry } from "./audit";
 import { loadMcpRuntimeState } from "./auth";
 import { resolveLocalBridgeSurface, summarizeRecentJobs } from "../../runtime/shared/local-bridge-surface";
 import { resolveRepoPreferredControllerHome } from "../repositories/controller-home";
+import { resolveRepositorySelection } from '../repositories/registry';
+import { executionIdentityForRepository } from '../../runtime/control-plane/execution/execution-identity';
+import { runPersistedCheckViaProcessRuntime } from '../../runtime/gateway/mcp/persisted-check-process';
+import { getProcessRecord } from '../../runtime/execution/process-runtime/store';
+import { processCheckCompletionReceipt } from '../../runtime/execution/process-runtime/check-receipt';
 import { normalizeMcpRelativePath, resolveMcpPath } from "./paths";
 import { currentGitBranch, isForgeAdopted } from "./repo";
 import { repositoryToolNames } from "./repository-tools";
@@ -174,16 +180,6 @@ export interface McpToolContext {
   signal?: AbortSignal;
 }
 
-export interface McpToolDefinition {
-  name: string;
-  description: string;
-  inputSchema: Record<string, unknown>;
-  annotations?: Record<string, unknown>;
-}
-
-export type CallToolResult = Omit<SdkCallToolResult, "content"> & {
-  content: Array<{ type: "text"; text: string }>;
-};
 
 const EMPTY_SCHEMA = { type: "object", additionalProperties: false };
 
@@ -1634,29 +1630,6 @@ export function buildMcpToolDefinitions(
         },
         annotations: readOnly,
       },
-      {
-        name: "controller_context_pack",
-        description:
-          "Build a bounded code context pack for a task: relevant files, search-hit line ranges, and raw snippets. This is for scoped investigation, not blind implementation.",
-        inputSchema: {
-          type: "object",
-          properties: {
-            description: { type: "string" },
-            issue_id: { type: "string" },
-            task_id: { type: "string" },
-            known_paths: { type: "array", items: { type: "string" } },
-            include_globs: { type: "array", items: { type: "string" } },
-            exclude_globs: { type: "array", items: { type: "string" } },
-            search_terms: { type: "array", items: { type: "string" } },
-            max_files: { type: "number" },
-            max_snippets: { type: "number" },
-            max_chars_per_snippet: { type: "number" },
-            structural_context: { type: "string", enum: ["off", "auto", "required"], description: "Optional CodeGraph structural context. Defaults to off so ordinary Direct work pays no graph startup cost." },
-          },
-          additionalProperties: false,
-        },
-        annotations: readOnly,
-      },
       {
         name: "quick_agent_session",
         description:
@@ -1807,22 +1780,6 @@ export function buildMcpToolDefinitions(
         },
         annotations: readOnly,
       },
-      {
-        name: "read_repository_file",
-        description:
-          "Read a line range from one policy-readable repository file.",
-        inputSchema: {
-          type: "object",
-          properties: {
-            path: { type: "string" },
-            start_line: { type: "number" },
-            end_line: { type: "number" },
-          },
-          required: ["path"],
-          additionalProperties: false,
-        },
-        annotations: readOnly,
-      },
       {
         name: "get_git_diff",
         description:
@@ -1844,25 +1801,6 @@ export function buildMcpToolDefinitions(
         inputSchema: EMPTY_SCHEMA,
         annotations: readOnly,
       },
-      {
-        name: "run_check",
-        description:
-          "Start one named focused repository check as a Local Job and return immediately; inspect it with get_local_job.",
-        inputSchema: {
-          type: "object",
-          properties: {
-            check_id: { type: "string" },
-            timeout_ms: { type: "number" },
-          },
-          required: ["check_id"],
-          additionalProperties: false,
-        },
-        annotations: {
-          readOnlyHint: false,
-          openWorldHint: false,
-          destructiveHint: false,
-        },
-      },
       {
         name: "list_issues",
         description: "List controller-managed issues and task summaries.",
@@ -3306,28 +3244,6 @@ export async function callMcpTool(
         audit(ctx, name, "ok", args);
         return textResult(payload);
       }
-      case "controller_context_pack": {
-        if (ctx.policy.profile !== "controller")
-          return errorResult(
-            "TOOL_DISABLED",
-            "controller_context_pack requires the controller profile",
-          );
-        const pack = buildControllerContextPack(ctx.repoRoot, ctx.policy, {
-          description: typeof args.description === "string" ? args.description : undefined,
-          issueId: typeof args.issue_id === "string" ? args.issue_id : undefined,
-          taskId: typeof args.task_id === "string" ? args.task_id : undefined,
-          knownPaths: stringList(args.known_paths),
-          includeGlobs: stringList(args.include_globs),
-          excludeGlobs: stringList(args.exclude_globs),
-          searchTerms: stringList(args.search_terms),
-          maxFiles: typeof args.max_files === "number" ? args.max_files : undefined,
-          maxSnippets: typeof args.max_snippets === "number" ? args.max_snippets : undefined,
-          maxCharsPerSnippet: typeof args.max_chars_per_snippet === "number" ? args.max_chars_per_snippet : undefined,
-          structuralContext: args.structural_context === "auto" || args.structural_context === "required" ? args.structural_context : "off",
-        });
-        audit(ctx, name, "ok", args);
-        return textResult(pack);
-      }
       case "controller_context": {
         if (ctx.policy.profile !== "controller")
           return errorResult(
@@ -3563,36 +3479,6 @@ export async function callMcpTool(
         audit(ctx, name, "ok", args);
         return textResult(result);
       }
-      case "read_repository_file": {
-        if (ctx.policy.profile !== "controller")
-          return errorResult(
-            "TOOL_DISABLED",
-            "read_repository_file requires the controller profile",
-          );
-        const path = String(args.path ?? "");
-        const session = ctx.sessionId && ctx.repoId
-          ? {
-            sessionId: ctx.sessionId,
-            repoId: ctx.repoId,
-            checkoutId: ctx.checkoutId ?? ctx.repoId,
-          }
-          : undefined;
-        const result = readRepositoryRange(
-          ctx.repoRoot,
-          ctx.policy,
-          path,
-          typeof args.start_line === "number" ? args.start_line : 1,
-          typeof args.end_line === "number" ? args.end_line : 200,
-          session,
-        );
-        const redacted = redactMcpText(result.content);
-        audit(ctx, name, "ok", args, result.path);
-        return textResult({
-          ...result,
-          content: redacted.text,
-          redactions: redacted.redactions,
-        });
-      }
       case "get_git_diff": {
         if (ctx.policy.profile !== "controller")
           return errorResult(
@@ -3640,84 +3526,6 @@ export async function callMcpTool(
         audit(ctx, name, "ok", args);
         return textResult({ checks });
       }
-      case "run_check": {
-        if (ctx.policy.profile !== "controller")
-          return errorResult(
-            "TOOL_DISABLED",
-            "run_check requires the controller profile",
-          );
-        // Prefer Unified Process Runtime for ordinary checks. Multi-phase and
-        // release checks require an explicit external Controller instead.
-        const checkId = String(args.check_id ?? "").trim();
-        const forceDurable = args.force_durable === true
-          || args.apply_mode === "async"
-          || args.mode === "durable";
-        if (!forceDurable && checkId) {
-          try {
-            const { checkRequiresDurableWorkflow, runCheckViaProcessRuntime } = await import(
-              "../../runtime/execution/process-runtime"
-            );
-            const { resolveRepoPreferredControllerHome } = await import("../repositories/controller-home");
-            const { resolveRepositorySelection } = await import("../repositories/registry");
-            if (!checkRequiresDurableWorkflow(checkId)) {
-              const controllerHome = resolveRepoPreferredControllerHome(ctx.repoRoot);
-              const repository = resolveRepositorySelection({
-                explicitPath: ctx.repoRoot,
-                controllerHome,
-                allowSoleRepository: true,
-              });
-              if (repository) {
-                const facade = await runCheckViaProcessRuntime({
-                  controllerHome,
-                  repoId: repository.repoId,
-                  checkoutId: repository.activeCheckoutId,
-                  repoRoot: repository.canonicalRoot,
-                  checkId,
-                  timeoutMs: typeof args.timeout_ms === "number" ? args.timeout_ms : undefined,
-                  requestId: typeof args.request_id === "string" ? args.request_id.trim() || undefined : undefined,
-                  executionIdentity: {
-                    schemaVersion: 1,
-                    repositoryId: repository.repoId,
-                    checkoutId: repository.activeCheckoutId,
-                    canonicalRoot: repository.canonicalRoot,
-                  },
-                });
-                if (facade.mode !== "durable" && facade.process) {
-                  audit(ctx, name, "ok", args);
-                  return textResult({
-                    mode: facade.mode,
-                    path: facade.mode === "direct" ? "process_direct" : "process_managed",
-                    checkId: facade.checkId,
-                    processId: facade.process.processId,
-                    status: facade.process.status,
-                    completed: facade.process.completed === true,
-                    ok: facade.process.ok,
-                    exitCode: facade.process.exitCode,
-                    timedOut: facade.process.timedOut,
-                    stdout: facade.process.stdout,
-                    stderr: facade.process.stderr,
-                    durableSideEffects: facade.durableSideEffects,
-                    next: facade.process.completed
-                      ? "Check finished on Process Runtime without LocalBridgeJob / ExecutionJob / Worker."
-                      : `Managed process ${facade.process.processId} still running; poll process_get / process_wait / process_logs.`,
-                  });
-                }
-              }
-            }
-          } catch (error) {
-            const message = error instanceof Error ? error.message : String(error);
-            const code = message.includes(":") ? message.slice(0, message.indexOf(":")) : "PROCESS_RUNTIME_FAILED";
-            audit(ctx, name, "failed", args, undefined, message);
-            return errorResult(code, message, { checkId });
-          }
-        }
-        audit(ctx, name, "blocked", args);
-        return errorResult(
-          "PROCESS_RUNTIME_REQUIRED",
-          "This check cannot create a Local Bridge Job. Run a registered ordinary check through Process Runtime or use external Controller handling for durable checks.",
-          { checkId },
-        );
-      }
       case "list_issues": {
         if (ctx.policy.profile !== "controller")
           return errorResult(
@@ -4506,11 +4314,6 @@ export async function callMcpTool(
         const checkIds = normalizedChecks.validCheckIds;
         const checkResults: TaskVerification['checkResults'] = [];
         if (checkIds.length > 0) {
-          const { resolveRepositorySelection } = await import('../repositories/registry');
-          const { executionIdentityForRepository } = await import('../../runtime/control-plane/execution/execution-identity');
-          const { runPersistedCheckViaProcessRuntime } = await import('../../runtime/gateway/mcp/persisted-check-process');
-          const { getProcessRecord } = await import('../../runtime/execution/process-runtime/store');
-          const { processCheckCompletionReceipt } = await import('../../runtime/execution/process-runtime/check-receipt');
           const controllerHome = resolveRepoPreferredControllerHome(ctx.repoRoot);
           const repository = resolveRepositorySelection({
             explicitPath: ctx.repoRoot,
@@ -4767,7 +4570,7 @@ export async function callMcpTool(
         const existingWork = getWorkContract(workStore, workId);
         if (requestedWorkId && !existingWork) return errorResult("WORK_NOT_FOUND", `WorkContract ${workId} not found`);
         if (!existingWork) {
-          createWorkContract(workStore, {
+          admitDirectEditWorkContract(workStore, {
             workId,
             repoId,
             checkoutId: identity.checkoutId,
@@ -4775,28 +4578,13 @@ export async function callMcpTool(
             controllerInstanceId: identity.controllerInstanceId,
             baseRevision: git.head ?? undefined,
             workspaceFingerprint: workspaceIdentity,
-            routeDecisionFingerprint: routeDecision.inputFingerprint,
             routeDecision,
-            mode: "direct_control",
             objective: purpose,
-            acceptanceCriteria: [],
-            constraints: { workspaceMode: "current", requireWorktree: false, requireHandoffOnAmbiguity: true },
-            risk: "low",
-            status: "running",
-            phase: "implementation",
             issueId: typeof args.issue_id === "string" ? args.issue_id : undefined,
             taskId: typeof args.task_id === "string" ? args.task_id : undefined,
-            scopeSummary: purpose,
             allowedPaths,
-            forbiddenPaths: [],
             checks,
             requestedBy: "chatgpt",
-            evidenceRefs: [],
-            handoffRefs: [],
-            suggestedNextActions: [],
-            policyDecisions: [],
-            checkRefs: [],
-            reconciliations: [],
           });
         }
         const session = beginEditSession(ctx.repoRoot, {

package/src/cli/mcp/multi-repository.ts

@@ -87,8 +87,8 @@ export function parseMcpToolset(value: unknown, profile: string): McpToolset {
   if (profile !== 'controller') return 'full';
   const normalized = typeof value === 'string' ? value.trim().toLowerCase() : '';
   if (!normalized) return 'advanced';
-  if (normalized === 'core' || normalized === 'advanced' || normalized === 'full') return normalized;
-  throw new Error(`invalid MCP toolset "${String(value)}" (expected: core, advanced, or full)`);
+  if (normalized === 'facade' || normalized === 'core' || normalized === 'advanced' || normalized === 'full') return normalized;
+  throw new Error(`invalid MCP toolset "${String(value)}" (expected: facade, core, advanced, or full)`);
 }
 
 function repositoryForExplicitPath(path: string, controllerHome: string): RepositoryRecord | undefined {
@@ -295,13 +295,24 @@ export function repositoryScopedToolArgs(
   input: Record<string, unknown>,
   repository: RepositoryRecord,
 ): Record<string, unknown> {
-  // Preserve resolved repository/checkout identity for every downstream call.
-  // Deleting these fields forced re-resolution and allowed silent route drift.
+  // Preserve resolved repository identity for every downstream call. Exact
+  // claimed Work calls are the one exception for checkout injection: when the
+  // caller omitted checkout_id, repository tools must resolve the Work-owned
+  // checkout after validating the authenticated principal instead of inheriting
+  // the repository's currently active checkout.
+  const workOwnedCheckoutResolution = [
+    'repository_command_preview',
+    'repository_command_execute',
+    'repository_safe_patch_apply',
+  ].includes(name)
+    && typeof input.work_id === 'string'
+    && input.work_id.trim().length > 0
+    && !(typeof input.checkout_id === 'string' && input.checkout_id.trim().length > 0);
   const args: Record<string, unknown> = {
     ...input,
     repo_id: repository.repoId,
-    checkout_id: repository.activeCheckoutId,
   };
+  if (!workOwnedCheckoutResolution) args.checkout_id = repository.activeCheckoutId;
 
   const github = repository.github;
   const githubRepo = github ? `${github.owner}/${github.repo}` : undefined;