@moretea-labs/forge 1.6.0 → 1.7.0

package/scripts/new-plan.sh

@@ -141,7 +141,7 @@ Complete this inventory before implementation. If any line is unknown, keep the
 
 - **State/progress path**:
 - **Verification evidence**:
-- **Evaluator rubric**:
+- **Impact review**:
 - **Stop condition**:
 - **Rollback surface**:
 

package/scripts/plan-to-todo.sh

@@ -63,7 +63,7 @@ plan_evidence_contract_error() {
   fi
 
   local label line value
-  for label in "State/progress path" "Verification evidence" "Evaluator rubric" "Stop condition" "Rollback surface"; do
+  for label in "State/progress path" "Verification evidence" "Impact review|Evaluator rubric" "Stop condition" "Rollback surface"; do
     line="$(printf '%s\n' "$section" | grep -Ei "^[[:space:]]*-[[:space:]]*(\\*\\*)?${label}(\\*\\*)?[[:space:]]*:" | head -1 || true)"
     if [[ -z "$line" ]]; then
       echo "missing field: ${label}"
@@ -323,7 +323,7 @@ Describe the exact outcome this task must deliver.
 - Checks file: `.ai/harness/checks/latest.json`
 - Run snapshots: `.ai/harness/runs/`
 - Scope gate: edit only paths listed under `allowed_paths`; update this contract before widening scope.
-- Completion gate: `scripts/verify-sprint.sh` must see this contract pass, the review recommend pass, and `## External Acceptance Advice` pass or record a manual override.
+- Completion evidence: `scripts/verify-sprint.sh` reports this contract's direct checks and declared scope. Then perform a fresh semantic impact review.
 
 ## Allowed Paths
 
@@ -691,19 +691,15 @@ else
 > **Notes File**: {{NOTES_FILE}}
 > **Checks File**: {{CHECKS_FILE}}
 > **Last Updated**: {{TIMESTAMP}}
-> **Recommendation**: fail
+> **Summary**:
 
-## Human Review Card
+## Semantic Impact Review
 
-- Verdict: pending
-- Change type: code-change | docs-only | ledger-closeout | migration | eval-only | delegated-run
-- Intended files changed:
-- Actual files changed:
-- Commands passed:
-- External acceptance: unavailable
-- Residual risks:
-- Reviewer action required: inspect diff and card
-- Rollback:
+- User intent:
+- Affected domains and downstream consumers:
+- State transitions and persistence/restart impact:
+- Missing impact areas or uncertainty:
+- Residual risks and recovery:
 
 ## Mode Evidence
 
@@ -713,26 +709,14 @@ else
 
 ## Verification Evidence
 
-- Forge /review run:
+- Focused/full checks:
 - Commands run:
 - Manual checks:
 - Supporting artifacts:
 - Implementation notes reviewed:
 - Run snapshot:
 
-## External Acceptance Advice
-
-> **External Acceptance**: unavailable
-> **External Reviewer**:
-> **External Source**:
-> **External Started**:
-> **External Completed**:
-
-- P1 blockers:
-- P2 advisories:
-- Acceptance checklist:
-
-## Behavior Diff Notes
+## Scenario Evidence
 
 - ...
 
@@ -740,15 +724,6 @@ else
 
 - ...
 
-## Scorecard
-
-| Dimension | Score | Notes |
-|-----------|-------|-------|
-| Functionality | 0/10 | |
-| Product depth | 0/10 | |
-| Design quality | 0/10 | |
-| Code quality | 0/10 | |
-
 ## Failing Items
 
 - ...

package/scripts/run-governed-gate.ts

@@ -17,11 +17,12 @@ export function stepsFor(gate: Gate): Step[] {
   if (gate === 'task') return [
     { label: 'typecheck', command: 'bun', args: ['run', 'check:type'], timeoutMs: 10 * 60_000 },
     { label: 'static architecture', command: 'bun', args: ['run', 'check:runtime-architecture'], timeoutMs: 5 * 60_000 },
-    { label: 'test budget', command: 'bun', args: ['run', 'check:test-governance'], timeoutMs: 5 * 60_000 },
+    { label: 'test manifest', command: 'bun', args: ['run', 'check:test-governance'], timeoutMs: 5 * 60_000 },
     { label: 'affected tests', command: 'bun', args: ['run', 'test'], timeoutMs: 30 * 60_000 },
   ];
   if (gate === 'main') return [
     { label: 'focused task receipt', gate: 'task' },
+    { label: 'core regression', command: 'bun', args: ['run', 'test:core'], timeoutMs: 20 * 60_000 },
     { label: 'runtime smoke', command: 'bun', args: ['run', 'check:smoke'], timeoutMs: 10 * 60_000 },
   ];
   return [

package/scripts/ship-worktrees.sh

@@ -224,19 +224,8 @@ active_slug_or_empty() {
   plan_slug_from_path "$active_plan"
 }
 
-review_recommends_pass_fallback() {
-  local review_file="$1"
-  grep -Eq '^> \*\*Recommendation\*\*:[[:space:]]*pass([[:space:]]*)$' "$review_file"
-}
-
-external_acceptance_pass_fallback() {
-  local review_file="$1"
-  grep -Eq '^> \*\*External Acceptance\*\*:[[:space:]]*(pass|manual_override)([[:space:]]*)$' "$review_file" \
-    && grep -Eq '^-?[[:space:]]*P1 blockers:[[:space:]]*none([[:space:]]*)$' "$review_file"
-}
-
 require_finish_ready() {
-  local contract_file="" review_file="" checks_file=".ai/harness/checks/latest.json" checks_error=""
+  local contract_file="" checks_file=".ai/harness/checks/latest.json" checks_error=""
 
   [[ -x "scripts/contract-worktree.sh" ]] || fail "scripts/contract-worktree.sh is missing or not executable"
   [[ -x "scripts/verify-sprint.sh" ]] || fail "scripts/verify-sprint.sh is missing or not executable"
@@ -245,27 +234,11 @@ require_finish_ready() {
   if declare -F workflow_active_contract >/dev/null 2>&1; then
     contract_file="$(workflow_active_contract 2>/dev/null || true)"
   fi
-  if declare -F workflow_active_review >/dev/null 2>&1; then
-    review_file="$(workflow_active_review 2>/dev/null || true)"
-  fi
   if declare -F workflow_checks_file >/dev/null 2>&1; then
     checks_file="$(workflow_checks_file)"
   fi
 
   [[ -n "$contract_file" && -f "$contract_file" ]] || fail "active sprint contract is missing"
-  [[ -n "$review_file" && -f "$review_file" ]] || fail "active sprint review is missing"
-
-  if declare -F workflow_review_recommends_pass >/dev/null 2>&1; then
-    workflow_review_recommends_pass "$review_file" || fail "$review_file does not recommend pass"
-  else
-    review_recommends_pass_fallback "$review_file" || fail "$review_file does not recommend pass"
-  fi
-
-  if declare -F workflow_external_acceptance_pass >/dev/null 2>&1; then
-    workflow_external_acceptance_pass "$review_file" || fail "$review_file has no passing external acceptance"
-  else
-    external_acceptance_pass_fallback "$review_file" || fail "$review_file has no passing external acceptance"
-  fi
 
   run_cmd bash "scripts/verify-sprint.sh"
   if [[ "$DRY_RUN" -eq 1 ]]; then
@@ -273,7 +246,7 @@ require_finish_ready() {
   fi
 
   if declare -F workflow_checks_pass >/dev/null 2>&1; then
-    if ! checks_error="$(workflow_checks_pass "$checks_file" "$contract_file" "$review_file")"; then
+    if ! checks_error="$(workflow_checks_pass "$checks_file" "$contract_file")"; then
       fail "$checks_error"
     fi
   elif ! grep -Eq '"status"[[:space:]]*:[[:space:]]*"pass"' "$checks_file"; then

package/scripts/smoke-ios-physical-device.ts

@@ -24,7 +24,6 @@ if (!/^[A-Za-z0-9][A-Za-z0-9.-]+$/.test(bundleId) || !bundleId.includes('.') ||
   throw new Error('FORGE_IOS_DEVICE_SMOKE_BUNDLE_ID must be an exact bundle identifier, not a URL or deep link.');
 }
 
-delete process.env.FORGE_IOS_DEVICE_RUNNER_URL;
 
 const common = {
   controllerHome,
@@ -51,6 +50,7 @@ try {
     entry.identifier === deviceSelector || entry.udid === deviceSelector || entry.name === deviceSelector);
   if (matches.length !== 1) throw new Error(`Expected exactly one physical iPhone for selector ${deviceSelector}; found ${matches.length}.`);
   const device = matches[0]!;
+  const info = await invoke('physical_device_info', { device: device.identifier });
   const apps = await invoke('physical_device_apps', { device: device.identifier, bundle_id: bundleId });
   const installed = Array.isArray(apps.apps) ? apps.apps as Array<Record<string, unknown>> : [];
   if (installed.length !== 1) throw new Error(`The exact bundle identifier ${bundleId} is not installed on the selected iPhone.`);
@@ -97,7 +97,9 @@ try {
       version: app.version,
     },
     launchStatus: interaction?.status,
-    uiAutomation: opened.uiAutomation,
+    controlPlane: opened.controlPlane,
+    coreDeviceCapabilities: info.capabilities,
+    screenViewingURLAvailable: typeof info.screenViewingURL === 'string',
     screenshot: {
       created: true,
       width: width ? Number(width) : undefined,

package/scripts/smoke-runtime-recovery.ts

@@ -25,8 +25,6 @@ import {
 } from '../src/runtime/execution/process-runtime';
 import { executionIdentityForRepository } from '../src/runtime/control-plane/execution/execution-identity';
 import { createSchedule } from '../src/runtime/workflow/schedules/store';
-import { createPortfolioWorkflow } from '../src/runtime/workflow/portfolio/store';
-import { recordCandidateFinding } from '../src/runtime/workflow/findings/store';
 import { assertAutomatedOperationAllowed } from '../src/runtime/control-plane/governance/external-effects';
 
 const root = mkdtempSync(join(tmpdir(), 'forge-recovery-smoke-'));
@@ -169,38 +167,9 @@ try {
   const scheduleB = createSchedule(controllerHome, scheduleInput);
   assert(scheduleA.scheduleId === scheduleB.scheduleId, 'Schedule requestId was not idempotent');
 
-  const portfolioInput = {
-    name: 'portfolio-idempotency', requestId: 'portfolio-idempotency', failurePolicy: 'stop' as const,
-    steps: [{ stepId: 'one', repoId: repository.repoId, operation: 'controller_context', dependsOn: [], priority: 'P2' as const, resourceClaims: [], status: 'pending' as const }],
-  };
-  const portfolioA = createPortfolioWorkflow(controllerHome, portfolioInput);
-  const portfolioB = createPortfolioWorkflow(controllerHome, portfolioInput);
-  assert(portfolioA.workflowId === portfolioB.workflowId, 'Portfolio requestId was not idempotent');
-
-  const candidateA = recordCandidateFinding(controllerHome, {
-    repoId: repository.repoId, requestId: 'candidate-observation-1', semanticKey: 'frequent-502:mcp-timeout',
-    title: 'Frequent MCP 502', summary: 'Observed during bounded triage.', evidence: { source: 'schedule', reference: 'OCC-1' },
-  });
-  const candidateB = recordCandidateFinding(controllerHome, {
-    repoId: repository.repoId, requestId: 'candidate-observation-2', semanticKey: 'frequent-502:mcp-timeout',
-    title: 'Frequent MCP 502', summary: 'Observed again.', evidence: { source: 'schedule', reference: 'OCC-2' },
-  });
-  assert(candidateA.findingId === candidateB.findingId && candidateB.observationCount === 2, 'candidate finding was not deduplicated');
   let automaticIssueBlocked = false;
   try { assertAutomatedOperationAllowed('create_issue'); } catch { automaticIssueBlocked = true; }
-  assert(automaticIssueBlocked, 'Schedule/Portfolio could create an Issue without candidate promotion');
-
-  let cycleRejected = false;
-  try {
-    createPortfolioWorkflow(controllerHome, {
-      name: 'cycle', requestId: 'portfolio-cycle', failurePolicy: 'stop',
-      steps: [
-        { stepId: 'a', repoId: repository.repoId, operation: 'controller_context', dependsOn: ['b'], priority: 'P2', resourceClaims: [], status: 'pending' },
-        { stepId: 'b', repoId: repository.repoId, operation: 'controller_context', dependsOn: ['a'], priority: 'P2', resourceClaims: [], status: 'pending' },
-      ],
-    });
-  } catch { cycleRejected = true; }
-  assert(cycleRejected, 'Portfolio dependency cycle was accepted');
+  assert(automaticIssueBlocked, 'Kernel automation could create an Issue without an explicit external-effect path');
 
   console.log(JSON.stringify({
     status: 'ok',
@@ -208,10 +177,7 @@ try {
     processRecovered,
     replacementController: replacement.controllerId,
     scheduleId: scheduleA.scheduleId,
-    portfolioWorkflowId: portfolioA.workflowId,
-    candidateFindingDeduplicated: candidateB.observationCount,
     automaticIssueBlocked,
-    portfolioCycleRejected: cycleRejected,
     executionJobCount: listExecutionJobs(controllerHome, repository.repoId, 20).length,
   }, null, 2));
 } finally {

package/scripts/smoke-schedule-engine.ts

@@ -6,7 +6,6 @@ import { registerRepository } from '../src/cli/repositories/registry';
 import { listHandoffItems } from '../src/runtime/control-plane/facade/handoff-inbox-store';
 import { listExecutionJobs } from '../src/runtime/execution/jobs/store';
 import { evaluateSchedule } from '../src/runtime/workflow/schedules/engine';
-import { recordCandidateFinding } from '../src/runtime/workflow/findings/store';
 import { createSchedule, getSchedule, getScheduleDecision } from '../src/runtime/workflow/schedules/store';
 
 const root = mkdtempSync(join(tmpdir(), 'forge-schedule-smoke-'));
@@ -119,20 +118,6 @@ try {
     'missing historical dependency checkpoint fired',
   );
 
-  recordCandidateFinding(controllerHome, {
-    repoId: repository.repoId,
-    requestId: 'schedule-candidate-1',
-    semanticKey: 'schedule:condition',
-    title: 'Condition finding',
-    evidence: { source: 'smoke' },
-  });
-  recordCandidateFinding(controllerHome, {
-    repoId: repository.repoId,
-    requestId: 'schedule-candidate-2',
-    semanticKey: 'schedule:condition',
-    title: 'Condition finding',
-    evidence: { source: 'smoke' },
-  });
   const conditionSchedule = createSchedule(controllerHome, {
     ...semanticBase,
     requestId: 'schedule-condition',
@@ -140,11 +125,7 @@ try {
     trigger: {
       type: 'condition',
       everyMinutes: 1,
-      condition: {
-        kind: 'candidate_observation_threshold',
-        semanticKey: 'schedule:condition',
-        observationThreshold: 2,
-      },
+      condition: { kind: 'repository_clean' },
     },
   });
   const conditionOccurrence = await evaluateSchedule(controllerHome, conditionSchedule);

package/scripts/verify-contract.sh

@@ -69,24 +69,6 @@ read_contract_status() {
   awk '/^> \*\*Status\*\*:/ {sub(/^.*> \*\*Status\*\*: */, ""); gsub(/\r/, ""); print; exit}' "$file" | xargs
 }
 
-read_contract_review_file() {
-  local file="$1"
-  local line=""
-  local value=""
-
-  line="$(grep -m 1 -E '^> \*\*Review File\*\*:' "$file" || true)"
-  [[ -n "$line" ]] || return 0
-
-  if [[ "$line" == *\`* ]]; then
-    value="${line#*\`}"
-    value="${value%%\`*}"
-  else
-    value="${line#*> **Review File**:}"
-  fi
-
-  printf '%s' "$value" | tr -d '\r' | sed -E 's/^[[:space:]]+//; s/[[:space:]]+$//'
-}
-
 read_contract_task_profile() {
   local file="$1"
   awk '/^> \*\*Task Profile\*\*:/ {sub(/^.*> \*\*Task Profile\*\*:[[:space:]]*/, ""); gsub(/\r/, ""); print; exit}' "$file" | xargs
@@ -130,36 +112,6 @@ contract_allowed_paths() {
   '
 }
 
-review_recommends_pass() {
-  local review_file="$1"
-  [[ -n "$review_file" && -f "$review_file" ]] || return 1
-  grep -Eq '^> \*\*Recommendation\*\*:[[:space:]]*pass[[:space:]]*$' "$review_file"
-}
-
-review_score() {
-  local review_file="$1"
-  local dimension="$2"
-
-  [[ -n "$review_file" && -f "$review_file" ]] || return 1
-
-  awk -F'|' -v wanted="$dimension" '
-    function trim(s) {
-      gsub(/^[[:space:]]+/, "", s)
-      gsub(/[[:space:]]+$/, "", s)
-      return s
-    }
-    BEGIN { wanted = tolower(wanted) }
-    /^\|/ {
-      dim = tolower(trim($2))
-      score = trim($3)
-      if (dim == wanted && match(score, /[0-9]+/)) {
-        print substr(score, RSTART, RLENGTH)
-        exit
-      }
-    }
-  ' "$review_file"
-}
-
 update_contract_status() {
   local file="$1"
   local status="$2"
@@ -385,14 +337,9 @@ declare -a contain_patterns=()
 declare -a files_not_exist=()
 declare -a not_contain_paths=()
 declare -a not_contain_patterns=()
-declare -a qa_dimensions=()
-declare -a qa_mins=()
-declare -a manual_checks=()
 
 section=""
 pending_path=""
-pending_dimension=""
-review_file="$(read_contract_review_file "$contract_file" || true)"
 task_profile="$(read_contract_task_profile "$contract_file" || true)"
 declare -a allowed_paths=()
 while IFS= read -r allowed_path; do
@@ -443,21 +390,10 @@ while IFS= read -r raw_line; do
       pending_path=""
       continue
       ;;
-    qa_scores:)
-      section="qa_scores"
-      pending_path=""
-      pending_dimension=""
-      continue
-      ;;
-    manual_checks:)
-      section="manual_checks"
-      pending_path=""
-      continue
-      ;;
   esac
 
   case "$section" in
-    files_exist|commands_succeed|files_not_exist|artifacts_exist|manual_checks)
+    files_exist|commands_succeed|files_not_exist|artifacts_exist)
       if [[ "$trimmed" =~ ^-[[:space:]]*(.+)$ ]]; then
         item="$(strip_quotes "${BASH_REMATCH[1]}")"
         [[ -n "$item" ]] || continue
@@ -467,8 +403,6 @@ while IFS= read -r raw_line; do
           commands_succeed+=("$item")
         elif [[ "$section" == "artifacts_exist" ]]; then
           artifacts_exist+=("$item")
-        elif [[ "$section" == "manual_checks" ]]; then
-          manual_checks+=("$item")
         else
           files_not_exist+=("$item")
         fi
@@ -497,19 +431,6 @@ while IFS= read -r raw_line; do
         fi
       fi
       ;;
-    qa_scores)
-      if [[ "$trimmed" =~ ^-[[:space:]]*dimension:[[:space:]]*(.+)$ ]]; then
-        pending_dimension="$(strip_quotes "${BASH_REMATCH[1]}")"
-      elif [[ "$trimmed" =~ ^dimension:[[:space:]]*(.+)$ ]]; then
-        pending_dimension="$(strip_quotes "${BASH_REMATCH[1]}")"
-      elif [[ "$trimmed" =~ ^min:[[:space:]]*([0-9]+)$ ]]; then
-        if [[ -n "$pending_dimension" ]]; then
-          qa_dimensions+=("$pending_dimension")
-          qa_mins+=("${BASH_REMATCH[1]}")
-          pending_dimension=""
-        fi
-      fi
-      ;;
   esac
 done <<< "$yaml_block"
 if ((${#tests_pass[@]} || ${#commands_succeed[@]})); then
@@ -602,37 +523,6 @@ if ((${#commands_succeed[@]})); then
   done
 fi
 
-if ((${#qa_dimensions[@]})); then
-  for idx in "${!qa_dimensions[@]}"; do
-    dimension="${qa_dimensions[$idx]}"
-    min_score="${qa_mins[$idx]}"
-    score="$(review_score "$review_file" "$dimension" || true)"
-
-    if [[ "$score" =~ ^[0-9]+$ && "$score" -ge "$min_score" ]]; then
-      pass "qa_scores" "$dimension" "qa_scores: $dimension ${score}/${min_score}"
-    else
-      fail "qa_scores" "$dimension" "qa_scores: $dimension score ${score:-missing} < $min_score"
-    fi
-  done
-fi
-
-if ((${#manual_checks[@]})); then
-  for check in "${manual_checks[@]}"; do
-    case "$check" in
-      "Evaluator review file recommends pass")
-        if review_recommends_pass "$review_file"; then
-          pass "manual_checks" "$check" "manual_checks: $check"
-        else
-          fail "manual_checks" "$check" "manual_checks: $check"
-        fi
-        ;;
-      *)
-        fail "manual_checks" "$check" "manual_checks unsupported: $check"
-        ;;
-    esac
-  done
-fi
-
 if ((${#contain_paths[@]})); then
   for idx in "${!contain_paths[@]}"; do
     path="${contain_paths[$idx]}"

package/scripts/verify-forge-runtime.sh

@@ -13,7 +13,6 @@ TEST_FILES=(
   "tests/runtime/facade-contracts.test.ts"
   "tests/runtime/route-policy.test.ts"
   "tests/runtime/forge-runtime-service.test.ts"
-  "tests/cli/mcp-controller.test.ts"
   "tests/cli/local-bridge.test.ts"
   "tests/runtime/thin-harness-gateway-routing.test.ts"
   "tests/runtime/runtime-observability.test.ts"