@moreapp/common-nodejs 0.10.2 → 0.10.6

package/dist/MoreAppClient.d.ts

@@ -15,7 +15,7 @@ export default class MoreAppClient {
     constructor(options: Options);
     getBinary(path: string): Promise<BinaryFile>;
     get<T>(path: string): Promise<T>;
-    post<T>(path: string, payload: Record<string, any>): Promise<T>;
-    delete(path: string): Promise<any>;
+    post<T>(path: string, payload: Record<string, unknown>): Promise<T>;
+    delete(path: string): Promise<unknown>;
 }
 export {};

package/dist/MoreAppClient.js

@@ -5,6 +5,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", { value: true });
 const axios_1 = __importDefault(require("axios"));
 const content_disposition_parser_1 = __importDefault(require("content-disposition-parser"));
+const lodash_1 = require("lodash");
 class MoreAppClient {
     client;
     constructor(options) {
@@ -49,7 +50,11 @@ class MoreAppClient {
 }
 exports.default = MoreAppClient;
 function getFilename(res) {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const contentDispositionHeader = res.headers["content-disposition"];
+    if (!(0, lodash_1.isString)(contentDispositionHeader)) {
+        return undefined;
+    }
     const filename = (0, content_disposition_parser_1.default)(contentDispositionHeader)?.filename;
     return filename ? decodeURI(filename) : undefined;
 }

package/dist/MoreAppClient.test.js

@@ -3,9 +3,9 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-const MoreAppClient_1 = __importDefault(require("./MoreAppClient"));
 const nock_1 = __importDefault(require("nock"));
 const axios_1 = require("axios");
+const MoreAppClient_1 = __importDefault(require("./MoreAppClient"));
 test("download binary file", async () => {
     const file = Buffer.from("Some data");
     const apiMock = (0, nock_1.default)("https://api.moreapp.com")

package/dist/dateUtil.test.js

@@ -2,22 +2,22 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const dateUtil_1 = require("./dateUtil");
 describe("isDate", () => {
-    test("should handle valid dates", async () => {
+    test("should handle valid dates", () => {
         expect((0, dateUtil_1.isDate)("2020-01-01")).toBe(true);
         expect((0, dateUtil_1.isDate)("2020-1-1")).toBe(true);
         expect((0, dateUtil_1.isDate)("0000-1-1")).toBe(true);
     });
-    test("should handle invalid dates", async () => {
+    test("should handle invalid dates", () => {
         expect((0, dateUtil_1.isDate)("not-a-date")).toBe(false);
         expect((0, dateUtil_1.isDate)("3039-20-01")).toBe(false);
     });
 });
 describe("isDateTime", () => {
-    test("should handle valid date times", async () => {
+    test("should handle valid date times", () => {
         expect((0, dateUtil_1.isDateTime)("2020-01-01 12:00")).toBe(true);
         expect((0, dateUtil_1.isDateTime)("2020-01-01 0:00")).toBe(true);
     });
-    test("should handle invalid date times", async () => {
+    test("should handle invalid date times", () => {
         expect((0, dateUtil_1.isDateTime)("2020-01-01 0:99")).toBe(false);
         expect((0, dateUtil_1.isDateTime)("2020-01-01 25:12")).toBe(false);
     });

package/dist/logger.test.js

@@ -2,7 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const logger_1 = require("./logger");
 describe("errorFormat", () => {
-    test("should format standard errors", async () => {
+    test("should format standard errors", () => {
         const error = new Error("Failed to persist");
         const formatted = logger_1.formatters
             .errorFormat()
@@ -16,7 +16,7 @@ describe("errorFormat", () => {
             },
         });
     });
-    test("should format error with (deeply nested) cause", async () => {
+    test("should format error with (deeply nested) cause", () => {
         const error = new Error("Failed to persist", {
             cause: new Error("Caused by me!", { cause: "Well actually..." }),
         });
@@ -41,7 +41,7 @@ describe("errorFormat", () => {
     });
 });
 describe("tracingFormat", () => {
-    test("should transform tracing data to Stackdriver format", async () => {
+    test("should transform tracing data to Stackdriver format", () => {
         const formatted = logger_1.formatters.stackdriverTracingFormat().transform({
             level: "error",
             message: "Something went wrong",

package/dist/observability/ExpressRequestTracker.test.js

@@ -3,8 +3,8 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-const ExpressRequestTracker_1 = __importDefault(require("./ExpressRequestTracker"));
 const node_events_1 = require("node:events");
+const ExpressRequestTracker_1 = __importDefault(require("./ExpressRequestTracker"));
 // Create a minimal Response mock that can emit the 'finish' event
 const createMockResponse = () => {
     const emitter = new node_events_1.EventEmitter();

package/dist/observability/ObservabilityServer.js

@@ -16,25 +16,27 @@ class ObservabilityServer {
         this.requestTracker = requestTracker;
         this.options = options;
         prom_client_1.default.collectDefaultMetrics();
-        this.server = node_http_1.default.createServer(async (req, res) => {
+        this.server = node_http_1.default.createServer((req, res) => {
             if (req.url === "/live") {
                 res.writeHead(200, { "Content-Type": "application/json" });
-                return res.end(JSON.stringify({ status: "ok" }));
+                res.end(JSON.stringify({ status: "ok" }));
             }
             else if (req.url === "/ready") {
                 res.writeHead(this.isReady ? 200 : 503, { "Content-Type": "application/json" });
-                return res.end(JSON.stringify({
+                res.end(JSON.stringify({
                     status: this.isReady ? "ok" : "not ready",
                     activeRequests: this.requestTracker.nrOfActiveRequests(),
                 }));
             }
             else if (req.url === "/metrics") {
-                res.setHeader("Content-Type", prom_client_1.default.register.contentType);
-                return res.end(await prom_client_1.default.register.metrics());
+                void prom_client_1.default.register.metrics().then((metrics) => {
+                    res.setHeader("Content-Type", prom_client_1.default.register.contentType);
+                    res.end(metrics);
+                });
             }
             else {
                 res.statusCode = 404;
-                return res.end();
+                res.end();
             }
         });
     }

package/dist/observability/ObservabilityServer.test.js

@@ -56,7 +56,9 @@ describe("ObservabilityServer", () => {
             capturedHandler = handler;
             return fakeServer;
         });
-        const requestTracker = { nrOfActiveRequests: jest.fn(() => 0) };
+        const requestTracker = {
+            nrOfActiveRequests: jest.fn(() => 0),
+        };
         const hs = await ObservabilityServer_1.default.create(requestTracker, { port: 0 });
         expect(fakeServer.listen).toHaveBeenCalled();
         // /live

package/dist/observability/TerminationHandler.d.ts

@@ -1,6 +1,6 @@
+import { Server } from "node:http";
 import ExpressRequestTracker from "./ExpressRequestTracker";
 import ObservabilityServer from "./ObservabilityServer";
-import { Server } from "node:http";
 export default class TerminationHandler {
     private readonly server;
     private readonly hs;

package/dist/observability/TerminationHandler.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const logger_1 = require("../logger");
 const node_timers_1 = require("node:timers");
+const logger_1 = require("../logger");
 const TERMINATION_SIGNALS = ["SIGTERM", "SIGHUP", "SIGINT"];
 const SHUTDOWN_TIMEOUT = 30_000;
 class TerminationHandler {
@@ -34,7 +34,7 @@ class TerminationHandler {
                 (0, node_timers_1.clearInterval)(interval);
                 // Destroy any remaining sockets
                 this.sockets.forEach((socket) => socket.destroy());
-                this.hs.stop().finally(() => {
+                void this.hs.stop().finally(() => {
                     logger_1.logger.info("Server stopped");
                     process.exit(0);
                 });

package/dist/observability/TerminationHandler.test.js

@@ -39,14 +39,14 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const testUtils_1 = require("../testUtils");
 (0, testUtils_1.silenceLogger)();
 const node_events_1 = require("node:events");
+const timers = __importStar(require("node:timers"));
+const TerminationHandler_1 = __importDefault(require("./TerminationHandler"));
 // Mock node:timers so we can control callbacks (TerminationHandler imports from node:timers)
 jest.mock("node:timers", () => ({
     setInterval: jest.fn(),
     clearInterval: jest.fn(),
     setTimeout: jest.fn(),
 }));
-const timers = __importStar(require("node:timers"));
-const TerminationHandler_1 = __importDefault(require("./TerminationHandler"));
 describe("TerminationHandler", () => {
     let intervalCb;
     let timeoutCb;
@@ -58,10 +58,7 @@ describe("TerminationHandler", () => {
             return 1;
         });
         timers.clearInterval.mockImplementation(() => { });
-        jest
-            .spyOn(globalThis, "setTimeout")
-            // @ts-ignore simplify types for test
-            .mockImplementation((cb) => {
+        jest.spyOn(globalThis, "setTimeout").mockImplementation((cb) => {
             timeoutCb = cb;
             return 2;
         });
@@ -91,7 +88,7 @@ describe("TerminationHandler", () => {
         socket.destroy = jest.fn();
         return socket;
     };
-    test("shutdown waits for active requests to reach 0 then stops and exits 0", async () => {
+    test("shutdown waits for active requests to reach 0 then stops and exits 0", () => {
         const server = createFakeServer();
         const hs = {
             setReady: jest.fn(),
@@ -103,10 +100,7 @@ describe("TerminationHandler", () => {
             })),
         };
         const requestTracker = { nrOfActiveRequests: jest.fn(() => 0) };
-        const exitSpy = jest
-            .spyOn(process, "exit")
-            // never return to process
-            .mockImplementation(((..._args) => undefined));
+        const exitSpy = jest.spyOn(process, "exit").mockImplementation(() => undefined);
         const th = new TerminationHandler_1.default(server, hs, requestTracker);
         th.shutdown();
         expect(hs.setReady).toHaveBeenCalledWith(false);
@@ -117,7 +111,7 @@ describe("TerminationHandler", () => {
         expect(hs.stop).toHaveBeenCalled();
         expect(exitSpy).toHaveBeenCalledWith(0);
     });
-    test("shutdown polls until requests finish then exits 0", async () => {
+    test("shutdown polls until requests finish then exits 0", () => {
         const server = createFakeServer();
         const hs = {
             setReady: jest.fn(),
@@ -131,9 +125,7 @@ describe("TerminationHandler", () => {
         const requestTracker = { nrOfActiveRequests: jest.fn() };
         // Return >0 first, then 0
         requestTracker.nrOfActiveRequests.mockReturnValueOnce(2).mockReturnValueOnce(0);
-        const exitSpy = jest
-            .spyOn(process, "exit")
-            .mockImplementation(((..._args) => undefined));
+        const exitSpy = jest.spyOn(process, "exit").mockImplementation(() => undefined);
         const th = new TerminationHandler_1.default(server, hs, requestTracker);
         th.shutdown();
         // First tick: still waiting
@@ -146,11 +138,12 @@ describe("TerminationHandler", () => {
     });
     test("forceful stop after 30s destroys sockets and exits 1", () => {
         const server = createFakeServer();
-        const hs = { setReady: jest.fn(), stop: jest.fn(() => Promise.resolve()) };
+        const hs = {
+            setReady: jest.fn(),
+            stop: jest.fn(() => Promise.resolve()),
+        };
         const requestTracker = { nrOfActiveRequests: jest.fn(() => 5) }; // never reaches 0
-        const exitSpy = jest
-            .spyOn(process, "exit")
-            .mockImplementation(((..._args) => undefined));
+        const exitSpy = jest.spyOn(process, "exit").mockImplementation(() => undefined);
         const th = new TerminationHandler_1.default(server, hs, requestTracker);
         // Register a socket via the server's connection event
         const socket = createSocket();

package/dist/testUtils.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.silenceLogger = void 0;
-// Utility to silence logger output in tests, must be at the top of the test file
+// Utility to silence logger output in tests must be at the top of the test file
 const silenceLogger = () => jest.mock("./logger", () => ({
     logger: {
         info: jest.fn(),

package/dist/types.d.ts

@@ -7,7 +7,7 @@ export type IntegrationTestResponse = {
 } | {
     status: "INVALID";
     globalError: string;
-    fieldErrors?: Record<string, any>;
+    fieldErrors?: Record<string, unknown>;
 };
 export type IntegrationHandleResponse = {
     status: "SUCCESS";
@@ -16,7 +16,7 @@ export type IntegrationHandleResponse = {
         name: string;
         data: string;
     }[];
-    data?: Record<string, any>;
+    data?: Record<string, unknown>;
 } | {
     status: "ERROR";
     message: string;

package/dist/utils.d.ts

@@ -6,4 +6,4 @@ export declare function environmentVariable(key: string, fallback: boolean): boo
 export declare function currentTraceId(): string | undefined;
 export declare function isValidEmail(email: string): boolean;
 export declare function parseDynamicRecipients(dynamicRecipients: string[], fields: FormVersionField[], data: Record<string, unknown>): string[];
-export declare function getDataForDataName(data: Record<string, unknown>, dataName: string | undefined): unknown | null;
+export declare function getDataForDataName(data: Record<string, unknown>, dataName: string | undefined): unknown;

package/dist/utils.js

@@ -69,7 +69,7 @@ const emailAddressDomainPattern = /^(?:[A-z0-9À-ž](?:[A-z0-9À-ž-]{0,61}[A-z0
 // There are many regex patterns to validate email addresses, but they all have flaws and cannot 100% correctly verify
 // every possible email address. For us, it's more important to avoid the majority of typo's instead of catching every
 // invalid email address. We let our email provider handle and false positives (either by their validation or the fact
-// that the email could not be delivered.
+// that the email could not be delivered).
 // ! This code is duplicated in other projects, make sure that changes are made there too (including tests).
 function isValidEmail(email) {
     if (email.length > emailAddressMaxLength) {
@@ -127,7 +127,7 @@ function getDataForDataName(data, dataName) {
     // resolve nested field (like: SEARCH_FIELD.name)
     if (dataName.includes(".")) {
         const parts = dataName.split(".");
-        let nestedData = data[parts[0]];
+        const nestedData = data[parts[0]];
         if (isObject(nestedData)) {
             const nestedKey = parts.slice(1).join(".");
             return getDataForDataName(nestedData, nestedKey);

package/dist/utils.test.js

@@ -2,35 +2,35 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const utils_1 = require("./utils");
 describe("environmentVariable", () => {
-    test("Should throw when environment variable does not exist", async () => {
+    test("Should throw when environment variable does not exist", () => {
         expect(() => (0, utils_1.environmentVariable)("COMMONS_NODEJS_TEST_NON_EXISTING")).toThrow("Missing environment variable 'COMMONS_NODEJS_TEST_NON_EXISTING'");
     });
-    test("Should return fallback value when environment variable does not exist (string)", async () => {
+    test("Should return fallback value when environment variable does not exist (string)", () => {
         expect((0, utils_1.environmentVariable)("COMMONS_NODEJS_TEST_NON_EXISTING", "my-fallback")).toBe("my-fallback");
     });
-    test("Should return fallback value when environment variable does not exist (number)", async () => {
+    test("Should return fallback value when environment variable does not exist (number)", () => {
         expect((0, utils_1.environmentVariable)("COMMONS_NODEJS_TEST_NON_EXISTING", 1)).toBe(1);
     });
-    test("Should return fallback value when environment variable does not exist (boolean)", async () => {
+    test("Should return fallback value when environment variable does not exist (boolean)", () => {
         expect((0, utils_1.environmentVariable)("COMMONS_NODEJS_TEST_NON_EXISTING", false)).toBe(false);
     });
-    test("Should return actual value when environment variable exists (string)", async () => {
+    test("Should return actual value when environment variable exists (string)", () => {
         process.env["COMMONS_NODEJS_TEST_EXISTING"] = "actual-value";
         expect((0, utils_1.environmentVariable)("COMMONS_NODEJS_TEST_EXISTING", "my-fallback")).toBe("actual-value");
     });
-    test("Should return actual value when environment variable exists (number)", async () => {
+    test("Should return actual value when environment variable exists (number)", () => {
         process.env["COMMONS_NODEJS_TEST_EXISTING"] = "2";
         expect((0, utils_1.environmentVariable)("COMMONS_NODEJS_TEST_EXISTING", 1)).toBe(2);
     });
-    test("Should return actual value when environment variable exists (boolean)", async () => {
+    test("Should return actual value when environment variable exists (boolean)", () => {
         process.env["COMMONS_NODEJS_TEST_EXISTING"] = "true";
         expect((0, utils_1.environmentVariable)("COMMONS_NODEJS_TEST_EXISTING", false)).toBe(true);
     });
-    test("should throw when environment variable contains an invalid type (number)", async () => {
+    test("should throw when environment variable contains an invalid type (number)", () => {
         process.env["COMMONS_NODEJS_TEST_EXISTING"] = "not-a-number";
         expect(() => (0, utils_1.environmentVariable)("COMMONS_NODEJS_TEST_EXISTING", 1)).toThrow("Wrong type for environment variable 'COMMONS_NODEJS_TEST_EXISTING'");
     });
-    test("should throw when environment variable contains an invalid type (boolean)", async () => {
+    test("should throw when environment variable contains an invalid type (boolean)", () => {
         process.env["COMMONS_NODEJS_TEST_EXISTING"] = "not-a-boolean";
         expect(() => (0, utils_1.environmentVariable)("COMMONS_NODEJS_TEST_EXISTING", false)).toThrow("Wrong type for environment variable 'COMMONS_NODEJS_TEST_EXISTING'");
     });
@@ -96,7 +96,7 @@ describe("parseDynamicRecipients", () => {
 });
 describe("getDataForDataName", () => {
     test("should return (nested) values in objects based on dataName", () => {
-        let data = {
+        const data = {
             name: "John",
             age: 10,
             address: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@moreapp/common-nodejs",
-  "version": "0.10.2",
+  "version": "0.10.6",
   "license": "UNLICENSED",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -21,7 +21,7 @@
     "prettier": "prettier './**/*.{ts,json,yaml,md,}'",
     "format:check": "yarn prettier --check",
     "format:fix": "yarn prettier --write",
-    "lint:check": "eslint . --ext ts",
+    "lint:check": "eslint src",
     "lint:fix": "yarn lint:check --fix",
     "prepare": "husky"
   },
@@ -32,47 +32,46 @@
     "@google-cloud/logging": "11.2.1",
     "@google-cloud/opentelemetry-cloud-trace-exporter": "3.0.0",
     "@opentelemetry/api": "1.9.0",
-    "@opentelemetry/core": "2.2.0",
-    "@opentelemetry/instrumentation": "0.208.0",
-    "@opentelemetry/instrumentation-dns": "0.52.0",
-    "@opentelemetry/instrumentation-express": "0.57.0",
-    "@opentelemetry/instrumentation-http": "0.208.0",
-    "@opentelemetry/instrumentation-winston": "0.53.0",
-    "@opentelemetry/resources": "2.2.0",
-    "@opentelemetry/sdk-node": "0.208.0",
-    "@opentelemetry/sdk-trace-base": "2.2.0",
-    "@opentelemetry/sdk-trace-node": "2.2.0",
-    "@opentelemetry/semantic-conventions": "1.38.0",
-    "axios": "1.13.2",
+    "@opentelemetry/core": "2.5.0",
+    "@opentelemetry/instrumentation": "0.211.0",
+    "@opentelemetry/instrumentation-dns": "0.54.0",
+    "@opentelemetry/instrumentation-express": "0.59.0",
+    "@opentelemetry/instrumentation-http": "0.211.0",
+    "@opentelemetry/instrumentation-winston": "0.55.0",
+    "@opentelemetry/resources": "2.5.0",
+    "@opentelemetry/sdk-node": "0.211.0",
+    "@opentelemetry/sdk-trace-base": "2.5.0",
+    "@opentelemetry/sdk-trace-node": "2.5.0",
+    "@opentelemetry/semantic-conventions": "1.39.0",
+    "axios": "1.13.4",
     "content-disposition-parser": "1.0.2",
-    "date-and-time": "4.1.2",
+    "date-and-time": "4.2.0",
     "express": "5.2.1",
-    "lodash": "4.17.21",
+    "lodash": "4.17.23",
     "prom-client": "15.1.3",
-    "winston": "3.18.3",
-    "zod": "4.1.13"
+    "winston": "3.19.0",
+    "zod": "4.3.6"
   },
   "devDependencies": {
     "@types/express": "5.0.6",
     "@types/jest": "30.0.0",
-    "@types/lodash": "4.17.21",
-    "@types/node": "24.10.4",
-    "@typescript-eslint/eslint-plugin": "8.49.0",
-    "@typescript-eslint/parser": "8.49.0",
-    "eslint": "8.57.1",
-    "eslint-config-airbnb-typescript": "18.0.0",
+    "@types/lodash": "4.17.23",
+    "@types/node": "24.10.9",
+    "@typescript-eslint/eslint-plugin": "8.54.0",
+    "@typescript-eslint/parser": "8.54.0",
+    "eslint": "9.39.2",
     "eslint-config-prettier": "10.1.8",
-    "eslint-plugin-import": "2.32.0",
-    "eslint-plugin-prettier": "5.5.4",
+    "eslint-plugin-prettier": "5.5.5",
     "husky": "9.1.7",
     "jest": "30.2.0",
     "jest-mock-extended": "4.0.0",
     "lint-staged": "16.2.7",
     "nock": "14.0.10",
-    "prettier": "3.7.4",
+    "prettier": "3.8.1",
     "ts-jest": "29.4.6",
     "ts-node": "10.9.2",
-    "typescript": "5.9.3"
+    "typescript": "5.9.3",
+    "typescript-eslint": "8.54.0"
   },
   "prettier": {
     "printWidth": 100,