@monster-orange/den 0.4.16 → 0.4.18

package/src/ui/server/index.ts

@@ -31,6 +31,8 @@ import { moduleScanner } from "../../shared/test-discovery/module-scanner.js";
 import { resolveFieldEnv } from "../../shared/perf/optional-fields.js";
 import { testRunner } from "../cli/test-runner.js";
 import { discoverRepos } from "../../pillars/smoke/discover.js";
+import { planSuites } from "../../pillars/suites/run.js";
+import { listServicesWithManifests } from "../../shared/manifest/workspace-manifests.js";
 import {
   awsProfileEnv,
   loadAwsProfiles,
@@ -856,6 +858,19 @@ import { heldActions } from "./held-actions.js";
 import type { ApprovalQueue } from "./approvals.js";
 import { processPathRules } from "../cli/onboard-reads.js";
 import { handleAgentRoutes, startAgentUpkeep } from "./agent-routes.js";
+import {
+  lastRunsByRepo,
+  recordRunEnd,
+  recordRunStart,
+  reposOfRun,
+} from "./run-history.js";
+import {
+  CHECK_CONCURRENCY,
+  CHECK_TIMEOUT_MS,
+  runCapped,
+  timedOutText,
+  withTimeout,
+} from "./check-pool.js";
 import {
   handleSessionList,
   handleSessionUpgrade,
@@ -1273,6 +1288,9 @@ function sshUserNow(): string {
   return sshUser(set, osUser);
 }
 
+/** Test runs this server is running now, by id (run-history.ts). */
+const LIVE_RUNS = new Set<string>();
+
 /** The ssh target for this request: the Host it used, minus the port. */
 function sshTargetOf(req: http.IncomingMessage): string {
   return sshTarget(req.headers.host, os.hostname());
@@ -1969,8 +1987,10 @@ async function handleRequest(
   // AG-4a-term's session routes (`/api/sessions/<id>/io`): shell-grade, and
   // an agent's token reaches its own session's only (request-guard). The io
   // is a WebSocket (the server's upgrade handler): a plain GET of it is 426.
-  if (pathname.startsWith("/api/sessions/"))
-    return sendSessionHttp(req, res, pathname);
+  if (pathname.startsWith("/api/sessions/")) {
+    await sendSessionHttp(req, res, pathname);
+    return;
+  }
   // ON-3: an agent's held writes; Allow from the person's browser only.
   if (
     guard.ok &&
@@ -2782,15 +2802,55 @@ async function handleRequest(
     // Streaming emits in completion order, which varies per poll (shell probes
     // finish at wildly different speeds), so without a stable key the client
     // repaints the dots in a different order every 5s.
-    const results = await Promise.all(
-      sortedEntries.map((e, idx) =>
-        checkEntry(e).then((r) => {
-          const ranked = { ...r, openUrl: e.openUrl, links: e.links, idx };
-          onResult?.(ranked);
-          return ranked;
-        }),
+    // 0.4.17: at most CHECK_CONCURRENCY at once, each with at most
+    // CHECK_TIMEOUT_MS: a dead host's check says "timed out after 10 s" and
+    // never holds up the run (check-pool.ts).
+    const late = (e: (typeof sortedEntries)[number]): HealthResult => ({
+      repo: e.repo,
+      service: e.service,
+      label: e.label,
+      ...(e.checkType !== "none"
+        ? healthCheckFields(e.checkType, e.target)
+        : { url: null }),
+      repoPath: e.repoPath,
+      mode: e.mode,
+      isEntrypoint: e.isEntrypoint,
+      ...e.meta,
+      ms: CHECK_TIMEOUT_MS,
+      ok: false,
+      error: timedOutText(CHECK_TIMEOUT_MS),
+    });
+    const run = (e: (typeof sortedEntries)[number], idx: number) =>
+      withTimeout(checkEntry(e), CHECK_TIMEOUT_MS, () => late(e)).then((r) => {
+        const ranked = { ...r, openUrl: e.openUrl, links: e.links, idx };
+        onResult?.(ranked);
+        return ranked;
+      });
+    // Compose and container checks are answered in-process from one shared
+    // docker listing (the call in flight): they start no process, so they
+    // run outside the cap, all at once, and a cycle still lists once.
+    const inProcess = (e: (typeof sortedEntries)[number]) =>
+      (e.checkType === "container" && !!e.container) ||
+      (e.checkType === "shell" && !!e.compose && e.target === e.compose.cmd);
+    const indexed = sortedEntries.map((e, idx) => ({ e, idx }));
+    const results = new Array<HealthResult>(sortedEntries.length);
+    await Promise.all([
+      ...indexed
+        .filter(({ e }) => inProcess(e))
+        .map(({ e, idx }) =>
+          run(e, idx).then((r) => {
+            results[idx] = r;
+          }),
+        ),
+      runCapped(
+        indexed.filter(({ e }) => !inProcess(e)),
+        CHECK_CONCURRENCY,
+        ({ e, idx }) =>
+          run(e, idx).then((r) => {
+            results[idx] = r;
+          }),
       ),
-    );
+    ]);
     return results;
   }
 
@@ -3413,6 +3473,13 @@ async function handleRequest(
     return;
   }
 
+  // ── API: each repo's last test run (0.4.17, run-history.ts) ─────────────────
+  if (pathname === "/api/runs/last") {
+    return sendJson(res, {
+      repos: lastRunsByRepo(getStateDir(), LIVE_RUNS),
+    });
+  }
+
   // ── API: running daemons list ──────────────────────────────────────────────
   if (pathname === "/api/service/daemons") {
     await startupPrune;
@@ -3878,8 +3945,36 @@ async function handleRequest(
 
     const startTime = Date.now();
     let overallExit = 0;
+    // 0.4.17: the server's run history (every browser's runs, kept), which
+    // Workspaces' Last test run reads per repo.
+    // Every run kind that runs a repo's own tests names it, the suites
+    // pillar (`tests:`) and a repo's performance modules included.
+    const tested = await reposOfRun(String(pillar), String(env), modules, {
+      pillarSources: (p) =>
+        collectTestSources(p as Pillar).map((x) => x.repoName),
+      suiteRepos: (e, only) =>
+        planSuites(listServicesWithManifests(), e as Environment, only).run.map(
+          (x) => x.repo,
+        ),
+      perfModules: async () =>
+        (await moduleScanner.scanModules("performance")).map((m) => m.name),
+      repoNames: () => discoverRepos().map((r) => r.repoName),
+    });
+    LIVE_RUNS.add(runId);
+    recordRunStart(getStateDir(), {
+      id: runId,
+      pillar: String(pillar),
+      env: String(env),
+      repos: tested,
+    });
+    let recorded = false;
 
     const finishLifecycle = (exitCode: number, note?: string): void => {
+      if (!recorded) {
+        recorded = true;
+        LIVE_RUNS.delete(runId);
+        recordRunEnd(getStateDir(), runId, exitCode);
+      }
       const dur = formatDuration(Date.now() - startTime);
       const extra = note ? ` · ${note}` : "";
       serverLog(

package/src/ui/server/public/agents-page.js

@@ -147,6 +147,9 @@ const st = {
   signedOut: false,
   open: [],
   panes: new Map(),
+  // AG-18: agents (ws\0id) whose persona change started fresh, for the
+  // pane's line once it follows them.
+  fresh: new Set(),
   timer: null,
   xterm: null,
   csrf: null,
@@ -200,6 +203,7 @@ function writeUrl() {
   else u.searchParams.delete("open");
   u.searchParams.set("layout", st.layout);
   u.searchParams.delete("start");
+  u.searchParams.delete("folder");
   const s = u.searchParams.toString().replace(/%2C/gi, ",");
   history.replaceState(history.state, "", u.pathname + (s ? `?${s}` : ""));
   paintSub();
@@ -326,6 +330,18 @@ function rotationWhy(rot) {
   );
 }
 
+/** The Workspaces page, focused on workspace `ws` (0.4.17). */
+function wsHref(ws) {
+  const nav = window.denShell?.nav?.() ?? [];
+  const base = nav.find((n) => n.id === "local-dev")?.href ?? "/local-dev";
+  return `${base}?ws=${encodeURIComponent(ws)}`;
+}
+
+/** Workspace `ws` as a link to it on Workspaces. */
+function wsLinkHtml(ws) {
+  return `<a class="wslink" href="${esc(wsHref(ws))}" title="${esc(t("ag.goWs", { ws }))}">${esc(ws)}</a>`;
+}
+
 /** Its rotation, when one is due: "ready" or "due" (den#4). */
 function rotationOf(r) {
   if (!r.rotation?.due) return "";
@@ -480,7 +496,7 @@ function paintList() {
     ? groups
         .map(
           (g) =>
-            `<div class="wsg" data-ws="${esc(g.ws)}"><div class="wsh"><span>${esc(g.ws)}</span><span>${esc(g.rows.length)}</span></div>` +
+            `<div class="wsg" data-ws="${esc(g.ws)}"><div class="wsh"><span>${wsLinkHtml(g.ws)}</span><span>${esc(g.rows.length)}</span></div>` +
             g.rows.map(rowHtml).join("") +
             `</div>`,
         )
@@ -616,6 +632,11 @@ function followAgents() {
   }
 }
 
+/** The pane's line for a resume that had nothing to continue (AG-14). */
+function freshLine(p) {
+  p.term?.write(`\x1b[2m${t("ag.freshLine")}\x1b[0m\r\n`);
+}
+
 /** Move pane `p` to session row `row`, where it was. */
 function retarget(p, row) {
   const old = p.id;
@@ -639,6 +660,7 @@ function retarget(p, row) {
   p.term?.write(
     `\r\n\x1b[2m${t("ag.switched", { p: row.persona ?? row.agent })}\x1b[0m\r\n`,
   );
+  if (st.fresh.delete(`${p.agentWs}\u0000${p.agent}`)) freshLine(p);
   paintBar(p);
   paintLayout();
   writeUrl();
@@ -769,6 +791,7 @@ function paintLayout() {
   if (n === 0) {
     box.className = "agempty";
     delete box.dataset.layout;
+    delete box.dataset.ws;
     box.innerHTML = `<div>${esc(t("ag.empty"))}</div>`;
     return;
   }
@@ -776,6 +799,10 @@ function paintLayout() {
   const shown = visibleIds();
   box.className = `agp n${Math.max(1, shown.length)}${layout === "tabs" ? " tabs" : ""}`;
   box.dataset.layout = layout;
+  // The front agent's workspace: ⌘K lists it first (0.4.17).
+  const front = rowOf(st.cur)?.workspace;
+  if (front) box.dataset.ws = front;
+  else delete box.dataset.ws;
   const empty = box.querySelector(":scope > div:not(.pane):not(.agtabs)");
   if (empty) empty.remove();
   let strip = box.querySelector(":scope > .agtabs");
@@ -919,10 +946,14 @@ function paintBar(p) {
   const r = rowOf(p.id);
   const bar = p.el.querySelector(".bar2");
   const name = r ? paneName(r) : p.label || p.id;
-  // AG-4b: the session's name last, when it says more.
-  const where = r
-    ? [r.workspace, r.runtime, sessionExtra(r)].filter(Boolean).join(" · ")
-    : p.workspace || "";
+  // AG-4b: the session's name last, when it says more. The workspace is a
+  // link to it on Workspaces (0.4.17).
+  const ws = r ? r.workspace : p.workspace || "";
+  const rest = r
+    ? [r.runtime, sessionExtra(r)].filter(Boolean).join(" · ")
+    : "";
+  const where =
+    (ws ? wsLinkHtml(ws) : "") + (ws && rest ? " · " : "") + esc(rest);
   const tone = r ? stateTone(r) : p.exited ? "off" : "pending";
   const stop =
     r?.kind === "agent" && (r.state === "running" || r.state === "stopping")
@@ -943,7 +974,7 @@ function paintBar(p) {
       : "";
   bar.innerHTML =
     `<span class="den-dot ${tone}" aria-hidden="true"></span>` +
-    `<b>${esc(name)}</b><span class="where mono">${esc(where)}</span>` +
+    `<b>${esc(name)}</b><span class="where mono">${where}</span>` +
     (r?.tokenRevoked
       ? `<span class="tagx warn" title="${esc(t("ag.revokedTip"))}">${esc(t("ag.revoked"))}</span>`
       : "") +
@@ -1124,21 +1155,41 @@ async function connect(p) {
     }
     p.term?.write(new Uint8Array(e.data));
   };
-  sock.onclose = (e) => {
+  sock.onclose = async (e) => {
     if (p.sock !== sock) return;
     p.sock = null;
     if (p.closed) return;
-    // Refused before it opened: beyond loopback without a session, the
-    // upgrade is 401 (a browser sees only the close).
-    if (!opened) void refresh();
-    const why =
-      e.reason || (opened ? String(e.code) : t("ag.signin", { cli: CLI }));
+    // Refused before it opened: a browser sees only the close, so ask the
+    // route why with a plain GET (0.4.17). "Sign in" only when it's 401.
+    let why = e.reason || String(e.code);
+    if (!opened) {
+      void refresh();
+      why = await refusalReason(p.id);
+      if (p.closed || p.sock) return;
+    }
     p.term?.write(`\r\n${t("ag.lost", { why })}\r\n`);
     p.lost = true;
     paintBar(p);
   };
 }
 
+/** Why session `id`'s io upgrade was refused, in words for its pane. */
+async function refusalReason(id) {
+  try {
+    const r = await fetch(`/api/sessions/${encodeURIComponent(id)}/io`, {
+      headers: { accept: "application/json" },
+      credentials: "same-origin",
+    });
+    if (r.status === 401) return t("ag.signin", { cli: CLI });
+    const b = await r.json().catch(() => null);
+    if (r.status === 426) return t("ag.refusedUnknown");
+    if (typeof b?.error === "string" && b.error) return b.error;
+    return t("ag.refusedStatus", { status: r.status });
+  } catch {
+    return t("ag.refusedUnknown");
+  }
+}
+
 // ── links and keys in a pane (AG-4b) ───────────────────────────────────
 
 /** What Shift+Enter sends to a pane's session (a plain session: Enter). */
@@ -2051,8 +2102,16 @@ function dialogMode(bring, change = null) {
   );
   $d("#ag-go").textContent = goLabel();
   $d("#ag-conv-f").hidden = !bring;
+  // 0.4.18: a new agent's folder (Start agent here fills it).
+  for (const id of ["#ag-folder-l", "#ag-folder-h"]) {
+    const el = $d(id);
+    if (el) el.hidden = !!(bring || change);
+  }
 }
 
+/** 0.4.18: Start agent here (the service panel): ?start=1&ws=…&folder=…. */
+let startPrefill = null;
+
 /** The submit button's words for the dialog's mode. */
 function goLabel() {
   return t(sd.change ? "ag.pc.go" : sd.bring ? "ag.bring.go" : "ag.go");
@@ -2074,12 +2133,18 @@ async function openStart(bring = false, change = null) {
   const dlg = $d("#ag-dlg");
   if (!dlg || dlg.open) return;
   dialogMode(bring, change);
+  const pre = change || bring ? null : startPrefill;
+  startPrefill = null;
   const shown = change ? [change.workspace] : viewWorkspaces();
+  if (pre?.ws && !shown.includes(pre.ws)) shown.push(pre.ws);
   const wsSel = $d("#ag-ws");
   wsSel.innerHTML = shown
     .map((w) => `<option value="${esc(w)}">${esc(w)}</option>`)
     .join("");
   wsSel.disabled = shown.length <= 1;
+  if (pre?.ws) wsSel.value = pre.ws;
+  const folder = $d("#ag-folder");
+  if (folder) folder.value = pre?.folder ?? "";
   sd.f = { q: "", cat: "", src: "" };
   sd.det = false;
   sd.what = false;
@@ -2120,6 +2185,8 @@ function startBody() {
   if (task) body.instruction = task;
   const name = $d("#ag-name").value.trim();
   if (name) body.name = name;
+  const folder = $d("#ag-folder")?.value.trim();
+  if (folder) body.folder = folder;
   return body;
 }
 
@@ -2306,11 +2373,20 @@ async function submitPersonaChange(when) {
       body,
     );
     window.denShell?.toast?.(
-      t(r?.pending ? "ag.pc.pending" : "ag.pc.done", {
-        id: ch.name,
-        p: personaName(p),
-      }),
+      t(
+        r?.pending ? "ag.pc.pending" : r?.fresh ? "ag.pc.fresh" : "ag.pc.done",
+        { id: ch.name, p: personaName(p) },
+      ),
     );
+    // Never prompted: nothing was resumed. Its pane says so, now if it
+    // has already moved to the new session, else when it does.
+    if (r?.fresh) {
+      const pane = [...st.panes.values()].find(
+        (q) => q.agent === ch.id && q.agentWs === ch.workspace,
+      );
+      if (pane && pane.id === r.agent?.sessionId) freshLine(pane);
+      else st.fresh.add(`${ch.workspace}\u0000${ch.id}`);
+    }
     for (const w of r?.warnings ?? []) window.denShell?.toast?.(w);
     dlg.close?.();
     await refresh();
@@ -2569,6 +2645,8 @@ function translateStatic(root) {
   set("#ag-what-p", "pe.what");
   set("#ag-task-t", "ag.new.task");
   set("#ag-name-t", "ag.new.name");
+  set("#ag-folder-t", "ag.new.folder");
+  set("#ag-folder-h", "ag.new.folderHelp");
   set("#ag-adv-s", "ag.new.adv");
   set("#ag-note", "ag.new.note");
   const task = root.querySelector("#ag-task");
@@ -2600,6 +2678,10 @@ export async function mountAgentsPage(root) {
   const wanted = openFromUrl(location.search);
   const linked = layoutFromUrl(location.search);
   const startAsked = new URLSearchParams(location.search).get("start") === "1";
+  if (startAsked) {
+    const q = new URLSearchParams(location.search);
+    startPrefill = { ws: q.get("ws") || "", folder: q.get("folder") || "" };
+  }
 
   root.querySelector("#agl").addEventListener("click", (e) => {
     const act = e.target.closest("button[data-act]");

package/src/ui/server/public/agents.html

@@ -412,6 +412,15 @@
         flex: none;
         white-space: nowrap;
       }
+      .wslink {
+        color: inherit;
+        text-decoration: none;
+      }
+      .wslink:hover,
+      .wslink:focus-visible {
+        color: var(--text);
+        text-decoration: underline;
+      }
       .pane .bar2 .where {
         flex: 0 1 auto;
         min-width: 0;
@@ -730,6 +739,19 @@
             ><span id="ag-name-t">Name (optional)</span>
             <input id="ag-name" maxlength="40" autocomplete="off" />
           </label>
+          <label class="fld" id="ag-folder-l"
+            ><span id="ag-folder-t">Folder (optional)</span>
+            <input
+              id="ag-folder"
+              maxlength="4096"
+              autocomplete="off"
+              spellcheck="false"
+              aria-describedby="ag-folder-h"
+            />
+          </label>
+          <p class="helpl" id="ag-folder-h">
+            Inside the workspace's folder. Empty: the workspace's own.
+          </p>
           <p class="helpl" id="ag-as" role="status"></p>
           <details id="ag-adv">
             <summary id="ag-adv-s">Advanced: model and permissions</summary>