@monque/core 1.5.0 → 1.5.2

package/dist/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @monque/core
 
+## 1.5.2
+
+### Patch Changes
+
+- [#227](https://github.com/ueberBrot/monque/pull/227) [`e9208ca`](https://github.com/ueberBrot/monque/commit/e9208ca5c985d84d023161560d5d3ba195394fe1) Thanks [@ueberBrot](https://github.com/ueberBrot)! - Prevent change stream reconnection attempts from running after the scheduler stops. This clears pending reconnect timers during shutdown and adds coverage for the stop-during-backoff scenario.
+
+## 1.5.1
+
+### Patch Changes
+
+- [#211](https://github.com/ueberBrot/monque/pull/211) [`7181215`](https://github.com/ueberBrot/monque/commit/7181215abac2b5cd231c63f10bf718f0314cc09f) Thanks [@ueberBrot](https://github.com/ueberBrot)! - Close shutdown race condition window by stopping timers before setting isRunning flag
+
 ## 1.5.0
 
 ### Minor Changes

package/dist/index.cjs

@@ -1,9 +1,8 @@
-Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+Object.defineProperty(exports, Symbol.toStringTag, { value: "Module" });
 let mongodb = require("mongodb");
 let cron_parser = require("cron-parser");
 let node_crypto = require("node:crypto");
 let node_events = require("node:events");
-
 //#region src/jobs/document-to-persisted-job.ts
 /**
 * Convert a raw MongoDB document to a strongly-typed {@link PersistedJob}.
@@ -36,7 +35,6 @@ function documentToPersistedJob(doc) {
 	if (doc["uniqueKey"] !== void 0) job.uniqueKey = doc["uniqueKey"];
 	return job;
 }
-
 //#endregion
 //#region src/jobs/types.ts
 /**
@@ -75,7 +73,6 @@ const CursorDirection = {
 	FORWARD: "forward",
 	BACKWARD: "backward"
 };
-
 //#endregion
 //#region src/jobs/guards.ts
 /**
@@ -288,7 +285,6 @@ function isCancelledJob(job) {
 function isRecurringJob(job) {
 	return job.repeatInterval !== void 0 && job.repeatInterval !== null;
 }
-
 //#endregion
 //#region src/shared/errors.ts
 /**
@@ -506,7 +502,6 @@ var PayloadTooLargeError = class PayloadTooLargeError extends MonqueError {
 		if (Error.captureStackTrace) Error.captureStackTrace(this, PayloadTooLargeError);
 	}
 };
-
 //#endregion
 //#region src/shared/utils/backoff.ts
 /**
@@ -548,7 +543,7 @@ const DEFAULT_MAX_BACKOFF_DELAY = 1440 * 60 * 1e3;
 * ```
 */
 function calculateBackoff(failCount, baseInterval = DEFAULT_BASE_INTERVAL, maxDelay) {
-	const effectiveMaxDelay = maxDelay ?? DEFAULT_MAX_BACKOFF_DELAY;
+	const effectiveMaxDelay = maxDelay ?? 864e5;
 	let delay = 2 ** failCount * baseInterval;
 	if (delay > effectiveMaxDelay) delay = effectiveMaxDelay;
 	return new Date(Date.now() + delay);
@@ -562,12 +557,11 @@ function calculateBackoff(failCount, baseInterval = DEFAULT_BASE_INTERVAL, maxDe
 * @returns The delay in milliseconds
 */
 function calculateBackoffDelay(failCount, baseInterval = DEFAULT_BASE_INTERVAL, maxDelay) {
-	const effectiveMaxDelay = maxDelay ?? DEFAULT_MAX_BACKOFF_DELAY;
+	const effectiveMaxDelay = maxDelay ?? 864e5;
 	let delay = 2 ** failCount * baseInterval;
 	if (delay > effectiveMaxDelay) delay = effectiveMaxDelay;
 	return delay;
 }
-
 //#endregion
 //#region src/shared/utils/cron.ts
 /**
@@ -621,7 +615,6 @@ function validateCronExpression(expression) {
 function handleCronParseError(expression, error) {
 	throw new InvalidCronError(expression, `Invalid cron expression "${expression}": ${error instanceof Error ? error.message : "Unknown parsing error"}. Expected 5-field format: "minute hour day-of-month month day-of-week" or predefined expression (e.g. @daily). Example: "0 9 * * 1" (every Monday at 9am)`);
 }
-
 //#endregion
 //#region src/shared/utils/error.ts
 /**
@@ -654,7 +647,6 @@ function toError(value) {
 		return /* @__PURE__ */ new Error(`Unserializable value (${detail})`);
 	}
 }
-
 //#endregion
 //#region src/scheduler/helpers.ts
 /**
@@ -720,7 +712,6 @@ function decodeCursor(cursor) {
 		throw new InvalidCursorError("Invalid cursor payload");
 	}
 }
-
 //#endregion
 //#region src/scheduler/services/change-stream-handler.ts
 /**
@@ -764,6 +755,7 @@ var ChangeStreamHandler = class {
 	*/
 	setup() {
 		if (!this.ctx.isRunning()) return;
+		this.clearReconnectTimer();
 		try {
 			this.changeStream = this.ctx.collection.watch([{ $match: { $or: [{ operationType: "insert" }, {
 				operationType: "update",
@@ -823,30 +815,35 @@ var ChangeStreamHandler = class {
 		this.reconnectAttempts++;
 		if (this.reconnectAttempts > this.maxReconnectAttempts) {
 			this.usingChangeStreams = false;
-			if (this.reconnectTimer) {
-				clearTimeout(this.reconnectTimer);
-				this.reconnectTimer = null;
-			}
-			if (this.changeStream) {
-				this.changeStream.close().catch(() => {});
-				this.changeStream = null;
-			}
+			this.clearReconnectTimer();
+			this.closeChangeStream();
 			this.ctx.emit("changestream:fallback", { reason: `Exhausted ${this.maxReconnectAttempts} reconnection attempts: ${error.message}` });
 			return;
 		}
 		const delay = 2 ** (this.reconnectAttempts - 1) * 1e3;
-		if (this.reconnectTimer) clearTimeout(this.reconnectTimer);
+		this.clearReconnectTimer();
+		if (!this.ctx.isRunning()) return;
 		this.reconnectTimer = setTimeout(() => {
-			this.reconnectTimer = null;
-			if (this.ctx.isRunning()) {
-				if (this.changeStream) {
-					this.changeStream.close().catch(() => {});
-					this.changeStream = null;
-				}
-				this.setup();
-			}
+			this.clearReconnectTimer();
+			this.reconnect();
 		}, delay);
 	}
+	reconnect() {
+		if (!this.ctx.isRunning()) return;
+		this.closeChangeStream();
+		if (!this.ctx.isRunning()) return;
+		this.setup();
+	}
+	clearReconnectTimer() {
+		if (!this.reconnectTimer) return;
+		clearTimeout(this.reconnectTimer);
+		this.reconnectTimer = null;
+	}
+	closeChangeStream() {
+		if (!this.changeStream) return;
+		this.changeStream.close().catch(() => {});
+		this.changeStream = null;
+	}
 	/**
 	* Close the change stream cursor and emit closed event.
 	*/
@@ -855,10 +852,7 @@ var ChangeStreamHandler = class {
 			clearTimeout(this.debounceTimer);
 			this.debounceTimer = null;
 		}
-		if (this.reconnectTimer) {
-			clearTimeout(this.reconnectTimer);
-			this.reconnectTimer = null;
-		}
+		this.clearReconnectTimer();
 		if (this.changeStream) {
 			try {
 				await this.changeStream.close();
@@ -876,7 +870,6 @@ var ChangeStreamHandler = class {
 		return this.usingChangeStreams;
 	}
 };
-
 //#endregion
 //#region src/scheduler/services/job-manager.ts
 /**
@@ -1169,7 +1162,6 @@ var JobManager = class {
 		}
 	}
 };
-
 //#endregion
 //#region src/scheduler/services/job-processor.ts
 /**
@@ -1474,7 +1466,6 @@ var JobProcessor = class {
 		} });
 	}
 };
-
 //#endregion
 //#region src/scheduler/services/job-query.ts
 /**
@@ -1778,7 +1769,6 @@ var JobQueryService = class JobQueryService {
 		}
 	}
 };
-
 //#endregion
 //#region src/scheduler/services/job-scheduler.ts
 /**
@@ -2009,7 +1999,6 @@ var JobScheduler = class {
 		}
 	}
 };
-
 //#endregion
 //#region src/scheduler/services/lifecycle-manager.ts
 /**
@@ -2117,7 +2106,6 @@ var LifecycleManager = class {
 		if (deletions.length > 0) await Promise.all(deletions);
 	}
 };
-
 //#endregion
 //#region src/scheduler/monque.ts
 /**
@@ -3039,12 +3027,12 @@ var Monque = class extends node_events.EventEmitter {
 	*/
 	async stop() {
 		if (!this.isRunning) return;
+		this.lifecycleManager.stopTimers();
 		this.isRunning = false;
 		this._query?.clearStatsCache();
 		try {
 			await this.changeStreamHandler.close();
 		} catch {}
-		this.lifecycleManager.stopTimers();
 		if (this.getActiveJobs().length === 0) return;
 		let checkInterval;
 		const waitForJobs = new Promise((resolve) => {
@@ -3166,7 +3154,6 @@ var Monque = class extends node_events.EventEmitter {
 		return super.off(event, listener);
 	}
 };
-
 //#endregion
 exports.AggregationTimeoutError = AggregationTimeoutError;
 exports.ConnectionError = ConnectionError;
@@ -3194,4 +3181,5 @@ exports.isProcessingJob = isProcessingJob;
 exports.isRecurringJob = isRecurringJob;
 exports.isValidJobStatus = isValidJobStatus;
 exports.validateCronExpression = validateCronExpression;
+
 //# sourceMappingURL=index.cjs.map