@monotykamary/pi-supervisor 0.5.9

package/tests/subagent-detector.test.ts

@@ -0,0 +1,191 @@
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
+import { exec } from 'node:child_process';
+import { checkChildPiProcesses, waitForSubagents } from '../src/subagent-detector.js';
+
+// Mock child_process
+vi.mock('node:child_process', () => ({
+  exec: vi.fn(),
+}));
+
+describe('subagent-detector', () => {
+  const mockExec = vi.mocked(exec);
+
+  beforeEach(() => {
+    vi.clearAllMocks();
+  });
+
+  afterEach(() => {
+    vi.restoreAllMocks();
+  });
+
+  describe('checkChildPiProcesses', () => {
+    it('returns no subagents when ps output is empty', async () => {
+      mockExec.mockImplementation((cmd, callback) => {
+        callback(null, { stdout: '', stderr: '' }, null as any);
+        return {} as any;
+      });
+
+      const result = await checkChildPiProcesses();
+
+      expect(result.hasActiveSubagents).toBe(false);
+      expect(result.count).toBe(0);
+      expect(result.pids).toEqual([]);
+    });
+
+    it('detects child pi processes', async () => {
+      const parentPid = process.pid;
+      mockExec.mockImplementation((cmd, callback) => {
+        callback(
+          null,
+          {
+            stdout: `${parentPid} 12345 pi\n${parentPid} 12346 pi\n99999 12347 other`,
+            stderr: '',
+          },
+          null as any
+        );
+        return {} as any;
+      });
+
+      const result = await checkChildPiProcesses();
+
+      expect(result.hasActiveSubagents).toBe(true);
+      expect(result.count).toBe(2);
+      expect(result.pids).toContain(12345);
+      expect(result.pids).toContain(12346);
+      expect(result.pids).not.toContain(12347);
+    });
+
+    it('ignores non-pi processes', async () => {
+      const parentPid = process.pid;
+      mockExec.mockImplementation((cmd, callback) => {
+        callback(
+          null,
+          {
+            stdout: `${parentPid} 12345 node\n${parentPid} 12346 bash`,
+            stderr: '',
+          },
+          null as any
+        );
+        return {} as any;
+      });
+
+      const result = await checkChildPiProcesses();
+
+      expect(result.hasActiveSubagents).toBe(false);
+      expect(result.count).toBe(0);
+    });
+
+    it('ignores pi processes from other parents', async () => {
+      mockExec.mockImplementation((cmd, callback) => {
+        callback(
+          null,
+          {
+            stdout: '99999 12345 pi\n99999 12346 pi',
+            stderr: '',
+          },
+          null as any
+        );
+        return {} as any;
+      });
+
+      const result = await checkChildPiProcesses();
+
+      expect(result.hasActiveSubagents).toBe(false);
+      expect(result.count).toBe(0);
+    });
+
+    it('handles exec errors gracefully', async () => {
+      mockExec.mockImplementation((cmd, callback) => {
+        callback(new Error('ps command failed'), { stdout: '', stderr: '' }, null as any);
+        return {} as any;
+      });
+
+      const result = await checkChildPiProcesses();
+
+      expect(result.hasActiveSubagents).toBe(false);
+      expect(result.count).toBe(0);
+      expect(result.pids).toEqual([]);
+    });
+
+    it('handles malformed ps output', async () => {
+      mockExec.mockImplementation((cmd, callback) => {
+        callback(
+          null,
+          {
+            stdout: 'garbage line\n  \n123 abc def extra',
+            stderr: '',
+          },
+          null as any
+        );
+        return {} as any;
+      });
+
+      const result = await checkChildPiProcesses();
+
+      expect(result.hasActiveSubagents).toBe(false);
+      expect(result.count).toBe(0);
+    });
+  });
+
+  describe('waitForSubagents', () => {
+    it('returns immediately when no subagents', async () => {
+      mockExec.mockImplementation((cmd, callback) => {
+        callback(null, { stdout: '', stderr: '' }, null as any);
+        return {} as any;
+      });
+
+      const result = await waitForSubagents(100, 1000);
+
+      expect(result.completed).toBe(true);
+      expect(result.finalStatus.hasActiveSubagents).toBe(false);
+    });
+
+    it('waits for subagents to complete', async () => {
+      const parentPid = process.pid;
+      let calls = 0;
+      mockExec.mockImplementation((cmd, callback) => {
+        calls++;
+        if (calls < 3) {
+          callback(
+            null,
+            {
+              stdout: `${parentPid} 12345 pi`,
+              stderr: '',
+            },
+            null as any
+          );
+        } else {
+          callback(null, { stdout: '', stderr: '' }, null as any);
+        }
+        return {} as any;
+      });
+
+      const result = await waitForSubagents(50, 1000);
+
+      expect(result.completed).toBe(true);
+      expect(result.finalStatus.hasActiveSubagents).toBe(false);
+      expect(calls).toBe(3);
+    });
+
+    it("times out if subagents don't complete", async () => {
+      const parentPid = process.pid;
+      mockExec.mockImplementation((cmd, callback) => {
+        callback(
+          null,
+          {
+            stdout: `${parentPid} 12345 pi`,
+            stderr: '',
+          },
+          null as any
+        );
+        return {} as any;
+      });
+
+      const result = await waitForSubagents(50, 100);
+
+      expect(result.completed).toBe(false);
+      expect(result.finalStatus.hasActiveSubagents).toBe(true);
+      expect(result.finalStatus.count).toBe(1);
+    });
+  });
+});

package/tests/supervise-command.test.ts

@@ -0,0 +1,363 @@
+import { describe, expect, it, vi, beforeEach } from 'vitest';
+import { SupervisorStateManager } from '../src/state/manager.js';
+
+// Mock dependencies
+vi.mock('../src/core/analyzer.js', () => ({
+  analyze: vi.fn(),
+}));
+
+vi.mock('../src/core/inference.js', () => ({
+  inferOutcome: vi.fn(),
+}));
+
+vi.mock('../src/core/prompt-loader.js', () => ({
+  loadSystemPrompt: vi.fn().mockReturnValue({ prompt: 'test prompt', source: 'built-in' }),
+}));
+
+vi.mock('../src/ui/renderer.js', () => ({
+  updateUI: vi.fn(),
+  toggleWidget: vi.fn(),
+}));
+
+vi.mock('../src/ui/model-picker.js', () => ({
+  pickModel: vi.fn(),
+}));
+
+vi.mock('../src/global-config.js', () => ({
+  loadGlobalModel: vi.fn().mockReturnValue(null),
+}));
+
+vi.mock('../src/session/client.js', () => ({
+  disposeSession: vi.fn(),
+}));
+
+vi.mock('../src/subagent-detector.js', () => ({
+  checkChildPiProcesses: vi.fn().mockResolvedValue({ hasActiveSubagents: false, count: 0 }),
+  waitForSubagents: vi
+    .fn()
+    .mockResolvedValue({ completed: true, finalStatus: { hasActiveSubagents: false, count: 0 } }),
+}));
+
+import { updateUI } from '../src/ui/renderer.js';
+import { pickModel } from '../src/ui/model-picker.js';
+import { loadGlobalModel } from '../src/global-config.js';
+import { inferOutcome } from '../src/core/inference.js';
+
+describe('SupervisorStateManager - goal append feature', () => {
+  function createMockApi() {
+    return {
+      appendEntry: vi.fn(),
+      on: vi.fn(),
+      registerCommand: vi.fn(),
+      registerTool: vi.fn(),
+      sendUserMessage: vi.fn(),
+      sendMessage: vi.fn(),
+      events: { emit: vi.fn(), on: vi.fn() },
+    } as any;
+  }
+
+  it('appends to existing goal when supervision is already active', () => {
+    const api = createMockApi();
+    const state = new SupervisorStateManager(api);
+
+    state.start('Initial goal', 'anthropic', 'claude-haiku');
+    expect(state.getState()!.outcome).toBe('Initial goal');
+
+    const trimmed = 'Additional requirement';
+    const existing = state.getState();
+    const appendedOutcome = `${existing!.outcome}. Additionally: ${trimmed}`;
+    state.updateOutcome(appendedOutcome);
+
+    expect(state.getState()!.outcome).toBe('Initial goal. Additionally: Additional requirement');
+    expect(api.appendEntry).toHaveBeenCalledTimes(2);
+  });
+
+  it('persists appended goal to session', () => {
+    const api = createMockApi();
+    const state = new SupervisorStateManager(api);
+
+    state.start('First part', 'anthropic', 'claude-haiku');
+    state.updateOutcome('First part. Additionally: Second part');
+
+    const lastCall = api.appendEntry.mock.calls[api.appendEntry.mock.calls.length - 1];
+    expect(lastCall[1].outcome).toBe('First part. Additionally: Second part');
+  });
+
+  it('maintains active state when appending', () => {
+    const api = createMockApi();
+    const state = new SupervisorStateManager(api);
+
+    state.start('Original', 'anthropic', 'claude-haiku');
+    expect(state.isActive()).toBe(true);
+
+    state.updateOutcome('Original. Additionally: More');
+    expect(state.isActive()).toBe(true);
+  });
+
+  it('keeps other state intact when appending', () => {
+    const api = createMockApi();
+    const state = new SupervisorStateManager(api);
+
+    state.start('Goal', 'openai', 'gpt-4o');
+    state.addIntervention({
+      message: 'Focus',
+      reasoning: 'Test',
+      timestamp: Date.now(),
+    });
+
+    const originalProvider = state.getState()!.provider;
+    const originalModelId = state.getState()!.modelId;
+    const originalInterventions = state.getState()!.interventions.length;
+
+    state.updateOutcome('Goal. Additionally: Extended');
+
+    expect(state.getState()!.provider).toBe(originalProvider);
+    expect(state.getState()!.modelId).toBe(originalModelId);
+    expect(state.getState()!.interventions.length).toBe(originalInterventions);
+  });
+});
+
+describe('Supervise command kickstart behavior', () => {
+  function createMockCommandContext(overrides: { isIdle?: boolean; hasUI?: boolean } = {}) {
+    return {
+      ui: {
+        notify: vi.fn(),
+        select: vi.fn(),
+        input: vi.fn(),
+        confirm: vi.fn(),
+        setStatus: vi.fn(),
+        setWorkingMessage: vi.fn(),
+        setWidget: vi.fn(),
+        setFooter: vi.fn(),
+        setHeader: vi.fn(),
+        custom: vi.fn(),
+        pasteToEditor: vi.fn(),
+        setEditorText: vi.fn(),
+        getEditorText: vi.fn().mockReturnValue(''),
+        editor: vi.fn(),
+        setEditorComponent: vi.fn(),
+        theme: {},
+        getAllThemes: vi.fn().mockReturnValue([]),
+        getTheme: vi.fn(),
+        setTheme: vi.fn().mockReturnValue({ success: true }),
+        getToolsExpanded: vi.fn().mockReturnValue(false),
+        setToolsExpanded: vi.fn(),
+        onTerminalInput: vi.fn().mockReturnValue(() => {}),
+      },
+      hasUI: overrides.hasUI ?? true,
+      cwd: '/test',
+      sessionManager: {
+        getBranch: vi.fn().mockReturnValue([]),
+      },
+      modelRegistry: {
+        getApiKeyForProvider: vi.fn().mockResolvedValue('test-key'),
+      },
+      model: {
+        provider: 'anthropic',
+        id: 'claude-haiku',
+      },
+      isIdle: vi.fn().mockReturnValue(overrides.isIdle ?? true),
+      abort: vi.fn(),
+      hasPendingMessages: vi.fn().mockReturnValue(false),
+      shutdown: vi.fn(),
+      getContextUsage: vi.fn(),
+      compact: vi.fn(),
+      getSystemPrompt: vi.fn().mockReturnValue('test system prompt'),
+    } as any;
+  }
+
+  function createMockExtensionAPI() {
+    const sendUserMessage = vi.fn();
+    return {
+      appendEntry: vi.fn(),
+      on: vi.fn(),
+      registerCommand: vi.fn(),
+      registerTool: vi.fn(),
+      sendUserMessage,
+      sendMessage: vi.fn(),
+      events: { emit: vi.fn(), on: vi.fn() },
+    } as any;
+  }
+
+  beforeEach(() => {
+    vi.clearAllMocks();
+  });
+
+  describe('when agent is idle', () => {
+    it('should kickstart with goal when running explicit /supervise <outcome>', async () => {
+      const pi = createMockExtensionAPI();
+      const ctx = createMockCommandContext({ isIdle: true });
+      const state = new SupervisorStateManager(pi);
+
+      const trimmed = 'Implement JWT authentication';
+      state.start(trimmed, 'anthropic', 'claude-haiku');
+
+      if (ctx.isIdle()) {
+        pi.sendUserMessage(`Please start working on this goal: ${trimmed}`, {
+          deliverAs: 'followUp',
+        });
+      }
+
+      expect(pi.sendUserMessage).toHaveBeenCalledTimes(1);
+      expect(pi.sendUserMessage).toHaveBeenCalledWith(
+        'Please start working on this goal: Implement JWT authentication',
+        { deliverAs: 'followUp' }
+      );
+    });
+
+    it('should kickstart with inferred goal when agent is idle', async () => {
+      vi.mocked(inferOutcome).mockResolvedValue('Fix the memory leak in handler');
+
+      const pi = createMockExtensionAPI();
+      const ctx = createMockCommandContext({ isIdle: true });
+      const state = new SupervisorStateManager(pi);
+
+      const inferred = 'Fix the memory leak in handler';
+      state.start(inferred, 'anthropic', 'claude-haiku');
+
+      if (ctx.isIdle()) {
+        pi.sendUserMessage(`Please start working on this goal: ${inferred}`, {
+          deliverAs: 'followUp',
+        });
+      }
+
+      expect(pi.sendUserMessage).toHaveBeenCalledWith(
+        'Please start working on this goal: Fix the memory leak in handler',
+        { deliverAs: 'followUp' }
+      );
+    });
+
+    it('should kickstart when tool initiates supervision', async () => {
+      const pi = createMockExtensionAPI();
+      const ctx = createMockCommandContext({ isIdle: true });
+      const state = new SupervisorStateManager(pi);
+
+      const outcome = 'Refactor database layer';
+      state.start(outcome, 'anthropic', 'claude-haiku');
+
+      if (ctx.isIdle()) {
+        pi.sendUserMessage(`Please start working on this goal: ${outcome}`, {
+          deliverAs: 'followUp',
+        });
+      }
+
+      expect(pi.sendUserMessage).toHaveBeenCalledWith(
+        'Please start working on this goal: Refactor database layer',
+        { deliverAs: 'followUp' }
+      );
+    });
+  });
+
+  describe('when agent is busy', () => {
+    it('should NOT kickstart when running /supervise and agent is working', async () => {
+      const pi = createMockExtensionAPI();
+      const ctx = createMockCommandContext({ isIdle: false });
+      const state = new SupervisorStateManager(pi);
+
+      const trimmed = 'Implement feature X';
+      state.start(trimmed, 'anthropic', 'claude-haiku');
+
+      if (ctx.isIdle()) {
+        pi.sendUserMessage(`Please start working on this goal: ${trimmed}`, {
+          deliverAs: 'followUp',
+        });
+      }
+
+      expect(pi.sendUserMessage).not.toHaveBeenCalled();
+    });
+
+    it('should NOT kickstart when tool initiates supervision but agent is busy', async () => {
+      const pi = createMockExtensionAPI();
+      const ctx = createMockCommandContext({ isIdle: false });
+      const state = new SupervisorStateManager(pi);
+
+      const outcome = 'Add test coverage';
+      state.start(outcome, 'anthropic', 'claude-haiku');
+
+      if (ctx.isIdle()) {
+        pi.sendUserMessage(`Please start working on this goal: ${outcome}`, {
+          deliverAs: 'followUp',
+        });
+      }
+
+      expect(pi.sendUserMessage).not.toHaveBeenCalled();
+    });
+  });
+
+  describe('append behavior', () => {
+    it('should NOT kickstart when appending to existing supervision', async () => {
+      const pi = createMockExtensionAPI();
+      const ctx = createMockCommandContext({ isIdle: true });
+      const state = new SupervisorStateManager(pi);
+
+      state.start('Original goal', 'anthropic', 'claude-haiku');
+
+      pi.sendUserMessage.mockClear();
+
+      const trimmed = 'Additional requirement';
+      const existing = state.getState();
+      const appendedOutcome = `${existing!.outcome}. Additionally: ${trimmed}`;
+      state.updateOutcome(appendedOutcome);
+
+      expect(pi.sendUserMessage).not.toHaveBeenCalled();
+      expect(state.getState()!.outcome).toBe('Original goal. Additionally: Additional requirement');
+    });
+
+    it('should notify user when appending to goal', async () => {
+      const pi = createMockExtensionAPI();
+      const ctx = createMockCommandContext({ isIdle: true });
+      const state = new SupervisorStateManager(pi);
+
+      state.start('Original', 'anthropic', 'claude-haiku');
+
+      const trimmed = 'More work';
+      const existing = state.getState();
+      const appendedOutcome = `${existing!.outcome}. Additionally: ${trimmed}`;
+      state.updateOutcome(appendedOutcome);
+
+      expect(state.getState()!.outcome).toContain('Additionally: More work');
+    });
+  });
+
+  describe('edge cases', () => {
+    it('should handle kickstart with very long goals', async () => {
+      const pi = createMockExtensionAPI();
+      const ctx = createMockCommandContext({ isIdle: true });
+      const state = new SupervisorStateManager(pi);
+
+      const longGoal = 'A'.repeat(200);
+      state.start(longGoal, 'anthropic', 'claude-haiku');
+
+      if (ctx.isIdle()) {
+        pi.sendUserMessage(`Please start working on this goal: ${longGoal}`, {
+          deliverAs: 'followUp',
+        });
+      }
+
+      expect(pi.sendUserMessage).toHaveBeenCalledWith(
+        `Please start working on this goal: ${longGoal}`,
+        { deliverAs: 'followUp' }
+      );
+    });
+
+    it('should handle empty isIdle() result gracefully', async () => {
+      const pi = createMockExtensionAPI();
+      const ctx = {
+        ...createMockCommandContext(),
+        isIdle: vi.fn().mockReturnValue(undefined),
+      };
+      const state = new SupervisorStateManager(pi);
+
+      const trimmed = 'Test goal';
+      state.start(trimmed, 'anthropic', 'claude-haiku');
+
+      if (ctx.isIdle()) {
+        pi.sendUserMessage(`Please start working on this goal: ${trimmed}`, {
+          deliverAs: 'followUp',
+        });
+      }
+
+      expect(pi.sendUserMessage).not.toHaveBeenCalled();
+    });
+  });
+});